[Lldb-commits] [PATCH] D47285: Add PPC64le support information

alexandreyy added a comment. In https://reviews.llvm.org/D47285#1110260, @alexandreyy wrote: > In https://reviews.llvm.org/D47285#1110232, @clayborg wrote: > > > Is PPC64le only supported? no PPC64? > > > Only PPC64le is supported. Thanks @clayborg @labath Could you commit this patch? https:

[Lldb-commits] [PATCH] D47285: Add PPC64le support information

alexandreyy added a comment. In https://reviews.llvm.org/D47285#1110232, @clayborg wrote: > Is PPC64le only supported? no PPC64? Only PPC64le is supported. https://reviews.llvm.org/D47285 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D47285: Add PPC64le support information

alexandreyy created this revision. alexandreyy added a reviewer: clayborg. Add PPC64le support information on LLDB site https://reviews.llvm.org/D47285 Files: www/features.html www/index.html www/status.html Index: www/status.html

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

alexandreyy added a comment. Hi @labath . Could you please commit this patch? https://reviews.llvm.org/D44472 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

alexandreyy added a comment. In https://reviews.llvm.org/D44472#1039812, @labath wrote: > I like what you did with the test. Originally, I wanted to just compare the > raw memory contents, but this keeps it more inline with the spirit of the > original test. I have just one question about the l

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

alexandreyy updated this revision to Diff 138699. alexandreyy added a comment. The test would pass if one of the disassembled code had more instructions. That should be considered. I added the assertion for that. Thanks @labath . https://reviews.llvm.org/D44472 Files: packages/Python/lldbsuit

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

alexandreyy added a comment. In https://reviews.llvm.org/D44472#1038656, @labath wrote: > I wonder if we shouldn't just fix the TestDisassembleBreakpoint to not > require adding every single architecture. That test was added because > lldb-server was not removing the traps from the memory read

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

alexandreyy updated this revision to Diff 138610. alexandreyy added a comment. Modified TestDisassembleBreakpoint.py to consider multiple architectures. https://reviews.llvm.org/D44472 Files: packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py packages/Python/lldbsuite/

[Lldb-commits] [PATCH] D44015: Fix std unique pointer not printing.

alexandreyy added a comment. Thanks, @labath @clayborg . @labath Could you please commit this patch? https://reviews.llvm.org/D44015 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [PATCH] D44015: Fix std unique pointer not printing.

alexandreyy updated this revision to Diff 137153. alexandreyy added a comment. Changed NULL pointer https://reviews.llvm.org/D44015 Files: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp Index: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp ===

[Lldb-commits] [PATCH] D44015: Fix std unique pointer not printing.

alexandreyy updated this revision to Diff 137022. alexandreyy added a comment. Fix std unique pointer not printing https://reviews.llvm.org/D44015 Files: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp Index: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp

[Lldb-commits] [PATCH] D44015: Fix std unique pointer not printing.

alexandreyy created this revision. alexandreyy added reviewers: labath, clayborg. Std unique pointers were not being printed. The unique pointer layout was changed in libstdc++ 6.0.23. https://reviews.llvm.org/D44015 Files: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp Index

[Lldb-commits] [PATCH] D42917: Adapt some tests to work with PPC64le architecture

alexandreyy accepted this revision. alexandreyy added a comment. Hi, @clayborg . Could you please commit this patch? https://reviews.llvm.org/D42917 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

alexandreyy added a comment. In https://reviews.llvm.org/D41702#981651, @alexandreyy wrote: > In https://reviews.llvm.org/D41702#980893, @davide wrote: > > > Wait a minute. Is there any reason why we can't add tests now? > > > Thanks. > We are running the default tests of the lldb suite. > Curr

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

alexandreyy added a comment. In https://reviews.llvm.org/D41702#980893, @davide wrote: > Wait a minute. Is there any reason why we can't add tests now? Thanks. We are running the default tests of the lldb suite. Currently, we have 48 failures that we are working on. Could we proceed with this p

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

alexandreyy added a comment. In https://reviews.llvm.org/D41702#981456, @labath wrote: > Well.. whether this plugin is tested depends on what machine you're running > on. If you're running on a ppc machine, plenty of tests will exercise this > code (TestReturnValue, and pretty much any test doi

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

alexandreyy added a comment. In https://reviews.llvm.org/D41702#978836, @clayborg wrote: > Looks nice. Only nit is we probably don't need the m_endian member variable. > See inlined comment. Thanks. I have changed the code to get the byte order. https://reviews.llvm.org/D41702 ___

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

alexandreyy updated this revision to Diff 130236. alexandreyy added a comment. Removed m_endian variable. https://reviews.llvm.org/D41702 Files: source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h source/Plugins/Process/Utility/RegisterInfos_ppc64

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

alexandreyy updated this revision to Diff 130180. alexandreyy added a comment. Herald added a subscriber: JDevlieghere. Merged ppc64le and ppc64 plugins. https://reviews.llvm.org/D41702 Files: source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h so

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

alexandreyy added a comment. Thanks, @labath and @chmeee . I will do the merge and send the update soon. In https://reviews.llvm.org/D41702#975873, @chmeee wrote: > In https://reviews.llvm.org/D41702#972009, @labath wrote: > > > In https://reviews.llvm.org/D41702#971076, @jhibbits wrote: > > > >

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

alexandreyy added a comment. I think the stack frame structure is not correct for the PPC64be plugin. But it is hard to say how bad it is broken and fix the plugin without testing it. The register numbers and stack frame structures are different from the ABI 1.9 to the ABI 2.0. In https://revie

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

alexandreyy added a comment. In https://reviews.llvm.org/D41702#970844, @labath wrote: > In https://reviews.llvm.org/D41702#969294, @hfinkel wrote: > > > In https://reviews.llvm.org/D41702#969179, @labath wrote: > > > > > Is the only difference between ppc64 and ppc64le ABIs in the endianness >

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

alexandreyy added a comment. Thanks, @clayborg. @labath , Could you commit this patch? https://reviews.llvm.org/D41702 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

alexandreyy created this revision. Herald added subscribers: kbarton, mgorny, nemanjai. This patch implements the ABI Plugin for PPC64le. It was based on the ABI for PPC64. It also enables LLDB to evaluate expressions using JIT. https://reviews.llvm.org/D41702 Files: source/API/SystemInitiali

[Lldb-commits] [PATCH] D40647: Fix float expressions for PPC64le

alexandreyy updated this revision to Diff 124952. alexandreyy added a comment. Add SIToFP and UIToFP instructions to handle comparisons between float and char values. https://reviews.llvm.org/D40647 Files: source/Expression/IRInterpreter.cpp Index: source/Expression/IRInterpreter.cpp ==

[Lldb-commits] [PATCH] D40647: Fix float expressions for PPC64le

alexandreyy created this revision. Implemented FCmp and FPExt instructions. https://reviews.llvm.org/D40647 Files: source/Expression/IRInterpreter.cpp Index: source/Expression/IRInterpreter.cpp === --- source/Expression/IRInterp

[Lldb-commits] [PATCH] D40133: elf-core: Convert remaining register context to use register set maps

alexandreyy added a comment. Looks good to me! https://reviews.llvm.org/D40133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy added a comment. In https://reviews.llvm.org/D39681#925864, @labath wrote: > Also, I have trouble downloading the core file from phabricator. Alexandre, > can you sent them to me directly? Sent the test files by e-mail. Thanks. https://reviews.llvm.org/D39681 _

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy updated this revision to Diff 123151. alexandreyy added a comment. Herald added a subscriber: JDevlieghere. Removed enums without namespaces. https://reviews.llvm.org/D39681 Files: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py packages/Pyt

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy added inline comments. Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14 +/// Core files PT_NOTE segment descriptor types +enum { + NT_PRSTATUS = 1, krytarowski wrote: > alexandreyy wrote: > > krytarowski wrote: > > > No namespace here?

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy added inline comments. Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:14 +/// Core files PT_NOTE segment descriptor types +enum { + NT_PRSTATUS = 1, krytarowski wrote: > No namespace here? I think these constants are used for multiple O

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy updated this revision to Diff 122879. alexandreyy added a comment. Removed issue note from commit message. https://reviews.llvm.org/D39681 Files: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py packages/Python/lldbsuite/test/functionalities/

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy added a comment. In https://reviews.llvm.org/D39681#920349, @labath wrote: > I'm not sure what's the problem with backtracing without more info, but the > nice thing about core files is that you can open a ppc and x86 one side by > side and see how for do you get before things start

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy updated this revision to Diff 122872. alexandreyy added a comment. Fixed backtrace issue. https://reviews.llvm.org/D39681 Files: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py packages/Python/lldbsuite/test/functionalities/postmortem/elf-co

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy added a comment. In https://reviews.llvm.org/D39681#921620, @labath wrote: > Looks good, thank you. Just please make sure you change the file name at top > of the new header file and add inclusion guards. Done. Could you commit it? I don't have commit access. https://reviews.llvm

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy updated this revision to Diff 122423. alexandreyy added a comment. Added inclusion guards in elf-core-enums.h https://reviews.llvm.org/D39681 Files: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py packages/Python/lldbsuite/test/functionaliti

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy updated this revision to Diff 122276. alexandreyy added a comment. Fixed test identation https://reviews.llvm.org/D39681 Files: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py packages/Python/lldbsuite/test/functionalities/postmortem/elf-cor

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy updated this revision to Diff 122265. alexandreyy added a comment. Changed namespaces in core enums. https://reviews.llvm.org/D39681 Files: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py packages/Python/lldbsuite/test/functionalities/postmo

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy added a comment. In https://reviews.llvm.org/D39681#920349, @labath wrote: > I'm not sure what's the problem with backtracing without more info, but the > nice thing about core files is that you can open a ppc and x86 one side by > side and see how for do you get before things start

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy updated this revision to Diff 122239. alexandreyy marked an inline comment as done. alexandreyy added a comment. Moved core enums to header file. https://reviews.llvm.org/D39681 Files: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py packages

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy added a comment. Thanks for all the reviews @labath and @clayborg. I changed the code to use the DenseMap and added the files for testing. The backtrace is not working properly yet, It is showing all frames, just the current. Am I missing something? https://reviews.llvm.org/D39681

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy updated this revision to Diff 14. alexandreyy added a comment. Update according to reviews. https://reviews.llvm.org/D39681 Files: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py packages/Python/lldbsuite/test/functionalities/postmortem/

[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le

alexandreyy created this revision. Herald added subscribers: kbarton, mgorny, nemanjai. Implement core dump debugging for PPC64le. https://reviews.llvm.org/D39681 Files: source/Plugins/Process/Utility/CMakeLists.txt source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.cpp source/Pl

[Lldb-commits] [PATCH] D39487: Add float/vector registers for ppc64le

alexandreyy added a comment. Thanks @labath. I adjusted the VSX and VMX methods. https://reviews.llvm.org/D39487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D39487: Add float/vector registers for ppc64le

alexandreyy updated this revision to Diff 121478. alexandreyy added a comment. Simplified vector register methods https://reviews.llvm.org/D39487 Files: packages/Python/lldbsuite/test/make/Makefile.rules source/Core/ArchSpec.cpp source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc6

[Lldb-commits] [PATCH] D39487: Add float/vector registers for ppc64le

alexandreyy added a comment. @clayborg Thanks for the review. @eugene , @labath Could you, please, commit this patch? I don't have the permission for it. https://reviews.llvm.org/D39487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D39487: Add float/vector registers for ppc64le

alexandreyy created this revision. Herald added subscribers: JDevlieghere, kbarton, nemanjai. Add read and write functions for VSX, VMX and float registers and fix watchpoint size https://reviews.llvm.org/D39487 Files: packages/Python/lldbsuite/test/make/Makefile.rules source/Core/ArchSpec

[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

alexandreyy added a comment. In https://reviews.llvm.org/D38323#889473, @labath wrote: > Looks fine to me. Sorry about the delay. > > @eugene should be able to help you commit this. > > Wrt. the extra register context discussion, I believe you will need to > implement an extra class or two when

[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

alexandreyy added a comment. Hi, Could you review/approve this patch, please? I do not have commit permission. I will add other register sets later. Thanks! ;) https://reviews.llvm.org/D38323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

alexandreyy added a comment. Are these changes ok? I am implementing the read/write functions for the other registers. And I will add it later. In https://reviews.llvm.org/D38323#883429, @clayborg wrote: > Looks fine. One main questions for new linux archs in particular: is linux > using the ll

[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

alexandreyy updated this revision to Diff 117197. alexandreyy marked 6 inline comments as done. alexandreyy added a comment. Remove duplicated structs and change register set types https://reviews.llvm.org/D38323 Files: source/Plugins/Process/Linux/CMakeLists.txt source/Plugins/Process/Linu

[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

alexandreyy marked 6 inline comments as done. alexandreyy added a comment. In https://reviews.llvm.org/D38323#883429, @clayborg wrote: > Looks fine. One main questions for new linux archs in particular: is linux > using the lldb-server to debug these days even when debugging locally? If so, > t

[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

alexandreyy created this revision. Herald added subscribers: JDevlieghere, kbarton, mgorny, nemanjai. Add support for ppc64le to create breakpoints and read/write general purpose registers. Other features for ppc64le and functions to read/write other registers are being implemented. https://re