[Lldb-commits] [lldb] e1d91ba - [lldb] Fix erroneous return value

Author: Alexandre Ganea Date: 2025-04-11T17:50:15-04:00 New Revision: e1d91ba06d250dd8bbd5bded4824c5b210c2667a URL: https://github.com/llvm/llvm-project/commit/e1d91ba06d250dd8bbd5bded4824c5b210c2667a DIFF: https://github.com/llvm/llvm-project/commit/e1d91ba06d250dd8bbd5bded4824c5b210c2667a.dif

[Lldb-commits] [lldb] 84ed81b - [lldb] On Windows, silence warning when building with Clang ToT

Author: Alexandre Ganea Date: 2025-04-11T17:49:26-04:00 New Revision: 84ed81bc8a5359f33818c876e43f6450e98deb35 URL: https://github.com/llvm/llvm-project/commit/84ed81bc8a5359f33818c876e43f6450e98deb35 DIFF: https://github.com/llvm/llvm-project/commit/84ed81bc8a5359f33818c876e43f6450e98deb35.dif

[Lldb-commits] [lldb] 715c61e - [lldb][lldbp-dap] On Windoows, silence warnings when building with MSVC

Author: Alexandre Ganea Date: 2025-04-11T17:50:15-04:00 New Revision: 715c61e9a7cc631fd0965b887941ccfd8c0133d6 URL: https://github.com/llvm/llvm-project/commit/715c61e9a7cc631fd0965b887941ccfd8c0133d6 DIFF: https://github.com/llvm/llvm-project/commit/715c61e9a7cc631fd0965b887941ccfd8c0133d6.dif

[Lldb-commits] [lldb] a819b0e - [lldb] Silence warning

Author: Alexandre Ganea Date: 2024-08-11T19:01:12-04:00 New Revision: a819b0e55fafab0c6c4b059fc0132620f43ac38a URL: https://github.com/llvm/llvm-project/commit/a819b0e55fafab0c6c4b059fc0132620f43ac38a DIFF: https://github.com/llvm/llvm-project/commit/a819b0e55fafab0c6c4b059fc0132620f43ac38a.dif

[Lldb-commits] [lldb] af09dd6 - [lldb] Silence warning

Author: Alexandre Ganea Date: 2024-08-11T19:01:12-04:00 New Revision: af09dd692232fe6f06650e5b29710206d516fb38 URL: https://github.com/llvm/llvm-project/commit/af09dd692232fe6f06650e5b29710206d516fb38 DIFF: https://github.com/llvm/llvm-project/commit/af09dd692232fe6f06650e5b29710206d516fb38.dif

[Lldb-commits] [lldb] 048815c - Revert "[lldb] Silence function cast warning when building with Clang ToT targetting Windows"

Author: Alexandre Ganea Date: 2024-07-06T12:00:13-04:00 New Revision: 048815c22ae779b1f2a0289b7b28ed8cf54af676 URL: https://github.com/llvm/llvm-project/commit/048815c22ae779b1f2a0289b7b28ed8cf54af676 DIFF: https://github.com/llvm/llvm-project/commit/048815c22ae779b1f2a0289b7b28ed8cf54af676.dif

[Lldb-commits] [lldb] cf1ded3 - [lldb] Silence function cast warning when building with Clang ToT targetting Windows

Author: Alexandre Ganea Date: 2024-07-05T20:49:40-04:00 New Revision: cf1ded3ac248ad4feeed7b4dd20c60b7e3c40339 URL: https://github.com/llvm/llvm-project/commit/cf1ded3ac248ad4feeed7b4dd20c60b7e3c40339 DIFF: https://github.com/llvm/llvm-project/commit/cf1ded3ac248ad4feeed7b4dd20c60b7e3c40339.dif

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

aganea wrote: This is breaking the github CI as seen here: https://buildkite.com/llvm-project/github-pull-requests/builds/73339#01902659-9fbc-44d2-9a5b-783f5af41b78. Should we add the "packaging" module to https://github.com/llvm/llvm-project/blob/main/lldb/test/requirements.txt ? https://git

[Lldb-commits] [lld] [lldb] [llvm] [mlir] Rename ThreadPool->DefaultThreadPool and ThreadPoolInterface->ThreadPool (NFC) (PR #83702)

https://github.com/aganea approved this pull request. https://github.com/llvm/llvm-project/pull/83702 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/aganea approved this pull request. Look good, thank you again for making all these changes! https://github.com/llvm/llvm-project/pull/82094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/82094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -209,25 +231,66 @@ class ThreadPool { /// Number of threads active for tasks in the given group (only non-zero). DenseMap ActiveGroups; -#if LLVM_ENABLE_THREADS // avoids warning for unused variable /// Signal for the destruction of the pool, asking thread to exit.

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -209,25 +231,66 @@ class ThreadPool { /// Number of threads active for tasks in the given group (only non-zero). DenseMap ActiveGroups; -#if LLVM_ENABLE_THREADS // avoids warning for unused variable /// Signal for the destruction of the pool, asking thread to exit.

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/aganea approved this pull request. LGTM with two minor comments. https://github.com/llvm/llvm-project/pull/82094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -140,54 +142,74 @@ class ThreadPool { }, std::move(F)}; } +}; + +/// A ThreadPool implementation using std::threads. +/// +/// The pool keeps a vector of threads alive, waiting on a condition variable +/// for some work to become available. +class S

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -209,25 +231,66 @@ class ThreadPool { /// Number of threads active for tasks in the given group (only non-zero). DenseMap ActiveGroups; -#if LLVM_ENABLE_THREADS // avoids warning for unused variable /// Signal for the destruction of the pool, asking thread to exit.

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/82094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -227,7 +265,7 @@ class ThreadPool { class ThreadPoolTaskGroup { aganea wrote: That point was raised by the OP in the Discourse thread (allow for custom implementations of `ThreadPoolTaskGroup`) and I think it deserved a clear answer, and I do agree now to y

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -227,7 +265,7 @@ class ThreadPool { class ThreadPoolTaskGroup { aganea wrote: Wouldn't the implemention for `ThreadPoolTaskGroup` come in hand with the one for `ThreadPool`? I feel if someone implements the `ThreadPoolInterface` they would want something si

[Lldb-commits] [lldb] 03e4070 - [lldb] Silence warning when building with Clang ToT

Author: Alexandre Ganea Date: 2024-01-25T09:34:18-05:00 New Revision: 03e4070ce1f834eb426aa8f8622838c40ff5c710 URL: https://github.com/llvm/llvm-project/commit/03e4070ce1f834eb426aa8f8622838c40ff5c710 DIFF: https://github.com/llvm/llvm-project/commit/03e4070ce1f834eb426aa8f8622838c40ff5c710.dif

[Lldb-commits] [lldb] cfc9f36 - Revert "[lldb] Silence narrowing conversion warning with MSVC"

Author: Alexandre Ganea Date: 2024-01-18T14:13:07-05:00 New Revision: cfc9f3695fafddfa6f537d6dac702afab00c3cce URL: https://github.com/llvm/llvm-project/commit/cfc9f3695fafddfa6f537d6dac702afab00c3cce DIFF: https://github.com/llvm/llvm-project/commit/cfc9f3695fafddfa6f537d6dac702afab00c3cce.dif

[Lldb-commits] [lldb] ded8aa6 - [lldb] Silence warning with latest MSVC

Author: Alexandre Ganea Date: 2024-01-18T13:06:12-05:00 New Revision: ded8aa61849c88492811186e0f4a7ee56a5d78ea URL: https://github.com/llvm/llvm-project/commit/ded8aa61849c88492811186e0f4a7ee56a5d78ea DIFF: https://github.com/llvm/llvm-project/commit/ded8aa61849c88492811186e0f4a7ee56a5d78ea.dif

[Lldb-commits] [lldb] cb67dc1 - [lldb] Silence narrowing conversion warning with MSVC

Author: Alexandre Ganea Date: 2024-01-18T13:06:12-05:00 New Revision: cb67dc19256565d15f6bed0e9808f4026ca04995 URL: https://github.com/llvm/llvm-project/commit/cb67dc19256565d15f6bed0e9808f4026ca04995 DIFF: https://github.com/llvm/llvm-project/commit/cb67dc19256565d15f6bed0e9808f4026ca04995.dif

[Lldb-commits] [lldb] bafdaa1 - [lldb] Silence warning with latest MSVC on Windows

Author: Alexandre Ganea Date: 2024-01-18T13:06:12-05:00 New Revision: bafdaa171a2806ceff628ed7b64ace2b92c05578 URL: https://github.com/llvm/llvm-project/commit/bafdaa171a2806ceff628ed7b64ace2b92c05578 DIFF: https://github.com/llvm/llvm-project/commit/bafdaa171a2806ceff628ed7b64ace2b92c05578.dif

[Lldb-commits] [lldb] d950157 - [lldb] Silence warning when building with latest MSVC

Author: Alexandre Ganea Date: 2024-01-18T13:06:12-05:00 New Revision: d950157f7b290e35ce25647e255df9dccbcead2b URL: https://github.com/llvm/llvm-project/commit/d950157f7b290e35ce25647e255df9dccbcead2b DIFF: https://github.com/llvm/llvm-project/commit/d950157f7b290e35ce25647e255df9dccbcead2b.dif

[Lldb-commits] [lldb] 89b7220 - [LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py

Author: Alexandre Ganea Date: 2020-10-19T14:28:08-04:00 New Revision: 89b72209ad9baf585f6765df7c668da112dea230 URL: https://github.com/llvm/llvm-project/commit/89b72209ad9baf585f6765df7c668da112dea230 DIFF: https://github.com/llvm/llvm-project/commit/89b72209ad9baf585f6765df7c668da112dea230.dif

[Lldb-commits] [lldb] 97e7fbb - [LLDB] More Windows non-English locales fixes

Author: Alexandre Ganea Date: 2020-10-08T17:22:42-04:00 New Revision: 97e7fbb343e2a4ea913686254105b9965c5468f8 URL: https://github.com/llvm/llvm-project/commit/97e7fbb343e2a4ea913686254105b9965c5468f8 DIFF: https://github.com/llvm/llvm-project/commit/97e7fbb343e2a4ea913686254105b9965c5468f8.dif

[Lldb-commits] [lldb] 79809f5 - [LLDB] On Windows, fix tests

Author: Alexandre Ganea Date: 2020-10-08T11:46:59-04:00 New Revision: 79809f58b02419a5d1bfb6c9a59dbd13cd038c77 URL: https://github.com/llvm/llvm-project/commit/79809f58b02419a5d1bfb6c9a59dbd13cd038c77 DIFF: https://github.com/llvm/llvm-project/commit/79809f58b02419a5d1bfb6c9a59dbd13cd038c77.dif

[Lldb-commits] [lldb] 76c5f27 - Re-land [Debug][CodeView] Emit fully qualified names for globals

Author: Alexandre Ganea Date: 2020-05-15T10:37:09-04:00 New Revision: 76c5f277f25e334404aa44ea0aafd674a627ab74 URL: https://github.com/llvm/llvm-project/commit/76c5f277f25e334404aa44ea0aafd674a627ab74 DIFF: https://github.com/llvm/llvm-project/commit/76c5f277f25e334404aa44ea0aafd674a627ab74.dif

[Lldb-commits] [lldb] 1cc0ba4 - [LLDB] Disable MSVC warning C4190: 'LLDBSwigPythonBreakpointCallbackFunction' has C-linkage specified, but returns UDT 'llvm::Expected' which is incompatible with

Author: Alexandre Ganea Date: 2019-12-03T09:53:26-05:00 New Revision: 1cc0ba4cbdc54200e1b3c65e83e51a5368a819ea URL: https://github.com/llvm/llvm-project/commit/1cc0ba4cbdc54200e1b3c65e83e51a5368a819ea DIFF: https://github.com/llvm/llvm-project/commit/1cc0ba4cbdc54200e1b3c65e83e51a5368a819ea.dif

[Lldb-commits] [lldb] bdad3ec - [LLDB] On Windows, force error message formatting to English

Author: Alexandre Ganea Date: 2019-11-28T14:15:13-05:00 New Revision: bdad3ec75ab35ade2433b1278689d483dcf9abc4 URL: https://github.com/llvm/llvm-project/commit/bdad3ec75ab35ade2433b1278689d483dcf9abc4 DIFF: https://github.com/llvm/llvm-project/commit/bdad3ec75ab35ade2433b1278689d483dcf9abc4.dif

[Lldb-commits] [lldb] b4dfc55 - [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope

Author: Alexandre Ganea Date: 2019-11-28T14:00:56-05:00 New Revision: b4dfc5508f9239f50a3c44dd64e82a488b698b29 URL: https://github.com/llvm/llvm-project/commit/b4dfc5508f9239f50a3c44dd64e82a488b698b29 DIFF: https://github.com/llvm/llvm-project/commit/b4dfc5508f9239f50a3c44dd64e82a488b698b29.dif

[Lldb-commits] [lldb] r361861 - Fix 'warning: format specifies type 'int' but the argument has type 'MIuint' (aka 'unsigned long long') [-Wformat]' with Clang 8.0

Author: aganea Date: Tue May 28 11:36:11 2019 New Revision: 361861 URL: http://llvm.org/viewvc/llvm-project?rev=361861&view=rev Log: Fix 'warning: format specifies type 'int' but the argument has type 'MIuint' (aka 'unsigned long long') [-Wformat]' with Clang 8.0 Modified: lldb/trunk/tools/l

[Lldb-commits] [lldb] r362437 - Silence 'warning C4305: 'initializing': truncation from 'double' to 'float'' with MSVC 19.16.27021.1 (VS2017 15.9.12)

Author: aganea Date: Mon Jun 3 11:46:30 2019 New Revision: 362437 URL: http://llvm.org/viewvc/llvm-project?rev=362437&view=rev Log: Silence 'warning C4305: 'initializing': truncation from 'double' to 'float'' with MSVC 19.16.27021.1 (VS2017 15.9.12) Modified: lldb/trunk/unittests/Utility/Re

[Lldb-commits] [lldb] r361295 - Fix LLDB warnings when compiling with Clang 8.0

Author: aganea Date: Tue May 21 12:35:06 2019 New Revision: 361295 URL: http://llvm.org/viewvc/llvm-project?rev=361295&view=rev Log: Fix LLDB warnings when compiling with Clang 8.0 Differential Revision: https://reviews.llvm.org/D62021 Modified: lldb/trunk/source/Host/common/GetOptInc.cpp