[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG895529cfd875: [lldb][PDB] Constexpr static member values as AST literals (authored by aleksandr.urakov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82160/

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82160/new/ https://reviews.llvm.org/D82160 __

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

aleksandr.urakov added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7324-7331 + // If the variable is an enum type, take the underlying integer type as + // the type of the integer literal. + if (const EnumType *enum_type = llvm::dyn_ca

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

aleksandr.urakov added a comment. Hello! Thanks for the patch, generally it looks good to me, the only thing I worry about is scoped enums (please, see the comment below). Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7324-7331 + // If the variable is a

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

This revision was automatically updated to reflect the committed changes. Closed by commit rG84c398d375d9: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a… (authored by aleksandr.urakov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov updated this revision to Diff 260235. aleksandr.urakov added a comment. Exactly! Removed unneeded wrapper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78697/new/ https://reviews.llvm.org/D78697 Files: lldb/source/Plugins/TypeS

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov added a comment. The problem here is that in the case of success `GetCString()` returns `nullptr`, and we fail on concatenation with `None` even if the expression was evaluated successfully. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov updated this revision to Diff 259864. aleksandr.urakov added a comment. Thanks! Fixed. The only thing is that `GetCString()` can return `nullptr`, which leads to `None` in Python, so I made a simple wrapper for that. I'm not very deep into the testing infrastructure, so I'm not

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov updated this revision to Diff 259509. aleksandr.urakov added reviewers: labath, leonid.mashinskiy. aleksandr.urakov added a comment. Hello, Pavel! Thanks for the review. Yes, this method looks like a better fit, I just didn't notice it before. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: aprantl, teemperor. aleksandr.urakov added a project: LLDB. Herald added a subscriber: lldb-commits. Sometimes a result variable of some expression can be presented as an elaborated type. In this case the methods `IsTypedef

[Lldb-commits] [PATCH] D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. Sorry for the long delay, LGTM now, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77000/new/ https://reviews.llvm.org/D77000 ___

[Lldb-commits] [PATCH] D77000: [lldb] [PECOFF] Check that PECallFrameInfo operates on the expected architecture before interpreting RuntimeFunction structs

aleksandr.urakov added a comment. Hello! But does the format of an exception directory for aarch64 differ completely from x86-64 one? Can we somehow adopt the existing parser to support it? If we can, I think that this check looks good (we encapsulate the difference inside `PECallFrameInfo`). O

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

aleksandr.urakov added a comment. Sorry, I'm OOO today, so I can't take a precise look on this now. But I'm not sure, isn't race condition possible here on the m_session_data reset? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69503/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thank you! Can you send me an example of binary on which unwinding fails with a crash, please? It is a very interesting case... Repository: rLLDB LLDB CHANGES SIN

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. @stella.stamenova I've fixed it with r374888, thanks again for pointing to that. The fix of unwind can fix some stepping issues, because stepping logic uses call stack information actively. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

aleksandr.urakov added a comment. In D68980#1709327 , @labath wrote: > @aleksandr.urakov, since you probably know more about windows and these tests > than I do, I'd be interested in hearing your thoughts too... Sorry, I made some changes to the testing

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

aleksandr.urakov added a comment. Sorry, I didn't see Pavel's message. In this case I have no objections to the patch if other people also won't have. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68980/new/ https://reviews.llvm.org/D68980 _

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68980/new/ https://reviews.llvm.org/D68980 ___

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. In D67347#1705563 , @mstorsjo wrote: > Quick question here; will unwinding using DWARF debug info still work like > before after this, for binaries that don't use SEH for exception unwinding? Hi Martin! Do I understand

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

This revision was automatically updated to reflect the committed changes. Closed by commit rG30c2441a3262: [Windows] Use information from the PE32 exceptions directory to construct… (authored by aleksandr.urakov). Changed prior to commit: https://reviews.llvm.org/D67347?vs=220144&id=224554#toc

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. Thanks a lot for the review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://reviews.llvm.org/D67347 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG0891366571b2: [Windows] Introduce a switch for the `lldb-server` mode on Windows (authored by aleksandr.urakov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov added a comment. Hello! I am sorry for a delay with reply, I was OOO. Thanks all for the review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68258/new/ https://reviews.llvm.org/D68258 ___ lldb-co

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov added a comment. In D68258#1690756 , @aleksandr.urakov wrote: > I've made it in the way similar to Zachary have made for the > `SymbolFileNativePDB` plugin. An environment variable could be more > convenient e.g. to run a bunch of tests

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov added a comment. I've made it in the way similar to Zachary have made for the `SymbolFileNativePDB` plugin. An environment variable could be more convenient e.g. to run a bunch of tests using the `lldb-test` option. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

This revision was automatically updated to reflect the committed changes. Closed by commit rL373300: [Windows] Added support of watchpoints to `NativeProcessWindows` (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

aleksandr.urakov added a comment. Thank you! I've added a switch in a manner similar to one that Zachary has chosen for SymbolFilePDB/NativePDB plugins here: D68258 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67222/new/ htt

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: labath, amccarth, asmith, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, abidh. This patch introduces a switch, based on the environment variable `LLDB_USE_LL

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. Gentle ping! What do you think of this? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://reviews.llvm.org/D67347 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

aleksandr.urakov added a subscriber: leonid.mashinskiy. aleksandr.urakov added a comment. In D67954#1680536 , @labath wrote: > Have you considered going the "native" route directly? My understanding is > that this route is already functional on x86 (modul

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

aleksandr.urakov updated this revision to Diff 221671. aleksandr.urakov added a comment. Update the patch due to Pavel's request. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67222/new/ https://reviews.llvm.org/D67222 Files: lldb/source/Plugins/Process/Wind

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

aleksandr.urakov added a reviewer: labath. aleksandr.urakov added a comment. In D67222#1680613 , @labath wrote: > Btw, in the context of D67954 , I realized > that I don't know how to actually enable the usage of lldb-serv

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov marked 4 inline comments as done. aleksandr.urakov added a comment. Hi Jason, thanks for the review! Initially, the reason of these changes was to reuse the code that works with `eh_frame`, because on Windows we have a very similar compiler generated info designed to help with

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov updated this revision to Diff 220144. aleksandr.urakov edited the summary of this revision. aleksandr.urakov added a comment. Update due to the requests. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://reviews.llvm.org/D67347

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov marked 4 inline comments as done. aleksandr.urakov added a comment. Thanks all for taking a look! In D67347#1666509 , @amccarth wrote: > This patch is pretty large. It might be easier to break it up into a series > of small steps to get

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov updated this revision to Diff 219853. aleksandr.urakov added a comment. Update diff due to Pavel's requests. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://reviews.llvm.org/D67347 Files: lldb/include/lldb/Symbol/DWARFCallFr

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. It's a good point, thank you! I had the same thoughts when I done it, but I'm not completely sure. The problem is that an object file can't be completely responsible for choosing an unwind plan, because some plans are produced by symbol files (and an object fil

[Lldb-commits] [PATCH] D67347: [Windows] Use EH info from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov created this revision. Herald added subscribers: llvm-commits, lldb-commits, JDevlieghere, MaskRay, arichardson, aprantl, mgorny, emaste. Herald added a reviewer: espindola. Herald added projects: LLDB, LLVM. This patch adds an implementation of reconstructing of unwind plans fro

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

This revision was automatically updated to reflect the committed changes. Closed by commit rL371166: [Windows] Add support of watchpoints to `ProcessWindows` (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov added a comment. Thanks all! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ https://reviews.llvm.org/D67168 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov marked 3 inline comments as done. aleksandr.urakov added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp:82 -bool RegisterContextWindows::ClearHardwareBreakpoint(uint32_t hw_idx) { - return false; -} + if (!

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov updated this revision to Diff 218897. aleksandr.urakov added a comment. Determine whether 8-byte watchpoints are supported or not statically. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ https://reviews.llvm.org/D67168 Files: ll

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: asmith, amccarth, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, jfb. This patch adds support of watchpoints to the new `NativeProcessWindows` plugin. The sam

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov marked 5 inline comments as done. aleksandr.urakov added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp:397 +if (slot != LLDB_INVALID_INDEX32) { + int id = m_watchpoint_slots[slot]; + LLDB_LOG(log, ---

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov updated this revision to Diff 218840. aleksandr.urakov marked an inline comment as done. aleksandr.urakov added a comment. Check bitness of the target when checking the watchpoint size. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ h

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov updated this revision to Diff 218838. aleksandr.urakov added a comment. Address the requested changes. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ https://reviews.llvm.org/D67168 Files: lldb/packages/Python/lldbsuite/test/comma

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov updated this revision to Diff 218837. aleksandr.urakov added a comment. Address the requested changes. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ https://reviews.llvm.org/D67168 Files: lldb/packages/Python/lldbsuite/test/comma

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: asmith, stella.stamenova, amccarth. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, abidh. aleksandr.urakov added a subscriber: leonid.mashinskiy. This patch adds support of watc

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:58 llvm::BumpPtrAllocator

[Lldb-commits] [PATCH] D62021: Fix LLDB warnings when compiling with Clang 8.0

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62021/new/ https://reviews.llvm.org/D62021 ___

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

aleksandr.urakov added a comment. Ah, yes, sure, it will just be moved on the `lldb-server` side. Thanks again for the clarification! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53753/new/ https://reviews.llvm.org/D53753 _

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

aleksandr.urakov added a comment. In D53753#1504589 , @labath wrote: > When we evaluate an expression, we jit a bunch of opcodes into the inferior > memory and then have it execute them. For that to work, we need to allocate > some memory in order to sto

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

aleksandr.urakov added a comment. In D53753#1504361 , @labath wrote: > I'm not sure what exactly are the consequences of not using the correct ABI > definition here. I think the case where the difference may start to become > obvious is if you try to get

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

aleksandr.urakov added a comment. @lanza Hello! AFAIU, these values have nothing to do with the Microsoft x64 calling convention. They are used by `ABISysV_x86_64`, which specifies ABI for working with code injectable into a process being debugged. It requires six arguments to be passed through

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

This revision was automatically updated to reflect the committed changes. Closed by commit rL359420: [Windows] Dump more information about access violation exception (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D61003: PostfixExpression: move parser out of NativePDB internals

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61003/new/ https://reviews.llvm.org/D61003 ___ lldb-comm

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

This revision was automatically updated to reflect the committed changes. Closed by commit rL358873: [NativePDB] Add anonymous namespaces support (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

aleksandr.urakov added a comment. Thanks for the review! Sorry, I've forgot to include context in the updated patch. Yes, it's exactly the case that is broken, I've left FIXME there until it will be fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60817/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/NativePDB/ast-types.cpp:77 +// FIXME: Should be located in the namespace `A`, in the struct `C<1>`. +A::C<1>::D AC1D; + amccarth wrote: > Is this

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

aleksandr.urakov updated this revision to Diff 195863. aleksandr.urakov added a comment. Thank you for the comments, I agree with you. I've fixed the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60817/new/ https://reviews.llvm.org/D60817 Files: lit/SymbolFile/NativePDB/Inputs

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, asmith, labath, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, aprantl. This patch adds anonymous namespaces support to the native PDB plugin. I had to

[Lldb-commits] [PATCH] D60599: Move postfix expression code out of the NativePDB plugin

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. Sorry for the long delay with the response, I had days off. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60599/new/ https://reviews.llvm.org/D60599

[Lldb-commits] [PATCH] D60271: PDBFPO: Use references instead of pointers, where possible

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. LGTM too! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60271/new/ https://reviews.llvm.org/D60271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [PATCH] D60068: PDBFPO: Refactor register reference resolution

aleksandr.urakov added a comment. I think both approaches are acceptable, but I would prefer to include it into the Symbols library because this functionality is more symbols-related than general. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60068/new/ https

[Lldb-commits] [PATCH] D60068: PDBFPO: Refactor register reference resolution

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60068/new/ https://reviews.llvm.org/D60068 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353806: [NativePDB] Process virtual bases in the correct order (authored by aleksandr.urakov, committed by ). Herald ad

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov added a comment. Thanks for the help with the tests, it looks like they are ok now! So can we proceed with this patch? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56904/new/ https://reviews.llvm.org/D56904

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL353709: [build.py] Add `-fms-compatibility-version=19` to `build.py` (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

aleksandr.urakov added a comment. Zachary, can you take a look? please? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57809/new/ https://reviews.llvm.org/D57809 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

aleksandr.urakov added a comment. Fixed in r353503, thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://reviews.llvm.org/D55122 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

aleksandr.urakov updated this revision to Diff 185526. aleksandr.urakov added a comment. I've checked your solution, and it's worked for me too! I think that your solution is better because it is more straight-forward. Here is the updated patch. Repository: rLLDB LLDB CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, labath, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: lldb-commits. On my system, `clang-cl` can't compile tests containing `char16_

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353281: [x64] Process the B field of the REX prefix correctly for the PUSH and POP (authored by aleksandr.urakov, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added a comment. Thanks all for the review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57745/new/ https://reviews.llvm.org/D57745 ___ lldb-comm

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

aleksandr.urakov updated this revision to Diff 185497. aleksandr.urakov added a comment. Yes, sure, sorry about this, I occasionally have forgot to update the prefixes... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57745/new/ https://reviews.llvm.org/D57745

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

aleksandr.urakov updated this revision to Diff 185296. aleksandr.urakov added a comment. Yes, you are right, thank you! I've updated the patch. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57745/new/ https://reviews.llvm.org/D57745 Files: source/Plugins/Unw

[Lldb-commits] [PATCH] D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: jasonmolenda, labath. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, abidh. This patch makes `x86AssemblyInspectionEngine` to process zero value of the `B` field of the `REX` prefix in a cor

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov added a comment. Thanks for the reply! It seems that after your hint I've figured it out. It's the environment variable `VCINSTALLDIR`. I've added it to the `defaultenv` list of the `_get_visual_studio_environment` function and the test passes now. What do you think about this

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov added a comment. Thank you! I've updated the comments in the commit. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

This revision was automatically updated to reflect the committed changes. Closed by commit rL353149: [Expressions] Add support of expressions evaluation in some object's context (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. C

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov added a comment. Ping! What do you think about it? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56904/new/ https://reviews.llvm.org/D56904 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov added a comment. Ping! Can you take a look, please? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

This revision was automatically updated to reflect the committed changes. Closed by commit rL352845: [PDB] Fix location retrieval for function local variables and arguments that are (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Changed prior to commit: https://rev

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/NativePDB/tag-types.cpp:5 // Test that we can display tag types. // RUN: %build --compiler=clang-cl --nodefaultlib -o %t.exe -- %s // RUN: env LLDB_USE_NATIVE

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov updated this revision to Diff 184061. aleksandr.urakov added a comment. Thanks for the comments, I think that they make sense. I've updated the patch. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56904/new/ https://reviews.llvm.org/D56904 Fil

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

This revision was automatically updated to reflect the committed changes. Closed by commit rL352464: [NativePDB] Add basic support of methods recostruction in AST (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56126/new/ https://reviews.llvm.org/D56126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov added a comment. Ping! Can you take a look, please? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56904/new/ https://reviews.llvm.org/D56904 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov added a comment. Ping! Can you take a look, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56126/new/ https://reviews.llvm.org/D56126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov updated this revision to Diff 183816. aleksandr.urakov added a comment. Herald added a reviewer: serge-sans-paille. Sorry for the long delay with reply. My colleague with a Mac (and Obj-C knowledge) have created the test for the Obj-C case. Can you take a look, please? Reposit

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov marked 2 inline comments as done. aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/NativePDB/tag-types.cpp:5 // Test that we can display tag types. // RUN: %build --compiler=clang-cl --nodefaultlib -o %t.exe -- %s // RUN: env LLDB_USE_NATIVE

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, rnk, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, abidh. This patch makes virtual bases to be added in the correct order to the bases list. It is impo

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov updated this revision to Diff 181541. aleksandr.urakov added a comment. @zturner Sorry for the long delay with this update. I've applied the changes we were talking about. @labath Thanks for sharing this, it's interesting to know! CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D56147: [Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`

This revision was automatically updated to reflect the committed changes. Closed by commit rL351065: [Core] Use the implementation method GetAddressOf in ValueObjectConstResultChild (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D56147: [Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`

aleksandr.urakov added a comment. Herald added a reviewer: serge-sans-paille. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56147/new/ https://reviews.llvm.org/D56147 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added inline comments. Comment at: lit/SymbolFile/NativePDB/ast-methods.cpp:28 +// CHECK: |-CXXRecordDecl {{.*}} struct Struct definition +// CHECK: | |-CXXMethodDecl {{.*}} simple_method 'void () __attribute__(

[Lldb-commits] [PATCH] D56147: [Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, JDevlieghere, clayborg, labath. aleksandr.urakov added a project: LLDB. Herald added a subscriber: lldb-commits. This patch allows to retrieve an address object for `ValueObject`'s children retrieved through e.g. `

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added a comment. In D56126#1342114 , @zturner wrote: > I think it's probably best to skip this part for now and come back to it > later. The only thing that will be missing is the abilit

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, labath, lemo, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, abidh. This patch adds the basic support of methods reconstruction by native PDB plugin. It

[Lldb-commits] [PATCH] D56010: [NativePDB] Fix setting breakpoint by file and line

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM too! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56010/new/ https://reviews.llvm.org/D56010 ___ lldb-commits

  1   2   3   4   >