ayzhao accepted this revision.
ayzhao added a comment.
This revision is now accepted and ready to land.
LGTM, looks like this builds on Windows now:
C:\src\llvm-project\build-ninja>ninja all
[3498/6597] Building CXX object
tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\AttrDocTable.cpp.obj
ayzhao added a comment.
A new conversion issue popped up:
C:\src\llvm-project\build-ninja>ninja all
[376/3206] Building CXX object
lib\ProfileData\CMakeFiles\LLVMProfileData.dir\ItaniumManglingCanonicalizer.cpp.obj
FAILED:
lib/ProfileData/CMakeFiles/LLVMProfileData.dir/ItaniumManglingCano
ayzhao requested changes to this revision.
ayzhao added a comment.
This revision now requires changes to proceed.
This still fails to build on Windows with MSVC's `cl.exe` compiler:
C:\src\llvm-project\build-ninja>ninja all
[49/4908] Building CXX object
lib\Demangle\CMakeFiles\LLVMDemangle.d
