https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/155485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/157192
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
@cmtice @boomanaiden154 1/3 are still failing:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/14864/testReport/lldb-shell/SymbolFile_DWARF/deterministic_build_cpp/
https://github.com/llvm/llvm-project/pull/156931
__
adrian-prantl wrote:
@cmtice I suspect that this may have broken three tests:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/14836/
Could you revert/investigate? Let me know if you need any data or help
reproducing.
https://github.com/llvm/llvm-project/pull/156729
__
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/156721
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/156721
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -308,52 +306,24 @@ Environment Host::GetEnvironment() {
return env;
}
-/// Manages the lifecycle of a Windows Event's Source.
-/// The destructor will call DeregisterEventSource.
-/// This class is meant to be used with \ref llvm::ManagedStatic.
-class WindowsEventLog {
-
https://github.com/adrian-prantl approved this pull request.
Otherwise lgtm
https://github.com/llvm/llvm-project/pull/156474
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/156469
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
LGTM once the outstanding comments are addressed.
Thanks for all the hard work!
https://github.com/llvm/llvm-project/pull/152887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
@@ -376,6 +382,148 @@ void Disassembler::PrintInstructions(Debugger &debugger,
const ArchSpec &arch,
}
}
+ // Add rich variable location annotations to the disassembly output.
+ //
+ // For each instruction, this block attempts to resolve in-scope variables
+ // and
@@ -154,6 +154,10 @@ Status
CommandObjectDisassemble::CommandOptions::SetOptionValue(
}
} break;
+ case 'v': //< --rich variable annotations
adrian-prantl wrote:
```suggestion
case 'v':
```
https://github.com/llvm/llvm-project/pull/152887
_
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/154727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/155483
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
Should this file be deleted?
https://github.com/llvm/llvm-project/pull/152887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
I think this should be deleted.
https://github.com/llvm/llvm-project/pull/152887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
@@ -376,6 +382,148 @@ void Disassembler::PrintInstructions(Debugger &debugger,
const ArchSpec &arch,
}
}
+ // Add rich variable location annotations to the disassembly output.
+ //
+ // For each instruction, this block attempts to resolve in-scope variables
+ // and
@@ -376,6 +382,148 @@ void Disassembler::PrintInstructions(Debugger &debugger,
const ArchSpec &arch,
}
}
+ // Add rich variable location annotations to the disassembly output.
+ //
+ // For each instruction, this block attempts to resolve in-scope variables
+ // and
@@ -376,6 +382,148 @@ void Disassembler::PrintInstructions(Debugger &debugger,
const ArchSpec &arch,
}
}
+ // Add rich variable location annotations to the disassembly output.
adrian-prantl wrote:
```suggestion
// Add variable location annotations t
@@ -154,6 +154,10 @@ Status
CommandObjectDisassemble::CommandOptions::SetOptionValue(
}
} break;
+ case 'v': //< --rich variable annotations
+enable_rich_annotations = true;
adrian-prantl wrote:
Can you rename `rich` to `variable` in most places?
@@ -399,6 +398,7 @@ class Disassembler : public
std::enable_shared_from_this,
eOptionMarkPCAddress =
(1u << 3), // Mark the disassembly line the contains the PC
eOptionShowControlFlowKind = (1u << 4),
+eOptionRichAnnotations = (1u << 5),
ad
adrian-prantl wrote:
```[lldb/test/API/functionalities/disassembler-variables/d_original_example](https://github.com/llvm/llvm-project/pull/152887#diff-b7942b849ea60f4e92ce3d85f3eb55811b20ea9507da4380e9c1b77f4336d61d)```
https://github.com/llvm/llvm-project/pull/152887
__
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/149827
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/155153
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/155153
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -129,6 +129,17 @@ class Architecture : public PluginInterface {
RegisterContext ®_context) const {
return false;
}
+
+ // Get the vector element order for this architecture. This determines how
adrian-prantl wrot
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/152887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -18,16 +18,34 @@ def _compile_object(self, src_name, func_cflags="-g
-gdwarf-5 -O2 -fno-inline"):
self.assertTrue(os.path.exists(obj), f"missing object: {obj}")
return obj
+def _compile_or_assemble_object(
+self,
+src_name,
+cfla
@@ -18,16 +18,34 @@ def _compile_object(self, src_name, func_cflags="-g
-gdwarf-5 -O2 -fno-inline"):
self.assertTrue(os.path.exists(obj), f"missing object: {obj}")
return obj
+def _compile_or_assemble_object(
+self,
+src_name,
+cfla
@@ -18,16 +18,34 @@ def _compile_object(self, src_name, func_cflags="-g
-gdwarf-5 -O2 -fno-inline"):
self.assertTrue(os.path.exists(obj), f"missing object: {obj}")
return obj
+def _compile_or_assemble_object(
+self,
+src_name,
+cfla
https://github.com/adrian-prantl approved this pull request.
I fit unbreaks the test suite, let's do this for now.
https://github.com/llvm/llvm-project/pull/154962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/adrian-prantl approved this pull request.
nice!
https://github.com/llvm/llvm-project/pull/154433
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> A bit surprised that this is gated by colour (or indeed, color) or not, but I
> see that the colour option is basically the ANSI option.
I think I may have conflated the two out of laziness when introducing column
visualization. IMO, it does make sense to separate out "d
@@ -376,6 +380,147 @@ void Disassembler::PrintInstructions(Debugger &debugger,
const ArchSpec &arch,
}
}
+ // Add rich variable location annotations to the disassembly output.
+ //
+ // For each instruction, this block attempts to resolve in-scope variables
+ // and
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/153494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -376,6 +380,143 @@ void Disassembler::PrintInstructions(Debugger &debugger,
const ArchSpec &arch,
}
}
+ // Add rich variable location annotations to the disassembly output.
+ //
+ // For each instruction, this block attempts to resolve in-scope variables
+ // and
@@ -445,10 +444,11 @@ class Disassembler : public
std::enable_shared_from_this,
const ExecutionContext &exe_ctx, const Address
&start,
Limit limit, bool mixed_source_and_assembly,
uint32_t num_mixed
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/152020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/152733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -150,6 +151,11 @@ llvm::Expected
ValueObjectPrinter::GetDescriptionForDisplay() {
if (maybe_str)
return maybe_str;
+ if (maybe_str.errorIsA())
+// Propagate expression errors to expose diagnostics to the user.
+// Without this early exit, the summary/value m
adrian-prantl wrote:
> > adding an option to the dissemble CommandObject is the right solution.
> > Personally I think I would prefer an option to the CommandObject. Do you
> > think this is feasible, or are there more many points through which the
> > disassembly is reachable, making an optio
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/149493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/152025
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/152001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/151992
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -247,6 +248,26 @@ uint32_t File::GetPermissions(Status &error) const {
return file_stats.st_mode & (S_IRWXU | S_IRWXG | S_IRWXO);
}
+NativeFile::NativeFile() = default;
+
+NativeFile::NativeFile(FILE *fh, bool transfer_ownership)
+: m_stream(fh), m_own_stream(transfer
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/151839
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/151668
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/150213
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -853,4 +853,6 @@ raw_ostream &operator<<(raw_ostream &OS, const
std::optional &O) {
} // end namespace llvm
+bool write_console_impl(int FD, llvm::StringRef Data);
adrian-prantl wrote:
This is making an internal API that only makes sense on Windows publi
@@ -0,0 +1,88 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,88 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,88 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,124 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,124 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,124 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,88 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/150073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/149112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
As high-level comments:
- I would filter out the entry values, since this feature is meant to help a
user understand the disassembly, and the entry values don't really exist in the
function.
- It would help readability if all annotations started at the same column
- in a fo
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t
max_opcode_byte_size,
ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' ');
ss.PutCString(mnemonics);
+ const size_t annotation_column = 150;
+
+ if (exe_ctx && exe_ctx->GetFramePtr(
@@ -158,6 +158,7 @@ class DWARFExpression {
}
void DumpLocation(Stream *s, lldb::DescriptionLevel level, ABI *abi) const;
+ void DumpLocationWithOptions(Stream *s, lldb::DescriptionLevel level, ABI
*abi, llvm::DIDumpOptions options) const;
adrian-prantl
@@ -53,6 +54,37 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+std::optional
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t
max_opcode_byte_size,
ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' ');
ss.PutCString(mnemonics);
+ const size_t annotation_column = 150;
+
+ if (exe_ctx && exe_ctx->GetFramePtr(
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t
max_opcode_byte_size,
ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' ');
ss.PutCString(mnemonics);
+ const size_t annotation_column = 150;
+
+ if (exe_ctx && exe_ctx->GetFramePtr(
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t
max_opcode_byte_size,
ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' ');
ss.PutCString(mnemonics);
+ const size_t annotation_column = 150;
+
+ if (exe_ctx && exe_ctx->GetFramePtr(
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t
max_opcode_byte_size,
ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' ');
ss.PutCString(mnemonics);
+ const size_t annotation_column = 150;
+
+ if (exe_ctx && exe_ctx->GetFramePtr(
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t
max_opcode_byte_size,
ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' ');
ss.PutCString(mnemonics);
+ const size_t annotation_column = 150;
+
+ if (exe_ctx && exe_ctx->GetFramePtr(
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/146963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
I pushed this manually as 0b98b27930da.
https://github.com/llvm/llvm-project/pull/146963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: CodingCarpincho
Date: 2025-07-03T14:20:31-07:00
New Revision: 0b98b27930dad5ff59de050605c3f101330a2b5c
URL:
https://github.com/llvm/llvm-project/commit/0b98b27930dad5ff59de050605c3f101330a2b5c
DIFF:
https://github.com/llvm/llvm-project/commit/0b98b27930dad5ff59de050605c3f101330a2b5c.dif
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/146963
>From 16b7748cf38aaade5185a1073d2755abb2c40d12 Mon Sep 17 00:00:00 2001
From: CodingCarpincho
Date: Thu, 3 Jul 2025 13:54:46 -0700
Subject: [PATCH] Use the root directory as the SDK root on POSIX platforms
@@ -39,6 +39,7 @@ class HostInfoPosix : public HostInfoBase {
static llvm::VersionTuple GetOSVersion();
static std::optional GetOSBuildString();
+ static llvm::Expected GetSDKRoot(SDKOptions options);
adrian-prantl wrote:
That's existing API.
https://gi
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/146963
LLDB has the concept of an "SDK root", which expresses where the system
libraries and so which are necessary for debugging can be found. On POSIX
platforms, the SDK root is just the root of the file syste
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/146801
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -860,6 +860,64 @@ ResolveLoadAddress(ExecutionContext *exe_ctx,
lldb::ModuleSP &module_sp,
return load_addr;
}
+static llvm::Error Evaluate_DW_OP_deref(DWARFExpression::Stack &stack,
+ExecutionContext *exe_ctx,
+
adrian-prantl wrote:
More test coverage sounds great!
https://github.com/llvm/llvm-project/pull/146740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/146740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/146697
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/146554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
LGTM with Michael's comments addressed.
https://github.com/llvm/llvm-project/pull/146062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/adrian-prantl commented:
LGTM with under/overflow checks added.
https://github.com/llvm/llvm-project/pull/144238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -53,6 +54,30 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+std::optional
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
@@ -53,6 +54,30 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+std::optional
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/145935
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> It's not _just_ `BuiltinHeadersInSystemModules` either. There are lots of
> things that the driver toolchain does that you shouldn't be skipping.
We should definitely _also_ find a way to factor that into a function LLDB can
call.
https://github.com/llvm/llvm-project/pu
@@ -53,6 +54,29 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+llvm::Expected
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
@@ -421,6 +422,10 @@ class AppleObjCRuntimeV2 : public AppleObjCRuntime {
lldb::addr_t GetISAHashTablePointer();
+ using ValueObjectSet = llvm::SmallSet;
adrian-prantl wrote:
`llvm::SmallPtrSet`?
https://github.com/llvm/llvm-project/pull/145396
_
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/144913
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1130,14 +1130,33 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
if (target) {
if (ModuleSP exe_module_sp = target->GetExecutableModule()) {
- auto path_or_err = ResolveSDKPathFromDebugInfo(*exe_module_sp);
- if (path_or_err) {
-
https://github.com/adrian-prantl approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/145744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
This LGTM. There is no good reason to support debugging with modules against an
older SDK, since you can't actually install one easily either.
https://github.com/llvm/llvm-project/pull/144913
__
@@ -58,6 +59,19 @@ class DWARFExpressionList {
}
lldb::addr_t GetFuncFileAddress() { return m_func_file_addr; }
+
+ /// Represents an entry in the DWARFExpressionList with all needed metadata.
+ struct DWARFExpressionEntry {
+AddressRange file_range; /// Represents
https://github.com/adrian-prantl approved this pull request.
LGTM with one comment
https://github.com/llvm/llvm-project/pull/145396
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/145328
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/145126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -53,6 +53,27 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+llvm::Expected
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/144998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
It would be nice if these were at least unit-tested on llvm.org, but given how
trivial the implementation is, make not strictly necessary.
https://github.com/llvm/llvm-project/pull/144549
__
@@ -982,7 +982,7 @@ lldb::LanguageType
SymbolFileDWARF::ParseLanguage(CompileUnit &comp_unit) {
return eLanguageTypeUnknown;
}
-XcodeSDK SymbolFileDWARF::ParseXcodeSDK(CompileUnit &comp_unit) {
+XcodeSDKPath SymbolFileDWARF::ParseXcodeSDK(CompileUnit &comp_unit) {
---
1 - 100 of 1457 matches
Mail list logo
