Re: [Lldb-commits] [PATCH] D33504: Fix FDE indexing while scan debug_info section

2017-05-26 Thread Abid, Hafiz via lldb-commits
Please note that version in the debug_frame is is specific to the call frame information. It is not the same as DWARF version number. Regards, Abid From: lldb-commits on behalf of Tatyana Krasnukha via lldb-commits Sent: Friday, May 26, 2017 12:47 PM To

Re: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section

2017-05-25 Thread Abid, Hafiz via lldb-commits
?I will commit on your behalf. Thanks, Abid From: Tatyana Krasnukha Sent: Wednesday, May 24, 2017 6:30 PM To: Abid, Hafiz; lldb-commits@lists.llvm.org Subject: RE: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section Formatting is done. C

Re: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section

2017-05-24 Thread Abid, Hafiz via lldb-commits
Please put it as review in Phabricator so others can comment too. I am wondering how we can test this behaviour. One can use -fno-asynchronous-unwind-tables with clang to disable generation of .eh_frame but the startup code still brings in that section. You also need to run clang-format to ma

Re: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section

2017-05-23 Thread Abid, Hafiz via lldb-commits
It looks ok to me. Please put the differences of .eh_frame and .debug_frame that you described below in code comments too.? Thanks, Abid From: lldb-commits on behalf of Tatyana Krasnukha via lldb-commits Sent: Thursday, May 18, 2017 9:37 PM To: lldb-commits@li