jimingham wrote:
It's always a little odd to have a class like this that's mostly read-only, but
one ivar is settable. We always seem to call SetLookupName right after we make
the lookup info. Is there any reason not to make this really "read only" by
passing the lookup name in as well when
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/171931
>From e36c4076c4ad4a8441cedcb8e00fdca2dbc27e99 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 11 Dec 2025 15:37:31 -0800
Subject: [PATCH 1/2] [lldb] Still echo the command if we print the error
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/171931
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3398,10 +3312,22 @@ void
CommandInterpreter::IOHandlerInputComplete(IOHandler &io_handler,
lldb_private::CommandReturnObject result(m_debugger.GetUseColor());
HandleCommand(line.c_str(), eLazyBoolCalculate, result);
- // Now emit the command output text from the comm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
When the command interpreter is asked to not echo commands but still print
errors, a user has no idea what command caused the error.
For example, when I add `bogus` in my `~/.lldbinit`:
```
$ lldb
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/171931
When the command interpreter is asked to not echo commands but still print
errors, a user has no idea what command caused the error.
For example, when I add `bogus` in my `~/.lldbinit`:
```
$ lldb
error:
@@ -233,6 +233,32 @@ Error UdtRecordCompleter::visitKnownMember(
Error UdtRecordCompleter::visitKnownMember(CVMemberRecord &cvr,
NestedTypeRecord &nested) {
+ // Typedefs can only be added on structs.
+ if (m_record.record.kind != M
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
This is a follow-on to:
https://github.com/llvm/llvm-project/pull/168611
which added a bunch of tests for detecting dynamic types of C++ result
variables. I don't actually know how well dynamic type detection wor
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/171922
This is a follow-on to:
https://github.com/llvm/llvm-project/pull/168611
which added a bunch of tests for detecting dynamic types of C++ result
variables. I don't actually know how well dynamic type detecti
@@ -153,3 +153,148 @@ Linux applies to Windows. To find dependencies like
Python, you need to run
``dumpbin`` on ``liblldb.dll`` too.
On MacOS, use ``otool -l ``.
+
+Why Do I See More, Less, Or Different Registers Than I Expected?
+
@@ -153,3 +153,148 @@ Linux applies to Windows. To find dependencies like
Python, you need to run
``dumpbin`` on ``liblldb.dll`` too.
On MacOS, use ``otool -l ``.
+
+Why Do I See More, Less, Or Different Registers Than I Expected?
+
JDevlieghere wrote:
```
remote: This request was rate-limited due to too many requests. Reduce the
frequency of your requests or try again later.
remote: For more on scraping GitHub and how it may affect your rights, please
review our Terms of Service
(https://docs.github.com/en/site-policy/gi
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `bolt-x86_64-ubuntu-dylib`
running on `bolt-worker` while building `lldb,llvm` at step 2 "checkout".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/119/builds/7658
Here is the relevant piece of the bu
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `flang-aarch64-sharedlibs`
running on `linaro-flang-aarch64-sharedlibs` while building `lldb,llvm` at step
2 "checkout".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/80/builds/18540
Here is the rel
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `bolt-x86_64-ubuntu-shared`
running on `bolt-worker` while building `lldb,llvm` at step 2 "checkout".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/151/builds/7735
Here is the relevant piece of the b
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `bolt-x86_64-ubuntu-clang`
running on `bolt-worker` while building `lldb,llvm` at step 2 "checkout".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/113/builds/10039
Here is the relevant piece of the b
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/171901.diff
1 Files Affected:
- (modified) lldb/include/lldb/Core/Module.h (-6)
``diff
diff --git a/lldb/include/lldb/Core/Module.h b/
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/171901
None
>From 2f3289a9d583f1bdab792a513d4a0905ad02918a Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Thu, 11 Dec 2025 11:26:42 -0800
Subject: [PATCH] [lldb][NFCI] Remove unused methods from Module::LookupIn
https://github.com/Nerixyz edited
https://github.com/llvm/llvm-project/pull/171489
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz edited
https://github.com/llvm/llvm-project/pull/171489
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/171489
>From 3860c0b95ce99e944d1598513428c5e81aeea395 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Thu, 6 Nov 2025 19:51:20 +0100
Subject: [PATCH 1/2] [LLDB] Fix MS STL `variant` with non-trivial types and
PDB
---
.
Author: Jonas Devlieghere
Date: 2025-12-11T11:12:26-08:00
New Revision: 8d59cca1ab9cf4e39e43bf695e415de9ccd41115
URL:
https://github.com/llvm/llvm-project/commit/8d59cca1ab9cf4e39e43bf695e415de9ccd41115
DIFF:
https://github.com/llvm/llvm-project/commit/8d59cca1ab9cf4e39e43bf695e415de9ccd41115.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/171507
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/171574
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/171574
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/171507
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DrSergei updated
https://github.com/llvm/llvm-project/pull/171854
>From ef8a0e118f394df64e14d4f399ce1246d5ab53f7 Mon Sep 17 00:00:00 2001
From: Druzhkov Sergei
Date: Thu, 11 Dec 2025 18:19:30 +0300
Subject: [PATCH 1/3] [lldb] Add generic string view summary provider
---
...
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/147709
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-12-11T17:25:56Z
New Revision: 98aa84075d3d2eeea4296d1e1a69c23db70edab2
URL:
https://github.com/llvm/llvm-project/commit/98aa84075d3d2eeea4296d1e1a69c23db70edab2
DIFF:
https://github.com/llvm/llvm-project/commit/98aa84075d3d2eeea4296d1e1a69c23db70edab2.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/171820
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-12-11T17:25:45Z
New Revision: 1b7f272906dee31d505ed74e0514d2c04c1b5f97
URL:
https://github.com/llvm/llvm-project/commit/1b7f272906dee31d505ed74e0514d2c04c1b5f97
DIFF:
https://github.com/llvm/llvm-project/commit/1b7f272906dee31d505ed74e0514d2c04c1b5f97.diff
LOG:
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/171733
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-12-11T17:24:04Z
New Revision: c814ac1928b264a5bdeb98ec9035412fa37fb243
URL:
https://github.com/llvm/llvm-project/commit/c814ac1928b264a5bdeb98ec9035412fa37fb243
DIFF:
https://github.com/llvm/llvm-project/commit/c814ac1928b264a5bdeb98ec9035412fa37fb243.diff
@@ -245,8 +245,10 @@ IOHandlerEditline::IOHandlerEditline(
SetPrompt(prompt);
#if LLDB_ENABLE_LIBEDIT
- const bool use_editline = m_input_sp && m_output_sp && m_error_sp &&
-m_input_sp->GetIsRealTerminal();
+ const bool use_editline =
+ m_i
@@ -0,0 +1,131 @@
+//===-- GenericStringView.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
https://github.com/JDevlieghere auto_merge_enabled
https://github.com/llvm/llvm-project/pull/171733
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/171733
>From cb83cdce863b25bf7eda68889cc772e1cfda8ad8 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 10 Dec 2025 15:03:42 -0800
Subject: [PATCH 1/2] [lldb] Correct use_editline check in IOHandlerEditl
DrSergei wrote:
> Thanks for the patch. I'm all in favour of de-duplicating the formatter code,
> but I'd prefer it if we kept the individual SummaryProvider's per STL.
>
> I.e., the code that extracts the data and size from the type should live in
> the individual STL files. But the code that
@@ -0,0 +1,131 @@
+//===-- GenericStringView.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/171549
>From 714a50cee306e1437ef38c08232700a164cdea55 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 9 Dec 2025 17:00:56 -0800
Subject: [PATCH 1/2] [lldb-dap] Adjusting the initialize/launch flow to better
mat
@@ -21,16 +21,18 @@ using namespace lldb_dap::protocol;
namespace lldb_dap {
/// Launch request; value of command field is 'launch'.
-Error LaunchRequestHandler::Run(const LaunchRequestArguments &arguments) const
{
+void LaunchRequestHandler::Run(
+const LaunchRequestArgu
https://github.com/Nerixyz closed
https://github.com/llvm/llvm-project/pull/171858
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: nerix
Date: 2025-12-11T18:03:42+01:00
New Revision: 7fdf800a91a37dc915fec2cca2d8539ec5070d8a
URL:
https://github.com/llvm/llvm-project/commit/7fdf800a91a37dc915fec2cca2d8539ec5070d8a
DIFF:
https://github.com/llvm/llvm-project/commit/7fdf800a91a37dc915fec2cca2d8539ec5070d8a.diff
LOG: [L
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: nerix (Nerixyz)
Changes
Split off from #171489. This only adds the lookup of the active type
for a `std::variant` based on the head type (since PDB doesn't have template
info).
---
Full diff: https://github.com/llvm/llvm-project/pull/1718
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Sergei Druzhkov (DrSergei)
Changes
This patch introduces general summary provider for `std::string_view` and
simial types. I tried to remove copy-paste between different stl
implementations. I cannot check now how it works on Windows machi
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/171820
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/147709
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/171507
>From 417bf4882e9a6be920e6a728e5de1d62eedc9e38 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 8 Dec 2025 17:01:18 -0800
Subject: [PATCH 1/4] [lldb] Add WebAssembly platform
This PR adds a plat
@@ -400,6 +400,22 @@ llvm::Error Terminal::SetHardwareFlowControl(bool enabled)
{
#endif // LLDB_ENABLE_TERMIOS
}
+bool Terminal::SupportsUnicode() {
+ static std::optional g_result;
slydiman wrote:
It seems you don't need g_result on Windows at all. Just m
https://github.com/Nerixyz edited
https://github.com/llvm/llvm-project/pull/171854
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz edited
https://github.com/llvm/llvm-project/pull/171854
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/171858
Unicorn! · GitHub
body {
background-color: #f1f1f1;
margin: 0;
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
}
.container { margin: 50px au
@@ -0,0 +1,131 @@
+//===-- GenericStringView.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
https://github.com/Michael137 approved this pull request.
LGTM (module comment)
https://github.com/llvm/llvm-project/pull/171858
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -119,8 +119,14 @@ bool formatters::MsvcStlVariantSummaryProvider(
storage_type = storage_type.GetTypedefedType();
CompilerType active_type = storage_type.GetTypeTemplateArgument(1, true);
- if (!active_type)
-return false;
+ if (!active_type) {
+// PDB: get
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/171854
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/171854
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 requested changes to this pull request.
Thanks for the patch. I'm all in favour of de-duplicating the formatter code,
but I'd prefer it if we kept the individual SummaryProvider's per STL.
I.e., the code that extracts the data and size from the type should live in
https://github.com/Nerixyz created
https://github.com/llvm/llvm-project/pull/171858
Split off from #171489. This only adds the lookup of the active type for a
`std::variant` based on the head type (since PDB doesn't have template info).
>From dc76f82f9b3356aac7299f1cb6e2ad77e59b53c9 Mon Sep 17
https://github.com/DrSergei created
https://github.com/llvm/llvm-project/pull/171854
This patch introduces general summary provider for `std::string_view` and
simial types. I tried to remove copy-paste between different stl
implementations. I cannot check now how it works on Windows machine, b
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/168729
>From 2101873001ffd00cb6117e757b222fe197512f08 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 26 Nov 2025 18:25:23 +
Subject: [PATCH 1/6] [lldb][windows] add Windows Virtual Console support
github-actions[bot] wrote:
# :penguin: Linux x64 Test Results
* 33219 tests passed
* 506 tests skipped
* 3 tests failed
## Failed Tests
(click on a test name to see its output)
### lldb-shell
lldb-shell.Commands/command-dwim-print.test
```
Exit Code: 1
Command Output (stdout):
--
# RUN: at
charles-zablit wrote:
Thanks for looking into this!
I was able to get all the tests to pass on Windows:
https://github.com/llvm/llvm-project/pull/171832
I'm not sure about `lldb/test/Shell/Commands/command-expr-diagnostics.test`
however, as it's XFAILed on Windows. I passes on macOS. The prev
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Charles Zablit (charles-zablit)
Changes
This patch improves the way lldb checks if the terminal it's opened in (if any)
supports Unicode or not.
On POSIX systems, we check if `LANG` contains `UTF-8`.
On Windows, we always return `true` si
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/171832
This patch improves the way lldb checks if the terminal it's opened in (if any)
supports Unicode or not.
On POSIX systems, we check if `LANG` contains `UTF-8`.
On Windows, we always return `true` since
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/171820
>From 8591030480b7f752e94ec289be0ba1fb306caa6f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 11 Dec 2025 12:42:10 +
Subject: [PATCH] [lldb][Module] Only log SDK search error once per debugger
se
Author: David Spickett
Date: 2025-12-11T14:04:51Z
New Revision: b2dae2ba6ecaa2d424649fbd9dd6c4d3934b4f2b
URL:
https://github.com/llvm/llvm-project/commit/b2dae2ba6ecaa2d424649fbd9dd6c4d3934b4f2b
DIFF:
https://github.com/llvm/llvm-project/commit/b2dae2ba6ecaa2d424649fbd9dd6c4d3934b4f2b.diff
LOG
@@ -0,0 +1,19 @@
+include "../../../../include/lldb/Core/PropertiesBase.td"
+
+let Definition = "platformwasm" in {
+ def RuntimePath : Property<"runtime-path", "FileSpec">,
+Global,
+DefaultStringValue<"">,
+Desc<"Path
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/171820
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 ready_for_review
https://github.com/llvm/llvm-project/pull/171820
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/171820
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
https://github.com/llvm/llvm-project/pull/171685#issuecomment-3642033568
https://github.com/llvm/llvm-project/pull/171491
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/171820
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/171820
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/171820
>From b31aa38353ed622285802623b26bbed7cbec2185 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 11 Dec 2025 12:42:10 +
Subject: [PATCH] [lldb][Module] Only log SDK search error once per debugger
se
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/171820
>From fcbe4c42381cf6b895bfcf484af82f79d9f1d75f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 11 Dec 2025 12:42:10 +
Subject: [PATCH] [lldb][Module] Only log SDK search error once per debugger
se
https://github.com/Michael137 converted_to_draft
https://github.com/llvm/llvm-project/pull/171820
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-12-11T13:57:26Z
New Revision: 90c340a64b1ce0fa2617994457b091e5ca4b
URL:
https://github.com/llvm/llvm-project/commit/90c340a64b1ce0fa2617994457b091e5ca4b
DIFF:
https://github.com/llvm/llvm-project/commit/90c340a64b1ce0fa2617994457b091e5ca4b.diff
LOG
Author: David Spickett
Date: 2025-12-11T13:54:19Z
New Revision: 60b5d06f7cb0a4de6417f6e6d05ed780e45d844d
URL:
https://github.com/llvm/llvm-project/commit/60b5d06f7cb0a4de6417f6e6d05ed780e45d844d
DIFF:
https://github.com/llvm/llvm-project/commit/60b5d06f7cb0a4de6417f6e6d05ed780e45d844d.diff
LOG
slydiman wrote:
I was able to pass the test `command-options.test` on Windows with the
following regex
```
# CHECK1: {{^ *(\^|˄)(~|˜)}}
# CHECK1: {{^ *.*error: unknown or ambiguous option}}
```
https://github.com/llvm/llvm-project/pull/171685
___
lldb
slydiman wrote:
Note I tried to use the option --input-file=dump.txt with filecheck.exe where
dump.txt is UTF-8 file with valid characters. It did not help.
https://github.com/llvm/llvm-project/pull/171491
___
lldb-commits mailing list
lldb-commits@li
slydiman wrote:
It seems lldb prints unicode to stdout
```
(lldb) log enable -x
˄˜
╰─ error: unknown or ambiguous option
(lldb)
```
but filecheck.exe cannot read unicode from stdin.
It reads `˄˜` (or something else with non-English default locale) instead
github-actions[bot] wrote:
# :penguin: Linux x64 Test Results
The build failed before running any tests. Click on a failure below to see the
details.
tools/lldb/source/Core/CMakeFiles/lldbCore.dir/Module.cpp.o
```
FAILED: tools/lldb/source/Core/CMakeFiles/lldbCore.dir/Module.cpp.o
sccache /
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Currently if we are debugging an app that was compiled against an SDK that we
don't know about on the host, then every time we evaluate an expression we get
following spam on the console (probably one erro
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/171820
Currently if we are debugging an app that was compiled against an SDK that we
don't know about on the host, then every time we evaluate an expression we get
following spam on the console (probably one error
DavidSpickett wrote:
> I didn't want to get too deep into details not directly related to this PR,
> but the overall project is a mac specific one.
Thanks for explaining and now you've explained, I feel justified in getting
Jonas to review :)
https://github.com/llvm/llvm-project/pull/171574
_
@@ -0,0 +1,19 @@
+include "../../../../include/lldb/Core/PropertiesBase.td"
+
+let Definition = "platformwasm" in {
+ def RuntimePath : Property<"runtime-path", "FileSpec">,
+Global,
+DefaultStringValue<"">,
+Desc<"Path
@@ -0,0 +1,19 @@
+include "../../../../include/lldb/Core/PropertiesBase.td"
+
+let Definition = "platformwasm" in {
+ def RuntimePath : Property<"runtime-path", "FileSpec">,
+Global,
+DefaultStringValue<"">,
+Desc<"Path
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/171507
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/171507
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,19 @@
+include "../../../../include/lldb/Core/PropertiesBase.td"
+
+let Definition = "platformwasm" in {
+ def RuntimePath : Property<"runtime-path", "FileSpec">,
+Global,
+DefaultStringValue<"">,
+Desc<"Path
https://github.com/DavidSpickett approved this pull request.
Pedantry on the settings text but otherwise LGTM.
You may want to revise the existing release note for WASM debug. Perhaps adding
to it "LLDB can also start a runtime for you...".
https://github.com/llvm/llvm-project/pull/171507
@@ -0,0 +1,19 @@
+include "../../../../include/lldb/Core/PropertiesBase.td"
+
+let Definition = "platformwasm" in {
+ def RuntimePath : Property<"runtime-path", "FileSpec">,
+Global,
+DefaultStringValue<"">,
+Desc<"Path
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/171507
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,19 @@
+include "../../../../include/lldb/Core/PropertiesBase.td"
+
+let Definition = "platformwasm" in {
+ def RuntimePath : Property<"runtime-path", "FileSpec">,
+Global,
+DefaultStringValue<"">,
+Desc<"Path
charles-zablit wrote:
> Nothing changed
> [lab.llvm.org/buildbot#/builders/197/builds/11757](https://lab.llvm.org/buildbot/#/builders/197/builds/11757)
>
> [lab.llvm.org/buildbot#/builders/211/builds/4494](https://lab.llvm.org/buildbot/#/builders/211/builds/4494)
I reverted the changes.
> Wi
@@ -245,8 +245,10 @@ IOHandlerEditline::IOHandlerEditline(
SetPrompt(prompt);
#if LLDB_ENABLE_LIBEDIT
- const bool use_editline = m_input_sp && m_output_sp && m_error_sp &&
-m_input_sp->GetIsRealTerminal();
+ const bool use_editline =
+ m_i
https://github.com/DavidSpickett approved this pull request.
I might have the details wrong but I see the overall idea.
This LGTM as long as you add clarifying comments about what a file without a
stream would actually represent.
https://github.com/llvm/llvm-project/pull/171733
___
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/171733
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/omjavaid closed
https://github.com/llvm/llvm-project/pull/171797
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 129 matches
Mail list logo
