[Lldb-commits] [lldb] [LLDB] Add SBFrameExtensions Tests (PR #169236)

2025-11-28 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: Hey @ahmednoursphinx! Thanks for contributing to lldb! I was wondering why you decided to group the extension tests that way ? Why not make a different test function for each of the extension. That way we would get a fine-grain test results and it'd be easier to catch regre

[Lldb-commits] [lldb] b38ed00 - [LLDB][PDB] Relax check for resolving breakpoint (#169932)

2025-11-28 Thread via lldb-commits
Author: nerix Date: 2025-11-28T18:14:59+01:00 New Revision: b38ed00495002f4df8b29527fb1cf47317c39d36 URL: https://github.com/llvm/llvm-project/commit/b38ed00495002f4df8b29527fb1cf47317c39d36 DIFF: https://github.com/llvm/llvm-project/commit/b38ed00495002f4df8b29527fb1cf47317c39d36.diff LOG: [L

[Lldb-commits] [lldb] [lldb][windows] refactor CreateProcessW setup (PR #168733)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/168733 >From 71c4fd1953dfa65a215ce347bee3c5d51db41e11 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 19 Nov 2025 16:17:31 + Subject: [PATCH 1/4] [lldb][windows] refactor CreateProcessW setup ---

[Lldb-commits] [lldb] [llvm] [lldb][NativePDB] Fix crash in debugger when PDB has bad type index value (PR #166455)

2025-11-28 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > > Can you add a test that (used to) reproduce(s) the crash? Presumably this > > isn't covered when running the API tests with PDB support? > > Added a test that causes a crash in unpatched code. Done so per @Nerixyz's > advice (i. e. took the YAML file from #166090 and

[Lldb-commits] [lldb] [LLDB][PDB] Relax check for resolving breakpoint (PR #169932)

2025-11-28 Thread via lldb-commits
https://github.com/Nerixyz closed https://github.com/llvm/llvm-project/pull/169932 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Add Windows release binary builds (PR #150793)

2025-11-28 Thread Tom Stellard via lldb-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/150793 >From 2bc5c1ae0c21ebc0bfa28777d19751fe2a811487 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 26 Jul 2025 12:27:08 -0700 Subject: [PATCH 01/67] Add Windows release binary builds --- .github/workflows/

[Lldb-commits] [lldb] [LLDB] Add SBFrameExtensions Tests (PR #169236)

2025-11-28 Thread Ahmed Nour via lldb-commits
ahmednoursphinx wrote: Hey @JDevlieghere please have a look when you have some time on this PR :) https://github.com/llvm/llvm-project/pull/169236 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] [LLDB][PDB] Relax check for resolving breakpoint (PR #169932)

2025-11-28 Thread via lldb-commits
Nerixyz wrote: I'll merge this without a review, because the buildbot is currently failing (see linked comment). https://github.com/llvm/llvm-project/pull/169932 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [lldb] rename fooSynthProvider module (PR #118094)

2025-11-28 Thread via lldb-commits
https://github.com/daniilavdeev closed https://github.com/llvm/llvm-project/pull/118094 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][dotest] use unused variable (PR #169903)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/169903 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][PDB] Relax check for resolving breakpoint (PR #169932)

2025-11-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes The test was flaky, because it assumed that the breakpoint was always resolved before `r` was executed (https://github.com/llvm/llvm-project/pull/169728#issuecomment-3589799783). This removes the check for this ord

[Lldb-commits] [lldb] c2eb332 - [lldb][dotest] use unused variable (#169903)

2025-11-28 Thread via lldb-commits
Author: Charles Zablit Date: 2025-11-28T15:46:58Z New Revision: c2eb332331c4b1e065ff50e08fb038dc63eb754c URL: https://github.com/llvm/llvm-project/commit/c2eb332331c4b1e065ff50e08fb038dc63eb754c DIFF: https://github.com/llvm/llvm-project/commit/c2eb332331c4b1e065ff50e08fb038dc63eb754c.diff LOG

[Lldb-commits] [lldb] [lldb-dap] Fix format string on Mac OS (PR #169933)

2025-11-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Nicolas Miller (npmiller) Changes On Mac `unsigned long long` corresponds to `uint64_t` so `%llu` is needed. Simply always using `%llu` and upcasting to `unsigned long long` should make it work fine. --- Full diff: https://github.com/llvm

[Lldb-commits] [lldb] [LLDB][PDB] Access object file through module (PR #169728)

2025-11-28 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: [lldb-x86_64-win](https://lab.llvm.org/buildbot/#/builders/211/builds/4162) is broken after this patch. ``` FAIL: lldb-shell::add-symbols.cpp [view all 86 lines](https://lab.llvm.org/buildbot/#/builders/211/builds/4162/steps/10/logs/FAIL__lldb-shell__add-symbols_cpp) # | Input

[Lldb-commits] [lldb] [LLDB][PDB] Relax check for resolving breakpoint (PR #169932)

2025-11-28 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/169932 The test was flaky, because it assumed that the breakpoint was always resolved before `r` was executed (https://github.com/llvm/llvm-project/pull/169728#issuecomment-3589799783). This removes the check for thi

[Lldb-commits] [lldb] [lldb-dap] Fix format string on Mac OS (PR #169933)

2025-11-28 Thread Nicolas Miller via lldb-commits
https://github.com/npmiller created https://github.com/llvm/llvm-project/pull/169933 On Mac `unsigned long long` corresponds to `uint64_t` so `%llu` is needed. Simply always using `%llu` and upcasting to `unsigned long long` should make it work fine. >From 3ba244c0b68902eb4b158429cb63d92f37dc

[Lldb-commits] [lldb] [LLDB][PDB] Relax check for resolving breakpoint (PR #169932)

2025-11-28 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/169932 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() returns nullptr (PR #169844)

2025-11-28 Thread via lldb-commits
https://github.com/aahrun updated https://github.com/llvm/llvm-project/pull/169844 >From 28aa746d16753483df75f0208651420a9a5f29c1 Mon Sep 17 00:00:00 2001 From: aaron Date: Thu, 27 Nov 2025 17:25:48 + Subject: [PATCH 1/3] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() return

[Lldb-commits] [lldb] [llvm] [lldb][NativePDB] Fix crash in debugger when PDB has bad type index value (PR #166455)

2025-11-28 Thread Vladimir Gorsunov via lldb-commits
gv wrote: > Can you add a test that (used to) reproduce(s) the crash? Presumably this > isn't covered when running the API tests with PDB support? Added a test that causes a crash in unpatched code. Done so per @Nerixyz's advice (i. e. took the YAML file from #166090 and changed some numbers).

[Lldb-commits] [lldb] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() returns nullptr (PR #169844)

2025-11-28 Thread via lldb-commits
https://github.com/aahrun updated https://github.com/llvm/llvm-project/pull/169844 >From 28aa746d16753483df75f0208651420a9a5f29c1 Mon Sep 17 00:00:00 2001 From: aaron Date: Thu, 27 Nov 2025 17:25:48 + Subject: [PATCH 1/2] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() return

[Lldb-commits] [lldb] [lldb-dap] Add data breakpoints for bytes (PR #167237)

2025-11-28 Thread Sergei Druzhkov via lldb-commits
https://github.com/DrSergei closed https://github.com/llvm/llvm-project/pull/167237 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add data breakpoints for bytes (PR #167237)

2025-11-28 Thread Ebuka Ezike via lldb-commits
@@ -58,24 +76,26 @@ DataBreakpointInfoRequestHandler::Run( if (data.IsValid()) { size = llvm::utostr(data.GetByteSize()); addr = llvm::utohexstr(load_addr); -lldb::SBMemoryRegionInfo region; -lldb::SBError err = -dap.target.GetP

[Lldb-commits] [lldb] [lldb-dap] Add data breakpoints for bytes (PR #167237)

2025-11-28 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. Modulo the double error message. https://github.com/llvm/llvm-project/pull/167237 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] 207627f - [lldb-dap] Add data breakpoints for bytes (#167237)

2025-11-28 Thread via lldb-commits
Author: Sergei Druzhkov Date: 2025-11-28T18:20:20+03:00 New Revision: 207627f20f06771edfbb1e779f94dfdc2ff7df26 URL: https://github.com/llvm/llvm-project/commit/207627f20f06771edfbb1e779f94dfdc2ff7df26 DIFF: https://github.com/llvm/llvm-project/commit/207627f20f06771edfbb1e779f94dfdc2ff7df26.dif

[Lldb-commits] [lldb] [lldb-dap] Add data breakpoints for bytes (PR #167237)

2025-11-28 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/167237 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][windows] add Windows Virtual Console support (PR #168729)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/168729 >From d9c22f7f38d96cfa3a24ed8e193037c1f56cef34 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 26 Nov 2025 18:25:23 + Subject: [PATCH] [lldb][windows] add Windows Virtual Console support ---

[Lldb-commits] [lldb] [NFC][lldb] document Process::SetSTDIOFileDescriptor (PR #169849)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/169849 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add data breakpoints for bytes (PR #167237)

2025-11-28 Thread Sergei Druzhkov via lldb-commits
https://github.com/DrSergei updated https://github.com/llvm/llvm-project/pull/167237 >From 482c89dcee876a9d50b0ecc0a9e90482a2d9c94a Mon Sep 17 00:00:00 2001 From: Druzhkov Sergei Date: Sat, 8 Nov 2025 22:41:39 +0300 Subject: [PATCH 1/6] [lldb-dap] Add data breakpoints for bytes --- .../test/t

[Lldb-commits] [lldb] [lldb-dap] Add data breakpoints for bytes (PR #167237)

2025-11-28 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/167237 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9999c31 - [NFC][lldb] document Process::SetSTDIOFileDescriptor (#169849)

2025-11-28 Thread via lldb-commits
Author: Charles Zablit Date: 2025-11-28T14:27:52Z New Revision: c316968ffdb77a69f883f8ddbdfe0b57a44b URL: https://github.com/llvm/llvm-project/commit/c316968ffdb77a69f883f8ddbdfe0b57a44b DIFF: https://github.com/llvm/llvm-project/commit/c316968ffdb77a69f883f8ddbdfe0b57a44b.diff LOG

[Lldb-commits] [lldb] [llvm] Add Windows release binary builds (PR #150793)

2025-11-28 Thread Tom Stellard via lldb-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/150793 >From 2bc5c1ae0c21ebc0bfa28777d19751fe2a811487 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 26 Jul 2025 12:27:08 -0700 Subject: [PATCH 01/66] Add Windows release binary builds --- .github/workflows/

[Lldb-commits] [lldb] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() returns nullptr (PR #169844)

2025-11-28 Thread via lldb-commits
aahrun wrote: > we could also update it here. both the `module_id` type and the call to > `llvm::StringRef`. > > https://github.com/llvm/llvm-project/blob/6c0d5aad7fa8756221a415fc3bf2bb6c7bf974f6/lldb/tools/lldb-dap/Handler/CompileUnitsRequestHandler.cpp#L63-L68 > > Do you by any chance have a

[Lldb-commits] [lldb] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() returns nullptr (PR #169844)

2025-11-28 Thread via lldb-commits
https://github.com/aahrun updated https://github.com/llvm/llvm-project/pull/169844 >From 28aa746d16753483df75f0208651420a9a5f29c1 Mon Sep 17 00:00:00 2001 From: aaron Date: Thu, 27 Nov 2025 17:25:48 + Subject: [PATCH 1/2] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() return

[Lldb-commits] [lldb] [LLDB][PDB] Access object file through module (PR #169728)

2025-11-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: I did not realise this test could run anywhere, knowing that resolves all my comments, thanks. https://github.com/llvm/llvm-project/pull/169728 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [LLDB][PDB] Access object file through module (PR #169728)

2025-11-28 Thread via lldb-commits
@@ -0,0 +1,39 @@ +// REQUIRES: lld, target-windows Nerixyz wrote: On Windows, it wouldn't require LLD, but on other platforms it requires `lld-link` to be available ([used as the linker](https://github.com/llvm/llvm-project/blob/346f48ecbcd5a2ba63b3947f3593acce

[Lldb-commits] [lldb] [NFC][lldb] document Process::SetSTDIOFileDescriptor (PR #169849)

2025-11-28 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/169849 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][PDB] Access object file through module (PR #169728)

2025-11-28 Thread via lldb-commits
https://github.com/Nerixyz closed https://github.com/llvm/llvm-project/pull/169728 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cc72171 - [LLDB][PDB] Access object file through module (#169728)

2025-11-28 Thread via lldb-commits
Author: nerix Date: 2025-11-28T14:58:32+01:00 New Revision: cc72171322a982b3d39a2688c45372ee7b5f8b67 URL: https://github.com/llvm/llvm-project/commit/cc72171322a982b3d39a2688c45372ee7b5f8b67 DIFF: https://github.com/llvm/llvm-project/commit/cc72171322a982b3d39a2688c45372ee7b5f8b67.diff LOG: [L

[Lldb-commits] [lldb] [LLDB][PDB] Access object file through module (PR #169728)

2025-11-28 Thread via lldb-commits
@@ -0,0 +1,39 @@ +// REQUIRES: lld, target-windows + +// Test that `target symbols add ` works. +// RUN: %build --compiler=clang-cl --nodefaultlib --output=%t.exe %s Nerixyz wrote: (I think) clang-cl is the only compiler that's guaranteed to be available on `tar

[Lldb-commits] [lldb] [NFC][lldb] document Process::SetSTDIOFileDescriptor (PR #169849)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/169849 >From 16254da649fe8eee3b1124179d9c06dfca265eb7 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Thu, 27 Nov 2025 18:28:13 + Subject: [PATCH 1/2] [NFC][lldb] document Process::SetSTDIOFileDescriptor

[Lldb-commits] [lldb] [NFC][lldb] document Process::SetSTDIOFileDescriptor (PR #169849)

2025-11-28 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > We could also clarify that there is no separation of stdout and stderr. Added a small paragraph to explain that, thanks! 👍 https://github.com/llvm/llvm-project/pull/169849 ___ lldb-commits mailing list [email protected].

[Lldb-commits] [lldb] [lldb-dap] Add data breakpoints for bytes (PR #167237)

2025-11-28 Thread Sergei Druzhkov via lldb-commits
https://github.com/DrSergei updated https://github.com/llvm/llvm-project/pull/167237 >From 482c89dcee876a9d50b0ecc0a9e90482a2d9c94a Mon Sep 17 00:00:00 2001 From: Druzhkov Sergei Date: Sat, 8 Nov 2025 22:41:39 +0300 Subject: [PATCH 1/5] [lldb-dap] Add data breakpoints for bytes --- .../test/t

[Lldb-commits] [lldb] [lldb][dotest] use unused variable (PR #169903)

2025-11-28 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/169903 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb] document Process::SetSTDIOFileDescriptor (PR #169849)

2025-11-28 Thread Ebuka Ezike via lldb-commits
da-viper wrote: We could also clarify that there is no separation of stdout and stderr. https://github.com/llvm/llvm-project/pull/169849 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb] Fix duplicate test class name causing lldb-dotest conflict (PR #169861)

2025-11-28 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/169861 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add data breakpoints for bytes (PR #167237)

2025-11-28 Thread Ebuka Ezike via lldb-commits
@@ -58,24 +75,31 @@ DataBreakpointInfoRequestHandler::Run( if (data.IsValid()) { size = llvm::utostr(data.GetByteSize()); addr = llvm::utohexstr(load_addr); -lldb::SBMemoryRegionInfo region; -lldb::SBError err = -dap.target.GetP

[Lldb-commits] [lldb] [lldb-dap] Add data breakpoints for bytes (PR #167237)

2025-11-28 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/167237 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add data breakpoints for bytes (PR #167237)

2025-11-28 Thread Ebuka Ezike via lldb-commits
@@ -676,7 +676,14 @@ llvm::json::Value CreateThreadStopped(DAP &dap, lldb::SBThread &thread, EmplaceSafeString(body, "description", desc_str); } } break; - case lldb::eStopReasonWatchpoint: + case lldb::eStopReasonWatchpoint: { +body.try_emplace("reason", "da

[Lldb-commits] [lldb] 14fb59a - [lldb] Fix duplicate test class name causing lldb-dotest conflict (#169861)

2025-11-28 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-11-28T12:09:23Z New Revision: 14fb59a2c25d2b010ce7b88eb3d201de65e5afed URL: https://github.com/llvm/llvm-project/commit/14fb59a2c25d2b010ce7b88eb3d201de65e5afed DIFF: https://github.com/llvm/llvm-project/commit/14fb59a2c25d2b010ce7b88eb3d201de65e5afed.diff LOG: [

[Lldb-commits] [lldb] [lldb-dap] Add data breakpoints for bytes (PR #167237)

2025-11-28 Thread Ebuka Ezike via lldb-commits
da-viper wrote: only show the args.name when `args.address` as it is duplicated twice. https://github.com/user-attachments/assets/2c28cd2e-b325-4658-b64a-dddbbe2bc7f9"; /> https://github.com/llvm/llvm-project/pull/167237 ___

[Lldb-commits] [lldb] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() returns nullptr (PR #169844)

2025-11-28 Thread Ebuka Ezike via lldb-commits
@@ -554,7 +554,8 @@ llvm::json::Value CreateStackFrame(DAP &dap, lldb::SBFrame &frame, lldb::SBModule module = frame.GetModule(); if (module.IsValid()) { -std::string uuid = module.GetUUIDString(); +const char *uuid_cstr = module.GetUUIDString(); +std::string

[Lldb-commits] [lldb] [lldb][dotest] use unused variable (PR #169903)

2025-11-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes `skipped_categories_list` was unused in `dotest.py`. This patch ensures it's used where intended. 2238dcc39358353cac21df75c3c3286ab20b8f53 switched to using `configuration.skip_categories` directly

[Lldb-commits] [lldb] [NFC][lldb][windows] fully qualify references to MemoryRegionInfo (PR #169845)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/169845 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb][windows] fully qualify references to MemoryRegionInfo (PR #169845)

2025-11-28 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > > which causes a build error when editing building with > > "when building with" Fixed, thanks! https://github.com/llvm/llvm-project/pull/169845 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/

[Lldb-commits] [lldb] fb3bf5b - [NFC][lldb][windows] fully qualify references to MemoryRegionInfo (#169845)

2025-11-28 Thread via lldb-commits
Author: Charles Zablit Date: 2025-11-28T11:40:40Z New Revision: fb3bf5b5900867f0738162d737e138ebd0228f8c URL: https://github.com/llvm/llvm-project/commit/fb3bf5b5900867f0738162d737e138ebd0228f8c DIFF: https://github.com/llvm/llvm-project/commit/fb3bf5b5900867f0738162d737e138ebd0228f8c.diff LOG

[Lldb-commits] [lldb] [LLDB][PDB] Access object file through module (PR #169728)

2025-11-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,39 @@ +// REQUIRES: lld, target-windows DavidSpickett wrote: Does it need lld? Doesn't really matter though, it wants clang-cl and lld will be next to it anyway. https://github.com/llvm/llvm-project/pull/169728 __

[Lldb-commits] [lldb] [LLDB][PDB] Access object file through module (PR #169728)

2025-11-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/169728 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb][windows] fully qualify references to MemoryRegionInfo (PR #169845)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/169845 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][PDB] Access object file through module (PR #169728)

2025-11-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,39 @@ +// REQUIRES: lld, target-windows + +// Test that `target symbols add ` works. +// RUN: %build --compiler=clang-cl --nodefaultlib --output=%t.exe %s DavidSpickett wrote: Specifically clang-cl why? Because you want to make sure you get a PDB and

[Lldb-commits] [lldb] [lldb] Fix duplicate test class name causing lldb-dotest conflict (PR #169861)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit approved this pull request. https://github.com/llvm/llvm-project/pull/169861 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][windows] add Windows Virtual Console support (PR #168729)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/168729 >From 3c4592e3c2c10b52c9f8e3e02ab56d228ce62ca0 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 26 Nov 2025 18:25:23 + Subject: [PATCH] [lldb][windows] add Windows Virtual Console support ---

[Lldb-commits] [lldb] [lldb][dotest] use unused variable (PR #169903)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/169903 `skipped_categories_list` was unused in `dotest.py`. This patch ensures it's used where intended. 2238dcc39358353cac21df75c3c3286ab20b8f53 switched to using `configuration.skip_categories` directly when

[Lldb-commits] [lldb] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() returns nullptr (PR #169844)

2025-11-28 Thread Ebuka Ezike via lldb-commits
da-viper wrote: we could also update it here. both the `module_id` type and the call to `llvm::StringRef`. https://github.com/llvm/llvm-project/blob/6c0d5aad7fa8756221a415fc3bf2bb6c7bf974f6/lldb/tools/lldb-dap/Handler/CompileUnitsRequestHandler.cpp#L63-L68 --- Do you by any chance have a repr

[Lldb-commits] [lldb] [LLDB][PDB] Access object file through module (PR #169728)

2025-11-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM Some questions about the tools but there are probably good reasons for your choices. https://github.com/llvm/llvm-project/pull/169728 ___ lldb-commits mailing list [email protected]

[Lldb-commits] [lldb] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() returns nullptr (PR #169844)

2025-11-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/169844 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix duplicate test class name causing lldb-dotest conflict (PR #169861)

2025-11-28 Thread Michael Buch via lldb-commits
Michael137 wrote: > LGTM > > > > On the surface this sounds like a pretty silly restriction, but I can't > remember what the reason for it is. Probably because the test framework makes > a giant pile of Python classes, right? So not something we would be able to > fix easily. > > > > Not

[Lldb-commits] [lldb] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() returns nullptr (PR #169844)

2025-11-28 Thread David Spickett via lldb-commits
@@ -554,7 +554,8 @@ llvm::json::Value CreateStackFrame(DAP &dap, lldb::SBFrame &frame, lldb::SBModule module = frame.GetModule(); if (module.IsValid()) { -std::string uuid = module.GetUUIDString(); +const char *uuid_cstr = module.GetUUIDString(); +std::string

[Lldb-commits] [lldb] [lldb] Fix duplicate test class name causing lldb-dotest conflict (PR #169861)

2025-11-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Yeah and it is easier Definitely, I would be the first to complain if we took away that feature :) https://github.com/llvm/llvm-project/pull/169861 ___ lldb-commits mailing list [email protected] https://lists.llvm.org

[Lldb-commits] [lldb] [lldb] Fix duplicate test class name causing lldb-dotest conflict (PR #169861)

2025-11-28 Thread Ebuka Ezike via lldb-commits
da-viper wrote: > Probably because the test framework makes a giant pile of Python classes, > right? Yeah and it is easier to do `lldb-dotest -p TestClass.py` without resolving the actual path to the test. https://github.com/llvm/llvm-project/pull/169861 _

[Lldb-commits] [lldb] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() returns nullptr (PR #169844)

2025-11-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: Looks fine, only thing is whether it's easy to add a test for this, probably too much effort. Nominate @da-viper as an lldb-dap expert to decide that. https://github.com/llvm/llvm-project/pull/169844 ___ ll

[Lldb-commits] [lldb] [NFC][lldb][windows] fully qualify references to MemoryRegionInfo (PR #169845)

2025-11-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: > which causes a build error when editing building with "when building with" https://github.com/llvm/llvm-project/pull/169845 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [NFC][lldb][windows] fully qualify references to MemoryRegionInfo (PR #169845)

2025-11-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM Please include a docs link in the PR description. I think https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-queryvirtualmemoryinformation is good enough, the table at the bottom has minimum versions. No

[Lldb-commits] [lldb] [lldb] Fix duplicate test class name causing lldb-dotest conflict (PR #169861)

2025-11-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM On the surface this sounds like a pretty silly restriction, but I can't remember what the reason for it is. Probably because the test framework makes a giant pile of Python classes, right? So not something we would be able to fi

[Lldb-commits] [lldb] [lldb-dap] Add data breakpoints for bytes (PR #167237)

2025-11-28 Thread Sergei Druzhkov via lldb-commits
https://github.com/DrSergei updated https://github.com/llvm/llvm-project/pull/167237 >From 482c89dcee876a9d50b0ecc0a9e90482a2d9c94a Mon Sep 17 00:00:00 2001 From: Druzhkov Sergei Date: Sat, 8 Nov 2025 22:41:39 +0300 Subject: [PATCH 1/4] [lldb-dap] Add data breakpoints for bytes --- .../test/t

[Lldb-commits] [lldb] [lldb] Fix duplicate test class name causing lldb-dotest conflict (PR #169861)

2025-11-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes Duplicate test class name `TestFrameVarDILPointerArithmetic` prevents lldb-dotest from running any tests. The conflict exists between: - lldb/test/API/commands/frame/vardil/expr/PointerArithmetic/ - lldb/test/

[Lldb-commits] [lldb] [lldb] Fix duplicate test class name causing lldb-dotest conflict (PR #169861)

2025-11-28 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/169861 Duplicate test class name `TestFrameVarDILPointerArithmetic` prevents lldb-dotest from running any tests. The conflict exists between: - lldb/test/API/commands/frame/vardil/expr/PointerArithmetic/ - lldb/test/A

[Lldb-commits] [lldb] [lldb] [disassembler] chore: enhance VariableAnnotator to return structured data (PR #165163)

2025-11-28 Thread via lldb-commits
https://github.com/n2h9 edited https://github.com/llvm/llvm-project/pull/165163 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [disassembler] chore: enhance VariableAnnotator to return structured data (PR #165163)

2025-11-28 Thread via lldb-commits
https://github.com/n2h9 converted_to_draft https://github.com/llvm/llvm-project/pull/165163 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][windows] add Windows Virtual Console support (PR #168729)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit ready_for_review https://github.com/llvm/llvm-project/pull/168729 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][windows] add Windows Virtual Console support (PR #168729)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/168729 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb] document Process::SetSTDIOFileDescriptor (PR #169849)

2025-11-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/169849.diff 1 Files Affected: - (modified) lldb/include/lldb/Target/Process.h (+19) ``diff diff --git a/lldb/include/lldb/Target

[Lldb-commits] [lldb] [NFC][lldb] document Process::SetSTDIOFileDescriptor (PR #169849)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/169849 None >From 16254da649fe8eee3b1124179d9c06dfca265eb7 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Thu, 27 Nov 2025 18:28:13 + Subject: [PATCH] [NFC][lldb] document Process::SetSTDIOFileDescript

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/168729 >From a4d3b99079b19693f71a59bd4688a67e63178024 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 26 Nov 2025 18:25:23 + Subject: [PATCH] [lldb][windows] add Windows Virtual Console support ---

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/168729 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/168729 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/168729 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() returns nullptr (PR #169844)

2025-11-28 Thread via lldb-commits
https://github.com/aahrun created https://github.com/llvm/llvm-project/pull/169844 When creating a stack frame in JSONUtils.cpp CreateStackFrame() the code constructs a std::string from module.GetUUIDString(), which can return nullptr in some cases (as documented in the implementation of SBMo

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/168729 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() returns nullptr (PR #169844)

2025-11-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Aaron (aahrun) Changes When creating a stack frame in JSONUtils.cpp CreateStackFrame() the code constructs a std::string from module.GetUUIDString(), which can return nullptr in some cases (as documented in the implementation of SBModule:

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

2025-11-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions h,cpp -- lldb/include/lldb/Host/windows/PseudoTerminalW

[Lldb-commits] [lldb] [NFC][lldb][windows] fully qualify references to MemoryRegionInfo (PR #169845)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/169845 This is an NFC patch which fully qualifies references to `MemoryRegionInfo` in lldb. The Windows API exposes an enum value named `MemoryRegionInfo` which causes a build error when editing building with

[Lldb-commits] [lldb] [lldb-dap] Fix segfault in JSONUtils.cpp when GetUUIDString() returns nullptr (PR #169844)

2025-11-28 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/168729 >From ecee56712487c5af7fee145beffe48ecde04bd0d Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 26 Nov 2025 18:25:23 + Subject: [PATCH] [lldb][windows] add Windows Virtual Console support ---

[Lldb-commits] [lldb] [NFC][lldb][windows] fully qualify references to MemoryRegionInfo (PR #169845)

2025-11-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes This is an NFC patch which fully qualifies references to `MemoryRegionInfo` in lldb. The Windows API exposes an enum value named `MemoryRegionInfo` which causes a build error when editing building w

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/168729 >From 2c16cbeec28fd5f0834a1d5d6b03603fcece5eb6 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 26 Nov 2025 18:25:23 + Subject: [PATCH] [lldb][windows] add Windows Virtual Console support ---

[Lldb-commits] [lldb] [llvm] [DRAFT][lldb][windows] add Windows Virtual Console support (PR #168729)

2025-11-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/168729 >From 6a48200f55512eb71e0af20604b8b45fd32e2057 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 26 Nov 2025 18:25:23 + Subject: [PATCH] [lldb][windows] add Windows Virtual Console support ---

[Lldb-commits] [lldb] [lldb] Fix CxxMethodName Parser on return type (PR #169652)

2025-11-28 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/169652 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 90e8889 - [lldb] Fix CxxMethodName Parser on return type (#169652)

2025-11-28 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-11-27T15:09:05Z New Revision: 90e8889a6394e29843ba903eff45ca03f877a6dd URL: https://github.com/llvm/llvm-project/commit/90e8889a6394e29843ba903eff45ca03f877a6dd DIFF: https://github.com/llvm/llvm-project/commit/90e8889a6394e29843ba903eff45ca03f877a6dd.diff LOG: [

[Lldb-commits] [lldb] [lldb] Fix CxxMethodName Parser on return type (PR #169652)

2025-11-28 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/169652 >From a0f2bcd3b3361572d68e11b6ee3b4284bc97679b Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 26 Nov 2025 13:52:51 + Subject: [PATCH 1/3] [lldb] fix CxxMethodName Parser. The simplified parser incor

[Lldb-commits] [lldb] [llvm] Add Windows release binary builds (PR #150793)

2025-11-28 Thread Tom Stellard via lldb-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/150793 >From 2bc5c1ae0c21ebc0bfa28777d19751fe2a811487 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 26 Jul 2025 12:27:08 -0700 Subject: [PATCH 01/65] Add Windows release binary builds --- .github/workflows/

  1   2   3   4   >