[Lldb-commits] [lldb] [lldb][AIX] Added RegisterInfo file for PPC64 (PR #165367)

2025-10-29 Thread Hemang Gadhavi via lldb-commits
HemangGadhavi wrote: @DavidSpickett Agreed — the existing ppc64le implementation doesn’t contain much endianness-specific logic. However, reusing and renaming the existing ppc64le code would require several modifications to the current linux_ppc64le implementation, which we’d prefer to keep i

[Lldb-commits] [lldb] [LLDB][Windows]: Don't pass duplicate HANDLEs to CreateProcess (PR #165281)

2025-10-29 Thread Charles Zablit via lldb-commits
charles-zablit wrote: Hey @lb90, your PR broke some of the build bots. Can you please take a look? https://github.com/llvm/llvm-project/pull/165281 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [clang] [lldb] [llvm] [mlir] fix(security): Address CodeQL Uncontrolled Data in Path Expression vulnerability (PR #160531)

2025-10-29 Thread Anton Korobeynikov via lldb-commits
https://github.com/asl locked https://github.com/llvm/llvm-project/pull/160531 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] fix(security): Address CodeQL Uncontrolled Data in Path Expression vulnerability (PR #160531)

2025-10-29 Thread Anton Korobeynikov via lldb-commits
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/160531 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Windows]: Don't pass duplicate HANDLEs to CreateProcess (PR #165281)

2025-10-29 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/12624 Here is the relevant piece of

[Lldb-commits] [lldb] [lldb][Android] Fix platform process list regression (PR #164333)

2025-10-29 Thread Chad Smith via lldb-commits
https://github.com/cs01 updated https://github.com/llvm/llvm-project/pull/164333 >From 40a0544f077a7fc28e53d335e073b482618d33db Mon Sep 17 00:00:00 2001 From: Chad Smith Date: Mon, 20 Oct 2025 14:18:16 -0700 Subject: [PATCH] [lldb][Android] Fix platform process list regression after FindProcess

[Lldb-commits] [lldb] [lldb][Android] Fix platform process list regression (PR #164333)

2025-10-29 Thread Chad Smith via lldb-commits
@@ -479,246 +481,131 @@ std::string PlatformAndroid::GetRunAs() { return run_as.str(); } -// Helper function to populate process status information from -// /proc/[pid]/status -void PlatformAndroid::PopulateProcessStatusInfo( -lldb::pid_t pid, ProcessInstanceInfo &proces

[Lldb-commits] [lldb] [lldb][Android] Fix platform process list regression (PR #164333)

2025-10-29 Thread Chad Smith via lldb-commits
@@ -479,246 +481,131 @@ std::string PlatformAndroid::GetRunAs() { return run_as.str(); } -// Helper function to populate process status information from -// /proc/[pid]/status -void PlatformAndroid::PopulateProcessStatusInfo( -lldb::pid_t pid, ProcessInstanceInfo &proces

[Lldb-commits] [lldb] [lldb][Android] Fix platform process list regression (PR #164333)

2025-10-29 Thread Chad Smith via lldb-commits
@@ -479,246 +481,131 @@ std::string PlatformAndroid::GetRunAs() { return run_as.str(); } -// Helper function to populate process status information from -// /proc/[pid]/status -void PlatformAndroid::PopulateProcessStatusInfo( -lldb::pid_t pid, ProcessInstanceInfo &proces

[Lldb-commits] [lldb] a49bfbe - [lldb-dap] Improving consistency of tests by removing concurrency. (#165496)

2025-10-29 Thread via lldb-commits
Author: John Harrison Date: 2025-10-29T13:52:42-07:00 New Revision: a49bfbeb15418ccf51ed1bad8d60d5fe6830353b URL: https://github.com/llvm/llvm-project/commit/a49bfbeb15418ccf51ed1bad8d60d5fe6830353b DIFF: https://github.com/llvm/llvm-project/commit/a49bfbeb15418ccf51ed1bad8d60d5fe6830353b.diff

[Lldb-commits] [lldb] [lldb-dap] Improving consistency of tests by removing concurrency. (PR #165496)

2025-10-29 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/165496 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Android] Fix platform process list regression (PR #164333)

2025-10-29 Thread Jonas Devlieghere via lldb-commits
@@ -479,246 +481,131 @@ std::string PlatformAndroid::GetRunAs() { return run_as.str(); } -// Helper function to populate process status information from -// /proc/[pid]/status -void PlatformAndroid::PopulateProcessStatusInfo( -lldb::pid_t pid, ProcessInstanceInfo &proces

[Lldb-commits] [lldb] [lldb][Android] Fix platform process list regression (PR #164333)

2025-10-29 Thread Jonas Devlieghere via lldb-commits
@@ -479,246 +481,131 @@ std::string PlatformAndroid::GetRunAs() { return run_as.str(); } -// Helper function to populate process status information from -// /proc/[pid]/status -void PlatformAndroid::PopulateProcessStatusInfo( -lldb::pid_t pid, ProcessInstanceInfo &proces

[Lldb-commits] [lldb] [lldb][Android] Fix platform process list regression (PR #164333)

2025-10-29 Thread Jonas Devlieghere via lldb-commits
@@ -479,246 +481,131 @@ std::string PlatformAndroid::GetRunAs() { return run_as.str(); } -// Helper function to populate process status information from -// /proc/[pid]/status -void PlatformAndroid::PopulateProcessStatusInfo( -lldb::pid_t pid, ProcessInstanceInfo &proces

[Lldb-commits] [lldb] [llvm] [LLDB] Use native PDB reader by default (PR #165363)

2025-10-29 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: Ok, thanks. https://github.com/llvm/llvm-project/pull/165363 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Improving consistency of tests by removing concurrency. (PR #165496)

2025-10-29 Thread John Harrison via lldb-commits
@@ -1,58 +1,52 @@ -import dap_server +""" +Test 'module' events for dynamically loaded libraries. +""" + from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * -from lldbsuite.test import lldbutil import lldbdap_testcase -import re class TestDAP_modu

[Lldb-commits] [lldb] [lldb-dap] Improving consistency of tests by removing concurrency. (PR #165496)

2025-10-29 Thread John Harrison via lldb-commits
@@ -1,58 +1,52 @@ -import dap_server +""" +Test 'module' events for dynamically loaded libraries. +""" + from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * -from lldbsuite.test import lldbutil import lldbdap_testcase -import re class TestDAP_modu

[Lldb-commits] [lldb] [lldb-dap] Improving consistency of tests by removing concurrency. (PR #165496)

2025-10-29 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/165496 >From 9f771a40d55f98bf426b96a5d878b295ab5e06db Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 28 Oct 2025 17:40:07 -0700 Subject: [PATCH 1/3] [lldb-dap] Improving consistency of tests by removing concur

[Lldb-commits] [lldb] [lldb-dap][test] skip io_redirection in debug builds (PR #165593)

2025-10-29 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/165593 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread via lldb-commits
@@ -12,6 +12,10 @@ class MultipleSlidesTestCase(TestBase): NO_DEBUG_INFO_TESTCASE = True +# The intermediate object main.o is compiled without debug info, but +# a.out is linked with `-gdwarf` on Windows. This creates a PDB. Nerixyz wrote: Opened

[Lldb-commits] [lldb] [llvm] [LLDB] Use native PDB reader by default (PR #165363)

2025-10-29 Thread via lldb-commits
Nerixyz wrote: > The buildbots > [lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197/builds/10342) > and > [lldb-aarch64-windows](https://lab.llvm.org/buildbot/#/builders/141/builds/12614) > are broken too. They're no longer broken after the two PRs. https://github.com/llv

[Lldb-commits] [lldb] [llvm] [LLDB] Use native PDB reader by default (PR #165363)

2025-10-29 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > LLVM Buildbot has detected a new failure on builder `lldb-x86_64-win` running > on `as-builder-10` while building `lldb,llvm` at step 8 > "test-check-lldb-unit". The buildbots [lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197/builds/10342) and [lldb-aarc

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 1 of 3. (PR #165199)

2025-10-29 Thread Ilia Kuklin via lldb-commits
@@ -608,4 +608,16 @@ Interpreter::Visit(const BooleanLiteralNode *node) { return ValueObject::CreateValueObjectFromBool(m_target, value, "result"); } +llvm::Expected +Interpreter::Visit(const CStyleCastNode *node) { + auto operand_or_err = Evaluate(node->GetOperand()); + i

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 1 of 3. (PR #165199)

2025-10-29 Thread Ilia Kuklin via lldb-commits
@@ -274,6 +323,81 @@ std::string DILParser::ParseNestedNameSpecifier() { } } +// Parse a type_id. +// +// type_id: +//type_specifier_seq [abstract_declarator] +// +// type_specifier_seq: +//type_specifier [type_specifier] +// +// type_specifier: +//["::"] [nes

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 1 of 3. (PR #165199)

2025-10-29 Thread Ilia Kuklin via lldb-commits
@@ -339,6 +463,40 @@ std::string DILParser::ParseUnqualifiedId() { return identifier; } +CompilerType +DILParser::ResolveTypeDeclarators(CompilerType type, + const std::vector &ptr_operators) { + CompilerType bad_type; + // Resolve pointers

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 1 of 3. (PR #165199)

2025-10-29 Thread Ilia Kuklin via lldb-commits
@@ -35,6 +36,14 @@ enum class UnaryOpKind { Deref, // "*" }; +/// The C-Style casts allowed by DIL. kuilpd wrote: We might implement at least `static_cast` and `reinterpret_cast` later. Since we are trying to emulate the C-style behavior here, I think it'

[Lldb-commits] [lldb] [lldb-dap] Report any errors during attach request (PR #165270)

2025-10-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/165270 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b17f1fd - [lldb-dap] Report any errors during attach request (#165270)

2025-10-29 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-10-29T18:53:00Z New Revision: b17f1fd6766a5b36b06df734ee577f7dae9cb964 URL: https://github.com/llvm/llvm-project/commit/b17f1fd6766a5b36b06df734ee577f7dae9cb964 DIFF: https://github.com/llvm/llvm-project/commit/b17f1fd6766a5b36b06df734ee577f7dae9cb964.diff LOG: [

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread Michael Buch via lldb-commits
@@ -12,6 +12,10 @@ class MultipleSlidesTestCase(TestBase): NO_DEBUG_INFO_TESTCASE = True +# The intermediate object main.o is compiled without debug info, but +# a.out is linked with `-gdwarf` on Windows. This creates a PDB. Michael137 wrote: Is Z

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread via lldb-commits
https://github.com/Nerixyz closed https://github.com/llvm/llvm-project/pull/165604 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 17c6c8d - [LLDB] Skip TestMultipleSlides.py on Windows (#165604)

2025-10-29 Thread via lldb-commits
Author: nerix Date: 2025-10-29T18:48:33Z New Revision: 17c6c8da56f6d34ddf8f8162b1b730a158bc8019 URL: https://github.com/llvm/llvm-project/commit/17c6c8da56f6d34ddf8f8162b1b730a158bc8019 DIFF: https://github.com/llvm/llvm-project/commit/17c6c8da56f6d34ddf8f8162b1b730a158bc8019.diff LOG: [LLDB]

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/165604 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread Michael Buch via lldb-commits
@@ -12,6 +12,10 @@ class MultipleSlidesTestCase(TestBase): NO_DEBUG_INFO_TESTCASE = True +# The intermediate object main.o is compiled without debug info, but +# a.out is linked with `-gdwarf` on Windows. This creates a PDB. Michael137 wrote: Seem

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread via lldb-commits
https://github.com/Nerixyz auto_merge_enabled https://github.com/llvm/llvm-project/pull/165604 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/165604 >From 0180d1275a49aad11c214c3c154561d663aceeeb Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Wed, 29 Oct 2025 18:41:41 +0100 Subject: [PATCH 1/3] [LLDB] Skip TestMultipleSlides.py on Windows --- .../API/functio

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread via lldb-commits
@@ -12,6 +12,10 @@ class MultipleSlidesTestCase(TestBase): NO_DEBUG_INFO_TESTCASE = True +# The intermediate object main.o is compiled without debug info, but +# a.out is linked with `-gdwarf` on Windows. This creates a PDB. Nerixyz wrote: I think

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread Michael Buch via lldb-commits
@@ -12,6 +12,10 @@ class MultipleSlidesTestCase(TestBase): NO_DEBUG_INFO_TESTCASE = True +# The intermediate object main.o is compiled without debug info, but +# a.out is linked with `-gdwarf` on Windows. This creates a PDB. Michael137 wrote: Why

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/165604 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread Michael Buch via lldb-commits
Michael137 wrote: In the interim, to unblock CI i suggest we either xfail the test or explicitly enable the DIA plugin on windows for this test https://github.com/llvm/llvm-project/pull/165604 ___ lldb-commits mailing list [email protected]

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/165604 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread via lldb-commits
Nerixyz wrote: There is still some bug with DWARF not including some public symbols on Windows (e.g. vtable symbols). I found this a while ago, but haven't investigated more. https://github.com/llvm/llvm-project/pull/165604 ___ lldb-commits mailing l

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread via lldb-commits
Nerixyz wrote: > So if we had used lld when running this test on Windows with DWARF, it > would've passed? Sorry, I was wrong. The intermediate object, `main.o`, is compiled without debug info. However, the final executable `a.out` is linked with clang and `-gdwarf`. Because of this, clang wi

[Lldb-commits] [lldb] [lldb] Do not narrow `GetIndexOfChildWithName` return type to int (PR #165453)

2025-10-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/165453 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d87c80b - [lldb] Do not narrow `GetIndexOfChildWithName` return type to int (#165453)

2025-10-29 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-10-29T18:22:54Z New Revision: d87c80bd46d9dc761b048cad48838a039cff214a URL: https://github.com/llvm/llvm-project/commit/d87c80bd46d9dc761b048cad48838a039cff214a DIFF: https://github.com/llvm/llvm-project/commit/d87c80bd46d9dc761b048cad48838a039cff214a.diff LOG: [

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/165604 >From 0180d1275a49aad11c214c3c154561d663aceeeb Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Wed, 29 Oct 2025 18:41:41 +0100 Subject: [PATCH 1/2] [LLDB] Skip TestMultipleSlides.py on Windows --- .../API/functio

[Lldb-commits] [lldb] [lldb][Android] Fix platform process list regression (PR #164333)

2025-10-29 Thread Chad Smith via lldb-commits
cs01 wrote: Is @emrekultursay 's approval sufficient or does it need approval from @JDevlieghere before merging? https://github.com/llvm/llvm-project/pull/164333 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [lldb] Do not narrow `GetIndexOfChildWithName` return type to int (PR #165453)

2025-10-29 Thread Ebuka Ezike via lldb-commits
da-viper wrote: > You mentioned some kinds of bad behavior as a result of doing that. Is any of > that testable? Otherwise, LGTM. Could not find a reliable way to test it from the python API. It casts the number back to uint32_t and that is implementation defined. https://github.com/llvm/l

[Lldb-commits] [lldb] [lldb][Android] Fix platform process list regression (PR #164333)

2025-10-29 Thread Chad Smith via lldb-commits
@@ -479,246 +479,128 @@ std::string PlatformAndroid::GetRunAs() { return run_as.str(); } -// Helper function to populate process status information from -// /proc/[pid]/status -void PlatformAndroid::PopulateProcessStatusInfo( -lldb::pid_t pid, ProcessInstanceInfo &proces

[Lldb-commits] [lldb] [lldb][Android] Fix platform process list regression (PR #164333)

2025-10-29 Thread Chad Smith via lldb-commits
@@ -479,246 +479,128 @@ std::string PlatformAndroid::GetRunAs() { return run_as.str(); } -// Helper function to populate process status information from -// /proc/[pid]/status -void PlatformAndroid::PopulateProcessStatusInfo( -lldb::pid_t pid, ProcessInstanceInfo &proces

[Lldb-commits] [lldb] [lldb][Android] Fix platform process list regression (PR #164333)

2025-10-29 Thread Chad Smith via lldb-commits
https://github.com/cs01 updated https://github.com/llvm/llvm-project/pull/164333 >From a443a6ccd78d8e63f1e23b1330e1b216de6bd36d Mon Sep 17 00:00:00 2001 From: Chad Smith Date: Mon, 20 Oct 2025 14:18:16 -0700 Subject: [PATCH] [lldb][Android] Fix platform process list regression after FindProcess

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread Michael Buch via lldb-commits
Michael137 wrote: > When using -gdwarf on Windows, Clang (and LLD) also produce a PDB with the > public symbols So if we had used lld when running this test on Windows with DWARF, it would've passed? https://github.com/llvm/llvm-project/pull/165604

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/165604 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][attempt #3] update lldb-server platform help parsing (PR #164904)

2025-10-29 Thread Chad Smith via lldb-commits
cs01 wrote: ping @adrian-prantl https://github.com/llvm/llvm-project/pull/164904 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes After the default PDB plugin changed to the native one (#165363), this test failed, because it uses the size of public symbols and the native plugin sets the size to 0 (as PDB doesn't include this information explic

[Lldb-commits] [lldb] [lldb] Do not narrow `GetIndexOfChildWithName` return type to int (PR #165453)

2025-10-29 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/165453 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

2025-10-29 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/165604 After the default PDB plugin changed to the native one (#165363), this test failed, because it uses the size of public symbols and the native plugin sets the size to 0 (as PDB doesn't include this information e

[Lldb-commits] [lldb] [LLDB][PDB] Explicitly set DIA plugin in unit test (PR #165592)

2025-10-29 Thread via lldb-commits
https://github.com/Nerixyz closed https://github.com/llvm/llvm-project/pull/165592 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 957598f - [LLDB][PDB] Explicitly set DIA plugin in unit test (#165592)

2025-10-29 Thread via lldb-commits
Author: nerix Date: 2025-10-29T18:38:34+01:00 New Revision: 957598f71bd8baa029d886e59ed9aed60e6e9bb9 URL: https://github.com/llvm/llvm-project/commit/957598f71bd8baa029d886e59ed9aed60e6e9bb9 DIFF: https://github.com/llvm/llvm-project/commit/957598f71bd8baa029d886e59ed9aed60e6e9bb9.diff LOG: [L

[Lldb-commits] [lldb] [LLDB][PDB] Explicitly set DIA plugin in unit test (PR #165592)

2025-10-29 Thread Michael Buch via lldb-commits
Michael137 wrote: > I'm not sure what to do about the other API test (`TestMultipleSlides.py`). > This fails because the native plugin sets the size of symbols to 0. However, > the test shouldn't run with PDB in the first place. I'd suggest opening a PR that just XFAILs/skips the test on Windo

[Lldb-commits] [lldb] [LLDB][PDB] Explicitly set DIA plugin in unit test (PR #165592)

2025-10-29 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/165592 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][PDB] Explicitly set DIA plugin in unit test (PR #165592)

2025-10-29 Thread via lldb-commits
Nerixyz wrote: I'm not sure what to do about the other API test (`TestMultipleSlides.py`). This fails because the native plugin sets the size of symbols to 0. However, the test shouldn't run with PDB in the first place. https://github.com/llvm/llvm-project/pull/165592 _

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add support for SME only systems (PR #165413)

2025-10-29 Thread David Spickett via lldb-commits
@@ -510,8 +562,9 @@ Status NativeRegisterContextLinux_arm64::WriteRegister( } else { // SVE enabled, we will read and cache SVE ptrace data. error = ReadAllSVE(); - if (error.Fail()) + if (error.Fail()) { return error; + } ---

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add support for SME only systems (PR #165413)

2025-10-29 Thread David Spickett via lldb-commits
@@ -349,8 +353,52 @@ NativeRegisterContextLinux_arm64::ReadRegister(const RegisterInfo *reg_info, return Status::FromErrorString("SVE disabled or not supported"); if (GetRegisterInfo().IsSVERegVG(reg)) { + error = ReadSVEHeader(); + if (error.Fail()) { +

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add support for SME only systems (PR #165413)

2025-10-29 Thread David Spickett via lldb-commits
@@ -271,10 +270,11 @@ NativeRegisterContextLinux_arm64::ReadRegister(const RegisterInfo *reg_info, const uint32_t reg = reg_info->kinds[lldb::eRegisterKindLLDB]; - if (reg == LLDB_INVALID_REGNUM) + if (reg == LLDB_INVALID_REGNUM) { DavidSpickett wrote:

[Lldb-commits] [lldb] [lldb] Add alternative SBThread::GetStopDescription (PR #165379)

2025-10-29 Thread Ebuka Ezike via lldb-commits
@@ -224,6 +224,13 @@ AND call SWIG_fail at the same time, because it will result in a double free. } $1 = (char *)malloc($2); } + +// Remove the default type check for this match. +// because if the match function has an overload and a typemap, +// it will typecheck agains

[Lldb-commits] [lldb] [lldb-dap][test] skip io_redirection in debug builds (PR #165593)

2025-10-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes Currently all `runInTerminal` test are skipped in debug builds because, when attaching it times out parsing the debug symbols of lldb-dap. Add this test since it is running in teminal. --- Full diff: https:/

[Lldb-commits] [lldb] [lldb-dap][test] skip io_redirection in debug builds (PR #165593)

2025-10-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/165593 Currently all `runInTerminal` test are skipped in debug builds because, when attaching it times out parsing the debug symbols of lldb-dap. Add this test since it is running in teminal. >From 08095a703546307dc

[Lldb-commits] [lldb] [llvm] [LLDB] Use native PDB reader by default (PR #165363)

2025-10-29 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-win` running on `as-builder-10` while building `lldb,llvm` at step 8 "test-check-lldb-unit". Full details are available at: https://lab.llvm.org/buildbot/#/builders/211/builds/3312 Here is the relevant piece of t

[Lldb-commits] [lldb] [LLDB][PDB] Explicitly set DIA plugin in unit test (PR #165592)

2025-10-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes Fixes the failing DIA unit test (https://lab.llvm.org/buildbot/#/builders/197/builds/10342) after #165363. Now that the native plugin is the default, we need to set the symbol file plugin for DIA via the settings.

[Lldb-commits] [lldb] [LLDB][PDB] Explicitly set DIA plugin in unit test (PR #165592)

2025-10-29 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/165592 Fixes the failing DIA unit test (https://lab.llvm.org/buildbot/#/builders/197/builds/10342) after #165363. Now that the native plugin is the default, we need to set the symbol file plugin for DIA via the setti

[Lldb-commits] [lldb] [lldb-dap] Improving consistency of tests by removing concurrency. (PR #165496)

2025-10-29 Thread Ebuka Ezike via lldb-commits
@@ -1,58 +1,52 @@ -import dap_server +""" +Test 'module' events for dynamically loaded libraries. +""" + from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * -from lldbsuite.test import lldbutil import lldbdap_testcase -import re class TestDAP_modu

[Lldb-commits] [lldb] [lldb-dap] Improving consistency of tests by removing concurrency. (PR #165496)

2025-10-29 Thread Ebuka Ezike via lldb-commits
@@ -1,58 +1,52 @@ -import dap_server +""" +Test 'module' events for dynamically loaded libraries. +""" + from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * -from lldbsuite.test import lldbutil import lldbdap_testcase -import re class TestDAP_modu

[Lldb-commits] [lldb] [lldb-dap] Improving consistency of tests by removing concurrency. (PR #165496)

2025-10-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/165496 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Improving consistency of tests by removing concurrency. (PR #165496)

2025-10-29 Thread John Harrison via lldb-commits
ashgti wrote: > Now if you for example send a breakpoint request. > > It blocks until the default timeout or matches the search predicate ?. > Instead of continuously polling on a different thread. Correct, we do not process any input from lldb-dap until `DebugCommunication._recv_packet` is c

[Lldb-commits] [lldb] [lldb][AIX] Added RegisterInfo file for PPC64 (PR #165367)

2025-10-29 Thread David Spickett via lldb-commits
DavidSpickett wrote: I'm looking at the ppc64le file and there's nothing in there that is endian dependent other than the names of some variables. Please check whether it would be possible to rename parts of the existing ppc64le code and re-use it. There'll be some limit to this of course, but

[Lldb-commits] [lldb] [lldb][AIX] Added RegisterInfo file for PPC64 (PR #165367)

2025-10-29 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/165367 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Improving consistency of tests by removing concurrency. (PR #165496)

2025-10-29 Thread Ebuka Ezike via lldb-commits
da-viper wrote: To Confirm what I read. Now if you for example send a breakpoint request. It blocks until the default timeout or matches the search predicate ?. Instead of continuously polling on a different thread. https://github.com/llvm/llvm-project/pull/165496

[Lldb-commits] [lldb] [lldb-dap] Improving consistency of tests by removing concurrency. (PR #165496)

2025-10-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. The reliability of the DAP tests is a recurring topic at the Developer Meeting this week. Anything we can do in that space is greatly appreciated. https://github.com/llvm/llvm-project/pull/165496

[Lldb-commits] [lldb] [lldb-dap] Improving consistency of tests by removing concurrency. (PR #165496)

2025-10-29 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/165496 >From 9f771a40d55f98bf426b96a5d878b295ab5e06db Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 28 Oct 2025 17:40:07 -0700 Subject: [PATCH 1/2] [lldb-dap] Improving consistency of tests by removing concur

[Lldb-commits] [lldb] [lldb-dap] Improving consistency of tests by removing concurrency. (PR #165496)

2025-10-29 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/165496 >From 9f771a40d55f98bf426b96a5d878b295ab5e06db Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 28 Oct 2025 17:40:07 -0700 Subject: [PATCH 1/2] [lldb-dap] Improving consistency of tests by removing concur

[Lldb-commits] [lldb] [llvm] [LLDB] Use native PDB reader by default (PR #165363)

2025-10-29 Thread via lldb-commits
https://github.com/Nerixyz closed https://github.com/llvm/llvm-project/pull/165363 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 287ca7b - [LLDB] Use native PDB reader by default (#165363)

2025-10-29 Thread via lldb-commits
Author: nerix Date: 2025-10-29T16:51:38+01:00 New Revision: 287ca7b243facc7185bbd9dfdaa5a6a012819e1b URL: https://github.com/llvm/llvm-project/commit/287ca7b243facc7185bbd9dfdaa5a6a012819e1b DIFF: https://github.com/llvm/llvm-project/commit/287ca7b243facc7185bbd9dfdaa5a6a012819e1b.diff LOG: [L

[Lldb-commits] [lldb] [llvm] [LLDB] Use native PDB reader by default (PR #165363)

2025-10-29 Thread via lldb-commits
Nerixyz wrote: Thank you to everyone who helped with the native plugin and LLVM's PDB support! https://github.com/llvm/llvm-project/pull/165363 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] [lldb-dap] Improving consistency of tests by removing concurrency. (PR #165496)

2025-10-29 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. what a good idea https://github.com/llvm/llvm-project/pull/165496 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Report any errors during attach request (PR #165270)

2025-10-29 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/165270 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-10-29 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/154123 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4dfe212 - [lldb][DWARFASTParserClang] Added a check for the specialization existence (#154123)

2025-10-29 Thread via lldb-commits
Author: Timur Golubovich Date: 2025-10-29T12:13:34Z New Revision: 4dfe212dade71e0e4e5ea4609e403f5e523eeb74 URL: https://github.com/llvm/llvm-project/commit/4dfe212dade71e0e4e5ea4609e403f5e523eeb74 DIFF: https://github.com/llvm/llvm-project/commit/4dfe212dade71e0e4e5ea4609e403f5e523eeb74.diff L

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-10-29 Thread via lldb-commits
github-actions[bot] wrote: @tgs-sc Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-10-29 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/154123 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-10-29 Thread Michael Buch via lldb-commits
Michael137 wrote: Ah whoops, was reading this too fast. Thanks! https://github.com/llvm/llvm-project/pull/154123 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 1 of 3. (PR #165199)

2025-10-29 Thread Michael Buch via lldb-commits
@@ -339,6 +463,40 @@ std::string DILParser::ParseUnqualifiedId() { return identifier; } +CompilerType +DILParser::ResolveTypeDeclarators(CompilerType type, + const std::vector &ptr_operators) { + CompilerType bad_type; + // Resolve pointers

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-10-29 Thread Timur Golubovich via lldb-commits
tgs-sc wrote: One of them is ASSERT_NE and the other is ASSERT_EQ https://github.com/llvm/llvm-project/pull/154123 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 1 of 3. (PR #165199)

2025-10-29 Thread Michael Buch via lldb-commits
@@ -274,6 +323,81 @@ std::string DILParser::ParseNestedNameSpecifier() { } } +// Parse a type_id. +// +// type_id: +//type_specifier_seq [abstract_declarator] +// +// type_specifier_seq: +//type_specifier [type_specifier] +// +// type_specifier: +//["::"] [nes

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 1 of 3. (PR #165199)

2025-10-29 Thread Michael Buch via lldb-commits
@@ -339,6 +463,40 @@ std::string DILParser::ParseUnqualifiedId() { return identifier; } +CompilerType +DILParser::ResolveTypeDeclarators(CompilerType type, + const std::vector &ptr_operators) { + CompilerType bad_type; + // Resolve pointers

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 1 of 3. (PR #165199)

2025-10-29 Thread Michael Buch via lldb-commits
@@ -80,15 +82,62 @@ ASTNodeUP DILParser::Run() { // Parse an expression. // // expression: -//unary_expression +//cast_expression // -ASTNodeUP DILParser::ParseExpression() { return ParseUnaryExpression(); } +ASTNodeUP DILParser::ParseExpression() { return ParseCastEx

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-10-29 Thread Michael Buch via lldb-commits
https://github.com/Michael137 requested changes to this pull request. Once last question is resolved I'll go ahead and merge https://github.com/llvm/llvm-project/pull/154123 ___ lldb-commits mailing list [email protected] https://lists.llvm.o

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-10-29 Thread Michael Buch via lldb-commits
Michael137 wrote: Can you remind me why both of these are `nullptr`? Should one of them have succeeded? https://github.com/llvm/llvm-project/pull/154123 ___ lldb-commits mailing list [email protected] https

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-10-29 Thread Michael Buch via lldb-commits
Michael137 wrote: Sure let's give this a go https://github.com/llvm/llvm-project/pull/154123 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 1 of 3. (PR #165199)

2025-10-29 Thread Michael Buch via lldb-commits
@@ -35,6 +36,14 @@ enum class UnaryOpKind { Deref, // "*" }; +/// The C-Style casts allowed by DIL. Michael137 wrote: Apologies if I'm late to the discussion, but should we be calling it C-style? I know it's inspired by the C-style casts, but Is there goi

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 1 of 3. (PR #165199)

2025-10-29 Thread Michael Buch via lldb-commits
@@ -35,6 +36,14 @@ enum class UnaryOpKind { Deref, // "*" }; +/// The C-Style casts allowed by DIL. +enum class CStyleCastKind { + eEnumeration, + eNullptr, + eReference, + eNone, Michael137 wrote: Can we add a brief oxygen comment to each of these enu

  1   2   >