https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/165496
We currently use a background thread to read the DAP output. This means the
test thread and the background thread can race at times and we may have
inconsistent timing due to these races.
To improve the consist
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
We currently use a background thread to read the DAP output. This means the
test thread and the background thread can race at times and we may have
inconsistent timing due to these races.
To improve the cons
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r origin/main...HEAD
lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
lldb/
https://github.com/charles-zablit approved this pull request.
Thank you for this patch!
https://github.com/llvm/llvm-project/pull/165281
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/charles-zablit approved this pull request.
Thank you for this!
https://github.com/llvm/llvm-project/pull/165363
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Charles Zablit
Date: 2025-10-28T16:26:04-07:00
New Revision: c2aa22f3cee05b54fc1e6b39822389c33c59dd96
URL:
https://github.com/llvm/llvm-project/commit/c2aa22f3cee05b54fc1e6b39822389c33c59dd96
DIFF:
https://github.com/llvm/llvm-project/commit/c2aa22f3cee05b54fc1e6b39822389c33c59dd96.diff
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/164491
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper edited
https://github.com/llvm/llvm-project/pull/165379
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/161870
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/165453
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
carlobertolli wrote:
wrong base branch.
https://github.com/llvm/llvm-project/pull/165476
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/carlobertolli closed
https://github.com/llvm/llvm-project/pull/165476
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r origin/main...HEAD amd/comgr/cmake/device-libs-id.py
amd/comgr/test-lit/lit.cfg.py amd/hip
cs01 wrote:
@emrekultursay are you available for another review?
https://github.com/llvm/llvm-project/pull/164333
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
n2h9 wrote:
> It looks like this patch was created with the help of AI. There's nothing
> inherently wrong with that, except that there's a bunch of places where it is
> diverging from the prevailing coding style. I highlighted some of those
> issues in the comments, but please do another pass
https://github.com/jimingham approved this pull request.
The exported API (SBValue::GetIndexOfChildWithName) returns a uint32_t so it
doesn't make any sense to use signed values in the intermediate steps.
You mentioned some kinds of bad behavior as a result of doing that. Is any of
that testa
JustinStitt wrote:
@ojhunt I'll get a roundtable slot for tomorrow. Would you be interested in
attending? I'll grab a 10:30-11:00am slot for 10/28.
Maybe we can page in @kees digitally.
https://github.com/llvm/llvm-project/pull/148914
___
lldb-commit
https://github.com/n2h9 updated https://github.com/llvm/llvm-project/pull/165163
>From aba4890ee4ce4e3c37961a3997d21832f904f599 Mon Sep 17 00:00:00 2001
From: Nikita B
Date: Sun, 26 Oct 2025 18:49:43 +0100
Subject: [PATCH 1/4] [lldb] [disassembler] chore: enhance VariableAnnotator to
return str
https://github.com/n2h9 updated https://github.com/llvm/llvm-project/pull/165163
>From aba4890ee4ce4e3c37961a3997d21832f904f599 Mon Sep 17 00:00:00 2001
From: Nikita B
Date: Sun, 26 Oct 2025 18:49:43 +0100
Subject: [PATCH 1/3] [lldb] [disassembler] chore: enhance VariableAnnotator to
return str
https://github.com/n2h9 updated https://github.com/llvm/llvm-project/pull/165163
>From aba4890ee4ce4e3c37961a3997d21832f904f599 Mon Sep 17 00:00:00 2001
From: Nikita B
Date: Sun, 26 Oct 2025 18:49:43 +0100
Subject: [PATCH 1/2] [lldb] [disassembler] chore: enhance VariableAnnotator to
return str
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
Modify the python wrapper to return uint32_t,
which prevents incorrect child name-to-index mapping and avoids performing
redundant operations on non-existent SBValues.
---
Full diff: https://github.com/llvm/l
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/165453
Modify the python wrapper to return uint32_t,
which prevents incorrect child name-to-index mapping and avoids performing
redundant operations on non-existent SBValues.
>From c0cb562de3e4c8f4a2b8e3410d4f209a2d4
https://github.com/JDevlieghere approved this pull request.
This is a huge achievement. Congratulations and thank you to everyone that
helped make this happen.
https://github.com/llvm/llvm-project/pull/165363
___
lldb-commits mailing list
lldb-commits
@@ -230,6 +230,75 @@ bytes.
`zt0`'s value and whether it is active or not will be saved prior to
expression evaluation and restored afterwards.
+## SME Only Systems
+
+AArch64 systems may have both SVE and SME (that is, `FEAT_SVE` and `FEAT_SVE`),
bulbazord wr
@@ -191,6 +191,10 @@ Changes to LLDB
* The `show-progress` setting, which became a NOOP with the introduction of the
statusline, now defaults to off and controls using OSC escape codes to show a
native progress bar in supporting terminals like Ghostty and ConEmu.
+* The def
da-viper wrote:
> However I'm not sure how this solves the 2 calls burden
The two "calls" is now amortised depending on the scenario
The user might want to get multiple stop descriptions from different threads.
to call `SBStream::GetData` once
or
They have a `SBStream` file redirect and do n
Nerixyz wrote:
> I assume the PDB shell-tests all explicitly turn on DIA? And the native ones
> turn it off? I.e., all the test coverage remains the same after this patch?
Yes, they use the environment variable:
https://github.com/llvm/llvm-project/blob/e5668d30393aa6c00ebbda75474c519ad0b57b2b/
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/165363
>From cc5fdcb728c8a954a6f8e1d5f611bdf52b88b8bc Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Tue, 28 Oct 2025 10:42:25 +0100
Subject: [PATCH 1/2] [LLDB] Use native PDB reader by default
---
.../Plugins/SymbolFi
https://github.com/DataCorrupted approved this pull request.
https://github.com/llvm/llvm-project/pull/164471
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
I don't feel strongly against this (since passing an `lldb::SBStream&` to a
method is the idiomatic way to get an object description in the SBAPI). However
I'm not sure how this solves the 2 calls burden: Instead, you'll need to call
`SBStream::GetString()` on top of callin
https://github.com/da-viper edited
https://github.com/llvm/llvm-project/pull/165379
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -118,6 +118,7 @@ static constexpr llvm::StringRef
MethodsWithPointerPlusLen[] = {
"_ZN4lldb8SBTarget15GetInstructionsEyPKvm",
"_ZN4lldb8SBTarget25GetInstructionsWithFlavorEyPKcPKvm",
"_ZN4lldb8SBThread18GetStopDescriptionEPcm",
+"_ZNK4lldb8SBThread18GetStopD
omjavaid wrote:
Thanks for this.
https://github.com/llvm/llvm-project/pull/165363
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2025-10-28T15:37:27Z
New Revision: 624d4f67549c0740e86293dab46b9be9291cdd4d
URL:
https://github.com/llvm/llvm-project/commit/624d4f67549c0740e86293dab46b9be9291cdd4d
DIFF:
https://github.com/llvm/llvm-project/commit/624d4f67549c0740e86293dab46b9be9291cdd4d.diff
LO
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/165417
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman auto_merge_enabled
https://github.com/llvm/llvm-project/pull/165417
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/165417
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett commented:
Before: skip if lldb tests are run on a Windows machine
After: skip if the test itself runs on a Windows machine (build machine or
remote)
Sounds good to me.
https://github.com/llvm/llvm-project/pull/165417
___
@@ -224,6 +224,13 @@ AND call SWIG_fail at the same time, because it will
result in a double free.
}
$1 = (char *)malloc($2);
}
+
+// Remove the default type check for this match.
+// because if the match function has an overload and a typemap,
+// it will typecheck agains
slydiman wrote:
Please approve #165417 to fix the buildbot
[lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197/builds/10304).
https://github.com/llvm/llvm-project/pull/164905
___
lldb-commits mailing list
[email protected]
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/165417
Skip the test for Windows hosts.
This patch fixes the buildbot `lldb-remote-linux-win`.
https://lab.llvm.org/buildbot/#/builders/197/builds/10304
>From 99e32f7d35891df97e8e7c168ab397c89137a8b3 Mon Sep 17 00:00
@@ -544,9 +597,49 @@ Status NativeRegisterContextLinux_arm64::WriteRegister(
return WriteAllSVE();
}
} else if (IsSVE(reg)) {
-if (m_sve_state == SVEState::Disabled || m_sve_state == SVEState::Unknown)
+if (m_sve_state == SVEState::Disabled || m_sve_state ==
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Skip the test for Windows hosts.
This patch fixes the buildbot `lldb-remote-linux-win`.
https://lab.llvm.org/buildbot/#/builders/197/builds/10304
---
Full diff: https://github.com/llvm/llvm-project/pull/1
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/165415
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
This PR is part of a 3 part stack, though they don't conflict at all so I'm
presenting them as separate PRs.
* lldb-server changes - https://github.com/llvm/llvm-project/pull/165413
* tests - https://github.com/llvm/llvm-project/pull/165414
* documentation - https://github.
DavidSpickett wrote:
This PR is part of a 3 part stack, though they don't conflict at all so I'm
presenting them as separate PRs.
* lldb-server changes - https://github.com/llvm/llvm-project/pull/165413
* tests - https://github.com/llvm/llvm-project/pull/165414
* documentation - https://github.
DavidSpickett wrote:
This PR is part of a 3 part stack, though they don't conflict at all so I'm
presenting them as separate PRs.
* lldb-server changes - https://github.com/llvm/llvm-project/pull/165413
* tests - https://github.com/llvm/llvm-project/pull/165414
* documentation - https://github.
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/165415.diff
1 Files Affected:
- (modified) lldb/docs/use/aarch64-linux.md (+69)
``diff
diff --git a/lldb/docs/use/aarch64-linux.m
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/165414
This PR is the tests for #138717. I have split it from implementation as there
is a lot of code, and the two don't really overlap. The tests are checking what
a user will see in LLDB, and only indirectly
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This PR is the tests for #138717. I have split it from implementation
as there is a lot of code, and the two don't really overlap. The tests are
checking what a user will see in LLDB, and only indirec
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/165415
None
>From f7c4f813060ee2abc8e13604d27d57555701997c Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 28 Oct 2025 10:38:17 +
Subject: [PATCH] [lldb][docs] Add documentation for AArch64 Linux SM
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/165379
>From 4f3a47c4cf0347a14ef115100c7a73cb00cf0f66 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Mon, 27 Oct 2025 16:02:27 +
Subject: [PATCH 1/2] [lldb] Add alternative SBThread::GetStopDescription
the func
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This is the implementation part of #138717, tests and documentation
will be in a seperate PR.
SME only systems have SME but not SVE. Previously we assumed that you'd either
have SVE, SVE+SME, or neit
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/165413
This is the implementation part of #138717, tests and documentation will be in
a seperate PR.
SME only systems have SME but not SVE. Previously we assumed that you'd either
have SVE, SVE+SME, or neither.
https://github.com/da-viper edited
https://github.com/llvm/llvm-project/pull/165379
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I also forgot that when not built on Windows, we have always been using native.
So this work has improved the remote debugging experience too!
https://github.com/llvm/llvm-project/pull/165363
___
lldb-commits mailing list
lldb-com
@@ -191,6 +191,10 @@ Changes to LLDB
* The `show-progress` setting, which became a NOOP with the introduction of the
statusline, now defaults to off and controls using OSC escape codes to show a
native progress bar in supporting terminals like Ghostty and ConEmu.
+* The def
@@ -191,6 +191,10 @@ Changes to LLDB
* The `show-progress` setting, which became a NOOP with the introduction of the
statusline, now defaults to off and controls using OSC escape codes to show a
native progress bar in supporting terminals like Ghostty and ConEmu.
+* The def
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/165363
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM with a small comment on the release note.
I might have expected to see a lot of tests flip from opting in to opting out,
but I think thanks to yours and others' hard work, all the tests run on both
plugins now, correct?
https:/
https://github.com/DavidSpickett commented:
I don't know anything about LUA so I leave it to someone who does to approve.
I agree with the new API itself.
https://github.com/llvm/llvm-project/pull/165379
___
lldb-commits mailing list
lldb-commits@list
@@ -118,6 +118,7 @@ static constexpr llvm::StringRef
MethodsWithPointerPlusLen[] = {
"_ZN4lldb8SBTarget15GetInstructionsEyPKvm",
"_ZN4lldb8SBTarget25GetInstructionsWithFlavorEyPKcPKvm",
"_ZN4lldb8SBThread18GetStopDescriptionEPcm",
+"_ZNK4lldb8SBThread18GetStopD
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/165379
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> Adds test case for lua.
I think you mean test case as in whole new test case, but at first this read as
if this was a Lua only feature. You have in fact added Python coverage as well.
https://github.com/llvm/llvm-project/pull/165379
__
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/164462
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ebuka Ezike
Date: 2025-10-28T13:33:22Z
New Revision: ec55aa4ef2c773fbc2723f38b7f96365e28f164b
URL:
https://github.com/llvm/llvm-project/commit/ec55aa4ef2c773fbc2723f38b7f96365e28f164b
DIFF:
https://github.com/llvm/llvm-project/commit/ec55aa4ef2c773fbc2723f38b7f96365e28f164b.diff
LOG: [
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/165270
>From d31dae6d626dd2c17dcfd5c00e3d909fa925cbf1 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Sun, 26 Oct 2025 21:13:13 +
Subject: [PATCH 1/3] [lldb-dap] Report any errors during attach request
---
lldb
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/165270
>From d31dae6d626dd2c17dcfd5c00e3d909fa925cbf1 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Sun, 26 Oct 2025 21:13:13 +
Subject: [PATCH 1/2] [lldb-dap] Report any errors during attach request
---
lldb
hokein wrote:
Closing it, as the RFC is considered rejected in the community, see
https://discourse.llvm.org/t/rfc-an-opt-in-cmake-option-for-64-bit-source-location/87538/25
https://github.com/llvm/llvm-project/pull/147292
___
lldb-commits mailing lis
https://github.com/hokein closed
https://github.com/llvm/llvm-project/pull/147292
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -224,6 +224,13 @@ AND call SWIG_fail at the same time, because it will
result in a double free.
}
$1 = (char *)malloc($2);
}
+
+// Remove the default type check for this match.
+// because if the match function has an overload and a typemap,
+// it will typecheck agains
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/165379
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev approved this pull request.
https://github.com/llvm/llvm-project/pull/164462
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/164462
>From 2da770c87999871d160d6c86d4e2b3de9b79c536 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Tue, 21 Oct 2025 18:23:43 +0100
Subject: [PATCH 1/2] [lldb][test] Do not link to the system stdlib
On linux if yo
https://github.com/da-viper edited
https://github.com/llvm/llvm-project/pull/164462
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/165379
the function signature for `GetStopDescription` is
`lldb::SBThread::GetStopDescription(char *dst_or_null, size_t len)`.
To get a description you need to call the function first time to get the buffer
size. a s
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
the function signature for `GetStopDescription` is
`lldb::SBThread::GetStopDescription(char *dst_or_null, size_t len)`.
To get a description you need to call the function first time to get the buffer
size. a
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/165363
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
SGTM, thanks for pushing through! Excited to see one of these plugins go away.
I assume the PDB shell-tests all explicitly turn on DIA? And the native ones
turn it off? I.e., all the test coverage remains the same after this patch?
Plea
@@ -191,6 +191,10 @@ Changes to LLDB
* The `show-progress` setting, which became a NOOP with the introduction of the
statusline, now defaults to off and controls using OSC escape codes to show a
native progress bar in supporting terminals like Ghostty and ConEmu.
+* The def
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/165367
>From a9c6cef1e9cb0f7a9c60c623f2d0b74699b66f06 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Tue, 28 Oct 2025 05:20:52 -0500
Subject: [PATCH] [lldb][AIX] Added RegisterInfo file for PPC64
---
.../Pl
https://github.com/HemangGadhavi created
https://github.com/llvm/llvm-project/pull/165367
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issues/1
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Hemang Gadhavi (HemangGadhavi)
Changes
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
https://github.com/Nerixyz closed
https://github.com/llvm/llvm-project/pull/165364
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: nerix
Date: 2025-10-28T11:43:47+01:00
New Revision: 7bb0d96e87e0129b960bb6a0a89de1a9a38f9f95
URL:
https://github.com/llvm/llvm-project/commit/7bb0d96e87e0129b960bb6a0a89de1a9a38f9f95
DIFF:
https://github.com/llvm/llvm-project/commit/7bb0d96e87e0129b960bb6a0a89de1a9a38f9f95.diff
LOG: [L
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/165364
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz created
https://github.com/llvm/llvm-project/pull/165364
This test passes with both plugins, but only ran with the DIA plugin. It was
fixed with #161678, where I missed this test.
>From 2640e46b56bb9339fa993ffaad3fe955e49c6305 Mon Sep 17 00:00:00 2001
From: Nerixyz
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: nerix (Nerixyz)
Changes
This test passes with both plugins, but only ran with the DIA plugin. It was
fixed with #161678, where I missed this test.
---
Full diff: https://github.com/llvm/llvm-project/pull/165364.diff
1 Files Affected:
-
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: nerix (Nerixyz)
Changes
All PDB tests now pass when compiled without DIA on Windows, so they pass with
the native reader.
With this PR, the default reader changes to the native reader.
The plan is to eventually remove the DIA reader (see
https://github.com/Nerixyz created
https://github.com/llvm/llvm-project/pull/165363
All PDB tests now pass when compiled without DIA on Windows, so they pass with
the native reader.
With this PR, the default reader changes to the native reader.
The plan is to eventually remove the DIA reader (
lb90 wrote:
Nice idea! Changed :)
https://github.com/llvm/llvm-project/pull/165281
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
It's a bit unfortunate we have to reconstruct this `StringMap` every time. Do
you have an intuition for how expensive that is?
Why can't we construct the map statically? The `LangOptions` never change
right? So you could just wrap all of thi
https://github.com/lb90 updated https://github.com/llvm/llvm-project/pull/165281
>From 76cf6d15c7cd4592fdcab4d79b31bc9b640fe727 Mon Sep 17 00:00:00 2001
From: Luca Bacci
Date: Mon, 27 Oct 2025 18:06:40 +0100
Subject: [PATCH] [LLDB][Windows]: Don't pass duplicate HANDLEs to
CreateProcess
Fixes
https://github.com/Michael137 commented:
`lldb/unittests/Language/CPlusPlus/CPlusPlusLanguageTest.cpp` has some
unit-tests for `CPlusPlusNameParser` (and friends). If we added a constructor
to `CPlusPlusNameParser` which took a user-provided `LangOptions` (but defaults
to the existing one) tha
Michael137 wrote:
very minor nit, but could we move this `using namespace` down to just before
the macro. Just so it gives the reader some indication that we may be using it
for the `include` machinery
https://github.com/llvm/llvm-project/pull/164284
Michael137 wrote:
Ignore the AArch64 CI failure, it has been unintentionally running on PRs as of
late.
https://github.com/llvm/llvm-project/pull/164462
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/Michael137 approved this pull request.
LGTM, we can clean things up in follow-up PRs. But this should fix the
immediate issue of accidentally linking against libstdc++.
Could add `Fixes https://github.com/llvm/llvm-project/issues/116040` to the PR
description before merging?
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/164462
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/164462
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/164462
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 104 matches
Mail list logo
