[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

JDevlieghere wrote: It's also worth noting that because of our post-commit testing, heavier use of reverts is a natural part of our development workflow. There's a section in the [LLVM Developer Policy](https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy) that sheds some more li

[Lldb-commits] [lldb] [lldb] Fix TestVTableValue.py test_overwrite_vtable test (PR #164910)

https://github.com/bulbazord approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/164910 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][attempt #3] update lldb-server platform help parsing (PR #164904)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chad Smith (cs01) Changes > I also should point out that a timeout of 0.2s is way to short for any kind of CI system under load. They run 24/7 and at some random point the OS will halt everything to do various cleanup jobs and then these t

[Lldb-commits] [lldb] [lldb][attempt #3] update lldb-server platform help parsing (PR #164904)

https://github.com/cs01 created https://github.com/llvm/llvm-project/pull/164904 > I also should point out that a timeout of 0.2s is way to short for any kind > of CI system under load. They run 24/7 and at some random point the OS will > halt everything to do various cleanup jobs and then thes

[Lldb-commits] [lldb] d478737 - [lldb][debugserver] fix typeo in SME ZA register

Author: Jason Molenda Date: 2025-10-23T14:43:51-07:00 New Revision: d47873784174181f1d5837f1389d23afeead734c URL: https://github.com/llvm/llvm-project/commit/d47873784174181f1d5837f1389d23afeead734c DIFF: https://github.com/llvm/llvm-project/commit/d47873784174181f1d5837f1389d23afeead734c.diff

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

cs01 wrote: Would it be possible for me to get commit access? https://github.com/llvm/llvm-project/pull/162730 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

cs01 wrote: Thanks for the heads up. I attempted to fix the windows issue in https://github.com/llvm/llvm-project/pull/164843. I am not sure of the normal workflow in cases like this, but in the future it would be easier for me (and reviewers) if the change was not reverted entirely and I coul

[Lldb-commits] [lldb] [lldb][windows] print an error if python.dll is not in the DLL search path (PR #164893)

mstorsjo wrote: > I'm debating if, when `SearchPathW` fails to find `python.dll`, we should > exit or let lldb crash. > > However, I don't want to prevent lldb from starting if we think `python.dll` > is not available, even though it is. I agree, I think this is the better call. As mentioned

[Lldb-commits] [lldb] [lldb][windows] print an error if python.dll is not in the DLL search path (PR #164893)

@@ -87,6 +89,8 @@ if (LLDB_ENABLE_PYTHON) set(LLDB_PYTHON_EXT_SUFFIX "_d${LLDB_PYTHON_EXT_SUFFIX}") endif() endif() + set(LLDB_PYTHON_SHARED_LIBRARY_FILENAME + "python${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR}${CMAKE_SHARED_LIBRARY_SUFFIX}") -

[Lldb-commits] [lldb] [lldb][windows] print an error if python.dll is not in the DLL search path (PR #164893)

@@ -776,8 +796,13 @@ int main(int argc, char const *argv[]) { "~/Library/Logs/DiagnosticReports/.\n"); #endif -#if defined(_WIN32) && defined(LLDB_PYTHON_DLL_RELATIVE_PATH) - AddPythonDLLToSearchPath(); +#if defined(_WIN32) && defined(LLDB_PYTHON_SHARE

[Lldb-commits] [lldb] [lldb][windows] print an error if python.dll is not in the DLL search path (PR #164893)

charles-zablit wrote: I'm debating if, when `SearchPathW` fails to find `python.dll`, we should exit or let lldb crash. Right now, the error looks like this and I think it's lost in the details of the crash. Gracefully exiting would allow to just have the error message without the stack dump

[Lldb-commits] [lldb] [lldb][windows] print an error if python.dll is not in the DLL search path (PR #164893)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes This is a follow up to https://github.com/llvm/llvm-project/pull/162509. Using the `SearchPathW` API, we can ensure that the correct version of Python is installed before `liblldb` is loaded (and `py

[Lldb-commits] [lldb] [lldb][windows] print an error if python.dll is not in the DLL search path (PR #164893)

https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/164893 This is a follow up to https://github.com/llvm/llvm-project/pull/162509. Using the `SearchPathW` API, we can ensure that the correct version of Python is installed before `liblldb` is loaded (and `python

[Lldb-commits] [lldb] aac036a - Revert "[lldb] update lldb-server platform help parsing (#162730)"

Author: Adrian Prantl Date: 2025-10-23T13:56:14-07:00 New Revision: aac036a7f6730118f0d832150243d66b603c3af3 URL: https://github.com/llvm/llvm-project/commit/aac036a7f6730118f0d832150243d66b603c3af3 DIFF: https://github.com/llvm/llvm-project/commit/aac036a7f6730118f0d832150243d66b603c3af3.diff

[Lldb-commits] [lldb] 4456afc - Revert "[lldb] fix lldb-server test failures on windows (#164843)"

Author: Adrian Prantl Date: 2025-10-23T13:56:14-07:00 New Revision: 4456afcf0bcb29d3ba5670dbc583ee5ea00a01f3 URL: https://github.com/llvm/llvm-project/commit/4456afcf0bcb29d3ba5670dbc583ee5ea00a01f3 DIFF: https://github.com/llvm/llvm-project/commit/4456afcf0bcb29d3ba5670dbc583ee5ea00a01f3.diff

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

adrian-prantl wrote: Based on the conversation you don't seem to have commit access so I'll go ahead and revert this for you. https://github.com/llvm/llvm-project/pull/162730 ___ lldb-commits mailing list [email protected] https://lists.llvm

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

adrian-prantl wrote: I also should point out that a timeout of 0.2s is way to short for any kind of CI system under load. They run 24/7 and at some random point the OS will halt everything to do various cleanup jobs and then these timeouts time out. Why does this need any timeout on top of the

[Lldb-commits] [lldb] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

https://github.com/piyushjaiswal98 updated https://github.com/llvm/llvm-project/pull/164739 >From e04bbb2579b91a08a99fd208739a17313de969ab Mon Sep 17 00:00:00 2001 From: Piyush Jaiswal Date: Wed, 22 Oct 2025 17:37:29 -0700 Subject: [PATCH 1/3] Refactor Breakpoint event notification --- lldb/i

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

adrian-prantl wrote: @cs01 This doesn't seem to work on macOS: ``` [2025-10-23T17:00:02.993Z] TEST 'lldb-shell :: lldb-server/TestPlatformSuccessfulStartup.test' FAILED [2025-10-23T17:00:02.993Z] Exit Code: 127 [2025-10-23T17:00:02.993Z] [2025-10-23T17

[Lldb-commits] [lldb] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

@@ -1346,6 +1346,21 @@ class Target : public std::enable_shared_from_this, const lldb_private::RegisterFlags &flags, uint32_t byte_size); + /// Sends a breakpoint notification event if any listener is registered.

[Lldb-commits] [lldb] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

https://github.com/piyushjaiswal98 updated https://github.com/llvm/llvm-project/pull/164739 >From e04bbb2579b91a08a99fd208739a17313de969ab Mon Sep 17 00:00:00 2001 From: Piyush Jaiswal Date: Wed, 22 Oct 2025 17:37:29 -0700 Subject: [PATCH 1/3] Refactor Breakpoint event notification --- lldb/i

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add multi-session support with shared debugger instances (PR #163653)

walter-erquinigo wrote: TIL https://github.com/llvm/llvm-project/pull/163653 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

https://github.com/piyushjaiswal98 edited https://github.com/llvm/llvm-project/pull/164739 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

@@ -1346,6 +1346,21 @@ class Target : public std::enable_shared_from_this, const lldb_private::RegisterFlags &flags, uint32_t byte_size); + /// Sends a breakpoint notification event if any listener is registered.

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

@@ -1346,6 +1346,21 @@ class Target : public std::enable_shared_from_this, const lldb_private::RegisterFlags &flags, uint32_t byte_size); + /// Sends a breakpoint notification event if any listener is registered.

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

@@ -1099,12 +1099,8 @@ bool Breakpoint::EvaluatePrecondition(StoppointCallbackContext &context) { void Breakpoint::SendBreakpointChangedEvent( lldb::BreakpointEventType eventKind) { - if (!IsInternal() && GetTarget().EventTypeHasListeners( - Tar

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

https://github.com/piyushjaiswal98 ready_for_review https://github.com/llvm/llvm-project/pull/164739 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

https://github.com/piyushjaiswal98 edited https://github.com/llvm/llvm-project/pull/164739 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

https://github.com/piyushjaiswal98 edited https://github.com/llvm/llvm-project/pull/164739 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

https://github.com/piyushjaiswal98 updated https://github.com/llvm/llvm-project/pull/164739 >From e04bbb2579b91a08a99fd208739a17313de969ab Mon Sep 17 00:00:00 2001 From: Piyush Jaiswal Date: Wed, 22 Oct 2025 17:37:29 -0700 Subject: [PATCH 1/2] Refactor Breakpoint event notification --- lldb/i

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

https://github.com/piyushjaiswal98 updated https://github.com/llvm/llvm-project/pull/164739 >From e04bbb2579b91a08a99fd208739a17313de969ab Mon Sep 17 00:00:00 2001 From: Piyush Jaiswal Date: Wed, 22 Oct 2025 17:37:29 -0700 Subject: [PATCH 1/2] Refactor Breakpoint event notification --- lldb/i

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

@@ -17,12 +17,7 @@ using namespace lldb_private; static void NotifyChange(const BreakpointSP &bp, BreakpointEventType event) { Target &target = bp->GetTarget(); - if (target.EventTypeHasListeners(Target::eBroadcastBitBreakpointChanged)) { -auto event_data_sp = -

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

@@ -1099,12 +1099,11 @@ bool Breakpoint::EvaluatePrecondition(StoppointCallbackContext &context) { void Breakpoint::SendBreakpointChangedEvent( lldb::BreakpointEventType eventKind) { - if (!IsInternal() && GetTarget().EventTypeHasListeners( - Ta

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

@@ -5244,3 +5245,19 @@ void Target::ClearSectionLoadList() { GetSectionLoadList().Clear(); } void Target::DumpSectionLoadList(Stream &s) { GetSectionLoadList().Dump(s, this); } + +void Target::NotifyBreakpointChanged(Breakpoint &bp, + lldb

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

@@ -17,12 +17,7 @@ using namespace lldb_private; static void NotifyChange(const BreakpointSP &bp, BreakpointEventType event) { Target &target = bp->GetTarget(); clayborg wrote: Remove this line https://github.com/llvm/llvm-project/pull/164739 _

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/164739 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

@@ -1346,6 +1346,21 @@ class Target : public std::enable_shared_from_this, const lldb_private::RegisterFlags &flags, uint32_t byte_size); + /// Sends a breakpoint notification event if any listener is registered.

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

@@ -1346,6 +1346,21 @@ class Target : public std::enable_shared_from_this, const lldb_private::RegisterFlags &flags, uint32_t byte_size); + /// Sends a breakpoint notification event if any listener is registered.

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

@@ -602,7 +608,102 @@ GetValObjFromFPRegs(Thread &thread, const RegisterContextSP ®_ctx, value, ConstString("")); } // we should never reach this, but if we do, use the integer registers - return GetValObjFromIntRegs(thread, reg_c

[Lldb-commits] [lldb] [docs][lldb] update the Windows tools instructions (PR #164491)

@@ -95,37 +95,29 @@ commands below. Windows *** -* Visual Studio 2019. -* The latest Windows SDK. -* The Active Template Library (ATL). -* `GnuWin32 `_ for CoreUtils and Make. -* `Python 3 `_. Ma

[Lldb-commits] [lldb] [docs][lldb] update the Windows tools instructions (PR #164491)

https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/164491 >From 09485ce6f3a961c741468998281f8f11cfc4e59e Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Tue, 21 Oct 2025 13:29:14 -0700 Subject: [PATCH 1/3] [docs][lldb] update the Windows tools instructions

[Lldb-commits] [lldb] [lldb] Introduce internal stop hooks (PR #164506)

https://github.com/yln updated https://github.com/llvm/llvm-project/pull/164506 >From 5f6caec8cbd40aa92233045e231ee791b6fba136 Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Tue, 21 Oct 2025 14:23:17 -0700 Subject: [PATCH 1/2] [lldb] Introduce internal stop hooks Introduce the concept of i

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/12468 Here is the relevant piece of

[Lldb-commits] [lldb] [lldb] fix lldb-server test failures on windows (PR #164843)

DavidSpickett wrote: Thanks! https://github.com/llvm/llvm-project/pull/164843 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix lldb-server test failures on windows (PR #164843)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/164843 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 930b36c - [lldb] fix lldb-server test failures on windows (#164843)

Author: Chad Smith Date: 2025-10-23T17:53:43+01:00 New Revision: 930b36cfbbc873fe6c329b95e1c56c6ae1ea1d94 URL: https://github.com/llvm/llvm-project/commit/930b36cfbbc873fe6c329b95e1c56c6ae1ea1d94 DIFF: https://github.com/llvm/llvm-project/commit/930b36cfbbc873fe6c329b95e1c56c6ae1ea1d94.diff LO

[Lldb-commits] [lldb] [lldb] fix lldb-server test failures on windows (PR #164843)

https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/164843 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fix llvm-server test failures on windows (PR #164843)

https://github.com/cs01 created https://github.com/llvm/llvm-project/pull/164843 Fix test failures by including and optional .exe on the lldb-server name. Still passes on linux, but should pass on windows now. ``` > bin/llvm-lit -v tools/lldb/test/Shell/lldb-server/ llvm-lit: llvm-project/llvm/

[Lldb-commits] [lldb] [lldb] fix lldb-server test failures on windows (PR #164843)

https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/164843 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add multi-session support with shared debugger instances (PR #163653)

@@ -295,4 +307,267 @@ void SendMemoryEvent(DAP &dap, lldb::SBValue variable) { dap.Send(protocol::Event{"memory", std::move(body)}); } +// Note: EventThread() is architecturally different from the other functions in +// this file. While the functions above are event helpers

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add multi-session support with shared debugger instances (PR #163653)

@@ -295,4 +307,267 @@ void SendMemoryEvent(DAP &dap, lldb::SBValue variable) { dap.Send(protocol::Event{"memory", std::move(body)}); } +// Note: EventThread() is architecturally different from the other functions in +// this file. While the functions above are event helpers

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add multi-session support with shared debugger instances (PR #163653)

@@ -295,4 +307,267 @@ void SendMemoryEvent(DAP &dap, lldb::SBValue variable) { dap.Send(protocol::Event{"memory", std::move(body)}); } +// Note: EventThread() is architecturally different from the other functions in +// this file. While the functions above are event helpers

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add multi-session support with shared debugger instances (PR #163653)

ashgti wrote: Most of the time in lldb, components have an Initialize / Terminate function to setup / teardown an instance. https://github.com/llvm/llvm-project/pull/163653 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add multi-session support with shared debugger instances (PR #163653)

ashgti wrote: Small nit, but we could just call this `SessionManager`, its already in the lldb_dap namespace. But not that big of a deal either way. https://github.com/llvm/llvm-project/pull/163653 ___ lldb-commits m

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add multi-session support with shared debugger instances (PR #163653)

ashgti wrote: Should this be a `llvm::ManagedStatic`? https://github.com/llvm/llvm-project/pull/163653 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb] fix lldb-server test failures on windows (PR #164843)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chad Smith (cs01) Changes Fix test failures by including and optional .exe on the lldb-server name. Still passes on linux, but should pass on windows now. ``` > bin/llvm-lit -v tools/lldb/test/Shell/lldb-server/ llvm-lit: llvm-project/llvm

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

cs01 wrote: buildbot failures should be fixed in https://github.com/llvm/llvm-project/pull/164843 https://github.com/llvm/llvm-project/pull/162730 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `lldb` at step 18 "test-check-lldb-shell". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/10154 Here is the relevant piece

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-win` running on `as-builder-10` while building `lldb` at step 10 "test-check-lldb-shell". Full details are available at: https://lab.llvm.org/buildbot/#/builders/211/builds/3151 Here is the relevant piece of the

[Lldb-commits] [lldb] [lldb][test] skip Lua tests when the Lua interpreter is not found (PR #164793)

@@ -158,7 +158,11 @@ def get_tests(self): return tests def test_lua_api(self): -if "LUA_EXECUTABLE" not in os.environ or len(os.environ["LUA_EXECUTABLE"]) == 0: +if ( +"LUA_EXECUTABLE" not in os.environ +or len(os.environ["L

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

tgs-sc wrote: Oh, I am sorry, but it is not merged as I checked. @Michael137, can you merge it please? https://github.com/llvm/llvm-project/pull/154123 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

https://github.com/tgs-sc reopened https://github.com/llvm/llvm-project/pull/154123 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/162730 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] faf7af8 - [lldb] update lldb-server platform help parsing (#162730)

Author: Chad Smith Date: 2025-10-23T16:04:57+01:00 New Revision: faf7af864f9258768133894764f1fae58d43bb09 URL: https://github.com/llvm/llvm-project/commit/faf7af864f9258768133894764f1fae58d43bb09 DIFF: https://github.com/llvm/llvm-project/commit/faf7af864f9258768133894764f1fae58d43bb09.diff LO

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/162730 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/162730 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

cs01 wrote: > Do you need someone to merge this for you? Yes I do. Thank you for the review! https://github.com/llvm/llvm-project/pull/162730 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

@@ -0,0 +1,39 @@ +RUN: %platformserver --help 2>&1 | FileCheck %s +RUN: %platformserver -h 2>&1 | FileCheck %s +RUN: %lldb-server p --help 2>&1 | FileCheck %s +RUN: %lldb-server p -h 2>&1 | FileCheck %s +RUN: %lldb-server platform --help 2>&1 | FileCheck %s +RUN: %lldb-server plat

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

@@ -0,0 +1,41 @@ +# UNSUPPORTED: system-windows + +RUN: %platformserver --help 2>&1 | FileCheck %s +RUN: %platformserver -h 2>&1 | FileCheck %s +RUN: %lldb-server p --help 2>&1 | FileCheck %s +RUN: %lldb-server p -h 2>&1 | FileCheck %s +RUN: %lldb-server platform --help 2>&1 | Fil

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

https://github.com/DavidSpickett approved this pull request. Jonas already approved and this LGTM. Whatever makes Filecheck happy is fine with me I was just a bit too curious about the details :) Do you need someone to merge this for you? https://github.com/llvm/llvm-project/pull/162730 __

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

https://github.com/cs01 updated https://github.com/llvm/llvm-project/pull/162730 >From 5fc40a5f2bedaf6ca3f024aa2a91c5f4ce187061 Mon Sep 17 00:00:00 2001 From: Chad Smith Date: Thu, 9 Oct 2025 11:52:01 -0700 Subject: [PATCH] update lldb-server platform help text --- ...s.test => TestGdbserverEr

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

@@ -0,0 +1,39 @@ +RUN: %platformserver --help 2>&1 | FileCheck %s +RUN: %platformserver -h 2>&1 | FileCheck %s +RUN: %lldb-server p --help 2>&1 | FileCheck %s +RUN: %lldb-server p -h 2>&1 | FileCheck %s +RUN: %lldb-server platform --help 2>&1 | FileCheck %s +RUN: %lldb-server plat

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

@@ -0,0 +1,39 @@ +RUN: %platformserver --help 2>&1 | FileCheck %s +RUN: %platformserver -h 2>&1 | FileCheck %s +RUN: %lldb-server p --help 2>&1 | FileCheck %s +RUN: %lldb-server p -h 2>&1 | FileCheck %s +RUN: %lldb-server platform --help 2>&1 | FileCheck %s +RUN: %lldb-server plat

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

@@ -0,0 +1,39 @@ +RUN: %platformserver --help 2>&1 | FileCheck %s +RUN: %platformserver -h 2>&1 | FileCheck %s +RUN: %lldb-server p --help 2>&1 | FileCheck %s +RUN: %lldb-server p -h 2>&1 | FileCheck %s +RUN: %lldb-server platform --help 2>&1 | FileCheck %s +RUN: %lldb-server plat

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

DavidSpickett wrote: > I think that, in general, a situation is always possible in which it is > unclear how to decode the instruction length, so it is hard to imagine how > this can be improved. For llvm-objdump and Arm Thumb they have something that will keep jumping forward to find a point

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/164413 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5d7da0a - [lldb] Added a warning in case of instruction decode failure (#164413)

Author: Timur Golubovich Date: 2025-10-23T15:26:14+01:00 New Revision: 5d7da0a5cd0031e4a3e4f685e061a0dc6d599ae9 URL: https://github.com/llvm/llvm-project/commit/5d7da0a5cd0031e4a3e4f685e061a0dc6d599ae9 DIFF: https://github.com/llvm/llvm-project/commit/5d7da0a5cd0031e4a3e4f685e061a0dc6d599ae9.di

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

tgs-sc wrote: > Maybe something should be skipping forward to try and re-sync. I think that, in general, a situation is always possible in which it is unclear how to decode the instruction length, so it is hard to imagine how this can be improved. Now, there are two phases: decode and disassem

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

@@ -0,0 +1,39 @@ +RUN: %platformserver --help 2>&1 | FileCheck %s +RUN: %platformserver -h 2>&1 | FileCheck %s +RUN: %lldb-server p --help 2>&1 | FileCheck %s +RUN: %lldb-server p -h 2>&1 | FileCheck %s +RUN: %lldb-server platform --help 2>&1 | FileCheck %s +RUN: %lldb-server plat

[Lldb-commits] [lldb] [lldb] update lldb-server platform help parsing (PR #162730)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/162730 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

DavidSpickett wrote: I tried your example on AArch64 and we don't get a return value there either. TestReturnValues.py in fact skips checking a type called `return_five_int` for the SysV AArch64 ABI (and now I see where you got the example from). According to the AArch64 AAPCS (it's ABI): > B.

[Lldb-commits] [lldb] update lldb-server platform help parsing (PR #162730)

https://github.com/cs01 updated https://github.com/llvm/llvm-project/pull/162730 >From a3f3f8f0eb2b572c070cee1b2ea5118d0a1de9dc Mon Sep 17 00:00:00 2001 From: Chad Smith Date: Thu, 9 Oct 2025 11:52:01 -0700 Subject: [PATCH] update lldb-server platform help text --- ...s.test => TestGdbserverEr

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [Clang] [Sema] Make `-Wincompatible-pointer-types` an error by default (PR #157364)

AaronBallman wrote: > > > This diagnostic fires in the following code - > > > https://gcc.godbolt.org/z/G6sYcTnWc: > > > ... > > > Is this expected? > > > > > > Yes. The prototype of `f` is using a `locally` defined struct (see the > > `Wvisibility` diagnostic). So that type is ONLY visible o

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

@@ -602,7 +604,104 @@ GetValObjFromFPRegs(Thread &thread, const RegisterContextSP ®_ctx, value, ConstString("")); } // we should never reach this, but if we do, use the integer registers - return GetValObjFromIntRegs(thread, reg_c

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

https://github.com/DavidSpickett approved this pull request. Jonas is probably busy preparing for US LLVM Dev now, and at the event all next week. You removed the "warning: " prefix from the message and that seemed to be the crux of his comment. You're now following the local pattern at least,

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

DavidSpickett wrote: @lenary the fact we can reach this state may be a sign that something is wrong elsewhere, that's true. Maybe something should be skipping forward to try and re-sync. Someone can try to fix that but in the meantime, I'm ok with this PR making the error a bit more clear. h

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

tgs-sc wrote: @DavidSpickett, @JDevlieghere, I think that this patch can be merged. https://github.com/llvm/llvm-project/pull/164413 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

sga-sc wrote: Consider compiling this code for RISC-V 64 bit: ``` struct five_int { int one_field;hat software shouldn't assume int two_field; int three_field; int four_field; int five_field; }; struct five_int return_five_int (struct five_int value) { return value; } int main() {

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

@@ -602,7 +604,104 @@ GetValObjFromFPRegs(Thread &thread, const RegisterContextSP ®_ctx, value, ConstString("")); } // we should never reach this, but if we do, use the integer registers - return GetValObjFromIntRegs(thread, reg_c

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

https://github.com/sga-sc updated https://github.com/llvm/llvm-project/pull/163931 >From f395e48b3599769b11ef5190ec041048e10ba3be Mon Sep 17 00:00:00 2001 From: Georgiy Samoylov Date: Fri, 17 Oct 2025 11:50:19 +0300 Subject: [PATCH 1/2] [lldb][RISCV] Implement reading of aggregate return value

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

@@ -602,7 +604,104 @@ GetValObjFromFPRegs(Thread &thread, const RegisterContextSP ®_ctx, value, ConstString("")); } // we should never reach this, but if we do, use the integer registers - return GetValObjFromIntRegs(thread, reg_c

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions h,cpp -- lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cp

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

@@ -602,7 +604,104 @@ GetValObjFromFPRegs(Thread &thread, const RegisterContextSP ®_ctx, value, ConstString("")); } // we should never reach this, but if we do, use the integer registers - return GetValObjFromIntRegs(thread, reg_c

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

@@ -602,7 +604,104 @@ GetValObjFromFPRegs(Thread &thread, const RegisterContextSP ®_ctx, value, ConstString("")); } // we should never reach this, but if we do, use the integer registers - return GetValObjFromIntRegs(thread, reg_c

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

@@ -602,7 +604,104 @@ GetValObjFromFPRegs(Thread &thread, const RegisterContextSP ®_ctx, value, ConstString("")); } // we should never reach this, but if we do, use the integer registers - return GetValObjFromIntRegs(thread, reg_c

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

@@ -602,7 +604,104 @@ GetValObjFromFPRegs(Thread &thread, const RegisterContextSP ®_ctx, value, ConstString("")); } // we should never reach this, but if we do, use the integer registers - return GetValObjFromIntRegs(thread, reg_c

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

@@ -602,7 +604,104 @@ GetValObjFromFPRegs(Thread &thread, const RegisterContextSP ®_ctx, value, ConstString("")); } // we should never reach this, but if we do, use the integer registers - return GetValObjFromIntRegs(thread, reg_c

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

@@ -602,7 +604,104 @@ GetValObjFromFPRegs(Thread &thread, const RegisterContextSP ®_ctx, value, ConstString("")); } // we should never reach this, but if we do, use the integer registers - return GetValObjFromIntRegs(thread, reg_c

[Lldb-commits] [lldb] [lldb][RISCV] Fix return value reading (PR #163931)

https://github.com/sga-sc updated https://github.com/llvm/llvm-project/pull/163931 >From de79f608e30168be7bc596f80cbf4131fffbbd8c Mon Sep 17 00:00:00 2001 From: Georgiy Samoylov Date: Fri, 17 Oct 2025 11:50:19 +0300 Subject: [PATCH 1/2] [lldb][RISCV] Implement reading of aggregate return value

[Lldb-commits] [lldb] [lldb][test] skip Lua tests when the Lua interpreter is not found (PR #164793)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vincent Palatin (vpalatin) Changes When Swig is installed but not any Lua interpreter, the cmake script in `lldb/cmake/modules/FindLuaAndSwig.cmake` will execute `find_program(LUA_EXECUTABLE, ...)` and this will set the `LUA_EXECUTABLE` v

  1   2   >