https://github.com/igorkudrin created
https://github.com/llvm/llvm-project/pull/161788
The test did not work as intended when the empty function 'done()' contained
epilog code, because a breakpoint was set on the first instruction of the
epilog instead of on the last instruction of the functio
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Igor Kudrin (igorkudrin)
Changes
The test did not work as intended when the empty function 'done()' contained
epilog code, because a breakpoint was set on the first instruction of the
epilog instead of on the last instruction of the functi
https://github.com/JDevlieghere approved this pull request.
Very nice. I looked at the example before reading the PR description and I
wondered (1) if this would show up even if the expression succeeded and (2) if
this would show up if the languages are the same. The answer to both is no
which
@@ -0,0 +1,94 @@
+"""Test MTE Memory Tagging on Apple platforms"""
+
+import lldb
+import re
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import lldbsuite.test.cpu_feature as cpu_feature
+
+exe_name = "uaf_mt
@@ -477,6 +477,85 @@ std::string PlatformAndroid::GetRunAs() {
}
return run_as.str();
}
+uint32_t
+PlatformAndroid::FindProcesses(const ProcessInstanceInfoMatch &match_info,
+ ProcessInstanceInfoList &proc_infos) {
+ // Use the parent implemen
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Just a simple de-duplication of the same code. We saw a bug here
recently (https://github.com/llvm/llvm-project/pull/161521). Might as well
isolate this all in one place.
rdar://158159242
---
Full diff: h
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/160199
>From c6534a14078ee8644c2403d51e9df613cddce22b Mon Sep 17 00:00:00 2001
From: George Hu
Date: Mon, 22 Sep 2025 13:42:31 -0700
Subject: [PATCH 1/5] Call locate module callback for main executable
---
lldb/
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/160199
>From c6534a14078ee8644c2403d51e9df613cddce22b Mon Sep 17 00:00:00 2001
From: George Hu
Date: Mon, 22 Sep 2025 13:42:31 -0700
Subject: [PATCH 1/5] Call locate module callback for main executable
---
lldb/
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/155331
>From 10c5245383c230cd8f12d58fcb04da584d77c998 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Mon, 25 Aug 2025 17:16:13 -0700
Subject: [PATCH 1/5] [lldb] Fix use after free on
ModuleList::RemoveShared
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/161731
The cpp file fails to compile without `lld-link`.
>From 315eca0cd9d2dd2dccea5ebd552e248c81fbafc3 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Thu, 2 Oct 2025 13:37:45 -0700
Subject: [PATCH] [lldb] Add l
augusto2112 wrote:
@JDevlieghere sorry for the delay, got sidetracked with other work.
https://github.com/llvm/llvm-project/pull/155331
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/155331
>From be7b116e5baa1c188a2da76aa72a1f925adb9551 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Mon, 25 Aug 2025 17:16:13 -0700
Subject: [PATCH 1/4] [lldb] Fix use after free on
ModuleList::RemoveShared
Author: Julian Lettner
Date: 2025-09-30T11:32:49-07:00
New Revision: 5665b1bf9da5c0918f8babec13f2ff537078a233
URL:
https://github.com/llvm/llvm-project/commit/5665b1bf9da5c0918f8babec13f2ff537078a233
DIFF:
https://github.com/llvm/llvm-project/commit/5665b1bf9da5c0918f8babec13f2ff537078a233.diff
Michael137 wrote:
> This going to be quite useful for diagnosing perplexing errors!
>
> > note: Requested expression evaluation as 'c' but fell back to 'c++'.
>
> * Do we have a table that would translate the spec names into human-readable
> names (objc -> Objective-C, c -> C, ...) we could us
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/161655
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-10-02T22:45:17+01:00
New Revision: 07974fe2b14a7601b5658deb9c41597db54e842f
URL:
https://github.com/llvm/llvm-project/commit/07974fe2b14a7601b5658deb9c41597db54e842f
DIFF:
https://github.com/llvm/llvm-project/commit/07974fe2b14a7601b5658deb9c41597db54e842f.diff
@@ -1118,3 +1118,21 @@ size_t lldb_private::npdb::GetSizeOfType(PdbTypeSymId id,
}
return 0;
}
+
+llvm::StringRef lldb_private::npdb::StripCDeclPrefix(llvm::StringRef mangled) {
+ // See
+ //
https://learn.microsoft.com/en-us/cpp/build/reference/decorated-names#FormatC
+
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
The cpp file fails to build without `lld-link`.
---
Full diff: https://github.com/llvm/llvm-project/pull/161731.diff
1 Files Affected:
- (modified) lldb/test/Shell/SymbolFile/NativePDB/symtab.cpp (+1-1)
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/161733
`LoadAddressResolver::Resolve` returns zero for weak symbols. However
`FindInSymbols`
does multiple searches (each starting with `FindSymbolsWithNameAndType`), and a
resolved
address of zero from one step o
Author: Julian Lettner
Date: 2025-10-02T13:57:40-07:00
New Revision: f4784fd13fb77a609920a06af99c3602bdec530f
URL:
https://github.com/llvm/llvm-project/commit/f4784fd13fb77a609920a06af99c3602bdec530f
DIFF:
https://github.com/llvm/llvm-project/commit/f4784fd13fb77a609920a06af99c3602bdec530f.diff
https://github.com/yln closed https://github.com/llvm/llvm-project/pull/160952
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/161733
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/161733
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kastiglione wrote:
draft while I figure out a test
https://github.com/llvm/llvm-project/pull/161733
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz approved this pull request.
Thank you for fixing!
https://github.com/llvm/llvm-project/pull/161731
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/161731
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/161731
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Langford
Date: 2025-10-02T13:50:11-07:00
New Revision: dbffd0aeaf3484fe3d846a10b3c3b1e48ccdf7ef
URL:
https://github.com/llvm/llvm-project/commit/dbffd0aeaf3484fe3d846a10b3c3b1e48ccdf7ef
DIFF:
https://github.com/llvm/llvm-project/commit/dbffd0aeaf3484fe3d846a10b3c3b1e48ccdf7ef.diff
@@ -359,6 +359,9 @@ class LLDB_API SBDebugger {
lldb::SBTarget FindTargetWithFileAndArch(const char *filename,
const char *arch);
+ /// Find a target with the specified unique ID
+ lldb::SBTarget FindTargetWithUniqueID(lldb::user_
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/161731
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/161385
>From bbc894aab1a2c58611b84025362422f5aa0821ac Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Tue, 30 Sep 2025 14:22:55 +0100
Subject: [PATCH 1/3] Revert "[lldb][test] check if CoreDumping info is
supported
https://github.com/GeorgeHuyubo closed
https://github.com/llvm/llvm-project/pull/160225
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
As a part of my recent work on Coredump metrics, I've come up with an 'active
time to first bt', where we look at the total time spent loading all the data
to get LLDB to report it's first backtrace.
One de
https://github.com/Jlalond ready_for_review
https://github.com/llvm/llvm-project/pull/161604
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/161604
>From 70cb09fa676859b0b87a9bdd232b2008f9870498 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 1 Oct 2025 14:50:48 -0700
Subject: [PATCH 1/4] Calculate time to first BT, as a part of my push to
generate
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/161604
>From 70cb09fa676859b0b87a9bdd232b2008f9870498 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 1 Oct 2025 14:50:48 -0700
Subject: [PATCH 1/3] Calculate time to first BT, as a part of my push to
generate
jansvoboda11 wrote:
Perfect, thanks for your response!
https://github.com/llvm/llvm-project/pull/160748
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/161495
>From bf3f96512240f1387003405544fa081c64a63025 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Oct 2025 10:18:53 +0100
Subject: [PATCH 1/2] [lldb][NFCI] Remove the non-const reference
Mangled::GetMa
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/161520
Required for
>From f4e7b75aebadbb3f135f2cfd45fd80aba42598c9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Oct 2025 14:25:34 +0100
Subject: [PATCH] [lldb][test] Allow '.c' files to be used as shel
@@ -202,6 +202,10 @@ TargetStats::ToJSON(Target &target,
if (process_sp->GetDynamicLoader())
dyld_plugin_name = process_sp->GetDynamicLoader()->GetPluginName();
target_metrics_json.try_emplace("dyldPluginName", dyld_plugin_name);
+
+if (process_sp->GetCoreFile
@@ -477,6 +477,85 @@ std::string PlatformAndroid::GetRunAs() {
}
return run_as.str();
}
+uint32_t
+PlatformAndroid::FindProcesses(const ProcessInstanceInfoMatch &match_info,
+ ProcessInstanceInfoList &proc_infos) {
+ // Use the parent implemen
@@ -1791,6 +1797,7 @@ bool TypeSystemClang::RecordHasFields(const RecordDecl
*record_decl) {
for (base_class = cxx_record_decl->bases_begin(),
base_class_end = cxx_record_decl->bases_end();
base_class != base_class_end; ++base_class) {
+ assert(record
jimingham wrote:
It makes sense to clear the "next branch" breakpoint there. Either the thread
plan's next branch breakpoint was the only one we hit, in which case that part
of the step succeeded and we should clear that breakpoint, or there was a user
breakpoint there and we're going to give
https://github.com/yln edited https://github.com/llvm/llvm-project/pull/160952
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,29 @@
+#include
+#include
+#include
+#include
+
+// Produce some names on the trace
+const size_t tag_granule = 16;
+uint8_t *my_malloc(void) { return malloc(2 * tag_granule); }
+uint8_t *allocate(void) { return my_malloc(); }
+
+void my_free(void *ptr) { free(ptr);
@@ -0,0 +1,10 @@
+
+http://www.apple.com/DTDs/PropertyList-1.0.dtd";>
+
+
+com.apple.security.hardened-process
+
+com.apple.security.hardened-process.checked-allocations
yln wrote:
This enables MTE in processes spawned from this binary in the producti
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/160748
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/161655
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
Any thoughts on my style question about the code structure?
https://github.com/llvm/llvm-project/pull/159160
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ldionne wrote:
I'm going to close this to clean up review queues. We've agreed that this
should be done as separate patches (depending on the RFC result), so let's
reopen new PRs if we decide to move forward with this.
https://github.com/llvm/llvm-project/pull/156995
__
JustinStitt wrote:
OK, I'll work on scaling back my custom promotion/conversion rules. Might take
a couple days because every test needs to be rewritten too.
https://github.com/llvm/llvm-project/pull/148914
___
lldb-commits mailing list
lldb-commits@l
https://github.com/qxy11 updated
https://github.com/llvm/llvm-project/pull/160736
>From c155381f49915fa98bd6e3ea14eb77b1dfcd7dbd Mon Sep 17 00:00:00 2001
From: qxy11
Date: Thu, 25 Sep 2025 09:54:50 -0700
Subject: [PATCH 1/8] Add support for unique target ids
---
lldb/include/lldb/API/SBDebugg
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/159160
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
I like the single template argument and using its dependent types. I don't know
enough about C++20 concepts to have an opinion on that part, but if your
proposed approach happens to bring the two implementations closer together,
then that seems like a nice to have.
https:
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/161691
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jacob Lalonde
Date: 2025-10-02T09:20:17-07:00
New Revision: 3c8c500a191e81044beeb6ec566f6aebd202c3c3
URL:
https://github.com/llvm/llvm-project/commit/3c8c500a191e81044beeb6ec566f6aebd202c3c3
DIFF:
https://github.com/llvm/llvm-project/commit/3c8c500a191e81044beeb6ec566f6aebd202c3c3.diff
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/161691
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/161688
Since it's a 'Note' diagnostic it would only show up when expression evaluation
actually failed. This helps with expression evaluation failure reports in mixed
language environments where it's not quite clea
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Fixes some casing mistakes I added in #161581
---
Full diff: https://github.com/llvm/llvm-project/pull/161691.diff
2 Files Affected:
- (modified) lldb/source/API/SBTarget.cpp (+1-1)
- (modified) lldb/sour
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/161691
Fixes some casing mistakes I added in #161581
>From c62857c97e9647b4bbe911f6a49f3bdeef7d0599 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 1 Oct 2025 17:05:28 -0700
Subject: [PATCH] Fix variable casin
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/161688
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Since it's a 'Note' diagnostic it would only show up when expression evaluation
actually failed. This helps with expression evaluation failure reports in mixed
language environments where it's not quite cl
Michael137 wrote:
Have yet to write tests for it.
https://github.com/llvm/llvm-project/pull/161688
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
thanks
https://github.com/llvm/llvm-project/pull/161089
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -294,3 +294,145 @@ def test_version(self):
self.assertEqual(instance_str, class_str)
self.assertEqual(class_str, property_str)
+
+def test_find_target_with_unique_id(self):
+"""Test SBDebugger.FindTargetWithUniqueID() functionality."""
+
+
@@ -357,6 +357,13 @@ class LLDB_API SBTarget {
const char *GetLabel() const;
+ /// Get the globally unique ID for this target.
walter-erquinigo wrote:
Mention that this ID is unique across all debugger instances wthin the same
lldb process.
https://gith
@@ -96,6 +96,7 @@
#define LLDB_INVALID_QUEUE_ID 0
#define LLDB_INVALID_CPU_ID UINT32_MAX
#define LLDB_INVALID_WATCHPOINT_RESOURCE_ID UINT32_MAX
+#define LLDB_INVALID_TARGET_ID 0
walter-erquinigo wrote:
```suggestion
#define LLDB_INVALID_GLOBALLY_UNIQUE_TARGET_
@@ -294,3 +294,145 @@ def test_version(self):
self.assertEqual(instance_str, class_str)
self.assertEqual(class_str, property_str)
+
+def test_find_target_with_unique_id(self):
+"""Test SBDebugger.FindTargetWithUniqueID() functionality."""
--
@@ -159,6 +159,17 @@ class TargetList : public Broadcaster {
lldb::TargetSP FindTargetWithProcess(lldb_private::Process *process) const;
+ /// Find the target that has a globally unique ID that matches ID \a id
+ ///
+ /// \param[in] id
+ /// The globally unique tar
@@ -294,3 +294,145 @@ def test_version(self):
self.assertEqual(instance_str, class_str)
self.assertEqual(class_str, property_str)
+
+def test_find_target_with_unique_id(self):
+"""Test SBDebugger.FindTargetWithUniqueID() functionality."""
+
+
https://github.com/walter-erquinigo requested changes to this pull request.
pretty nice. Almost there
https://github.com/llvm/llvm-project/pull/160736
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/160736
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/161673
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Relates to #161510
(it's not fixing it, it's just making the error not be an unhandled error)
When we fail to attach to a process we see if we can add more information about
why it happened:
```
if
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/161673
Relates to #161510
(it's not fixing it, it's just making the error not be an unhandled error)
When we fail to attach to a process we see if we can add more information about
why it happened:
```
if (st
https://github.com/qxy11 updated
https://github.com/llvm/llvm-project/pull/160736
>From c155381f49915fa98bd6e3ea14eb77b1dfcd7dbd Mon Sep 17 00:00:00 2001
From: qxy11
Date: Thu, 25 Sep 2025 09:54:50 -0700
Subject: [PATCH 1/6] Add support for unique target ids
---
lldb/include/lldb/API/SBDebugg
Author: Michael Buch
Date: 2025-10-02T13:48:46+01:00
New Revision: 82b3057a5ec552d5e42bb595c8243e4fac0c70b4
URL:
https://github.com/llvm/llvm-project/commit/82b3057a5ec552d5e42bb595c8243e4fac0c70b4
DIFF:
https://github.com/llvm/llvm-project/commit/82b3057a5ec552d5e42bb595c8243e4fac0c70b4.diff
https://github.com/qxy11 updated
https://github.com/llvm/llvm-project/pull/160736
>From c155381f49915fa98bd6e3ea14eb77b1dfcd7dbd Mon Sep 17 00:00:00 2001
From: qxy11
Date: Thu, 25 Sep 2025 09:54:50 -0700
Subject: [PATCH 1/7] Add support for unique target ids
---
lldb/include/lldb/API/SBDebugg
Author: Michael Buch
Date: 2025-10-02T13:33:21+01:00
New Revision: 7e6d277d3bd10bacc121962637c3c646866e2ca3
URL:
https://github.com/llvm/llvm-project/commit/7e6d277d3bd10bacc121962637c3c646866e2ca3
DIFF:
https://github.com/llvm/llvm-project/commit/7e6d277d3bd10bacc121962637c3c646866e2ca3.diff
Author: Michael Buch
Date: 2025-10-02T13:30:43+01:00
New Revision: 86ba1986a29478681ddc64af7d08fdff390b00e8
URL:
https://github.com/llvm/llvm-project/commit/86ba1986a29478681ddc64af7d08fdff390b00e8
DIFF:
https://github.com/llvm/llvm-project/commit/86ba1986a29478681ddc64af7d08fdff390b00e8.diff
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/161655
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This reverts `5a80fb9177e3c831c9c574400a13d77393397f2a`. The original change
got reverted because of failing tests on macOS.
The issue was that I changed the scope of setting `type = eSymbolTypeData`
duri
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/161655
This reverts `5a80fb9177e3c831c9c574400a13d77393397f2a`. The original change
got reverted because of failing tests on macOS.
The issue was that I changed the scope of setting `type = eSymbolTypeData`
during
Nerixyz wrote:
> Btw, @al45tair pointed out to me that mangled names can appear in multiple
> places in PDB. One has prefixed mangled names and the other doesnt (i think
> the one per module doesnt). So you have to make sure we only strip the ones
> that are actually prefixed
Where else do th
Author: Michael Buch
Date: 2025-10-02T11:59:26+01:00
New Revision: 6382bb5dda106a4bae0f0a17e88396036969784b
URL:
https://github.com/llvm/llvm-project/commit/6382bb5dda106a4bae0f0a17e88396036969784b
DIFF:
https://github.com/llvm/llvm-project/commit/6382bb5dda106a4bae0f0a17e88396036969784b.diff
Michael137 wrote:
> > Could you elaborate the configuration here? Compiled with `clang-cl` on a
> > Windows host I assume? Is this with `-gdwarf`? Couldn't get something like
> > that to work on Godbolt
>
> Sure, https://godbolt.org/z/Gj968q3xs shows the functions. Getting clang(-cl)
> to bui
https://github.com/DavidSpickett approved this pull request.
This LGTM, I think I answered my own question about how you enable tagging.
It's per-process not per-page like on Linux.
https://github.com/llvm/llvm-project/pull/160952
___
lldb-commits mai
@@ -0,0 +1,10 @@
+
+http://www.apple.com/DTDs/PropertyList-1.0.dtd";>
+
+
+com.apple.security.hardened-process
+
+com.apple.security.hardened-process.checked-allocations
DavidSpickett wrote:
So this opts the entire process into tagging, correct?
http
@@ -0,0 +1,29 @@
+#include
+#include
+#include
+#include
+
+// Produce some names on the trace
+const size_t tag_granule = 16;
+uint8_t *my_malloc(void) { return malloc(2 * tag_granule); }
+uint8_t *allocate(void) { return my_malloc(); }
+
+void my_free(void *ptr) { free(ptr);
@@ -0,0 +1,28 @@
+#include
+#include
+#include
+#include
+
+// Produce some names on the trace
+const size_t tag_granule = 16;
+static uint8_t *my_malloc(void) { return malloc(2 * tag_granule); }
+static uint8_t *allocate(void) { return my_malloc(); }
+
+static void my_free(vo
DavidSpickett wrote:
> My understanding is that all of the tag interpretation and error handling
> happens on the LLDB client side, so these aspects are already tested by the
> Linux tests. I essentially only re-implemented the existing qMemTags packet
> in debugserver and added integration te
DavidSpickett wrote:
> Do we have any plans of addressing this? @JDevlieghere @jasonmolenda
I asked the question expecting the answer to be no, just to be clear :)
In an ideal world we'd have this but I'm not going to block this review because
of it.
https://github.com/llvm/llvm-project/pull/
@@ -47,6 +47,12 @@ def debugger_pid: S<"debugger-pid">,
HelpText<"The PID of the lldb-dap instance that sent the launchInTerminal "
"request when using --launch-target.">;
+def stdio: S<"stdio">,
DrSergei wrote:
I expect only paths here because we have
Michael137 wrote:
> > Other C and C++ names don't have it in DWARF though (even on Windows), as
> > your Godbolt link demonstrates.
>
>
>
> I didn't notice this at first, you're right. With PDB, you get these names:
>
> ```
>
> 431284 | S_PUB32 [size = 28] `_CFuncCCall`
>
>fl
slydiman wrote:
lldb-x86_64-win buildbot is broken
https://lab.llvm.org/buildbot/#/builders/211/builds/2496
Please fix it.
https://github.com/llvm/llvm-project/pull/161520
___
lldb-commits mailing list
[email protected]
https://lists.llvm.or
95 matches
Mail list logo
