Michael137 wrote:
> lldb-x86_64-win buildbot is broken
>
> https://lab.llvm.org/buildbot/#/builders/211/builds/2496
>
> Please fix it.
Will check when I'm back at PC
https://github.com/llvm/llvm-project/pull/161520
___
lldb-commits mailing list
lld
@@ -157,3 +158,25 @@ def test_command_stats_force(self):
stats_force.GetAsJSON(stream_force)
debug_stats_force = json.loads(stream_force.GetData())
self.assertEqual(debug_stats_force["totalDebugInfoByteSize"], 445)
+
+def test_core_load_time(self):
+
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/160952
>From e16adb15486694876c5486604474ba6195f8dece Mon Sep 17 00:00:00 2001
From: Julian Lettner
Date: Wed, 23 Jul 2025 10:53:14 -0700
Subject: [PATCH 01/11] Extend MemoryRegionInfo to include flags
Extend handling of `
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/161604
As a part of my recent work on Coredump metrics, I've come up with an 'active
time to first bt', where we look at the total time spent loading all the data
to get LLDB to report it's first backtrace.
One desig
@@ -1303,9 +1309,16 @@
PlatformDarwin::LaunchProcess(lldb_private::ProcessLaunchInfo &launch_info) {
lldb_private::Status PlatformDarwin::FindBundleBinaryInExecSearchPaths(
const ModuleSpec &module_spec, Process *process, ModuleSP &module_sp,
-const FileSpecList *modu
https://github.com/JDevlieghere commented:
Please use the LLDB naming conventions for the local variables.
https://github.com/llvm/llvm-project/pull/161581
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman
@@ -202,6 +202,10 @@ TargetStats::ToJSON(Target &target,
if (process_sp->GetDynamicLoader())
dyld_plugin_name = process_sp->GetDynamicLoader()->GetPluginName();
target_metrics_json.try_emplace("dyldPluginName", dyld_plugin_name);
+
+if (process_sp->GetCoreFile
@@ -255,6 +255,7 @@ SBProcess SBTarget::LoadCore(const char *core_file,
lldb::SBError &error) {
ProcessSP process_sp(target_sp->CreateProcess(
target_sp->GetDebugger().GetListener(), "", &filespec, false));
if (process_sp) {
+ ElapsedTime loadCoreTime(targ
mstorsjo wrote:
Yeah - it doesn't need to be a regression in 21.x for the fix to be backported,
any reasonable bug fix can be eligible IMO.
https://github.com/llvm/llvm-project/pull/159308
___
lldb-commits mailing list
[email protected]
http
@@ -1087,6 +1089,24 @@ ModuleList::GetSharedModule(const ModuleSpec
&module_spec, ModuleSP &module_sp,
if (module_sp)
return error;
+ // Try target's platform locate module callback before second attempt
+ if (allow_locate_callback) {
+ModuleSpec module_spec_copy(
@@ -1087,6 +1089,24 @@ ModuleList::GetSharedModule(const ModuleSpec
&module_spec, ModuleSP &module_sp,
if (module_sp)
return error;
+ // Try target's platform locate module callback before second attempt
+ if (allow_locate_callback) {
+ModuleSpec module_spec_copy(
@@ -126,6 +127,18 @@ class ModuleSpec {
lldb::DataBufferSP GetData() const { return m_data; }
+ Target *GetTargetPtr() {
+auto locked = m_target.lock();
+return locked.get();
+ }
JDevlieghere wrote:
This is inherently unsafe: once you return the
@@ -341,18 +340,25 @@ Status PlatformDarwin::GetSharedModule(
// module first.
if (m_remote_platform_sp) {
error = m_remote_platform_sp->GetSharedModule(
- module_spec, process, module_sp, module_search_paths_ptr,
old_modules,
- did_create_ptr);
@@ -476,9 +476,9 @@ class ModuleList {
static Status
GetSharedModule(const ModuleSpec &module_spec, lldb::ModuleSP &module_sp,
- const FileSpecList *module_search_paths_ptr,
llvm::SmallVectorImpl *old_modules,
- bool *di
@@ -767,9 +763,19 @@ Platform::ResolveExecutable(const ModuleSpec &module_spec,
Status error;
for (const ArchSpec &arch : GetSupportedArchitectures(process_host_arch)) {
resolved_module_spec.GetArchitecture() = arch;
-error =
-ModuleList::GetSharedModule(res
@@ -1087,6 +1089,24 @@ ModuleList::GetSharedModule(const ModuleSpec
&module_spec, ModuleSP &module_sp,
if (module_sp)
return error;
+ // Try target's platform locate module callback before second attempt
+ if (allow_locate_callback) {
+ModuleSpec module_spec_copy(
@@ -767,9 +763,19 @@ Platform::ResolveExecutable(const ModuleSpec &module_spec,
Status error;
for (const ArchSpec &arch : GetSupportedArchitectures(process_host_arch)) {
resolved_module_spec.GetArchitecture() = arch;
-error =
-ModuleList::GetSharedModule(res
@@ -1114,6 +1134,16 @@ ModuleList::GetSharedModule(const ModuleSpec
&module_spec, ModuleSP &module_sp,
module_sp.reset();
}
+ // Get module search paths from the target if available
JDevlieghere wrote:
```suggestion
// Get module search paths from t
@@ -1087,6 +1089,24 @@ ModuleList::GetSharedModule(const ModuleSpec
&module_spec, ModuleSP &module_sp,
if (module_sp)
return error;
+ // Try target's platform locate module callback before second attempt
JDevlieghere wrote:
```suggestion
// Try targ
https://github.com/JDevlieghere requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/160199
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/160416
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -255,6 +255,7 @@ SBProcess SBTarget::LoadCore(const char *core_file,
lldb::SBError &error) {
ProcessSP process_sp(target_sp->CreateProcess(
target_sp->GetDebugger().GetListener(), "", &filespec, false));
if (process_sp) {
+ ElapsedTime loadCoreTime(targ
@@ -202,6 +202,10 @@ TargetStats::ToJSON(Target &target,
if (process_sp->GetDynamicLoader())
dyld_plugin_name = process_sp->GetDynamicLoader()->GetPluginName();
target_metrics_json.try_emplace("dyldPluginName", dyld_plugin_name);
+
+if (process_sp->GetCoreFile
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/161597
>From cabf9ffb7532d010d15bc916c9432650f46726f6 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Wed, 1 Oct 2025 15:26:20 -0700
Subject: [PATCH] [lldb] Add deleted line in NextRangeBreakpointExplainsStop
@@ -255,6 +255,7 @@ SBProcess SBTarget::LoadCore(const char *core_file,
lldb::SBError &error) {
ProcessSP process_sp(target_sp->CreateProcess(
target_sp->GetDebugger().GetListener(), "", &filespec, false));
if (process_sp) {
+ ElapsedTime loadCoreTime(targ
@@ -202,6 +202,10 @@ TargetStats::ToJSON(Target &target,
if (process_sp->GetDynamicLoader())
dyld_plugin_name = process_sp->GetDynamicLoader()->GetPluginName();
target_metrics_json.try_emplace("dyldPluginName", dyld_plugin_name);
+
+if (process_sp->GetCoreFile
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/161497
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/161581
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -418,7 +418,11 @@ class CommandObjectTargetCreate : public
CommandObjectParsed {
if (process_sp) {
// Seems weird that we Launch a core file, but that is what we
// do!
- error = process_sp->LoadCore();
+ {
+ElapsedT
augusto2112 wrote:
@jeffreytan81, do you remember if the deletion of this line
(https://github.com/llvm/llvm-project/pull/90930/files#diff-46aa8e984a6ebc1d4032efa38c8fba130ab4a8851fba18842e36c37daef32e50L421)
was accidental or if there was a reason behind it? I ran the test suite
locally and n
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/161597
Commit f838fa820f9271008617c345c477122d9e29a05c refactored large pointers of
the thread plan code. In that refactor, the call to ClearNextBranchBreakpoint in
ThreadPlanStepRange::NextRangeBreakpointExplainsS
@@ -148,6 +148,11 @@ TargetStats::ToJSON(Target &target,
target_metrics_json.try_emplace("targetCreateTime",
m_create_time.get().count());
+if (m_load_core_time.get().count() > 0) {
dmpots wrote:
Do we need to condi
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/161581
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DrSergei wrote:
I updated the redirection logic to handle the case where multiple descriptors
are redirected to the same file to avoid opening it twice.
https://github.com/llvm/llvm-project/pull/161089
___
lldb-commits mailing list
lldb-commits@lists.
https://github.com/DrSergei updated
https://github.com/llvm/llvm-project/pull/161089
>From 0fed265f9bb48efbf07d2d11b32737ca0efbc2af Mon Sep 17 00:00:00 2001
From: Druzhkov Sergei
Date: Sun, 28 Sep 2025 12:45:01 +0300
Subject: [PATCH 1/2] [lldb-dap] Add stdio redirection for integrated and
exte
@@ -157,3 +158,25 @@ def test_command_stats_force(self):
stats_force.GetAsJSON(stream_force)
debug_stats_force = json.loads(stream_force.GetData())
self.assertEqual(debug_stats_force["totalDebugInfoByteSize"], 445)
+
+def test_core_load_time(self):
+
https://github.com/dmpots approved this pull request.
LGTM. Added a few minor questions/comments.
https://github.com/llvm/llvm-project/pull/161581
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/dmpots edited
https://github.com/llvm/llvm-project/pull/161581
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
This is failing on Arm 32-bit:
https://lab.llvm.org/buildbot/#/builders/18/builds/21624
```
--
UNSUPPORTED: LLDB
(/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_dsym
(TestCppFloatingTypesSpecialization.TestCase) (test case does not fall in any
ca
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/161581
This patch adds a load core time, right now we don't have much insight into the
performance of load core, especially for large coredumps. To start collecting
information on this I've added some minor instrument
https://github.com/jasonmolenda approved this pull request.
LGTM, thanks for the change. I had one small style suggestion in
RegisterContextUnwind, if you agree with it.
https://github.com/llvm/llvm-project/pull/161398
___
lldb-commits mailing list
l
mstorsjo wrote:
> For the time being, we could strip only the __cdecl prefix in PDB to match
> DWARF and open an issue for the mangling of other calling conventions.
Sounds reasonble. If we add good test coverage for these cases, we should be
kinda free to adjust the exact implementation later
https://github.com/JDevlieghere approved this pull request.
Makes sense, but I'd like @jasonmolenda to sign off.
https://github.com/llvm/llvm-project/pull/161398
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/
walter-erquinigo wrote:
@qxy11: Jim gave you good feedback. Try to apply that and I'll do a review
https://github.com/llvm/llvm-project/pull/160736
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinf
Author: Augusto Noronha
Date: 2025-10-01T10:50:59-07:00
New Revision: 5a80fb9177e3c831c9c574400a13d77393397f2a
URL:
https://github.com/llvm/llvm-project/commit/5a80fb9177e3c831c9c574400a13d77393397f2a
DIFF:
https://github.com/llvm/llvm-project/commit/5a80fb9177e3c831c9c574400a13d77393397f2a.dif
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/160952
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -150,6 +152,63 @@ nub_bool_t MachVMMemory::GetMemoryRegionInfo(task_t task,
nub_addr_t address,
return true;
}
+// API availability:
+// mach_vm_update_pointers_with_remote_tags() - 26.0
+// VM_OFFSET_LIST_MAX macro - 26.1
+#ifndef VM_OFFSET_LIST_MAX
+#define VM_OFFSET
@@ -150,6 +152,63 @@ nub_bool_t MachVMMemory::GetMemoryRegionInfo(task_t task,
nub_addr_t address,
return true;
}
+// API availability:
+// mach_vm_update_pointers_with_remote_tags() - 26.0
+// VM_OFFSET_LIST_MAX macro - 26.1
+#ifndef VM_OFFSET_LIST_MAX
+#define VM_OFFSET
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/160952
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/161528
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ojeda wrote:
Agreed, some people in the committee wanted/want a feature like that, but it is
hard to say what form it would take, if any.
https://github.com/llvm/llvm-project/pull/148914
___
lldb-commits mailing list
[email protected]
https:
llvmbot wrote:
/pull-request llvm/llvm-project#161541
https://github.com/llvm/llvm-project/pull/159308
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
It always "worked", just slowly. So it's like backporting a code generation
improvement, which we have been known to do. Worth a try.
I would support it on the basis that the patch is very simple and we haven't
seen any regressions.
https://github.com/llvm/llvm-project/
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/161536
>From f4e7b75aebadbb3f135f2cfd45fd80aba42598c9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Oct 2025 14:25:34 +0100
Subject: [PATCH 1/4] [lldb][test] Allow '.c' files to be used as shell tests
--
Nerixyz wrote:
/cherry-pick a868f28c6e9beecb2b3fbe8acfbe0d272fabd14d
https://github.com/llvm/llvm-project/pull/159308
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-10-01T16:47:15+01:00
New Revision: 9f7e7f7d9c9f46cfe83481b1e79d7c8a3e11580e
URL:
https://github.com/llvm/llvm-project/commit/9f7e7f7d9c9f46cfe83481b1e79d7c8a3e11580e
DIFF:
https://github.com/llvm/llvm-project/commit/9f7e7f7d9c9f46cfe83481b1e79d7c8a3e11580e.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/161521
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/161521
>From f4e7b75aebadbb3f135f2cfd45fd80aba42598c9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Oct 2025 14:25:34 +0100
Subject: [PATCH 1/4] [lldb][test] Allow '.c' files to be used as shell tests
--
Author: Michael Buch
Date: 2025-10-01T16:26:55+01:00
New Revision: f33564b9afaa34ffd92b754db7a5ff8ff5e60897
URL:
https://github.com/llvm/llvm-project/commit/f33564b9afaa34ffd92b754db7a5ff8ff5e60897
DIFF:
https://github.com/llvm/llvm-project/commit/f33564b9afaa34ffd92b754db7a5ff8ff5e60897.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/161495
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/161521
>From f4e7b75aebadbb3f135f2cfd45fd80aba42598c9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Oct 2025 14:25:34 +0100
Subject: [PATCH 1/2] [lldb][test] Allow '.c' files to be used as shell tests
--
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/161520
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/161536
>From f4e7b75aebadbb3f135f2cfd45fd80aba42598c9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Oct 2025 14:25:34 +0100
Subject: [PATCH 1/4] [lldb][test] Allow '.c' files to be used as shell tests
--
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/161521
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
This is a very pointless overload anyway.
https://github.com/llvm/llvm-project/pull/161495
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/lis
kees wrote:
Would it be reasonable to split this into two phases?
1) this PR, but with standard promotion semantics and instrumented casting.
2) new PR that adds a type qualifier named `__strict` or
`__no_implicit_promotion` that forces annotated types to not be involved in
implicit promotion
Author: David Spickett
Date: 2025-10-01T15:53:10+01:00
New Revision: edb80a8d7fb2e1e29a4cb792148b4ffd441eb114
URL:
https://github.com/llvm/llvm-project/commit/edb80a8d7fb2e1e29a4cb792148b4ffd441eb114
DIFF:
https://github.com/llvm/llvm-project/commit/edb80a8d7fb2e1e29a4cb792148b4ffd441eb114.diff
DavidSpickett wrote:
Landing to get the bot green.
https://github.com/llvm/llvm-project/pull/161528
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Fixes #157674
On ARM, the presence of a specific bf16 type in the AST is gated by:
```
bool ARMTargetInfo::hasBFloat16Type() const {
// The __bf16 type is generally available so long as we have any
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/161528
Fixes #157674
On ARM, the presence of a specific bf16 type in the AST is gated by: bool
ARMTargetInfo::hasBFloat16Type() const {
// The __bf16 type is generally available so long as we have any fp regis
DavidSpickett wrote:
A few printfs later:
```
(lldb) p f0
Typename::>>> __bf16
has bfloat16?: 0
HasBfloat16: 0
FPU: 0
SoftFloat: 0
Qual type: __bf16
qual_type_bit_size = 0, bit_size = 16
Qual type: float
qual_type_bit_size = 32, bit_size = 16
Qual type: double
qual_type_bit_size = 64,
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
On Darwin C-symbols are prefixed with a '_'. The LLDB Macho-O parses handles
Objective-C metadata symbols starting with '_OBJC' specially. Previously global
symbols starting with a '_O' prefix were lost be
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/154123
>From f158ed36c1045b8b996786b7c022fd26680d95ea Mon Sep 17 00:00:00 2001
From: Timur Golubovich
Date: Mon, 8 Sep 2025 14:43:50 +0300
Subject: [PATCH] [lldb][DWARFASTParserClang] Added a check for the
speciali
tgs-sc wrote:
@Michael137, can you please rerun CI to this PR? As
https://github.com/llvm/llvm-project/pull/157674 was merged, this one can be
merged too I think.
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-com
DavidSpickett wrote:
Mind you, aren't ConstStrings encoded into some kind of table? This could be a
single byte random write from something completely unrelated.
https://github.com/llvm/llvm-project/pull/161499
___
lldb-commits mailing list
lldb-commi
https://github.com/DavidSpickett approved this pull request.
On the basis of saving a strlen, LGTM.
https://github.com/llvm/llvm-project/pull/161499
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/161499
We've been seen (very sporadic) lifetime issues around this area. Here's an
example backtrace:
```
[ 8] 0x000188e56743 libsystem_platform.dylib`_sigtramp + 55
[ 9] 0x0001181e041f
LLDB`lldb_private:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Georgiy Samoylov (sga-sc)
Changes
This test failed during testing on the RISC-V target because we couldn't strip
the main label from the binary. main is dynamically linked when the -fPIC flag
is enabled. The RISC-V ABI requires that execut
78 matches
Mail list logo
