llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (GeorgeHuyubo)
Changes
Fixes a deadlock that occurs during parallel module loading when symbol indexing
operations conflict with module list access. The deadlock happens when:
- Thread A (symbol loading): holds Module.m_mutex → tries
https://github.com/GeorgeHuyubo ready_for_review
https://github.com/llvm/llvm-project/pull/160225
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/160225
>From 51e9f664a755da9175a29ca0537cf8996dd97fb9 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Mon, 22 Sep 2025 20:48:57 -0700
Subject: [PATCH] [lldb] Fix deadlock in parallel module loading with separate
s
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/160225
>From f9edaeca77dd44dc36f3e44acaaea1249d0d9b71 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Mon, 22 Sep 2025 20:48:57 -0700
Subject: [PATCH] [lldb] Fix deadlock in parallel module loading with separate
s
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/160225
>From b4f6da6ff87b109d21bb1cc4e309d698cc0e99fe Mon Sep 17 00:00:00 2001
From: George Hu
Date: Mon, 22 Sep 2025 20:48:57 -0700
Subject: [PATCH] [lldb] Fix deadlock in parallel module loading with separate
s
GeorgeHuyubo wrote:
> 2. It sucks we have to have two code paths for locating modules, one for
> shared libraries, one for main executable. I wonder if we should consolidate
> to a central place? Like `ModuleList::GetSharedModule`?
Thought about this too, but `ModuleList::GetSharedModule` is a
https://github.com/GeorgeHuyubo created
https://github.com/llvm/llvm-project/pull/160225
Fixes a deadlock that occurs during parallel module loading when symbol indexing
operations conflict with module list access. The deadlock happens when:
- Thread A (symbol loading): holds Module.m_mutex → t
https://github.com/GeorgeHuyubo ready_for_review
https://github.com/llvm/llvm-project/pull/160199
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -35,9 +35,7 @@ using namespace lldb_private;
Statusline::Statusline(Debugger &debugger)
: m_debugger(debugger), m_terminal_width(m_debugger.GetTerminalWidth()),
- m_terminal_height(m_debugger.GetTerminalHeight()) {
- Enable();
-}
+ m_terminal_height(m_debugge
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff origin/main HEAD --extensions cpp --
lldb/source/Target/Platform.cpp
``
:war
https://github.com/GeorgeHuyubo created
https://github.com/llvm/llvm-project/pull/160199
Main executables were bypassing the locate module callback that shared
libraries use, preventing custom symbol file location logic from working
consistently.
Fixed by modifying Platform::ResolveExecutabl
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/159797
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/160067
>From 4dab54fd1d003e99ac0b1014b276f0c6d24f9de2 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Mon, 22 Sep 2025 12:32:08 +0200
Subject: [PATCH 1/4] [LLDB][PDB] Warn if DIA plugin is requested but not
available
--
royitaqi wrote:
@walter-erquinigo: Gentle ping.
Since your last review, I have:
- Used `chokidar`.
- Rebased on latest main.
- When both the lldb-dap binary and the arguments have changed, I made the
dialog box show both changes (see the first screenshot in the patch's
description).
https://g
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/160149
>From 085e848344f5772b3d1481c24ca6471fe45c9138 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Mon, 22 Sep 2025 20:05:57 +0500
Subject: [PATCH 1/2] [lldb] Use APSInt's right shift operator in Scalar
---
lldb/s
@@ -118,11 +118,14 @@ TEST(ScalarTest, RightShiftOperator) {
int a = 0x1000;
int b = 0x;
int c = 4;
+ unsigned d = 0x;
Scalar a_scalar(a);
Scalar b_scalar(b);
Scalar c_scalar(c);
+ Scalar d_scalar(d);
ASSERT_EQ(a >> c, a_scalar >> c_scala
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/160149
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/tambry edited
https://github.com/llvm/llvm-project/pull/159106
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kuilpd created
https://github.com/llvm/llvm-project/pull/160149
Right shift operator in `Scalar` didn't check if the value is unsigned to
perform a logical right shift. Use the right shift operator from `APSInt` that
does this check.
>From 085e848344f5772b3d1481c24ca6471fe4
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ilia Kuklin (kuilpd)
Changes
Right shift operator in `Scalar` didn't check if the value is unsigned to
perform a logical right shift. Use the right shift operator from `APSInt` that
does this check.
---
Full diff: https://github.com/llvm/
@@ -0,0 +1,65 @@
+// REQUIRES: !diasdk, target-windows
+
+// Test plugin.symbol-file.pdb.reader setting without the DIA SDK
+// RUN: %build -o %t.exe -- %s
+// RUN: env -u LLDB_USE_NATIVE_PDB_READER %lldb %t.exe -o 'target modules dump
symfile' 2>&1 | FileCheck --check-prefix=NO-
@@ -136,6 +141,21 @@ class PluginProperties : public Properties {
bool UseNativeReader() const {
#if LLVM_ENABLE_DIA_SDK && defined(_WIN32)
+return IsNativeReaderRequested();
+#else
+if (!IsNativeReaderRequested()) {
+ static std::once_flag g_warning_shown;
+
Author: Michael Buch
Date: 2025-09-22T17:24:15+01:00
New Revision: cbfa5c84f9423b94d499de7995c0f0eeff066c93
URL:
https://github.com/llvm/llvm-project/commit/cbfa5c84f9423b94d499de7995c0f0eeff066c93
DIFF:
https://github.com/llvm/llvm-project/commit/cbfa5c84f9423b94d499de7995c0f0eeff066c93.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/160074
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/160074
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/160132
>From 6293105c42e29cc9151eaac33a4208a91e40a0e9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 22 Sep 2025 16:02:35 +0100
Subject: [PATCH 1/4] Init
---
.../SymbolFile/DWARF/DWARFASTParserClang.cpp |
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/160132
>From 6293105c42e29cc9151eaac33a4208a91e40a0e9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 22 Sep 2025 16:02:35 +0100
Subject: [PATCH 1/2] Init
---
.../SymbolFile/DWARF/DWARFASTParserClang.cpp |
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/160132
None
>From 6293105c42e29cc9151eaac33a4208a91e40a0e9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 22 Sep 2025 16:02:35 +0100
Subject: [PATCH] Init
---
.../SymbolFile/DWARF/DWARFASTParserClang.cpp
https://github.com/satyajanga approved this pull request.
Looks good to me !
https://github.com/llvm/llvm-project/pull/159842
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/satyajanga closed
https://github.com/llvm/llvm-project/pull/159842
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/159401
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/159769
>From d2c6336279358e570dcdc4e4a1ce75baf0a048ee Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Mon, 22 Sep 2025 11:57:34 +0200
Subject: [PATCH] [LLDB][PDB] Run UDT layout test with native PDB too
---
.../SymbolFi
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/159401
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -117,11 +117,16 @@ bool ShouldUseNativeReaderByDefault() {
!env_value.equals_insensitive("1") &&
!env_value.equals_insensitive("true"))
g_use_native_by_default = false;
+
+#if !LLVM_ENABLE_DIA_SDK || !defined(_WIN32)
+// if the environment value is
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/160074
…e persistent variables
Here's an example crash that we've seen sporadically over the years:
```
0 libsystem_kernel.dylib 0x19d392388 __pthread_kill + 8
1 libsystem_pthread.dylib
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/160067
>From 4dab54fd1d003e99ac0b1014b276f0c6d24f9de2 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Mon, 22 Sep 2025 12:32:08 +0200
Subject: [PATCH 1/2] [LLDB][PDB] Warn if DIA plugin is requested but not
available
--
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/160074
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
The `m_passthrough` guard was added in
https://github.com/llvm/llvm-project/commit/4e969da33e113dffc1dfcf5c5e3ef97e3b594161
I assume something got refactored since then that broke it again. Or maybe it
was fixing a different codepath leading to this crash
https://github.com/
https://github.com/Nerixyz created
https://github.com/llvm/llvm-project/pull/160067
If LLDB was built without the DIA SDK and the DIA reader is explicitly
requested (through `LLDB_USE_NATIVE_PDB_READER=0` or `settings set
plugin.symbol-file.pdb.reader dia`), LLDB should print a warning, becaus
DavidSpickett wrote:
> In a very ideal world, I would love if we could not strip anything, ever. But
> this places some burden on codegen of the expression evaluator, for all
> languages and all ABIs. I don't think it's doable right now.
Yes we're getting into a pointers as capabilities sort o
@@ -1,51 +1,63 @@
REQUIRES: target-windows, lld
RUN: %build --compiler=clang-cl --output=%t.exe %S/Inputs/UdtLayoutTest.cpp
-RUN: %lldb -b -s %S/Inputs/UdtLayoutTest.script -- %t.exe | FileCheck %s
+RUN: env LLDB_USE_NATIVE_PDB_READER=0 %lldb -b -s
%S/Inputs/UdtLayoutTest.scrip
@@ -1,51 +1,63 @@
REQUIRES: target-windows, lld
RUN: %build --compiler=clang-cl --output=%t.exe %S/Inputs/UdtLayoutTest.cpp
-RUN: %lldb -b -s %S/Inputs/UdtLayoutTest.script -- %t.exe | FileCheck %s
+RUN: env LLDB_USE_NATIVE_PDB_READER=0 %lldb -b -s
%S/Inputs/UdtLayoutTest.scrip
@@ -1,51 +1,63 @@
REQUIRES: target-windows, lld
RUN: %build --compiler=clang-cl --output=%t.exe %S/Inputs/UdtLayoutTest.cpp
-RUN: %lldb -b -s %S/Inputs/UdtLayoutTest.script -- %t.exe | FileCheck %s
+RUN: env LLDB_USE_NATIVE_PDB_READER=0 %lldb -b -s
%S/Inputs/UdtLayoutTest.scrip
https://github.com/Michael137 approved this pull request.
Do you have a C++ example snippet of how this happens?
https://github.com/llvm/llvm-project/pull/159401
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/m
44 matches
Mail list logo
