[Lldb-commits] [lldb] [lldb] Add some vector operations to the IRInterpreter (PR #155000)

2025-09-04 Thread Michael Buch via lldb-commits
@@ -1564,7 +1660,103 @@ bool IRInterpreter::Interpret(llvm::Module &module, llvm::Function &function, returnVal = value.GetScalar(); // Push the return value as the result -frame.AssignValue(inst, returnVal, module); +frame.AssignValue(inst, re

[Lldb-commits] [lldb] [lldb][DataFormatter] Allow std::string formatters to match against custom allocators (PR #156050)

2025-09-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This came up in https://github.com/llvm/llvm-project/issues/155691. For `std::basic_string` our formatter matching logic required the allocator template parameter to be a `std::allocator`. There is no comp

[Lldb-commits] [lldb] [lldb] Add some vector operations to the IRInterpreter (PR #155000)

2025-09-04 Thread Michael Buch via lldb-commits
@@ -30,9 +30,14 @@ class ArchitecturePPC64 : public Architecture { void AdjustBreakpointAddress(const Symbol &func, Address &addr) const override; + lldb::ByteOrder GetVectorElementOrder() const override; + private: static std::unique_ptr

[Lldb-commits] [clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-09-04 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: ping, I need feedback from the DebugInfo experts, do the test changes look good? https://github.com/llvm/llvm-project/pull/155120 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [lldb] [lldb][DataFormatter] Allow std::string formatters to match against custom allocators (PR #156050)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 ready_for_review https://github.com/llvm/llvm-project/pull/156050 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix deterministic-build.cpp post #156931 (PR #156983)

2025-09-04 Thread via lldb-commits
cmtice wrote: Just FYI: That blank line got removed because otherwise it failed the code formatting premerge test. :-( https://github.com/llvm/llvm-project/pull/156983 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-09-04 Thread Anthony Eid via lldb-commits
@@ -62,7 +97,11 @@ struct Variables { /// These are the variables evaluated from debug console REPL. llvm::DenseMap m_referencedpermanent_variables; - int64_t m_next_temporary_var_ref{VARREF_FIRST_VAR_IDX}; + /// Key = frame_id + /// Value = (locals, globals Registers)

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-09-04 Thread Anthony Eid via lldb-commits
https://github.com/Anthony-Eid updated https://github.com/llvm/llvm-project/pull/124232 >From 30658e994b18b7c0db114a297036421c8de2dea3 Mon Sep 17 00:00:00 2001 From: Anthony Date: Wed, 27 Aug 2025 13:04:26 -0400 Subject: [PATCH 01/17] Fix variable request from reusing variable_ids --- .../lld

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [Inclusive Language] migrate "sanity" checks to "soundness" checks (PR #156995)

2025-09-04 Thread Rick van Voorden via lldb-commits
https://github.com/vanvoorden edited https://github.com/llvm/llvm-project/pull/156995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-09-04 Thread Anthony Eid via lldb-commits
@@ -62,7 +97,11 @@ struct Variables { /// These are the variables evaluated from debug console REPL. llvm::DenseMap m_referencedpermanent_variables; - int64_t m_next_temporary_var_ref{VARREF_FIRST_VAR_IDX}; + /// Key = frame_id + /// Value = (locals, globals Registers)

[Lldb-commits] [lldb] e7572d7 - [lldb][yaml2macho-core] fix typeo in API test

2025-09-04 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-09-04T19:57:05-07:00 New Revision: e7572d73b5fabe69844c943b776495121774 URL: https://github.com/llvm/llvm-project/commit/e7572d73b5fabe69844c943b776495121774 DIFF: https://github.com/llvm/llvm-project/commit/e7572d73b5fabe69844c943b776495121774.diff

[Lldb-commits] [lldb] 4c17749 - [lldb][yaml2macho-core] change the two API tests to skipUnlessDarwin

2025-09-04 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-09-04T19:53:16-07:00 New Revision: 4c17749b6d26093f33efd13f798d47b893252b15 URL: https://github.com/llvm/llvm-project/commit/4c17749b6d26093f33efd13f798d47b893252b15 DIFF: https://github.com/llvm/llvm-project/commit/4c17749b6d26093f33efd13f798d47b893252b15.diff

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [Inclusive Language] migrate "sanity" checks to "soundness" checks (PR #156995)

2025-09-04 Thread Rick van Voorden via lldb-commits
https://github.com/vanvoorden edited https://github.com/llvm/llvm-project/pull/156995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [Inclusive Language] migrate "sanity" checks to "soundness" checks (PR #156995)

2025-09-04 Thread Rick van Voorden via lldb-commits
https://github.com/vanvoorden edited https://github.com/llvm/llvm-project/pull/156995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [Inclusive Language] migrate "sanity" checks to "soundness" checks (PR #156995)

2025-09-04 Thread Rick van Voorden via lldb-commits
https://github.com/vanvoorden edited https://github.com/llvm/llvm-project/pull/156995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [Inclusive Language] migrate "sanity" checks to "soundness" checks (PR #156995)

2025-09-04 Thread Vlad Serebrennikov via lldb-commits
Endilll wrote: I'd like to see this massive change to be backed by an RFC on Discourse. That is also a good place to discuss various options for the exact wording. https://github.com/llvm/llvm-project/pull/156995 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libcxx] [lldb] [llvm] [mlir] [openmp] Fix typos and spelling errors across codebase (PR #156270)

2025-09-04 Thread Congcong Cai via lldb-commits
https://github.com/HerrCai0907 approved this pull request. clang-tools-extra/clang-tidy part LGTM https://github.com/llvm/llvm-project/pull/156270 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [Inclusive Language] migrate "sanity" checks to "soundness" checks (PR #156995)

2025-09-04 Thread Rick van Voorden via lldb-commits
https://github.com/vanvoorden edited https://github.com/llvm/llvm-project/pull/156995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [Inclusive Language] migrate "sanity" checks to "soundness" checks (PR #156995)

2025-09-04 Thread Jessica Clarke via lldb-commits
jrtc27 wrote: I worry that sound specifically may be interpreted as to do with soundness as in correctness, given thats the term used to talk about the correctness of compiler transformations https://github.com/llvm/llvm-project/pull/156995 ___ lldb-

[Lldb-commits] [lldb] 84b5620 - [lldb] Introduce ScriptedFrame affordance (#149622)

2025-09-04 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2025-09-04T15:07:11-07:00 New Revision: 84b56202fbe150e06f92c855107489e08cc17bcd URL: https://github.com/llvm/llvm-project/commit/84b56202fbe150e06f92c855107489e08cc17bcd DIFF: https://github.com/llvm/llvm-project/commit/84b56202fbe150e06f92c855107489e08cc17bcd.

[Lldb-commits] [lldb] [LLDB] Fix deterministic-build.cpp post #156931 (PR #156983)

2025-09-04 Thread via lldb-commits
https://github.com/cmtice approved this pull request. https://github.com/llvm/llvm-project/pull/156983 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix deterministic-build.cpp post #156931 (PR #156983)

2025-09-04 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: > Just FYI: That blank line got removed because otherwise it failed the code > formatting premerge test. :-( Good point. Updated to change the line number rather than add in the extra blank line. I've confirmed this fixes the issue locally, so I'm going to merge this onc

[Lldb-commits] [lldb] [lldb] Add more mnemonics (PR #156987)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/156987 Add a few more command option mnemonics. >From b86d0eada5f7b752851779fdc9aed08988e92b39 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 4 Sep 2025 16:51:55 -0700 Subject: [PATCH] [lldb] Add mor

[Lldb-commits] [lldb] [LLDB][NativePDB] Create functions with mangled name (PR #149701)

2025-09-04 Thread Reid Kleckner via lldb-commits
@@ -2353,3 +2356,67 @@ SymbolFileNativePDB::GetParentType(llvm::codeview::TypeIndex ti) { return std::nullopt; return parent_iter->second; } + +std::optional +SymbolFileNativePDB::FindMangledFunctionName(PdbCompilandSymId func_id) { + const CompilandIndexItem *cci = +

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @cmtice @boomanaiden154 1/3 are still failing: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/14864/testReport/lldb-shell/SymbolFile_DWARF/deterministic_build_cpp/ https://github.com/llvm/llvm-project/pull/156931 __

[Lldb-commits] [lldb] [lldb][elf-core][ARM] Add support for VFP registers (PR #155956)

2025-09-04 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: > I wanted to say merge this into the existing `linux-arm.core` but I can't > find any source for it. With all those neat sequential values across the GPR registers, it's clear that the file was created artificially. > So I'm ok with this being its own thing, and if you do h

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Roy Shi via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/156803 >From 9af1b0029e3e19b521d472d8c94596709f990166 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Wed, 3 Sep 2025 22:23:20 -0700 Subject: [PATCH 1/2] [lldb-dap] Add optional TTL argument when using --connection ---

[Lldb-commits] [lldb] [lldb] Add utility to create Mach-O corefile from YAML desc (PR #153911)

2025-09-04 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `lldb` at step 8 "build-default". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/8699 Here is the relevant piece of the bui

[Lldb-commits] [lldb] [LLDB][NativePDB] Create functions with mangled name (PR #149701)

2025-09-04 Thread via lldb-commits
@@ -2353,3 +2356,67 @@ SymbolFileNativePDB::GetParentType(llvm::codeview::TypeIndex ti) { return std::nullopt; return parent_iter->second; } + +std::optional +SymbolFileNativePDB::FindMangledFunctionName(PdbCompilandSymId func_id) { + const CompilandIndexItem *cci = +

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: Also, it would be great if we had a clang-tidy checker as part of the CI testing to catching this inconsistencies earlier 👀 https://github.com/llvm/llvm-project/pull/156774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Moving MCPTransport into its own file. (PR #156712)

2025-09-04 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/156712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-04 Thread via lldb-commits
cmtice wrote: Ok, I will revert this and try to work out how to test/fix the issues on windows (I wonder why it passed the windows CI premerge tests). https://github.com/llvm/llvm-project/pull/156729 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155705 >From 85e35e5ace2e5f8f851117268ae49c38f7f55477 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 4 Sep 2025 11:19:49 -0700 Subject: [PATCH] [lldb] Add more command option mnemonics #155705 --- l

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-04 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: #156939 should fix the last remaining issue. https://github.com/llvm/llvm-project/pull/156729 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/156774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't crash if no default unwind plan (PR #152481)

2025-09-04 Thread Alex Langford via lldb-commits
@@ -426,9 +426,12 @@ void RegisterContextUnwind::InitializeNonZerothFrame() { } } -if (abi_sp) { - m_fast_unwind_plan_sp.reset(); +m_fast_unwind_plan_sp.reset(); +m_full_unwind_plan_sp.reset(); bulbazord wrote: Is it necessary to cl

[Lldb-commits] [lldb] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/156868 >From 0e9fdefffde7c679873b0907147bb153763f4ea1 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Thu, 4 Sep 2025 14:18:02 +0100 Subject: [PATCH] [lldb] remove Python 3.9 specific typing annotations ---

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread David Spickett via lldb-commits
@@ -418,7 +418,7 @@ other command as far as there is only one alias command match."); if ((pos != std::string::npos) && (pos > 0)) raw_command_string = raw_command_string.substr(pos); } else { - result.AppendError("Error parsing command string. No alias

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame affordance (PR #149622)

2025-09-04 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/149622 >From 440e6ce8e00130621ec57160ffd80e54e179a5d2 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Thu, 4 Sep 2025 10:52:00 -0700 Subject: [PATCH] [lldb] Introduce ScriptedFrame affordance This patch i

[Lldb-commits] [lldb] [lldb][DataFormatter] Allow std::string formatters to match against custom allocators (PR #156050)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/156050 >From 35999d8d509864795dd36565d12ddea425a98c22 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 29 Aug 2025 16:57:35 +0100 Subject: [PATCH 1/6] [lldb][DataFormatter] Allow std::string formatters to mat

[Lldb-commits] [lldb] [LLDB][AArch64] Make TPIDR a generic tp register (PR #154444)

2025-09-04 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: Thanks @DavidSpickett! https://github.com/llvm/llvm-project/pull/15 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][AArch64] Make TPIDR a generic tp register (PR #154444)

2025-09-04 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/15 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6505bc3 - [LLDB][AArch64] Make TPIDR a generic tp register (#154444)

2025-09-04 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-09-04T10:37:52-07:00 New Revision: 6505bc3db02913a44b630c60ed6068ed84100e60 URL: https://github.com/llvm/llvm-project/commit/6505bc3db02913a44b630c60ed6068ed84100e60 DIFF: https://github.com/llvm/llvm-project/commit/6505bc3db02913a44b630c60ed6068ed84100e60.diff

[Lldb-commits] [lldb] [LLDB][AArch64] Make TPIDR a generic tp register (PR #154444)

2025-09-04 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/15 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-04 Thread Michael Buch via lldb-commits
Michael137 wrote: I suspect this broke `UnsupportedLanguage.test` on the lldb-x86_64-win bot: https://lab.llvm.org/buildbot/#/builders/211/builds/1840 Though don't have a machine to confirm that. ``` TEST 'lldb-shell :: Process/UnsupportedLanguage.test' FAILED ***

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread via lldb-commits
cmtice wrote: > `lldb/test/Shell/Host/TestCustomShell.test` will still fail after this, but > this change is still necessary either way. It does fix the other two tests > and enables implementing `env -i` within lit's internal shell to fix > `lldb/test/Shell/Host/TestCustomShell.test`. > > I'

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: I've tested this locally on Darwin. I can confirm it fixes part of `TestCustomShell.test` and completely fixes the other two tests. https://github.com/llvm/llvm-project/pull/156931 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] bdb9283 - [LLDB][NativePDB] Find global variables in namespaces (#156736)

2025-09-04 Thread via lldb-commits
Author: nerix Date: 2025-09-04T19:30:34+02:00 New Revision: bdb9283eec633585a14f7b1640822448c17ed71a URL: https://github.com/llvm/llvm-project/commit/bdb9283eec633585a14f7b1640822448c17ed71a DIFF: https://github.com/llvm/llvm-project/commit/bdb9283eec633585a14f7b1640822448c17ed71a.diff LOG: [L

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame affordance (PR #149622)

2025-09-04 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/149622 >From a38ed4d99315224889c503d2ce31362be28b28eb Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Wed, 3 Sep 2025 18:32:22 -0700 Subject: [PATCH] [lldb] Introduce ScriptedFrame affordance This patch i

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread John Harrison via lldb-commits
@@ -327,6 +348,23 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, std::unique_lock lock(dap_sessions_mutex); dap_sessions.erase(&loop); std::notify_all_at_thread_exit(dap_sessions_condition, std::move(lock)); + + if (t

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread John Harrison via lldb-commits
@@ -327,6 +348,23 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, std::unique_lock lock(dap_sessions_mutex); dap_sessions.erase(&loop); std::notify_all_at_thread_exit(dap_sessions_condition, std::move(lock)); + + if (t

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread John Harrison via lldb-commits
@@ -509,6 +547,17 @@ int main(int argc, char *argv[]) { } if (!connection.empty()) { +int ttl = 0; ashgti wrote: nit: Could this be `ttl_ms` or maybe a `std::chrono::milliseconds` instead of an `int`? https://github.com/llvm/llvm-project/pull/156803

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread John Harrison via lldb-commits
@@ -327,6 +348,23 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, std::unique_lock lock(dap_sessions_mutex); dap_sessions.erase(&loop); std::notify_all_at_thread_exit(dap_sessions_condition, std::move(lock)); + + if (t

[Lldb-commits] [lldb] [LLDB][NativePDB] Find global variables in namespaces (PR #156736)

2025-09-04 Thread via lldb-commits
https://github.com/Nerixyz closed https://github.com/llvm/llvm-project/pull/156736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Roy Shi via lldb-commits
royitaqi wrote: @JDevlieghere Thanks for the good questions. I appreciate all of them. Below are my thoughts for discussion. > proliferation of new options > motivation Main motivation is memory pressure. Other ways to counter memory pressure is either to monitor from lldb-dap VS Code extensi

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/156774 The LLVM Style Guide says the following about error and warning messages [1]: > [T]o match error message styles commonly produced by other tools, > start the first sentence with a lowercase letter, and fini

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 approved this pull request. https://github.com/llvm/llvm-project/pull/156931 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 commented: `lldb/test/Shell/Host/TestCustomShell.test` will still fail after this, but this change is still necessary either way. It does fix the other two tests and enables implementing `env -i` within lit's internal shell to fix `lldb/test/Shell/Host/TestCus

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
@@ -6,7 +6,7 @@ # XFAIL: system-openbsd # RUN: %clang_host %S/Inputs/simple.c -g -o %t.out -# RUN: SHELL=bogus not %lldb %t.out -b -o 'process launch -X 1 --' 2>&1 | FileCheck %s --check-prefix ERROR +# RUN: env SHELL=bogus not %lldb %t.out -b -o 'process launch -X 1 --' 2>&1

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/156931 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Expression] Reject languages not supported by TypeSystems for expression evaluation (PR #156648)

2025-09-04 Thread via lldb-commits
jimingham wrote: The other scenario is accessing an extant C global variable (maybe even one you don't have debug info for) called "class" or "namespace". But more importantly, having this sort of secret out that is applied inconsistently will just make lldb more confusing. It's fine to say

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/156931 >From f1418f873ce40963ca09e39490c202da503535ce Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Thu, 4 Sep 2025 10:14:20 -0700 Subject: [PATCH 1/2] [LLDB] Fix tests that fail when using internal shell. These t

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame affordance (PR #149622)

2025-09-04 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/149622 >From df4c41ddc529dce9aac96a698199cb6ed4506000 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Thu, 4 Sep 2025 10:21:46 -0700 Subject: [PATCH] [lldb] Introduce ScriptedFrame affordance This patch i

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions cpp -- lldb/test/Shell/SymbolFile/DWARF/deterministic-b

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-04 Thread via lldb-commits
cmtice wrote: > @cmtice I suspect that this may have broken three tests: > > https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/14836/ > > Could you revert/investigate? Let me know if you need any data or help > reproducing. @adrian-prantl Could you please test https://github.c

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread via lldb-commits
cmtice wrote: I need someone with a darwin system to verify that this actually fixes the breakages from here: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/14836/ https://github.com/llvm/llvm-project/pull/156931 ___ lldb-commits ma

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cmtice) Changes These tests were failing on darwin, because the internal shell needs environment var definitions to start with 'env'. This PR (hopefully) fixes that problem. --- Full diff: https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread via lldb-commits
https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/156931 These tests were failing on darwin, because the internal shell needs environment var definitions to start with 'env'. This PR (hopefully) fixes that problem. >From f1418f873ce40963ca09e39490c202da503535ce Mon

[Lldb-commits] [lldb] 65f60fd - [lldb] Moving MCPTransport into its own file. (#156712)

2025-09-04 Thread via lldb-commits
Author: John Harrison Date: 2025-09-04T08:52:33-07:00 New Revision: 65f60fd4657a31f832ac48caf3d9e1b138d96653 URL: https://github.com/llvm/llvm-project/commit/65f60fd4657a31f832ac48caf3d9e1b138d96653 DIFF: https://github.com/llvm/llvm-project/commit/65f60fd4657a31f832ac48caf3d9e1b138d96653.diff

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-04 Thread via lldb-commits
cmtice wrote: > Ok, I will revert this and try to work out how to test/fix the issues on > windows (I wonder why it passed the windows CI premerge tests). Maybe not? The failing test has already been updated and marked as 'Unsupported' on windows? https://github.com/llvm/llvm-project/pull/15

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Can you talk a bit about what's motivating this change? I'm a little worried about the proliferation of new options and I'm especially wary about the ones that need to be specified on the command line instead of over the protocol. Every new option extends the matrix of thin

[Lldb-commits] [lldb] [LLDB][AArch64] Make TPIDR a generic tp register (PR #154444)

2025-09-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM Remove the `@` mention in the description before merging, so that they don't get spammed when this gets merged into forks. https://github.com/llvm/llvm-project/pull/15 ___ lldb-com

[Lldb-commits] [lldb] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Jannick Kremer via lldb-commits
https://github.com/DeinAlptraum dismissed https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread David Spickett via lldb-commits
DavidSpickett wrote: > from typing import List Is this something we install or something that's included with Python 3.8+? https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb][test] Fix unordered-map test (PR #156033)

2025-09-04 Thread Pavel Labath via lldb-commits
labath wrote: The script code is not an exact equivalent of the "frame var" expression. Notice how in the "frame var", you explicitly dereference the object, while in the script, you call GetChildAtIndex directly on the pointer value. The "frame var" expression would be more similar to `script

[Lldb-commits] [lldb] [lldb][elf-core][ARM] Add support for VFP registers (PR #155956)

2025-09-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: I wanted to say merge this into the existing `linux-arm.core` but I can't find any source for it. So I'm ok with this being its own thing, and if you do have time, extending it to set GPR and replacing the existing core file would be great. https://

[Lldb-commits] [lldb] [lldb][elf-core][ARM] Add support for VFP registers (PR #155956)

2025-09-04 Thread David Spickett via lldb-commits
@@ -152,6 +152,11 @@ constexpr RegsetDesc AARCH64_GCS_Desc[] = { {llvm::Triple::Linux, llvm::Triple::aarch64, llvm::ELF::NT_ARM_GCS}, }; +constexpr RegsetDesc ARM_VFP_Desc[] = { +{llvm::Triple::FreeBSD, llvm::Triple::UnknownArch, llvm::ELF::NT_ARM_VFP}, +{llvm::Tri

[Lldb-commits] [lldb] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: llvm.org having issues at the moment so I can't read the guidance but sure why not, if that's the format it wants. Wonder about multiple sentence messages though. https://github.com/llvm/llvm-project/pull/156774 __

[Lldb-commits] [lldb] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Jannick Kremer via lldb-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Destroy debugger when debug session terminates (PR #156231)

2025-09-04 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. cool https://github.com/llvm/llvm-project/pull/156231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 requested changes to this pull request. If you have bots for this, please address specific failures rather than grepping through the entire monorepo for these constructs. A bunch of the files you have hit here (like the ones related to CI) will never be run as

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request. https://github.com/llvm/llvm-project/pull/156803 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Walter Erquinigo via lldb-commits
@@ -327,6 +348,23 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, std::unique_lock lock(dap_sessions_mutex); dap_sessions.erase(&loop); std::notify_all_at_thread_exit(dap_sessions_condition, std::move(lock)); + + if (t

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-04 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @cmtice I suspect that this may have broken three tests: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/14836/ Could you revert/investigate? Let me know if you need any data or help reproducing. https://github.com/llvm/llvm-project/pull/156729 __

[Lldb-commits] [lldb] [lldb] Don't crash if no default unwind plan (PR #152481)

2025-09-04 Thread Nikita Popov via lldb-commits
nikic wrote: Ping :) https://github.com/llvm/llvm-project/pull/152481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Allow std::string formatters to match against custom allocators (PR #156050)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/156050 >From 35999d8d509864795dd36565d12ddea425a98c22 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 29 Aug 2025 16:57:35 +0100 Subject: [PATCH 1/5] [lldb][DataFormatter] Allow std::string formatters to mat

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-09-04 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/155705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Jannick Kremer via lldb-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Allow std::string formatters to match against custom allocators (PR #156050)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/156050 >From 35999d8d509864795dd36565d12ddea425a98c22 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 29 Aug 2025 16:57:35 +0100 Subject: [PATCH 1/7] [lldb][DataFormatter] Allow std::string formatters to mat

[Lldb-commits] [lldb] [lldb][Instrumentation] Set selected frame to outside sanitizer libraries (PR #133079)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/133079 >From 2314f9e584d736ce2093cc196c7c57c2087cde42 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 26 Mar 2025 12:54:36 + Subject: [PATCH 1/4] [lldb][Instrumentation] Set selected frame to outside san

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-09-04 Thread via lldb-commits
jimingham wrote: The latter. We have to send the event so that lldb will know that the expression stopped mid-way through. But process events have to be consumed to have any effect, so in sync mode EvaluateExpression should consume the event and then print the stop status. https://github.co

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-04 Thread Michael Buch via lldb-commits
Michael137 wrote: Latest commit narrows the heuristics so it specifically applies to `CallExpr`s generated for structured bindings. Here's what the AST looks like when stopped in `IgnoreImplicitCallSingleStep` for a structured binding: ``` (lldb) p E->dump()

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Friendly ping https://github.com/llvm/llvm-project/pull/155705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Great! May be we should do this for: > > * `Status::Status(std::string err_str)` > * `static Status FromErrorString(const char *str)` > * `static Status FromErrorStringWithFormat(const char *format, ...)` > * `template static Status FromErrorStringWithFormatv(const > char

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
@@ -418,7 +418,7 @@ other command as far as there is only one alias command match."); if ((pos != std::string::npos) && (pos > 0)) raw_command_string = raw_command_string.substr(pos); } else { - result.AppendError("Error parsing command string. No alias

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/156774 >From 7e2901ba9171555b07a44a008e84f6811a95a64d Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 3 Sep 2025 16:45:13 -0700 Subject: [PATCH] [lldb] Correct style of error messages The LLVM Style G

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Walter Erquinigo via lldb-commits
@@ -61,3 +61,10 @@ def pre_init_command: S<"pre-init-command">, def: Separate<["-"], "c">, Alias, HelpText<"Alias for --pre-init-command">; + +def time_to_live: S<"time-to-live">, + MetaVarName<"">, + HelpText<"When using --connection, the number of milliseconds t

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Jannick Kremer via lldb-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >