[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-08-28 Thread Anthony Eid via lldb-commits
https://github.com/Anthony-Eid updated https://github.com/llvm/llvm-project/pull/124232 >From 30658e994b18b7c0db114a297036421c8de2dea3 Mon Sep 17 00:00:00 2001 From: Anthony Date: Wed, 27 Aug 2025 13:04:26 -0400 Subject: [PATCH 01/12] Fix variable request from reusing variable_ids --- .../lld

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Greg Clayton via lldb-commits
@@ -488,22 +488,26 @@ class SymbolFile : public PluginInterface { return false; }; - /// Get number of loaded/parsed DWO files. This is emitted in "statistics - /// dump" + /// Retrieves statistics about DWO files associated with this symbol file. + /// This function

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Greg Clayton via lldb-commits
@@ -612,21 +616,20 @@ class SymbolFileCommon : public SymbolFile { const CompilerType &compiler_qual_type, Type::ResolveState compiler_type_resolve_state, uint32_t opaque_payload = 0) override { - lldb:

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Greg Clayton via lldb-commits
@@ -1716,7 +1716,7 @@ SymbolFileDWARF *SymbolFileDWARF::GetDIERefSymbolFile(const DIERef &die_ref) { return this; if (file_index) { - // We have a SymbolFileDWARFDebugMap, so let it find the right file +// We have a SymbolFileDWARFDebugMap, so let it find the r

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Greg Clayton via lldb-commits
@@ -612,21 +616,20 @@ class SymbolFileCommon : public SymbolFile { const CompilerType &compiler_qual_type, Type::ResolveState compiler_type_resolve_state, uint32_t opaque_payload = 0) override { - lldb:

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Greg Clayton via lldb-commits
@@ -1725,7 +1725,8 @@ SymbolFileDWARF *SymbolFileDWARF::GetDIERefSymbolFile(const DIERef &die_ref) { return GetDwpSymbolFile().get(); // DWP case // Handle the .dwo file case correctly -return DebugInfo().GetUnitAtIndex(*die_ref.file_index()) +return DebugIn

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/155023 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Greg Clayton via lldb-commits
@@ -597,7 +601,7 @@ class SymbolFileCommon : public SymbolFile { return m_debug_info_had_variable_errors; } void SetDebugInfoHadFrameVariableErrors() override { - m_debug_info_had_variable_errors = true; +m_debug_info_had_variable_errors = true;

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Greg Clayton via lldb-commits
@@ -90,7 +90,7 @@ #include #include -//#define ENABLE_DEBUG_PRINTF // COMMENT OUT THIS LINE PRIOR TO CHECKIN +// #define ENABLE_DEBUG_PRINTF // COMMENT OUT THIS LINE PRIOR TO CHECKIN clayborg wrote: Ditto (revert auto clang-format changes for stuff that isn

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. One more round of changes just removing any auto clang-format changes that are not part of this PR. When committing PRs to upstream, we want to make sure any noise that isn't related to the PR is not part of the PR itself like

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] NFC: rename clang/include/clang/AST/Type.h to TypeBase.h (PR #155049)

2025-08-28 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: > If they are including `Type.h` in files that only exist downstream that will > force them to deal with this both times around, unless I am missing something. No, they would only have had to do that if they had rebased in between this commit landing and the next one, but that

[Lldb-commits] [lldb] [llvm] Add AArch64 support to the premerge tests (PR #155274)

2025-08-28 Thread Tom Stellard via lldb-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/155274 >From 57697a66cfdddf2028c7260f1ce61ecacc550d00 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Mon, 25 Aug 2025 17:15:36 + Subject: [PATCH 01/54] Add AArch64 support to the premerge tests --- .github/wo

[Lldb-commits] [lldb] [llvm] Add AArch64 support to the premerge tests (PR #155274)

2025-08-28 Thread Tom Stellard via lldb-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/155274 >From 57697a66cfdddf2028c7260f1ce61ecacc550d00 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Mon, 25 Aug 2025 17:15:36 + Subject: [PATCH 01/53] Add AArch64 support to the premerge tests --- .github/wo

[Lldb-commits] [lldb] [lldb] Skip TestVariableAnnotationsDisassembler.py on non-x86 architectures (PR #155942)

2025-08-28 Thread Tom Stellard via lldb-commits
tstellar wrote: I've tested this on aarch64 and it fixes the failure. https://github.com/llvm/llvm-project/pull/155942 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/155939 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2a062d6 - [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (#155939)

2025-08-28 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-28T19:10:52-07:00 New Revision: 2a062d693693f92d80656cb2b334b7dc8e08121f URL: https://github.com/llvm/llvm-project/commit/2a062d693693f92d80656cb2b334b7dc8e08121f DIFF: https://github.com/llvm/llvm-project/commit/2a062d693693f92d80656cb2b334b7dc8e08121f.d

[Lldb-commits] [lldb] [lldb] Unwind through ARM Cortex-M exceptions automatically (PR #153922)

2025-08-28 Thread Jason Molenda via lldb-commits
@@ -150,3 +158,161 @@ addr_t ArchitectureArm::GetOpcodeLoadAddress(addr_t opcode_addr, } return opcode_addr & ~(1ull); } + +// The ARM M-Profile Armv7-M Architecture Reference Manual +// "Exception return behavior" describes how the processor +// saves registers to the sta

[Lldb-commits] [lldb] [lldb] Unwind through ARM Cortex-M exceptions automatically (PR #153922)

2025-08-28 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/153922 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Unwind through ARM Cortex-M exceptions automatically (PR #153922)

2025-08-28 Thread Jason Molenda via lldb-commits
@@ -150,3 +158,161 @@ addr_t ArchitectureArm::GetOpcodeLoadAddress(addr_t opcode_addr, } return opcode_addr & ~(1ull); } + +// The ARM M-Profile Armv7-M Architecture Reference Manual +// "Exception return behavior" describes how the processor +// saves registers to the sta

[Lldb-commits] [lldb] [lldb] Unwind through ARM Cortex-M exceptions automatically (PR #153922)

2025-08-28 Thread Jason Molenda via lldb-commits
@@ -129,6 +130,14 @@ class Architecture : public PluginInterface { RegisterContext ®_context) const { return false; } + + /// Return an UnwindPlan that allows architecture-defined rules for finding + /// saved registers, given a pa

[Lldb-commits] [lldb] [lldb][elf-core][ARM] Add support for VFP registers (PR #155956)

2025-08-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Igor Kudrin (igorkudrin) Changes This patch loads values of the VFP registers from the NT_ARM_VFP note. Note that a CORE/NT_FPREGSET note is typically present in core dump files and used to store the FPA registers. The FPA unit is rare and

[Lldb-commits] [lldb] [lldb][elf-core][ARM] Add support for VFP registers (PR #155956)

2025-08-28 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/155956 This patch loads values of the VFP registers from the NT_ARM_VFP note. Note that a CORE/NT_FPREGSET note is typically present in core dump files and used to store the FPA registers. The FPA unit is rare and

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] NFC: rename clang/include/clang/AST/Type.h to TypeBase.h (PR #155049)

2025-08-28 Thread Shafik Yaghmour via lldb-commits
shafik wrote: If they are including `Type.h` in files that only exist downstream that will force them to deal with this both times around, unless I am missing something. https://github.com/llvm/llvm-project/pull/155049 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Ziyi Wang via lldb-commits
https://github.com/zw3917 updated https://github.com/llvm/llvm-project/pull/155023 >From d978cb5b17b7a8450226825a8fd85f2054166059 Mon Sep 17 00:00:00 2001 From: Ziyi Wang Date: Fri, 22 Aug 2025 09:17:25 -0700 Subject: [PATCH 1/4] [lldb] Add count for errors of DWO files in statistics --- lldb

[Lldb-commits] [lldb] [llvm] Add AArch64 support to the premerge tests (PR #155274)

2025-08-28 Thread Tom Stellard via lldb-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/155274 >From 57697a66cfdddf2028c7260f1ce61ecacc550d00 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Mon, 25 Aug 2025 17:15:36 + Subject: [PATCH 01/52] Add AArch64 support to the premerge tests --- .github/wo

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155939 >From 87e6eee01196c924f4fda1093eb961f37bb6088c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 28 Aug 2025 15:50:29 -0700 Subject: [PATCH 1/4] [lldb] Add SBFunction::GetBaseName() & SBSymbol::G

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread via lldb-commits
@@ -0,0 +1,53 @@ +""" +Test SBFunction::GetBaseName() and SBSymbol::GetBaseName() APIs. +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class GetBaseNameTestCase(TestBase): +NO_DEBUG_

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread via lldb-commits
@@ -0,0 +1,53 @@ +""" +Test SBFunction::GetBaseName() and SBSymbol::GetBaseName() APIs. +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class GetBaseNameTestCase(TestBase): +NO_DEBUG_

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155939 >From 87e6eee01196c924f4fda1093eb961f37bb6088c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 28 Aug 2025 15:50:29 -0700 Subject: [PATCH 1/4] [lldb] Add SBFunction::GetBaseName() & SBSymbol::G

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread via lldb-commits
@@ -556,3 +556,21 @@ void Mangled::Encode(DataEncoder &file, ConstStringTable &strtab) const { break; } } + +ConstString Mangled::GetBaseName() const { + const auto &demangled_info = GetDemangledInfo(); + if (!demangled_info.has_value()) +return GetDisplayDemangl

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread via lldb-commits
@@ -556,3 +556,21 @@ void Mangled::Encode(DataEncoder &file, ConstStringTable &strtab) const { break; } } + +ConstString Mangled::GetBaseName() const { + const auto &demangled_info = GetDemangledInfo(); + if (!demangled_info.has_value()) +return GetDisplayDemangl

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread via lldb-commits
@@ -287,6 +287,18 @@ class Mangled { /// Retrieve \c DemangledNameInfo of the demangled name held by this object. const std::optional &GetDemangledInfo() const; + /// Compute the base name (without namespace/class qualifiers) from the + /// demangled name. + /// + ///

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Ziyi Wang via lldb-commits
https://github.com/zw3917 updated https://github.com/llvm/llvm-project/pull/155023 >From d978cb5b17b7a8450226825a8fd85f2054166059 Mon Sep 17 00:00:00 2001 From: Ziyi Wang Date: Fri, 22 Aug 2025 09:17:25 -0700 Subject: [PATCH 1/2] [lldb] Add count for errors of DWO files in statistics --- lldb

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155939 >From 87e6eee01196c924f4fda1093eb961f37bb6088c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 28 Aug 2025 15:50:29 -0700 Subject: [PATCH 1/3] [lldb] Add SBFunction::GetBaseName() & SBSymbol::G

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r origin/main...HEAD lldb/test/API/python_api/basename/TestGetBaseName.py `` :warni

[Lldb-commits] [lldb] [llvm] [lldb] Skip TestVariableAnnotationsDisassembler.py on unsupported architectures (PR #155938)

2025-08-28 Thread Abdullah Mohammad Amin via lldb-commits
UltimateForce21 wrote: > This has a lot of unrelated changes, can you remove them. sorry I will close this PR, can create a new one from a fresh branch so it just shows the necessary change. https://github.com/llvm/llvm-project/pull/155938 ___ lldb-c

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155939 >From 87e6eee01196c924f4fda1093eb961f37bb6088c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 28 Aug 2025 15:50:29 -0700 Subject: [PATCH 1/2] [lldb] Add SBFunction::GetBaseName() & SBSymbol::G

[Lldb-commits] [lldb] [llvm] [lldb] Skip TestVariableAnnotationsDisassembler.py on unsupported architectures (PR #155938)

2025-08-28 Thread Abdullah Mohammad Amin via lldb-commits
UltimateForce21 wrote: New PR created with just lldb tester change for TestVariableAnnotationsDisassembler: https://github.com/llvm/llvm-project/pull/155942 https://github.com/llvm/llvm-project/pull/155938 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155939 >From 87e6eee01196c924f4fda1093eb961f37bb6088c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 28 Aug 2025 15:50:29 -0700 Subject: [PATCH] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBa

[Lldb-commits] [lldb] [lldb] Skip TestVariableAnnotationsDisassembler.py on non-x86 architectures (PR #155942)

2025-08-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Abdullah Mohammad Amin (UltimateForce21) Changes The test lldb-api::TestVariableAnnotationsDisassembler.py was failing on the lldb-remote-linux-ubuntu and lldb-remote-linux-win builders due to assembler incompatibilities in d_original_exam

[Lldb-commits] [lldb] [lldb] Skip TestVariableAnnotationsDisassembler.py on non-x86 architectures (PR #155942)

2025-08-28 Thread Abdullah Mohammad Amin via lldb-commits
https://github.com/UltimateForce21 created https://github.com/llvm/llvm-project/pull/155942 The test lldb-api::TestVariableAnnotationsDisassembler.py was failing on the lldb-remote-linux-ubuntu and lldb-remote-linux-win builders due to assembler incompatibilities in d_original_example.s. These

[Lldb-commits] [lldb] [llvm] [lldb] Skip TestVariableAnnotationsDisassembler.py on unsupported architectures (PR #155938)

2025-08-28 Thread Abdullah Mohammad Amin via lldb-commits
https://github.com/UltimateForce21 closed https://github.com/llvm/llvm-project/pull/155938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Abdullah Mohammad Amin via lldb-commits
UltimateForce21 wrote: Here is the new pull request: https://github.com/llvm/llvm-project/pull/155938 https://github.com/llvm/llvm-project/pull/152887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [llvm] [lldb] Skip TestVariableAnnotationsDisassembler.py on unsupported architectures (PR #155938)

2025-08-28 Thread Tom Stellard via lldb-commits
https://github.com/tstellar requested changes to this pull request. This has a lot of unrelated changes, can you remove them. https://github.com/llvm/llvm-project/pull/155938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [lldb] [llvm] [lldb] Skip TestVariableAnnotationsDisassembler.py on unsupported architectures (PR #155938)

2025-08-28 Thread Abdullah Mohammad Amin via lldb-commits
https://github.com/UltimateForce21 edited https://github.com/llvm/llvm-project/pull/155938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes When you are trying for instance to set a breakpoint on a function by name, but the SBFunction or SBSymbol are returning demangled names with argument lists, that match can be tedious to do. Intern

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/155939 When you are trying for instance to set a breakpoint on a function by name, but the SBFunction or SBSymbol are returning demangled names with argument lists, that match can be tedious to do. Internally, t

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Abdullah Mohammad Amin via lldb-commits
UltimateForce21 wrote: > Yes, would you? Thank you. I can do that now. https://github.com/llvm/llvm-project/pull/152887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Vladimir Vereschaka via lldb-commits
vvereschaka wrote: > Do I have to create a new PR, to push this change in the tester? Yes, would you? Thank you. https://github.com/llvm/llvm-project/pull/152887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-08-28 Thread Anthony Eid via lldb-commits
@@ -41,9 +41,9 @@ static Scope CreateScope(const llvm::StringRef name, int64_t variablesReference, // if we add the arguments above the local scope as the locals scope will not // be expanded if we enter a function with arguments. It becomes more // annoying when the sco

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Abdullah Mohammad Amin via lldb-commits
UltimateForce21 wrote: > @UltimateForce21 , the `lldb-api::TestVariableAnnotationsDisassembler.py` > test gets failed on the lldb-remote-linux-ubuntu/win builders: > > * https://lab.llvm.org/buildbot/#/builders/195/builds/13890 > * https://lab.llvm.org/buildbot/#/builders/197/builds/8515 > > w

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Abdullah Mohammad Amin via lldb-commits
UltimateForce21 wrote: Do I have to create a new PR, to push this change in the tester? https://github.com/llvm/llvm-project/pull/152887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-08-28 Thread Anthony Eid via lldb-commits
https://github.com/Anthony-Eid deleted https://github.com/llvm/llvm-project/pull/124232 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-08-28 Thread Anthony Eid via lldb-commits
@@ -75,22 +75,31 @@ ScopesRequestHandler::Run(const ScopesArguments &args) const { frame.GetThread().GetProcess().SetSelectedThread(frame.GetThread()); frame.GetThread().SetSelectedFrame(frame.GetFrameID()); } - dap.variables.locals = frame.GetVariables(/*arguments=

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-08-28 Thread Anthony Eid via lldb-commits
Anthony-Eid wrote: @da-viper Thank you for your feedback! To address some of it > I am not too happy with the SwitchFrame and ReadyFrame as it implies that we > have a state within the stopped state. I think it would make sense to unify these functions and see if we can get rid of `SwitchFrame

[Lldb-commits] [lldb] [lldb] Delay creation of ConstStrings when parsing MachO symtab (PR #155931)

2025-08-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes This change is motivated by performance. Creating ConstStrings can be expensive and is a non-trivial amount of ObjectFileMachO::ParseSymtab. This patch reduces the number of ConstStrings created. LLDB rel

[Lldb-commits] [lldb] [lldb] Delay creation of ConstStrings when parsing MachO symtab (PR #155931)

2025-08-28 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/155931 This change is motivated by performance. Creating ConstStrings can be expensive and is a non-trivial amount of ObjectFileMachO::ParseSymtab. This patch reduces the number of ConstStrings created. LLDB relies

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-08-28 Thread Anthony Eid via lldb-commits
https://github.com/Anthony-Eid updated https://github.com/llvm/llvm-project/pull/124232 >From 30658e994b18b7c0db114a297036421c8de2dea3 Mon Sep 17 00:00:00 2001 From: Anthony Date: Wed, 27 Aug 2025 13:04:26 -0400 Subject: [PATCH 01/10] Fix variable request from reusing variable_ids --- .../lld

[Lldb-commits] [lldb] [lldb-dap] Adding exception handling for dap server disconnect and terminations in lldbdap_testcase.py (PR #155335)

2025-08-28 Thread Piyush Jaiswal via lldb-commits
https://github.com/piyushjaiswal98 edited https://github.com/llvm/llvm-project/pull/155335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-08-28 Thread Anthony Eid via lldb-commits
@@ -103,3 +119,55 @@ lldb::SBValue Variables::FindVariable(uint64_t variablesReference, } return variable; } + +std::optional +Variables::GetScopeKind(const int64_t variablesReference) { + auto iter = m_scope_kinds.find(variablesReference); + if (iter != m_scope_kinds.en

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Tom Stellard via lldb-commits
tstellar wrote: Were these changes AI generated? https://github.com/llvm/llvm-project/pull/152887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Vladimir Vereschaka via lldb-commits
vvereschaka wrote: @UltimateForce21 , the `lldb-api::TestVariableAnnotationsDisassembler.py` test gets failed on the lldb-remote-linux-ubuntu/win builders: * https://lab.llvm.org/buildbot/#/builders/195/builds/13890 * https://lab.llvm.org/buildbot/#/builders/197/builds/8515 would you take care

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/155714 >From 831a505e3e8368cf2ee5cae995b8920fbc8d2365 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 27 Aug 2025 15:58:04 -0700 Subject: [PATCH 1/8] [lldb] Adjust ProtocolServer connection defaults. This adjus

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-28 Thread Roy Shi via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/153536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 20b8664 - [vscode-lldb] Support lldb-dap environment in debug configuration (#153536)

2025-08-28 Thread via lldb-commits
Author: Roy Shi Date: 2025-08-28T14:21:28-07:00 New Revision: 20b86644e45a76c4fa33c4a05c05b0726607cf77 URL: https://github.com/llvm/llvm-project/commit/20b86644e45a76c4fa33c4a05c05b0726607cf77 DIFF: https://github.com/llvm/llvm-project/commit/20b86644e45a76c4fa33c4a05c05b0726607cf77.diff LOG:

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Ziyi Wang via lldb-commits
https://github.com/zw3917 updated https://github.com/llvm/llvm-project/pull/155023 >From d978cb5b17b7a8450226825a8fd85f2054166059 Mon Sep 17 00:00:00 2001 From: Ziyi Wang Date: Fri, 22 Aug 2025 09:17:25 -0700 Subject: [PATCH 1/2] [lldb] Add count for errors of DWO files in statistics --- lldb

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/155714 >From 831a505e3e8368cf2ee5cae995b8920fbc8d2365 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 27 Aug 2025 15:58:04 -0700 Subject: [PATCH 1/7] [lldb] Adjust ProtocolServer connection defaults. This adjus

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Abdullah Mohammad Amin via lldb-commits
UltimateForce21 wrote: Sorry, now that this PR is merged, how should I go about making the suggested changes? https://github.com/llvm/llvm-project/pull/152887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] [lldb-dap] Adding exception handling for dap server disconnect and terminations in lldbdap_testcase.py (PR #155335)

2025-08-28 Thread Piyush Jaiswal via lldb-commits
@@ -466,8 +466,15 @@ def attach( # if we throw an exception during the test case. def cleanup(): if disconnectAutomatically: -self.dap_server.request_disconnect(terminateDebuggee=True) -self.dap_server.terminate() +

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [lldb-dap] Adding exception handling for dap server disconnect and terminations in lldbdap_testcase.py (PR #155335)

2025-08-28 Thread Piyush Jaiswal via lldb-commits
https://github.com/piyushjaiswal98 updated https://github.com/llvm/llvm-project/pull/155335 >From 443c2b4c983399fce0ac6805abfa7ca2fffd1322 Mon Sep 17 00:00:00 2001 From: Piyush Jaiswal Date: Mon, 25 Aug 2025 17:31:45 -0700 Subject: [PATCH 1/5] Improving lldbdap server error diagnosability and a

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/155714 >From 831a505e3e8368cf2ee5cae995b8920fbc8d2365 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 27 Aug 2025 15:58:04 -0700 Subject: [PATCH 1/6] [lldb] Adjust ProtocolServer connection defaults. This adjus

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions cpp,h -- lldb/include/lldb/Host/HostInfoBase.h lldb/in

[Lldb-commits] [lldb] [lldb-dap] Adding exception handling for dap server disconnect and terminations in lldbdap_testcase.py (PR #155335)

2025-08-28 Thread Piyush Jaiswal via lldb-commits
https://github.com/piyushjaiswal98 updated https://github.com/llvm/llvm-project/pull/155335 >From 443c2b4c983399fce0ac6805abfa7ca2fffd1322 Mon Sep 17 00:00:00 2001 From: Piyush Jaiswal Date: Mon, 25 Aug 2025 17:31:45 -0700 Subject: [PATCH 1/4] Improving lldbdap server error diagnosability and a

[Lldb-commits] [lldb] [lldb-dap] Adding exception handling for dap server disconnect and terminations in lldbdap_testcase.py (PR #155335)

2025-08-28 Thread Piyush Jaiswal via lldb-commits
https://github.com/piyushjaiswal98 updated https://github.com/llvm/llvm-project/pull/155335 >From 443c2b4c983399fce0ac6805abfa7ca2fffd1322 Mon Sep 17 00:00:00 2001 From: Piyush Jaiswal Date: Mon, 25 Aug 2025 17:31:45 -0700 Subject: [PATCH 1/4] Improving lldbdap server error diagnosability and a

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -161,6 +165,27 @@ FileSpec HostInfoBase::GetSystemPluginDir() { return g_fields->m_lldb_system_plugin_dir; } +FileSpec HostInfoBase::GetUserHomeDir() { + llvm::call_once(g_fields->m_lldb_user_home_dir_once, []() { +if (!HostInfo::ComputeUserHomeDirectory(g_fields->m_

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -161,6 +165,27 @@ FileSpec HostInfoBase::GetSystemPluginDir() { return g_fields->m_lldb_system_plugin_dir; } +FileSpec HostInfoBase::GetUserHomeDir() { + llvm::call_once(g_fields->m_lldb_user_home_dir_once, []() { +if (!HostInfo::ComputeUserHomeDirectory(g_fields->m_

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/155714 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -1993,23 +1994,23 @@ bool CommandInterpreter::HandleCommand(const char *command_line, // Those will be collected by the on-exit-callback. }); - helper.DispatchOnExit([&cmd_obj, &parsed_command_args, &result, - detailed_command_telemetry, comm

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/155714 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-08-28 Thread Ebuka Ezike via lldb-commits
@@ -103,3 +119,55 @@ lldb::SBValue Variables::FindVariable(uint64_t variablesReference, } return variable; } + +std::optional +Variables::GetScopeKind(const int64_t variablesReference) { + auto iter = m_scope_kinds.find(variablesReference); + if (iter != m_scope_kinds.en

[Lldb-commits] [lldb] [lldb] Add a simplified syntax for underlying command options (NFC) (PR #155694)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155694 >From 2a337e37d28a1ce2d02d8605b148213125e0fa01 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 27 Aug 2025 13:49:07 -0700 Subject: [PATCH 1/2] [lldb] Add a simplified syntax for underlying comma

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. One quick change suggested to re-use the new DWOStats struct instead of creating 3 local variables. https://github.com/llvm/llvm-project/pull/155023 ___ lldb-commits mailing list lld

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Greg Clayton via lldb-commits
@@ -155,6 +155,7 @@ struct ModuleStats { bool debug_info_had_incomplete_types = false; uint32_t dwo_file_count = 0; uint32_t loaded_dwo_file_count = 0; + uint32_t dwo_error_count = 0; clayborg wrote: We can change these three lines to: ``` DWOStats dwo_

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-08-28 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/155023 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/155714 >From 831a505e3e8368cf2ee5cae995b8920fbc8d2365 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 27 Aug 2025 15:58:04 -0700 Subject: [PATCH 1/3] [lldb] Adjust ProtocolServer connection defaults. This adjus

[Lldb-commits] [lldb] [lldb] add software watchpoints support (PR #151195)

2025-08-28 Thread via lldb-commits
jimingham wrote: There's `thread plan list` if you want to inspect the current thread plan stack. Pass -i if you want to see the full stack. https://github.com/llvm/llvm-project/pull/151195 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (try 2) (PR #153585)

2025-08-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: There is also `lldb/test/API/functionalities/json/symbol-file/TestSymbolFileJSON.py` which is almost what we want. I got this to work: ``` { "triple": "aarch64--linux", "uuid": "A2180C69-2DC0-DE61-3689-5CDC84D0AB63-A898EE40", "sections": [ {

[Lldb-commits] [lldb] [lldb] Add lldb-mcp scaffolding (PR #155708)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thank you! https://github.com/llvm/llvm-project/pull/155708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread John Harrison via lldb-commits
@@ -104,6 +104,43 @@ llvm::Error ProtocolServerMCP::Start(ProtocolServer::Connection connection) { if (llvm::Error error = handles.takeError()) return error; + auto listening_uris = m_listener->GetListeningConnectionURI(); + if (listening_uris.empty()) +return cre

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread John Harrison via lldb-commits
@@ -104,6 +104,43 @@ llvm::Error ProtocolServerMCP::Start(ProtocolServer::Connection connection) { if (llvm::Error error = handles.takeError()) return error; + auto listening_uris = m_listener->GetListeningConnectionURI(); + if (listening_uris.empty()) +return cre

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread John Harrison via lldb-commits
@@ -14,11 +14,23 @@ #include "lldb/Protocol/MCP/Resource.h" #include "lldb/Protocol/MCP/Tool.h" #include "lldb/Protocol/MCP/Transport.h" +#include "lldb/lldb-types.h" #include "llvm/ADT/StringMap.h" #include "llvm/Support/Error.h" +#include "llvm/Support/JSON.h" namespace

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/155714 >From 831a505e3e8368cf2ee5cae995b8920fbc8d2365 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 27 Aug 2025 15:58:04 -0700 Subject: [PATCH 1/2] [lldb] Adjust ProtocolServer connection defaults. This adjus

  1   2   >