[Lldb-commits] [lldb] [LLDB][NativePDB] Resolve declaration for tag types (PR #152579)

2025-08-11 Thread Michael Buch via lldb-commits
@@ -12,9 +12,19 @@ RUN: lldb-test symbols %t.dir/ClassLayoutTest.cpp.exe | FileCheck --check-prefix RUN: lldb-test symbols %t.dir/ClassLayoutTest.cpp.exe | FileCheck --check-prefix=BASE %s RUN: lldb-test symbols %t.dir/ClassLayoutTest.cpp.exe | FileCheck --check-prefix=FRIEND

[Lldb-commits] [lldb] [LLDB][NativePDB] Resolve declaration for tag types (PR #152579)

2025-08-11 Thread Michael Buch via lldb-commits
@@ -2441,3 +2440,55 @@ SymbolFileNativePDB::GetContextForType(TypeIndex ti) { } return ctx; } + +void SymbolFileNativePDB::CacheUdtDeclarations() { + if (m_has_cached_udt_declatations) +return; + m_has_cached_udt_declatations = true; + + for (CVType cvt : m_index->ip

[Lldb-commits] [lldb] [LLDB][NativePDB] Resolve declaration for tag types (PR #152579)

2025-08-11 Thread Michael Buch via lldb-commits
@@ -2441,3 +2440,55 @@ SymbolFileNativePDB::GetContextForType(TypeIndex ti) { } return ctx; } + +void SymbolFileNativePDB::CacheUdtDeclarations() { + if (m_has_cached_udt_declatations) +return; + m_has_cached_udt_declatations = true; + + for (CVType cvt : m_index->ip

[Lldb-commits] [lldb] [LLDB][NativePDB] Resolve declaration for tag types (PR #152579)

2025-08-11 Thread Michael Buch via lldb-commits
@@ -2441,3 +2440,55 @@ SymbolFileNativePDB::GetContextForType(TypeIndex ti) { } return ctx; } + +void SymbolFileNativePDB::CacheUdtDeclarations() { + if (m_has_cached_udt_declatations) +return; + m_has_cached_udt_declatations = true; + + for (CVType cvt : m_index->ip

[Lldb-commits] [lldb] [LLDB][NativePDB] Resolve declaration for tag types (PR #152579)

2025-08-11 Thread Michael Buch via lldb-commits
@@ -2441,3 +2440,55 @@ SymbolFileNativePDB::GetContextForType(TypeIndex ti) { } return ctx; } + +void SymbolFileNativePDB::CacheUdtDeclarations() { + if (m_has_cached_udt_declatations) +return; + m_has_cached_udt_declatations = true; + + for (CVType cvt : m_index->ip

[Lldb-commits] [lldb] [LLDB][NativePDB] Find functions by basename (PR #152295)

2025-08-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7e2cc72 - [LLDB][NativePDB] Find functions by basename (#152295)

2025-08-11 Thread via lldb-commits
Author: nerix Date: 2025-08-11T20:51:37-05:00 New Revision: 7e2cc725dbe00a9c99b0d58df020ab970e53dd51 URL: https://github.com/llvm/llvm-project/commit/7e2cc725dbe00a9c99b0d58df020ab970e53dd51 DIFF: https://github.com/llvm/llvm-project/commit/7e2cc725dbe00a9c99b0d58df020ab970e53dd51.diff LOG: [L

[Lldb-commits] [lldb] [lldb] Use the Python limited API with SWIG 4.2 or later (PR #153119)

2025-08-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Use the Python limited API when building with SWIG 4.2 or later. --- Full diff: https://github.com/llvm/llvm-project/pull/153119.diff 1 Files Affected: - (modified) lldb/cmake/modules/LLDBConfig.c

[Lldb-commits] [lldb] [lldb] Use the Python limited API with SWIG 4.2 or later (PR #153119)

2025-08-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/153119 Use the Python limited API when building with SWIG 4.2 or later. >From e002f15ff6f14e1288e5da97bed0537d2a7802fa Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 11 Aug 2025 18:21:09 -0700 Subjec

[Lldb-commits] [lldb] [lldb] remove a superfluous assignment statement (PR #152669)

2025-08-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152669 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ee56cb9 - [lldb] remove a superfluous assignment statement (#152669)

2025-08-11 Thread via lldb-commits
Author: Matej Košík Date: 2025-08-11T20:48:34-05:00 New Revision: ee56cb9c10bddf438c630353245abafdb32e6e9f URL: https://github.com/llvm/llvm-project/commit/ee56cb9c10bddf438c630353245abafdb32e6e9f DIFF: https://github.com/llvm/llvm-project/commit/ee56cb9c10bddf438c630353245abafdb32e6e9f.diff L

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #152367)

2025-08-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. 🚢 https://github.com/llvm/llvm-project/pull/152367 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-11 Thread Abdullah Mohammad Amin via lldb-commits
@@ -376,6 +380,143 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add rich variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-11 Thread Abdullah Mohammad Amin via lldb-commits
https://github.com/UltimateForce21 edited https://github.com/llvm/llvm-project/pull/152887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-11 Thread Abdullah Mohammad Amin via lldb-commits
@@ -376,6 +380,143 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add rich variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and

[Lldb-commits] [lldb] [lldb] Support parsing the Wasm symbol table (PR #153093)

2025-08-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This PR adds support for parsing the WebAssembly symbol table. The symbol table is encoded in the "names" section and contains names and indexes into other sections. For now we only support parsing

[Lldb-commits] [lldb] [lldb] Support parsing the Wasm symbol table (PR #153093)

2025-08-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/153093 This PR adds support for parsing the WebAssembly symbol table. The symbol table is encoded in the "names" section and contains names and indexes into other sections. For now we only support parsing functio

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-11 Thread Adrian Prantl via lldb-commits
@@ -376,6 +380,143 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add rich variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-11 Thread Adrian Prantl via lldb-commits
@@ -445,10 +444,11 @@ class Disassembler : public std::enable_shared_from_this, const ExecutionContext &exe_ctx, const Address &start, Limit limit, bool mixed_source_and_assembly, uint32_t num_mixed

[Lldb-commits] [lldb] [lldb][NFC] Fix `help breakpoint set` typo. (PR #152981)

2025-08-11 Thread via lldb-commits
jimingham wrote: This was actually put there on purpose, its supposed to help you remember the letter we chose for the one-character version of the option when we couldn't pick the first letter. This seems to confuse people more than helps, however. If we decide to remove these, however, we

[Lldb-commits] [lldb] [LLDB][NativePDB] Find functions by basename (PR #152295)

2025-08-11 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu approved this pull request. https://github.com/llvm/llvm-project/pull/152295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NativePDB] Find functions by basename (PR #152295)

2025-08-11 Thread Zequan Wu via lldb-commits
@@ -6,24 +6,52 @@ // RUN: lldb-test symbols --find=function --name=main --function-flags=full %t.exe \ // RUN: | FileCheck %s --check-prefix=FIND-MAIN +// RUN: lldb-test symbols --find=function --name=main --function-flags=method %t.exe \ +// RUN: | FileCheck %s --ch

[Lldb-commits] [libcxx] [lldb] [libcxx] adds size-based `__split_buffer` representation to unstable ABI (PR #139632)

2025-08-11 Thread Christopher Di Bella via lldb-commits
@@ -78,23 +80,232 @@ public: __split_buffer, void>; - pointer __first_; - pointer __begin_; - pointer __end_; - _LIBCPP_COMPRESSED_PAIR(pointer, __cap_, allocator_type, __alloc_); + struct __data { +pointer __first_ = nullpt

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-11 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: I believe @adrian-prantl merged this by mistake. Feel free to continue the discussion here and I'll address the points in a follow up, or just revert and repost. https://github.com/llvm/llvm-project/pull/152020 ___ lldb-commits m

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-11 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/152020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][framework] Remove original framework fixup script (PR #153052)

2025-08-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/153052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[NFC][lldb] Speed up lookup of shared modules" (229d860) (PR #152607)

2025-08-11 Thread Augusto Noronha via lldb-commits
augusto2112 wrote: ping @JDevlieghere @felipepiovezan :) https://github.com/llvm/llvm-project/pull/152607 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f12e038 - [lldb] Guard SBFrame/SBThread methods against running processes (#152020)

2025-08-11 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-08-11T10:26:57-07:00 New Revision: f12e0380be3bd6084ae860090dc027e0281e388e URL: https://github.com/llvm/llvm-project/commit/f12e0380be3bd6084ae860090dc027e0281e388e DIFF: https://github.com/llvm/llvm-project/commit/f12e0380be3bd6084ae860090dc027e02

[Lldb-commits] [lldb] [NFC][lldb] Cleanup the ArchDefinitionEntry definitons. (PR #152618)

2025-08-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. I think this makes sense. Out of curiosity, what does clang-format do to the formatting? https://github.com/llvm/llvm-project/pull/152618 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] [lldb][framework] Remove original framework fixup script (PR #153052)

2025-08-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes The original version of the framework fixup script is no longer being used and should be able to be removed. --- Full diff: https://github.com/llvm/llvm-project/pull/153052.diff 1 Files Affected:

[Lldb-commits] [lldb] [lldb][framework] Remove original framework fixup script (PR #153052)

2025-08-11 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/153052 The original version of the framework fixup script is no longer being used and should be able to be removed. >From 8324a738ff47cc7dbe30e6cd4c03c193c60a Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova

[Lldb-commits] [lldb] [LLDB] Add `ScalarLiteralNode` and literal parsing in DIL (PR #152308)

2025-08-11 Thread via lldb-commits
@@ -178,6 +179,40 @@ class BitFieldExtractionNode : public ASTNode { int64_t m_last_index; }; +class ScalarLiteralNode : public ASTNode { +public: + ScalarLiteralNode(uint32_t location, Scalar value, uint32_t radix, +bool is_unsigned, bool is_long, bool

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (PR #152798)

2025-08-11 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/152798 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 18ef8d7 - [lldb] Call FixUpPointer in WritePointerToMemory (#152798)

2025-08-11 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-08-11T09:39:12-07:00 New Revision: 18ef8d7fae9573913cb299ce0c82afa2f5279846 URL: https://github.com/llvm/llvm-project/commit/18ef8d7fae9573913cb299ce0c82afa2f5279846 DIFF: https://github.com/llvm/llvm-project/commit/18ef8d7fae9573913cb299ce0c82afa2f

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (PR #152798)

2025-08-11 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -640,6 +640,9 @@ void IRMemoryMap::WritePointerToMemory(lldb::addr_t process_address, lldb::addr_t address, Status &error) { error.Clear(); + if (auto process_sp = GetProcessWP().lock()) +address = process_sp->FixAnyAddress(add

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #152367)

2025-08-11 Thread John Harrison via lldb-commits
@@ -83,24 +86,68 @@ class JSONTransport { return WriteImpl(message); } - /// Reads the next message from the input stream. + /// Registers the transport with the MainLoop. template - llvm::Expected Read(const std::chrono::microseconds &timeout) { -llvm::Expect

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #152367)

2025-08-11 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/152367 >From 02417f51a23fbfd4d941b6f9b18e82fe8eb87566 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 5 Aug 2025 11:23:31 -0700 Subject: [PATCH 1/3] [lldb] Update JSONTransport to use MainLoop for reading. Reap

[Lldb-commits] [lldb] [LLDB] Add `ScalarLiteralNode` and literal parsing in DIL (PR #152308)

2025-08-11 Thread Pavel Labath via lldb-commits
@@ -72,12 +74,39 @@ static std::optional IsWord(llvm::StringRef expr, static bool IsNumberBodyChar(char ch) { return IsDigit(ch) || IsLetter(ch); } -static std::optional IsNumber(llvm::StringRef expr, - llvm::StringRef &remainder

[Lldb-commits] [lldb] [LLDB] Add `ScalarLiteralNode` and literal parsing in DIL (PR #152308)

2025-08-11 Thread Pavel Labath via lldb-commits
@@ -403,11 +403,13 @@ ASTNodeUP DILParser::ParseIntegerLiteral() { auto radix = llvm::getAutoSenseRadix(spelling_ref); bool is_unsigned = false, is_long = false, is_longlong = false; + if (spelling_ref.consume_back_insensitive("u")) +is_unsigned = true; if (spellin

[Lldb-commits] [lldb] [LLDB] Add `ScalarLiteralNode` and literal parsing in DIL (PR #152308)

2025-08-11 Thread Pavel Labath via lldb-commits
@@ -178,6 +179,40 @@ class BitFieldExtractionNode : public ASTNode { int64_t m_last_index; }; +class ScalarLiteralNode : public ASTNode { +public: + ScalarLiteralNode(uint32_t location, Scalar value, uint32_t radix, +bool is_unsigned, bool is_long, bool

[Lldb-commits] [lldb] [LLDB] Add `ScalarLiteralNode` and literal parsing in DIL (PR #152308)

2025-08-11 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: > The node will also have boolean literals and nullptr later, they are all > stored in a Scalar, so I don't think we should do 4 nodes for this. Why not? If all you needed was a single Scalar field that is handled uniformly, then sure. However, here you hav

[Lldb-commits] [lldb] [LLDB] Add `ScalarLiteralNode` and literal parsing in DIL (PR #152308)

2025-08-11 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/152308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add "settings modified" command (PR #152338)

2025-08-11 Thread Pavel Labath via lldb-commits
labath wrote: I don't know about "discoverable", but I think it's more logical and fits it with the existing "noun verb" command naming scheme. You say you want to "show" "settings", and then you follow that with some modifiers/restrictions on that. Currently, the only restriction is via the s

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #152367)

2025-08-11 Thread Jonas Devlieghere via lldb-commits
@@ -83,24 +86,68 @@ class JSONTransport { return WriteImpl(message); } - /// Reads the next message from the input stream. + /// Registers the transport with the MainLoop. template - llvm::Expected Read(const std::chrono::microseconds &timeout) { -llvm::Expect

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-11 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > Maybe a Doxygen comment explaining why you get the API lock back but not the > stop lock would address your concerns? This is exactly how this started, actually. I felt like I should document why we get one lock back but not the other, and explain why such a method is

[Lldb-commits] [lldb] [lldb] Make StackID call Fix{Code, Data} pointers (PR #152796)

2025-08-11 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/152796 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9c8e716 - [lldb] Make StackID call Fix{Code, Data} pointers (#152796)

2025-08-11 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-08-11T08:27:25-07:00 New Revision: 9c8e71644227e2a30403dbfe075f96374ba9739c URL: https://github.com/llvm/llvm-project/commit/9c8e71644227e2a30403dbfe075f96374ba9739c DIFF: https://github.com/llvm/llvm-project/commit/9c8e71644227e2a30403dbfe075f96374

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-11 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > I was thinking a bit more about the `Destroy` method, which I was not too too > happy with, and thought about just changing it to be a "Resume" method. > Something like the below, what do you think? I see the appeal, but I think it's too specialized. IMHO, conceptually,

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (PR #152798)

2025-08-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/152798 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (PR #152798)

2025-08-11 Thread David Spickett via lldb-commits
@@ -640,6 +640,9 @@ void IRMemoryMap::WritePointerToMemory(lldb::addr_t process_address, lldb::addr_t address, Status &error) { error.Clear(); + if (auto process_sp = GetProcessWP().lock()) +address = process_sp->FixAnyAddress(add

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-11 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: I was thinking a bit more about the `Destroy` method, which I was not too too happy with, and thought about just changing it to be a "Resume" method. Something like the below, what do you think? ``` diff --git a/lldb/include/lldb/Target/ExecutionContext.h b/lldb/include/l

[Lldb-commits] [lldb] [lldb] Make StackID call Fix{Code, Data} pointers (PR #152796)

2025-08-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/152796 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make StackID call Fix{Code, Data} pointers (PR #152796)

2025-08-11 Thread David Spickett via lldb-commits
@@ -71,7 +72,7 @@ StackFrame::StackFrame(const ThreadSP &thread_sp, user_id_t frame_idx, // recursive functions properly aren't confused with one another on a history // stack. if (IsHistorical() && !m_cfa_is_valid) { -m_id.SetCFA(m_frame_index); +m_id.SetCFA(m_f

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid and make threadsafe (PR #145382)

2025-08-11 Thread Chad Smith via lldb-commits
cs01 wrote: @labath @JDevlieghere thanks again for all the feedback. I believe I have addressed your comments. https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] [lldb] Make StackID call Fix{Code, Data} pointers (PR #152796)

2025-08-11 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -71,7 +72,7 @@ StackFrame::StackFrame(const ThreadSP &thread_sp, user_id_t frame_idx, // recursive functions properly aren't confused with one another on a history // stack. if (IsHistorical() && !m_cfa_is_valid) { -m_id.SetCFA(m_frame_index); +m_id.SetCFA(m_f

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (PR #152798)

2025-08-11 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -640,6 +640,9 @@ void IRMemoryMap::WritePointerToMemory(lldb::addr_t process_address, lldb::addr_t address, Status &error) { error.Clear(); + if (auto process_sp = GetProcessWP().lock()) +address = process_sp->FixAnyAddress(add

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (PR #152798)

2025-08-11 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -640,6 +640,9 @@ void IRMemoryMap::WritePointerToMemory(lldb::addr_t process_address, lldb::addr_t address, Status &error) { error.Clear(); + if (auto process_sp = GetProcessWP().lock()) +address = process_sp->FixAnyAddress(add

[Lldb-commits] [lldb] [lldb] Make StackID call Fix{Code, Data} pointers (PR #152796)

2025-08-11 Thread David Spickett via lldb-commits
@@ -71,7 +72,7 @@ StackFrame::StackFrame(const ThreadSP &thread_sp, user_id_t frame_idx, // recursive functions properly aren't confused with one another on a history // stack. if (IsHistorical() && !m_cfa_is_valid) { -m_id.SetCFA(m_frame_index); +m_id.SetCFA(m_f

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (PR #152798)

2025-08-11 Thread David Spickett via lldb-commits
@@ -640,6 +640,9 @@ void IRMemoryMap::WritePointerToMemory(lldb::addr_t process_address, lldb::addr_t address, Status &error) { error.Clear(); + if (auto process_sp = GetProcessWP().lock()) +address = process_sp->FixAnyAddress(add

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (PR #152798)

2025-08-11 Thread David Spickett via lldb-commits
@@ -640,6 +640,9 @@ void IRMemoryMap::WritePointerToMemory(lldb::addr_t process_address, lldb::addr_t address, Status &error) { error.Clear(); + if (auto process_sp = GetProcessWP().lock()) +address = process_sp->FixAnyAddress(add

[Lldb-commits] [lldb] [lldb] Fix libstdc++ std::string formatter after #147835 (PR #152993)

2025-08-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/152993 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f23d2ee - [lldb] Fix libstdc++ std::string formatter after #147835 (#152993)

2025-08-11 Thread via lldb-commits
Author: David Spickett Date: 2025-08-11T12:01:32+01:00 New Revision: f23d2ee5d584960eb7b6f7a092fa863e8be06ee6 URL: https://github.com/llvm/llvm-project/commit/f23d2ee5d584960eb7b6f7a092fa863e8be06ee6 DIFF: https://github.com/llvm/llvm-project/commit/f23d2ee5d584960eb7b6f7a092fa863e8be06ee6.diff

[Lldb-commits] [lldb] [lldb] Fix libstdc++ std::string formatter after #147835 (PR #152993)

2025-08-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/152993 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix libstdc++ std::string formatter after #147835 (PR #152993)

2025-08-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: > AssertionError: '(null)' != 'Summary Unavailable' I guess that before we didn't have the full type of this nested struct member. Then clang made improvements so we did, and then knew to format it as a C string. https://github.com/llvm/llvm-project/pull/152993 __

[Lldb-commits] [lldb] [lldb] Fix libstdc++ std::string formatter after #147835 (PR #152993)

2025-08-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM thanks! Checking the error seems like the right thing to do regardless of what caused the issue https://github.com/llvm/llvm-project/pull/152993 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [lldb] Fix libstdc++ std::string formatter after #147835 (PR #152993)

2025-08-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes https://github.com/llvm/llvm-project/pull/147835 made changes that caused libstdc++ std::string tests to fail: ``` == FAIL: test_unav

[Lldb-commits] [lldb] [lldb] Fix libstdc++ std::string formatter after #147835 (PR #152993)

2025-08-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/152993 https://github.com/llvm/llvm-project/pull/147835 made changes that caused libstdc++ std::string tests to fail: ``` == FAIL: test_unavaila

[Lldb-commits] [lldb] [lldb][NFC] Fix `help breakpoint set` typo. (PR #152981)

2025-08-11 Thread via lldb-commits
https://github.com/b10902118 created https://github.com/llvm/llvm-project/pull/152981 None >From 27893ec5396e167b7db4b9f0fe39a005a98f7b40 Mon Sep 17 00:00:00 2001 From: b10902118 Date: Mon, 11 Aug 2025 17:07:31 +0800 Subject: [PATCH] [lldb][NFC] Fix `help breakpoint set` typo. --- lldb/sourc

[Lldb-commits] [lldb] [lldb][NFC] Fix `help breakpoint set` typo. (PR #152981)

2025-08-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/152981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 005401d - [lldb][NFC] Fix `help breakpoint set` typo. (#152981)

2025-08-11 Thread via lldb-commits
Author: b10902118 Date: 2025-08-11T10:28:57+01:00 New Revision: 005401d9e1c9098ace2df72ae1ec91d997d6e890 URL: https://github.com/llvm/llvm-project/commit/005401d9e1c9098ace2df72ae1ec91d997d6e890 DIFF: https://github.com/llvm/llvm-project/commit/005401d9e1c9098ace2df72ae1ec91d997d6e890.diff LOG

[Lldb-commits] [lldb] [lldb][NFC] Fix `help breakpoint set` typo. (PR #152981)

2025-08-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. tHanks :) https://github.com/llvm/llvm-project/pull/152981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Fix `help breakpoint set` typo. (PR #152981)

2025-08-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (b10902118) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/152981.diff 1 Files Affected: - (modified) lldb/source/Commands/Options.td (+1-1) ``diff diff --git a/lldb/source/Commands/Options.td b/lldb/so

[Lldb-commits] [lldb] [LLDB] Run API tests with PDB too (PR #149305)

2025-08-11 Thread David Spickett via lldb-commits
@@ -804,6 +804,13 @@ def setUpCommands(cls): ) return commands +def getDebugInfoSetupCommands(self): +if self.getDebugInfo() == "native-pdb": DavidSpickett wrote: > We could implement this, ideally with a reduced scope check-ll

[Lldb-commits] [lldb] [LLDB] Run API tests with PDB too (PR #149305)

2025-08-11 Thread David Spickett via lldb-commits
@@ -804,6 +804,13 @@ def setUpCommands(cls): ) return commands +def getDebugInfoSetupCommands(self): +if self.getDebugInfo() == "native-pdb": DavidSpickett wrote: That's if we want to go Pavels' way. I don't really mind. The d

[Lldb-commits] [lldb] [LLDB] Run API tests with PDB too (PR #149305)

2025-08-11 Thread David Spickett via lldb-commits
@@ -804,6 +804,13 @@ def setUpCommands(cls): ) return commands +def getDebugInfoSetupCommands(self): +if self.getDebugInfo() == "native-pdb": DavidSpickett wrote: As one half of Windows lldb bots, I can say that Linaro is not g