[Lldb-commits] [lldb] [LLDB] Complete a missing register format mapping in the gdb-remote p… (PR #152170)

2025-08-05 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/34835 Here is the relevant piece of th

[Lldb-commits] [lldb] [lldb] Workaround omission of PyBUF_READ in the stable API (PR #152214)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152214 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7b8dea2 - [lldb] Workaround omission of PyBUF_READ in the stable API (#152214)

2025-08-05 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-05T19:21:36-07:00 New Revision: 7b8dea265e72c3037b6b1e54d5ab51b7e14f328b URL: https://github.com/llvm/llvm-project/commit/7b8dea265e72c3037b6b1e54d5ab51b7e14f328b DIFF: https://github.com/llvm/llvm-project/commit/7b8dea265e72c3037b6b1e54d5ab51b7e14f328b.d

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-08-05 Thread via lldb-commits
b10902118 wrote: Thanks! That will be helpful to my arm stuff. I am looking forward to try that. https://github.com/llvm/llvm-project/pull/147198 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [lldb] [lldb][rpc] Add sysroot to lldb-rpc-gen test suite invocation (PR #151291)

2025-08-05 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/151291 >From f764bae8d7977c61abd9aa106cf55f3294af4cdc Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Jul 2025 00:56:06 -0700 Subject: [PATCH] [lldb][rpc] Add sysroot to lldb-rpc-gen test suite inv

[Lldb-commits] [lldb] [lldb][rpc] Add sysroot to lldb-rpc-gen test suite invocation (PR #151291)

2025-08-05 Thread Chelsea Cassanova via lldb-commits
@@ -119,6 +119,17 @@ def use_lldb_substitutions(config): lldb_init = _get_lldb_init_path(config) +sysroot_arg = "" +if platform.system() in ["Darwin"]: +try: +out = subprocess.check_output(["xcrun", "--show-sdk-path"]).strip()

[Lldb-commits] [lldb] [lldb] Workaround omission of PyBUF_READ in the stable API (PR #152214)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/152214 PyMemoryView_FromMemory is part of stable ABI but the flag constants such as PyBUF_READ are not. This was fixed in Python 3.11 [1] but work around the issue with older versions. [1] https://github.com/pyt

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152201 >From 90eaf547090690c6250fa36937c0f07b170eb8bb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 13:34:50 -0700 Subject: [PATCH 1/4] [lldb] Preserve original symbol of Mangled function names ---

[Lldb-commits] [lldb] [lldb] Support the Python stable C API in PythonString::AsUTF8 (PR #152212)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Part of https://github.com/llvm/llvm-project/issues/151617 https://github.com/llvm/llvm-project/pull/152212 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support the Python stable C API in PythonString::AsUTF8 (PR #152212)

2025-08-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This conditionally reimplements `PythonString::AsUTF8` using `PyUnicode_AsUTF8String` instead of `PyUnicode_AsUTF8AndSize`. The latter is slightly more efficient because it caches the result, which

[Lldb-commits] [lldb] [lldb] Support the Python stable C API in PythonString::AsUTF8 (PR #152212)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/152212 This conditionally reimplements `PythonString::AsUTF8` using `PyUnicode_AsUTF8String` instead of `PyUnicode_AsUTF8AndSize`. The latter is slightly more efficient because it caches the result, which also me

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152201 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152201 >From 90eaf547090690c6250fa36937c0f07b170eb8bb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 13:34:50 -0700 Subject: [PATCH 1/3] [lldb] Preserve original symbol of Mangled function names ---

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserCl

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152201 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152201 >From 90eaf547090690c6250fa36937c0f07b170eb8bb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 13:34:50 -0700 Subject: [PATCH 1/2] [lldb] Preserve original symbol of Mangled function names ---

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] dbaa82b - [lldb] Move the generic MCP code into Protocol/MCP (NFC) (#152188)

2025-08-05 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-05T14:10:31-07:00 New Revision: dbaa82b384a7c7a57a3d9a93c2c968af422e6aa9 URL: https://github.com/llvm/llvm-project/commit/dbaa82b384a7c7a57a3d9a93c2c968af422e6aa9 DIFF: https://github.com/llvm/llvm-project/commit/dbaa82b384a7c7a57a3d9a93c2c968af422e6aa9.d

[Lldb-commits] [lldb] [LLDB] added getName method in SBModule (PR #150331)

2025-08-05 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/150331 >From 140f4053e6601585a3e27b285f1c00204fca0728 Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Wed, 23 Jul 2025 15:17:29 -0700 Subject: [PATCH 01/10] [LLDB] added getName method in SBModule --- lldb/i

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152201 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/152201.diff 1 Files Affected: - (modified) lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp (+3-1) ``diff diff --git a/lldb/

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/152201 None >From 90eaf547090690c6250fa36937c0f07b170eb8bb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 13:34:50 -0700 Subject: [PATCH] [lldb] Preserve original symbol of Mangled function names -

[Lldb-commits] [lldb] [LLDB] added getName method in SBModule (PR #150331)

2025-08-05 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/150331 >From 140f4053e6601585a3e27b285f1c00204fca0728 Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Wed, 23 Jul 2025 15:17:29 -0700 Subject: [PATCH 1/9] [LLDB] added getName method in SBModule --- lldb/inc

[Lldb-commits] [lldb] [lldb] Fix auto advance PC in `EmulateInstructionARM64` if PC >= 4G (PR #151460)

2025-08-05 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/151460 >From e7ae06b1388e172a83fea0340f81d437b9da3c88 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Wed, 30 Jul 2025 23:28:59 -0700 Subject: [PATCH 1/6] [lldb] Fix auto advance PC in 'EmulateInstructionARM64' if

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/152020 >From 9be92f8ead1294cc1931fe68c13dbaa8c5945423 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Mon, 4 Aug 2025 08:32:20 -0700 Subject: [PATCH 1/3] [lldb] Guard SBFrame/SBThread methods aga

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/151827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][rpc] Fix build failures when building lldb-rpc-gen (PR #151603)

2025-08-05 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > Yes, as a user, if you want to point to a preexisting executable, you'd still > set it in LLDB_RPC_GEN_EXE, but that variable is empty if the user didn't set > anything, and then when the cmake functions either use the user supplied > value, or a locally compiled one, th

[Lldb-commits] [lldb] [vscode-lldb] Fix race condition when changing lldb-dap arguments (PR #151828)

2025-08-05 Thread via lldb-commits
royitaqi wrote: Updated. @walter-erquinigo kindly take a look when you have the time. I appreciate your review~! https://github.com/llvm/llvm-project/pull/151828 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
royitaqi wrote: @JDevlieghere / @walter-erquinigo: Added text to https://lldb.llvm.org/resources/lldbdap.html How about now? https://github.com/llvm/llvm-project/pull/151827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/151827 >From 14c3fc997de307c00199e22e23b2f665147964fc Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Sat, 2 Aug 2025 09:04:18 -0700 Subject: [PATCH 1/4] [lldb] [vscode-lldb] Add VS Code commands that can be leveraged b

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
@@ -1,4 +1,4 @@ -//===-- MCPError.h ===// +//===--===// JDevlieghere wrote: Yup, as of https://discourse.llvm.org/t/is-c-in-header-files-

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/152188 >From 6519cdaa2339e78ed7f7d5ef58b3978746646b75 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 5 Aug 2025 11:26:27 -0700 Subject: [PATCH 1/2] [lldb] Move the generic MCP code into Protocol/MCP (

[Lldb-commits] [lldb] [lldb] Avoid a crash after selecting an unknown platform (PR #151803)

2025-08-05 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/151803 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f8a4f61 - [lldb] Avoid a crash after selecting an unknown platform (#151803)

2025-08-05 Thread via lldb-commits
Author: Igor Kudrin Date: 2025-08-05T12:42:38-07:00 New Revision: f8a4f61101bbed236adfeca58e59cac4b95afe15 URL: https://github.com/llvm/llvm-project/commit/f8a4f61101bbed236adfeca58e59cac4b95afe15 DIFF: https://github.com/llvm/llvm-project/commit/f8a4f61101bbed236adfeca58e59cac4b95afe15.diff L

[Lldb-commits] [lldb] [LLDB][NativePDB] Use undecorated name for types if UniqueName isn't mangled (PR #152114)

2025-08-05 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu approved this pull request. https://github.com/llvm/llvm-project/pull/152114 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/152188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread John Harrison via lldb-commits
@@ -8,10 +8,12 @@ #include "lldb/Protocol/MCP/Protocol.h" #include "llvm/Support/Error.h" -#include "llvm/Support/FormatVariadic.h" #include -namespace lldb_private::mcp { +#ifndef LLDB_PROTOCOL_MCP_MCPERROR_H +#define LLDB_PROTOCOL_MCP_MCPERROR_H ashgti w

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread John Harrison via lldb-commits
@@ -1,4 +1,4 @@ -//===-- MCPError.h ===// +//===--===// ashgti wrote: Is this not required for the header anymore? If so, thats good to kn

[Lldb-commits] [lldb] [LLDB][NativePDB] Use undecorated name for types if UniqueName isn't mangled (PR #152114)

2025-08-05 Thread via lldb-commits
Nerixyz wrote: > Can you add a test for this if it's not hard to create one? Found a way to make the IR a bit smaller by compiling an rlib with a `main()`. https://github.com/llvm/llvm-project/pull/152114 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] [LLDB][NativePDB] Use undecorated name for types if UniqueName isn't mangled (PR #152114)

2025-08-05 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/152114 >From 9818fda9a4254196a18285b5a8d87fd4b25dedbf Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Tue, 5 Aug 2025 11:53:55 +0200 Subject: [PATCH 1/2] [LLDB][NativePDB] Use undecorated name for types if UniqueName isn

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
kusmour wrote: > BTW, how to add to https://lldb.llvm.org/resources/lldbdap.html? Is that > something that I do in this PR (which file?), or I don't have access and > maybe one of you guys will help with this? The page source is this: https://github.com/llvm/llvm-project/edit/main/lldb/docs/r

[Lldb-commits] [lldb] [vscode-lldb] Fix race condition when changing lldb-dap arguments (PR #151828)

2025-08-05 Thread via lldb-commits
@@ -39,8 +39,10 @@ export class LLDBDapServer implements vscode.Disposable { const process = child_process.spawn(dapPath, dapArgs, options); process.on("error", (error) => { reject(error); -this.serverProcess = undefined; -this.serverInfo = u

[Lldb-commits] [lldb] [vscode-lldb] Fix race condition when changing lldb-dap arguments (PR #151828)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/151828 >From b58e5d4fe42a499dc7b9d903f56d62fc993f67a2 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Sat, 2 Aug 2025 09:30:25 -0700 Subject: [PATCH 1/2] [vscode-lldb] Fix race condition when changing lldb-dap arguments

[Lldb-commits] [lldb] [LLDB] Complete a missing register format mapping in the gdb-remote p… (PR #152170)

2025-08-05 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: Thank you @kazutakahirata !!! You are a life saver https://github.com/llvm/llvm-project/pull/152170 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-08-05 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/147655 >From 431333fb171671a508999ef5e5e9677f0f3c6a1a Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 24 Jul 2025 14:05:55 -0700 Subject: [PATCH 1/4] [lldb][rpc] Add RPC client library tests Adds she

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/151827 >From 14c3fc997de307c00199e22e23b2f665147964fc Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Sat, 2 Aug 2025 09:04:18 -0700 Subject: [PATCH 1/3] [lldb] [vscode-lldb] Add VS Code commands that can be leveraged b

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/151827 >From 14c3fc997de307c00199e22e23b2f665147964fc Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Sat, 2 Aug 2025 09:04:18 -0700 Subject: [PATCH 1/3] [lldb] [vscode-lldb] Add VS Code commands that can be leveraged b

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
royitaqi wrote: BTW, how to add to https://lldb.llvm.org/resources/lldbdap.html?Is that something that I do in this PR (which file?), or I don't have access and maybe one of you guys will help with this? https://github.com/llvm/llvm-project/pull/151827

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This moves all the generic MCP code into the new ProtocolMCP library so it can be shared between the MCP implementation in LLDB (built on the private API) and lldb-mcp (built on the public API). Th

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/152188 This moves all the generic MCP code into the new ProtocolMCP library so it can be shared between the MCP implementation in LLDB (built on the private API) and lldb-mcp (built on the public API). This PR d

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -981,7 +1018,10 @@ SBError SBThread::UnwindInnermostExpression() { SBError sb_error; std::unique_lock lock; - ExecutionContext exe_ctx(m_opaque_sp.get(), lock); + Process::StopLocker stop_locker; + ExecutionContext exe_ctx(m_opaque_sp.get(), lock, stop_locker); + if

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -125,17 +125,21 @@ ExecutionContext::ExecutionContext(const ExecutionContextRef *exe_ctx_ref_ptr, } } -ExecutionContext::ExecutionContext(const ExecutionContextRef *exe_ctx_ref_ptr, - std::unique_lock &lock) +ExecutionContext::Execution

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -782,27 +809,26 @@ SBValueList SBFrame::GetVariables(const lldb::SBVariablesOptions &options) { SBValueList value_list; std::unique_lock lock; - ExecutionContext exe_ctx(m_opaque_sp.get(), lock); + Process::StopLocker stop_locker; felipepiovezan wrot

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -139,19 +140,19 @@ SBModule SBFrame::GetModule() const { SBModule sb_module; ModuleSP module_sp; std::unique_lock lock; - ExecutionContext exe_ctx(m_opaque_sp.get(), lock); + Process::StopLocker stop_locker; + ExecutionContext exe_ctx(m_opaque_sp.get(), lock, stop_l

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -125,17 +125,21 @@ ExecutionContext::ExecutionContext(const ExecutionContextRef *exe_ctx_ref_ptr, } } -ExecutionContext::ExecutionContext(const ExecutionContextRef *exe_ctx_ref_ptr, - std::unique_lock &lock) +ExecutionContext::Execution

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: I think I've addressed the vast majority of comments here. @jimingham I may have added "error messages" at a finer granularity than what you were expecting in the constructor. Were you thinking of limiting it to _only_ when we had a process and it was not stopped? If so,

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -204,9 +209,64 @@ bool ScriptedThread::LoadArtificialStackFrames() { SymbolContext sc; symbol_addr.CalculateSymbolContext(&sc); -StackFrameSP synth_frame_sp = std::make_shared( +return std::make_shared( this->shared_from_this(), idx, idx, cfa, cfa_i

[Lldb-commits] [lldb] [Minidump] Update Minidump file builder to continue when the Module's section cannot be found (PR #152009)

2025-08-05 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/152009 >From 91ad83c794eeaed56297aa43a6d36e8c7572e18e Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Mon, 4 Aug 2025 10:13:37 -0700 Subject: [PATCH 1/6] Update Minidump file builder to continue when the Modu

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/152020 >From 9be92f8ead1294cc1931fe68c13dbaa8c5945423 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Mon, 4 Aug 2025 08:32:20 -0700 Subject: [PATCH 1/2] [lldb] Guard SBFrame/SBThread methods aga

[Lldb-commits] [lldb] [Minidump] Update Minidump file builder to continue when the Module's section cannot be found (PR #152009)

2025-08-05 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/152009 >From 91ad83c794eeaed56297aa43a6d36e8c7572e18e Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Mon, 4 Aug 2025 10:13:37 -0700 Subject: [PATCH 1/6] Update Minidump file builder to continue when the Modu

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Complete a missing register format mapping in the gdb-remote p… (PR #152170)

2025-08-05 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @walter-erquinigo I've landed 40fbc76dc8e81ede437b581a652ce6e5850cbc7b to fix the build breakage from this PR. Thanks! https://github.com/llvm/llvm-project/pull/152170 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] 40fbc76 - [lldb] Fix the build

2025-08-05 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2025-08-05T11:09:56-07:00 New Revision: 40fbc76dc8e81ede437b581a652ce6e5850cbc7b URL: https://github.com/llvm/llvm-project/commit/40fbc76dc8e81ede437b581a652ce6e5850cbc7b DIFF: https://github.com/llvm/llvm-project/commit/40fbc76dc8e81ede437b581a652ce6e5850cbc7b.diff L

[Lldb-commits] [lldb] [LLDB][NativePDB] Use undecorated name for types if UniqueName isn't mangled (PR #152114)

2025-08-05 Thread Zequan Wu via lldb-commits
ZequanWu wrote: Can you add a test for this if it's not hard to create one? https://github.com/llvm/llvm-project/pull/152114 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move MCP protocol into its own library (NFC) (PR #152059)

2025-08-05 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/20115 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb] Use Python Bytes instead of Buffer for Binary I/O (NFC) (PR #152031)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 12da87b - [lldb] Use Python Bytes instead of Buffer for Binary I/O (NFC) (#152031)

2025-08-05 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-05T10:58:59-07:00 New Revision: 12da87bef12d9545775a5c375cfc22904ca4602d URL: https://github.com/llvm/llvm-project/commit/12da87bef12d9545775a5c375cfc22904ca4602d DIFF: https://github.com/llvm/llvm-project/commit/12da87bef12d9545775a5c375cfc22904ca4602d.d

[Lldb-commits] [lldb] [vscode-lldb] Fix `yarn package` (PR #152002)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/152002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4882874 - [vscode-lldb] Fix `yarn package` (#152002)

2025-08-05 Thread via lldb-commits
Author: royitaqi Date: 2025-08-05T10:54:07-07:00 New Revision: 4882874ddc1017f2f1b9b11fb67065440b101701 URL: https://github.com/llvm/llvm-project/commit/4882874ddc1017f2f1b9b11fb67065440b101701 DIFF: https://github.com/llvm/llvm-project/commit/4882874ddc1017f2f1b9b11fb67065440b101701.diff LOG:

[Lldb-commits] [lldb] [LLDB] Complete a missing register format mapping in the gdb-remote p… (PR #152170)

2025-08-05 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/152170 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9179b07 - [LLDB] Complete a missing register format mapping in the gdb-remote p… (#152170)

2025-08-05 Thread via lldb-commits
Author: Walter Erquinigo Date: 2025-08-05T13:53:15-04:00 New Revision: 9179b079812319010ab09718926ee73ca26ecc78 URL: https://github.com/llvm/llvm-project/commit/9179b079812319010ab09718926ee73ca26ecc78 DIFF: https://github.com/llvm/llvm-project/commit/9179b079812319010ab09718926ee73ca26ecc78.di

[Lldb-commits] [lldb] [LLDB] Complete a missing register format mapping in the gdb-remote p… (PR #152170)

2025-08-05 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: It seems that the CI linux tests is borked: > cp: cannot stat > '/home/gha/actions-runner/_work/llvm-project/llvm-project/build/test-results.*.xml': > No such file or directory I'll merge this for the time being https://github.com/llvm/llvm-project/pull/152170 ___

[Lldb-commits] [lldb] [lldb][rpc] Add sysroot to lldb-rpc-gen test suite invocation (PR #151291)

2025-08-05 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Actually, we have a couple tests that are testing the use of SB API pointers or refs as function parameters, so adding the sysroot will be necessary to resolve this. The other tests that do not use SB API classes can be modified however. https://github.com/llvm/llvm-projec

[Lldb-commits] [lldb] [LLDB] Complete a missing register format mapping in the gdb-remote p… (PR #152170)

2025-08-05 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. FYI: This could be upstreamed now https://github.com/llvm/llvm-project/pull/152170 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] [lldb][rpc] Add sysroot to lldb-rpc-gen test suite invocation (PR #151291)

2025-08-05 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > Was this always happening before? Yes, so we had to disable the tests downstream. Giving this patch another look though, I think this can be closed and we can run the tests for RPC without needing this extra infrastructure. There's 2 main reasons that we would need this

[Lldb-commits] [lldb] [lldb] Use Python Bytes instead of Buffer for Binary I/O (NFC) (PR #152031)

2025-08-05 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/152031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
royitaqi wrote: > It's probably not relevant to 99% of the users of the extension. Totally agree. > Given that we use the README in the Marketplace, maybe > https://lldb.llvm.org/resources/lldbdap.html would be a more appropriate > place for this? I think the cohort we are addressing are th

[Lldb-commits] [lldb] [lldb][CPlusPlusLanguage] Create public accessors for getting DemangledNameInfo components and use them in tests (PR #152134)

2025-08-05 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/152134 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 406f61f - [lldb][CPlusPlusLanguage] Create public accessors for getting DemangledNameInfo components and use them in tests (#152134)

2025-08-05 Thread via lldb-commits
Author: Michael Buch Date: 2025-08-05T18:12:22+01:00 New Revision: 406f61fd3a28b9628f50cf009c6e65562f93a2cc URL: https://github.com/llvm/llvm-project/commit/406f61fd3a28b9628f50cf009c6e65562f93a2cc DIFF: https://github.com/llvm/llvm-project/commit/406f61fd3a28b9628f50cf009c6e65562f93a2cc.diff

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > @walter-erquinigo > > > Please write a section in the lldb-dap documentation on how to integrate > > with other debugger extensions via these commands? > > That was a great suggestion. Added text to near the end of the `README.md`. > Please feel free to LMK if you have d

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-05 Thread Augusto Noronha via lldb-commits
augusto2112 wrote: > > By profiling LLDB debugging a Swift application without a dSYM and a large > > amount of .o files, I identified that querying shared modules was the > > biggest bottleneck when running "frame variable", and Clang types need to > > be searched. > > Could you elaborate wh

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
royitaqi wrote: @walter-erquinigo > Please write a section in the lldb-dap documentation on how to integrate with > other debugger extensions via these commands? That was a great suggestion. Added text to near the end of the `README.md`. Please feel free to LMK if you have different wording/f

[Lldb-commits] [lldb] [Minidump] Update Minidump file builder to continue when the Module's section cannot be found (PR #152009)

2025-08-05 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileB

[Lldb-commits] [lldb] [Minidump] Update Minidump file builder to continue when the Module's section cannot be found (PR #152009)

2025-08-05 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/152009 >From 91ad83c794eeaed56297aa43a6d36e8c7572e18e Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Mon, 4 Aug 2025 10:13:37 -0700 Subject: [PATCH 1/5] Update Minidump file builder to continue when the Modu

[Lldb-commits] [lldb] [lldb] Move MCP protocol into its own library (NFC) (PR #152059)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ed294c2 - [lldb] Move MCP protocol into its own library (NFC) (#152059)

2025-08-05 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-05T09:48:26-07:00 New Revision: ed294c28aca6f1371df3de42131f7b41e2be151b URL: https://github.com/llvm/llvm-project/commit/ed294c28aca6f1371df3de42131f7b41e2be151b DIFF: https://github.com/llvm/llvm-project/commit/ed294c28aca6f1371df3de42131f7b41e2be151b.d

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/151827 >From 14c3fc997de307c00199e22e23b2f665147964fc Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Sat, 2 Aug 2025 09:04:18 -0700 Subject: [PATCH 1/2] [lldb] [vscode-lldb] Add VS Code commands that can be leveraged b

[Lldb-commits] [lldb] [lldb][CPlusPlusLanguage] Create public accessors for getting DemangledNameInfo components and use them in tests (PR #152134)

2025-08-05 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/152134 >From d8d8e1dccecb941ff44cd820c0a8f6f238ec6726 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 5 Aug 2025 17:37:39 +0100 Subject: [PATCH] [lldb][CPlusPlusLanguage] Create public accessors for getting

[Lldb-commits] [lldb] [lldb] Implement DW_CFA_val_offset and DW_CFA_val_offset_sf (PR #150732)

2025-08-05 Thread Daniel Sanders via lldb-commits
https://github.com/dsandersllvm closed https://github.com/llvm/llvm-project/pull/150732 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c455c4e - [lldb] Implement DW_CFA_val_offset and DW_CFA_val_offset_sf (#150732)

2025-08-05 Thread via lldb-commits
Author: Daniel Sanders Date: 2025-08-05T09:33:14-07:00 New Revision: c455c4e2d7f78d5992369457066b249699fe2084 URL: https://github.com/llvm/llvm-project/commit/c455c4e2d7f78d5992369457066b249699fe2084 DIFF: https://github.com/llvm/llvm-project/commit/c455c4e2d7f78d5992369457066b249699fe2084.diff

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I'm also curious how these will be used. Are you working on an extension that will take advantage of this, or are the commands added in this PR purely speculative? It would be nice to at least include that because otherwise it'll be hard to figure out in the future if we ca

[Lldb-commits] [lldb] [LLDB] Complete a missing register format mapping in the gdb-remote p… (PR #152170)

2025-08-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes …rotocol When writing a custom gdb-remote server I realized that the encoder and decoder of register formats is incomplete. - Add the encoder on the server side and add an llvm_unreachable is th

[Lldb-commits] [lldb] [LLDB] Complete a missing register format mapping in the gdb-remote p… (PR #152170)

2025-08-05 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/152170 …rotocol When writing a custom gdb-remote server I realized that the encoder and decoder of register formats is incomplete. - Add the encoder on the server side and add an llvm_unreachable is there's

[Lldb-commits] [lldb] [vscode-lldb] Fix `yarn package` (PR #152002)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/152002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Fix `yarn package` (PR #152002)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Asking just for this first time: In this code base (vscode-lldb), do you > recommend me to go ahead and merge with your approval, or should I wait for > @JDevlieghere to take a look, too? Thanks for asking! The [Code Review Policy](https://llvm.org/docs/CodeReview.html#l

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/151827 >From 14c3fc997de307c00199e22e23b2f665147964fc Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Sat, 2 Aug 2025 09:04:18 -0700 Subject: [PATCH] [lldb] [vscode-lldb] Add VS Code commands that can be leveraged by ot

[Lldb-commits] [lldb] [llvm] [lldb] Fix object format in the Triple of Mach-O files (approach 2) (PR #143633)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/143633 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >