llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Igor Kudrin (igorkudrin)
Changes
`PlatformList::Create()` added an item in the list even if `Platform::Create()`
returned `nullptr`. Other methods use items of the list without checking, which
can lead to a crash. For example:
```
> lldb
https://github.com/igorkudrin created
https://github.com/llvm/llvm-project/pull/151803
`PlatformList::Create()` added an item in the list even if `Platform::Create()`
returned `nullptr`. Other methods use items of the list without checking, which
can lead to a crash. For example:
```
> lldb
(
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`sanitizer-x86_64-linux-fast` running on `sanitizer-buildbot4` while building
`clang-tools-extra,clang,lldb` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/169/builds/13549
Here
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross`
running on `suse-gary-m68k-cross` while building `clang-tools-extra,clang,lldb`
at step 5 "ninja check 1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/27/builds/13997
Here
https://github.com/jyknight closed
https://github.com/llvm/llvm-project/pull/151782
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -137,7 +137,16 @@ struct InitializePythonRAII {
config.install_signal_handlers = 0;
Py_InitializeFromConfig(&config);
PyConfig_Clear(&config);
-InitializeThreadsPrivate();
+
+// The only case we should go further and acquire the GIL: it is unlocked.
+
Author: Jonas Devlieghere
Date: 2025-08-01T16:18:24-07:00
New Revision: 4d1ae58d9e1d679cd0f35ce935579df221b14882
URL:
https://github.com/llvm/llvm-project/commit/4d1ae58d9e1d679cd0f35ce935579df221b14882
DIFF:
https://github.com/llvm/llvm-project/commit/4d1ae58d9e1d679cd0f35ce935579df221b14882.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/151777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
This is in preparation for eliminating the call to `PyGILState_Check` and
calling `PyGILState_Ensure` directly as part of
https://github.com/llvm/llvm-project/issues/151617.
https://github.com/llvm/llvm-project/pull/151780
___
ll
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The behavior of thread initialization changed in Python 3.7. The minimum
supported Python version is now 3.8. That means that
`PyEval_ThreadsInitialized` always returns true and `PyEval_InitThreads`
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/151780
The behavior of thread initialization changed in Python 3.7. The minimum
supported Python version is now 3.8. That means that
`PyEval_ThreadsInitialized` always returns true and `PyEval_InitThreads` is
ne
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/151777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149827
>From 9ec9eefb23b0676bcb89c195d96e5a2e1d6c615f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 1 Aug 2025 11:04:47 +0100
Subject: [PATCH] Structors init
---
clang/include/clang/Basic/Attr.td
chelcassanova wrote:
> Your initial attempts seem quite close to actually getting this right
> (already attempting to use get_host_tool_path etc), but both the initial
> attempt and this one missed one subtle detail: The cmake functions
> get_host_tool_path and setup_host_tool do take a cmake
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/151767
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/151767
The method ConvertRegisterKindToRegisterNumber should return INVALID_REGNUM,
and not "false" upon failure: false would mean 0 which is usually the number
for generic PC.
Likewise, NumSupportedHardwareB
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/147655
>From ebde09ab545148230e7284cf8a934ae9e9a8fc3b Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 24 Jul 2025 14:05:55 -0700
Subject: [PATCH 1/4] [lldb][rpc] Add RPC client library tests
Adds she
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/151761
>From cb8d0d2f28a736c6c4808e73f1f60103ee535478 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 1 Aug 2025 12:48:47 -0700
Subject: [PATCH] [lldb] Reimplment PyRun_String using the Python stable C
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/151761
>From 80affa33bba14616f21da6bdad6fc6fb8b7048ed Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 1 Aug 2025 12:48:47 -0700
Subject: [PATCH] [lldb] Reimplment PyRun_String using the Python stable C
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Reimplement `PyRun_String` using `Py_CompileString` and` PyEval_EvalCode`,
which are part of the stable C API.
Part of #151617
---
Full diff: https://github.com/llvm/llvm-project/pull/151761.diff
https://github.com/igorkudrin closed
https://github.com/llvm/llvm-project/pull/151635
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Igor Kudrin
Date: 2025-08-01T12:51:59-07:00
New Revision: 55c2b273ea5d3b949c6431d429a4da20612d9808
URL:
https://github.com/llvm/llvm-project/commit/55c2b273ea5d3b949c6431d429a4da20612d9808
DIFF:
https://github.com/llvm/llvm-project/commit/55c2b273ea5d3b949c6431d429a4da20612d9808.diff
L
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/151761
Reimplement `PyRun_String` using `Py_CompileString` and` PyEval_EvalCode`,
which are part of the stable C API.
Part of #151617
>From 8fe60ddc943421af3039d136cd2e3ac38c8347f4 Mon Sep 17 00:00:00 2001
From:
igorkudrin wrote:
Thanks!
> There will be a few registers in each frame to cover the last 1 integer.
I counted `my_ints` itself for this last 1 integer. Yes, there are some
registers stored in the past frames, but there is no point in guessing how many.
https://github.com/llvm/llvm-project/pu
kuilpd wrote:
@labath
What are your thoughts?
https://github.com/llvm/llvm-project/pull/151350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/151490
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
It's also kind of weird that we have `SymbolFilePDB` and `SymbolFileNativePDB`
with one initializing the other. It seems like we should have a pure virtual
SymbolFilePDB and then a `SymbolFileNativePDB` and a `SymbolFileDIAPDB`.
Anyway, I'd still like to get rid of the DIA
JDevlieghere wrote:
> Is this the current behavior? In my understanding, both plugins are mostly
> independent. The DIA PDB parser only brings in the native PDB parser to
> initialize it. It doesn't instantiate it to resolve a type.
It's possible I'm misremembering this. In the PR that removes
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/146884
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/146884
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -62,8 +63,12 @@ export class DebugSessionTracker
createDebugAdapterTracker(
session: vscode.DebugSession,
): vscode.ProviderResult {
+this.logger.info(`Starting debug session "${session.name}"`);
+let stopping = false;
return {
+ onError: (error) =>
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/151668
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@barsolo2000 Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a bu
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/149903
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: barsolo2000
Date: 2025-08-01T09:36:48-07:00
New Revision: 3d098f78bfa82bfae5242402d4b8201b1ec38d06
URL:
https://github.com/llvm/llvm-project/commit/3d098f78bfa82bfae5242402d4b8201b1ec38d06
DIFF:
https://github.com/llvm/llvm-project/commit/3d098f78bfa82bfae5242402d4b8201b1ec38d06.diff
L
https://github.com/erichkeane approved this pull request.
I think I'm good with this. No real other comments here.
https://github.com/llvm/llvm-project/pull/150823
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -160,7 +160,7 @@ class alignas(8) InitializedEntity {
struct VD {
/// The VarDecl, FieldDecl, or BindingDecl being initialized.
-ValueDecl *VariableOrMember;
+NamedDecl *VariableOrMember;
cor3ntin wrote:
It was (after your feedback)!
https:/
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149827
>From 499aa52ad1e2ffbbccf63b4a037597f94adad97f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 1 Aug 2025 11:04:47 +0100
Subject: [PATCH] Structors init
---
clang/include/clang/Basic/Attr.td
https://github.com/ashgti approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/146884
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/151618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-08-01T07:57:34-07:00
New Revision: 5f2a8cd9a685935726421fd28a42b61c303aef27
URL:
https://github.com/llvm/llvm-project/commit/5f2a8cd9a685935726421fd28a42b61c303aef27
DIFF:
https://github.com/llvm/llvm-project/commit/5f2a8cd9a685935726421fd28a42b61c303aef27.d
@@ -69,17 +69,19 @@ def test_subscript(self):
substrs=["expected 'r_square', got: <'.'"],
)
-# Base should be a "pointer to T" and index should be of an integral
type.
-self.expect(
-"frame var 'idx_1[0]'",
-error=Tr
@@ -323,47 +323,144 @@ Interpreter::Visit(const MemberOfNode *node) {
m_expr, errMsg, node->GetLocation(), node->GetFieldName().size());
}
+
llvm::Expected
Interpreter::Visit(const ArraySubscriptNode *node) {
auto lhs_or_err = Evaluate(node->GetBase());
if (!lhs_
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/151629
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kazu Hirata
Date: 2025-08-01T07:02:06-07:00
New Revision: 33625f7cb395a3664b81f1327868828d2e51fa46
URL:
https://github.com/llvm/llvm-project/commit/33625f7cb395a3664b81f1327868828d2e51fa46
DIFF:
https://github.com/llvm/llvm-project/commit/33625f7cb395a3664b81f1327868828d2e51fa46.diff
L
@@ -110,6 +110,11 @@
"additionalProperties": {
"type": "string"
}
+ },
+ "lldb-dap.captureSessionLogs": {
award999 wrote:
@ashgti latest patch introduces a new `logFolder` setting
https://github.com/llvm
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/149774
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: woruyu
Date: 2025-08-01T13:43:13+01:00
New Revision: 0b9470b329103bcdfe3578d99664974d2a53bf8d
URL:
https://github.com/llvm/llvm-project/commit/0b9470b329103bcdfe3578d99664974d2a53bf8d
DIFF:
https://github.com/llvm/llvm-project/commit/0b9470b329103bcdfe3578d99664974d2a53bf8d.diff
LOG: [
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h --
lldb/include/lldb/Utility/ArchSpec.h
lldb/source/P
mstorsjo wrote:
Now I've had time to study lldb-rpc-gen a little bit closer...
For myself and others, to clarify what lldb-rpc-gen does (as how command
options flow into it that aren't immediately obvious): It is a tool that
includes clang tooling libraries. It runs at the regular LLVM/LLDB bu
@@ -0,0 +1,15 @@
+RUN: mkdir -p %t/server
+RUN: mkdir -p %t/lib
+RUN: %lldb-rpc-gen --output-dir=%t %S/../../Inputs/CheckSBPointer.h
+
+RUN: cat %t/lib/CheckSBPointer.cpp | FileCheck %s
+
+# Pointers to SB objects must be checked to
+# see if they're null. If so, then a new object
@@ -0,0 +1,124 @@
+#include "RPCLibraryHeaderEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/AST/Mangle.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/ToolOutputFile.h"
+#include "llvm/S
https://github.com/DavidSpickett commented:
Please go over the outstanding comments and make sure they have been done. I
see several that have not.
https://github.com/llvm/llvm-project/pull/147655
___
lldb-commits mailing list
lldb-commits@lists.llvm.
@@ -0,0 +1,124 @@
+#include "RPCLibraryHeaderEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/AST/Mangle.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/ToolOutputFile.h"
+#include "llvm/S
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/147655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows`
running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6
"test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/141/builds/10514
Here is the relevant piece of
Author: Michael Buch
Date: 2025-08-01T11:19:53+01:00
New Revision: ebe6eba62580592af7065a36b22d929c15291e9a
URL:
https://github.com/llvm/llvm-project/commit/ebe6eba62580592af7065a36b22d929c15291e9a
DIFF:
https://github.com/llvm/llvm-project/commit/ebe6eba62580592af7065a36b22d929c15291e9a.diff
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/151629
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM
I saw the same problem with another test case on Windows on Arm. In that case I
was able to lower the amount of memory read, but here it needs to be some
amount greater than the l2 cache line size which is 512:
```
def MemCach
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/151490
>From 5f1bd9e57120d5b6be0fbdaacfcbcea1a465c6a9 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Thu, 31 Jul 2025 12:29:05 +0200
Subject: [PATCH 1/2] [LLDB] Add setting for native PDB reader
---
.../NativePDB/Symbo
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/149827
>From 3f144195543f7b256242b126d3d803954ef62f2f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 1 Aug 2025 11:04:47 +0100
Subject: [PATCH] Structors init
---
clang/include/clang/Basic/Attr.td
Nerixyz wrote:
> * keep the current behavior, which means `eDIAWithFallbackToNative`
Is this the current behavior? In my understanding, both plugins are mostly
independent. The DIA PDB parser only brings in the native PDB parser to
initialize it. It doesn't instantiate it to resolve a type.
R
aap-sc wrote:
> Also, their Program Buffer is kind of interesting,
Program buffer is for external debugger, unfortunately.
https://github.com/llvm/llvm-project/pull/151195
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
aap-sc wrote:
@jasonmolenda
> I may have skimmed the doc too quickly, but I didn't see a self-hosted side
> to this spec, how is Linux going to support it?
The debug specification describes two extensions `sdext` and `sdtrig` . `sdext`
is for external debug (jtag and stuff), while `sdtrig` d
https://github.com/tgymnich approved this pull request.
https://github.com/llvm/llvm-project/pull/151629
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-08-01T09:22:40+01:00
New Revision: 96d117859c1cc3fb81897d3d72f7c4692b7ee930
URL:
https://github.com/llvm/llvm-project/commit/96d117859c1cc3fb81897d3d72f7c4692b7ee930
DIFF:
https://github.com/llvm/llvm-project/commit/96d117859c1cc3fb81897d3d72f7c4692b7ee930.diff
https://github.com/mstorsjo requested changes to this pull request.
This doesn't yet work as it should.
https://github.com/llvm/llvm-project/pull/151603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
@@ -326,27 +326,19 @@ endif()
# In a cross-compile build, we need to skip building the generated
# lldb-rpc sources in the first phase of host build so that they can
# get built using the just-built Clang toolchain in the second phase.
-if (NOT DEFINED LLDB_CAN_USE_LLDB_RPC_SER
https://github.com/mstorsjo edited
https://github.com/llvm/llvm-project/pull/151603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -18,6 +18,11 @@ add_lldb_tool(lldb-rpc-gen
Support
)
-if (NOT DEFINED LLDB_RPC_GEN_EXE)
- set(LLDB_RPC_GEN_EXE $ CACHE STRING "Executable
that generates lldb-rpc-server")
+if (CMAKE_CROSSCOMPILING)
+ setup_host_tool(lldb-rpc-gen LLDB_RPC_GEN_EXE lldb_rpc_gen_exe
@@ -18,6 +18,11 @@ add_lldb_tool(lldb-rpc-gen
Support
)
-if (NOT DEFINED LLDB_RPC_GEN_EXE)
- set(LLDB_RPC_GEN_EXE $ CACHE STRING "Executable
that generates lldb-rpc-server")
+if (CMAKE_CROSSCOMPILING)
+ setup_host_tool(lldb-rpc-gen LLDB_RPC_GEN_EXE lldb_rpc_gen_exe
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/151668
>From 6fa2b6e3acaeffd5fd55f46eded372944ba2c328 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 31 Jul 2025 14:50:59 +0100
Subject: [PATCH 1/2] Namespaces and global variables to IterationAction
---
.
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFInde
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Continuation from https://github.com/llvm/llvm-project/pull/151489
---
Patch is 22.60 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/151668.diff
9 Files Affec
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/151668
Continuation from https://github.com/llvm/llvm-project/pull/151489
>From 6fa2b6e3acaeffd5fd55f46eded372944ba2c328 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 31 Jul 2025 14:50:59 +0100
Subject: [P
mstorsjo wrote:
> On some cross compile builds, the tool is not correctly set and the command
> that runs the tool has an empty path for the tool, causing the build to fail.
I'd rather skip the "some" word here, this happens whenever cmake things we're
cross compiling - it's not just an odd ca
76 matches
Mail list logo
