[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-31 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `lldb` at step 16 "test-check-lldb-unit". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/7609 Here is the relevant piece o

[Lldb-commits] [lldb] [lldb] Ensure that TestMemoryCache.py reads allocated memory (PR #151635)

2025-07-31 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/151635 >From e6bb5f48978f4eabc9e49176eb3ffd04f2f0e66c Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Thu, 31 Jul 2025 20:39:15 -0700 Subject: [PATCH 1/2] [lldb] Ensure that TestMemoryCache.py reads allocated memo

[Lldb-commits] [lldb] [lldb] Ensure that TestMemoryCache.py reads allocated memory (PR #151635)

2025-07-31 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/test/API/functionalities/memory/cache/main.cpp `

[Lldb-commits] [lldb] [lldb] Ensure that TestMemoryCache.py reads allocated memory (PR #151635)

2025-07-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Igor Kudrin (igorkudrin) Changes The test reads 400 bytes of memory above the local variable. If the stack is shallow, this can reach non-allocated space, resulting in a test failure. --- Full diff: https://github.com/llvm/llvm-project/pul

[Lldb-commits] [lldb] [lldb] Ensure that TestMemoryCache.py reads allocated memory (PR #151635)

2025-07-31 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/151635 The test reads 400 bytes of memory above the local variable. If the stack is shallow, this can reach non-allocated space, resulting in a test failure. >From e6bb5f48978f4eabc9e49176eb3ffd04f2f0e66c Mon Sep 1

[Lldb-commits] [lldb] [lldb] Use std::optional::value_or (NFC) (PR #151629)

2025-07-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/151629.diff 1 Files Affected: - (modified) lldb/source/Interpreter/OptionArgParser.cpp (+1-1) ``diff diff --git a/lldb/source/Inter

[Lldb-commits] [lldb] [lldb] Use std::optional::value_or (NFC) (PR #151629)

2025-07-31 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/151629 None >From ce46f3df1109b25c660bc70de9f2f52f93e13ba0 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 31 Jul 2025 13:36:45 -0700 Subject: [PATCH] [lldb] Use std::optional::value_or (NFC) --- lldb/s

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/98369 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e15b3ef - [lldb] Add support for displaying `__float128` variables (#98369)

2025-07-31 Thread via lldb-commits
Author: beetrees Date: 2025-07-31T18:04:48-07:00 New Revision: e15b3ef704dec573452f6e318617c10031491030 URL: https://github.com/llvm/llvm-project/commit/e15b3ef704dec573452f6e318617c10031491030 DIFF: https://github.com/llvm/llvm-project/commit/e15b3ef704dec573452f6e318617c10031491030.diff LOG:

[Lldb-commits] [lldb] [lldb] Clear Frames when changing `disable-language-runtime-unwindplans` (PR #151208)

2025-07-31 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/151208 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 03bb10b - [lldb] Clear Frames when changing `disable-language-runtime-unwindplans` (#151208)

2025-07-31 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-07-31T18:00:55-07:00 New Revision: 03bb10bea6edeb6b1cbcb3fc6b590e585ae43ad6 URL: https://github.com/llvm/llvm-project/commit/03bb10bea6edeb6b1cbcb3fc6b590e585ae43ad6 DIFF: https://github.com/llvm/llvm-project/commit/03bb10bea6edeb6b1cbcb3fc6b590e585

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2025-07-31 Thread via lldb-commits
beetrees wrote: Formatting fixed. https://github.com/llvm/llvm-project/pull/98369 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2025-07-31 Thread via lldb-commits
https://github.com/beetrees updated https://github.com/llvm/llvm-project/pull/98369 >From 697f6cbf56e49588cb502519a9c685fb3ede6fe1 Mon Sep 17 00:00:00 2001 From: beetrees Date: Wed, 10 Jul 2024 18:49:45 +0100 Subject: [PATCH] [lldb] Add support for displaying `__float128` variables --- lldb/b

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-07-31 Thread via lldb-commits
@@ -0,0 +1,158 @@ +//===-- ScriptedFramePythonInterface.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Fix a use-after-free in SymbolFileCTF (PR #151586)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e1d45b1 - [lldb] Fix a use-after-free in SymbolFileCTF (#151586)

2025-07-31 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-31T14:15:20-07:00 New Revision: e1d45b1b97c1f18e5a5fb9db8621ae4b34ba0ab1 URL: https://github.com/llvm/llvm-project/commit/e1d45b1b97c1f18e5a5fb9db8621ae4b34ba0ab1 DIFF: https://github.com/llvm/llvm-project/commit/e1d45b1b97c1f18e5a5fb9db8621ae4b34ba0ab1.d

[Lldb-commits] [lldb] [lldb] Fix a use-after-free in SymbolFileCTF (PR #151586)

2025-07-31 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Makes sense to me. Thanks! https://github.com/llvm/llvm-project/pull/151586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a use-after-free in SymbolFileCTF (PR #151586)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > I think I'm missing something. Instead of removing it at the end of > `ResolveTypeUID`, you remove it right _after_ the call to `ResolveTypeUID`. > What's the difference? I should've mentioned that this function is (indirectly) recursive, because that's totally fine (e.g

[Lldb-commits] [lldb] [lldb] Fix a use-after-free in SymbolFileCTF (PR #151586)

2025-07-31 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: I think I'm missing something. Instead of removing it at the end of `ResolveTypeUID`, you remove it right _after_ the call to `ResolveTypeUID`. What's the difference? https://github.com/llvm/llvm-project/pull/151586 _

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] NFC: Clean up of IntrusiveRefCntPtr construction from raw pointers. (PR #151545)

2025-07-31 Thread James Y Knight via lldb-commits
https://github.com/jyknight closed https://github.com/llvm/llvm-project/pull/151545 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add stop_reason Python property to SBThread (PR #151568)

2025-07-31 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/151568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-07-31 Thread via lldb-commits
@@ -204,9 +209,64 @@ bool ScriptedThread::LoadArtificialStackFrames() { SymbolContext sc; symbol_addr.CalculateSymbolContext(&sc); -StackFrameSP synth_frame_sp = std::make_shared( +return std::make_shared( this->shared_from_this(), idx, idx, cfa, cfa_i

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-07-31 Thread via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-07-31 Thread via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-07-31 Thread via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-31 Thread Vladislav Dzhidzhoev via lldb-commits
@@ -37,6 +37,9 @@ def getExtraMakeArgs(self): def getArchCFlags(self, architecture): """Returns the ARCH_CFLAGS for the make system.""" +triple = self.getTriple(architecture) +if triple: +return ["ARCH_CFLAGS=-target {}".format(triple)]

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-07-31 Thread via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-07-31 Thread via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Add stop_reason Python property to SBThread (PR #151568)

2025-07-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/151568 >From e6016cf51e315fd894382c0c76ffbd5e3fc3ac04 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 31 Jul 2025 10:53:48 -0700 Subject: [PATCH 1/2] [lldb] Add stop_reason Python property to SBThread --- lldb

[Lldb-commits] [lldb] [lldb] Add stop_reason Python property to SBThread (PR #151568)

2025-07-31 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoi

[Lldb-commits] [lldb] [lldb] Add stop_reason Python property to SBThread (PR #151568)

2025-07-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/151568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add stop_reason Python property to SBThread (PR #151568)

2025-07-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/151568.diff 13 Files Affected: - (modified) lldb/bindings/interface/SBThreadExtensions.i (+4) - (modified) lldb/test/API/commands/watchp

[Lldb-commits] [lldb] [lldb] Add stop_reason Python property to SBThread (PR #151568)

2025-07-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/151568 None >From e6016cf51e315fd894382c0c76ffbd5e3fc3ac04 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 31 Jul 2025 10:53:48 -0700 Subject: [PATCH] [lldb] Add stop_reason Python property to SBThread --- ll

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151403 >From 279bb81cafcf1d5fcbb3f605293a52c0cbe25f9b Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 30 Jul 2025 14:57:20 -0700 Subject: [PATCH 1/2] [lldb] Support Darwin cross compilation for remote

[Lldb-commits] [lldb] [lldb] Don't use NamedTemporaryFile to test compiler support (PR #151387)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151387 >From 5174e09049e6e295862decfad8081105bca154aa Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 30 Jul 2025 13:19:50 -0700 Subject: [PATCH] [lldb] Don't use NamedTemporaryFile to test compiler su

[Lldb-commits] [lldb] [lldb][DWARFIndex][NFC] Change GetFunctions return type to IterationAction (PR #151489)

2025-07-31 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Wunderbar https://github.com/llvm/llvm-project/pull/151489 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-31 Thread Jason Molenda via lldb-commits
@@ -148,6 +148,16 @@ else endif endif +#-- +# Use LLD when cross compiling on Darwin. +#-- +ifeq "$(HOST_OS)" "Darwin" + ifneq (,$(

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/151374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f23c10f - [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (#151374)

2025-07-31 Thread via lldb-commits
Author: Dave Lee Date: 2025-07-31T10:28:12-07:00 New Revision: f23c10f9e68efae7df10745234bf879a84b2d02b URL: https://github.com/llvm/llvm-project/commit/f23c10f9e68efae7df10745234bf879a84b2d02b DIFF: https://github.com/llvm/llvm-project/commit/f23c10f9e68efae7df10745234bf879a84b2d02b.diff LOG:

[Lldb-commits] [lldb] [lldb] Don't use NamedTemporaryFile to test compiler support (PR #151387)

2025-07-31 Thread Alex Langford via lldb-commits
@@ -0,0 +1,26 @@ +""" +Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +See https://llvm.org/LICENSE.txt for license information. +SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception + +Prepares language bindings for LLDB build process. Run with

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-31 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/149774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-31 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/146884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-31 Thread John Harrison via lldb-commits
@@ -110,6 +110,11 @@ "additionalProperties": { "type": "string" } + }, + "lldb-dap.captureSessionLogs": { ashgti wrote: What if we replaced both `lldb-dap.log-path` with a `lldb-dap.log-dir` and we speci

[Lldb-commits] [lldb] [lldb] Add `ValueObject::CreateValueObjectFromScalar` and fix `Scalar::GetData` (PR #151350)

2025-07-31 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/151350 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-31 Thread John Harrison via lldb-commits
@@ -110,6 +110,11 @@ "additionalProperties": { "type": "string" } + }, + "lldb-dap.captureSessionLogs": { +"type": "boolean", +"description": "When enabled, LLDB-DAP session logs will be written to

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -37,6 +37,9 @@ def getExtraMakeArgs(self): def getArchCFlags(self, architecture): """Returns the ARCH_CFLAGS for the make system.""" +triple = self.getTriple(architecture) +if triple: +return ["ARCH_CFLAGS=-target {}".format(triple)]

[Lldb-commits] [libcxx] [lldb] [libcxx] adds size-based `__split_buffer` representation to unstable ABI (PR #139632)

2025-07-31 Thread Christopher Di Bella via lldb-commits
cjdb wrote: @ldionne if you don't have any further commentary, I'd like to merge this PR so that I can move on to upstreaming size-based vector. https://github.com/llvm/llvm-project/pull/139632 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [libcxx] [lldb] [libcxx] adds size-based `__split_buffer` representation to unstable ABI (PR #139632)

2025-07-31 Thread Christopher Di Bella via lldb-commits
@@ -74,6 +77,40 @@ def stdstring_SummaryProvider(valobj, dict): return '"' + strval + '"' +def get_buffer_data(parent): +map_valobj = parent.valobj.GetChildMemberWithName("__map_") +map_data = map_valobj.GetChildMemberWithName("__data_") +if map_data.I

[Lldb-commits] [lldb] [lldb] Fix auto advance PC in `EmulateInstructionARM64` if PC >= 4G (PR #151460)

2025-07-31 Thread Igor Kudrin via lldb-commits
@@ -13,15 +13,124 @@ #include "lldb/Core/Disassembler.h" #include "lldb/Target/ExecutionContext.h" #include "lldb/Utility/ArchSpec.h" +#include "lldb/Utility/RegisterValue.h" #include "Plugins/Instruction/ARM64/EmulateInstructionARM64.h" +#include "Plugins/Process/Utility/Re

[Lldb-commits] [lldb] [lldb] Clear Frames when changing `disable-language-runtime-unwindplans` (PR #151208)

2025-07-31 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/151208 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix auto advance PC in `EmulateInstructionARM64` if PC >= 4G (PR #151460)

2025-07-31 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/151460 >From e7ae06b1388e172a83fea0340f81d437b9da3c88 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Wed, 30 Jul 2025 23:28:59 -0700 Subject: [PATCH 1/5] [lldb] Fix auto advance PC in 'EmulateInstructionARM64' if

[Lldb-commits] [lldb] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2 (PR #148996)

2025-07-31 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > correct, the LLDB_RPC_GEN_EXE wasn't set at all because there is no the > rpc-gen tool on the build host. This is the case when the Clang/LLDB cross > build uses the pre-installed external cross-platform GCC toolchain. That > toolchain does not contain the rpc-gen tool a

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-31 Thread John Harrison via lldb-commits
@@ -156,24 +157,52 @@ async function getDAPArguments( .get("arguments", []); } +/** + * Formats the given date as a string in the form "MMddTHHMMSS". + * + * @param date The date to format as a string. + * @returns The formatted date. + */ +function formatDate(date: Da

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-31 Thread John Harrison via lldb-commits
@@ -110,6 +110,11 @@ "additionalProperties": { "type": "string" } + }, + "lldb-dap.captureSessionLogs": { +"type": "boolean", +"description": "When enabled, LLDB-DAP session logs will be written to

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-31 Thread John Harrison via lldb-commits
@@ -62,8 +63,12 @@ export class DebugSessionTracker createDebugAdapterTracker( session: vscode.DebugSession, ): vscode.ProviderResult { +this.logger.info(`Starting debug session "${session.name}"`); +let stopping = false; return { + onError: (error) =>

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-31 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. LGTM. Thanks for working on this. https://github.com/llvm/llvm-project/pull/148877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb][DWARFIndex][NFC] Change GetFunctions return type to IterationAction (PR #151489)

2025-07-31 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. This LGTM! When I was working on the accelerator tables in the past, this API really bothered me, so I'll be happy to see it changed! https://github.com/llvm/llvm-project/pull/151489 ___ ll

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-31 Thread Pavel Labath via lldb-commits
@@ -906,6 +982,20 @@ lldb::addr_t IRExecutionUnit::FindInUserDefinedSymbols( lldb::addr_t IRExecutionUnit::FindSymbol(lldb_private::ConstString name, bool &missing_weak) { + if (name.GetStringRef().starts_with(FunctionCallLabelPrefix))

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -1593,6 +1621,14 @@ DisassemblerLLVMC::DisassemblerLLVMC(const ArchSpec &arch, features_str += "+a,+m,"; } + const char *additional_features = + arch.GetAdditionalDisassemblyFeatureStr().data(); + // Prepend the additional_features if it's not already in the f

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -1284,6 +1285,54 @@ ObjectFileELF::RefineModuleDetailsFromNote(lldb_private::DataExtractor &data, return error; } +void ObjectFileELF::ParseRISCVAttributes(DataExtractor &data, uint64_t length, + ArchSpec &arch_spec) { + lldb::off

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -548,6 +557,9 @@ class ArchSpec { // these are application specific extensions like micromips, mips16 etc. uint32_t m_flags = 0; + // Holds the additional disassembly feature string. JDevlieghere wrote: Maybe explain what this is and what it's used fo

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -537,6 +537,15 @@ class ArchSpec { void SetFlags(const std::string &elf_abi); + // Sets the target specific disassembly feature string + // for ELF disassembly. + void SetAdditionalDisassemblyFeatureStr(llvm::StringRef additional_features); + + // Get the current tar

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -548,6 +557,9 @@ class ArchSpec { // these are application specific extensions like micromips, mips16 etc. uint32_t m_flags = 0; + // Holds the additional disassembly feature string. + std::string m_additional_disassembly_feature_str; JDevlieghere wro

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -537,6 +537,15 @@ class ArchSpec { void SetFlags(const std::string &elf_abi); + // Sets the target specific disassembly feature string + // for ELF disassembly. + void SetAdditionalDisassemblyFeatureStr(llvm::StringRef additional_features); JDevlieghe

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -1284,6 +1285,54 @@ ObjectFileELF::RefineModuleDetailsFromNote(lldb_private::DataExtractor &data, return error; } +void ObjectFileELF::ParseRISCVAttributes(DataExtractor &data, uint64_t length, + ArchSpec &arch_spec) { + lldb::off

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -537,6 +537,15 @@ class ArchSpec { void SetFlags(const std::string &elf_abi); + // Sets the target specific disassembly feature string + // for ELF disassembly. JDevlieghere wrote: At the ArchSpec level, the fact that this is coming from ELF is an im

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -1446,6 +1446,34 @@ bool DisassemblerLLVMC::MCDisasmInstance::IsAuthenticated( return InstrDesc.isAuthenticated() || IsBrkC47x; } +void DisassemblerLLVMC::UpdateFeatureString(llvm::StringRef additional_features, +std::string &

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,11 @@ +# REQUIRES: target=riscv32-{{.*}} + +# RUN: %lldb -b -o "disassemble -b -n main" %p/Inputs/riscv_xqci.out | FileCheck %s + +# CHECK: 051f 0058 qc.e.li a0, 0x58 +# CHECK: 1516 qc.extu a0, a0, 0x6, 0x0 + +# RUN: %lldb -b -o "disassemble -b -n ma

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. https://github.com/llvm/llvm-project/pull/147990 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] NFC: Clean up of IntrusiveRefCntPtr construction from raw pointers. (PR #151545)

2025-07-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: James Y Knight (jyknight) Changes Handles clang::DiagnosticsEngine and clang::DiagnosticIDs. For DiagnosticIDs, this mostly migrates from `new DiagnosticIDs` to convenience method `DiagnosticIDs::create()`. Part of cleanup https://g

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] NFC: Clean up of IntrusiveRefCntPtr construction from raw pointers. (PR #151545)

2025-07-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: James Y Knight (jyknight) Changes Handles clang::DiagnosticsEngine and clang::DiagnosticIDs. For DiagnosticIDs, this mostly migrates from `new DiagnosticIDs` to convenience method `DiagnosticIDs::create()`. Part of cleanup https:

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] NFC: Clean up of IntrusiveRefCntPtr construction from raw pointers. (PR #151545)

2025-07-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: James Y Knight (jyknight) Changes Handles clang::DiagnosticsEngine and clang::DiagnosticIDs. For DiagnosticIDs, this mostly migrates from `new DiagnosticIDs` to convenience method `DiagnosticIDs::create()`. Part of cleanup https://githu

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] NFC: Clean up of IntrusiveRefCntPtr construction from raw pointers. (PR #151545)

2025-07-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-flang-driver Author: James Y Knight (jyknight) Changes Handles clang::DiagnosticsEngine and clang::DiagnosticIDs. For DiagnosticIDs, this mostly migrates from `new DiagnosticIDs` to convenience method `DiagnosticIDs::create()`. Part of cleanup https:/

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] NFC: Clean up of IntrusiveRefCntPtr construction from raw pointers. (PR #151545)

2025-07-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl @llvm/pr-subscribers-clang-tools-extra Author: James Y Knight (jyknight) Changes Handles clang::DiagnosticsEngine and clang::DiagnosticIDs. For DiagnosticIDs, this mostly migrates from `new DiagnosticIDs` to convenience method `DiagnosticIDs::crea

[Lldb-commits] [lldb] [llvm] [lldb][windows] use Windows APIs to print to the console (PR #149493)

2025-07-31 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/149493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][darwin] force BuiltinHeadersInSystemModules to be always false (PR #151535)

2025-07-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes This is a re-landing of https://github.com/llvm/llvm-project/pull/144913, which was reverted because of tests failing on Darwin. The bots were failing because the x64 bots run the macOS 14.0 SDKs whe

[Lldb-commits] [lldb] [lldb][darwin] force BuiltinHeadersInSystemModules to be always false (PR #151535)

2025-07-31 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/151535 This is a re-landing of https://github.com/llvm/llvm-project/pull/144913, which was reverted because of tests failing on Darwin. The bots were failing because the x64 bots run the macOS 14.0 SDKs whereas

[Lldb-commits] [lldb] [llvm] [lldb][windows] use Windows APIs to print to the console (PR #149493)

2025-07-31 Thread Charles Zablit via lldb-commits
@@ -853,4 +853,6 @@ raw_ostream &operator<<(raw_ostream &OS, const std::optional &O) { } // end namespace llvm +bool write_console_impl(int FD, llvm::StringRef Data); charles-zablit wrote: Fixed by using an instance of `raw_fd_ostream` instead. https://git

[Lldb-commits] [lldb] [llvm] [lldb][windows] use Windows APIs to print to the console (PR #149493)

2025-07-31 Thread Charles Zablit via lldb-commits
@@ -853,4 +853,6 @@ raw_ostream &operator<<(raw_ostream &OS, const std::optional &O) { } // end namespace llvm +bool write_console_impl(int FD, llvm::StringRef Data); charles-zablit wrote: Using an instance of `raw_fd_ostream` works. Thanks! https://github

[Lldb-commits] [lldb] [llvm] [lldb][windows] use Windows APIs to print to the console (PR #149493)

2025-07-31 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/149493 >From 77bf2b7acb82ea930702c8b0587c019fd48dc0f2 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Fri, 18 Jul 2025 12:29:31 +0200 Subject: [PATCH 1/7] [windows][lldb] force the console to use a UTF-8 cod

[Lldb-commits] [clang] [lldb] [llvm] NFC: Clean up construction of IntrusiveRefCntPtr from raw pointers for llvm::vfs::FileSystem. (PR #151407)

2025-07-31 Thread James Y Knight via lldb-commits
https://github.com/jyknight closed https://github.com/llvm/llvm-project/pull/151407 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9ddbb47 - NFC: Clean up construction of IntrusiveRefCntPtr from raw pointers for llvm::vfs::FileSystem. (#151407)

2025-07-31 Thread via lldb-commits
Author: James Y Knight Date: 2025-07-31T09:57:13-04:00 New Revision: 9ddbb478ce11e43ae18aa6d04937a51621021482 URL: https://github.com/llvm/llvm-project/commit/9ddbb478ce11e43ae18aa6d04937a51621021482 DIFF: https://github.com/llvm/llvm-project/commit/9ddbb478ce11e43ae18aa6d04937a51621021482.diff

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-31 Thread via lldb-commits
award999 wrote: @ashgti @JDevlieghere I did some more testing this morning, this PR is ready to land pending any further comments https://github.com/llvm/llvm-project/pull/146884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-31 Thread via lldb-commits
https://github.com/award999 edited https://github.com/llvm/llvm-project/pull/146884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add `ValueObject::CreateValueObjectFromScalar` and fix `Scalar::GetData` (PR #151350)

2025-07-31 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: Changed the default address type and tried it with pointers, it works. I just didn't think about creating pointers with this function initially, but apparently it can be done as well. https://github.com/llvm/llvm-project/pull/151350 ___

[Lldb-commits] [lldb] [lldb] Add `ValueObject::CreateValueObjectFromScalar` and fix `Scalar::GetData` (PR #151350)

2025-07-31 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/151350 >From ff14392e82fb5658c87b4376551a0dc366b33e8c Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Wed, 30 Jul 2025 17:39:43 +0500 Subject: [PATCH 1/2] [lldb] Add `ValueObject::CreateValueObjectFromScalar` --- lld

[Lldb-commits] [lldb] [lldb][DWARFIndex][NFC] Change GetFunctions return type to IterationAction (PR #151489)

2025-07-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes The ultimate goal is to replace the return types of all the `DWARFIndex` callbacks to `IterationAction`. To reduce the blast radius and do this incrementally I'm doing this for `GetFunctions` only here. I

[Lldb-commits] [lldb] [lldb][DWARFIndex][NFC] Change GetFunctions return type to IterationAction (PR #151489)

2025-07-31 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/151489 The ultimate goal is to replace the return types of all the `DWARFIndex` callbacks to `IterationAction`. To reduce the blast radius and do this incrementally I'm doing this for `GetFunctions` only here. I ad

[Lldb-commits] [lldb] [windows][lldb] implement system logging on Windows (PR #150213)

2025-07-31 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/150213 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 87023cd - [windows][lldb] implement system logging on Windows (#150213)

2025-07-31 Thread via lldb-commits
Author: Charles Zablit Date: 2025-07-31T10:38:33+01:00 New Revision: 87023cdc1c5e0e8b968e3ad51660fcebe57ddb38 URL: https://github.com/llvm/llvm-project/commit/87023cdc1c5e0e8b968e3ad51660fcebe57ddb38 DIFF: https://github.com/llvm/llvm-project/commit/87023cdc1c5e0e8b968e3ad51660fcebe57ddb38.diff

[Lldb-commits] [lldb] [lldb] Fix auto advance PC in `EmulateInstructionARM64` if PC >= 4G (PR #151460)

2025-07-31 Thread David Spickett via lldb-commits
@@ -60,3 +169,18 @@ TEST_F(TestAArch64Emulator, TestOverflow) { ASSERT_EQ(pstate.V, 1ULL); ASSERT_EQ(pstate.C, 0ULL); } + +TEST_F(TestAArch64Emulator, TestAutoAdvancePC) { + Arch64EmulatorTester emu; + emu.memory_offset = 0x1234567800; + emu.gpr.pc = 0x1234567800; --

[Lldb-commits] [lldb] [lldb] Fix auto advance PC in `EmulateInstructionARM64` if PC >= 4G (PR #151460)

2025-07-31 Thread David Spickett via lldb-commits
@@ -13,15 +13,124 @@ #include "lldb/Core/Disassembler.h" #include "lldb/Target/ExecutionContext.h" #include "lldb/Utility/ArchSpec.h" +#include "lldb/Utility/RegisterValue.h" #include "Plugins/Instruction/ARM64/EmulateInstructionARM64.h" +#include "Plugins/Process/Utility/Re

[Lldb-commits] [lldb] [lldb] Fix auto advance PC in `EmulateInstructionARM64` if PC >= 4G (PR #151460)

2025-07-31 Thread David Spickett via lldb-commits
@@ -13,15 +13,124 @@ #include "lldb/Core/Disassembler.h" #include "lldb/Target/ExecutionContext.h" #include "lldb/Utility/ArchSpec.h" +#include "lldb/Utility/RegisterValue.h" #include "Plugins/Instruction/ARM64/EmulateInstructionARM64.h" +#include "Plugins/Process/Utility/Re

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [DRAFT] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-07-31 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/test/API/lang/cpp/expr-definition-in-dylib/lib

[Lldb-commits] [lldb] c31cb8b - [lldb][docs] Fix typo in frame-format docs

2025-07-31 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-07-31T09:00:40+01:00 New Revision: c31cb8b9b88d824d8c7639dd7303cd1aa7674960 URL: https://github.com/llvm/llvm-project/commit/c31cb8b9b88d824d8c7639dd7303cd1aa7674960 DIFF: https://github.com/llvm/llvm-project/commit/c31cb8b9b88d824d8c7639dd7303cd1aa7674960.diff

[Lldb-commits] [lldb] [lldb][test][NFC] Add LLDB test for UBSan trap frame recognizer (PR #151231)

2025-07-31 Thread Michael Buch via lldb-commits
Michael137 wrote: > Apparently, these changes break > [lldb-x86_64-win](https://lab.llvm.org/buildbot/#/builders/211) buildbot with > the following error: > > ``` > C:\buildbot\as-builder-10\lldb-x86-64\llvm-project\lldb\test\Shell\Recognizer\ubsan_add_overflow.test:7:10: > error: CHECK: expe

[Lldb-commits] [lldb] 21bf2fa - [lldb][test] Skip Recognizer/ubsan_add_overflow.test on Windows

2025-07-31 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-07-31T08:58:03+01:00 New Revision: 21bf2fa77fbf19d0a02ced63e4caa37a8c65fb07 URL: https://github.com/llvm/llvm-project/commit/21bf2fa77fbf19d0a02ced63e4caa37a8c65fb07 DIFF: https://github.com/llvm/llvm-project/commit/21bf2fa77fbf19d0a02ced63e4caa37a8c65fb07.diff

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-31 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/151403 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-31 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/151403 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][NFC] Add LLDB test for UBSan trap frame recognizer (PR #151231)

2025-07-31 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: Apparently, these changes break [lldb-x86_64-win](https://lab.llvm.org/buildbot/#/builders/211) buildbot with the following error: ``` C:\buildbot\as-builder-10\lldb-x86-64\llvm-project\lldb\test\Shell\Recognizer\ubsan_add_overflow.test:7:10: error: CHECK: expected string no

  1   2   >