[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/148736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-17 Thread Jonas Devlieghere via lldb-commits
@@ -323,12 +332,24 @@ foreach(header COMMENT "LLDB headers: stage LLDB headers in include directory") list(APPEND lldb_staged_headers ${staged_header}) + + if (LLDB_BUILD_FRAMEWORK) +set(input_header ${staged_header}) JDevlieghere wrote: Seems like

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-17 Thread Jonas Devlieghere via lldb-commits
@@ -323,12 +332,24 @@ foreach(header COMMENT "LLDB headers: stage LLDB headers in include directory") list(APPEND lldb_staged_headers ${staged_header}) + + if (LLDB_BUILD_FRAMEWORK) +set(input_header ${staged_header}) +set(output_header $/Headers/${basename}) +

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM modulo comments. https://github.com/llvm/llvm-project/pull/148736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix type req->arguments == "disconnect" (PR #149446)

2025-07-17 Thread via lldb-commits
https://github.com/kusmour closed https://github.com/llvm/llvm-project/pull/149446 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] de453e8 - [lldb-dap] Fix type req->arguments == "disconnect" (#149446)

2025-07-17 Thread via lldb-commits
Author: Wanyi Date: 2025-07-18T01:14:28-04:00 New Revision: de453e86977adf4f418b003b5c25931b8365c9cc URL: https://github.com/llvm/llvm-project/commit/de453e86977adf4f418b003b5c25931b8365c9cc DIFF: https://github.com/llvm/llvm-project/commit/de453e86977adf4f418b003b5c25931b8365c9cc.diff LOG: [l

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-17 Thread Nathan Chancellor via lldb-commits
nathanchance wrote: For what it’s worth, it looks like this introduces a series of `-Wformat` warnings when building the Linux kernel for 32-bit targets, which `typedef size_t` as `unsigned int` in [`include/linux/types.h`](https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tre

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-17 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux` running on `sanitizer-buildbot1` while building `clang-tools-extra,clang,libcxx,lldb` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/16687 Her

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-17 Thread via lldb-commits
github-actions[bot] wrote: @YexuanXiao Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bui

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-17 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/143653 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Process minidump is in memory check command (PR #149401)

2025-07-17 Thread via lldb-commits
@@ -648,6 +648,26 @@ class RangeDataVector { return nullptr; } + const Entry *FindEntryThatContainsOrPrior(B addr) const { +#ifdef ASSERT_RANGEMAP_ARE_SORTED +assert(IsSorted()); +#endif +if (!m_entries.empty()) { + typename Collection::const_iterator begin

[Lldb-commits] [lldb] [lldb] Always compute the execution & symbol context (PR #148994)

2025-07-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/148994 >From ee116a937d165f4862aae34206d112682b8ce0ee Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 15 Jul 2025 16:54:05 -0700 Subject: [PATCH 1/2] [lldb] Always compute the execution & symbol contex

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-17 Thread Greg Clayton via lldb-commits
@@ -965,6 +965,16 @@ Status PluginManager::SaveCore(const lldb::ProcessSP &process_sp, return error; } + if (!options.GetProcess()) +options.SetProcess(process_sp); clayborg wrote: We should be doing this before calling SaveCore as what if this pr

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-17 Thread Greg Clayton via lldb-commits
@@ -965,6 +965,16 @@ Status PluginManager::SaveCore(const lldb::ProcessSP &process_sp, return error; } + if (!options.GetProcess()) +options.SetProcess(process_sp); + + // Make sure the process sp is the same as the one we are using. + if (options.GetProcess() !=

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-17 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/146777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Allow returning multiple breakpoints in "stopped" event (PR #149133)

2025-07-17 Thread Stephen Tozer via lldb-commits
@@ -33,7 +33,7 @@ int main(int argc, char const *argv[]) { if (foo == nullptr) { fprintf(stderr, "%s\n", dlerror()); exit(2); - } + } // end of foo check SLTozer wrote: I can make this change, but other comments used for setting breakpoints in the

[Lldb-commits] [compiler-rt] [lldb] [llvm] Rename config.host_os to config.target_os. (PR #149015)

2025-07-17 Thread Teresa Johnson via lldb-commits
teresajohnson wrote: thanks that fixed it https://github.com/llvm/llvm-project/pull/149015 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-17 Thread Chelsea Cassanova via lldb-commits
@@ -105,18 +78,32 @@ set_target_properties(liblldb-resource-headers PROPERTIES FOLDER "LLDB/Resources add_dependencies(liblldb-resource-headers liblldb-header-staging) add_dependencies(liblldb liblldb-resource-headers) -# Take the headers from the staging directory and fix up

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-17 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/148736 >From e473fa9d67517d18ed106c900d665b4bda2f1aff Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 14 Jul 2025 16:58:23 -0500 Subject: [PATCH] [lldb][framework] Glob headers from source for framewo

[Lldb-commits] [compiler-rt] [lldb] [llvm] Rename config.host_os to config.target_os. (PR #149015)

2025-07-17 Thread Peter Collingbourne via lldb-commits
pcc wrote: Should now be fixed: e68efed71ba818a9eb18a2baede922e1e2ff9a46 Verified that check-asan runs. https://github.com/llvm/llvm-project/pull/149015 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [compiler-rt] [lldb] [llvm] Rename config.host_os to config.target_os. (PR #149015)

2025-07-17 Thread Teresa Johnson via lldb-commits
teresajohnson wrote: > I'm getting an error in my testing that I'm guessing is from this change > (paths shortened for simplicity): > > ``` > llvm-lit: llvm/utils/lit/lit/TestingConfig.py:157: fatal: unable to parse > config file 'compiler-rt/test/lit.common.cfg.py', traceback: Traceback (most

[Lldb-commits] [compiler-rt] [lldb] [llvm] Rename config.host_os to config.target_os. (PR #149015)

2025-07-17 Thread Teresa Johnson via lldb-commits
teresajohnson wrote: I'm getting an error in my testing that I'm guessing is from this change (paths shortened for simplicity): ``` llvm-lit: llvm/utils/lit/lit/TestingConfig.py:157: fatal: unable to parse config file 'compiler-rt/test/lit.common.cfg.py', traceback: Traceback (most recent cal

[Lldb-commits] [compiler-rt] [lldb] [llvm] Rename config.host_os to config.target_os. (PR #149015)

2025-07-17 Thread Peter Collingbourne via lldb-commits
https://github.com/pcc closed https://github.com/llvm/llvm-project/pull/149015 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3fa07ed - Rename config.host_os to config.target_os.

2025-07-17 Thread via lldb-commits
Author: Peter Collingbourne Date: 2025-07-17T11:12:29-07:00 New Revision: 3fa07ed5b38774656a2cff1bebc1785ce8e7feb8 URL: https://github.com/llvm/llvm-project/commit/3fa07ed5b38774656a2cff1bebc1785ce8e7feb8 DIFF: https://github.com/llvm/llvm-project/commit/3fa07ed5b38774656a2cff1bebc1785ce8e7feb8

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-17 Thread Alex Langford via lldb-commits
@@ -105,18 +78,32 @@ set_target_properties(liblldb-resource-headers PROPERTIES FOLDER "LLDB/Resources add_dependencies(liblldb-resource-headers liblldb-header-staging) add_dependencies(liblldb liblldb-resource-headers) -# Take the headers from the staging directory and fix up

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-17 Thread Alex Langford via lldb-commits
bulbazord wrote: > > The new code duplicates a lot of the existing logic in API/CMakeLists.txt. > > Wouldn't it be simpler to add the framework code to the existing loop > > behind if(LLDB_BUILD_FRAMEWORK)? > > That can be done, I think we'd also have to move the top-level targets for > fixin

[Lldb-commits] [lldb] [lldb][rpc] Use Clang attributes to keep track of pointer plus len (PR #148981)

2025-07-17 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,469 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2 (PR #148996)

2025-07-17 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/148996 >From 93913751666fa7121457dc7ab6a766fa90836598 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 15 Jul 2025 18:42:34 -0500 Subject: [PATCH] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146

[Lldb-commits] [lldb] [lldb] Always compute the execution & symbol context (PR #148994)

2025-07-17 Thread via lldb-commits
jimingham wrote: Except for the quibble that "current" is ambiguous, and it's better to use the explicit "currently selected" this looks fine. https://github.com/llvm/llvm-project/pull/148994 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] [lldb][rpc] Use Clang attributes to keep track of pointer plus len (PR #148981)

2025-07-17 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,469 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Always compute the execution & symbol context (PR #148994)

2025-07-17 Thread via lldb-commits
@@ -421,6 +421,9 @@ class Debugger : public std::enable_shared_from_this, /// Redraw the statusline if enabled. void RedrawStatusline(bool update = true); + /// Compute the current execution and symbol context. jimingham wrote: I would be explicit and c

[Lldb-commits] [lldb] [lldb][rpc] Use Clang attributes to keep track of pointer plus len (PR #148981)

2025-07-17 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > What happens when you don't put this annotation on one of these? It generates > something I suppose, but it fails when you use lldb-rpc? Correct, without an annotation (or in the earlier case, without having a given function in the exception list), a function will still

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-17 Thread Sad Al Abdullah via lldb-commits
SiamAbdullah wrote: @JDevlieghere @adrian-prantl, would you review this diff and unblock @cs01 ? https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-17 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > The new code duplicates a lot of the existing logic in API/CMakeLists.txt. > Wouldn't it be simpler to add the framework code to the existing loop behind > if(LLDB_BUILD_FRAMEWORK)? That can be done, I think we'd also have to move the top-level targets for fixing up fra

[Lldb-commits] [lldb] [llvm] [LLDB] Switch to using DIL as default implementation for 'frame var'. (PR #147887)

2025-07-17 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: > It looks like this just barely didn't make it into the 21.x release branch. > Do we want to cherry-pick that over? I think it would be a good way to flush > out any issues... I think so too, this and #149117. Do we just create a PR with the same changes into `release/21.x` bra

[Lldb-commits] [lldb] [lldb] Adjust default target.max-children-depth (PR #149282)

2025-07-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/149282 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Process minidump better error messages (PR #149206)

2025-07-17 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/149206 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a6fb3b3 - [LLDB] Process minidump better error messages (#149206)

2025-07-17 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-07-17T09:18:23-07:00 New Revision: a6fb3b3c18fd48a2eaaa8c969edbc013b9276a09 URL: https://github.com/llvm/llvm-project/commit/a6fb3b3c18fd48a2eaaa8c969edbc013b9276a09 DIFF: https://github.com/llvm/llvm-project/commit/a6fb3b3c18fd48a2eaaa8c969edbc013b9276a09.diff

[Lldb-commits] [lldb] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2 (PR #148996)

2025-07-17 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > You should email the worker admin and see if they can help. "Worker:" tab > then "admin". Thanks! I've reached out to them and I'm waiting to hear back. > It is doing remote testing but the failure seems to be before that step so I > think it's something to do with the

[Lldb-commits] [lldb] Clean up LLDB `type format` docs a bit (PR #149311)

2025-07-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/149311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Process minidump better error messages (PR #149206)

2025-07-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/149206 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: The new code duplicates a lot of the existing logic in `API/CMakeLists.txt`. Wouldn't it be simpler to add the framework code to the existing loop behind `if(LLDB_BUILD_FRAMEWORK)`? https://github.com/llvm/llvm-project/pull/148736 ___

[Lldb-commits] [lldb] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2 (PR #148996)

2025-07-17 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/148996 >From 015acc5f0dd749bcc51d690b1c7fb1577cf66aa4 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 15 Jul 2025 18:42:34 -0500 Subject: [PATCH] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146

[Lldb-commits] [lldb] [lldb][test] Fix TestChildCountTruncation on Windows (PR #149322)

2025-07-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/149322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4bf82ae - [lldb][test] Fix TestChildCountTruncation on Windows (#149322)

2025-07-17 Thread via lldb-commits
Author: David Spickett Date: 2025-07-17T16:06:03+01:00 New Revision: 4bf82aebc0da985cf6b2e70812714875e8fa78fa URL: https://github.com/llvm/llvm-project/commit/4bf82aebc0da985cf6b2e70812714875e8fa78fa DIFF: https://github.com/llvm/llvm-project/commit/4bf82aebc0da985cf6b2e70812714875e8fa78fa.diff

[Lldb-commits] [lldb] [lldb][test] Fix TestChildCountTruncation on Windows (PR #149322)

2025-07-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/149322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix TestChildCountTruncation on Windows (PR #149322)

2025-07-17 Thread Michael Buch via lldb-commits
Michael137 wrote: nope doesn't need dwarf, thanks! https://github.com/llvm/llvm-project/pull/149322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix TestChildCountTruncation on Windows (PR #149322)

2025-07-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: @Michael137 Does this actually need DWARF, or will any debug info format do? https://github.com/llvm/llvm-project/pull/149322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] [lldb][test] Fix TestChildCountTruncation on Windows (PR #149322)

2025-07-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes By not forcing the DWARF debug info format. When left as the default, the tests pass. Test added by https://github.com/llvm/llvm-project/pull/149088. --- Full diff: https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] [lldb][test] Fix TestChildCountTruncation on Windows (PR #149322)

2025-07-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/149322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix TestChildCountTruncation on Windows (PR #149322)

2025-07-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/149322 By not forcing the DWARF debug info format. When left as the default, the tests pass. >From 092168660b280c0e1a1f6956bddd11899d5bafcc Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 17 Jul 2025 1

[Lldb-commits] [lldb] ba5f31c - [lldb][test] Disable TestChildCountTruncation on Windows

2025-07-17 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-07-17T14:30:50Z New Revision: ba5f31cfaa2452a4a94a482b53d899d6f2ee0e66 URL: https://github.com/llvm/llvm-project/commit/ba5f31cfaa2452a4a94a482b53d899d6f2ee0e66 DIFF: https://github.com/llvm/llvm-project/commit/ba5f31cfaa2452a4a94a482b53d899d6f2ee0e66.diff LOG

[Lldb-commits] [lldb] 756e077 - [lldb][test] Adjust TestTypeList.py on Windows with exceptions

2025-07-17 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-07-17T14:24:05Z New Revision: 756e07734b4f2aa64bd1bd5b6a29389c4c642323 URL: https://github.com/llvm/llvm-project/commit/756e07734b4f2aa64bd1bd5b6a29389c4c642323 DIFF: https://github.com/llvm/llvm-project/commit/756e07734b4f2aa64bd1bd5b6a29389c4c642323.diff LOG

[Lldb-commits] [lldb] Clean up LLDB `type format` docs a bit (PR #149311)

2025-07-17 Thread Sam Estep via lldb-commits
https://github.com/samestep edited https://github.com/llvm/llvm-project/pull/149311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Clean up LLDB `type format delete` doc paragraph (PR #149311)

2025-07-17 Thread Sam Estep via lldb-commits
https://github.com/samestep updated https://github.com/llvm/llvm-project/pull/149311 >From af8f67a8ed9b0f66dc9aad7d0a0358471a25968f Mon Sep 17 00:00:00 2001 From: Sam Estep Date: Thu, 17 Jul 2025 09:45:31 -0400 Subject: [PATCH 1/2] Clean up LLDB `type format delete` doc paragraph --- lldb/doc

[Lldb-commits] [lldb] Clean up LLDB `type format` docs a bit (PR #149311)

2025-07-17 Thread Sam Estep via lldb-commits
https://github.com/samestep edited https://github.com/llvm/llvm-project/pull/149311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Clean up LLDB `type format delete` doc paragraph (PR #149311)

2025-07-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Sam Estep (samestep) Changes This PR cleans up the formatting of the [LLDB doc paragraph about `type format delete`](https://lldb.llvm.org/use/variable.html#type-format) to make it more readable. --- Full diff: https://github.com/llvm/llv

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: Yes this is what I was thinking of. Don't go diving into the failures yet, I'll try this on the bot machine first and see if we need other adjustments. https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list

[Lldb-commits] [lldb] Clean up LLDB `type format delete` doc paragraph (PR #149311)

2025-07-17 Thread Sam Estep via lldb-commits
https://github.com/samestep created https://github.com/llvm/llvm-project/pull/149311 This PR cleans up the formatting of the [LLDB doc paragraph about `type format delete`](https://lldb.llvm.org/use/variable.html#type-format) to make it more readable. >From af8f67a8ed9b0f66dc9aad7d0a0358471a2

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-17 Thread via lldb-commits
Nerixyz wrote: @DavidSpickett added the PDB tests here - Is the general approach fine? https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::variant (PR #148554)

2025-07-17 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/148554 >From 2ae71bc96e19575037e7e200f317e714f79bcd98 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Mon, 14 Jul 2025 00:30:48 +0200 Subject: [PATCH 1/2] [LLDB] Add formatters for MSVC STL std::variant --- .../Plugins/

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-17 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149305 >From eeea8f973f5583276e4b9c24e8cddfa67b0cf06f Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Thu, 17 Jul 2025 15:10:24 +0200 Subject: [PATCH] [LLDB] Run API tests with native PDB too --- .../Python/lldbsuite/te

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/builders/builder.py lldb/packages/Pytho

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-17 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/148877 >From 31d9f127ede936a525e8a1630a0d910a2eef0369 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH] [lldb][Expression] Encode Module and DIE UIDs into function A

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-17 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/149305 >From https://github.com/llvm/llvm-project/pull/148554#issuecomment-3083261858 >- this runs the API tests with the native PDB on Windows. Using native over >DIA because it's easier to inspect/debug. One of the

[Lldb-commits] [lldb] [lldb] Adjust default target.max-children-depth (PR #149282)

2025-07-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149282 >From 2be8d8ddb03116776f2f1d04ec98da6da595959c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 17 Jul 2025 10:42:27 +0100 Subject: [PATCH 1/2] [lldb] Adjust default target.max-children-depth Deeply ne

[Lldb-commits] [lldb] Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2 (PR #148996)

2025-07-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: You should email the worker admin and see if they can help. "Worker:" tab then "admin". It is doing remote testing but the failure seems to be before that step so I think it's something to do with the host. https://github.com/llvm/llvm-project/pull/148996

[Lldb-commits] [lldb] [lldb][rpc] Use Clang attributes to keep track of pointer plus len (PR #148981)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,469 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][rpc] Use Clang attributes to keep track of pointer plus len (PR #148981)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,469 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][rpc] Use Clang attributes to keep track of pointer plus len (PR #148981)

2025-07-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: What happens when you don't put this annotation on one of these? It generates something I suppose, but it fails when you use lldb-rpc? https://github.com/llvm/llvm-project/pull/148981 ___ lldb-commits mailin

[Lldb-commits] [lldb] [lldb][rpc] Use Clang attributes to keep track of pointer plus len (PR #148981)

2025-07-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/148981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,124 @@ +#include "RPCLibraryHeaderEmitter.h" +#include "RPCCommon.h" + +#include "clang/AST/AST.h" +#include "clang/AST/Mangle.h" +#include "clang/Frontend/CompilerInstance.h" + +#include "llvm/ADT/StringRef.h" +#include "llvm/Support/ToolOutputFile.h" +#include "llvm/S

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,542 @@ +#include "RPCLibrarySourceEmitter.h" +#include "RPCCommon.h" + +#include "clang/AST/AST.h" +#include "clang/Frontend/CompilerInstance.h" + +#include "llvm/ADT/STLExtras.h" +#include "llvm/ADT/SmallString.h" +#include "llvm/ADT/StringRef.h" +#include "llvm/Suppor

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,20 @@ +#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H +#define LLDB_API_SBRPC_CHECKARRAYPTR_H + +#include +#include + +#include "lldb/API/SBDefines.h" + +namespace lldb { +class LLDB_API SBRPC_CHECKARRAYPTR { DavidSpickett wrote: Not sure about the ALLCAPS n

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,542 @@ +#include "RPCLibrarySourceEmitter.h" +#include "RPCCommon.h" + +#include "clang/AST/AST.h" +#include "clang/Frontend/CompilerInstance.h" + +#include "llvm/ADT/STLExtras.h" +#include "llvm/ADT/SmallString.h" +#include "llvm/ADT/StringRef.h" +#include "llvm/Suppor

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,542 @@ +#include "RPCLibrarySourceEmitter.h" +#include "RPCCommon.h" + +#include "clang/AST/AST.h" +#include "clang/Frontend/CompilerInstance.h" + +#include "llvm/ADT/STLExtras.h" +#include "llvm/ADT/SmallString.h" +#include "llvm/ADT/StringRef.h" +#include "llvm/Suppor

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,20 @@ +#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H +#define LLDB_API_SBRPC_CHECKARRAYPTR_H + +#include +#include + +#include "lldb/API/SBDefines.h" + +namespace lldb { +class LLDB_API SBRPC_CHECKARRAYPTR { DavidSpickett wrote: So these are just test input

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,124 @@ +#include "RPCLibraryHeaderEmitter.h" +#include "RPCCommon.h" + +#include "clang/AST/AST.h" +#include "clang/AST/Mangle.h" +#include "clang/Frontend/CompilerInstance.h" + +#include "llvm/ADT/StringRef.h" +#include "llvm/Support/ToolOutputFile.h" +#include "llvm/S

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,542 @@ +#include "RPCLibrarySourceEmitter.h" +#include "RPCCommon.h" + +#include "clang/AST/AST.h" +#include "clang/Frontend/CompilerInstance.h" + +#include "llvm/ADT/STLExtras.h" +#include "llvm/ADT/SmallString.h" +#include "llvm/ADT/StringRef.h" +#include "llvm/Suppor

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,542 @@ +#include "RPCLibrarySourceEmitter.h" +#include "RPCCommon.h" + +#include "clang/AST/AST.h" +#include "clang/Frontend/CompilerInstance.h" + +#include "llvm/ADT/STLExtras.h" +#include "llvm/ADT/SmallString.h" +#include "llvm/ADT/StringRef.h" +#include "llvm/Suppor

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,124 @@ +#include "RPCLibraryHeaderEmitter.h" +#include "RPCCommon.h" + +#include "clang/AST/AST.h" +#include "clang/AST/Mangle.h" +#include "clang/Frontend/CompilerInstance.h" + +#include "llvm/ADT/StringRef.h" +#include "llvm/Support/ToolOutputFile.h" +#include "llvm/S

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,542 @@ +#include "RPCLibrarySourceEmitter.h" +#include "RPCCommon.h" + +#include "clang/AST/AST.h" +#include "clang/Frontend/CompilerInstance.h" + +#include "llvm/ADT/STLExtras.h" +#include "llvm/ADT/SmallString.h" +#include "llvm/ADT/StringRef.h" +#include "llvm/Suppor

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,20 @@ +#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H +#define LLDB_API_SBRPC_CHECKARRAYPTR_H + +#include +#include DavidSpickett wrote: Oh these are just test inputs. So the include can be removed entirely? https://github.com/llvm/llvm-project/pull/147655

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,15 @@ +RUN: mkdir -p %t/server +RUN: mkdir -p %t/lib +RUN: %lldb-rpc-gen --output-dir=%t %S/../../Inputs/CheckSBPointer.h + +RUN: cat %t/lib/CheckSBPointer.cpp | FileCheck %s + +# Pointers to SB objects must be checked to +# see if they're null. If so, then a new object

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,20 @@ +#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H +#define LLDB_API_SBRPC_CHECKARRAYPTR_H + +#include +#include DavidSpickett wrote: I think all the cstdio includes can move into the cpp files. https://github.com/llvm/llvm-project/pull/147655 __

[Lldb-commits] [lldb] [lldb] Adjust default target.max-children-depth (PR #149282)

2025-07-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Deeply nested structs can be noisy, so Apple's LLDB fork sets the default to `4`: https://github.com/swiftlang/llvm-project/blob/9c93adbb283005ab416fd155b75fd43e6a8288ca/lldb/source/Target/TargetProperties

[Lldb-commits] [lldb] [lldb] Adjust default target.max-children-depth (PR #149282)

2025-07-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/149282 Deeply nested structs can be noisy, so Apple's LLDB fork sets the default to `4`: https://github.com/swiftlang/llvm-project/blob/9c93adbb283005ab416fd155b75fd43e6a8288ca/lldb/source/Target/TargetProperties.t

[Lldb-commits] [lldb] 4797a6c - [lldb][test] TestChildCountTruncation.test: add missing command

2025-07-17 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-07-17T10:49:05+01:00 New Revision: 4797a6c4e8244ab06829b2e462b1329e94286dbf URL: https://github.com/llvm/llvm-project/commit/4797a6c4e8244ab06829b2e462b1329e94286dbf DIFF: https://github.com/llvm/llvm-project/commit/4797a6c4e8244ab06829b2e462b1329e94286dbf.diff

[Lldb-commits] [lldb] d871702 - [lldb][test] Remove XFAIL from some Windows tests

2025-07-17 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-07-17T09:17:25Z New Revision: d87170211dc780341e42f7719c7332416f9cc290 URL: https://github.com/llvm/llvm-project/commit/d87170211dc780341e42f7719c7332416f9cc290 DIFF: https://github.com/llvm/llvm-project/commit/d87170211dc780341e42f7719c7332416f9cc290.diff LOG

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::variant (PR #148554)

2025-07-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: We had a discussion about preferring one or the other PDB implementation but I don't recall the conclusion. I think this is just for reading PDB, right? Clang is going to use llvm's libraries to *write* PDB and of course MSVC is using Microsoft's implementation. I think a