[Lldb-commits] [lldb] [llvm] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-16 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Incidentally, this is always something get a little confused by when reading assembly, we see it with backtraces. A CALL instruction executes and the return address is the next instruction. That confuses people looking at the assembly language -- the "pc" pointer is point

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-16 Thread Chad Smith via lldb-commits
cs01 wrote: Friendly ping @labath and anyone else who has any thoughts https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-16 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Interesting PR, thanks for looking at adding these annotations. I think exposing these dwarf location expressions in a more user-visible way is going to put a lot of pressure on making them more meaningful to users, as opposed to debugging prints for debugger/compiler deve

[Lldb-commits] [lldb] [lldb-dap] persistent assembly breakpoints (PR #148061)

2025-07-16 Thread Ely Ronnen via lldb-commits
eronnen wrote: @jimingham I don't know if the `instructions_offset` parameter can be useful for other use cases, but in order to resolve assembly breakpoints in future sessions under the given protocol constraints I don't see another way . In the Debug Adapter Protocol the only persistent da

[Lldb-commits] [lldb] [lldb] Print children-count warning for dwim-print and expr (PR #149088)

2025-07-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/149088 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8c28f49 - [lldb] Print children-count warning for dwim-print and expr (#149088)

2025-07-16 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-16T21:47:13+01:00 New Revision: 8c28f4920dfda2e3d91c58e8eb5b568dd396fa2d URL: https://github.com/llvm/llvm-project/commit/8c28f4920dfda2e3d91c58e8eb5b568dd396fa2d DIFF: https://github.com/llvm/llvm-project/commit/8c28f4920dfda2e3d91c58e8eb5b568dd396fa2d.diff

[Lldb-commits] [lldb] Draft: [LLDB] Add scalar literal node (PR #147064)

2025-07-16 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: > say that values retain their width and signedness, but then get converted > into the wider width using C-like rules. We already have this implemented > inside the Scalar class (which wraps APInt), so this would be best in terms > of code reuse, and it would produce few surprise

[Lldb-commits] [lldb] Draft: [LLDB] Add scalar literal node (PR #147064)

2025-07-16 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/147064 >From cf1f908360399ac51770d9fb7e1dac03eceab0e9 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Thu, 3 Jul 2025 19:34:17 +0500 Subject: [PATCH 1/2] [LLDB] *WIP* Add scalar literal node and binary addition --- l

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
@@ -0,0 +1,130 @@ +""" +Test that saved memory regions is byte-wise 1:1 with the live process. Specifically +that the memory regions that will be populated in the Memory64List are the same byte for byte. +""" + +import os +import lldb +from lldbsuite.test.decorators import * +f

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread Jacob Lalonde via lldb-commits
@@ -1130,9 +1122,9 @@ MinidumpFileBuilder::AddMemoryList_64(std::vector &ranges, // Capture the starting offset for all the descriptors so we can clean them up // if needed. offset_t starting_offset = - GetCurrentDataEndOffset() + sizeof(llvm::support::ulittle64_t)

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread Jacob Lalonde via lldb-commits
@@ -164,3 +164,46 @@ def test_get_total_in_bytes_missing_requirements(self): options.SetStyle(lldb.eSaveCoreCustomOnly) total = options.GetCurrentSizeInBytes(error) self.assertTrue(error.Fail(), error.GetCString()) + +def test_get_memory_regions_to_s

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,130 @@ +""" +Test that saved memory regions is byte-wise 1:1 with the live process. Specifically +that the memory regions that will be populated in the Memory64List are the same byte for byte. +""" + +import os +import lldb +from lldbsuite.test.decorators import * +f

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread Jacob Lalonde via lldb-commits
@@ -63,6 +67,12 @@ Note that currently ELF Core files are not supported." Get an SBThreadCollection of all threads marked to be saved. This collection is not sorted according to insertion order." ) lldb::SBSaveCoreOptions::GetThreadsToSave; +%feature("docstring", " +G

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-16 Thread Chelsea Cassanova via lldb-commits
@@ -105,18 +78,30 @@ set_target_properties(liblldb-resource-headers PROPERTIES FOLDER "LLDB/Resources add_dependencies(liblldb-resource-headers liblldb-header-staging) add_dependencies(liblldb liblldb-resource-headers) +# Glob all necessary header files from source and place

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
https://github.com/dmpots edited https://github.com/llvm/llvm-project/pull/146777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
@@ -169,8 +187,14 @@ llvm::Expected SaveCoreOptions::GetCurrentSizeInBytes() { if (error.Fail()) return error.takeError(); + llvm::Expected core_file_ranges_maybe = + GetMemoryRegionsToSave(); + if (!core_file_ranges_maybe) +return core_file_ranges_maybe.take

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
@@ -164,3 +164,46 @@ def test_get_total_in_bytes_missing_requirements(self): options.SetStyle(lldb.eSaveCoreCustomOnly) total = options.GetCurrentSizeInBytes(error) self.assertTrue(error.Fail(), error.GetCString()) + +def test_get_memory_regions_to_s

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
@@ -63,6 +67,12 @@ Note that currently ELF Core files are not supported." Get an SBThreadCollection of all threads marked to be saved. This collection is not sorted according to insertion order." ) lldb::SBSaveCoreOptions::GetThreadsToSave; +%feature("docstring", " +G

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
@@ -997,6 +982,13 @@ Status MinidumpFileBuilder::ReadWriteMemoryInChunks( return lldb_private::IterationAction::Stop; } +if (current_addr != addr + total_bytes_read) { dmpots wrote: Should this be an error? https://github.com/llvm/llvm-project/

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
@@ -997,6 +982,13 @@ Status MinidumpFileBuilder::ReadWriteMemoryInChunks( return lldb_private::IterationAction::Stop; } +if (current_addr != addr + total_bytes_read) { + LLDB_LOGF(log, +"Current addr is at expected address, 0x%" PRIx64 --

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
@@ -0,0 +1,130 @@ +""" +Test that saved memory regions is byte-wise 1:1 with the live process. Specifically +that the memory regions that will be populated in the Memory64List are the same byte for byte. +""" + +import os +import lldb +from lldbsuite.test.decorators import * +f

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
@@ -128,6 +133,26 @@ uint64_t SBSaveCoreOptions::GetCurrentSizeInBytes(SBError &error) { return *expected_bytes; } +lldb::SBMemoryRegionInfoList SBSaveCoreOptions::GetMemoryRegionsToSave() { + LLDB_INSTRUMENT_VA(this); + llvm::Expected memory_ranges = + m_opaque_up->

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
@@ -0,0 +1,130 @@ +""" +Test that saved memory regions is byte-wise 1:1 with the live process. Specifically +that the memory regions that will be populated in the Memory64List are the same byte for byte. +""" + +import os +import lldb +from lldbsuite.test.decorators import * +f

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
@@ -1130,9 +1122,9 @@ MinidumpFileBuilder::AddMemoryList_64(std::vector &ranges, // Capture the starting offset for all the descriptors so we can clean them up // if needed. offset_t starting_offset = - GetCurrentDataEndOffset() + sizeof(llvm::support::ulittle64_t)

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
@@ -964,6 +964,18 @@ Status PluginManager::SaveCore(const lldb::ProcessSP &process_sp, return error; } + // Set the process sp if not already set. + ProcessSP options_sp = options.GetProcess(); dmpots wrote: The name `options_sp` is a bit confusing t

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
https://github.com/dmpots commented: nit: Your link to minidump.py in the comment does not link to a python file, but just the scripts repo and I don't see that script in the repo. https://github.com/llvm/llvm-project/pull/146777 ___ lldb-commits mail

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread David Peixotto via lldb-commits
@@ -45,6 +45,10 @@ Note that currently ELF Core files are not supported." Resetting will result in the reset of all process specific options, such as Threads to save." ) lldb::SBSaveCoreOptions::SetProcess; +%feature("docstring", " +Get the process to save. If undefin

[Lldb-commits] [lldb] [llvm] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-16 Thread Abdullah Mohammad Amin via lldb-commits
UltimateForce21 wrote: > As high-level comments: > > * I would filter out the entry values, since this feature is meant to help a > user understand the disassembly, and the entry values don't really exist in > the function. > * It would help readability if all annotations started at the same c

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-16 Thread Alex Langford via lldb-commits
@@ -105,18 +78,30 @@ set_target_properties(liblldb-resource-headers PROPERTIES FOLDER "LLDB/Resources add_dependencies(liblldb-resource-headers liblldb-header-staging) add_dependencies(liblldb liblldb-resource-headers) +# Glob all necessary header files from source and place

[Lldb-commits] [lldb] [lldb] [cosmetic] Update help message of `(lldb) b` (PR #149114)

2025-07-16 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/149114 >From eccc519b1c465f3f77297e62dc5d1e7109327508 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Wed, 16 Jul 2025 08:10:05 -0700 Subject: [PATCH 1/2] [lldb] Update help message of `b` --- lldb/source/Interpreter/C

[Lldb-commits] [lldb] [lldb] [cosmetic] Update help message of `(lldb) b` (PR #149114)

2025-07-16 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/149114 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Allow returning multiple breakpoints in "stopped" event (PR #149133)

2025-07-16 Thread Jonas Devlieghere via lldb-commits
@@ -33,7 +33,7 @@ int main(int argc, char const *argv[]) { if (foo == nullptr) { fprintf(stderr, "%s\n", dlerror()); exit(2); - } + } // end of foo check JDevlieghere wrote: Ah, I missed that you were using that to set the breakpoint. In that case,

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::variant (PR #148554)

2025-07-16 Thread via lldb-commits
Nerixyz wrote: > Appreciate the effort to support both PDB _and_ DWARF, but I don't think we > should be jumping through hoops to support PDB when there is no bots running > the API tests for it. It's too easy for that to bit-rot. So I would suggest > dropping PDB support from this for now. M

[Lldb-commits] [lldb] [lldb][NFC] Small fixes identified by the clang static analyzer (PR #148773)

2025-07-16 Thread Jason Molenda via lldb-commits
@@ -2015,8 +2015,6 @@ llvm::Expected DWARFExpression::Evaluate( if (stack.size() < 1) { UpdateValueTypeFromLocationDescription(log, dwarf_cu, LocationDescriptionKind::Empty); -// Reset for the next piece. -

[Lldb-commits] [lldb] [lldb][NFC] Small fixes identified by the clang static analyzer (PR #148773)

2025-07-16 Thread Jason Molenda via lldb-commits
@@ -2015,8 +2015,6 @@ llvm::Expected DWARFExpression::Evaluate( if (stack.size() < 1) { UpdateValueTypeFromLocationDescription(log, dwarf_cu, LocationDescriptionKind::Empty); -// Reset for the next piece. -

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::variant (PR #148554)

2025-07-16 Thread David Spickett via lldb-commits
DavidSpickett wrote: What does running API tests with PDB look like? I assume Linaro is not doing that because we don't pass any extra flags, and often have to disable tests because link.exe is mangling the DWARF sections. Or put another way, @Nerixyz how do you make sure PDB is being used whe

[Lldb-commits] [lldb] [lldb-dap] Allow returning multiple breakpoints in "stopped" event (PR #149133)

2025-07-16 Thread Stephen Tozer via lldb-commits
https://github.com/SLTozer updated https://github.com/llvm/llvm-project/pull/149133 >From 773cff4106a9c28300847fcc9612ea25cc0cd44d Mon Sep 17 00:00:00 2001 From: Stephen Tozer Date: Wed, 16 Jul 2025 17:06:39 +0100 Subject: [PATCH 1/2] [lldb-dap] Allow returning multiple breakpoints in "stopped

[Lldb-commits] [lldb] [lldb-dap] Allow returning multiple breakpoints in "stopped" event (PR #149133)

2025-07-16 Thread Stephen Tozer via lldb-commits
https://github.com/SLTozer edited https://github.com/llvm/llvm-project/pull/149133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Allow returning multiple breakpoints in "stopped" event (PR #149133)

2025-07-16 Thread Stephen Tozer via lldb-commits
@@ -33,7 +33,7 @@ int main(int argc, char const *argv[]) { if (foo == nullptr) { fprintf(stderr, "%s\n", dlerror()); exit(2); - } + } // end of foo check SLTozer wrote: This comment is being used to set the breakpoint from [here](https://github.co

[Lldb-commits] [lldb] 9f364fe - [lldb][docs] Add section on testing with QEMU user (#149057)

2025-07-16 Thread via lldb-commits
Author: David Spickett Date: 2025-07-16T17:47:21+01:00 New Revision: 9f364fe9c446d498f46efff327871dc62db8212f URL: https://github.com/llvm/llvm-project/commit/9f364fe9c446d498f46efff327871dc62db8212f DIFF: https://github.com/llvm/llvm-project/commit/9f364fe9c446d498f46efff327871dc62db8212f.diff

[Lldb-commits] [lldb] [lldb-dap] Allow returning multiple breakpoints in "stopped" event (PR #149133)

2025-07-16 Thread Stephen Tozer via lldb-commits
@@ -173,6 +173,29 @@ def verify_breakpoint_hit(self, breakpoint_ids, timeout=DEFAULT_TIMEOUT): return self.assertTrue(False, f"breakpoint not hit, stopped_events={stopped_events}") +def verify_all_breakpoints_hit(self, breakpoint_ids, tim

[Lldb-commits] [lldb] [lldb][docs] Add section on testing with QEMU user (PR #149057)

2025-07-16 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/149057 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Document MCP tools & resources (PR #148708)

2025-07-16 Thread Jonas Devlieghere via lldb-commits
@@ -75,7 +75,69 @@ Configuration example for [Visual Studio Code](https://code.visualstudio.com/doc } ``` -### Troubleshooting +## Tools + +Tools are a primitive in the Model Context Protocol that enable servers to +expose functionality to clients. + +LLDB's MCP integration e

[Lldb-commits] [lldb] e8dc96d - [lldb] Document MCP tools & resources (#148708)

2025-07-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-16T09:31:43-07:00 New Revision: e8dc96d9de14c4b2317b11b8bc6e9310113697b3 URL: https://github.com/llvm/llvm-project/commit/e8dc96d9de14c4b2317b11b8bc6e9310113697b3 DIFF: https://github.com/llvm/llvm-project/commit/e8dc96d9de14c4b2317b11b8bc6e9310113697b3.d

[Lldb-commits] [lldb] [lldb-dap] Allow returning multiple breakpoints in "stopped" event (PR #149133)

2025-07-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py lldb

[Lldb-commits] [lldb] [lldb] Always compute the execution & symbol context (PR #148994)

2025-07-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/148994 >From ee116a937d165f4862aae34206d112682b8ce0ee Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 15 Jul 2025 16:54:05 -0700 Subject: [PATCH] [lldb] Always compute the execution & symbol context A

[Lldb-commits] [lldb] [lldb-dap] Allow returning multiple breakpoints in "stopped" event (PR #149133)

2025-07-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Stephen Tozer (SLTozer) Changes Currently, the "stopped" event returned when a breakpoint is hit will always return only the ID of first breakpoint returned from `GetStopReasonDataAtIndex`. This is slightly different from the behaviour in

[Lldb-commits] [lldb] [lldb-dap] Allow returning multiple breakpoints in "stopped" event (PR #149133)

2025-07-16 Thread Stephen Tozer via lldb-commits
https://github.com/SLTozer created https://github.com/llvm/llvm-project/pull/149133 Currently, the "stopped" event returned when a breakpoint is hit will always return only the ID of first breakpoint returned from `GetStopReasonDataAtIndex`. This is slightly different from the behaviour in `l

[Lldb-commits] [lldb] [lldb] [cosmetic] Update help message of `(lldb) b` (PR #149114)

2025-07-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: [begin bikeshedding] How about something like this: >Set a breakpoint using one of several shorthand formats, or list the existing >breakpoints if no arguments are provided. Expects 'raw' input (see 'help >raw-input'.) My reasoning is that it describes the more common use

[Lldb-commits] [lldb] [lldb] Document MCP tools & resources (PR #148708)

2025-07-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Also, the server made it into 21.x but the docs obviously didn't and there's > no release note for it. Is it complete "enough" to cherry-pick this and add a > release note? I will add a release note and create a back port request. Do you think it's worth cherrypicking th

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::variant (PR #148554)

2025-07-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: Appreciate the effort to support both PDB *and* DWARF, but I don't think we should be jumping through hoops to support PDB when there is no bots running the API tests for it. It's too easy for that to bit-rot. So I would suggest dropping PDB support fro

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::variant (PR #148554)

2025-07-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes Adds a summary and synthetic children for MSVC STL's `std::variant`. This one is a bit complicated because of DWARF vs PDB differences. I put the representations in comments. Being able to `GetChildMemberWithName` a

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::variant (PR #148554)

2025-07-16 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/148554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::variant (PR #148554)

2025-07-16 Thread via lldb-commits
https://github.com/Nerixyz ready_for_review https://github.com/llvm/llvm-project/pull/148554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [cosmetic] Update help message of `(lldb) b` (PR #149114)

2025-07-16 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/149114 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update help message of `(lldb) b` (PR #149114)

2025-07-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (royitaqi) Changes `(lldb) b` can be used in two different ways: 1. Running `b` without arguments, it lists all existing breakpoints. 2. Running `b` with additional arguments, it adds breakpoints. However, the help message doesn't ment

[Lldb-commits] [lldb] [lldb] Update help message of `(lldb) b` (PR #149114)

2025-07-16 Thread via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/149114 `(lldb) b` can be used in two different ways: 1. Running `b` without arguments, it lists all existing breakpoints. 2. Running `b` with additional arguments, it adds breakpoints. However, the help message doesn'

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::variant (PR #148554)

2025-07-16 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/148554 >From 2ae71bc96e19575037e7e200f317e714f79bcd98 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Mon, 14 Jul 2025 00:30:48 +0200 Subject: [PATCH] [LLDB] Add formatters for MSVC STL std::variant --- .../Plugins/Lang

[Lldb-commits] [lldb] [lldb][SBType] GetBasicType to unwrap canonical type (PR #149112)

2025-07-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149112 >From c14caf77cd3fbb0d4d94a9e34122bc75eb07dfb8 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 16 Jul 2025 16:01:30 +0100 Subject: [PATCH 1/3] [lldb][SBType] GetBasicType to unwrap canonical type `SBT

[Lldb-commits] [lldb] [lldb][SBType] GetBasicType to unwrap canonical type (PR #149112)

2025-07-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149112 >From c14caf77cd3fbb0d4d94a9e34122bc75eb07dfb8 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 16 Jul 2025 16:01:30 +0100 Subject: [PATCH 1/2] [lldb][SBType] GetBasicType to unwrap canonical type `SBT

[Lldb-commits] [lldb] [lldb][SBType] GetBasicType to unwrap canonical type (PR #149112)

2025-07-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes `SBType::GetBasicType` fails on typedefs to primitive types. The docs for `GetBasicType` state: ``` Returns the BasicType value that is most appropriate to this type ``` But, e.g., for `uint64_t` this would

[Lldb-commits] [lldb] [lldb][SBType] GetBasicType to unwrap canonical type (PR #149112)

2025-07-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/149112 `SBType::GetBasicType` fails on typedefs to primitive types. The docs for `GetBasicType` state: ``` Returns the BasicType value that is most appropriate to this type ``` But, e.g., for `uint64_t` this would c

[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

2025-07-16 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/148736 >From 577cc56f48f8cbaba3c1af4a153cbd3be2216246 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 14 Jul 2025 16:58:23 -0500 Subject: [PATCH] [lldb][framework] Glob headers from source for framewo

[Lldb-commits] [lldb] [lldb] Fix a crash in lldb-server during RemoveSoftwareBreakpoint() (PR #148738)

2025-07-16 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/148738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a13712e - [lldb] Fix a crash in lldb-server during RemoveSoftwareBreakpoint() (#148738)

2025-07-16 Thread via lldb-commits
Author: royitaqi Date: 2025-07-16T07:57:13-07:00 New Revision: a13712ed88cf6fc37d3789d4c3b54ffdd1a05a1d URL: https://github.com/llvm/llvm-project/commit/a13712ed88cf6fc37d3789d4c3b54ffdd1a05a1d DIFF: https://github.com/llvm/llvm-project/commit/a13712ed88cf6fc37d3789d4c3b54ffdd1a05a1d.diff LOG:

[Lldb-commits] [lldb] [lldb] Document MCP tools & resources (PR #148708)

2025-07-16 Thread David Spickett via lldb-commits
DavidSpickett wrote: Also, the server made it into 21.x but the docs obviously didn't and there's no release note for it. Is it complete "enough" to cherry-pick this and add a release note? https://github.com/llvm/llvm-project/pull/148708 ___ lldb-co

[Lldb-commits] [lldb] [lldb] Document MCP tools & resources (PR #148708)

2025-07-16 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM with whatever is the correct thing to document for debugger IDs. https://github.com/llvm/llvm-project/pull/148708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb][docs] Add section on testing with QEMU user (PR #149057)

2025-07-16 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/149057 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Add section on testing with QEMU user (PR #149057)

2025-07-16 Thread David Spickett via lldb-commits
@@ -167,3 +167,49 @@ The result of this is that: Your VM configuration should have ports ``54321`` and ``49140`` forwarded for this to work. + +QEMU user mode emulation + + +Serious testing of LLDB should be done using system mode emulation. The follow

[Lldb-commits] [lldb] [lldb][docs] Add section on testing with QEMU user (PR #149057)

2025-07-16 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/149057 >From eab94453a4275cdbc5fe60607fb18a7869a2d3a8 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 16 Jul 2025 10:20:59 + Subject: [PATCH 1/2] [lldb][docs] Add section on testing with QEMU user T

[Lldb-commits] [lldb] [llvm] [LLDB] Switch to using DIL as default implementation for 'frame var'. (PR #147887)

2025-07-16 Thread via lldb-commits
cmtice wrote: > Perhaps with a release note saying this happened and how to switch back to > the non-default way? This PR updates the release notes; is that not good enough? https://github.com/llvm/llvm-project/pull/147887 ___ lldb-commits mailing li

[Lldb-commits] [lldb] [lldb][docs] Add section on testing with QEMU user (PR #149057)

2025-07-16 Thread Pavel Labath via lldb-commits
@@ -167,3 +167,49 @@ The result of this is that: Your VM configuration should have ports ``54321`` and ``49140`` forwarded for this to work. + +QEMU user mode emulation + + +Serious testing of LLDB should be done using system mode emulation. The follow

[Lldb-commits] [lldb] [lldb][docs] Add section on testing with QEMU user (PR #149057)

2025-07-16 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/149057 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-16 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: As high-level comments: - I would filter out the entry values, since this feature is meant to help a user understand the disassembly, and the entry values don't really exist in the function. - It would help readability if all annotations started at the same column - in a fo

[Lldb-commits] [lldb] 88a498c - [LLDB] Add formatters for MSVC STL std::(forward_)list (#148285)

2025-07-16 Thread via lldb-commits
Author: nerix Date: 2025-07-16T14:00:18+01:00 New Revision: 88a498c3b110b73c10362df8c18ca13fe1873744 URL: https://github.com/llvm/llvm-project/commit/88a498c3b110b73c10362df8c18ca13fe1873744 DIFF: https://github.com/llvm/llvm-project/commit/88a498c3b110b73c10362df8c18ca13fe1873744.diff LOG: [L

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::(forward_)list (PR #148285)

2025-07-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/148285 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-16 Thread Adrian Prantl via lldb-commits
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t max_opcode_byte_size, ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' '); ss.PutCString(mnemonics); + const size_t annotation_column = 150; + + if (exe_ctx && exe_ctx->GetFramePtr(

[Lldb-commits] [lldb] [llvm] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-16 Thread Adrian Prantl via lldb-commits
@@ -158,6 +158,7 @@ class DWARFExpression { } void DumpLocation(Stream *s, lldb::DescriptionLevel level, ABI *abi) const; + void DumpLocationWithOptions(Stream *s, lldb::DescriptionLevel level, ABI *abi, llvm::DIDumpOptions options) const; adrian-prantl

[Lldb-commits] [lldb] [llvm] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-16 Thread Adrian Prantl via lldb-commits
@@ -53,6 +54,37 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t func_load_addr, return GetExpressionAtAddress(func_load_addr, addr) != nullptr; } +std::optional +DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr, +

[Lldb-commits] [lldb] [llvm] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-16 Thread Adrian Prantl via lldb-commits
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t max_opcode_byte_size, ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' '); ss.PutCString(mnemonics); + const size_t annotation_column = 150; + + if (exe_ctx && exe_ctx->GetFramePtr(

[Lldb-commits] [lldb] [llvm] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-16 Thread Adrian Prantl via lldb-commits
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t max_opcode_byte_size, ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' '); ss.PutCString(mnemonics); + const size_t annotation_column = 150; + + if (exe_ctx && exe_ctx->GetFramePtr(

[Lldb-commits] [lldb] [llvm] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-16 Thread Adrian Prantl via lldb-commits
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t max_opcode_byte_size, ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' '); ss.PutCString(mnemonics); + const size_t annotation_column = 150; + + if (exe_ctx && exe_ctx->GetFramePtr(

[Lldb-commits] [lldb] [llvm] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-16 Thread Adrian Prantl via lldb-commits
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t max_opcode_byte_size, ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' '); ss.PutCString(mnemonics); + const size_t annotation_column = 150; + + if (exe_ctx && exe_ctx->GetFramePtr(

[Lldb-commits] [lldb] [llvm] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-16 Thread Adrian Prantl via lldb-commits
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t max_opcode_byte_size, ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' '); ss.PutCString(mnemonics); + const size_t annotation_column = 150; + + if (exe_ctx && exe_ctx->GetFramePtr(

[Lldb-commits] [lldb] [lldb] Print children-count warning for dwim-print and expr (PR #149088)

2025-07-16 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/149088 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print children-count warning for dwim-print and expr (PR #149088)

2025-07-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes When dumping variables, LLDB will print a one-time warning about truncating children (when the children count exceeds the default `target.max-children-count`). But we only do this for `frame variable`. So

[Lldb-commits] [lldb] [lldb] Print children-count warning for dwim-print and expr (PR #149088)

2025-07-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149088 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print children-count warning for DWIM-print and expr (PR #149088)

2025-07-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149088 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print child-depth warning for DWIM-print and expr (PR #149088)

2025-07-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/149088 When dumping variables, LLDB will print a one-time warning about truncating children (when the children count exceeds the default `target.max-children-count`). But we only do this for `frame variable`. So if

[Lldb-commits] [lldb] [DRAFT] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-16 Thread Michael Buch via lldb-commits
@@ -249,6 +250,41 @@ static unsigned GetCXXMethodCVQuals(const DWARFDIE &subprogram, return cv_quals; } +// TODO: +// 0. Adjust FindInSymbols +// 1. log failure paths +// 2. What happens for functions without a linkage name? Previously we didn't +// attach a label for those

[Lldb-commits] [lldb] [llvm] [LLDB] Switch to using DIL as default implementation for 'frame var'. (PR #147887)

2025-07-16 Thread David Spickett via lldb-commits
DavidSpickett wrote: Perhaps with a release note saying this happened and how to switch back to the non-default way? https://github.com/llvm/llvm-project/pull/147887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [lldb][docs] Add section on testing with QEMU user (PR #149057)

2025-07-16 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/149057 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Add section on testing with QEMU user (PR #149057)

2025-07-16 Thread David Spickett via lldb-commits
DavidSpickett wrote: Hopefully there are enough "here be dragons, fighting them is your problem" in the text. WASM runtimes is another class of simulator I was thinking of in future. I know we don't have support for that yet but if that one PR ever gets revived, it might be a thing. So I'm le

[Lldb-commits] [lldb] [lldb][docs] Add section on testing with QEMU user (PR #149057)

2025-07-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This is not recommended to basically anyone but on occasion it's useful and could be used for testing with other simulator programs for example bare metal simulators. Adding this is also an excuse to

[Lldb-commits] [lldb] [lldb][docs] Add section on testing with QEMU user (PR #149057)

2025-07-16 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/149057 This is not recommended to basically anyone but on occasion it's useful and could be used for testing with other simulator programs for example bare metal simulators. Adding this is also an excuse to doc

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::(forward_)list (PR #148285)

2025-07-16 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/148285 >From a341b83b07f8ccb50036b2ab09c29d1c5946bd19 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Fri, 11 Jul 2025 22:06:47 +0200 Subject: [PATCH 1/3] [LLDB] Add formatters for MSVC STL std::(forward_)list --- lldb/

[Lldb-commits] [lldb] [lldb][NFC] Small fixes identified by the clang static analyzer (PR #148773)

2025-07-16 Thread Michael Buch via lldb-commits
@@ -2015,8 +2015,6 @@ llvm::Expected DWARFExpression::Evaluate( if (stack.size() < 1) { UpdateValueTypeFromLocationDescription(log, dwarf_cu, LocationDescriptionKind::Empty); -// Reset for the next piece. -

[Lldb-commits] [lldb] [LLDB] Convert libstdc++ std::variant summary to C++ (PR #148929)

2025-07-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/148929 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f98cf07 - [LLDB] Convert libstdc++ std::variant summary to C++ (#148929)

2025-07-16 Thread via lldb-commits
Author: nerix Date: 2025-07-16T10:07:45+01:00 New Revision: f98cf07b7dc7af7716e1da9a1257b8c6416f9a46 URL: https://github.com/llvm/llvm-project/commit/f98cf07b7dc7af7716e1da9a1257b8c6416f9a46 DIFF: https://github.com/llvm/llvm-project/commit/f98cf07b7dc7af7716e1da9a1257b8c6416f9a46.diff LOG: [L

[Lldb-commits] [lldb] [LLDB] Convert libstdc++ std::variant summary to C++ (PR #148929)

2025-07-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/148929 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >