labath wrote:
You should be able to extend the unit test in
unittests/Host/NativeProcessProtocolTest.cpp to cover this scenario.
https://github.com/llvm/llvm-project/pull/148738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
https://github.com/labath approved this pull request.
:crossed_fingers:
https://github.com/llvm/llvm-project/pull/147887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (qxy11)
Changes
Summary:
There was a deadlock was introduced by [PR #146441](https://github.com/llvm/llvm-project/pull/146441) which changed
`CurrentThreadIsPrivateStateThread()` to
`CurrentThreadPosesAsPrivateStateThread()`. This cha
https://github.com/qxy11 created
https://github.com/llvm/llvm-project/pull/148774
Summary:
There was a deadlock was introduced by [PR
#146441](https://github.com/llvm/llvm-project/pull/146441) which changed
`CurrentThreadIsPrivateStateThread()` to
`CurrentThreadPosesAsPrivateStateThread()`. T
Author: tedwoodward
Date: 2025-07-14T21:50:22-05:00
New Revision: eb6da944af31dd684be3ab2f93f453a3837a72c6
URL:
https://github.com/llvm/llvm-project/commit/eb6da944af31dd684be3ab2f93f453a3837a72c6
DIFF:
https://github.com/llvm/llvm-project/commit/eb6da944af31dd684be3ab2f93f453a3837a72c6.diff
L
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/146777
>From d17473cc32acb31935759012ca87342d750d68f7 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 2 Jul 2025 09:18:59 -0700
Subject: [PATCH 01/14] Fix logs, prevent accidentally printing a partial read
whe
https://github.com/satyajanga updated
https://github.com/llvm/llvm-project/pull/148735
>From d6c8504e344f46fbcbc77ec19f25a540fc85462e Mon Sep 17 00:00:00 2001
From: Jeffrey Tan
Date: Wed, 21 Jul 2021 13:32:56 -0700
Subject: [PATCH] Add new "target module replace" command
Summary:
For dump debu
https://github.com/cmtice created
https://github.com/llvm/llvm-project/pull/148732
** DO NOT REVIEW! DO NOT MERGE/COMMIT! **
This draft PR is purely for testing purposes; it is not meant to be shared,
reviewed or merged.
>From 6b39d4a0de969f18514e80fb5d11cd50f22b7526 Mon Sep 17 00:00:00 2001
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Add documentation for the tools and resources exposed by LLDB's MCP server.
---
Full diff: https://github.com/llvm/llvm-project/pull/148708.diff
1 Files Affected:
- (modified) lldb/docs/use/mcp.md
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/148708
Add documentation for the tools and resources exposed by LLDB's MCP server.
>From cde479affc82c6964e6471315179aaab58b3fd6a Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 14 Jul 2025 12:18:02 -
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Buch (Michael137)
Changes
When an LLDB user asks for the value of a static data member, LLDB starts by
searching the Names accelerator table for the corresponding variable definition
DIE. For static data members with out-of-class de
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
Author: Michael Buch (Michael137)
Changes
When an LLDB user asks for the value of a static data member, LLDB starts by
searching the Names accelerator table for the corresponding variable definition
DIE. For static data members with out-of-clas
@@ -737,6 +738,11 @@ class LLDB_API SBTarget {
lldb::SBBreakpoint BreakpointCreateBySBAddress(SBAddress &address);
+ lldb::SBBreakpoint
+ BreakpointCreateByFileAddress(const SBFileSpec &file_spec, addr_t file_addr,
+addr_t offset = 0,
+
https://github.com/jimingham requested changes to this pull request.
The proposed new breakpoint setting API doesn't make sense to me.
https://github.com/llvm/llvm-project/pull/148061
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
jimingham wrote:
I don't understand what this address plus address offset breakpoint type is
supposed to be?
We have "address plus offset" already - where the initial address is a Section
Offset - that's what Address-es are. Addresses are very handy for address
breakpoint setting because t
https://github.com/clayborg requested changes to this pull request.
Make the process subclasses that save core files use the
`llvm::Expected GetMemoryRegionsToSave();`
from `SaveCoreOptions`. This will ensure everyone is using the same list.
https://github.com/llvm/llvm-project/pull/146777
___
https://github.com/clayborg requested changes to this pull request.
Remove flags from all APIs. Enable 64 bit for any non stack memory regions to
allow us to test the 64 bit memory regions all of the time.
https://github.com/llvm/llvm-project/pull/146777
___
https://github.com/ldionne approved this pull request.
LGTM for the libc++ bit
https://github.com/llvm/llvm-project/pull/143653
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/148691
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> On other platforms, exceptions are enabled as well.
I don't believe that's accurate. By default, LLVM builds without exceptions.
There's `LLVM_ENABLE_EH` to override that behavior [1]:
> LLVM_ENABLE_EH:BOOL
> Build LLVM with exception-handling support. This is necessary i
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: nerix (Nerixyz)
Changes
>From #148554 - compile tests with exceptions on Windows
>(`-fno-exceptions` was added 11 years ago in
>c7826524acda6a9c8816261d5c48b94dc92935ed). The variant test uses `try {} catch
>{}` to create variants that ar
https://github.com/Nerixyz created
https://github.com/llvm/llvm-project/pull/148691
>From #148554 - compile tests with exceptions on Windows (`-fno-exceptions` was
>added 11 years ago in c7826524acda6a9c8816261d5c48b94dc92935ed). The variant
>test uses `try {} catch {}` to create variants that
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/148548
>From 90ff1a307319680048b0f5674ea15a300ab6bf50 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Sun, 13 Jul 2025 22:46:23 +0200
Subject: [PATCH] [LLDB] Add formatters for MSVC STL std::tuple
---
.../Plugins/Langua
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
lldb/source/Plugins/Language/CPlusPlus/MsvcStlTuple
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/148548
>From d8983cbdd12b9c3b7730e9a42960705f89eecc7b Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Sun, 13 Jul 2025 22:46:23 +0200
Subject: [PATCH] [LLDB] Add formatters for MSVC STL std::tuple
---
.../Plugins/Langua
https://github.com/tedwoodward updated
https://github.com/llvm/llvm-project/pull/145793
>From 1a7ee4297bb8e6b3fa08818e05cf245a2c768c2b Mon Sep 17 00:00:00 2001
From: Ted Woodward
Date: Wed, 25 Jun 2025 14:22:28 -0700
Subject: [PATCH 01/10] Support disassembling RISC-V proprietary insns
RISC-V
tedwoodward wrote:
> Please fix the formatting before landing -
> https://github.com/llvm/llvm-project/actions/runs/16232166455/job/45836933279?pr=145793.
I disagree with the Python formatting here. It doesn't need to indent inside a
`"""` comment string; it's not Python code. And other exampl
https://github.com/tedwoodward updated
https://github.com/llvm/llvm-project/pull/145793
>From 1a7ee4297bb8e6b3fa08818e05cf245a2c768c2b Mon Sep 17 00:00:00 2001
From: Ted Woodward
Date: Wed, 25 Jun 2025 14:22:28 -0700
Subject: [PATCH 1/9] Support disassembling RISC-V proprietary insns
RISC-V su
cmtice wrote:
> I gave this patch a spin on a mac. The only failure I got was in
> test/Shell/SymbolFile/DWARF/TestDedupWarnings.test, which fails it does not
> generate both of the warnings, and that's because the "p" (aka dwim-print)
> now resolves to "frame var" instead of expr". Changing t
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/147887
>From 3dbe09deb36a44eb056fa2d3d7dacd341e391697 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Wed, 9 Jul 2025 20:42:03 -0700
Subject: [PATCH 1/4] [LLDB] Switch to using DIL as default implementation for
'fra
@@ -1,8 +1,3 @@
-// Evil hack: To simulate memory corruption, we want to fiddle with some
internals of std::list.
Michael137 wrote:
Would be nice to fix the test to cover cycle detection. Happy to do that in a
separate PR though. Since this is already how this
Michael137 wrote:
All that being said, i think we can defer the questions about capping list
size, etc. until after this lands. Since this just mimicks what libc++ already
does
https://github.com/llvm/llvm-project/pull/148285
___
lldb-commits mailing
Michael137 wrote:
> > Side-note, I'm also a bit wary of all the cycle-detection stuff. Might be a
> > remnant of protection against old libcxx bugs? We don't really do this
> > stuff for other libcxx containers.
>
> We don't do that for other containers, but it's not really as acute there.
>
jansvoboda11 wrote:
Ping.
https://github.com/llvm/llvm-project/pull/146422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
I somehow think we shouldn't add this kind of heuristics in LLDB and instead
add them in the VSCode extension at a per-language basis. Some language, like
Mojo, allow you to write variables with potentially any character sequences,
and they have different characters to
@@ -1,8 +1,3 @@
-// Evil hack: To simulate memory corruption, we want to fiddle with some
internals of std::list.
labath wrote:
It looks like this test doesn't actually circularize the list anymore, so you
might as well delete it completely. Alternatively, we c
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/148285
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
> Side-note, I'm also a bit wary of all the cycle-detection stuff. Might be a
> remnant of protection against old libcxx bugs? We don't really do this stuff
> for other libcxx containers.
We don't do that for other containers, but it's not really as acute
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian`
running on `lldb-x86_64-debian` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/162/builds/26741
Here is the relevant piece of the build log
Author: Michael Buch
Date: 2025-07-14T11:46:18+01:00
New Revision: fa143619b1e9831e750ff74900b424a3b33c352e
URL:
https://github.com/llvm/llvm-project/commit/fa143619b1e9831e750ff74900b424a3b33c352e
DIFF:
https://github.com/llvm/llvm-project/commit/fa143619b1e9831e750ff74900b424a3b33c352e.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/148600
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: nerix
Date: 2025-07-14T11:18:43+01:00
New Revision: da68e72b1bd1c2e6a38b42c49941b3541e1b9a67
URL:
https://github.com/llvm/llvm-project/commit/da68e72b1bd1c2e6a38b42c49941b3541e1b9a67
DIFF:
https://github.com/llvm/llvm-project/commit/da68e72b1bd1c2e6a38b42c49941b3541e1b9a67.diff
LOG: [L
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/148248
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/148248
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> The implementation makes it hard to detect if the empty tuple is from this
> STL. Fortunately, libstdc++'s synthetic children provider works for empty
> MSVC STL tuples as well.
This is why i wish we had something definitive in debug-info to tell us what
STL a compile-unit
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/148548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/148600
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Ran my python script from
https://github.com/llvm/llvm-project/pull/97043 over the repo again and there
was 1 duplicate test-case that has been introduced since I last did this.
This patch renames that tes
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/148600
Ran my python script from
https://github.com/llvm/llvm-project/pull/97043 over the repo again and there
was 1 duplicate test-case that has been introduced since I last did this.
This patch renames that test.
https://github.com/Michael137 commented:
I'm in two minds about generic formatters. It does make the implementation
harder to follow. And is fragile to refactorings of the corresponding STL.
In this case it might be OK since you already did all the work to do so.
Side-note, I'm also a bit wary
https://github.com/DhruvSrivastavaX closed
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Hemang Gadhavi
Date: 2025-07-14T15:25:45+05:30
New Revision: 0a357e92ca3ebfd68710b58413cac21e2cb9d8ad
URL:
https://github.com/llvm/llvm-project/commit/0a357e92ca3ebfd68710b58413cac21e2cb9d8ad
DIFF:
https://github.com/llvm/llvm-project/commit/0a357e92ca3ebfd68710b58413cac21e2cb9d8ad.diff
@@ -84,3 +84,100 @@ TEST(DWARF64UnitTest, DWARF64DebugInfoAndCU) {
ASSERT_TRUE(declaration.IsValid());
ASSERT_EQ(declaration.Tag(), DW_TAG_subprogram);
}
+
+TEST(DWARF64UnitTest, DWARF5StrTable) {
+ const char *yamldata = R"(
+--- !ELF
+FileHeader:
+ Class: ELFCLASS64
+
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/147054
>From 4ae4d0ab6ba44317e00dced8f247341ec9930c2c Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Fri, 4 Jul 2025 09:28:30 -0400
Subject: [PATCH 1/3] [lldb] Updated the String table offset based on the DWA
https://github.com/DavidSpickett approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
I gave this patch a spin on a mac. The only failure I got was in
test/Shell/SymbolFile/DWARF/TestDedupWarnings.test, which fails it does not
generate both of the warnings, and that's because the "p" (aka dwim-print) now
resolves to "frame var" instead of expr". Changing the test
DavidSpickett wrote:
Please fix the formatting before landing -
https://github.com/llvm/llvm-project/actions/runs/16232166455/job/45836933279?pr=145793.
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -90,3 +91,64 @@ TEST_F(TestMCDisasmInstanceRISCV, TestRISCV32Instruction) {
EXPECT_FALSE(inst_sp->IsCall());
EXPECT_TRUE(inst_sp->DoesBranch());
}
+
+TEST_F(TestMCDisasmInstanceRISCV, TestOpcodeBytePrinter) {
+ ArchSpec arch("riscv32-*-linux");
+
+ const unsigned num_o
@@ -304,6 +304,10 @@ Changes to LLDB
stop reason = SIGSEGV: sent by tkill system call (sender pid=649752,
uid=2667987)
```
* ELF Cores can now have their siginfo structures inspected using `thread
siginfo`.
+* Disassembly of unknown instructions now produces "" instead
@@ -7,127 +7,80 @@
//===--===//
#include "lldb/Host/JSONTransport.h"
-#include "lldb/Utility/IOObject.h"
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Log.h"
-#include "lldb/Utility/SelectHelper.
@@ -7,163 +7,122 @@
//===--===//
#include "lldb/Host/JSONTransport.h"
-#include "lldb/Utility/IOObject.h"
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Log.h"
-#include "lldb/Utility/SelectHelper
@@ -7,163 +7,122 @@
//===--===//
#include "lldb/Host/JSONTransport.h"
-#include "lldb/Utility/IOObject.h"
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Log.h"
-#include "lldb/Utility/SelectHelper
@@ -56,40 +84,88 @@ bool fromJSON(const llvm::json::Value &V, JSONTestType &T,
llvm::json::Path P) {
} // namespace
TEST_F(HTTPDelimitedJSONTransportTest, MalformedRequests) {
- std::string malformed_header = "COnTent-LenGth: -1{}\r\n\r\nnotjosn";
+ std::string malformed_he
@@ -7,163 +7,122 @@
//===--===//
#include "lldb/Host/JSONTransport.h"
-#include "lldb/Utility/IOObject.h"
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Log.h"
-#include "lldb/Utility/SelectHelper
@@ -7,163 +7,122 @@
//===--===//
#include "lldb/Host/JSONTransport.h"
-#include "lldb/Utility/IOObject.h"
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Log.h"
-#include "lldb/Utility/SelectHelper
@@ -22,8 +23,28 @@ class TransportBase : public PipePairTest {
protected:
std::unique_ptr to_dap;
std::unique_ptr from_dap;
+ lldb_private::MainLoop loop;
void SetUp() override;
+
+ template
+ void
+ RunOnce(std::function)> callback,
+ std::chrono::millis
@@ -7,163 +7,122 @@
//===--===//
#include "lldb/Host/JSONTransport.h"
-#include "lldb/Utility/IOObject.h"
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Log.h"
-#include "lldb/Utility/SelectHelper
@@ -737,6 +738,11 @@ class LLDB_API SBTarget {
lldb::SBBreakpoint BreakpointCreateBySBAddress(SBAddress &address);
+ lldb::SBBreakpoint
+ BreakpointCreateByFileAddress(const SBFileSpec &file_spec, addr_t file_addr,
+addr_t offset = 0,
+
@@ -84,3 +84,100 @@ TEST(DWARF64UnitTest, DWARF64DebugInfoAndCU) {
ASSERT_TRUE(declaration.IsValid());
ASSERT_EQ(declaration.Tag(), DW_TAG_subprogram);
}
+
+TEST(DWARF64UnitTest, DWARF5StrTable) {
+ const char *yamldata = R"(
+--- !ELF
+FileHeader:
+ Class: ELFCLASS64
+
https://github.com/labath approved this pull request.
Cool. Thanks.
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
72 matches
Mail list logo
