[Lldb-commits] [lldb] [llvm] [LLDB] Switch to using DIL as default implementation for 'frame var'. (PR #147887)

2025-07-11 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/147887 >From 3dbe09deb36a44eb056fa2d3d7dacd341e391697 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Wed, 9 Jul 2025 20:42:03 -0700 Subject: [PATCH 1/3] [LLDB] Switch to using DIL as default implementation for 'fra

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/148075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3c4c2fa - [lldb] Expose debuggers and target as resources through MCP (#148075)

2025-07-11 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-11T15:49:27-07:00 New Revision: 3c4c2fada26f479be7c2f9744f5b7364f7612446 URL: https://github.com/llvm/llvm-project/commit/3c4c2fada26f479be7c2f9744f5b7364f7612446 DIFF: https://github.com/llvm/llvm-project/commit/3c4c2fada26f479be7c2f9744f5b7364f7612446.d

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-07-11 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/148300 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-07-11 Thread John Harrison via lldb-commits
@@ -949,75 +952,76 @@ static std::optional getArgumentsIfRequest(const Message &pm, return args; } -llvm::Error DAP::Loop() { - // Can't use \a std::future because it doesn't compile on - // Windows. - std::future queue_reader = - std::async(std::launch::async, [&](

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add Disassembler log channel (PR #148290)

2025-07-11 Thread via lldb-commits
github-actions[bot] wrote: @agontarek Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a buil

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add Disassembler log channel (PR #148290)

2025-07-11 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/148290 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9e90788 - [LLDB][NVIDIA] Add Disassembler log channel (#148290)

2025-07-11 Thread via lldb-commits
Author: Andrew Gontarek Date: 2025-07-11T13:49:34-07:00 New Revision: 9e90788a3ea776f6ba8baa2de30fb8845ac1916f URL: https://github.com/llvm/llvm-project/commit/9e90788a3ea776f6ba8baa2de30fb8845ac1916f DIFF: https://github.com/llvm/llvm-project/commit/9e90788a3ea776f6ba8baa2de30fb8845ac1916f.dif

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add Disassembler log channel (PR #148290)

2025-07-11 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/148290 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add Disassembler log channel (PR #148290)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/148290 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add Disassembler log channel (PR #148290)

2025-07-11 Thread Andrew Gontarek via lldb-commits
https://github.com/agontarek updated https://github.com/llvm/llvm-project/pull/148290 >From a5e8c92d9f07f6465ddf1d71ed92b0394f6e4804 Mon Sep 17 00:00:00 2001 From: Andrew Gontarek Date: Fri, 11 Jul 2025 13:17:56 -0700 Subject: [PATCH 1/2] [LLDB][NVIDIA] Add Disassembler log channel This commit

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I think both are true. When using an IDE with LSP support, the doxygen comments can be quite helpful and they're easier to keep up to date compared to a separate design document. I've reduced the verbosity further and now almost all comments are a single line. https://gith

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/147621 >From 337a7e43efcab08061ca6a5a0bd05547d783c63c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 11 Jul 2025 13:33:53 -0700 Subject: [PATCH] [lldb] Document the SBDebugger public interface Despit

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add Disassembler log channel (PR #148290)

2025-07-11 Thread Greg Clayton via lldb-commits
@@ -49,6 +49,7 @@ enum class LLDBLog : Log::MaskType { Watchpoints = Log::ChannelFlag<30>, OnDemand = Log::ChannelFlag<31>, Source = Log::ChannelFlag<32>, + Disassembler = Log::ChannelFlag<33>, LLVM_MARK_AS_BITMASK_ENUM(OnDemand), clayborg wrote: I t

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add Disassembler log channel (PR #148290)

2025-07-11 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/148290 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add Disassembler log channel (PR #148290)

2025-07-11 Thread Greg Clayton via lldb-commits
@@ -1146,7 +1146,7 @@ class InstructionLLVMC : public lldb_private::Instruction { } } -if (Log *log = GetLog(LLDBLog::Process)) { +if (Log *log = GetLog(LLDBLog::Disassembler)) { clayborg wrote: We do have the option to specify multiple fla

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add Disassembler log channel (PR #148290)

2025-07-11 Thread Andrew Gontarek via lldb-commits
agontarek wrote: Tagging @clayborg @walter-erquinigo for review. https://github.com/llvm/llvm-project/pull/148290 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add Disassembler log channel (PR #148290)

2025-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Andrew Gontarek (agontarek) Changes This commit introduces a new log channel for the disassembler in LLDB, allowing for better logging of disassembler related activities. The `LLDBLOG` enum has been updated to include the `Disassembler` ch

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add Disassembler log channel (PR #148290)

2025-07-11 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add Disassembler log channel (PR #148290)

2025-07-11 Thread Andrew Gontarek via lldb-commits
https://github.com/agontarek created https://github.com/llvm/llvm-project/pull/148290 This commit introduces a new log channel for the disassembler in LLDB, allowing for better logging of disassembler related activities. The `LLDBLOG` enum has been updated to include the `Disassembler` channel

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::(forward_)list (PR #148285)

2025-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes Adds synthetic providers for MSVC's `std::forward_list` and `std::list`. It refactors `LibCxxList` to be generic over the STL type (currently libc++ or MSVC STL). The libstdc++ synthetic providers use something simi

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::(forward_)list (PR #148285)

2025-07-11 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/148285 Adds synthetic providers for MSVC's `std::forward_list` and `std::list`. It refactors `LibCxxList` to be generic over the STL type (currently libc++ or MSVC STL). The libstdc++ synthetic providers use something

[Lldb-commits] [lldb] [lldb-dap] persistent assembly breakpoints (PR #148061)

2025-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) Changes - Adds data to breakpoints `Source` object, in order for assembly breakpoints, which rely on a temporary `sourceReference` value, to be able to resolve in future sessions like normal path+line breakpoints - Add

[Lldb-commits] [lldb] [llvm] [lldb] Support disassembling RISC-V proprietary instructions (PR #145793)

2025-07-11 Thread Sam Elliott via lldb-commits
lenary wrote: > We don't have any big endian riscv ArchSpec entry today or I'd add a big > endian riscv instruction decoding test too. We're starting to get Big Endian support for RISC-V in LLVM, but I've asked that those patches wait until after the branch as there's a lot of work to make bi

[Lldb-commits] [libcxx] [lldb] [libcxx] adds size-based `__split_buffer` representation to unstable ABI (PR #139632)

2025-07-11 Thread Christopher Di Bella via lldb-commits
cjdb wrote: Done. https://github.com/llvm/llvm-project/pull/139632 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [libcxx] adds size-based `__split_buffer` representation to unstable ABI (PR #139632)

2025-07-11 Thread Christopher Di Bella via lldb-commits
@@ -184,67 +172,299 @@ public: _LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI void swap(__split_buffer& __x) _NOEXCEPT_(!__alloc_traits::propagate_on_container_swap::value || __is_nothrow_swappable_v<__alloc_rr>); - _LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FR

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I didn't because, unlike for the debugger, you can do `target select`. https://github.com/llvm/llvm-project/pull/148075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/148075 >From 74cc4598eccdb43b3a36e3276d16de84a901f095 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 10 Jul 2025 15:51:44 -0700 Subject: [PATCH 1/3] [lldb] Expose debuggers and target as resources thr

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/148075 >From 74cc4598eccdb43b3a36e3276d16de84a901f095 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 10 Jul 2025 15:51:44 -0700 Subject: [PATCH 1/2] [lldb] Expose debuggers and target as resources thr

[Lldb-commits] [lldb] [lldb][WIP] dump riscv opcode bytes as blocks of 2/4 bytes (PR #148105)

2025-07-11 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/148105 >From 74995e8f1a982a82bafaa150fb407187fa4b95e4 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 10 Jul 2025 22:31:54 -0700 Subject: [PATCH 1/6] [lldb][WIP] dump riscv opcode bytes as blocks of 2/4 b

[Lldb-commits] [lldb] [lldb][WIP] dump riscv opcode bytes as blocks of 2/4 bytes (PR #148105)

2025-07-11 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/include/lldb/Core/Opcode.h lldb/source/Core/Op

[Lldb-commits] [lldb] [lldb][WIP] dump riscv opcode bytes as blocks of 2/4 bytes (PR #148105)

2025-07-11 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I didn't little-endian swap the bytes for the 48-bit and 64-bit instructions properly in my unit test, which is why those two were failing. Fixed now. https://github.com/llvm/llvm-project/pull/148105 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [llvm] [lldb] Support disassembling RISC-V proprietary instructions (PR #145793)

2025-07-11 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: nb: I didn't little-endian swap the bytes for the 48-bit and 64-bit instructions properly in my unit test in https://github.com/llvm/llvm-project/pull/148105 , which is why those tests were failing. Fixed. https://github.com/llvm/llvm-project/pull/145793 _

[Lldb-commits] [lldb] [lldb][WIP] dump riscv opcode bytes as blocks of 2/4 bytes (PR #148105)

2025-07-11 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/148105 >From 74995e8f1a982a82bafaa150fb407187fa4b95e4 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 10 Jul 2025 22:31:54 -0700 Subject: [PATCH 1/5] [lldb][WIP] dump riscv opcode bytes as blocks of 2/4 b

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-11 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov approved this pull request. LGTM For reference, this takes this change out of https://github.com/llvm/llvm-project/pull/147835, which reduces the size of that PR a little bit. https://github.com/llvm/llvm-project/pull/148195

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-11 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: > These files test demangling `RecordDecl::isInjectedClassName`, which will be > out-of-date (I think) after merging this PR. This file uses these symbols as test cases, but they are just examples and aren't coupled to the clang implementation at all, the tests are still valid,

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,166 @@ +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===

[Lldb-commits] [lldb] When running OS Plugins from dSYM's, make sure start state is correct (PR #146441)

2025-07-11 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/146441 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9adc8dd - When running OS Plugins from dSYM's, make sure start state is correct (#146441)

2025-07-11 Thread via lldb-commits
Author: jimingham Date: 2025-07-11T10:02:07-07:00 New Revision: 9adc8ddad02d062e0b395d8079f051e8ae4552b4 URL: https://github.com/llvm/llvm-project/commit/9adc8ddad02d062e0b395d8079f051e8ae4552b4 DIFF: https://github.com/llvm/llvm-project/commit/9adc8ddad02d062e0b395d8079f051e8ae4552b4.diff LOG

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,166 @@ +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
@@ -76,17 +76,75 @@ struct ToolCapability { llvm::json::Value toJSON(const ToolCapability &); bool fromJSON(const llvm::json::Value &, ToolCapability &, llvm::json::Path); +struct ResourceCapability { + /// Whether this server supports notifications for changes to the resourc

[Lldb-commits] [lldb] When running OS Plugins from dSYM's, make sure start state is correct (PR #146441)

2025-07-11 Thread via lldb-commits
@@ -3144,16 +3144,17 @@ void Process::CompleteAttach() { } } - if (!m_os_up) { + if (!m_os_up) LoadOperatingSystemPlugin(false); -if (m_os_up) { - // Somebody might have gotten threads before now, but we need to force the - // update after we've loa

[Lldb-commits] [lldb] When running OS Plugins from dSYM's, make sure start state is correct (PR #146441)

2025-07-11 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/146441 >From 8a8e86d72e9d130f513d91fbf75d7631077bf930 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Thu, 12 Jun 2025 11:16:36 -0700 Subject: [PATCH 1/4] When running OS Plugins from dSYM's, make sure the OS plugin

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-11 Thread via lldb-commits
jimingham wrote: > I don't want to hold this up. Made some suggestions on how I would condense > the descriptions. I stopped after I realized I'd be rewriting most of these. > I also haven't checked how would the formatted version of this look like. > I'll leave it up to you whether you want t

[Lldb-commits] [lldb] [lldb] Add completions for plugin list/enable/disable (PR #147775)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/147775 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add completions for plugin list/enable/disable (PR #147775)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
@@ -2473,3 +2474,35 @@ bool PluginManager::SetUnwindAssemblyPluginEnabled(llvm::StringRef name, bool enable) { return GetUnwindAssemblyInstances().SetInstanceEnabled(name, enable); } + +void PluginManager::AutoCompletePlugin

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-11 Thread Yanzuo Liu via lldb-commits
zwuis wrote: > > I'm not sure if I should update > > `llvm/include/llvm/Testing/Demangle/DemangleTestCases.inc` and > > `libcxxabi/test/DemangleTestCases.inc`. > > Why would you need to? There are no changes to mangling/demangling here AFAICT These files test demangling `RecordDecl::isInjecte

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] Fix typos 'seperate' -> 'separate' (NFC) (PR #144368)

2025-07-11 Thread via lldb-commits
https://github.com/GameRoMan edited https://github.com/llvm/llvm-project/pull/144368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::unique_ptr (PR #148248)

2025-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes This PR adds a summary and synthetic children for `std::unique_ptr` from MSVC's STL ([NatVis](https://github.com/microsoft/STL/blob/313964b78a8fd5a52e7965e13781f735bcce13c5/stl/debugger/STL.natvis#L285-L303)). As w

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::unique_ptr (PR #148248)

2025-07-11 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/148248 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::unique_ptr (PR #148248)

2025-07-11 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/148248 This PR adds a summary and synthetic children for `std::unique_ptr` from MSVC's STL ([NatVis](https://github.com/microsoft/STL/blob/313964b78a8fd5a52e7965e13781f735bcce13c5/stl/debugger/STL.natvis#L285-L303)).

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-11 Thread Michael Buch via lldb-commits
Michael137 wrote: > I'm not sure if I should update > `llvm/include/llvm/Testing/Demangle/DemangleTestCases.inc` and > `libcxxabi/test/DemangleTestCases.inc`. Why would you need to? There are no changes to mangling/demangling here AFAICT https://github.com/llvm/llvm-project/pull/148195 __

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] A couple of grammar fixes (PR #144368)

2025-07-11 Thread Baranov Victor via lldb-commits
vbvictor wrote: Please write PR description more specific and add (NFC) at the end. Could be: "Fix typos 'seperate' -> 'separate' (NFC)" https://github.com/llvm/llvm-project/pull/144368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] [lldb] Update the String table offset based on the DWARF format (PR #147054)

2025-07-11 Thread Hemang Gadhavi via lldb-commits
HemangGadhavi wrote: Hi @labath @DavidSpickett I have addressed your comments, and added separate test case to test DW_AT_str_offsets_base for DWARF5 & 64 format. Please review once and give your inputs. https://github.com/llvm/llvm-project/pull/147054

[Lldb-commits] [lldb] [lldb] Update the String table offset based on the DWARF format (PR #147054)

2025-07-11 Thread Hemang Gadhavi via lldb-commits
@@ -1077,7 +1077,8 @@ uint32_t DWARFUnit::GetHeaderByteSize() const { return m_header.getSize(); } std::optional DWARFUnit::GetStringOffsetSectionItem(uint32_t index) const { - lldb::offset_t offset = GetStrOffsetsBase() + index * 4; + lldb::offset_t offset = + GetStrO

[Lldb-commits] [lldb] [lldb] Update the String table offset based on the DWARF format (PR #147054)

2025-07-11 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi updated https://github.com/llvm/llvm-project/pull/147054 >From 4ae4d0ab6ba44317e00dced8f247341ec9930c2c Mon Sep 17 00:00:00 2001 From: HemangGadhavi Date: Fri, 4 Jul 2025 09:28:30 -0400 Subject: [PATCH 1/2] [lldb] Updated the String table offset based on the DWA

[Lldb-commits] [lldb] [lldb][Format] Fall back to old function.name-with-args if language frame format is emtpy (PR #148235)

2025-07-11 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit approved this pull request. https://github.com/llvm/llvm-project/pull/148235 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] A couple of grammar fixes (PR #144368)

2025-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-core Author: Roman (GameRoMan) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/144368.diff 10 Files Affected: - (modified) clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp (+1-1) - (modified) clang/test/AST/HLSL/RootSi

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] A couple of grammar fixes (PR #144368)

2025-07-11 Thread via lldb-commits
https://github.com/GameRoMan updated https://github.com/llvm/llvm-project/pull/144368 >From 2b50682f230efa03c3b9a1f5c5e48e708734bf4d Mon Sep 17 00:00:00 2001 From: Roman A <121314722+gamero...@users.noreply.github.com> Date: Mon, 16 Jun 2025 15:59:01 +0100 Subject: [PATCH] A couple of grammar fi

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-11 Thread Pavel Labath via lldb-commits
@@ -55,16 +56,33 @@ class LLDB_API SBDebugger { eBroadcastBitExternalProgressCategory = lldb::DebuggerBroadcastBit::eBroadcastBitExternalProgressCategory, }; + + /// Default constructor creates an invalid SBDebugger instance. SBDebugger(); SBDebugger(cons

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-11 Thread Pavel Labath via lldb-commits
@@ -55,16 +56,33 @@ class LLDB_API SBDebugger { eBroadcastBitExternalProgressCategory = lldb::DebuggerBroadcastBit::eBroadcastBitExternalProgressCategory, }; + + /// Default constructor creates an invalid SBDebugger instance. SBDebugger(); SBDebugger(cons

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-11 Thread Pavel Labath via lldb-commits
@@ -106,44 +124,122 @@ class LLDB_API SBDebugger { bool &is_debugger_specific); #endif + /// Get structured progress data from an event. + /// + /// \param [in] event + /// The event to extract the progress information from. + /

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-11 Thread Pavel Labath via lldb-commits
@@ -106,44 +124,116 @@ class LLDB_API SBDebugger { bool &is_debugger_specific); #endif + /// Get progress data from an event. + /// + /// \param [in] event + /// The event to extract the progress information from. + /// + /// \

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-11 Thread Pavel Labath via lldb-commits
@@ -55,16 +56,33 @@ class LLDB_API SBDebugger { eBroadcastBitExternalProgressCategory = lldb::DebuggerBroadcastBit::eBroadcastBitExternalProgressCategory, }; + + /// Default constructor creates an invalid SBDebugger instance. SBDebugger(); SBDebugger(cons

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-11 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/147621 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-11 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. I don't want to hold this up. Made some suggestions on how I would condense the descriptions. I stopped after I realized I'd be rewriting most of these. I also haven't checked how would the formatted version of this look like. I'll leave it

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] A couple of grammar fixes (PR #144368)

2025-07-11 Thread via lldb-commits
https://github.com/GameRoMan updated https://github.com/llvm/llvm-project/pull/144368 >From 2b50682f230efa03c3b9a1f5c5e48e708734bf4d Mon Sep 17 00:00:00 2001 From: Roman A <121314722+gamero...@users.noreply.github.com> Date: Mon, 16 Jun 2025 15:59:01 +0100 Subject: [PATCH] A couple of grammar fi

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] A couple of grammar fixes (PR #144368)

2025-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Roman (GameRoMan) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/144368.diff 10 Files Affected: - (modified) clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp (+1-1) - (modified) clang/test/AST/HLSL/RootSi

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] A couple of grammar fixes (PR #144368)

2025-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-analysis Author: Roman (GameRoMan) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/144368.diff 10 Files Affected: - (modified) clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp (+1-1) - (modified) clang/test/AST/HLSL/Ro

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] A couple of grammar fixes (PR #144368)

2025-07-11 Thread via lldb-commits
https://github.com/GameRoMan ready_for_review https://github.com/llvm/llvm-project/pull/144368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] A couple of grammar fixes (PR #144368)

2025-07-11 Thread via lldb-commits
https://github.com/GameRoMan updated https://github.com/llvm/llvm-project/pull/144368 >From 2b50682f230efa03c3b9a1f5c5e48e708734bf4d Mon Sep 17 00:00:00 2001 From: Roman A <121314722+gamero...@users.noreply.github.com> Date: Mon, 16 Jun 2025 15:59:01 +0100 Subject: [PATCH] A couple of grammar fi

[Lldb-commits] [lldb] [lldb][Format] Fall back to old function.name-with-args if language frame format is emtpy (PR #148235)

2025-07-11 Thread Michael Buch via lldb-commits
Michael137 wrote: > Is it a reasonable use case to want to not print anything? If not, then I > think this is a valid way of deactivating the plugin formatting. There are better ways of not printing a function name in the frame. E.g., overriding the `frame-format` setting https://github.com/l

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::vector (PR #147538)

2025-07-11 Thread via lldb-commits
@@ -1599,6 +1599,20 @@ GenericSmartPointerSummaryProvider(ValueObject &valobj, Stream &stream, return LibStdcppSmartPointerSummaryProvider(valobj, stream, options); } +static lldb_private::SyntheticChildrenFrontEnd * +GenericVectorSyntheticFrontEndCreator(CXXSyntheticChildr

[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::vector (PR #147538)

2025-07-11 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/147538 >From a5b22c74a6457ea6d546ff03c09fe93bd2829c4e Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Sat, 21 Jun 2025 17:35:23 +0200 Subject: [PATCH] [LLDB] Add formatters for MSVC STL std::vector --- .../Plugins/Langu

[Lldb-commits] [lldb] [lldb][Format] Fall back to old function.name-with-args if language frame format is emtpy (PR #148235)

2025-07-11 Thread Charles Zablit via lldb-commits
charles-zablit wrote: Is it a reasonable use case to want to not print anything? If not, then I think this is a valid way of deactivating the plugin formatting. https://github.com/llvm/llvm-project/pull/148235 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [lldb] [LLDB] Use non synthetic value for MSVC smart ptr check (PR #148176)

2025-07-11 Thread Michael Buch via lldb-commits
Michael137 wrote: > Windows premerge checks would be great for this. I opened #146236, but there > are still some LLDB tests failing. Not really sure why. That's awesome! I think @Endilll looked at Windows pre-merge testing in the past (at least for Clang, but IIRC maybe also LLDB?), but it wa

[Lldb-commits] [lldb] [LLDB] Use non synthetic value for MSVC smart ptr check (PR #148176)

2025-07-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/148176 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 539991e - [LLDB] Use non synthetic value for MSVC smart ptr check (#148176)

2025-07-11 Thread via lldb-commits
Author: nerix Date: 2025-07-11T13:06:17+01:00 New Revision: 539991e33f1df194b6ca00039a1bab04b045f47b URL: https://github.com/llvm/llvm-project/commit/539991e33f1df194b6ca00039a1bab04b045f47b DIFF: https://github.com/llvm/llvm-project/commit/539991e33f1df194b6ca00039a1bab04b045f47b.diff LOG: [L

[Lldb-commits] [lldb] [lldb][Format] Fall back to old function.name-with-args if language frame format is emtpy (PR #148235)

2025-07-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/148235 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Format] Fall back to old function-name-with args if language frame format is emtpy (PR #148235)

2025-07-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/148235 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Format] Fallback to old function-name-with args if language frame format is emtpy (PR #148235)

2025-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes There is currently no way to prevent `${function.name-with-args}` from using the `plugin.cplusplus.display.function-name-format` setting. Even if the setting is set to an empty string. As a way to disable

[Lldb-commits] [lldb] [lldb][Format] Fallback to old function-name-with args if language frame format is emtpy (PR #148235)

2025-07-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/148235 There is currently no way to prevent `${function.name-with-args}` from using the `plugin.cplusplus.display.function-name-format` setting. Even if the setting is set to an empty string. As a way to disable fo

[Lldb-commits] [lldb] [LLDB] Use non synthetic value for MSVC smart ptr check (PR #148176)

2025-07-11 Thread via lldb-commits
Nerixyz wrote: Windows premerge checks would be great for this. I opened https://github.com/llvm/llvm-project/pull/146236, but there are still some LLDB tests failing. Not really sure why. https://github.com/llvm/llvm-project/pull/148176 ___ lldb-com

[Lldb-commits] [lldb] [LLDB] Use non synthetic value for MSVC smart ptr check (PR #148176)

2025-07-11 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/148176 >From 0e6da6450866758c2b8a0bca7ecc5b43f4ade268 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Fri, 11 Jul 2025 11:51:51 +0200 Subject: [PATCH 1/2] [LLDB] Use non synthetic value for MSVC smart ptr check --- lldb

[Lldb-commits] [lldb] [lldb] deactivate some tests on older SDKs (PR #147768)

2025-07-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/147768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-11 Thread Yanzuo Liu via lldb-commits
https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/148195 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-11 Thread Corentin Jabot via lldb-commits
cor3ntin wrote: Can you provide a more detailed description? Thanks! https://github.com/llvm/llvm-project/pull/148195 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-11 Thread Yanzuo Liu via lldb-commits
zwuis wrote: I'm not sure if I should update `llvm/include/llvm/Testing/Demangle/DemangleTestCases.inc` and `libcxxabi/test/DemangleTestCases.inc`. https://github.com/llvm/llvm-project/pull/148195 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [lldb] [LLDB] Use non synthetic value for MSVC smart ptr check (PR #148176)

2025-07-11 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Plugins/Language/CPlusPlus/MsvcStlSmartPo

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clangd Author: Yanzuo Liu (zwuis) Changes Co-authored-by: Matheus Izvekov --- Full diff: https://github.com/llvm/llvm-project/pull/148195.diff 10 Files Affected: - (modified) clang-tools-ext

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Yanzuo Liu (zwuis) Changes Co-authored-by: Matheus Izvekov --- Full diff: https://github.com/llvm/llvm-project/pull/148195.diff 10 Files Affected: - (modified) clang-tools-extra/clangd/CodeComplete.cpp (+1-1) - (mod

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-11 Thread Yanzuo Liu via lldb-commits
https://github.com/zwuis created https://github.com/llvm/llvm-project/pull/148195 Co-authored-by: Matheus Izvekov >From 306049aa7dd17f6683935d631b3ad222b268a3f2 Mon Sep 17 00:00:00 2001 From: Yanzuo Liu Date: Fri, 11 Jul 2025 18:17:05 +0800 Subject: [PATCH] (`RecordDecl` -> `CXXRecordDecl`)`:

[Lldb-commits] [lldb] [LLDB] Use non synthetic value for MSVC smart ptr check (PR #148176)

2025-07-11 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/148176 >From 0e6da6450866758c2b8a0bca7ecc5b43f4ade268 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Fri, 11 Jul 2025 11:51:51 +0200 Subject: [PATCH 1/2] [LLDB] Use non synthetic value for MSVC smart ptr check --- lldb

[Lldb-commits] [lldb] [lldb-dap] Add external terminal support (PR #146950)

2025-07-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/146950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9098bff - [lldb-dap] Add external terminal support (#146950)

2025-07-11 Thread via lldb-commits
Author: Druzhkov Sergei Date: 2025-07-11T11:14:59+01:00 New Revision: 9098bffb0370273e67c76ab996eb4559dcc71f34 URL: https://github.com/llvm/llvm-project/commit/9098bffb0370273e67c76ab996eb4559dcc71f34 DIFF: https://github.com/llvm/llvm-project/commit/9098bffb0370273e67c76ab996eb4559dcc71f34.dif

[Lldb-commits] [lldb] [LLDB] Use non synthetic value for MSVC smart ptr check (PR #148176)

2025-07-11 Thread Michael Buch via lldb-commits
@@ -15,7 +15,8 @@ using namespace lldb; bool lldb_private::formatters::IsMsvcStlSmartPointer(ValueObject &valobj) { - return valobj.GetChildMemberWithName("_Ptr") != nullptr; + ValueObjectSP valobj_sp = valobj.GetNonSyntheticValue(); + return valobj_sp->GetChildMemberWithNa

[Lldb-commits] [lldb] [LLDB] Use non synthetic value for MSVC smart ptr check (PR #148176)

2025-07-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. no worries! LGTM https://github.com/llvm/llvm-project/pull/148176 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Use non synthetic value for MSVC smart ptr check (PR #148176)

2025-07-11 Thread via lldb-commits
Nerixyz wrote: @Michael137 Sorry for the failure, I only built LLDB before but didn't run the tests after fixing the suggestions 🤦 https://github.com/llvm/llvm-project/pull/148176 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [lldb] [LLDB] Use non synthetic value for MSVC smart ptr check (PR #148176)

2025-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes I forgot to use the non-synthetic value to check for the `_Ptr` member. Fixes the test failure from #147575. --- Full diff: https://github.com/llvm/llvm-project/pull/148176.diff 1 Files Affected: - (modified) lld

[Lldb-commits] [lldb] [LLDB] Use non synthetic value for MSVC smart ptr check (PR #148176)

2025-07-11 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/148176 I forgot to use the non-synthetic value to check for the `_Ptr` member. Fixes the test failure from #147575. >From 0e6da6450866758c2b8a0bca7ecc5b43f4ade268 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Fri, 11

  1   2   >