lenary wrote:
To also respond to something earlier in the thread, where there is a little
complexity:
> The missing part is knowing how to split up that encoding value isn't it. For
> AArch64 you'd just print it because we only have 32-bit, Intel you would roll
> dice to randomly decide what
chelcassanova wrote:
```
cp: cannot stat
'/home/gha/actions-runner/_work/llvm-project/llvm-project/build/test-results.*.xml':
No such file or directory
+ :
+ shopt -s nullglob
+ python3
/home/gha/actions-runner/_work/llvm-project/llvm-project/.ci/generate_test_report_github.py
':penguin: Linu
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions c,cpp --
lldb/test/API/functionalities/breakpoint/breakpoint
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/functionalities/breakpoint/breakpoint_locations/after_rebuild/
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve2-vla`
running on `linaro-g4-02` while building `bolt,lldb,llvm,utils` at step 7
"ninja check 1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/198/builds/5640
Here is the relevant
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/144627
>From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 17 Jun 2025 18:57:11 -0700
Subject: [PATCH 01/12] [lldb][Mach-O] Allow "process metadata" LC_NOTE to
s
adrian-prantl wrote:
> It's not _just_ `BuiltinHeadersInSystemModules` either. There are lots of
> things that the driver toolchain does that you shouldn't be skipping.
We should definitely _also_ find a way to factor that into a function LLDB can
call.
https://github.com/llvm/llvm-project/pu
dwblaikie wrote:
FYI: per https://llvm.org/docs/CodeReview.html#code-review-workflow - please
don't commit a PR without approval, once it's sent for review. If the intent
wasn't to precommit review the PR, it should be created with the
`skip-precommit-approval` tag.
https://github.com/llvm/ll
@@ -148,23 +161,14 @@ void TelemetryManager::DispatchClientTelemetry(
LLDB_LOG(GetLog(LLDBLog::Object),
"Cannot determine client_data from client-telemetry entry");
- int64_t start_time;
- if (dict->GetValueForKeyAsInteger("start_time", start_time)) {
-c
@@ -148,23 +161,14 @@ void TelemetryManager::DispatchClientTelemetry(
LLDB_LOG(GetLog(LLDBLog::Object),
"Cannot determine client_data from client-telemetry entry");
- int64_t start_time;
- if (dict->GetValueForKeyAsInteger("start_time", start_time)) {
-c
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`amdgpu-offload-ubuntu-22-cmake-build-only` running on `rocm-docker-ubu-22`
while building `bolt,lldb,llvm,utils` at step 4 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/203/builds/14758
@@ -20,7 +20,7 @@
# Main header regexes
INCLUDE_FILENAME_REGEX = re.compile(
-r'#include "lldb/API/(?P.*){0,1}"'
+r'#include "lldb/(API/){0,1}(?P.*){0,1}"'
chelcassanova wrote:
Such that we have `r'#include "lldb/(API/)?(?P.*){0,1}"'`
instead of `r'#
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`amdgpu-offload-rhel-9-cmake-build-only` running on `rocm-docker-rhel-9` while
building `bolt,lldb,llvm,utils` at step 4 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/205/builds/13548
He
@@ -20,7 +20,7 @@
# Main header regexes
INCLUDE_FILENAME_REGEX = re.compile(
-r'#include "lldb/API/(?P.*){0,1}"'
+r'#include "lldb/(API/){0,1}(?P.*){0,1}"'
chelcassanova wrote:
Could be worth updating all other instances of `{0,1}`
https://github.com
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/145961
>From 7382a6a7e5636515c4882136d54c8133d77aa31d Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 26 Jun 2025 13:05:56 -0700
Subject: [PATCH] [lldb][scripts] Fix bugs in framework fix script
The
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/145961
The script used to fix up LLDB's header for use in the macOS framework
contained 2 bugs that this commit addreses:
1. The output contents were appended to the output file multiple times instead
of only b
@@ -20,7 +20,7 @@
# Main header regexes
INCLUDE_FILENAME_REGEX = re.compile(
-r'#include "lldb/API/(?P.*){0,1}"'
+r'#include "lldb/(API/){0,1}(?P.*){0,1}"'
bulbazord wrote:
I'm not an expert on regex but would it make sense to use `?` here instead of
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/145961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
The script used to fix up LLDB's header for use in the macOS framework
contained 2 bugs that this commit addreses:
1. The output contents were appended to the output file multiple times instead
of
Sterling-Augustine wrote:
I think it is there now.
https://github.com/llvm/llvm-project/pull/145081
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp
bolt/
https://github.com/Sterling-Augustine closed
https://github.com/llvm/llvm-project/pull/145959
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-pgo
@llvm/pr-subscribers-lldb
Author: None (Sterling-Augustine)
Changes
…145081)"
This reverts commit cbf781f0bdf2f680abbe784faedeefd6f84c246e.
Breaks a couple of buildbots.
---
Patch is 96.13 KiB, truncated to 20.00 KiB below, full version:
https:/
https://github.com/Sterling-Augustine created
https://github.com/llvm/llvm-project/pull/145959
…145081)"
This reverts commit cbf781f0bdf2f680abbe784faedeefd6f84c246e.
Breaks a couple of buildbots.
>From 47fa4a6385cb4e8964cc6909c3554f6589b66eef Mon Sep 17 00:00:00 2001
From: Sterling Augustine
jplehr wrote:
> Reverted with
> [47fa4a6](https://github.com/llvm/llvm-project/commit/47fa4a6385cb4e8964cc6909c3554f6589b66eef)
>
> Will fix and reapply.
Has this reached `main` by now? I cannot see the revert and the bot is still
red.
https://github.com/llvm/llvm-project/pull/145081
___
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`amdgpu-offload-rhel-8-cmake-build-only` running on `rocm-docker-rhel-8` while
building `bolt,lldb,llvm,utils` at step 4 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/204/builds/13571
He
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`clang-ppc64le-linux-multistage` running on `ppc64le-clang-multistage-test`
while building `bolt,lldb,llvm,utils` at step 4 "build stage 1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/76/builds/107
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/143177
>From 66bc2addbbd229e88b3434f771211638cd80b867 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Wed, 18 Jun 2025 21:49:16 +0200
Subject: [PATCH] [LLDB] Add type summaries for MSVC STL strings
---
.../lldb/DataForm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/145954.diff
1 Files Affected:
- (modified) lldb/source/Core/Telemetry.cpp (+19-15)
``diff
diff --git a/lldb/source/Core/Telemetry.cpp b/lldb
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/145954
None
>From f4092ed5fda4214bfd2c72f288a6c686315bdc3b Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 26 Jun 2025 15:18:44 -0400
Subject: [PATCH] [LLDB][NFC] Refactor code extracting timestamp from
Structure
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux`
running on `sanitizer-buildbot1` while building `bolt,lldb,llvm,utils` at step
2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/66/builds/15857
Here is the releva
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross`
running on `suse-gary-m68k-cross` while building `bolt,lldb,llvm,utils` at step
5 "ninja check 1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/27/builds/12150
Here is the
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux`
running on `sanitizer-buildbot7` while building `bolt,lldb,llvm,utils` at step
2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/51/builds/18671
Here is the relev
@@ -78,23 +80,232 @@ public:
__split_buffer,
ldionne wrote:
The documentation of the `__split_buffer` class above will have to be updated:
it references members that don't exist anymore after this patch.
https://github.com/llvm/llvm-proje
@@ -253,30 +436,35 @@ _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::__construct_
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void
__split_buffer<_Tp, _Allocator>::__construct_at_end(size_type __n,
const_reference __x) {
- _ConstructTransaction __tx(std::add
@@ -431,52 +599,61 @@ _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::shrink_to_fi
template
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::emplace_front(_Args&&... __args) {
- if (__begin_ == __first_) {
-if (__end_ < _
@@ -431,52 +599,61 @@ _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::shrink_to_fi
template
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::emplace_front(_Args&&... __args) {
- if (__begin_ == __first_) {
-if (__end_ < _
@@ -78,23 +80,232 @@ public:
__split_buffer,
void>;
- pointer __first_;
- pointer __begin_;
- pointer __end_;
- _LIBCPP_COMPRESSED_PAIR(pointer, __cap_, allocator_type, __alloc_);
+ struct __data {
+pointer __first_ = nullpt
@@ -431,52 +599,61 @@ _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::shrink_to_fi
template
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::emplace_front(_Args&&... __args) {
- if (__begin_ == __first_) {
-if (__end_ < _
@@ -288,92 +476,82 @@ template
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void
__split_buffer<_Tp, _Allocator>::__construct_at_end_with_size(_ForwardIterator
__first, size_type __n) {
- _ConstructTransaction __tx(std::addressof(this->__end_), __n);
+ _ConstructTransaction __tx
@@ -111,36 +322,22 @@ public:
_LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI ~__split_buffer();
- _LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI iterator begin()
_NOEXCEPT { return __begin_; }
- _LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI const_iterator
@@ -288,92 +476,82 @@ template
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void
__split_buffer<_Tp, _Allocator>::__construct_at_end_with_size(_ForwardIterator
__first, size_type __n) {
- _ConstructTransaction __tx(std::addressof(this->__end_), __n);
+ _ConstructTransaction __tx
@@ -253,30 +436,35 @@ _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::__construct_
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void
__split_buffer<_Tp, _Allocator>::__construct_at_end(size_type __n,
const_reference __x) {
- _ConstructTransaction __tx(std::add
@@ -78,23 +80,232 @@ public:
__split_buffer,
void>;
- pointer __first_;
- pointer __begin_;
- pointer __end_;
- _LIBCPP_COMPRESSED_PAIR(pointer, __cap_, allocator_type, __alloc_);
+ struct __data {
+pointer __first_ = nullpt
@@ -288,92 +476,82 @@ template
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void
__split_buffer<_Tp, _Allocator>::__construct_at_end_with_size(_ForwardIterator
__first, size_type __n) {
- _ConstructTransaction __tx(std::addressof(this->__end_), __n);
+ _ConstructTransaction __tx
@@ -253,30 +436,35 @@ _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::__construct_
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void
__split_buffer<_Tp, _Allocator>::__construct_at_end(size_type __n,
const_reference __x) {
- _ConstructTransaction __tx(std::add
@@ -288,92 +476,82 @@ template
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void
__split_buffer<_Tp, _Allocator>::__construct_at_end_with_size(_ForwardIterator
__first, size_type __n) {
- _ConstructTransaction __tx(std::addressof(this->__end_), __n);
+ _ConstructTransaction __tx
@@ -253,30 +436,35 @@ _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::__construct_
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void
__split_buffer<_Tp, _Allocator>::__construct_at_end(size_type __n,
const_reference __x) {
- _ConstructTransaction __tx(std::add
@@ -431,52 +599,61 @@ _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::shrink_to_fi
template
template
_LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::emplace_front(_Args&&... __args) {
- if (__begin_ == __first_) {
-if (__end_ < _
https://github.com/ldionne requested changes to this pull request.
Thanks for the patch! These are the comments from our live review.
https://github.com/llvm/llvm-project/pull/139632
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
@@ -185,66 +382,52 @@ public:
_NOEXCEPT_(!__alloc_traits::propagate_on_container_swap::value ||
__is_nothrow_swappable_v<__alloc_rr>);
_LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI bool __invariants()
const;
-
private:
_LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_
@@ -185,66 +382,52 @@ public:
_NOEXCEPT_(!__alloc_traits::propagate_on_container_swap::value ||
__is_nothrow_swappable_v<__alloc_rr>);
_LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI bool __invariants()
const;
-
private:
_LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/139632
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Sterling-Augustine wrote:
Reverted with 47fa4a6385cb4e8964cc6909c3554f6589b66eef
Will fix and reapply.
https://github.com/llvm/llvm-project/pull/145081
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `hip-third-party-libs-test`
running on `ext_buildbot_hw_05-hip-docker` while building
`bolt,lldb,llvm,utils` at step 4 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/206/builds/2380
Here
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building
`bolt,lldb,llvm,utils` at step 5 "compile-openmp".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/10/builds/8155
Here i
JDevlieghere wrote:
> This PR uses the active IOHanlder (which is Editline), but you're saying that
> prior to this PR, Editline was sometimes able to recover. So we were using
> Editline all along? Confused as to what is Editline the library and what is
> our Editline code.
> I am confused wh
https://github.com/Sterling-Augustine closed
https://github.com/llvm/llvm-project/pull/145081
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Sterling-Augustine
Date: 2025-06-26T11:23:46-07:00
New Revision: cbf781f0bdf2f680abbe784faedeefd6f84c246e
URL:
https://github.com/llvm/llvm-project/commit/cbf781f0bdf2f680abbe784faedeefd6f84c246e
DIFF:
https://github.com/llvm/llvm-project/commit/cbf781f0bdf2f680abbe784faedeefd6f84c246e.
tedwoodward wrote:
> The only real "gotcha" question I can come up with is, wouldn't a user who is
> interested in custom instructions already have access to a compiler that
> produces them and that compiler is likely to be llvm, so is lldb from that
> llvm not within reach already?
>
> Educ
Author: Chelsea Cassanova
Date: 2025-06-26T10:45:11-07:00
New Revision: e880cf74217d8b925f923185994dc8fe6f69a551
URL:
https://github.com/llvm/llvm-project/commit/e880cf74217d8b925f923185994dc8fe6f69a551
DIFF:
https://github.com/llvm/llvm-project/commit/e880cf74217d8b925f923185994dc8fe6f69a551.d
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/145111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jeffreytan81 wrote:
@cs01, can you get a more symbolicated stacktrace for the crash with debug info
and line info?
>From the current callstack, it seems to be a life time use after free issue?
>Like the `SyncService` is trying to access underlying `m_conn` object while it
>is destroyed?
If s
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Document how to use MCP support in LLDB. I expect this to change significantly
as the feature matures. For now it covers configuring the server and two
example clients.
---
Full diff: https://githu
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/145935
Document how to use MCP support in LLDB. I expect this to change significantly
as the feature matures. For now it covers configuring the server and two
example clients.
>From 2b6a7e22481761b244e98dff00f90
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/144364
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ebuka Ezike
Date: 2025-06-26T18:22:47+01:00
New Revision: 0b8a656ba110884e40e9ec79c936139eb6fce0b6
URL:
https://github.com/llvm/llvm-project/commit/0b8a656ba110884e40e9ec79c936139eb6fce0b6
DIFF:
https://github.com/llvm/llvm-project/commit/0b8a656ba110884e40e9ec79c936139eb6fce0b6.diff
L
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/145436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jeffreytan81 wrote:
@qxy11, have you requested merge permission yet? If not, I can merge for you,
but you probably want to ask for you own merge access.
https://github.com/llvm/llvm-project/pull/145436
___
lldb-commits mailing list
lldb-commits@lists.
Author: qxy11
Date: 2025-06-26T10:16:05-07:00
New Revision: 5c310d1ef0188d609b1d2837d403d2b3f2eeb609
URL:
https://github.com/llvm/llvm-project/commit/5c310d1ef0188d609b1d2837d403d2b3f2eeb609
DIFF:
https://github.com/llvm/llvm-project/commit/5c310d1ef0188d609b1d2837d403d2b3f2eeb609.diff
LOG: De
https://github.com/jeffreytan81 approved this pull request.
https://github.com/llvm/llvm-project/pull/145436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ian-twilightcoder wrote:
It's not _just_ `BuiltinHeadersInSystemModules` either. There are lots of
things that the driver toolchain does that you shouldn't be skipping.
https://github.com/llvm/llvm-project/pull/144913
___
lldb-commits mailing list
lld
https://github.com/DavidSpickett approved this pull request.
I am confused which bits are handled by editline the library and which are
handled by our code that interacts with editline, but I always have been so
that shouldn't block this :)
LGTM
https://github.com/llvm/llvm-project/pull/14582
Author: Ebuka Ezike
Date: 2025-06-26T17:42:33+01:00
New Revision: d83457eb83d817e773ed6740a6f0c92180ca585e
URL:
https://github.com/llvm/llvm-project/commit/d83457eb83d817e773ed6740a6f0c92180ca585e
DIFF:
https://github.com/llvm/llvm-project/commit/d83457eb83d817e773ed6740a6f0c92180ca585e.diff
L
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/145915
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Ok I get what we're doing now but...
> This PR uses the active IOHandler (i.e. Editline) to get the cursor position
> before we emit the newline and then uses an ANSI escape code to move the
> cursor back to its original column. I was curious why, depending on the
> timin
DavidSpickett wrote:
Just doing some googling, mostly people talk about modifying the binutils in
the gnu toolchain for custom instructions and rebuilding it.
[This](https://www.ashling.com/wp-content/uploads/PR_CUSTOM_INST_17-FEB-2022.pdf)
refers to some XML file, but I can't tell if they're
DavidSpickett wrote:
@JDevlieghere / @jasonmolenda you have been in the RISC-V world lately, what do
you think to this approach?
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/144364
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,87 @@
+"""
+Defines a command, fdis, that does filtered disassembly. The command does the
+lldb disassemble command with -b and any other arguments passed in, and
+pipes that through a provided filter program.
+
+The intention is to support disassembly of RISC-V proprie
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/145915
>From fbfc26bd78b815334af4beb786ac8276f782b370 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Thu, 26 Jun 2025 16:07:28 +0100
Subject: [PATCH 1/2] [NFC][lldb-dap] add missing header guard.
delete the copy, m
DavidSpickett wrote:
> For RISC-V, llvm-objdump mimics gnu objdump, so this change makes the RISC-V
> byte encodings match both.
Great, that's standard enough.
> That's one thing I'm trying to avoid - we don't want a filter app for objdump
> and another for the debugger. That's why I changed
Michael137 wrote:
> We could mark these tests as requiring macOS 15+, but given how often they
> break I am not sure we want to do that?
Happy to mark them as unsupported on older SDKs if it's blocking other work.
https://github.com/llvm/llvm-project/pull/144913
___
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/145872
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-06-26T17:10:12+01:00
New Revision: aeea062dd43e164889f35c24b98cb1994ead50cb
URL:
https://github.com/llvm/llvm-project/commit/aeea062dd43e164889f35c24b98cb1994ead50cb
DIFF:
https://github.com/llvm/llvm-project/commit/aeea062dd43e164889f35c24b98cb1994ead50cb.diff
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/145915
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -156,3 +161,5 @@ class ProgressEventReporter {
};
} // namespace lldb_dap
+
+#endif // LLDB_TOOLS_LLDB_DAP_PROGRESS_EVENT_H
JDevlieghere wrote:
Missing newline
https://github.com/llvm/llvm-project/pull/145915
__
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/145823
>From 6dc1ff8270e603def516bae230a5fe7108645978 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 26 Jun 2025 08:33:07 -0700
Subject: [PATCH] [lldb] Correctly restore the cursor column after resizi
@@ -102,20 +103,36 @@ void Statusline::UpdateScrollWindow(ScrollWindowMode
mode) {
const unsigned scroll_height =
(mode == DisableStatusline) ? m_terminal_height : m_terminal_height - 1;
+ CursorPosition cursor_position = m_debugger.GetIOHandlerCursorPosition();
JDevlieghere wrote:
> And how exactly does this fix #134064?
https://github.com/llvm/llvm-project/issues/134064#issuecomment-2923315404 has
a visualization of the problem, which you've summarized in
https://github.com/llvm/llvm-project/pull/145823#pullrequestreview-2961296028.
> As in, what
@@ -398,6 +397,20 @@ int Editline::GetLineIndexForLocation(CursorLocation
location, int cursor_row) {
return line;
}
+CursorPosition Editline::GetCursorPosition() {
+ if (!m_editline)
+return {};
+
+ const LineInfoW *info = el_wline(m_editline);
+ if (!info)
+ret
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
delete the copy, move constructor and assignment for ProgressEventReporter.
---
Full diff: https://github.com/llvm/llvm-project/pull/145915.diff
2 Files Affected:
- (modified) lldb/tools/lldb-dap/DAPError.h
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/145915
delete the copy, move constructor and assignment for ProgressEventReporter.
>From fbfc26bd78b815334af4beb786ac8276f782b370 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Thu, 26 Jun 2025 16:07:28 +0100
Subje
https://github.com/tedwoodward deleted
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tedwoodward wrote:
> Few more things:
>
> * Assuming this were to land, there needs to be a release note for it.
> * What solutions exist for people using GDB, and are they along the same
> lines?
I think that's a good idea. Do you know how to add something to release notes?
I've never done i
@@ -0,0 +1,87 @@
+"""
+Defines a command, fdis, that does filtered disassembly. The command does the
+lldb disassemble command with -b and any other arguments passed in, and
+pipes that through a provided filter program.
+
+The intention is to support disassembly of RISC-V proprie
@@ -0,0 +1,87 @@
+"""
+Defines a command, fdis, that does filtered disassembly. The command does the
+lldb disassemble command with -b and any other arguments passed in, and
+pipes that through a provided filter program.
+
+The intention is to support disassembly of RISC-V proprie
https://github.com/tedwoodward edited
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/tedwoodward edited
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/tedwoodward edited
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 133 matches
Mail list logo
