mikaelholmen wrote:
Hi,
With this patch libcxx/test/libcxx/selftest/dsl/dsl.sh.py fails.
So if I run
```build-all-builtins/bin/llvm-lit -av
build-all-builtins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/libcxx/test/libcxx/selftest/dsl/dsl.sh.py```
it fails with lots of errors like
```
# | =
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows`
running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6
"test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/141/builds/9422
Here is the relevant piece of t
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/143628
>From ecc6e9e88e2f5786e7ebd0a454567cd933e60b7f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 12 Jun 2025 16:33:55 -0700
Subject: [PATCH] [lldb] Add MCP support to LLDB
https://discourse.llvm.
@@ -76,26 +178,22 @@ def read_packet(f, verbose=False, trace_file=None):
if verbose:
print('length: "%u"' % (length))
# Skip empty line
-line = f.readline()
+line = f.readline().decode()
if verbose:
print('empty:
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/143818
>From ab4b987aec591491d3805af41c7127ff6698fe0e Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 11 Jun 2025 15:57:16 -0700
Subject: [PATCH 1/2] [lldb-dap] Refactring DebugCommunication to improve test
con
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/143628
>From dee0cc4017bff69879736f39c8cf270a3c867c1c Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 12 Jun 2025 16:33:55 -0700
Subject: [PATCH] [lldb] Add MCP support to LLDB
https://discourse.llvm.
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`sanitizer-aarch64-linux-bootstrap-hwasan` running on `sanitizer-buildbot11`
while building `lld,lldb,llvm` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/55/builds/12717
Here i
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/143628
>From 0db4451b1413f16443a7105f4aaa59597b166955 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 4 Jun 2025 23:56:57 -0700
Subject: [PATCH] [lldb] Add MCP support to LLDB (PoC)
---
lldb/include/
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/143930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Charles Zablit
Date: 2025-06-12T15:13:13-07:00
New Revision: 26f91610011f1a23cb306d61bbc1fafded7d077d
URL:
https://github.com/llvm/llvm-project/commit/26f91610011f1a23cb306d61bbc1fafded7d077d
DIFF:
https://github.com/llvm/llvm-project/commit/26f91610011f1a23cb306d61bbc1fafded7d077d.diff
https://github.com/JDevlieghere commented:
This looks fine to me, but I haven't been following this work too closely so
I'll defer to the others to sign off.
https://github.com/llvm/llvm-project/pull/143818
___
lldb-commits mailing list
lldb-commits@
@@ -76,26 +178,22 @@ def read_packet(f, verbose=False, trace_file=None):
if verbose:
print('length: "%u"' % (length))
# Skip empty line
-line = f.readline()
+line = f.readline().decode()
if verbose:
print('empty:
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/143946
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-06-12T14:52:43-07:00
New Revision: 8a2895ad89793591cd3f0114bc56cd345f651823
URL:
https://github.com/llvm/llvm-project/commit/8a2895ad89793591cd3f0114bc56cd345f651823
DIFF:
https://github.com/llvm/llvm-project/commit/8a2895ad89793591cd3f0114bc56cd345f651823.d
https://github.com/dmpots edited
https://github.com/llvm/llvm-project/pull/143970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2025-06-12T13:55:44-07:00
New Revision: 8a8ea8fec063bd64c17e463e7c3eaae5cdb4a645
URL:
https://github.com/llvm/llvm-project/commit/8a8ea8fec063bd64c17e463e7c3eaae5cdb4a645
DIFF:
https://github.com/llvm/llvm-project/commit/8a8ea8fec063bd64c17e463e7c3eaae5cdb4a645.d
@@ -690,6 +678,102 @@ class PluginManager {
static bool CreateSettingForCPlusPlusLanguagePlugin(
Debugger &debugger, const lldb::OptionValuePropertiesSP &properties_sp,
llvm::StringRef description, bool is_global_property);
+
+ //
+ // Plugin Info+Enable Declara
https://github.com/dmpots commented:
Added a few notes and potential points of discussion.
https://github.com/llvm/llvm-project/pull/143970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
@@ -10,10 +10,10 @@
# Test plugin list without an argument will list all plugins.
plugin list
# CHECK-LABEL: plugin list
-# CHECK: system-runtime
-# CHECK: [+] systemruntime-macosx System runtime plugin for Mac OS
X native libraries
# CHECK: instrumentation-runtime
@@ -407,7 +569,7 @@ ABICreateInstance
PluginManager::GetABICreateCallbackAtIndex(uint32_t idx) {
#pragma mark Architecture
typedef PluginInstance ArchitectureInstance;
-typedef std::vector ArchitectureInstances;
+typedef PluginInstances ArchitectureInstances;
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/143945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dmpots updated
https://github.com/llvm/llvm-project/pull/143970
>From 10f527ddd5b3defc3e7ceef8c5a00ffba9f77b74 Mon Sep 17 00:00:00 2001
From: David Peixotto
Date: Thu, 12 Jun 2025 11:17:53 -0700
Subject: [PATCH 1/3] Use PluginInstances instead of vector for Architecuture
plu
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Peixotto (dmpots)
Changes
In #134418 we added support to list/enable/disable `SystemRuntime` and
`InstrumentationRuntime` plugins. We limited it to those two plugin types
to flesh out the idea with a smaller change.
This PR adds suppo
https://github.com/dmpots created
https://github.com/llvm/llvm-project/pull/143970
In #134418 we added support to list/enable/disable `SystemRuntime` and
`InstrumentationRuntime` plugins. We limited it to those two plugin types
to flesh out the idea with a smaller change.
This PR adds support f
chelcassanova wrote:
@bulbazord I have a auggestion for this patch. I want to have the minimum CMake
necessary to let the tool build. To accomplish this, I want to take out all
code in this tool that relates to the server/client code, leaving the code that
generates the byproducts. I'd then sh
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/143946
>From 9ebb3986e008cec978c0111557a02a9a8d720838 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 12 Jun 2025 11:19:15 -0700
Subject: [PATCH 1/3] [lldb] Implement JSON RPC (newline delimited) Trans
https://github.com/GeorgeHuyubo closed
https://github.com/llvm/llvm-project/pull/143793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: GeorgeHuyubo
Date: 2025-06-12T13:23:26-07:00
New Revision: b1f5e26b78a9550a22ee2f24bb3f220d396c452f
URL:
https://github.com/llvm/llvm-project/commit/b1f5e26b78a9550a22ee2f24bb3f220d396c452f
DIFF:
https://github.com/llvm/llvm-project/commit/b1f5e26b78a9550a22ee2f24bb3f220d396c452f.diff
ashgti wrote:
I tried to see if the existing timeout test was working on the Windows buildbot
and its not running due to
https://github.com/llvm/llvm-project/blob/main/lldb/unittests/CMakeLists.txt#L50
so the timeout tests may need an `#ifdef !_WIN32` around them maybe.
https://github.com/llv
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/143945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,146 @@
+//===-- JSONTransportTest.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/ashgti approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/143946
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/143945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/143945
>From 9a1eedd202a7c5e27bd1ec8a907cc1a650ed4e67 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 12 Jun 2025 10:46:36 -0700
Subject: [PATCH] Reland "[lldb][headers] Create Python script to fix up
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/143946
>From 9ebb3986e008cec978c0111557a02a9a8d720838 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 12 Jun 2025 11:19:15 -0700
Subject: [PATCH 1/2] [lldb] Implement JSON RPC (newline delimited) Trans
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows`
running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6
"test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/141/builds/9412
Here is the relevant piece of t
JDevlieghere wrote:
> @JDevlieghere not a review, but any context on for the change? Just curious.
Apologies for not providing more context. This is a continuation of
https://github.com/llvm/llvm-project/pull/143806 which is partially motivated
by https://discourse.llvm.org/t/rfc-adding-mcp-su
@@ -0,0 +1,146 @@
+//===-- JSONTransportTest.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,146 @@
+//===-- JSONTransportTest.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/143946
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,146 @@
+//===-- JSONTransportTest.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 33f60654673a9d27ed806334a8803c75b51a7aa5 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
@@ -0,0 +1,502 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
Jlalond wrote:
@JDevlieghere not a review, but any context on for the change? Just curious.
https://github.com/llvm/llvm-project/pull/143946
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This PR implements JSON RPC-style (i.e. newline delimited) JSON transport. I
moved the existing transport tests from DAP to Host and moved the PipeTest base
class into TestingSupport so it can be sh
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/143946
This PR implements JSON RPC-style (i.e. newline delimited) JSON transport. I
moved the existing transport tests from DAP to Host and moved the PipeTest base
class into TestingSupport so it can be shared by
@@ -0,0 +1,504 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/143945
>From 4f873a3ee458009541a7015cfa63a247bc792737 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 12 Jun 2025 10:46:36 -0700
Subject: [PATCH] Reland "[lldb][headers] Create Python script to fix up
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/143930
>From 900a01df2892660602c837b0ad0335238337197e Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Thu, 12 Jun 2025 17:36:06 +0100
Subject: [PATCH 1/2] [lit] cleanup unused imports
---
lld/test/Unit/lit
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
…ers" (#143941)
Reland the script that converts lldb headers to RPC headers. The RPC test was
failing due to the incorrect input filepath being used.
---
Full diff: https://github.com/llvm/llvm-pr
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/143945
…ers" (#143941)
Reland the script that converts lldb headers to RPC headers. The RPC test was
failing due to the incorrect input filepath being used.
>From 835528c8926e933ab2c24482c562f5811e0065e4 Mon Se
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu`
running on `as-builder-9` while building `lldb` at step 17
"test-check-lldb-shell".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/195/builds/10363
Here is the relevant pie
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu`
running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/59/builds/19255
Here is the relevant piece of the b
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/142051
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2025-06-12T10:07:45-07:00
New Revision: 1a4cf1d3edff2d4c790f597834301702cfc6dc15
URL:
https://github.com/llvm/llvm-project/commit/1a4cf1d3edff2d4c790f597834301702cfc6dc15
DIFF:
https://github.com/llvm/llvm-project/commit/1a4cf1d3edff2d4c790f597834301702cfc6dc15.d
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/143930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
🚢
https://github.com/llvm/llvm-project/pull/142051
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
Okay, it sounds like I should remove the `-#` from dotest.py since its broken
and `-y` since its not used anywhere.
I can take a look at lit and see if there is some way to integrate re-running a
test there. I'll check if there is a way we could also integrate the failfast
flag
@@ -204,19 +204,19 @@ def create_parser():
action="append",
help='Run "setting set SETTING VALUE" before executing any test.',
)
-group.add_argument(
-"-y",
-type=int,
-metavar="count",
-help="Specify the iteration count u
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/143860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-06-12T17:14:31+01:00
New Revision: c6da2c877cb407c0404e58c5ca257d12036ed164
URL:
https://github.com/llvm/llvm-project/commit/c6da2c877cb407c0404e58c5ca257d12036ed164
DIFF:
https://github.com/llvm/llvm-project/commit/c6da2c877cb407c0404e58c5ca257d12036ed164.diff
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/143860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/143860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/143860
>From 953c71de0b3d21309a4ebbe71cab8618c16dd699 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 11 Jun 2025 12:26:51 +0100
Subject: [PATCH 1/2] [lldb][Commands] Fix memory find for Swift expressions
Th
@@ -928,6 +929,11 @@ EvaluateExpression(llvm::StringRef expression, StackFrame
&frame,
return llvm::createStringError(
"expression evaluation failed. pass a string instead");
+ result_sp = result_sp->GetQualifiedRepresentationIfAvailable(
+ result_sp->GetDyn
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/143860
>From 953c71de0b3d21309a4ebbe71cab8618c16dd699 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 11 Jun 2025 12:26:51 +0100
Subject: [PATCH] [lldb][Commands] Fix memory find for Swift expressions
There
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/143686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-06-12T16:48:57+01:00
New Revision: 1c1df94d09820959c771cb4aaae4d36cdf5cab5a
URL:
https://github.com/llvm/llvm-project/commit/1c1df94d09820959c771cb4aaae4d36cdf5cab5a
DIFF:
https://github.com/llvm/llvm-project/commit/1c1df94d09820959c771cb4aaae4d36cdf5cab5a.diff
@@ -0,0 +1,94 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
lei137 wrote:
I might be missing something, what does `mmaplus` imply here? Since this
tests mma builtins that uses the dmr registers, maybe `builtins-ppc-mma-dmr.c
@@ -0,0 +1,20 @@
+// RUN: not %clang_cc1 -triple powerpc64le-unknown-linux-gnu -target-cpu
future \
lei137 wrote:
nit: better not to have "future" in the test case names as "future" is a
sliding thing?
https://github.com/llvm/llvm-project/pull/142480
@@ -0,0 +1,184 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
lei137 wrote:
nit: maybe this tests can be renamed to `dmf-types.c`?
https://github.com/llvm/llvm-project/pull/142480
___
@@ -30,6 +30,7 @@
#endif
+PPC_VECTOR_MMA_TYPE(__dmr1024, VectorDmr1024, 1024)
lei137 wrote:
Since this is a vector type, maybe we can just keep the same naming convention?
```suggestion
PPC_VECTOR_MMA_TYPE(__vector_dmr, VectorDmr, 1024)
```
https://github.c
https://github.com/lei137 edited
https://github.com/llvm/llvm-project/pull/142480
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -62,7 +62,7 @@ def test_subscript(self):
self.expect(
"frame var 'int_arr[-1]'",
error=True,
-substrs=["unrecognized token"],
+substrs=["failed to parse integer constant"],
kuilpd wrote:
Should I make
kuilpd wrote:
@labath @jimingham
Just to clarify, do we change `-` to `:` now in this PR or later, after we
replace `frame var` with DIL?
https://github.com/llvm/llvm-project/pull/141422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
DavidSpickett wrote:
Then what I'm doing is narrowing the window in which crashes could happen, but
not closing it.
_exit seems more safe for the timeout situation. If there's a genuine bug then
yes anything could happen but at least we'd be rewarded for looking into it
when it did.
If there
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/143732
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/143732
>From 8ab827fab1dc9fed30b28f03b545f78d96af7946 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 11 Jun 2025 15:29:29 +
Subject: [PATCH 1/2] [lldb][test] Don't call SBDebugger::Terminate if
Tes
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/functionalities/memory/find/TestMemoryFind.py
``
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/143686
>From 94a2cae4dfee6d943eaa93bd089e1c0e61b54356 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 11 Jun 2025 12:02:44 +0100
Subject: [PATCH 1/4] [lldb][Commands][NFC] Extract memory find expression
eval
https://github.com/adrian-prantl approved this pull request.
Anyway, this is good otherwise!
https://github.com/llvm/llvm-project/pull/143686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -885,6 +885,55 @@ class CommandObjectMemoryRead : public CommandObjectParsed
{
#define LLDB_OPTIONS_memory_find
#include "CommandOptions.inc"
+static llvm::Error CopyExpressionResult(ValueObject &result,
+DataBufferHeap &buffer) {
+
@@ -885,6 +885,55 @@ class CommandObjectMemoryRead : public CommandObjectParsed
{
#define LLDB_OPTIONS_memory_find
#include "CommandOptions.inc"
+static llvm::Error CopyExpressionResult(ValueObject &result,
+DataBufferHeap &buffer) {
+
labath wrote:
A low-tech way to support both STL versions would be to do a dispatch inside
the data formatter:
```
StdStringSummaryProvider(value) {
if (IsGnuSTL(value))
return GnuStringSummaryProvider(value);
return MSVCStringSummaryProvider(value);
}
```
It's not a complete solution a
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/143686
>From 94a2cae4dfee6d943eaa93bd089e1c0e61b54356 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 11 Jun 2025 12:02:44 +0100
Subject: [PATCH 1/3] [lldb][Commands][NFC] Extract memory find expression
eval
labath wrote:
+1 for removing the option :)
https://github.com/llvm/llvm-project/pull/143797
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-06-12T15:27:27+02:00
New Revision: 622df892b844749440124167e8eee9e652fba613
URL:
https://github.com/llvm/llvm-project/commit/622df892b844749440124167e8eee9e652fba613
DIFF:
https://github.com/llvm/llvm-project/commit/622df892b844749440124167e8eee9e652fba613.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/143731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
+1 for %python
https://github.com/llvm/llvm-project/pull/143756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
exit() will also run some cleanup functions and could cause things to crash.
You could one-up it to _exit(), but ultimately, there's no way to guarantee
that misbehaving code will umm... behave in a certain way.
https://github.com/llvm/llvm
DhruvSrivastavaX wrote:
Got it @labath, I have added the updates accordingly.
Hope this patch serves the purpose. 🙂
> The code is fine, but you should really add a test for it. You don't need to
> wait for lldb-test to grow symtab support. You can write a test that does
> something like:
>
>
DhruvSrivastavaX wrote:
Got it @labath, I have added the updates accordingly.
Hope this is good enough. 🙂
> The code is fine, but you should really add a test for it. You don't need to
> wait for lldb-test to grow symtab support. You can write a test that does
> something like:
>
> ```
> #
DhruvSrivastavaX wrote:
Please ignore the above unrelated push logs. It got messed up due to some
issues with our team's default branch last week.
https://github.com/llvm/llvm-project/pull/141577
___
lldb-commits mailing list
lldb-commits@lists.llvm.
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/141577
>From a62cd7b510f3cf74ee356a95a26e0f9922f4b39c Mon Sep 17 00:00:00 2001
From: DhruvSrivastavaX
Date: Tue, 27 May 2025 05:44:55 -0500
Subject: [PATCH 1/5] Added XCOFF ParseSymtab handling
---
.../Objec
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/141577
>From a62cd7b510f3cf74ee356a95a26e0f9922f4b39c Mon Sep 17 00:00:00 2001
From: DhruvSrivastavaX
Date: Tue, 27 May 2025 05:44:55 -0500
Subject: [PATCH 1/4] Added XCOFF ParseSymtab handling
---
.../Objec
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/141577
>From a62cd7b510f3cf74ee356a95a26e0f9922f4b39c Mon Sep 17 00:00:00 2001
From: DhruvSrivastavaX
Date: Tue, 27 May 2025 05:44:55 -0500
Subject: [PATCH 1/3] Added XCOFF ParseSymtab handling
---
.../Objec
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/141577
>From a62cd7b510f3cf74ee356a95a26e0f9922f4b39c Mon Sep 17 00:00:00 2001
From: DhruvSrivastavaX
Date: Tue, 27 May 2025 05:44:55 -0500
Subject: [PATCH 1/3] Added XCOFF ParseSymtab handling
---
.../Objec
Nerixyz wrote:
> I think we'll then cache the {typename, second_validator} so at that point
> we're getting no benefit from caching...
Yes, if you're going back and forth, then the current caching won't help.
I'm not that familiar with all the use cases of LLDB. In my thinking, you'd
break in
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/143860
(depends on https://github.com/llvm/llvm-project/pull/143686)
There were two issues previously preventing `memory find -e` expressions
to succeed when stopped in Swift frames:
1. We weren't getting the dynami
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
(depends on https://github.com/llvm/llvm-project/pull/143686)
There were two issues previously preventing `memory find -e` expressions
to succeed when stopped in Swift frames:
1. We weren't getting the dyna
1 - 100 of 107 matches
Mail list logo
