https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/143806
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-06-11T19:51:05-07:00
New Revision: de51b2dd3c6fc995e7db56fc50b4c8dceddc0aab
URL:
https://github.com/llvm/llvm-project/commit/de51b2dd3c6fc995e7db56fc50b4c8dceddc0aab
DIFF:
https://github.com/llvm/llvm-project/commit/de51b2dd3c6fc995e7db56fc50b4c8dceddc0aab.d
@@ -0,0 +1,131 @@
+//===-- JSONTransport.h
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/GeorgeHuyubo edited
https://github.com/llvm/llvm-project/pull/143793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/143806
>From 7fad13d3dba1974ece6f4e7da6fe4f48d7f3b4b0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 11 Jun 2025 16:17:21 -0700
Subject: [PATCH 1/2] [lldb] Move Transport class into lldb_private (NFC)
@@ -0,0 +1,131 @@
+//===-- JSONTransport.h
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
JDevlieghere wrote:
My (potentially controversial stance) is that instead of fixing this broken
functionality, we should remove it. When we switched over to using lit as the
test runner, the idea was that dotest would continue to be our test framework
but lit would be the driver, and that we c
JDevlieghere wrote:
@ashgti Let me know if you think it's too early to land this change. Given the
popularity of JSON RPC, I think this would be generally useful, but let me know
if you'd like me to hold off until the RFC has converged.
https://github.com/llvm/llvm-project/pull/143806
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Move lldb-dap's Transport class into lldb_private so the code can be shared
between the "JSON with header" protocol used by DAP and the JSON RPC protocol
used by MCP (see [1]).
[1]: https://discour
https://github.com/JDevlieghere ready_for_review
https://github.com/llvm/llvm-project/pull/143806
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/143806
Move lldb-dap's Transport class into lldb_private so the code can be shared
between the "JSON with header" protocol used by DAP and the JSON RPC protocol
used by MCP (see [1]).
[1]: https://discourse.llvm
https://github.com/GeorgeHuyubo edited
https://github.com/llvm/llvm-project/pull/143793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo edited
https://github.com/llvm/llvm-project/pull/143793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond commented:
This makes sense to me. Let's update the PR description to explain whenever
Target changes architecture we mvoe any corresponding platform Module callback,
because that wasn't really apparent to me from reading the summary.
https://github.com/llvm/llvm-pro
jimingham wrote:
Also, when you go to write tests be sure to write a test with this case. If
there were a way to add the validator from Python you could do this pretty
easily. Maybe you can do it a unit test w/o going that far?
https://github.com/llvm/llvm-project/pull/143748
___
jimingham wrote:
> > When you are about to use a cached formatter, just run the validator
> > function from that formatter on the candidate VO. If it doesn't pass the
> > validator, fall back to the full search.
>
> I think for this, it's easier to save the validator per
> formatter/summary/s
ashgti wrote:
For reference, without this change if you use `-# 2` then you'll see an error
like:
```
Traceback (most recent call last):
File "/Users/harjohn/Projects/llvm-project/lldb/test/API/dotest.py", line 8,
in
lldbsuite.test.run_suite()
^^
File
"/Us
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/143797
This fixes the `dotest.py -# ` flag to work. Currently, if you try to use
the flag you'll get an error on the second run of the suite because python
unittest.TestSuite will remove the tests from the suite after
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This fixes the `dotest.py -# ` flag to work. Currently, if you try
to use the flag you'll get an error on the second run of the suite because
python unittest.TestSuite will remove the tests from the suit
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (GeorgeHuyubo)
Changes
Since this PR: https://github.com/llvm/llvm-project/pull/141670/
We start to override the Platform/Arch for a target if needed. However we may
have already registered locate module callback with the old platform
https://github.com/GeorgeHuyubo created
https://github.com/llvm/llvm-project/pull/143793
Since this PR: https://github.com/llvm/llvm-project/pull/141670/
We start to override the Platform/Arch for a target if needed. However we may
have already registered locate module callback with the old pl
Nerixyz wrote:
It's still missing tests, but I updated it to validate in the formatter. I also
updated https://github.com/llvm/llvm-project/pull/143177 where it's implemented
for std::string.
https://github.com/llvm/llvm-project/pull/143748
___
lldb-
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/143177
>From 06dbd7cbb51986f5718427cf47535f1815273378 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Wed, 11 Jun 2025 18:11:20 +0200
Subject: [PATCH 1/2] [LLDB] Add optional callback function to `TypeMatcher`
---
.../i
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/143748
>From fc36d220f6e21b0a49e6f86b7972d1029813e4fc Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Wed, 11 Jun 2025 18:11:20 +0200
Subject: [PATCH] [LLDB] Add optional callback function to `TypeMatcher`
---
.../inclu
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/commands/frame/var-dil/basics/BitField/TestFrameVarDILBitField
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
lldb/test/API/commands/frame/var-dil/basics/BitField/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (cmtice)
Changes
This updates the DIL implementation to handle smart pointers (accessing field
members and dereferencing) in the same way the current 'frame variable'
implementation does. It also adds tests for handling smart pointer
https://github.com/cmtice created
https://github.com/llvm/llvm-project/pull/143786
This updates the DIL implementation to handle smart pointers (accessing field
members and dereferencing) in the same way the current 'frame variable'
implementation does. It also adds tests for handling smart p
jimingham wrote:
Another way to do this would be to make the data formatters held per target not
per debugger. But that's a much bigger change.
https://github.com/llvm/llvm-project/pull/143748
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Nerixyz wrote:
> When you are about to use a cached formatter, just run the validator function
> from that formatter on the candidate VO. If it doesn't pass the validator,
> fall back to the full search.
I think for this, it's easier to save the validator per
formatter/summary/synthetic, beca
Author: Chelsea Cassanova
Date: 2025-06-11T13:12:37-07:00
New Revision: a2d2941830d9c141d7f43da1ff58e7b7235a9f7d
URL:
https://github.com/llvm/llvm-project/commit/a2d2941830d9c141d7f43da1ff58e7b7235a9f7d
DIFF:
https://github.com/llvm/llvm-project/commit/a2d2941830d9c141d7f43da1ff58e7b7235a9f7d.d
jimingham wrote:
You could even make the cache hold the "match string" and a LIST of matching
formatters. If a VO passes the typename string match, then we run through the
list of matching formatters and choose the first one whose validator accepts
this VO.
That way we could have both the ST
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
We would very much like to support debug sessions with two targets on different
systems. For instance, imagine debugging a Windows client on the host system,
and a Linux server running on another machine. There's all sorts of
opportunities to do coordinated debugging betwee
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/143731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/143756
>From 0a4aee29aedd9079d03750c0757f4a2e93da5933 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 11 Jun 2025 18:43:13 +0100
Subject: [PATCH 1/2] [lldb] make lit use the same Python executable for
JDevlieghere wrote:
Makes sense for the shell test (we could also make it an alias and resolve the
path ourselves, that would be a bit more reliable) but why is this necessary
for the unit tests?
https://github.com/llvm/llvm-project/pull/143756
___
l
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/143572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -105,6 +105,21 @@ protocol::Source CreateSource(lldb::SBAddress address,
lldb::SBTarget &target) {
return CreateSource(line_entry.GetFileSpec());
}
+protocol::Source CreateSource(lldb::SBFrame frame) {
+ if (!frame.IsValid())
+return {};
ashgti wrot
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: nerix (Nerixyz)
Changes
To be able to have multiple formatters that match on the same type name but for
different types, this adds a callback that can be specified, which is called
with the match candidate. As [mentlerd pointed
out](https
@@ -581,19 +581,19 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame,
EmplaceSafeString(object, "name", frame_name);
- auto target = frame.GetThread().GetProcess().GetTarget();
- auto source = CreateSource(frame.GetPCAddress(), target);
+ lldb::SBTarget target =
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/143572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2025-06-11T09:57:42-07:00
New Revision: 145b1b0f103e61cfc8a47ed37080e955630a1390
URL:
https://github.com/llvm/llvm-project/commit/145b1b0f103e61cfc8a47ed37080e955630a1390
DIFF:
https://github.com/llvm/llvm-project/commit/145b1b0f103e61cfc8a47ed37080e9556
https://github.com/Nerixyz created
https://github.com/llvm/llvm-project/pull/143748
To be able to have multiple formatters that match on the same type name but for
different types, this adds a callback that can be specified, which is called
with the match candidate. As [mentlerd pointed
out](
@@ -105,6 +105,21 @@ protocol::Source CreateSource(lldb::SBAddress address,
lldb::SBTarget &target) {
return CreateSource(line_entry.GetFileSpec());
}
+protocol::Source CreateSource(lldb::SBFrame frame) {
+ if (!frame.IsValid())
+return {};
+
+ const lldb::SBTarget ta
dmpots wrote:
> this is really an change to one of the foundational llvm classes, so you
> should get someone from the llvm side to review this
Tagging a few people involved in the last PR (#75469) that modified this code
path: @arsenm, @MaskRay, @lhames, @dsandersllvm, @rudkx
> and also ad
@@ -581,19 +581,19 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame,
EmplaceSafeString(object, "name", frame_name);
- auto target = frame.GetThread().GetProcess().GetTarget();
- auto source = CreateSource(frame.GetPCAddress(), target);
felipepio
@@ -581,19 +581,19 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame,
EmplaceSafeString(object, "name", frame_name);
- auto target = frame.GetThread().GetProcess().GetTarget();
- auto source = CreateSource(frame.GetPCAddress(), target);
+ lldb::SBTarget target =
@@ -885,6 +885,55 @@ class CommandObjectMemoryRead : public CommandObjectParsed
{
#define LLDB_OPTIONS_memory_find
#include "CommandOptions.inc"
+static llvm::Error CopyExpressionResult(ValueObject &result,
+DataBufferHeap &buffer) {
+
@@ -885,6 +885,55 @@ class CommandObjectMemoryRead : public CommandObjectParsed
{
#define LLDB_OPTIONS_memory_find
#include "CommandOptions.inc"
+static llvm::Error CopyExpressionResult(ValueObject &result,
+DataBufferHeap &buffer) {
+
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/143686
>From 94a2cae4dfee6d943eaa93bd089e1c0e61b54356 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 11 Jun 2025 12:02:44 +0100
Subject: [PATCH 1/3] [lldb][Commands][NFC] Extract memory find expression
eval
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/143686
>From 94a2cae4dfee6d943eaa93bd089e1c0e61b54356 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 11 Jun 2025 12:02:44 +0100
Subject: [PATCH 1/4] [lldb][Commands][NFC] Extract memory find expression
eval
https://github.com/DavidSpickett approved this pull request.
Using what cmake provides, makes sense to me.
https://github.com/llvm/llvm-project/pull/143731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
da-viper wrote:
It is the combination of the first and third.
For completness.
we do an step-over, which lands us at an instruction, which happens to be the
first instruction of an inlined function.
lldb-dap takes the PC value and resolves it to a function/block on its own.
This returns the
https://github.com/Nerixyz edited
https://github.com/llvm/llvm-project/pull/143177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
The test does look like it could be easily broken or invalidated by a change in
how the compiler emits debug info. There probably is a better way to test this,
but I'm not quite sure on what exactly is it that you're trying to do. Is it
the following:
- we do an step-over, which
@@ -885,6 +885,55 @@ class CommandObjectMemoryRead : public CommandObjectParsed
{
#define LLDB_OPTIONS_memory_find
#include "CommandOptions.inc"
+static llvm::Error CopyExpressionResult(ValueObject &result,
+DataBufferHeap &buffer) {
+
@@ -885,6 +885,55 @@ class CommandObjectMemoryRead : public CommandObjectParsed
{
#define LLDB_OPTIONS_memory_find
#include "CommandOptions.inc"
+static llvm::Error CopyExpressionResult(ValueObject &result,
+DataBufferHeap &buffer) {
+
@@ -885,6 +885,55 @@ class CommandObjectMemoryRead : public CommandObjectParsed
{
#define LLDB_OPTIONS_memory_find
#include "CommandOptions.inc"
+static llvm::Error CopyExpressionResult(ValueObject &result,
+DataBufferHeap &buffer) {
+
@@ -885,6 +885,55 @@ class CommandObjectMemoryRead : public CommandObjectParsed
{
#define LLDB_OPTIONS_memory_find
#include "CommandOptions.inc"
+static llvm::Error CopyExpressionResult(ValueObject &result,
+DataBufferHeap &buffer) {
+
@@ -140,77 +129,78 @@
lldb_private::formatters::StdlibCoroutineHandleSyntheticFrontEnd::Update() {
if (frame_ptr_addr == 0 || frame_ptr_addr == LLDB_INVALID_ADDRESS)
return lldb::ChildCacheState::eRefetch;
- auto ast_ctx = valobj_sp->GetCompilerType().GetTypeSystem();
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
lldb/source/Commands/CommandObjectMemory.cpp
lldb/te
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/141516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Vogelsgesang
Date: 2025-06-11T14:09:54+02:00
New Revision: 4a46ead8fb5b57e69bcd1c72ebd7dd8eaf09fa9c
URL:
https://github.com/llvm/llvm-project/commit/4a46ead8fb5b57e69bcd1c72ebd7dd8eaf09fa9c
DIFF:
https://github.com/llvm/llvm-project/commit/4a46ead8fb5b57e69bcd1c72ebd7dd8eaf09fa9c
vogelsgesang wrote:
Thanks for the review!
> I don't know much about coroutines, but the code seems fine.
in case you are interested to read more about it: In
https://github.com/llvm/llvm-project/pull/142651, I updated LLVM's "Debugging
C++ coroutines" tutorial
https://github.com/llvm/llvm-p
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/141516
>From 82aa5d13eb9cc73c7e45cb3f4a9e32cd5639 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Fri, 23 May 2025 01:20:46 +
Subject: [PATCH 1/2] [lldb] Show coro_frame in `std::coroutine_handle`
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/141889
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Vogelsgesang
Date: 2025-06-11T13:50:32+02:00
New Revision: 756e7cfd86c7f2bf20aaa1a3f87b5aa72ec128b4
URL:
https://github.com/llvm/llvm-project/commit/756e7cfd86c7f2bf20aaa1a3f87b5aa72ec128b4
DIFF:
https://github.com/llvm/llvm-project/commit/756e7cfd86c7f2bf20aaa1a3f87b5aa72ec128b4
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/141889
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/141889
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/141516
>From 82aa5d13eb9cc73c7e45cb3f4a9e32cd5639 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Fri, 23 May 2025 01:20:46 +
Subject: [PATCH 1/2] [lldb] Show coro_frame in `std::coroutine_handle`
https://github.com/jprotze closed
https://github.com/llvm/llvm-project/pull/133148
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@concussious Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a bu
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/143686
>From 94a2cae4dfee6d943eaa93bd089e1c0e61b54356 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 11 Jun 2025 12:02:44 +0100
Subject: [PATCH 1/2] [lldb][Commands][NFC] Extract memory find expression
eval
Author: Alexander Ziaee
Date: 2025-06-11T13:27:23+02:00
New Revision: 44a7ecd1d7485be94d3a92021c650175f100d2f7
URL:
https://github.com/llvm/llvm-project/commit/44a7ecd1d7485be94d3a92021c650175f100d2f7
DIFF:
https://github.com/llvm/llvm-project/commit/44a7ecd1d7485be94d3a92021c650175f100d2f7.dif
https://github.com/jprotze approved this pull request.
OpenMP changes LGTM, as ru_maxrss actually provides KiB
https://github.com/llvm/llvm-project/pull/133148
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch factors out the `-e` option logic into two helper functions. The
`EvaluateExpression` helper might seem redundant but I'll be adding to it in a
follow-up patch to fix an issue when running `memo
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/143686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/143686
This patch factors out the `-e` option logic into two helper functions. The
`EvaluateExpression` helper might seem redundant but I'll be adding to it in a
follow-up patch to fix and issue when running `memor
SuibianP wrote:
Thanks for the response!
> Your method of receiving a signal may not work reliably in a multithreaded
> process.
It will not. Signal mask is thread local and the signal may be delivered to
other threads instead of being deferred until `pselect`. `sigtimedwait` avoids
the pitf
https://github.com/labath approved this pull request.
I don't know much about coroutines, but the code seems fine.
https://github.com/llvm/llvm-project/pull/141516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
labath wrote:
> I thought we augmented the target.xml from the remote gdb stub via
> `ABI::AugmentRegisterInfo` -- adding eh_frame/dwarf register numbers that
> were not supplied by the stub, for instance -- but looking at AArch64 & x86,
> it looks like it's just adding the slice registers lik
@@ -140,77 +129,78 @@
lldb_private::formatters::StdlibCoroutineHandleSyntheticFrontEnd::Update() {
if (frame_ptr_addr == 0 || frame_ptr_addr == LLDB_INVALID_ADDRESS)
return lldb::ChildCacheState::eRefetch;
- auto ast_ctx = valobj_sp->GetCompilerType().GetTypeSystem();
DavidSpickett wrote:
> It seems that the completion for optional arguments is currently not working
> There are two ways I am thinking of that can solve the problem.
How about you remove the completion parts from this PR and tackle that topic in
another. That way you can get something landed s
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/141516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -140,77 +129,78 @@
lldb_private::formatters::StdlibCoroutineHandleSyntheticFrontEnd::Update() {
if (frame_ptr_addr == 0 || frame_ptr_addr == LLDB_INVALID_ADDRESS)
return lldb::ChildCacheState::eRefetch;
- auto ast_ctx = valobj_sp->GetCompilerType().GetTypeSystem();
labath wrote:
I don't have an opinion on the patch, but I want to point out that, despite it
being motivated by lldb, this is really an change to one of the foundational
llvm classes, so you should get someone from the llvm side to review this and
also add an (llvm) test to demonstrate/test th
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/141889
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/141889
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
91 matches
Mail list logo
