https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/142244
>From ff28c4be506dd762a4f8550a4a5a44578e34535d Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 3 Jun 2025 16:03:36 -0700
Subject: [PATCH 1/2] [lldb] Revive TestSimulatorPlatform.py
This test wa
https://github.com/JDevlieghere approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/143385
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running
on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/18/builds/17248
Here is the relevant piece of the build log
@@ -212,6 +212,8 @@ class PluginManager {
static Status SaveCore(const lldb::ProcessSP &process_sp,
lldb_private::SaveCoreOptions &core_options);
+ static llvm::SmallVector GetSaveCorePluginNames();
JDevlieghere wrote:
It's rather
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/143126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
This needs a test.
https://github.com/llvm/llvm-project/pull/143126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2025-06-09T18:36:35-07:00
New Revision: 48556108f25052a106bfbe83060775bebf9b43a4
URL:
https://github.com/llvm/llvm-project/commit/48556108f25052a106bfbe83060775bebf9b43a4
DIFF:
https://github.com/llvm/llvm-project/commit/48556108f25052a106bfbe83060775bebf9b43a4.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/139817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/139817
>From e63e53adc0909f481a165eca958a3ac2ca4374ee Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 13 May 2025 17:11:08 -0700
Subject: [PATCH 1/9] [lldb][NFC] Split
RegisterContextUnwind::SavedLocation
Author: Jason Molenda
Date: 2025-06-09T17:42:31-07:00
New Revision: f5733b0b859ada51ab4a1cc239ce901ea30b297f
URL:
https://github.com/llvm/llvm-project/commit/f5733b0b859ada51ab4a1cc239ce901ea30b297f
DIFF:
https://github.com/llvm/llvm-project/commit/f5733b0b859ada51ab4a1cc239ce901ea30b297f.diff
https://github.com/Sterling-Augustine closed
https://github.com/llvm/llvm-project/pull/143170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Sterling-Augustine
Date: 2025-06-09T16:32:40-07:00
New Revision: 474db6a85257612a2e878320d0bae51cb884d4f9
URL:
https://github.com/llvm/llvm-project/commit/474db6a85257612a2e878320d0bae51cb884d4f9
DIFF:
https://github.com/llvm/llvm-project/commit/474db6a85257612a2e878320d0bae51cb884d4f9.
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/139817
>From e63e53adc0909f481a165eca958a3ac2ca4374ee Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 13 May 2025 17:11:08 -0700
Subject: [PATCH 1/9] [lldb][NFC] Split
RegisterContextUnwind::SavedLocation
@@ -797,7 +797,8 @@ let Command = "process save_core" in {
EnumArg<"SaveCoreStyle">, Desc<"Request a specific style "
"of corefile to be saved.">;
def process_save_core_plugin_name : Option<"plugin-name", "p">,
-OptionalArg<"Plugin">, Desc<"Specify a plugin name t
@@ -425,7 +425,7 @@ void CFIProgram::printOperand(raw_ostream &OS,
DIDumpOptions DumpOpts,
case OT_Expression:
assert(Instr.Expression && "missing DWARFExpression object");
OS << " ";
-Instr.Expression->print(OS, DumpOpts, nullptr);
+DWARFExpressionPrinter::p
https://github.com/Sterling-Augustine updated
https://github.com/llvm/llvm-project/pull/143170
>From 1b2fcdccc6d7f35dc2f387259c70fe6c9825b8b0 Mon Sep 17 00:00:00 2001
From: Sterling Augustine
Date: Wed, 4 Jun 2025 11:53:45 -0700
Subject: [PATCH 1/4] [NFC] Separate high-level-dependent portions
jimingham wrote:
> > This seems like a generic module loading observer. I don't see anything JIT
> > specific about it. Not saying a generic module loading observer is not a
> > good idea. But calling it a JITLoader seems pretty confusing to me.
>
> true, in the current form. Check out the com
https://github.com/dmpots closed
https://github.com/llvm/llvm-project/pull/134418
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz edited
https://github.com/llvm/llvm-project/pull/143177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Peixotto
Date: 2025-06-09T13:30:13-07:00
New Revision: d4fe522eb4ae710e90107a682911fc75f2388a87
URL:
https://github.com/llvm/llvm-project/commit/d4fe522eb4ae710e90107a682911fc75f2388a87
DIFF:
https://github.com/llvm/llvm-project/commit/d4fe522eb4ae710e90107a682911fc75f2388a87.diff
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/143177
>From e7c1973cb18636174d4f6cab90643cbb04e96262 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Fri, 6 Jun 2025 19:23:04 +0200
Subject: [PATCH] [LLDB] Add type summaries for MSVC STL strings
---
.../lldb/DataForma
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/143177
>From 05d118b35936d0ed02c627ed094a5cd5b48451f4 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Fri, 6 Jun 2025 19:23:04 +0200
Subject: [PATCH] [LLDB] Add type summaries for MSVC STL strings
---
.../lldb/DataForma
https://github.com/maryammo updated
https://github.com/llvm/llvm-project/pull/142480
>From 5ef7a4ca7c2a838a6b2100968d5023e0797b2848 Mon Sep 17 00:00:00 2001
From: Maryam Moghadas
Date: Mon, 2 Jun 2025 19:54:57 +
Subject: [PATCH 1/2] [Clang][PowerPC] Add __dmr type and DMF integer
calculati
clayborg wrote:
> This seems like a generic module loading observer. I don't see anything JIT
> specific about it. Not saying a generic module loading observer is not a good
> idea. But calling it a JITLoader seems pretty confusing to me.
true, in the current form. Check out the comments in my
@@ -198,6 +198,8 @@ static constexpr OptionEnumValueElement g_completion_type[]
= {
"Completes to a type category name."},
{lldb::eCustomCompletion, "custom", "Custom completion."},
{lldb::eThreadIDCompletion, "thread-id", "Completes to a thread ID."},
+{lldb:
clayborg wrote:
> > This seems like a generic module loading observer. I don't see anything JIT
> > specific about it. Not saying a generic module loading observer is not a
> > good idea. But calling it a JITLoader seems pretty confusing to me.
>
> +1 on the name. The design seems very general
https://github.com/clayborg requested changes to this pull request.
Just add a quick test for this and it is ready to go.
https://github.com/llvm/llvm-project/pull/134133
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/134418
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond commented:
Commented on my own real concern. David can approve the land, but please don't
break the current default behavior :)
https://github.com/llvm/llvm-project/pull/143126
___
lldb-commits mailing list
lldb-commits@list
@@ -425,7 +425,7 @@ void CFIProgram::printOperand(raw_ostream &OS,
DIDumpOptions DumpOpts,
case OT_Expression:
assert(Instr.Expression && "missing DWARFExpression object");
OS << " ";
-Instr.Expression->print(OS, DumpOpts, nullptr);
+DWARFExpressionPrinter::p
https://github.com/dwblaikie approved this pull request.
https://github.com/llvm/llvm-project/pull/143170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dwblaikie edited
https://github.com/llvm/llvm-project/pull/143170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/143126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/143126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -198,6 +198,8 @@ static constexpr OptionEnumValueElement g_completion_type[]
= {
"Completes to a type category name."},
{lldb::eCustomCompletion, "custom", "Custom completion."},
{lldb::eThreadIDCompletion, "thread-id", "Completes to a thread ID."},
+{lldb:
@@ -797,7 +797,8 @@ let Command = "process save_core" in {
EnumArg<"SaveCoreStyle">, Desc<"Request a specific style "
"of corefile to be saved.">;
def process_save_core_plugin_name : Option<"plugin-name", "p">,
-OptionalArg<"Plugin">, Desc<"Specify a plugin name t
@@ -797,7 +797,8 @@ let Command = "process save_core" in {
EnumArg<"SaveCoreStyle">, Desc<"Request a specific style "
"of corefile to be saved.">;
def process_save_core_plugin_name : Option<"plugin-name", "p">,
-OptionalArg<"Plugin">, Desc<"Specify a plugin name t
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/143385
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
I can't find a proper source for this but many materials say that ANSI rows and
columns start at 1 not 0.
https://www2.math.upenn.edu/~kazdan/210/computer/ansi.html is as good as I can
get:
is
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/143385
I can't find a proper source for this but many materials say that ANSI rows and
columns start at 1 not 0.
https://www2.math.upenn.edu/~kazdan/210/computer/ansi.html is as good as I can
get:
is a number
@@ -22,8 +22,26 @@ Status SaveCoreOptions::SetPluginName(const char *name) {
}
if (!PluginManager::IsRegisteredObjectFilePluginName(name)) {
DavidSpickett wrote:
In other words:
if (!PluginManager::IsRegisteredObjectFilePluginName(name)) {
Is checking a
@@ -198,6 +198,8 @@ static constexpr OptionEnumValueElement g_completion_type[]
= {
"Completes to a type category name."},
{lldb::eCustomCompletion, "custom", "Custom completion."},
{lldb::eThreadIDCompletion, "thread-id", "Completes to a thread ID."},
+{lldb:
@@ -792,6 +792,12 @@ Status PluginManager::SaveCore(const lldb::ProcessSP
&process_sp,
}
}
+ // report for one plugin if a name is specified.
+ if (error.Success() && !plugin_name.empty())
+error = Status::FromErrorStringWithFormatv(
DavidSpickett
https://github.com/DavidSpickett commented:
Trying not to bog you down in nitpicks, honest :)
There are completion test cases
(`lldb/test/API/functionalities/completion/TestCompletion.py` at least). See if
you can add to those.
https://github.com/llvm/llvm-project/pull/143126
@@ -198,6 +198,8 @@ static constexpr OptionEnumValueElement g_completion_type[]
= {
"Completes to a type category name."},
{lldb::eCustomCompletion, "custom", "Custom completion."},
{lldb::eThreadIDCompletion, "thread-id", "Completes to a thread ID."},
+{lldb:
@@ -198,6 +198,8 @@ static constexpr OptionEnumValueElement g_completion_type[]
= {
"Completes to a type category name."},
{lldb::eCustomCompletion, "custom", "Custom completion."},
{lldb::eThreadIDCompletion, "thread-id", "Completes to a thread ID."},
+{lldb:
@@ -1281,7 +1281,26 @@ class CommandObjectProcessSaveCore : public
CommandObjectParsed {
~CommandOptions() override = default;
llvm::ArrayRef GetDefinitions() override {
- return llvm::ArrayRef(g_process_save_core_options);
+ if (m_opt_def.empty()) {
---
@@ -22,8 +22,19 @@ Status SaveCoreOptions::SetPluginName(const char *name) {
}
if (!PluginManager::IsRegisteredObjectFilePluginName(name)) {
-return Status::FromErrorStringWithFormat(
-"plugin name '%s' is not a valid ObjectFile plugin name", name);
+Stream
@@ -792,6 +792,12 @@ Status PluginManager::SaveCore(const lldb::ProcessSP
&process_sp,
}
}
+ // report for one plugin if a name is specified.
+ if (error.Success() && !plugin_name.empty())
DavidSpickett wrote:
It's so strange that this code (and the
@@ -1281,7 +1281,26 @@ class CommandObjectProcessSaveCore : public
CommandObjectParsed {
~CommandOptions() override = default;
llvm::ArrayRef GetDefinitions() override {
- return llvm::ArrayRef(g_process_save_core_options);
+ if (m_opt_def.empty()) {
---
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/143126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -736,6 +738,16 @@ void CommandCompletions::ProcessNames(CommandInterpreter
&interpreter,
for (const ProcessInstanceInfo &info : process_infos)
request.TryCompleteCurrentArg(info.GetNameAsStringRef());
}
+void CommandCompletions::ProcessSaveCorePluginNames(
---
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/141577
>From a62cd7b510f3cf74ee356a95a26e0f9922f4b39c Mon Sep 17 00:00:00 2001
From: DhruvSrivastavaX
Date: Tue, 27 May 2025 05:44:55 -0500
Subject: [PATCH 1/4] Added XCOFF ParseSymtab handling
---
.../Objec
da-viper wrote:
I overrode the `GetDefinitions` to add the missing options for the `plugin-name
arg` it seems like the generic way to do it.
https://github.com/llvm/llvm-project/pull/143126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/143126
>From 95c61d6a917060d7b3a2bc554575eb6a1086ed6e Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Fri, 6 Jun 2025 13:15:41 +0100
Subject: [PATCH 1/2] [lldb] add plugin names to process save-core error
output.
-
DhruvSrivastavaX wrote:
Hi @DavidSpickett , I have addressed all your comments as well.
https://github.com/llvm/llvm-project/pull/141577
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
Author: David Spickett
Date: 2025-06-09T10:14:54Z
New Revision: e4447e1273616a8732e332168a53a6ac5c8798e2
URL:
https://github.com/llvm/llvm-project/commit/e4447e1273616a8732e332168a53a6ac5c8798e2
DIFF:
https://github.com/llvm/llvm-project/commit/e4447e1273616a8732e332168a53a6ac5c8798e2.diff
LOG
DavidSpickett wrote:
This fixed two tests on Windows -
https://lab.llvm.org/buildbot/#/builders/141/builds/9338
Not often I see a unexpected passes! I've removed the xfails -
https://github.com/llvm/llvm-project/commit/e4447e1273616a8732e332168a53a6ac5c8798e2.
https://github.com/llvm/llvm-pro
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/143183
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Charles Zablit
Date: 2025-06-09T10:20:39+01:00
New Revision: b62488f8326c61fad05d4cd7c88e6e940d8929a4
URL:
https://github.com/llvm/llvm-project/commit/b62488f8326c61fad05d4cd7c88e6e940d8929a4
DIFF:
https://github.com/llvm/llvm-project/commit/b62488f8326c61fad05d4cd7c88e6e940d8929a4.diff
Michael137 wrote:
Merging based on Jonas's approval (@charles-zablit doesn't have commit access
yet)
https://github.com/llvm/llvm-project/pull/143183
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
Author: David Spickett
Date: 2025-06-09T08:59:22Z
New Revision: c73830878463b6d383ca0e8c1dd50842ec4489b9
URL:
https://github.com/llvm/llvm-project/commit/c73830878463b6d383ca0e8c1dd50842ec4489b9
DIFF:
https://github.com/llvm/llvm-project/commit/c73830878463b6d383ca0e8c1dd50842ec4489b9.diff
LOG
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/143338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/143338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kazu Hirata
Date: 2025-06-09T09:56:27+01:00
New Revision: df4b453516ebf9aa03c48c17e81112dce1c80f41
URL:
https://github.com/llvm/llvm-project/commit/df4b453516ebf9aa03c48c17e81112dce1c80f41
DIFF:
https://github.com/llvm/llvm-project/commit/df4b453516ebf9aa03c48c17e81112dce1c80f41.diff
L
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/141344
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: nerix
Date: 2025-06-09T09:46:50+01:00
New Revision: c6670fa20d434a85e167e88aa6a4f56bfc02af2f
URL:
https://github.com/llvm/llvm-project/commit/c6670fa20d434a85e167e88aa6a4f56bfc02af2f
DIFF:
https://github.com/llvm/llvm-project/commit/c6670fa20d434a85e167e88aa6a4f56bfc02af2f.diff
LOG: [L
67 matches
Mail list logo
