[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread Jonas Devlieghere via lldb-commits
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const lldb::SBTarget &target, return source; } -bool ShouldDisplayAssemblySource( -const lldb::SBLineEntry &line_entry, -lldb::StopDisassemblyType stop_disassembly_display) { - if (stop_disassembly_display

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread Jonas Devlieghere via lldb-commits
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const lldb::SBTarget &target, return source; } -bool ShouldDisplayAssemblySource( -const lldb::SBLineEntry &line_entry, -lldb::StopDisassemblyType stop_disassembly_display) { - if (stop_disassembly_display

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread Jonas Devlieghere via lldb-commits
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const lldb::SBTarget &target, return source; } -bool ShouldDisplayAssemblySource( -const lldb::SBLineEntry &line_entry, -lldb::StopDisassemblyType stop_disassembly_display) { - if (stop_disassembly_display

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread Jonas Devlieghere via lldb-commits
@@ -139,15 +141,16 @@ static DisassembledInstruction ConvertSBInstructionToDisassembledInstruction( disassembled_inst.instruction = std::move(instruction); - auto line_entry = addr.GetLineEntry(); + auto source = CreateSource(addr, target); + auto line_entry = GetLineEn

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,17 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-05-29 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/139170 >From c7432d04896c1eea67ed6a6d5f4b4c28941e5a90 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 8 May 2025 07:38:20 -0700 Subject: [PATCH 1/4] [lldb] Do not create SymbolFileDWARFDebugMap for non-Mach-O files

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-05-29 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: @gulfemsavrun thanks for reporting the issue. This should be fixed soon by https://github.com/llvm/llvm-project/pull/142081 https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [lldb] [NFC][lldb][lldb-dap][test] show the expected value in the error message. (PR #142030)

2025-05-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/142030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8a44cd7 - [NFC][lldb-dap][test] show the expected value in the error message. (#142030)

2025-05-29 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-05-29T23:20:09+01:00 New Revision: 8a44cd74bdf8a650d85e144a640c595e1945e906 URL: https://github.com/llvm/llvm-project/commit/8a44cd74bdf8a650d85e144a640c595e1945e906 DIFF: https://github.com/llvm/llvm-project/commit/8a44cd74bdf8a650d85e144a640c595e1945e906.diff L

[Lldb-commits] [lldb] [NFC][lldb][lldb-dap][test] show the expected value in the error message. (PR #142030)

2025-05-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142030 >From 2051222d2beede3a5bed8a9436dce3ca217d53a6 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Thu, 29 May 2025 21:28:13 +0100 Subject: [PATCH 1/3] [lldb][lldb-dap][test] show the expected value in the error

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-29 Thread Jan Svoboda via lldb-commits
jansvoboda11 wrote: Thanks for the concrete example! I think the key thing to realize is that the `DiagnosticsEngine` and `DiagnosticOptions` used for command-line parsing are typically throwaway and separate from those used for actual compilation. I suggest looking at how `cc1_main()` orchest

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-05-29 Thread Greg Clayton via lldb-commits
@@ -46,12 +49,206 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +// Helper function to perform an action on each matching plugin. +// The action callback is given the containing namespace along with plugin info +// for each matching plugi

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/6] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] Fall back to using parent DW_AT_LLVM_include_path for submodules (PR #142044)

2025-05-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Looks good! https://github.com/llvm/llvm-project/pull/142044 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/tools/lldb-dap/Protocol/ProtocolUtils.cpp lld

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-05-29 Thread Greg Clayton via lldb-commits
@@ -464,6 +466,24 @@ llvm::json::Value DebuggerStats::ReportStatistics( } } + if (include_plugins) { +json::Object plugin_stats; +for (const PluginNamespace &plugin_ns : + PluginManager::GetPluginNamespaces()) { + json::Array namespace_stats; + +

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-05-29 Thread Greg Clayton via lldb-commits
@@ -46,12 +49,206 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +// Helper function to perform an action on each matching plugin. +// The action callback is given the containing namespace along with plugin info +// for each matching plugi

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-05-29 Thread Greg Clayton via lldb-commits
@@ -174,12 +174,21 @@ struct StatisticsOptions { return !GetSummaryOnly(); } + void SetIncludePlugins(bool value) { m_include_plugins = value; } + bool GetIncludePlugins() const { +if (m_include_plugins.has_value()) + return m_include_plugins.value(); +//

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-05-29 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/134418 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-05-29 Thread Greg Clayton via lldb-commits
@@ -46,12 +49,206 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +// Helper function to perform an action on each matching plugin. +// The action callback is given the containing namespace along with plugin info +// for each matching plugi

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/5] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread Ely Ronnen via lldb-commits
@@ -58,6 +59,9 @@ class LLDB_API SBAddress { // "lldb::SBAddress SBTarget::ResolveLoadAddress (...)". lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope); + lldb::SBSymbolContext GetSymbolContext(const SBTarget &target, +

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] Fall back to using parent DW_AT_LLVM_include_path for submodules (PR #142044)

2025-05-29 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/142044 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] Fall back to using parent DW_AT_LLVM_include_path for submodules (PR #142044)

2025-05-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Inferred submodule declarations are emitted in DWARF as `DW_TAG_module`s without `DW_AT_LLVM_include_path`s. Instead the parent DIE will have the include path. This patch adds support for such setups. With

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] Fall back to using parent DW_AT_LLVM_include_path for submodules (PR #142044)

2025-05-29 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/142044 Inferred submodule declarations are emitted in DWARF as `DW_TAG_module`s without `DW_AT_LLVM_include_path`s. Instead the parent DIE will have the include path. This patch adds support for such setups. Withou

[Lldb-commits] [lldb] [NFC][lldb][lldb-dap][test] show the expected value in the error message. (PR #142030)

2025-05-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142030 >From 2051222d2beede3a5bed8a9436dce3ca217d53a6 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Thu, 29 May 2025 21:28:13 +0100 Subject: [PATCH 1/2] [lldb][lldb-dap][test] show the expected value in the error

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-29 Thread Ebuka Ezike via lldb-commits
da-viper wrote: The test for disassembly is failing because the test is wrong. The memory reference can have a corresponding source location. if there is debuginfo installed on the computer or it is downloaded with debuginfod. https://github.com/llvm/llvm-project/blob/84a69a0f8f60b6d852b9a16

[Lldb-commits] [lldb] [lldb-dap] fix config value comparison (PR #142017)

2025-05-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/142017 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb][lldb-dap][test] show the expected value in the error message. (PR #142030)

2025-05-29 Thread Jonas Devlieghere via lldb-commits
@@ -45,9 +45,14 @@ def test_optimized_variable(self): self.continue_to_breakpoints(breakpoint_ids) optimized_variable = self.dap_server.get_local_variable("argc") -self.assertTrue(optimized_variable["value"].startswith("https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread John Harrison via lldb-commits
@@ -58,6 +59,9 @@ class LLDB_API SBAddress { // "lldb::SBAddress SBTarget::ResolveLoadAddress (...)". lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope); + lldb::SBSymbolContext GetSymbolContext(const SBTarget &target, +

[Lldb-commits] [lldb] [lldb-dap] fix config value comparison (PR #142017)

2025-05-29 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/142017 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-29 Thread James Y Knight via lldb-commits
jyknight wrote: I'm trying to update some non-in-tree code after this change, and I don't think I understand the newly-expected lifetime rules after this change. I see all the comments that say this makes lifetime clearer...so I expect I'm just misunderstanding things. Previously, Diagnostics

[Lldb-commits] [lldb] [lldb-dap] fix config value comparison (PR #142017)

2025-05-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) Changes Fix TypeSCript comparison (when defining an empty config string like `commandEscapePrefix=""` it would skip it) --- Full diff: https://github.com/llvm/llvm-project/pull/142017.diff 1 Files Affected: - (modif

[Lldb-commits] [lldb] [lldb-dap] fix config value comparison (PR #142017)

2025-05-29 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/142017 Fix TypeSCript comparison (when defining an empty config string like `commandEscapePrefix=""` it would skip it) >From 8632a15c5fa4a11b1a108d9b763b9241b5a2bc41 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Th

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-05-29 Thread via lldb-commits
dlav-sc wrote: @DavidSpickett, @asb could you take another look at this patch, please? I've added support for instructional step for any possible riscv atomic sequence (or at least I believe so). Additionally, I've made some minor refactoring to the software's single-step logic. https://githu

[Lldb-commits] [lldb] [LLDB] Add bit extraction to DIL (PR #141422)

2025-05-29 Thread Pavel Labath via lldb-commits
labath wrote: > If we are worried about supporting older uses of path expressions while we're > quite dramatically expanding what you can express in this syntax, we probably > should make the parser have a mode where it emulates the old path expression, > turning off the new operators. FTR, I

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Pavel Labath via lldb-commits
labath wrote: > Are these actually different on Mac? These 4 are the same on BSD to my > knowledge. I haven't checked, I guess these four might be the same on a mac, but that definitely is not the case everywhere. We're currently growing AIX support, and that one seems to have different numbe

[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug in generating 64b memory minidumps (PR #141995)

2025-05-29 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/141995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: https://lab.llvm.org/buildbot/#/builders/197/builds/6014 looks like we're passing https://github.com/llvm/llvm-project/pull/141971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From 4c20703077eb4bbee8cfeb59022dec89d8697d83 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/4] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [LLDB] Add bit extraction to DIL (PR #141422)

2025-05-29 Thread via lldb-commits
cmtice wrote: > I agree with Pavel that using `-` for ranges of bitfields was an unfortunate > choice, which really only worked because we didn't intend to provide the > addition operators in the ValueObject path specifications. Now that we're > going to add those, we ought to switch to someth

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/141971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 159646c - [LLDB] Add ifndef to platform linux (#141971)

2025-05-29 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-05-29T11:20:05-07:00 New Revision: 159646cd39eb6451c8906a65e04d2566882f URL: https://github.com/llvm/llvm-project/commit/159646cd39eb6451c8906a65e04d2566882f DIFF: https://github.com/llvm/llvm-project/commit/159646cd39eb6451c8906a65e04d2566882f.diff

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @labath I'm landing to not leave the build broken, but if you have a better solution/means of doing this let me know and I'll implement it https://github.com/llvm/llvm-project/pull/141971 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug in generating 64b memory minidumps (PR #141995)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/141995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9ca41b6 - [LLDB][Minidump] Fix bug in generating 64b memory minidumps (#141995)

2025-05-29 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-05-29T11:06:56-07:00 New Revision: 9ca41b6b65680c9eceb938c0e27d8d054114e680 URL: https://github.com/llvm/llvm-project/commit/9ca41b6b65680c9eceb938c0e27d8d054114e680 DIFF: https://github.com/llvm/llvm-project/commit/9ca41b6b65680c9eceb938c0e27d8d054114e680.diff

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-29 Thread John Harrison via lldb-commits
ashgti wrote: I'm surprised by some of these failures, since it passed on buildkite and the premerge check that are also on linux x86_64. Trying to understand the reason for these failures. https://github.com/llvm/llvm-project/pull/141689 ___ lldb-co

[Lldb-commits] [lldb] [lldb-dap] Treat empty thread names as unset (PR #141529)

2025-05-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/141529 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, Breakpoints. (PR #141983)

2025-05-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/141983 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add bit extraction to DIL (PR #141422)

2025-05-29 Thread via lldb-commits
jimingham wrote: I agree with Pavel that using `-` for ranges of bitfields was an unfortunate choice, which really only worked because we didn't intend to provide the addition operators in the ValueObject path specifications. Now that we're going to add those, we ought to switch to something

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, attach tests. (PR #141981)

2025-05-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/141981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug in generating 64b memory minidumps (PR #141995)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: ``` MINIDUMP_MEMORY64_LIST: NumberOfMemoryRanges = 0x0042 BaseRva = 0x7f1963c0 MemoryRanges[0] = [0x - 0x7f1a4020) MemoryRanges[1] = [0x - 0x7f1e0820) MemoryRanges[2] = [0x00

[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug in generating 64b memory minidumps (PR #141995)

2025-05-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes In #129307, we introduced read write in chunks, and during the final revision of the PR I changed the behavior for 64b memory regions and did not test an actual 64b memory range. This caused LLDB to crash w

[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug in generating 64b memory minidumps (PR #141995)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/141995 In #129307, we introduced read write in chunks, and during the final revision of the PR I changed the behavior for 64b memory regions and did not test an actual 64b memory range. This caused LLDB to crash when

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-05-29 Thread via lldb-commits
https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/127505 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-29 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/23448 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-29 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/18540 Here is the relevant piece of the b

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-29 Thread John Harrison via lldb-commits
ashgti wrote: Looking into the failure on the buildbot. https://github.com/llvm/llvm-project/pull/141689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-05-29 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/127505 >From 2520b8d7884d320ed7923685b1a3e8652a7e8f5f Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Fri, 23 May 2025 13:27:46 + Subject: [PATCH 1/2] [lldb][RISCV] handle lr/sc single step lldb-server had limi

[Lldb-commits] [lldb] 8a49db3 - [lldb-dap] Test Gardening, improving DebugCommunication. (#141689)

2025-05-29 Thread via lldb-commits
Author: John Harrison Date: 2025-05-29T09:51:27-07:00 New Revision: 8a49db35f45e56c92522c6079e51553e80c07aec URL: https://github.com/llvm/llvm-project/commit/8a49db35f45e56c92522c6079e51553e80c07aec DIFF: https://github.com/llvm/llvm-project/commit/8a49db35f45e56c92522c6079e51553e80c07aec.diff

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, Breakpoints. (PR #141983)

2025-05-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Enabling the breakpoint tests, these have been stable for me locally and I think with the recent changes this should be stable again in the CI. --- Full diff: https://github.com/llvm/llvm-project/pull/141983.

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, Breakpoints. (PR #141983)

2025-05-29 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/141983 Enabling the breakpoint tests, these have been stable for me locally and I think with the recent changes this should be stable again in the CI. >From 60ca2ac18ccff832d2137107d3f5161614c02dd1 Mon Sep 17 00:00:00

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-29 Thread John Harrison via lldb-commits
ashgti wrote: Okay, the latest version of this worked on buildkit for linux. I'll submit this, but if we get reports of it failing with other specific versions of python we may need to tweak things a bit. https://github.com/llvm/llvm-project/pull/141689 ___

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, attach tests. (PR #141981)

2025-05-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Trimming unused imports, adjusting the test to use the `DEFAULT_TIMEOUT` instead of a custom timeout and adjusting the flow to stopOnEntry for improving consistency. --- Full diff: https://github.com/llvm/ll

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-05-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/riscv/step/TestSoftwareStep.py `` View the diff f

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, attach tests. (PR #141981)

2025-05-29 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/141981 Trimming unused imports, adjusting the test to use the `DEFAULT_TIMEOUT` instead of a custom timeout and adjusting the flow to stopOnEntry for improving consistency. >From 509b0a5643620b10e77216c7cde591b7e8ccb1

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-29 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/141689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-05-29 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/127505 >From 2520b8d7884d320ed7923685b1a3e8652a7e8f5f Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Fri, 23 May 2025 13:27:46 + Subject: [PATCH 1/2] [lldb][RISCV] handle lr/sc single step lldb-server had limi

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > Ummm... I should have caught this before, but this isn't correct because the > host system may (and some do) use different signal numbers for these > constants. Are these actually different on Mac? These 4 are the same on BSD to my knowledge. How do you think we should go ab

[Lldb-commits] [lldb] [lldb] Refactor away UB in SBValue::GetLoadAddress (PR #141799)

2025-05-29 Thread via lldb-commits
https://github.com/jimingham approved this pull request. That worked out pretty well. https://github.com/llvm/llvm-project/pull/141799 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: Hey @felipepiovezan am I reading green dragon right https://green.lab.llvm.org/job/llvm.org/job/as-lldb-cmake/changes Looks like the build with my changes failed (with I believe unrelated test failures), then went green? Does that mean we're working on Darwin? https://github.c

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
@@ -34,6 +34,20 @@ #define MAP_PRIVATE 2 #define MAP_ANON 0x20 +// For other platforms that use platform linux +#ifndef SIGILL +#define SIGILL 4 +#endif +#ifndef SIGBUS +#define SIGBUS 7 +#endif +#ifndef SIGFPE +#define SIGFPE 8 +#endif +#ifndef SIGSEGV +#define SIGSEGV 11 ---

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Pavel Labath via lldb-commits
labath wrote: Ummm... I should have caught this before, but this isn't correct because the host system may (and some do) use different signal numbers for these constants. So, on windows, you get an undefined symbol error, but on e.g. macos, you'd just get a wrong value. You should take these

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: I'm going to wait to see how many build issues we get before landing. https://github.com/llvm/llvm-project/pull/141971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread David Peixotto via lldb-commits
@@ -34,6 +34,20 @@ #define MAP_PRIVATE 2 #define MAP_ANON 0x20 +// For other platforms that use platform linux +#ifndef SIGILL +#define SIGILL 4 +#endif +#ifndef SIGBUS +#define SIGBUS 7 +#endif +#ifndef SIGFPE +#define SIGFPE 8 +#endif +#ifndef SIGSEGV +#define SIGSEGV 11 ---

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread David Peixotto via lldb-commits
https://github.com/dmpots edited https://github.com/llvm/llvm-project/pull/141971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread David Peixotto via lldb-commits
@@ -34,6 +34,20 @@ #define MAP_PRIVATE 2 #define MAP_ANON 0x20 +// For other platforms that use platform linux dmpots wrote: Are these guaranteed to be defines and not constants? https://github.com/llvm/llvm-project/pull/141971 _

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread David Peixotto via lldb-commits
https://github.com/dmpots approved this pull request. Approving to unblock windows build break. https://github.com/llvm/llvm-project/pull/141971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: Put up a fix for Windows on #141971 https://github.com/llvm/llvm-project/pull/141670 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/141971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Another iteration of fixes for #141670. Platform linux can be used by other platforms, so we need to supply the signal values if they're not defined. --- Full diff: https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/141971 Another iteration of fixes for #141670. Platform linux can be used by other platforms, so we need to supply the signal values if they're not defined. >From 0612b888a0dd0cda09fbaa89f5e68c15a1bc9e98 Mon Sep 17 00

[Lldb-commits] [lldb] [lldb][lldb-dap] Support breakpoint info bytes (PR #141122)

2025-05-29 Thread John Harrison via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-29 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/141689 >From ad0a9cd321d260cd87b852b335da9565f8326449 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 27 May 2025 16:40:10 -0700 Subject: [PATCH 1/4] [lldb-dap] Test Gardening, improving DebugCommunication. Imp

[Lldb-commits] [lldb] [lldb][lldb-dap] Support breakpoint info bytes (PR #141122)

2025-05-29 Thread John Harrison via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/141670 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-29 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `lldb` at step 8 "build-default". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/5997 Here is the relevant piece of the bui

[Lldb-commits] [lldb] 5fe9aea - Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (#141670)

2025-05-29 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-05-29T08:43:55-07:00 New Revision: 5fe9aea6d128a8569e27f8c66272e481f10c61ae URL: https://github.com/llvm/llvm-project/commit/5fe9aea6d128a8569e27f8c66272e481f10c61ae DIFF: https://github.com/llvm/llvm-project/commit/5fe9aea6d128a8569e27f8c66272e481f10c61ae.diff

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @JDevlieghere I did run this on my local Mac (Very slowly on an M1 🥲). Got no failures, but still FYI https://github.com/llvm/llvm-project/pull/141670 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-29 Thread John Harrison via lldb-commits
ashgti wrote: Looks like my tests failed on the buildkit linux host, looking into why python3.10 failed. They passed on the 'CI Checks / Build and Test Linux' but that has python 3.12. https://github.com/llvm/llvm-project/pull/141689 ___ lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Support breakpoint info bytes (PR #141122)

2025-05-29 Thread Ebuka Ezike via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-29 Thread Jacob Lalonde via lldb-commits
@@ -27,6 +27,30 @@ #ifndef SEGV_CPERR #define SEGV_CPERR 10 #endif +#ifndef SI_QUEUE +#define SI_QUEUE -1 +#endif +#ifndef SI_TIMER +#define SI_TIMER -2 +#endif +#ifndef SI_MESGQ +#define SI_MESGQ -3 +#endif +#ifndef SI_ASYNCIO +#define SI_ASYNCIO -4 +#endif +#ifndef SI_SIGIO +

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/141670 >From 048cc769d6380bcb899bbcc5acf7f9349b51c5d3 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 27 May 2025 13:40:40 -0700 Subject: [PATCH 1/6] Reapply "[LLDB][ELF Core] Support all the Generic (Negative

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-05-29 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: @labath > The code seems okay. I don't know anything about the format, so I don't know > which parts are "obvious" and which not, but I'd encourage you to add > comments where you think it might be useful. Sure, I have added some comments for that now. > You're right

[Lldb-commits] [lldb] [lldb][lldb-dap] Support breakpoint info bytes (PR #141122)

2025-05-29 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/141122 >From 9408d17b1acf308c7a299bdc6c413a3505d1a039 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 21 May 2025 23:26:14 +0100 Subject: [PATCH 1/9] [lldb][lldb-dap] support DataBreakpointBytes capability ---

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-05-29 Thread Dhruv Srivastava via lldb-commits
@@ -188,7 +188,74 @@ AddressClass ObjectFileXCOFF::GetAddressClass(addr_t file_addr) { return AddressClass::eUnknown; } -void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {} +lldb::SymbolType MapSymbolType(llvm::object::SymbolRef::Type sym_type) { + if (sym_type == ll

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-05-29 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/141577 >From a62cd7b510f3cf74ee356a95a26e0f9922f4b39c Mon Sep 17 00:00:00 2001 From: DhruvSrivastavaX Date: Tue, 27 May 2025 05:44:55 -0500 Subject: [PATCH 1/3] Added XCOFF ParseSymtab handling --- .../Objec

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-05-29 Thread David Spickett via lldb-commits
@@ -188,7 +188,74 @@ AddressClass ObjectFileXCOFF::GetAddressClass(addr_t file_addr) { return AddressClass::eUnknown; } -void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {} +lldb::SymbolType MapSymbolType(llvm::object::SymbolRef::Type sym_type) { + if (sym_type == ll

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-05-29 Thread David Spickett via lldb-commits
@@ -188,7 +188,74 @@ AddressClass ObjectFileXCOFF::GetAddressClass(addr_t file_addr) { return AddressClass::eUnknown; } -void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {} +lldb::SymbolType MapSymbolType(llvm::object::SymbolRef::Type sym_type) { Davi

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-05-29 Thread David Spickett via lldb-commits
@@ -188,7 +188,74 @@ AddressClass ObjectFileXCOFF::GetAddressClass(addr_t file_addr) { return AddressClass::eUnknown; } -void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {} +lldb::SymbolType MapSymbolType(llvm::object::SymbolRef::Type sym_type) { + if (sym_type == ll

  1   2   >