https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/140228
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-05-22T08:32:11+02:00
New Revision: 53a5bea0ad7ebf72d076d00d3e4a8aff18692ec6
URL:
https://github.com/llvm/llvm-project/commit/53a5bea0ad7ebf72d076d00d3e4a8aff18692ec6
DIFF:
https://github.com/llvm/llvm-project/commit/53a5bea0ad7ebf72d076d00d3e4a8aff18692ec6.diff
@@ -10,8 +10,16 @@ add_lldb_unittest(DAPTests
VariablesTest.cpp
LINK_LIBS
+liblldb
lldbDAP
+lldbUtilityHelpers
LLVMTestingSupport
LINK_COMPONENTS
Support
)
+
+set(test_inputs
+ linux-x86_64.out
+ linux-x86_64.core
labath wrot
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/140993
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
SuibianP wrote:
I still wonder why CI checks (such as
[this](https://buildkite.com/llvm-project/github-pull-requests/builds/180533#0196e513-330d-4fe5-8ed4-8e96fc5b1a89))
were `PASS` without catching the errors. I could only guess it is in
`isTestSupported`.
https://github.com/llvm/llvm-projec
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/140978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pat Doyle
Date: 2025-05-21T20:21:18-07:00
New Revision: 4fd48ac9ae272db07a48a08f99f2101dce2f1eb0
URL:
https://github.com/llvm/llvm-project/commit/4fd48ac9ae272db07a48a08f99f2101dce2f1eb0
DIFF:
https://github.com/llvm/llvm-project/commit/4fd48ac9ae272db07a48a08f99f2101dce2f1eb0.diff
LOG
https://github.com/shiltian approved this pull request.
https://github.com/llvm/llvm-project/pull/140989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/138587
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/functionalities/thread/num_threads/TestNumThreads.py
`
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
always using the "frame-format-unique" even when you weren't doing the unique
backtrace mode.
---
Full diff: https://github.com/llvm/llvm-project/pull/140993.diff
2 Files Affected:
- (modified) lldb/source/Comma
patdoyle-google wrote:
btw I don't have commit access yet so if you could merge for me that would be
lovely :)
https://github.com/llvm/llvm-project/pull/140978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
@@ -1,7 +1,7 @@
# REQUIRES: lld, arm
# RUN: llvm-mc -triple=thumbv7-eabi %s -filetype=obj -o %t.o
-# RUN: ld.lld %t.o -o %t --section-start=.text=0x8074 -e 0x8075 -s
+# RUN: ld.lld %t.o -o %t --image-base=0x8074 --section-start=.text=0x8074 -e
0x8075 -s
patdo
https://github.com/patdoyle-google updated
https://github.com/llvm/llvm-project/pull/140978
>From 0483de4c38c49fbda6a7965d246c0a5423c47b65 Mon Sep 17 00:00:00 2001
From: Pat Doyle
Date: Wed, 21 May 2025 18:32:59 -0700
Subject: [PATCH 1/2] Update dissassemble-entry-point.s
---
lldb/test/Shell/
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/140978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pat Doyle (patdoyle-google)
Changes
similar to #140570
getting this error:
exit status 1
ld.lld: error: section '.text' address (0x8074) is smaller than image base
(0x1); specify --image-base
---
Full diff: https://github.com/llvm/ll
https://github.com/patdoyle-google created
https://github.com/llvm/llvm-project/pull/140978
similar to #140570
getting this error:
exit status 1
ld.lld: error: section '.text' address (0x8074) is smaller than image base
(0x1); specify --image-base
>From 0483de4c38c49fbda6a7965d246c0a5423
medismailben wrote:
That doesn't solve the issue:
```
File
"/Users/mib/Developer/open-source/llvm.org/lldb/test/API/tools/lldb-dap/disassemble/TestDAP_disassemble.py",
line 28, in test_disassemble
self.assertIn("location", pc_assembly, "Source location missing.")
AssertionError: 'locatio
https://github.com/jasonmolenda approved this pull request.
OK.
https://github.com/llvm/llvm-project/pull/140228
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/140908
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/140738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -10,8 +10,16 @@ add_lldb_unittest(DAPTests
VariablesTest.cpp
LINK_LIBS
+liblldb
lldbDAP
+lldbUtilityHelpers
LLVMTestingSupport
LINK_COMPONENTS
Support
)
+
+set(test_inputs
+ linux-x86_64.out
+ linux-x86_64.core
ashgti wrot
eronnen wrote:
@medismailben Unfortunately I dont own a mac so I can't really test but I think
maybe this patch should fix it: https://github.com/llvm/llvm-project/pull/140975
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing l
Author: Jason Molenda
Date: 2025-05-21T17:38:35-07:00
New Revision: cea82573bb39230f6ddf47f8ee5a83f85c255025
URL:
https://github.com/llvm/llvm-project/commit/cea82573bb39230f6ddf47f8ee5a83f85c255025
DIFF:
https://github.com/llvm/llvm-project/commit/cea82573bb39230f6ddf47f8ee5a83f85c255025.diff
@@ -1102,3 +1103,28 @@ def is_feature_enabled():
return "%s is not supported on this system." % feature
return skipTestIfFn(is_feature_enabled)
+
+
+def skipIfBinaryToLarge(path: Optional[str], maxSize: int):
+"""Skip the test if a binary is to large.
+
medismailben wrote:
Hey @eronnen, I think this change broke the macOS lldb incremental bot:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/26259/execution/node/106/log/?consoleFull
Let me know if you need help to investigate it or if we should revert it if you
don't have t
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/140908
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -10,8 +10,16 @@ add_lldb_unittest(DAPTests
VariablesTest.cpp
LINK_LIBS
+liblldb
lldbDAP
+lldbUtilityHelpers
LLVMTestingSupport
LINK_COMPONENTS
Support
)
+
+set(test_inputs
+ linux-x86_64.out
+ linux-x86_64.core
JDevliegher
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/140738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -136,6 +136,7 @@ def __init__(
self.initialized = False
self.frame_scopes = {}
self.init_commands = init_commands
+self.resolved_breakpoints = set([])
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/140470
__
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/140777
>From e50ea7d279adcb181f68a7156b5fc12d1047f402 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 20 May 2025 11:09:35 -0700
Subject: [PATCH] [lldb-dap] Test gardening, enabling tests and improving doc
comm
@@ -985,7 +1013,10 @@ def request_setBreakpoints(self, file_path, line_array,
data=None):
"type": "request",
"arguments": args_dict,
}
-return self.send_recv(command_dict)
+response = self.send_recv(command_dict)
+breakpo
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/140424
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 5c1d1854c3f93e081405e27fa0f14a3c02ef7cc7 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/6] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/140958
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/140958
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Convert the Maintainers file from reStructuredText to Markdown and include
links to GitHub and Discouse. The new layout improves readability, makes it
easier to navigate from GitHub and matches LLVM
JDevlieghere wrote:
Tip: Click on "Display the rich diff" to see the rendered markdown in the Files
Changed tab.
https://github.com/llvm/llvm-project/pull/140958
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/140958
Convert the Maintainers file from reStructuredText to Markdown and include
links to GitHub and Discouse. The new layout improves readability, makes it
easier to navigate from GitHub and matches LLVM's Main
@@ -1011,7 +1042,10 @@ def request_setFunctionBreakpoints(self, names,
condition=None, hitCondition=Non
"type": "request",
"arguments": args_dict,
}
-return self.send_recv(command_dict)
+response = self.send_recv(command_dict)
+
@@ -422,8 +431,27 @@ def wait_for_breakpoint_events(self, timeout:
Optional[float] = None):
if not event:
break
breakpoint_events.append(event)
+
+self._update_verified_breakpoints(
eronnen wrote:
:100:
https:
Author: Dave Lee
Date: 2025-05-21T12:03:58-07:00
New Revision: e424787a95f2b88ff6f724fd92d87dd0f1cecddc
URL:
https://github.com/llvm/llvm-project/commit/e424787a95f2b88ff6f724fd92d87dd0f1cecddc
DIFF:
https://github.com/llvm/llvm-project/commit/e424787a95f2b88ff6f724fd92d87dd0f1cecddc.diff
LOG:
https://github.com/adrian-prantl approved this pull request.
That looks like a nice improvement!
https://github.com/llvm/llvm-project/pull/140424
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -10,8 +10,16 @@ add_lldb_unittest(DAPTests
VariablesTest.cpp
LINK_LIBS
+liblldb
lldbDAP
+lldbUtilityHelpers
LLVMTestingSupport
LINK_COMPONENTS
Support
)
+
+set(test_inputs
+ linux-x86_64.out
+ linux-x86_64.core
ashgti wrot
@@ -0,0 +1,592 @@
+//===-- RPCServerSourceEmitter.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
jimingham wrote:
This behavior has gotten fairly complicated, you need to describe how it works
somewhere that users can consult.
https://github.com/llvm/llvm-project/pull/140938
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/140788
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ebuka Ezike
Date: 2025-05-21T18:17:38+01:00
New Revision: d219a71849f9209b01ee9e71af83747ad44b2a18
URL:
https://github.com/llvm/llvm-project/commit/d219a71849f9209b01ee9e71af83747ad44b2a18
DIFF:
https://github.com/llvm/llvm-project/commit/d219a71849f9209b01ee9e71af83747ad44b2a18.diff
L
@@ -422,8 +431,27 @@ def wait_for_breakpoint_events(self, timeout:
Optional[float] = None):
if not event:
break
breakpoint_events.append(event)
+
+self._update_verified_breakpoints(
ashgti wrote:
We should call
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
Basically, disable everything except the eh_frame unwind plan, as that's the
only one which supports this right now. The other plans are working with now
trying the interpret everything in between the function
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/140927
Basically, disable everything except the eh_frame unwind plan, as that's the
only one which supports this right now. The other plans are working with now
trying the interpret everything in between the function p
@@ -1011,7 +1042,10 @@ def request_setFunctionBreakpoints(self, names,
condition=None, hitCondition=Non
"type": "request",
"arguments": args_dict,
}
-return self.send_recv(command_dict)
+response = self.send_recv(command_dict)
+
@@ -136,6 +136,7 @@ def __init__(
self.initialized = False
self.frame_scopes = {}
self.init_commands = init_commands
+self.resolved_breakpoints = set([])
ashgti wrote:
Should we use `self.breakpoints = {}` and we can key them by
https://github.com/ashgti approved this pull request.
Looks like a good cleanup!
https://github.com/llvm/llvm-project/pull/140788
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -985,7 +1013,10 @@ def request_setBreakpoints(self, file_path, line_array,
data=None):
"type": "request",
"arguments": args_dict,
}
-return self.send_recv(command_dict)
+response = self.send_recv(command_dict)
+breakpo
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/140761
>From e08ec0697c9d22ad002c83c4e5c7ce3e0d10b0b6 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Wed, 21 May 2025 17:32:48 +0200
Subject: [PATCH 1/2] [LLDB] Pass `/std:...` before `--` on MSVC
---
lldb/test/Shell/h
https://github.com/labath commented:
[I'm sorry, this is going to be long]
Most of David's comments are there because you copied the existing attach
implementation. Even if we go down the path of different attach methods, I
don't think it's necessary to copy all of that. Actual attaching is a
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -312,10 +312,27 @@ NativeProcessLinux::Manager::Attach(
Log *log = GetLog(POSIXLog::Process);
LLDB_LOG(log, "pid = {0:x}", pid);
- auto tids_or = NativeProcessLinux::Attach(pid);
- if (!tids_or)
-return tids_or.takeError();
- ArrayRef<::pid_t> tids = *tids_or;
+
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/140788
>From a9824d7b8a4b6ad4b7baf1d43901aa796beeff2a Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Tue, 20 May 2025 20:11:29 +0100
Subject: [PATCH 1/2] [lldb][lldb-dap][tests] Make sure evaluate test exists
with
labath wrote:
The failure is in lldb_private::HostInfoBase::GetArchitecture. To fix this, you
need to `Initialize()` the HostInfo class.
https://github.com/llvm/llvm-project/pull/138687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:/
labath wrote:
> > Could you also make unit tests for these two functions:
> >
> > * call GetProgramFileSpec and make sure the result is reasonable (exists?)
> > * create a Process and make sure FindProcesses finds it (you can use
> > [this](https://github.com/llvm/llvm-project/blob/52f568dbbb61
@@ -54,6 +54,12 @@ TEST_F(HostInfoTest, GetHostname) {
EXPECT_TRUE(HostInfo::GetHostname(s));
}
+TEST_F(HostInfoTest, GetProgramFileSpec) {
+ // Test GetProgramFileSpec()
labath wrote:
That much is obvious.
```suggestion
```
https://github.com/llvm/llvm-
@@ -54,6 +54,12 @@ TEST_F(HostInfoTest, GetHostname) {
EXPECT_TRUE(HostInfo::GetHostname(s));
}
+TEST_F(HostInfoTest, GetProgramFileSpec) {
+ // Test GetProgramFileSpec()
+ FileSpec filespec = HostInfo::GetProgramFileSpec();
+ EXPECT_FALSE(filespec.GetFilename().IsEmpty()
@@ -90,6 +90,31 @@ TEST(Host, LaunchProcessSetsArgv0) {
ASSERT_THAT(exit_status.get_future().get(), 0);
}
+TEST(Host, FindProcesses) {
+ SubsystemRAII subsystems;
+
+ if (test_arg != 0)
+exit(0);
+
+ ProcessLaunchInfo info;
+ ProcessInstanceInfoList processes;
+ Pro
@@ -10,8 +10,16 @@ add_lldb_unittest(DAPTests
VariablesTest.cpp
LINK_LIBS
+liblldb
lldbDAP
+lldbUtilityHelpers
LLVMTestingSupport
LINK_COMPONENTS
Support
)
+
+set(test_inputs
+ linux-x86_64.out
+ linux-x86_64.core
labath wrot
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/98369
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett commented:
A couple of comments to be addressed but otherwise I have no problems with this.
https://github.com/llvm/llvm-project/pull/138032
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
@@ -0,0 +1,592 @@
+//===-- RPCServerSourceEmitter.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,592 @@
+//===-- RPCServerSourceEmitter.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -312,10 +312,27 @@ NativeProcessLinux::Manager::Attach(
Log *log = GetLog(POSIXLog::Process);
LLDB_LOG(log, "pid = {0:x}", pid);
- auto tids_or = NativeProcessLinux::Attach(pid);
- if (!tids_or)
-return tids_or.takeError();
- ArrayRef<::pid_t> tids = *tids_or;
+
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
https://github.com/DavidSpickett commented:
I leave the discussion of race conditions or lack of to @labath .
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6,7 +6,7 @@ add_lldb_unittest(LLDBCoreTests
DumpDataExtractorTest.cpp
DumpRegisterInfoTest.cpp
FormatEntityTest.cpp
- MangledTest.cpp
+ ItaniumMangledTest.cpp
Michael137 wrote:
I don't mind renaming the file but there are already swift mangling tes
@@ -88,6 +88,7 @@ struct Entry {
FunctionNameWithArgs,
FunctionNameNoArgs,
FunctionMangledName,
+FunctionPrefix,
Michael137 wrote:
If we add a new variable here we will need to update the documentation under
`lldb/docs/use/formatting.rst`
htt
@@ -59,10 +59,24 @@ struct DemangledNameInfo {
/// \endcode
std::pair QualifiersRange;
+ /// Indicates the [start, end) of the function's prefix. This is a
+ /// catch-all range for anything that is not tracked by the rest of
+ /// the pairs.
+ std::pair PrefixRange;
+
@@ -59,10 +59,24 @@ struct DemangledNameInfo {
/// \endcode
std::pair QualifiersRange;
+ /// Indicates the [start, end) of the function's prefix. This is a
+ /// catch-all range for anything that is not tracked by the rest of
+ /// the pairs.
+ std::pair PrefixRange;
+
DavidSpickett wrote:
> I added my gist to the description, let me know what you think
This part looks good, that'll be enough to test this / explain why it exists.
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-com
@@ -0,0 +1,57 @@
+// clang-format off
+
+// REQUIRES: target-windows
+// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s
+// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run"
-o "fr v" -o c | FileCheck %s
+
+#include
Michael1
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mstorsjo approved this pull request.
LGTM
IIRC @petrhosek had commented on this before, and was generally in favour of
it, but I'd still leave it open for a couple days if he wants to comment
further on it.
https://github.com/llvm/llvm-project/pull/138587
__
DavidSpickett wrote:
Candidates for how it ever worked:
* Out of bounds write managing to break something else in just the right way.
Then adding new extension registers meant it was invalidating registers again,
probably guarded control stack registers.
* LLDB got less aggressive about re-read
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/140875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/140875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/140875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Recently the Linux Kernel has fixed a bunch of issues in SME support and while
testing that, I found two tests failing: FAIL:
test_za_register_dynamic_config_main_disabled
(TestZAThreadedDynamic.AArc
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/140875
Recently the Linux Kernel has fixed a bunch of issues in SME support and while
testing that, I found two tests failing: FAIL:
test_za_register_dynamic_config_main_disabled
(TestZAThreadedDynamic.AArch64Z
HemangGadhavi wrote:
> Could you also make unit tests for these two functions:
>
> * call GetProgramFileSpec and make sure the result is reasonable (exists?)
> * create a Process and make sure FindProcesses finds it (you can use
> [this](https://github.com/llvm/llvm-project/blob/52f568dbbb61ffe
@@ -4737,19 +4750,23 @@ CompilerType
TypeSystemClang::CreateGenericFunctionPrototype() {
// Exploring the type
const llvm::fltSemantics &
-TypeSystemClang::GetFloatTypeSemantics(size_t byte_size) {
+TypeSystemClang::GetFloatTypeSemantics(size_t byte_size, bool prefer_float128
https://github.com/beetrees updated
https://github.com/llvm/llvm-project/pull/98369
>From 52f00a10537e738762adc62b5e88b71008336e65 Mon Sep 17 00:00:00 2001
From: beetrees
Date: Wed, 10 Jul 2024 18:49:45 +0100
Subject: [PATCH] [lldb] Add support for displaying `__float128` variables
---
lldb/b
@@ -335,6 +336,10 @@ static const llvm::fltSemantics &GetFloatSemantics(const
TargetSP &target_sp,
return llvm::APFloat::IEEEsingle();
case 8:
return llvm::APFloat::IEEEdouble();
+case 16:
+ if (prefer_float128) {
beetrees wrote:
Done
@@ -133,7 +142,45 @@ static bool GetProcessAndStatInfo(::pid_t pid,
uint32_t Host::FindProcessesImpl(const ProcessInstanceInfoMatch &match_info,
ProcessInstanceInfoList &process_infos) {
- return 0;
+ static const char procdir[] = "/proc/";
+
@@ -18,5 +20,18 @@ void HostInfoAIX::Terminate() { HostInfoBase::Terminate(); }
FileSpec HostInfoAIX::GetProgramFileSpec() {
static FileSpec g_program_filespec;
+ struct psinfo psinfoData;
+ auto BufferOrError = getProcFile(getpid(), "psinfo");
+ if (BufferOrError) {
+
1 - 100 of 122 matches
Mail list logo
