[Lldb-commits] [lld] [lldb] [NFC] Address more bit-field storage sizes (PR #140493)

2025-05-18 Thread Oliver Hunt via lldb-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/140493 >From 90e4c9d97eb84decea39cf28fbd22b99fcbccbda Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Sun, 18 May 2025 20:31:43 -0700 Subject: [PATCH] [NFC] Address more bit-field storage sizes Follow on work from #13

[Lldb-commits] [lld] [lldb] [llvm] [NFC] Address more bit-field storage sizes (PR #140493)

2025-05-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lld-wasm Author: Oliver Hunt (ojhunt) Changes Follow on work from #139825 --- Full diff: https://github.com/llvm/llvm-project/pull/140493.diff 6 Files Affected: - (modified) lld/wasm/InputChunks.h (+3-3) - (modified) lldb/source/Plugins/Language/Obj

[Lldb-commits] [lld] [lldb] [llvm] [NFC] Address more bit-field storage sizes (PR #140493)

2025-05-18 Thread Oliver Hunt via lldb-commits
https://github.com/ojhunt created https://github.com/llvm/llvm-project/pull/140493 Follow on work from #139825 >From 6234ea2b59e49a9da1248875a9fc6ecf294483b4 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Sun, 18 May 2025 20:31:43 -0700 Subject: [PATCH] [NFC] Address more bit-field storage s

[Lldb-commits] [lldb] [lldb-dap] Add unit test for FifoFiles (PR #140480)

2025-05-18 Thread John Harrison via lldb-commits
@@ -0,0 +1,102 @@ +//===-- FifoFilesTest.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-18 Thread Jonas Devlieghere via lldb-commits
@@ -9,113 +9,34 @@ #include "DAP.h" #include "EventHelper.h" #include "JSONUtils.h" +#include "Protocol/ProtocolRequests.h" +#include "Protocol/ProtocolTypes.h" #include "RequestHandler.h" #include "lldb/API/SBInstruction.h" #include "llvm/ADT/StringExtras.h" +using namesp

[Lldb-commits] [lldb] [lldb] Suppport testing with debug-python on Windows (PR #140443)

2025-05-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Makes sense https://github.com/llvm/llvm-project/pull/140443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: +1 on the unit test https://github.com/llvm/llvm-project/pull/140482 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/140482 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add unit test for FifoFiles (PR #140480)

2025-05-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/140480 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] eb467a0 - [lldb-dap] Add unit test for FifoFiles (#140480)

2025-05-18 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-18T19:04:59-07:00 New Revision: eb467a088bd9c5f2755cbc6152195670bf45ae0e URL: https://github.com/llvm/llvm-project/commit/eb467a088bd9c5f2755cbc6152195670bf45ae0e DIFF: https://github.com/llvm/llvm-project/commit/eb467a088bd9c5f2755cbc6152195670bf45ae0e.d

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/140486 None >From 1014235896b79eb4ea05a6822714a66adaa691ac Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 18 May 2025 23:51:58 +0200 Subject: [PATCH 1/2] [lldb-dap] Migrate disassemble request to structured han

[Lldb-commits] [lldb] [lldb-dap] Add unit test for FifoFiles (PR #140480)

2025-05-18 Thread John Harrison via lldb-commits
@@ -0,0 +1,102 @@ +//===-- FifoFilesTest.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] ad67315 - [lldb-dap] Move the command plugins out of the DAP header (#140396)

2025-05-18 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-18T17:32:28-07:00 New Revision: ad673151085cc6cd85ae05714e201e0b6dd78e37 URL: https://github.com/llvm/llvm-project/commit/ad673151085cc6cd85ae05714e201e0b6dd78e37 DIFF: https://github.com/llvm/llvm-project/commit/ad673151085cc6cd85ae05714e201e0b6dd78e37.d

[Lldb-commits] [lldb] [lldb-dap] Move the command plugins out of the DAP header (PR #140396)

2025-05-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/140396 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Progress-On-Dap] Have indeterminate progress actually send events. (PR #140162)

2025-05-18 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/140162 >From 0673dc530a91cb2dd1bdd60dd5136d64e4ed48e8 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 15 May 2025 16:37:06 -0700 Subject: [PATCH 1/2] Have interderminate events actually broadcast to dap --- .

[Lldb-commits] [lldb] [LLDB][Progress-On-Dap] Have indeterminate progress actually send events. (PR #140162)

2025-05-18 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/140162 >From 0673dc530a91cb2dd1bdd60dd5136d64e4ed48e8 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 15 May 2025 16:37:06 -0700 Subject: [PATCH 1/2] Have interderminate events actually broadcast to dap --- .

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-18 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/140150 >From 86ec6c076b9cf8e7afeb7d6bb0e334434f6e0d9e Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 15 May 2025 13:57:11 -0700 Subject: [PATCH 1/8] Update ThreadElfCore --- lldb/include/lldb/Target/UnixSign

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-18 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/140482 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add unit test for FifoFiles (PR #140480)

2025-05-18 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,102 @@ +//===-- FifoFilesTest.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-18 Thread John Harrison via lldb-commits
@@ -627,6 +627,60 @@ struct InstructionBreakpoint { bool fromJSON(const llvm::json::Value &, InstructionBreakpoint &, llvm::json::Path); +/// Properties of a single disassembled instruction, returned by `disassemble` +/// request. +struct DisassembledInstruction

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-18 Thread John Harrison via lldb-commits
https://github.com/ashgti commented: Should we also add unit tests to https://github.com/llvm/llvm-project/blob/main/lldb/unittests/DAP/ProtocolTypesTest.cpp for these new types as well? https://github.com/llvm/llvm-project/pull/140482 ___ lldb-commi

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-18 Thread John Harrison via lldb-commits
@@ -627,6 +627,60 @@ struct InstructionBreakpoint { bool fromJSON(const llvm::json::Value &, InstructionBreakpoint &, llvm::json::Path); +/// Properties of a single disassembled instruction, returned by `disassemble` +/// request. +struct DisassembledInstruction

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-18 Thread John Harrison via lldb-commits
@@ -78,8 +84,40 @@ def set_function_breakpoints(self, functions, condition=None, hitCondition=None) breakpoint_ids = [] for breakpoint in breakpoints: breakpoint_ids.append("%i" % (breakpoint["id"])) +if wait_for_resolve: +self.w

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-18 Thread John Harrison via lldb-commits
@@ -62,9 +64,13 @@ def set_source_breakpoints(self, source_path, lines, data=None): breakpoint_ids = [] for breakpoint in breakpoints: breakpoint_ids.append("%i" % (breakpoint["id"])) +if wait_for_resolve: +self.wait_for_breakpoi

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-18 Thread John Harrison via lldb-commits
@@ -1187,15 +1187,17 @@ def request_locations(self, locationReference): } return self.send_recv(command_dict) -def request_testGetTargetBreakpoints(self): +def request_testGetTargetBreakpoints(self, only_resolved=False): ashgti wrote:

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-18 Thread John Harrison via lldb-commits
@@ -78,8 +84,40 @@ def set_function_breakpoints(self, functions, condition=None, hitCondition=None) breakpoint_ids = [] for breakpoint in breakpoints: breakpoint_ids.append("%i" % (breakpoint["id"])) +if wait_for_resolve: +self.w

[Lldb-commits] [lldb] [lldb-dap] Add unit test for FifoFiles (PR #140480)

2025-05-18 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM, one question about the timeouts https://github.com/llvm/llvm-project/pull/140480 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [lldb-dap] Add unit test for FifoFiles (PR #140480)

2025-05-18 Thread John Harrison via lldb-commits
@@ -0,0 +1,102 @@ +//===-- FifoFilesTest.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Add unit test for FifoFiles (PR #140480)

2025-05-18 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/140480 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Move the command plugins out of the DAP header (PR #140396)

2025-05-18 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/140396 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140482.diff 6 Files Affected: - (modified) lldb/tools/lldb-dap/Handler/DisassembleRequestHandler.cpp (+39-137) - (modified) lldb/tools/lldb-dap/Hand

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140482 >From 1014235896b79eb4ea05a6822714a66adaa691ac Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 18 May 2025 23:51:58 +0200 Subject: [PATCH] [lldb-dap] Migrate disassemble request to structured handler ---

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/140482 None >From b187a83605b9c50ea5dbe7674b755bc8706c2936 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 18 May 2025 23:51:58 +0200 Subject: [PATCH] [lldb-dap] Migrate disassemble request to structured handler

[Lldb-commits] [lldb] [lldb-dap] Add unit test for FifoFiles (PR #140480)

2025-05-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/140480 >From 58f1ceb2c3d7e7e74d06f1ffb8b015794d011db5 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sun, 18 May 2025 14:05:46 -0700 Subject: [PATCH] [lldb-dap] Add unit test for FifoFiles --- lldb/unitt

[Lldb-commits] [lldb] [lldb-dap] Add unit test for FifoFiles (PR #140480)

2025-05-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140480.diff 2 Files Affected: - (modified) lldb/unittests/DAP/CMakeLists.txt (+1) - (added) lldb/unittests/DAP/FifoFilesTest.cpp (+102)

[Lldb-commits] [lldb] [lldb-dap] Add unit test for FifoFiles (PR #140480)

2025-05-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/140480 None >From 8cc54e7e1f2134e2e6352e4f572f3b0f9a3ce59f Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sun, 18 May 2025 14:05:46 -0700 Subject: [PATCH] [lldb-dap] Add unit test for FifoFiles --- lldb

[Lldb-commits] [lldb] [lldb-dap] Move the command plugins out of the DAP header (PR #140396)

2025-05-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/140396 >From 501550d4b96cd746b86467bdb77e432786d7e50c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sat, 17 May 2025 12:20:15 -0700 Subject: [PATCH] [lldb-dap] Move the command plugins out of the DAP head

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140470 >From 542fd2a828a2ed64b23b91c84e444f56e650ad20 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 18 May 2025 20:56:47 +0200 Subject: [PATCH 1/2] [lldb-dap] Attempt to synchronously wait for breakpoints resol

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-18 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py lldb/packa

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) Changes Attempt to improve tests by synchronously waiting for breakpoints to resolve. Not sure if it will fix all the tests but I think it should make the tests more stable --- Full diff: https://github.com/llvm/llvm-

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/140470 Attempt to improve tests by synchronously waiting for breakpoints to resolve. Not sure if it will fix all the tests but I think it should make the tests more stable >From 0bb463172bdabe20e08f743107906bce424c4b

[Lldb-commits] [lldb] [lldb-dap] Move the Variables struct into its own file (PR #140393)

2025-05-18 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-b-1` while building `lldb` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/15391 Here is the relevant p

[Lldb-commits] [lldb] [lldb] Use llvm::is_contained (NFC) (PR #140466)

2025-05-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140466.diff 1 Files Affected: - (modified) lldb/source/Expression/FunctionCaller.cpp (+1-3) ``diff diff --git a/lldb/source/Express

[Lldb-commits] [lldb] [lldb] Use llvm::is_contained (NFC) (PR #140466)

2025-05-18 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140466 None >From 71e7fe5e2898b6ccaef56622515f7e7f8eca005d Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 18 May 2025 10:39:39 -0700 Subject: [PATCH] [lldb] Use llvm::is_contained (NFC) --- lldb/source

[Lldb-commits] [lldb] [lldb-dap] Move the Variables struct into its own file (PR #140393)

2025-05-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/140393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3d0c616 - [lldb-dap] Move the Variables struct into its own file (#140393)

2025-05-18 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-18T10:57:16-07:00 New Revision: 3d0c616ce30cdc3d9c26dda8fdc608a6c85f00a6 URL: https://github.com/llvm/llvm-project/commit/3d0c616ce30cdc3d9c26dda8fdc608a6c85f00a6 DIFF: https://github.com/llvm/llvm-project/commit/3d0c616ce30cdc3d9c26dda8fdc608a6c85f00a6.d

[Lldb-commits] [lldb] [lldb-dap] Member variable cleanup in DAP.{cpp, h} (NFC) (PR #140390)

2025-05-18 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `lldb` at step 17 "test-check-lldb-api". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/5499 Here is the relevant piece of

[Lldb-commits] [lldb] [lldb-dap] Member variable cleanup in DAP.{cpp, h} (NFC) (PR #140390)

2025-05-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/140390 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5ab3c52 - [lldb-dap] Member variable cleanup in DAP.{cpp, h} (NFC) (#140390)

2025-05-18 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-18T10:22:59-07:00 New Revision: 5ab3c5215688f62dbc3707f0e9cc2e8b69c0a7f0 URL: https://github.com/llvm/llvm-project/commit/5ab3c5215688f62dbc3707f0e9cc2e8b69c0a7f0 DIFF: https://github.com/llvm/llvm-project/commit/5ab3c5215688f62dbc3707f0e9cc2e8b69c0a7f0.d

[Lldb-commits] [lldb] [lldb-dap] Move the Variables struct into its own file (PR #140393)

2025-05-18 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/140393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Member variable cleanup in DAP.{cpp, h} (NFC) (PR #140390)

2025-05-18 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/140390 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Basic implementation of a deferred request. (PR #140260)

2025-05-18 Thread Ebuka Ezike via lldb-commits
da-viper wrote: I don't think there is a need for this anymore as #140331 fixes this issue. https://github.com/llvm/llvm-project/pull/140260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] [lldb-dap] Take two at refactoring the startup sequence. (PR #140331)

2025-05-18 Thread Ebuka Ezike via lldb-commits
da-viper wrote: > @da-viper I think this version may be a bit cleaner for #140154, let me know > if that works for you Yeah it fixes the issue in #140154 https://github.com/llvm/llvm-project/pull/140331 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] a86344c - [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (NFC) (#140440)

2025-05-18 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-18T07:36:09-07:00 New Revision: a86344c5a9854ae38d925566d3e9fbc0854254f6 URL: https://github.com/llvm/llvm-project/commit/a86344c5a9854ae38d925566d3e9fbc0854254f6 DIFF: https://github.com/llvm/llvm-project/commit/a86344c5a9854ae38d925566d3e9fbc0854254f6.diff L

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (NFC) (PR #140440)

2025-05-18 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140440 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -60,7 +60,7 @@ namespace lldb_dap { -typedef llvm::DenseMap, SourceBreakpoint> +typedef std::map, SourceBreakpoint> eronnen wrote: changed to `std::map` because I'm not sure how to remove from the map while iterating it with `DenseMap` https://github.c

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/139969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Move the Variables struct into its own file (PR #140393)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen approved this pull request. https://github.com/llvm/llvm-project/pull/140393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/139969 >From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 10 May 2025 20:45:17 +0200 Subject: [PATCH 01/15] support assembly in BreakpointLocationsRequestHandler --- .

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/139969 >From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 10 May 2025 20:45:17 +0200 Subject: [PATCH 01/14] support assembly in BreakpointLocationsRequestHandler --- .

[Lldb-commits] [lldb] [lldb-dap] Move the command plugins out of the DAP header (PR #140396)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen approved this pull request. https://github.com/llvm/llvm-project/pull/140396 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/139969 >From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 10 May 2025 20:45:17 +0200 Subject: [PATCH 01/13] support assembly in BreakpointLocationsRequestHandler --- .

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/139969 >From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 10 May 2025 20:45:17 +0200 Subject: [PATCH 01/11] support assembly in BreakpointLocationsRequestHandler --- .

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/139969 >From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 10 May 2025 20:45:17 +0200 Subject: [PATCH 01/12] support assembly in BreakpointLocationsRequestHandler --- .

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -53,6 +54,8 @@ class LLDB_API SBFileSpec { uint32_t GetPath(char *dst_path, size_t dst_len) const; + bool GetPath(lldb::SBStream &dst_path) const; eronnen wrote: moved to LLDBUtils https://github.com/llvm/llvm-project/pull/139969 _

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -73,7 +87,64 @@ SetBreakpointsRequestHandler::Run( } } - return protocol::SetBreakpointsResponseBody{std::move(response_breakpoints)}; + return response_breakpoints; +} + +std::vector +SetBreakpointsRequestHandler::SetAssemblyBreakpoints( +const protocol::Source

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/139969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -73,7 +87,64 @@ SetBreakpointsRequestHandler::Run( } } - return protocol::SetBreakpointsResponseBody{std::move(response_breakpoints)}; + return response_breakpoints; +} + +std::vector +SetBreakpointsRequestHandler::SetAssemblyBreakpoints( +const protocol::Source

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/139969 >From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 10 May 2025 20:45:17 +0200 Subject: [PATCH 01/10] support assembly in BreakpointLocationsRequestHandler --- .

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/139969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -19,19 +18,50 @@ namespace lldb_dap { llvm::Expected BreakpointLocationsRequestHandler::Run( const protocol::BreakpointLocationsArguments &args) const { - std::string path = args.source.path.value_or(""); uint32_t start_line = args.line; uint32_t start_column = ar

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -73,7 +87,64 @@ SetBreakpointsRequestHandler::Run( } } - return protocol::SetBreakpointsResponseBody{std::move(response_breakpoints)}; + return response_breakpoints; +} + +std::vector +SetBreakpointsRequestHandler::SetAssemblyBreakpoints( +const protocol::Source

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -19,19 +18,50 @@ namespace lldb_dap { llvm::Expected BreakpointLocationsRequestHandler::Run( const protocol::BreakpointLocationsArguments &args) const { - std::string path = args.source.path.value_or(""); uint32_t start_line = args.line; uint32_t start_column = ar

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -73,7 +87,64 @@ SetBreakpointsRequestHandler::Run( } } - return protocol::SetBreakpointsResponseBody{std::move(response_breakpoints)}; + return response_breakpoints; +} + +std::vector +SetBreakpointsRequestHandler::SetAssemblyBreakpoints( +const protocol::Source

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -71,22 +101,26 @@ BreakpointLocationsRequestHandler::Run( locations.emplace_back(line, column); } } +} - // The line entries are sorted by addresses, but we must return the list - // ordered by line / column position. - std::sort(locations.begin(), locations

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -219,6 +221,9 @@ struct DAP { llvm::StringSet<> modules; /// @} + /// Number of lines of assembly code to show when no debug info is available. + uint32_t number_of_assembly_lines_for_nodebug = 32; eronnen wrote: :100: https://github.com/llvm/llvm-

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -53,6 +54,8 @@ class LLDB_API SBFileSpec { uint32_t GetPath(char *dst_path, size_t dst_len) const; + bool GetPath(lldb::SBStream &dst_path) const; eronnen wrote: makes sense, I was trying to avoid the potential problem of the path being longer than `M

[Lldb-commits] [lldb] [lldb] Suppport testing with debug-python on Windows (PR #140443)

2025-05-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes When trying to run the LLDB API tests on Windows with a debug configuration, they fail, because the `_lldb` module won't be found. As explained in https://github.com/llvm/llvm-project/issues/51272, this is because l

[Lldb-commits] [lldb] [lldb] Suppport testing with debug-python on Windows (PR #140443)

2025-05-18 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/140443 When trying to run the LLDB API tests on Windows with a debug configuration, they fail, because the `_lldb` module won't be found. As explained in https://github.com/llvm/llvm-project/issues/51272, this is beca

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (NFC) (PR #140440)

2025-05-18 Thread Matt Arsenault via lldb-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/140440 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits