https://github.com/kazutakahirata edited
https://github.com/llvm/llvm-project/pull/140011
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/140011.diff
2 Files Affected:
- (modified) lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
(+2-2)
- (modified) lldb/source/Plug
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/140011
None
>From cb827a2d99f3d700378ddbe4064b60281c5ef85e Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Wed, 14 May 2025 23:29:42 -0700
Subject: [PATCH] [lldb] Use std::optional::value_of (NFC)
---
.../Pl
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/138209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -366,6 +366,16 @@ The command to obtain the output shown in the example is:
Initially, we will focus on summary strings, and then describe the Python
binding mechanism.
+Summary Format Matching On Pointers
+--
+
+When a summary format is registered for a
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/139817
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/139817
>From e63e53adc0909f481a165eca958a3ac2ca4374ee Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 13 May 2025 17:11:08 -0700
Subject: [PATCH 1/7] [lldb][NFC] Split
RegisterContextUnwind::SavedLocation
@@ -0,0 +1,35 @@
+//===-- DisconnectRequestHandlerTest.cpp
--===//
JDevlieghere wrote:
```suggestion
//===-- DisconnectTest.cpp ===//
```
https://github.com/llvm/llvm-project/pull/1
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/139969
Enable breakpints from assembly sources
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSy
ZequanWu wrote:
Ping.
https://github.com/llvm/llvm-project/pull/138209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
@@ -1,8 +1,11 @@
add_lldb_unittest(DAPTests
+ DAPTest.cpp
+ Handler/DisconnectRequestHandlerTest.cpp
ashgti wrote:
I renamed the file to `Handler/DisconnectTest.cpp` but should the test be
`DisconnectTest` or should it be `DisconnectRequestHandlerTest` since
@@ -0,0 +1,70 @@
+//===-- TestBase.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
https://github.com/JDevlieghere approved this pull request.
I like the test base classes.
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
@@ -1,8 +1,11 @@
add_lldb_unittest(DAPTests
+ DAPTest.cpp
+ Handler/DisconnectRequestHandlerTest.cpp
JDevlieghere wrote:
I somewhat regret the naming of the request handlers (*). Learning from our
mistakes, maybe here we should just call it `Handler/Disconne
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,70 @@
+//===-- TestBase.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/139934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/139934
>From 7dbd5f7467cf1ab31caf935633062a7a66a49757 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Wed, 14 May 2025 17:32:47 +0100
Subject: [PATCH 1/4] [lldb][lldb-dap] clarify the todo.
---
lldb/tools/lldb-dap/
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
>From 6f947e38ad4f744754cf13c1094c4e5e3fd249b6 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 10:31:40 -0700
Subject: [PATCH 1/5] [lldb-dap] Setup DAP for unit testing.
This is a very simple
ashgti wrote:
I added a few extra tests here and some extra base classes to help setup tests.
LMKWYT
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
>From 6f947e38ad4f744754cf13c1094c4e5e3fd249b6 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 10:31:40 -0700
Subject: [PATCH 1/4] [lldb-dap] Setup DAP for unit testing.
This is a very simple
@@ -244,6 +244,20 @@
}
}
],
+"commands": [
+ {
+"command": "lldb-dap.modules.copyProperty",
+"title": "Copy Value"
+ }
+],
+"menus": {
+ "view/item/context": [
ashgti wrote:
Can we also disable the `
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/139934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -416,8 +416,11 @@ llvm::json::Value CreateModule(lldb::SBTarget &target,
lldb::SBModule &module,
} else {
object.try_emplace("symbolStatus", "Symbols not found.");
}
- std::string loaded_addr = std::to_string(
- module.GetObjectFileHeaderAddress().GetLoadAddre
@@ -2032,6 +2032,7 @@ class SourceManagerForFile {
// as they are created in `createSourceManagerForFile` so that they can be
// deleted in the reverse order as they are created.
std::unique_ptr FileMgr;
+ std::unique_ptr DiagOpts;
ojhunt wrote:
@jansvo
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/139934
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-
JDevlieghere wrote:
> Yea, thats my mistake. I made the protocol classes to match the names of the
> spec, but we don't really have to do that as long as the `toJSON`/`fromJSON`
> adjusts the names, they can be different.
I think we discussed this at some point in the past and I'm personally o
bulbazord wrote:
> Pushed again to address David's comments and remove most of the FIXMEs.
> There's one FIXME I've kept in for now:
>
> ```
> // FIXME: SB class server references are stored as non-const references so
> // that we can actually change them as needed. If a parameter is marked
> /
@@ -0,0 +1,20 @@
+// Copy lldb-defines.h from source.
+# RUN: mkdir -p %t/input
+# RUN: mkdir -p %t/output
+# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input
JDevlieghere wrote:
You're mixing two comment styles here, and lit doesn't actually treat
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/139875
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Ari
Author: Kazu Hirata
Date: 2025-05-14T11:21:42-07:00
New Revision: 539265b9044f8cda513e5e65d11f2630a32176cf
URL:
https://github.com/llvm/llvm-project/commit/539265b9044f8cda513e5e65d11f2630a32176cf
DIFF:
https://github.com/llvm/llvm-project/commit/539265b9044f8cda513e5e65d11f2630a32176cf.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/139932
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
> Yeah, that should be possible, and it may make more sense in a world where
> the MainLoop cannot listen on all FD types (since you need the forwarding
> thread anyway). It's unfortunate that there's no synchronization operation
> (at least, not a portable one, FUTEX_FD seems ki
@@ -0,0 +1,16 @@
+// Copy lldb-rpc-defines.h from source.
+# RUN: mkdir -p %t/input
+# RUN: mkdir -p %t/output
+# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input
JDevlieghere wrote:
Is the goal to run this on the sources to catch regressions, or ar
@@ -0,0 +1,65 @@
+#!/usr/bin/env python3
+# Usage: convert-lldb-header-to-rpc-header.py
+# This scripts takes common LLDB headers (such as lldb-defines.h) and replaces
references to LLDB
+# with those for RPC. This happens for:
+# - namespace definitions
+# - namespace usage
+
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
>From 6f947e38ad4f744754cf13c1094c4e5e3fd249b6 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 10:31:40 -0700
Subject: [PATCH 1/3] [lldb-dap] Setup DAP for unit testing.
This is a very simple
ashgti wrote:
Yea, thats my mistake. I made the protocol classes to match the names of the
spec, but we don't really have to do that as long as the `toJSON`/`fromJSON`
adjusts the names, they can be different.
https://github.com/llvm/llvm-project/pull/139937
___
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
>From 6f947e38ad4f744754cf13c1094c4e5e3fd249b6 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 10:31:40 -0700
Subject: [PATCH 1/2] [lldb-dap] Setup DAP for unit testing.
This is a very simple
ashgti wrote:
Should I rename `toDAP`/`fromDAP` to `to_dap`/`from_dap`? I think thats more
inline with how lldb names variables, right?
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/138020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2025-05-14T10:46:01-07:00
New Revision: 28d732a24ef06bab3a2cd6c17975281155f63cd6
URL:
https://github.com/llvm/llvm-project/commit/28d732a24ef06bab3a2cd6c17975281155f63cd6
DIFF:
https://github.com/llvm/llvm-project/commit/28d732a24ef06bab3a2cd6c17975281155f63cd6.d
JDevlieghere wrote:
> Should I rename `toDAP`/`fromDAP` to `to_dap`/`from_dap`? I think thats more
> inline with how lldb names variables, right?
Yes, good point. Currently we have a weird mix of styles. Once everything has
been migrated to use the protocol classes, we should go through the co
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/138020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/139932
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1510,6 +1510,7 @@ bool Target::IgnoreWatchpointByID(lldb::watch_id_t
watch_id,
}
ModuleSP Target::GetExecutableModule() {
+ std::lock_guard guard(m_images.GetMutex());
JDevlieghere wrote:
Let's use the `Modules()` iterable which allows us to use a for-b
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/139932
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/138020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Very excited to see more unit testing!
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This is a very simple case that currently only validates we can create a DAP
instance and send a message over the transport layer. More in-depth tests will
require additional helpers and possibly refactors of
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/139937
This is a very simple case that currently only validates we can create a DAP
instance and send a message over the transport layer. More in-depth tests will
require additional helpers and possibly refactors of DA
https://github.com/JDevlieghere commented:
Looks great!
https://github.com/llvm/llvm-project/pull/139934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -416,8 +416,11 @@ llvm::json::Value CreateModule(lldb::SBTarget &target,
lldb::SBModule &module,
} else {
object.try_emplace("symbolStatus", "Symbols not found.");
}
- std::string loaded_addr = std::to_string(
- module.GetObjectFileHeaderAddress().GetLoadAddre
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/139934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138020
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,
@@ -154,6 +154,21 @@ endif()
add_definitions(-DLLDB_USE_OS_LOG)
+# Make sure we have the macOS SDK root as mig needs it and will silently
+# fail to generate its output files without it.
+if(CMAKE_OSX_SYSROOT)
+ set(MIG_SYSROOT ${CMAKE_OSX_SYSROOT})
+else()
+ execute_proces
https://github.com/JDevlieghere approved this pull request.
LGTM modulo wording.
https://github.com/llvm/llvm-project/pull/138020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/138020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139926
>From 506e8107a397e2ae88d8b952c0a5351cda9fa161 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 09:13:32 -0700
Subject: [PATCH 1/3] [lldb-dap] Adding unittests for Transport.
This adds basic s
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
What it now looks like.
It is a good idea to remove the, symbol status and name from the tree children
?.
---
Full
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/139934
What it now looks like.
It is a good idea to remove the, symbol status and name from the tree children
?.
chelcassanova wrote:
@bulbazord @JDevlieghere Is it possible to take another pass over at this? I
think this should be good to land now.
https://github.com/llvm/llvm-project/pull/138020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/139932.diff
1 Files Affected:
- (modified) lldb/source/Plugins/ExpressionParser/Clang/ASTStructExtractor.cpp
(+1-2)
``diff
diff --
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/139932
None
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/139926
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: John Harrison
Date: 2025-05-14T10:00:01-07:00
New Revision: 441d382f9350c134c958244f252c00923824
URL:
https://github.com/llvm/llvm-project/commit/441d382f9350c134c958244f252c00923824
DIFF:
https://github.com/llvm/llvm-project/commit/441d382f9350c134c958244f252c00923824.diff
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/139848
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/139926
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138612
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/139916
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -169,7 +169,8 @@ Status TCPSocket::Connect(llvm::StringRef name) {
return error;
}
- error = Status::FromErrorString("Failed to connect port");
+ error = Status::FromErrorStringWithFormatv(
+ "Failed to connect {0}:{1}", host_port->hostname, host_port->port);
-
https://github.com/JDevlieghere approved this pull request.
LGTM modulo (pre-existing) typo.
https://github.com/llvm/llvm-project/pull/139916
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
chelcassanova wrote:
Pushed again to address David's comments and remove most of the FIXMEs. There's
one FIXME I've kept in for now:
```
// FIXME: SB class server references are stored as non-const references so
// that we can actually change them as needed. If a parameter is marked
// const, we
labath wrote:
Jason, could you take a look at this as well?
https://github.com/llvm/llvm-project/pull/137155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-05-14T18:22:02+02:00
New Revision: 5fb9dca14aeaf12219ff149bf3a4f94c8dc58d8b
URL:
https://github.com/llvm/llvm-project/commit/5fb9dca14aeaf12219ff149bf3a4f94c8dc58d8b
DIFF:
https://github.com/llvm/llvm-project/commit/5fb9dca14aeaf12219ff149bf3a4f94c8dc58d8b.diff
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138032
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139926
>From 506e8107a397e2ae88d8b952c0a5351cda9fa161 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 09:13:32 -0700
Subject: [PATCH 1/2] [lldb-dap] Adding unittests for Transport.
This adds basic s
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This adds basic support for testing the Transport class and includes tests for
'Read'.
---
Full diff: https://github.com/llvm/llvm-project/pull/139926.diff
2 Files Affected:
- (modified) lldb/unittests/DAP
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/139926
This adds basic support for testing the Transport class and includes tests for
'Read'.
>From 506e8107a397e2ae88d8b952c0a5351cda9fa161 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 09:13:32
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138032
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,
Author: Jonas Devlieghere
Date: 2025-05-14T09:10:49-07:00
New Revision: 998dca42351f3292512af56207b603dc2fef565b
URL:
https://github.com/llvm/llvm-project/commit/998dca42351f3292512af56207b603dc2fef565b
DIFF:
https://github.com/llvm/llvm-project/commit/998dca42351f3292512af56207b603dc2fef565b.d
quic-akaryaki wrote:
@anjenner : an alternative way to report error would be to pass a "diagnostic
object" to CachedFileStream that would collect errors happening during calling
its destructors, report them later, and fail the compilation if any. That might
have been a less intrusive way.
htt
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/139584
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -714,6 +714,8 @@ uint32_t ModuleList::ResolveSymbolContextsForFileSpec(
const FileSpec &file_spec, uint32_t line, bool check_inlines,
SymbolContextItem resolve_scope, SymbolContextList &sc_list) const {
std::lock_guard guard(m_modules_mutex);
+ // If we're looking
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/139584
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
@@ -107,6 +107,7 @@ class ASTUnit {
private:
std::unique_ptr LangOpts;
+ std::shared_ptr DiagOpts;
cor3ntin wrote:
Ouch, this is not great :smile:
Can you leave a FIXME comment in the source? Thanks
https://github.com/llvm/llvm-project/pull/139584
__
https://github.com/ita-sc updated
https://github.com/llvm/llvm-project/pull/139916
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
lldb/source/Host/common/TCPSocket.cpp
``
@@ -837,6 +838,7 @@ class ASTUnit {
static std::unique_ptr LoadFromCommandLine(
const char **ArgBegin, const char **ArgEnd,
std::shared_ptr PCHContainerOps,
+ std::shared_ptr DiagOpts,
jansvoboda11 wrote:
Explained above.
https://github.com
@@ -107,6 +107,7 @@ class ASTUnit {
private:
std::unique_ptr LangOpts;
+ std::shared_ptr DiagOpts;
jansvoboda11 wrote:
I was hoping it could be, but the situation is a bit weird. The documentation
for `ASTUnit::LoadFromCommandLine()` says the `Diagnostics
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (ita-sc)
Changes
Before:
```
(lldb) r
error: connect remote failed (Failed to connect port)
error: Failed to connect port
```
After the patch:
```
(lldb) r
error: connect remote failed (Failed to connect localhost:47140)
error: Failed
https://github.com/ita-sc created
https://github.com/llvm/llvm-project/pull/139916
Before:
```
(lldb) r
error: connect remote failed (Failed to connect port)
error: Failed to connect port
```
After the patch:
```
(lldb) r
error: connect remote failed (Failed to connect localhost:47140)
error: F
@@ -2032,6 +2032,7 @@ class SourceManagerForFile {
// as they are created in `createSourceManagerForFile` so that they can be
// deleted in the reverse order as they are created.
std::unique_ptr FileMgr;
+ std::unique_ptr DiagOpts;
jansvoboda11 wrote:
I
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazu Hirata (kazutakahirata)
Changes
While I am at it, this patch removes the "if" statement.
std::vector::erase(first, last) doesn't do anything when
first == last.
---
Full diff: https://github.com/llvm/llvm-project/pull/139910.diff
1
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/139910
While I am at it, this patch removes the "if" statement.
std::vector::erase(first, last) doesn't do anything when
first == last.
Rate limit · GitHub
body {
1 - 100 of 145 matches
Mail list logo
