JDevlieghere wrote:
I added @labath as a reviewer since he's the MainLoop architect and because we
briefly discussed this at EuroLLVM.
I only glanced at this and I'll take a more in-depth look tomorrow. One thing I
remember form reading the MainLoop docs is that the class itself is not thread
https://github.com/labath approved this pull request.
Thanks.
https://github.com/llvm/llvm-project/pull/139252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
ashgti wrote:
The tests are passing for me locally on macOS, but I need to check Linux at
least before this is fully ready for review. I'll let the CI job run and go
from there.
https://github.com/llvm/llvm-project/pull/139669
___
lldb-commits mailin
ashgti wrote:
Okay, I got this working with a RunLoop instead in PR
https://github.com/llvm/llvm-project/pull/139669. All the macOS tests are
passing for me, but I'll let the CI run to check linux and fix any issues with
that before making the PR ready for review.
https://github.com/llvm/llvm
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/139669
Refactor lldp-dap to use a `lldb_private::MainLoop` to handle events and
protocol messages.
This should ensure more uniform handling of debugger state by ensuring only one
action is being performed at a time. T
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/138093
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const MemberOfNode *node) {
+ Status error;
+ auto base_or_err = Evaluate(node->GetBase());
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const MemberOfNode *node) {
+ Status error;
+ auto base_or_err = Evaluate(node->GetBase());
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const MemberOfNode *node) {
+ Status error;
+ auto base_or_err = Evaluate(node->GetBase());
@@ -0,0 +1,546 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/139301
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans
https://github.com/JDevlieghere approved this pull request.
LGTM modulo the enum nit. Please add a unit test for `Scope` now that that's
possible :-)
https://github.com/llvm/llvm-project/pull/138116
___
lldb-commits mailing list
lldb-commits@lists.ll
@@ -269,17 +271,16 @@ struct Capabilities {
};
llvm::json::Value toJSON(const Capabilities &);
-enum PresentationHint : unsigned {
- ePresentationHintNormal,
- ePresentationHintEmphasize,
- ePresentationHintDeemphasize,
-};
-llvm::json::Value toJSON(PresentationHint hint);
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/139621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Remove the `lldb-vscode` -> `lldb-dap` symlink in the `tools` directory. I
initially created the symlink when we renamed the tool to make migration
easier. I think enough time has passed that we do
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/139621
Remove the `lldb-vscode` -> `lldb-dap` symlink in the `tools` directory. I
initially created the symlink when we renamed the tool to make migration
easier. I think enough time has passed that we don't nee
JDevlieghere wrote:
> FWIW, I completely agree @royitaqi. I'm not saying inter-plugin dependencies
> should be a free-for-all (*), but I think that some kinds of dependencies
> make sense and I definitely think this is one of them. The debug map format
> is intimately tied to the MachO and dar
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/139502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-05-12T13:23:50-07:00
New Revision: 8bec5e5b88de6cfa7cd979b73eafdc2ba69ee053
URL:
https://github.com/llvm/llvm-project/commit/8bec5e5b88de6cfa7cd979b73eafdc2ba69ee053
DIFF:
https://github.com/llvm/llvm-project/commit/8bec5e5b88de6cfa7cd979b73eafdc2ba69ee053.d
@@ -0,0 +1,62 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/ashgti approved this pull request.
One style nit question but otherwise LGTM
https://github.com/llvm/llvm-project/pull/138116
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
@@ -269,17 +271,16 @@ struct Capabilities {
};
llvm::json::Value toJSON(const Capabilities &);
-enum PresentationHint : unsigned {
- ePresentationHintNormal,
- ePresentationHintEmphasize,
- ePresentationHintDeemphasize,
-};
-llvm::json::Value toJSON(PresentationHint hint);
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/138116
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,62 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
dmpots wrote:
ping @clayborg @JDevlieghere @jimingham. Please take a look when you get a
chance. Thanks!
https://github.com/llvm/llvm-project/pull/134418
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
@@ -98,9 +83,15 @@ void ScopesRequestHandler::operator()(const
llvm::json::Object &request) const {
/*statics=*/true,
/*in_scope_only=*/true);
dap.variables.registers = frame.GetRegiste
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/138116
>From 98659ed9520b5364092e72420aee5edea7cb7bba Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Tue, 29 Apr 2025 18:19:18 +0100
Subject: [PATCH 1/3] [lldb][lldb-dap] Migrate 'Scopes' to structured types.
---
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/138116
>From 98659ed9520b5364092e72420aee5edea7cb7bba Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Tue, 29 Apr 2025 18:19:18 +0100
Subject: [PATCH 1/2] [lldb][lldb-dap] Migrate 'Scopes' to structured types.
---
ashgti wrote:
I'll take a look at refactoring the `DAP::Loop` and `EventThread`.
https://github.com/llvm/llvm-project/pull/139596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-05-12T11:56:57-07:00
New Revision: 4086d5ff74729e655c3b29479845c35c971541d9
URL:
https://github.com/llvm/llvm-project/commit/4086d5ff74729e655c3b29479845c35c971541d9
DIFF:
https://github.com/llvm/llvm-project/commit/4086d5ff74729e655c3b29479845c35c971541d9.d
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,62 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/139502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/139252
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-
ashgti wrote:
I've been thinking about that as well. I wasn't sure if there was an easy way
to integrate the event system into a MainLoop helper but that would definitely
help.
https://github.com/llvm/llvm-project/pull/139596
___
lldb-commits mailin
@@ -7,6 +7,9 @@
# CHECK: Stripped: false
# CHECK: Type: executable
# CHECK: Strata: unknown
+# CHECK: Name: .text
+# CHECK-NEXT: code
+# CHECK-NEXT: r-x
DhruvSrivastavaX wrote:
Right, thats reasonable! Will increment accordingly in upcoming additions.
https:/
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -1,20 +1,11 @@
-if(APPLE)
- configure_file(
-${CMAKE_CURRENT_SOURCE_DIR}/lldb-dap-Info.plist.in
-${CMAKE_CURRENT_BINARY_DIR}/lldb-dap-Info.plist
-)
- # Inline info plist in binary (use target_link_options for this as soon as
CMake 3.13 is available)
- set(CMAKE_
https://github.com/igorkudrin updated
https://github.com/llvm/llvm-project/pull/139196
>From 499f723c3f974ff53deb8f354d879e0baaa7a9e8 Mon Sep 17 00:00:00 2001
From: Igor Kudrin
Date: Wed, 7 May 2025 19:55:07 -0700
Subject: [PATCH 1/4] [lldb][core] Fix getting summary of a variable pointing
to
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
JDevlieghere wrote:
I too have been contemplating this for a while...
Given that the request handlers currently lock the API mutex and now the event
thread does the same, this patch means that the two are essentially fully
synchronized. That begs the question: Should these be separate threads
Author: Ilia Kuklin
Date: 2025-05-12T22:59:40+05:00
New Revision: c8a0513a1a694078e5ea927faf8249ce77084d80
URL:
https://github.com/llvm/llvm-project/commit/c8a0513a1a694078e5ea927faf8249ce77084d80
DIFF:
https://github.com/llvm/llvm-project/commit/c8a0513a1a694078e5ea927faf8249ce77084d80.diff
L
https://github.com/kuilpd closed
https://github.com/llvm/llvm-project/pull/139567
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kuilpd wrote:
Thank you!
https://github.com/llvm/llvm-project/pull/139567
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kuilpd ready_for_review
https://github.com/llvm/llvm-project/pull/139567
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/139567
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> @felipepiovezan I don't have a machine to run ObjC tests on, could you apply
> this patch and see if it fixes the issue in #135843 ?
The test pass after applying this patch. Feel free to land this whenever :)
https://github.com/llvm/llvm-project/pull/139567
_
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
A number of unit tests are unstable at the moment and I believe this is due to
event handling between the event thread and the DAP::Loop.
One way this manifests is the 'disconnect' request terminating the SBT
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/139596
A number of unit tests are unstable at the moment and I believe this is due to
event handling between the event thread and the DAP::Loop.
One way this manifests is the 'disconnect' request terminating the SBTarg
JDevlieghere wrote:
Updated the PR and settled on the roundtrip approach for `Source` and
`ExceptionBreakpointsFilter`.
https://github.com/llvm/llvm-project/pull/139502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/139502
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
medismailben wrote:
> @felipepiovezan I don't have a machine to run ObjC tests on, could you apply
> this patch and see if it fixes the issue in #135843 ?
I'll try that for you.
https://github.com/llvm/llvm-project/pull/139567
___
lldb-commits mailin
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,268 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
oontvoo wrote:
> Maybe we should use line 1 than as that's the first real line number?
done! thanks!
https://github.com/llvm/llvm-project/pull/139002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
>From 5746e997eea55c05cbbb63ad6f78ca225c9ac855 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 7 May 2025 21:37:31 -0400
Subject: [PATCH 1/8] [lldb]Make `list` command work with headers when
possible.
---
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Jan Svoboda (jansvoboda11)
Changes
The `DiagnosticOptions` class is currently intrusively reference-counted, which
makes reasoning about its lifetime very difficult in some cases. For example,
`CompilerInvocation` owns the `DiagnosticOptio
llvmbot wrote:
@llvm/pr-subscribers-clang-format
@llvm/pr-subscribers-clang
Author: Jan Svoboda (jansvoboda11)
Changes
The `DiagnosticOptions` class is currently intrusively reference-counted, which
makes reasoning about its lifetime very difficult in some cases. For example,
`CompilerIn
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/139584
The `DiagnosticOptions` class is currently intrusively reference-counted, which
makes reasoning about its lifetime very difficult in some cases. For example,
`CompilerInvocation` owns the `DiagnosticOption
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/139502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,268 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
JDevlieghere wrote:
Fixed by fb9b43a0c56de9b1f36e862565c33e0ad637fb36
https://github.com/llvm/llvm-project/pull/139402
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-05-12T09:51:15-07:00
New Revision: fb9b43a0c56de9b1f36e862565c33e0ad637fb36
URL:
https://github.com/llvm/llvm-project/commit/fb9b43a0c56de9b1f36e862565c33e0ad637fb36
DIFF:
https://github.com/llvm/llvm-project/commit/fb9b43a0c56de9b1f36e862565c33e0ad637fb36.d
JDevlieghere wrote:
I'll take a look. I see it failing here too:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-standalone/1688/
https://github.com/llvm/llvm-project/pull/139402
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
ashgti wrote:
Hmm after a sync, this started causing my cmake to fail to configure with:
```
$ cmake --fresh -B ~/Projects/lldb-build -G Ninja \
-C ~/Projects/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake \
-DCMAKE_EXPORT_COMPILE_COMMANDS=
@@ -0,0 +1,268 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/139552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-05-12T17:32:26+01:00
New Revision: 74a588464c133447b2d644cee7910084f4f57065
URL:
https://github.com/llvm/llvm-project/commit/74a588464c133447b2d644cee7910084f4f57065
DIFF:
https://github.com/llvm/llvm-project/commit/74a588464c133447b2d644cee7910084f4f57065.diff
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/139554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,268 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/139554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
labath wrote:
> Leaving the line-number as `0` somehow result in it couldn't find the file!
> (Changing it to the right line number - or anything non-zero, on the other
> hand works). Any idea why?
Line zero means "I don't know", so it's possible that it's treated specially
(you could step th
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
kuilpd wrote:
@felipepiovezan
I don't have a machine to run ObjC tests on, could you apply this patch and see
if it fixes the issue in #135843 ?
https://github.com/llvm/llvm-project/pull/139567
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ilia Kuklin (kuilpd)
Changes
Attempt an ObjC incomplete type fix even if `GetDereferencedType` returns an
error.
---
Full diff: https://github.com/llvm/llvm-project/pull/139567.diff
1 Files Affected:
- (modified) lldb/source/ValueObject
https://github.com/kuilpd created
https://github.com/llvm/llvm-project/pull/139567
Attempt an ObjC incomplete type fix even if `GetDereferencedType` returns an
error.
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
@@ -0,0 +1,268 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -1114,15 +1115,15 @@ class CommandObjectSourceList : public
CommandObjectParsed {
matching_modules.Clear();
target.GetImages().FindModules(module_spec, matching_modules);
num_matches += matching_modules.ResolveSymbolContextForFilePath(
-
@@ -1170,10 +1171,41 @@ class CommandObjectSourceList : public
CommandObjectParsed {
if (m_options.num_lines == 0)
m_options.num_lines = 10;
const uint32_t column = 0;
+
+ // Headers aren't always in the DWARF but if they have
+
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
JDevlieghere wrote:
> tiny nit for concrete types
@da-viper I don't see your comment, is it possible it wasn't submitted?
https://github.com/llvm/llvm-project/pull/139502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
oontvoo wrote:
> When setting a breakpoint, we pass eSymbolContextLineEntry to the function so
> that it returns a line entry matching the query. In this case, we're not
> really interested in the entire line entry, but I think it should be possible
> the line entry as a carrier for the file
labath wrote:
> But if plain counter preferred, will switch to that.
That is the first idea that crossed my mind, I'm not saying its the best one.
I'm not really sure how would a condition variable help here (like, you still
need some kind of a counter to trigger the condition), but I'm open t
@@ -189,17 +189,23 @@ DWARFUnit::ScopedExtractDIEs
DWARFUnit::ExtractDIEsScoped() {
}
DWARFUnit::ScopedExtractDIEs::ScopedExtractDIEs(DWARFUnit &cu) : m_cu(&cu) {
- m_cu->m_die_array_scoped_mutex.lock_shared();
+ llvm::sys::ScopedLock lock(m_cu->m_die_array_scoped_mutex);
+
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
A contrived performance measurement on my local machine:
1. Attach LLDB to LLDB
2. Measure how much time it takes to run `b operator[]`
Without this patch, we would spend a total of 400ms (which was ~4-5% o
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/139554
A contrived performance measurement on my local machine:
1. Attach LLDB to LLDB
2. Measure how much time it takes to run `b operator[]`
Without this patch, we would spend a total of 400ms (which was ~4-5% of
https://github.com/labath approved this pull request.
yay
https://github.com/llvm/llvm-project/pull/139552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/139545
>From 2aa2fd0d0777bd0bcdd1b627c2c3d306b79512c4 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 12 May 2025 04:38:05 -0700
Subject: [PATCH] [lldb] Merge/unify ABI-provided AArch64 unwind plans
The macos an
labath wrote:
I looked at why the test fails on linux. It turns out it's due to a bunch of
reasons, but most of them are unrelated to the problem at hand. #139545 and
#139550 fix the surrounding issues, and
https://github.com/llvm/llvm-project/commit/c290e555d6e7d196ebbe5fd6d64e0be25275a5b4
i
felipepiovezan wrote:
hi @kuilpd , I think this may have broken the mac incremental bots:
https://green.lab.llvm.org//job/as-lldb-cmake/25656/
```
[2025-05-12T12:08:03.542Z] runCmd: frame variable -d run-target *cfDictionaryRef
[2025-05-12T12:08:03.542Z]
[2025-05-12T12:08:03.542Z] runCmd fail
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
`TypeSystemClang::GetNumBaseClasses` does exactly the same base-class
accounting that we were doing in GetNumChildren. So re-use it.
---
Full diff: https://github.com/llvm/llvm-project/pull/139552.diff
1
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/139552
`TypeSystemClang::GetNumBaseClasses` does exactly the same base-class
accounting that we were doing in GetNumChildren. So re-use it.
Rate limit · GitHub
body {
labath wrote:
@DavidSpickett, following up on
https://github.com/llvm/llvm-project/issues/138085#issuecomment-2871438305, I
noticed that some of these tests don't have the synchronization to prevent the
test attaching before they disable YAMA -- and I think most of those tests are
marked `@fl
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
test_common is force-included into every compilation, which causes problems
when we're compiling assembly code, as we were in #138805.
This avoids that as we can include the header only when it's needed.
---
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/139550
test_common is force-included into every compilation, which causes problems
when we're compiling assembly code, as we were in #138805.
This avoids that as we can include the header only when it's needed.
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp
lld
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The macos and sysv ABIs return functionally equivalent unwind plans, so they
can be implemented in the base AArch64 class. The only difference between them
was that the macos plan provided a "pc=lr" rule where
1 - 100 of 137 matches
Mail list logo
