[Lldb-commits] [lldb] Extending LLDB to work on AIX (PR #102601)

2025-05-06 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi updated https://github.com/llvm/llvm-project/pull/102601 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,

[Lldb-commits] [lldb] Extending LLDB to work on AIX (PR #102601)

2025-05-06 Thread via lldb-commits
https://github.com/ravindra-shinde2 updated https://github.com/llvm/llvm-project/pull/102601 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Ari

[Lldb-commits] [lldb] [lldb] Provide lr value in faulting frame on arm64 (PR #138805)

2025-05-06 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Also while initially working on this issue I found I could fix it in two places in `SavedLocationForRegister` without considering the entirety of the method. This made me unhappy so I spent a bit of time going over all of `SavedLocationForRegister` until I felt confident I

[Lldb-commits] [lldb] [lldb] Provide lr value in faulting frame on arm64 (PR #138805)

2025-05-06 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: While working on this bug, I started musing about how we could switch the logic for how to handle registers more into UnwindPlans, wrote a little discourse with the idea. https://discourse.llvm.org/t/unhappiness-with-the-lldb-unwinder-register-passing-up-the-stack-interrup

[Lldb-commits] [lldb] [lldb] Provide lr value in faulting frame on arm64 (PR #138805)

2025-05-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes When a frameless function faults or is interrupted asynchronously, the UnwindPlan MAY have no register location rule for the return address register (lr on arm64); the value is simply live in the lr reg

[Lldb-commits] [lldb] [lldb] Provide lr value in faulting frame on arm64 (PR #138805)

2025-05-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/138805 When a frameless function faults or is interrupted asynchronously, the UnwindPlan MAY have no register location rule for the return address register (lr on arm64); the value is simply live in the lr regist

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-06 Thread Jacques Pienaar via lldb-commits
https://github.com/jpienaar approved this pull request. https://github.com/llvm/llvm-project/pull/138174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Parse DWARF CFI for discontinuous functions (PR #137006)

2025-05-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Sorry for taking so long to look at this one, it all looks reasonable and I'm fine with this. It would be valid for eh_frame entries which are only valid at throwable locations to not be scoped to a single function. If you had two fu

[Lldb-commits] [lldb] [lldb] Parse DWARF CFI for discontinuous functions (PR #137006)

2025-05-06 Thread Jason Molenda via lldb-commits
@@ -17,23 +17,32 @@ image show-unwind --cached true -n foo # CHECK: UNWIND PLANS for {{.*}}`foo # -# CHECK: Assembly language inspection UnwindPlan: -# CHECK-NEXT: This UnwindPlan originally sourced from assembly insn profiling -# CHECK-NEXT: This UnwindPlan is sourced fro

[Lldb-commits] [lldb] [lldb] Parse DWARF CFI for discontinuous functions (PR #137006)

2025-05-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/137006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Parse DWARF CFI for discontinuous functions (PR #137006)

2025-05-06 Thread Jason Molenda via lldb-commits
@@ -122,6 +122,13 @@ AddressRanges UnwindTable::GetAddressRanges(const Address &addr, return {}; } +static Address GetFunctionOrSymbolAddress(const Address &addr, + const SymbolContext &sc) { + if (Address result = sc.GetFunctionOrS

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/138791 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
@@ -18,6 +18,7 @@ import socket +@skip("SBTarget::ConnectRemote is not synchronous") JDevlieghere wrote: I filed #138803 https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

2025-05-06 Thread Oliver Hunt via lldb-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/137580 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[Lldb-commits] [lldb] [lldb-dap] Migrate attach to typed RequestHandler. (PR #137911)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
@@ -675,12 +675,11 @@ lldb::SBTarget DAP::CreateTarget(lldb::SBError &error) { // enough information to determine correct arch and platform (or ELF can be // omitted at all), so it is good to leave the user an opportunity to specify // those. Any of those three can be lef

[Lldb-commits] [lldb] [lldb-dap] Migrate attach to typed RequestHandler. (PR #137911)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
@@ -10,183 +10,133 @@ #include "EventHelper.h" #include "JSONUtils.h" #include "LLDBUtils.h" +#include "Protocol/ProtocolRequests.h" #include "RequestHandler.h" +#include "lldb/API/SBAttachInfo.h" #include "lldb/API/SBListener.h" +#include "lldb/lldb-defines.h" +#include "llv

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread John Harrison via lldb-commits
@@ -18,6 +18,7 @@ import socket +@skip("SBTarget::ConnectRemote is not synchronous") ashgti wrote: Should we put a link to the bug to fix this test? https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commit

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrate attach to typed RequestHandler. (PR #137911)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/137911 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrate attach to typed RequestHandler. (PR #137911)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
@@ -183,7 +194,7 @@ struct Configuration { /// Specify a source path to remap "./" to allow full paths to be used when /// setting breakpoints in binaries that have relative source paths. - std::optional sourcePath; + std::string sourcePath = ""; JDevlie

[Lldb-commits] [lldb] [lldb-dap] Migrate attach to typed RequestHandler. (PR #137911)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM modulo nits. https://github.com/llvm/llvm-project/pull/137911 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5e70460 - Revert "[lldb-dap] Don't make stopOnAttach the default in attach tests"

2025-05-06 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-06T19:52:00-07:00 New Revision: 5e70460d0155aacbd926f97a7c059de009b6e22d URL: https://github.com/llvm/llvm-project/commit/5e70460d0155aacbd926f97a7c059de009b6e22d DIFF: https://github.com/llvm/llvm-project/commit/5e70460d0155aacbd926f97a7c059de009b6e22d.d

[Lldb-commits] [lldb] [lldb-dap] Ensure we acquire the SB API lock while handling requests. (PR #137026)

2025-05-06 Thread John Harrison via lldb-commits
ashgti wrote: We could move the join to when the DAP::Loop exits, that would unblock the event handler, I think. https://github.com/llvm/llvm-project/pull/137026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread via lldb-commits
https://github.com/kusmour approved this pull request. Let's go (fingercrossed https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Re-enable the lldb-dap tests. We've spent the last week improving the reliability of the test suite and the tests now pass reliably on macOS and Linux at desk. Let's see how things fare on the bots.

[Lldb-commits] [lldb] a123891 - Revert "Branch island with numbers (#138781)"

2025-05-06 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-05-06T18:20:25-07:00 New Revision: a1238911f43c1d46cc7d4e72e2a16c3c9a157d9a URL: https://github.com/llvm/llvm-project/commit/a1238911f43c1d46cc7d4e72e2a16c3c9a157d9a DIFF: https://github.com/llvm/llvm-project/commit/a1238911f43c1d46cc7d4e72e2a16c3c9

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/138791 Re-enable the lldb-dap tests. We've spent the last week improving the reliability of the test suite and the tests now pass reliably on macOS and Linux at desk. Let's see how things fare on the bots.

[Lldb-commits] [lldb] 69a0af3 - [lldb-dap] Don't make stopOnAttach the default in attach tests

2025-05-06 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-06T18:19:37-07:00 New Revision: 69a0af35a5860156836e9e295ecef9de3474db11 URL: https://github.com/llvm/llvm-project/commit/69a0af35a5860156836e9e295ecef9de3474db11 DIFF: https://github.com/llvm/llvm-project/commit/69a0af35a5860156836e9e295ecef9de3474db11.d

[Lldb-commits] [lldb] [lldb-dap] Ensure we acquire the SB API lock while handling requests. (PR #137026)

2025-05-06 Thread via lldb-commits
jeffreytan81 wrote: > What is the other lock involved in the deadlock, other than the API mutex? It is the same lock (`target.GetAPIMutex()`). If you looked at the shared callstacks above, main thread is holding the API mutex in `BaseRequestHandler`, at the same time, event thread above tries

[Lldb-commits] [lldb] Branch island with numbers (PR #138781)

2025-05-06 Thread Adrian Prantl via lldb-commits
@@ -1028,6 +1029,23 @@ DynamicLoaderDarwin::GetStepThroughTrampolinePlan(Thread &thread, thread_plan_sp = std::make_shared( thread, load_addrs, stop_others); } +// One more case we have to consider is "branch islands". These are regular +// TEXT s

[Lldb-commits] [lldb] Branch island with numbers (PR #138781)

2025-05-06 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/21769 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb-dap] Migrate attach to typed RequestHandler. (PR #137911)

2025-05-06 Thread John Harrison via lldb-commits
ashgti wrote: @JDevlieghere I sync this with your change to the attach flow. After syncing I tried to simplify the AttachRequestHandler a bit since there were a lot of branches that were a bit hard to follow. LMKWYT https://github.com/llvm/llvm-project/pull/137911 _

[Lldb-commits] [lldb] Branch island with numbers (PR #138781)

2025-05-06 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,3 @@ +.text adrian-prantl wrote: This is the first cross-architecture assembler source file I've seen :-) https://github.com/llvm/llvm-project/pull/138781 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [lldb] Branch island with numbers (PR #138781)

2025-05-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/138781 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Branch island with numbers (PR #138781)

2025-05-06 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,16 @@ +C_SOURCES := main.c foo.c +CFLAGS_EXTRAS := -std=c99 + +include Makefile.rules + +a.out: main.o padding1.o padding2.o padding3.o padding4.o foo.o + ${CC} ${LDFLAGS} foo.o padding1.o padding2.o padding3.o padding4.o main.o -o a.out + +%.o: $(SRCDIR)/%.s +

[Lldb-commits] [lldb] Branch island with numbers (PR #138781)

2025-05-06 Thread Adrian Prantl via lldb-commits
@@ -1028,6 +1029,23 @@ DynamicLoaderDarwin::GetStepThroughTrampolinePlan(Thread &thread, thread_plan_sp = std::make_shared( thread, load_addrs, stop_others); } +// One more case we have to consider is "branch islands". These are regular +// TEXT s

[Lldb-commits] [lldb] [lldb-dap] Migrate attach to typed RequestHandler. (PR #137911)

2025-05-06 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/137911 >From a43b90dba56bd411b09257d47e3a3091faa09efd Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 29 Apr 2025 17:36:46 -0700 Subject: [PATCH 1/7] [lldb-dap] Migrate attach to typed RequestHandler. This upda

[Lldb-commits] [lldb] Branch island with numbers (PR #138781)

2025-05-06 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/138781 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 11f33ab - Branch island with numbers (#138781)

2025-05-06 Thread via lldb-commits
Author: jimingham Date: 2025-05-06T16:58:01-07:00 New Revision: 11f33ab3850886510a831122078a155be7dc1167 URL: https://github.com/llvm/llvm-project/commit/11f33ab3850886510a831122078a155be7dc1167 DIFF: https://github.com/llvm/llvm-project/commit/11f33ab3850886510a831122078a155be7dc1167.diff LOG

[Lldb-commits] [lldb] Branch island with numbers (PR #138781)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Ship it https://github.com/llvm/llvm-project/pull/138781 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Do the other reviewers have any other concerns? If not I'm happy to merge this on your behalf. https://github.com/llvm/llvm-project/pull/98369 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] Branch island with numbers (PR #138781)

2025-05-06 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/138781 >From 9bcf63344ba475c73029c5c44975bfab57117f80 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Mon, 5 May 2025 15:02:22 -0700 Subject: [PATCH 1/3] Revert "Revert "Handle step-in over a Darwin "branch island".

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang][modules] Lazily load by name lookups in module maps (PR #132853)

2025-05-06 Thread Michael Spencer via lldb-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/132853 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2025-05-06 Thread via lldb-commits
https://github.com/beetrees updated https://github.com/llvm/llvm-project/pull/98369 >From 8c0d1c67386c5a380ce8603562483a45ac30db72 Mon Sep 17 00:00:00 2001 From: beetrees Date: Wed, 10 Jul 2024 18:49:45 +0100 Subject: [PATCH] [lldb] Add support for displaying `__float128` variables --- lldb/b

[Lldb-commits] [lldb] Branch island with numbers (PR #138781)

2025-05-06 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions c,cpp -- lldb/test/API/macosx/branch-islands/foo.c lldb/tes

[Lldb-commits] [lldb] Branch island with numbers (PR #138781)

2025-05-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes Reapply the support for stepping through branch islands, add support for a branch that takes multiple hops to get to the target. --- Full diff: https://github.com/llvm/llvm-project/pull/138781.diff 9 Files Affect

[Lldb-commits] [lldb] Branch island with numbers (PR #138781)

2025-05-06 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/138781 Reapply the support for stepping through branch islands, add support for a branch that takes multiple hops to get to the target. Rate limit · GitHub body { back

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang][modules] Lazily load by name lookups in module maps (PR #132853)

2025-05-06 Thread Jan Svoboda via lldb-commits
jansvoboda11 wrote: Test change LGTM, I was probably trying to get to a minimal test-case and ended up with something that was relying on implementation details. https://github.com/llvm/llvm-project/pull/132853 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] [lldb-dap] Ensure we acquire the SB API lock while handling requests. (PR #137026)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > High level, I do not think it is a good idea to hold the top level API mutex > which is way too large locking scope. We should leave the decision to each > request handler for smaller scope locks if they want to ensure a critical > section. Can we revert the PR? FWIW I d

[Lldb-commits] [lldb] [LLDB] Add IsCoreDumping to ProcessInstanceInfo (PR #138580)

2025-05-06 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/138580 >From 03d5449b30f414e2a3f322f102101dc4b2c05c4f Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Mon, 5 May 2025 11:33:05 -0700 Subject: [PATCH 1/3] Add IsCoredumping to ProcessInfo to use in the future of the

[Lldb-commits] [lldb] [lldb-dap] Ensure we acquire the SB API lock while handling requests. (PR #137026)

2025-05-06 Thread John Harrison via lldb-commits
ashgti wrote: We could revert this and try to add more specific locks in request handlers instead. https://github.com/llvm/llvm-project/pull/137026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I created #138778 to track extending the launch and attach helpers to take breakpoints. https://github.com/llvm/llvm-project/pull/138219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] ba29e60 - [lldb-dap] Change the launch sequence (#138219)

2025-05-06 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-06T15:58:44-07:00 New Revision: ba29e60f9abd5e883579bb78db13fc5a7588 URL: https://github.com/llvm/llvm-project/commit/ba29e60f9abd5e883579bb78db13fc5a7588 DIFF: https://github.com/llvm/llvm-project/commit/ba29e60f9abd5e883579bb78db13fc5a7588.d

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/138219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/138219 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Ensure we acquire the SB API lock while handling requests. (PR #137026)

2025-05-06 Thread via lldb-commits
jeffreytan81 wrote: @ashgti, this change is causing deadlock in our lldb. We have internal changes that main thread's disconnect request handler tried to reset debugger states and call StopEventHandlers() to ensure all event threads to stop. However, this deadlocks now because event thread can

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Allow arrays to be dereferenced in C/C++. (PR #135843)

2025-05-06 Thread via lldb-commits
jimingham wrote: This looks fine to me as well. I had a small typographical nit which you can act on or not as you feel moved to. https://github.com/llvm/llvm-project/pull/135843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Allow arrays to be dereferenced in C/C++. (PR #135843)

2025-05-06 Thread via lldb-commits
@@ -2794,47 +2794,31 @@ ValueObjectSP ValueObject::Dereference(Status &error) { if (m_deref_valobj) return m_deref_valobj->GetSP(); - const bool is_pointer_or_reference_type = IsPointerOrReferenceType(); - if (is_pointer_or_reference_type) { -bool omit_empty_base_c

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Use llvm::bit_ceil (NFC) (PR #138723)

2025-05-06 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/138723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5c3ef62 - [lldb] Use llvm::bit_ceil (NFC) (#138723)

2025-05-06 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-06T14:14:03-07:00 New Revision: 5c3ef62f64cc379b8c5a4cf23bcaf019d398fcc4 URL: https://github.com/llvm/llvm-project/commit/5c3ef62f64cc379b8c5a4cf23bcaf019d398fcc4 DIFF: https://github.com/llvm/llvm-project/commit/5c3ef62f64cc379b8c5a4cf23bcaf019d398fcc4.diff L

[Lldb-commits] [lldb] [lldb] Use llvm::bit_ceil (NFC) (PR #138723)

2025-05-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/138723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,65 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py +# This scripts takes common LLDB headers (such as lldb-defines.h) and replaces references to LLDB +# with those for RPC. This happens for: +# - namespace definitions +# - namespace usage +

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #138416)

2025-05-06 Thread Ely Ronnen via lldb-commits
eronnen wrote: @JDevlieghere thanks for taking the time to test it! I attempted to fix it but still not sure it's good :| https://github.com/llvm/llvm-project/pull/138416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #138416)

2025-05-06 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/138416 >From 3ec9e1962940799ab291aaa8455e6f76da02af0f Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 27 Apr 2025 13:48:45 +0200 Subject: [PATCH 1/6] Change ___lldb_unnamed_symbol generated names to have the file

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Unblocked! Thanks! > > @kusmour Please take another look. In the current state all the test pass > > (reliably) locally and the linux bot seems happy too. Not sure if we want > > to keep the test disabled for now or turn them back on and see what the > > reliability is

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-06 Thread via lldb-commits
kusmour wrote: Unblocked! > @kusmour Please take another look. In the current state all the test pass > (reliably) locally and the linux bot seems happy too. Not sure if we want to > keep the test disabled for now or turn them back on and see what the > reliability is like on the bots. I don

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-06 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: > I don't have an answer to that, but I do know that it's possible to index > pointers in the current implementation. I suggest checking out how it > achieves that and seeing if it can be translated to here. I found `GetSyntheticArrayMember`, hopefully this is the one you're refe

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-06 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/138551 >From cfe7359bd16c1e87932e2ebb8bcdfc88130e9729 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Wed, 30 Apr 2025 22:03:50 +0500 Subject: [PATCH 1/3] [LLDB] Add array subscription and integer parsing to DIL ---

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-06 Thread Ilia Kuklin via lldb-commits
@@ -24,6 +28,8 @@ qualified_id = ["::"] [nested_name_specifier] unqualified_id identifier = ? C99 Identifier ? ; +numeric_literal = ? C99 Integer constant ? ; kuilpd wrote: Yeah, `0b...` and `0o...` formats supported here are missing from C99. How should I

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-06 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: > Apart from the pointer indexing question, this PR also opens the question of > "how should the numbers be represented". Here you represent them as > ValueObjects, which means you have to give them types, which means you have > to find a type system for them, ... Why is that a

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-06 Thread Ilia Kuklin via lldb-commits
@@ -280,6 +311,52 @@ void DILParser::BailOut(const std::string &error, uint32_t loc, m_dil_lexer.ResetTokenIdx(m_dil_lexer.NumLexedTokens() - 1); } +// Parse a numeric_literal. +// +// numeric_literal: +//? Token::numeric_constant ? +// +ASTNodeUP DILParser::ParseNumer

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-06 Thread Ilia Kuklin via lldb-commits
@@ -111,7 +111,36 @@ ASTNodeUP DILParser::ParseUnaryExpression() { llvm_unreachable("invalid token kind"); } } - return ParsePrimaryExpression(); + return ParsePostfixExpression(); +} + +// Parse a postfix_expression. +// +// postfix_expression: +//primary_ex

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,592 @@ +//===-- RPCServerSourceEmitter.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/138032 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-05-06 Thread David Spickett via lldb-commits
DavidSpickett wrote: Please correct the REQUIRES if you have access to such machines to confirm it. Maybe the test is so specific that it is fine to be on only one architecture/os combination. I recall a way in codegen tests to capture a line number in one pattern and re-use that in a check p

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: For what it's worth, while these scripts do work for intended purpose for now, an approach I'd love is to have all this header modification be a subtool of the `lldb-rpc-gen` tool itself. Subtooling a ClangTool is something I'm not too sure on how to do so maybe a better C

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,592 @@ +//===-- RPCServerSourceEmitter.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,592 @@ +//===-- RPCServerSourceEmitter.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,592 @@ +//===-- RPCServerSourceEmitter.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,592 @@ +//===-- RPCServerSourceEmitter.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,592 @@ +//===-- RPCServerSourceEmitter.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,18 @@ +// Copy lldb-rpc-defines.h from source. +# RUN: mkdir -p %t/input +# RUN: mkdir -p %t/output +# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input + +// Run the convert script on it, then run the framework include fix on it. The framework version fix

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,65 @@ +#!/usr/bin/env python3 +# Usage: framework-header-version-fix.py MAJOR MINOR PATCH +# This script modifies lldb-rpc-defines.h to uncomment the macro defines used for the LLDB +# major, minor and patch values as well as populating their definitions. + +import

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-05-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/137383 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,540 @@ +#include "RPCBindingsHarnessEmitter.h" bulbazord wrote: This file will need a license header. https://github.com/llvm/llvm-project/pull/138031 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Given that I wrote some of this code, it looks mostly good to me 😄 Note that this has a dependency on the emitters so this probably shouldn't land quite yet. I commented on some of the FIXMEs because I think now is the time to really address them. It woul

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/138031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/138698 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,44 @@ +#!/usr/bin/env python3 +# Usage: framework-header-include-fix.py +# This script modifies all #include lines in all lldb-rpc headers +# from either filesystem or local includes to liblldbrpc includes. + +import argparse +import os +import re + + +def main(): +

[Lldb-commits] [lldb] [DRAFT][lldb][RPC] Design doc for upstreaming PR (PR #138612)

2025-05-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,107 @@ +LLDB RPC Upstreaming Design Doc +=== + +This document aims to explain the general structure of the upstreaming patches for adding LLDB RPC. The 2 primary concepts explained here will be: + +* How LLDB RPC is used +* How the ``lldb-rp

  1   2   >