Author: Felipe de Azevedo Piovezan
Date: 2025-05-01T18:27:34-07:00
New Revision: 2cae14fdc62a07252ad1c2c2b11678c4539416a6
URL:
https://github.com/llvm/llvm-project/commit/2cae14fdc62a07252ad1c2c2b11678c4539416a6
DIFF:
https://github.com/llvm/llvm-project/commit/2cae14fdc62a07252ad1c2c2b11678c45
felipepiovezan wrote:
I'm going to revert this for now, as I see your commit access is still pending
(hopefully soon!)
https://github.com/llvm/llvm-project/pull/137512
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
felipepiovezan wrote:
@eronnen I believe this is breaking the macOS bots, on the test
TestFoundationDisassembly.py
```
17:54:59 FAIL: test_foundation_disasm
(TestFoundationDisassembly.FoundationDisassembleTestCase)
17:54:59 Do 'disassemble -n func' on each and every 'Code' symbol entry
f
@@ -155,6 +155,9 @@ class SourceManager {
~SourceManager();
FileSP GetLastFile() { return GetFile(m_last_support_file_sp); }
+ bool AsLastLine(bool reverse) {
hapee wrote:
> Is this a typo?
Yes, it is a mistake. I have fixed it. Could you please re
https://github.com/hapee updated
https://github.com/llvm/llvm-project/pull/137515
>From 0d448180a569fa3730f3608a1584de24cf832c88 Mon Sep 17 00:00:00 2001
From: hapee <623151...@qq.com>
Date: Sun, 27 Apr 2025 18:27:04 +0800
Subject: [PATCH] [lldb] print a notice when `source list` paging
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/138174
>From fbe3ca0c2e4d195149f5e3e6b8d32797cf47b9df Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 30 Apr 2025 23:47:37 -0700
Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy
Add `llvm::uninitiali
@@ -161,20 +161,22 @@ static void EventThreadFunction(DAP &dap) {
case lldb::eStateSuspended:
break;
case lldb::eStateStopped:
-// We launch and attach in synchronous mode then the first stop
-// event will not be delivere
@@ -161,20 +161,22 @@ static void EventThreadFunction(DAP &dap) {
case lldb::eStateSuspended:
break;
case lldb::eStateStopped:
-// We launch and attach in synchronous mode then the first stop
-// event will not be delivere
@@ -417,8 +424,11 @@ struct DAP {
lldb::SBMutex GetAPIMutex() const { return target.GetAPIMutex(); }
private:
- std::mutex m_queue_mutex;
+ /// Queue for all incoming messages.
std::deque m_queue;
+ /// Dedicated queue for launching and attaching.
+ std::deque m_launc
@@ -161,20 +161,22 @@ static void EventThreadFunction(DAP &dap) {
case lldb::eStateSuspended:
break;
case lldb::eStateStopped:
ashgti wrote:
May be unrelated but in
[`lldb_private::StateIsRunningState`](https://github.com/llvm/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
lldb/tools/lldb-dap/DAP.cpp lldb/tools/lldb-dap/DAP
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/138219
This PR changes how we treat the launch sequence in lldb-dap.
- Send the initialized event after we finish handling the initialize request,
rather than after we finish attaching or launching.
- Delay han
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/138216
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1213,12 +1212,13 @@ void DAP::ConfigureSourceMaps() {
void DAP::SetConfiguration(const protocol::Configuration &config,
bool is_attach) {
configuration = config;
+ stop_at_entry = config.stopOnEntry;
this->is_attach = is_attach;
- if (con
@@ -675,12 +675,11 @@ lldb::SBTarget DAP::CreateTarget(lldb::SBError &error) {
// enough information to determine correct arch and platform (or ELF can be
// omitted at all), so it is good to leave the user an opportunity to specify
// those. Any of those three can be lef
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/137911
>From a43b90dba56bd411b09257d47e3a3091faa09efd Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 29 Apr 2025 17:36:46 -0700
Subject: [PATCH 1/4] [lldb-dap] Migrate attach to typed RequestHandler.
This upda
kastiglione wrote:
> Similarly, if you're in a frame where we can detect the language, maybe you
> step into a frame you don't have debug info or symbols for.
@bulbazord note that knowing the language of a frame does not depend on debug
info, a symbol alone can be used to identify its languag
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/136766
>From 776dc6da5c5900adb97bb89a9ed7a60478bf05e1 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Tue, 22 Apr 2025 13:58:25 -0700
Subject: [PATCH 01/10] [lldb] Expose language plugin commands based based on
lang
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
lldb/source/Core/ModuleList.cpp
``
View
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
That calls an unknown amount of Python code, and can do quite a bit of work -
especially if people do things like launch scripted processes in this script
affordance. Doing that while holding a major lock like the
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/138216
That calls an unknown amount of Python code, and can do quite a bit of work -
especially if people do things like launch scripted processes in this script
affordance. Doing that while holding a major lock li
@@ -0,0 +1,142 @@
+"""
+Test saving a mini dump, from yamilized examples.
+"""
+
+import os
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class ProcessSaveCoreMinidumpTestCaseYaml(TestBase):
+
@@ -0,0 +1,142 @@
+"""
+Test saving a mini dump, from yamilized examples.
+"""
+
+import os
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class ProcessSaveCoreMinidumpTestCaseYaml(TestBase):
+
@@ -0,0 +1,142 @@
+"""
+Test saving a mini dump, from yamilized examples.
+"""
+
+import os
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class ProcessSaveCoreMinidumpTestCaseYaml(TestBase):
+
@@ -0,0 +1,142 @@
+"""
+Test saving a mini dump, from yamilized examples.
+"""
+
+import os
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class ProcessSaveCoreMinidumpTestCaseYaml(TestBase):
+
@@ -0,0 +1,35 @@
+--- !minidump
+Streams:
+ - Type:SystemInfo
+Processor Arch: AMD64
+Processor Level: 6
+Processor Revision: 15876
+Number of Processors: 40
+Platform ID: Linux
+CSD Version: 'Linux 3.13.0-91-generic'
+CPU:
+
@@ -0,0 +1,142 @@
+"""
+Test saving a mini dump, from yamilized examples.
+"""
+
+import os
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class ProcessSaveCoreMinidumpTestCaseYaml(TestBase):
+
kastiglione wrote:
@jimingham I've added 2f91d3f which includes a long help for `language` to
describe this behavior. I'll look into making `help` show the output you
suggest.
https://github.com/llvm/llvm-project/pull/136766
___
lldb-commits mailing
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/136766
>From 776dc6da5c5900adb97bb89a9ed7a60478bf05e1 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Tue, 22 Apr 2025 13:58:25 -0700
Subject: [PATCH 1/9] [lldb] Expose language plugin commands based based on
langua
@@ -380,6 +380,25 @@ template class
RangeVector {
return nullptr;
}
+ const Entry *FindEntryThatIntersects(const Entry &range) const {
+#ifdef ASSERT_RANGEMAP_ARE_SORTED
+assert(IsSorted());
+#endif
+if (!m_entries.empty()) {
+ typename Collection::const_
jimingham wrote:
This looks pretty good. This is user-facing so you should describe this aspect
of the summary formatter matching somewhere in the "Variable formatting" doc
page.
https://github.com/llvm/llvm-project/pull/138209
___
lldb-commits mail
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/138211
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jimingham
Date: 2025-05-01T16:01:50-07:00
New Revision: 471fe9c68948d339016d0c4aa66c116ff31e0516
URL:
https://github.com/llvm/llvm-project/commit/471fe9c68948d339016d0c4aa66c116ff31e0516
DIFF:
https://github.com/llvm/llvm-project/commit/471fe9c68948d339016d0c4aa66c116ff31e0516.diff
LOG
@@ -96,6 +97,8 @@ class FormattersMatchCandidate {
bool DidStripTypedef() const { return m_flags.stripped_typedef; }
+ uint32_t GetPtrStrippedDepth() const { return m_ptr_stripped_depth; }
jimingham wrote:
I think this reads better as GetPtrStrippingDepth
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/138206
>From 91ce0997c03f87ec617ec2a113e7e88f1a88de11 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 1 May 2025 14:53:08 -0700
Subject: [PATCH 1/4] Change custom regions to be intersections, add test cases
fo
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h --
lldb/include/lldb/Utility/RangeMap.h lldb/source/Ta
https://github.com/Jlalond approved this pull request.
https://github.com/llvm/llvm-project/pull/138211
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,142 @@
+"""
+Test saving a mini dump, from yamilized examples.
+"""
+
+import os
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class ProcessSaveCoreMinidumpTestCaseYaml(TestBase):
+
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/138206
>From 91ce0997c03f87ec617ec2a113e7e88f1a88de11 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 1 May 2025 14:53:08 -0700
Subject: [PATCH 1/4] Change custom regions to be intersections, add test cases
fo
@@ -0,0 +1,142 @@
+"""
+Test saving a mini dump, from yamilized examples.
+"""
+
+import os
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
Jlalond wrote:
There is actually `Tes
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
I changed the option name from at-first-stop (-F) to at-initial-stop (-I) but
missed one place in the testsuite.
---
Full diff: https://github.com/llvm/llvm-project/pull/138211.diff
1 Files Affected:
- (modified
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/138211
I changed the option name from at-first-stop (-F) to at-initial-stop (-I) but
missed one place in the testsuite.
>From 6780540d600677083c692cebd99d921684948465 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date:
@@ -380,6 +380,25 @@ template class
RangeVector {
return nullptr;
}
+ const Entry *FindEntryThatIntersects(const Entry &range) const {
+#ifdef ASSERT_RANGEMAP_ARE_SORTED
+assert(IsSorted());
+#endif
+if (!m_entries.empty()) {
+ typename Collection::const_
@@ -0,0 +1,142 @@
+"""
+Test saving a mini dump, from yamilized examples.
+"""
+
+import os
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
dmpots wrote:
Maybe we should test so
@@ -6689,6 +6689,25 @@ static void GetCoreFileSaveRangesStackOnly(Process
&process,
}
}
+// TODO: We should refactor CoreFileMemoryRanges to use the lldb range type,
and
+// then add an intersect method on it, or MemoryRegionInfo.
+static MemoryRegionInfo
+Intersect(const
@@ -6698,9 +6717,16 @@ static void GetUserSpecifiedCoreFileSaveRanges(Process
&process,
return;
for (const auto &range : regions) {
-auto entry = option_ranges.FindEntryThatContains(range.GetRange());
-if (entry)
- AddRegion(range, true, ranges);
+auto
@@ -380,6 +380,25 @@ template class
RangeVector {
return nullptr;
}
+ const Entry *FindEntryThatIntersects(const Entry &range) const {
+#ifdef ASSERT_RANGEMAP_ARE_SORTED
+assert(IsSorted());
+#endif
+if (!m_entries.empty()) {
+ typename Collection::const_
@@ -0,0 +1,142 @@
+"""
+Test saving a mini dump, from yamilized examples.
+"""
+
+import os
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class ProcessSaveCoreMinidumpTestCaseYaml(TestBase):
+
@@ -6689,6 +6689,25 @@ static void GetCoreFileSaveRangesStackOnly(Process
&process,
}
}
+// TODO: We should refactor CoreFileMemoryRanges to use the lldb range type,
and
+// then add an intersect method on it, or MemoryRegionInfo.
+static MemoryRegionInfo
+Intersect(const
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h --
lldb/test/API/functionalities/data-formatter/data-f
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/functionalities/data-formatter/data-formatter-ptr-matching/Tes
Author: Ely Ronnen
Date: 2025-05-01T15:32:34-07:00
New Revision: b69957fa642635f769c3aa33a539f74497df0b4d
URL:
https://github.com/llvm/llvm-project/commit/b69957fa642635f769c3aa33a539f74497df0b4d
DIFF:
https://github.com/llvm/llvm-project/commit/b69957fa642635f769c3aa33a539f74497df0b4d.diff
LO
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/137512
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
Currently, the type `T`'s summary formatter will be matched for `T`, `T*`,
`T**` and so on. This is unexpected in many data formatters. Such unhandled
cases could cause the data formatter to crash. An example w
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/138209
Currently, the type `T`'s summary formatter will be matched for `T`, `T*`,
`T**` and so on. This is unexpected in many data formatters. Such unhandled
cases could cause the data formatter to crash. An example
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/136766
>From 776dc6da5c5900adb97bb89a9ed7a60478bf05e1 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Tue, 22 Apr 2025 13:58:25 -0700
Subject: [PATCH 1/8] [lldb] Expose language plugin commands based based on
langua
jimingham wrote:
The code looks fine but this would be super confusing if you don't know what
is happening here, so we have to document it somehow. We can release note it
but a lot of people don't read release notes. We probably should put something
in the Tutorial, which discusses command
@@ -145,6 +145,28 @@ SaveCoreOptions::GetThreadsToSave() const {
return thread_collection;
}
+uint64_t SaveCoreOptions::GetCurrentSizeInBytes(Status &error) {
bulbazord wrote:
Suggestion: `llvm::Expected`. Callers will be forced to handle the
error instead
@@ -119,6 +119,19 @@ class LLDB_API SBSaveCoreOptions {
/// an empty collection will be returned.
SBThreadCollection GetThreadsToSave() const;
+ /// Get the current total number of bytes the core is expected to be but not
bulbazord wrote:
Suggestion: `
@@ -119,6 +119,19 @@ class LLDB_API SBSaveCoreOptions {
/// an empty collection will be returned.
SBThreadCollection GetThreadsToSave() const;
+ /// Get the current total number of bytes the core is expected to be but not
bulbazord wrote:
Suggestion: `
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/138206
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/138206
>From 91ce0997c03f87ec617ec2a113e7e88f1a88de11 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 1 May 2025 14:53:08 -0700
Subject: [PATCH 1/3] Change custom regions to be intersections, add test cases
fo
chelcassanova wrote:
I can add shell tests 👍🏾
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCore
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Custom regions in Process::GetUserSpecifiedCoreFileSaveRanges originally used
entry that contains. This made sense on my first attempt, but what we really
want are *intersecting* regions. This is so the user
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/138206
Custom regions in Process::GetUserSpecifiedCoreFileSaveRanges originally used
entry that contains. This made sense on my first attempt, but what we really
want are *intersecting* regions. This is so the user ca
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/138030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
Sounds good, I can close this PR then and add the shell tests back in once the
PR for the client-side emitters are up.
https://github.com/llvm/llvm-project/pull/138030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
https://github.com/jimingham approved this pull request.
LEBTM
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
> Also note that all the other `QueueThreadPlanFor*` functions still have a
> version without SBError :/
Yes, we don't remove API's from the SB API set, which means we do get left with
our mistakes.
https://github.com/llvm/llvm-project/pull/137904
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/138174
>From de1b49fc6b8819b591e48b81634567ceeffe5089 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 30 Apr 2025 23:47:37 -0700
Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy
Add `llvm::uninitiali
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138020
>From 350648f15e834a3734ab9fcafb610d27d9c6dd33 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 28 Apr 2025 10:28:03 -0700
Subject: [PATCH] [lldb][cmake] Error out when building debugserver with
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/137751
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -153,10 +173,37 @@ constexpr llvm::StringRef lookupStrings[] = {
"${target.file.fullpath}",
"${var.dummy-var-to-test-wildcard}"};
-TEST(FormatEntity, LookupAllEntriesInTree) {
+TEST_F(FormatEntityTest, LookupAllEntriesInTree) {
for (const llvm::StringRef testStri
DrSergei wrote:
Just a question, as far as I see, there is no `Static` scope and static
variables are included in the `Global` scope. This may not be optimal for large
projects with a large number of global variables (for example, global variables
provided by libraries). Basically, there are n
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/138020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -153,10 +173,37 @@ constexpr llvm::StringRef lookupStrings[] = {
"${target.file.fullpath}",
"${var.dummy-var-to-test-wildcard}"};
-TEST(FormatEntity, LookupAllEntriesInTree) {
+TEST_F(FormatEntityTest, LookupAllEntriesInTree) {
for (const llvm::StringRef testStri
@@ -154,6 +154,20 @@ endif()
add_definitions(-DLLDB_USE_OS_LOG)
+if(NOT CMAKE_OSX_SYSROOT)
+ execute_process(COMMAND xcodebuild -version -sdk macosx Path
+OUTPUT_VARIABLE SDKROOT
+ERROR_QUIET
+OUTPUT_STRIP_TRAILING_WHITESPACE)
+
+ if(NOT EXISTS ${SDKROOT})
+
ojhunt wrote:
> I realize you've got downstream users making use of this additional
> qualifier. Can you mention how prevalent the use is?
it's used a bunch in libcxx, libcxxabi, libunwind, compiler-rt and a few other
places. We can obviously use a macro to wrap this, but we need to have a wa
Author: jimingham
Date: 2025-05-01T13:46:19-07:00
New Revision: 4fdb8cb42f73ebec9a3bdd37b2f27c222f9afd87
URL:
https://github.com/llvm/llvm-project/commit/4fdb8cb42f73ebec9a3bdd37b2f27c222f9afd87
DIFF:
https://github.com/llvm/llvm-project/commit/4fdb8cb42f73ebec9a3bdd37b2f27c222f9afd87.diff
LOG
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/137410
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DrSergei wrote:
> There's an existing PR that adds this functionality as well: #121269 with
> quite a bit of discussion. Does this PR have anything that's lacking in the
> other PR?
It's quite similar. I use slightly different functionalites, but main idea is
the same. Another PR looks abando
JDevlieghere wrote:
> > After the response to `configurationDone` is sent, the debug adapter may
> > respond to the `launch` or `attach` request, and then the debug session has
> > started.
>
> Technically the response of launch/attach should be the end of the chain. But
> because of the sing
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137904
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
eronnen wrote:
Also note that all the other `QueueThreadPlanFor*` functions still have a
version without SBError :/
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
eronnen wrote:
Removed the version without `SBError`, but I'm not sure what to do with it in
the python test because this function is not called in the test body, so we
can't assert it
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137904
>From b901b71abbaac768e67913cdbc15da2337c8bb03 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 30 Apr 2025 02:00:44 +0200
Subject: [PATCH 1/4] Expose QueueThreadPlanForStepSingleInstruction function
to SBT
JDevlieghere wrote:
There's an existing PR that adds this functionality as well:
https://github.com/llvm/llvm-project/pull/121269 with quite a bit of
discussion. Does this PR have anything that's lacking in the other PR?
https://github.com/llvm/llvm-project/pull/138160
@@ -155,6 +155,9 @@ class SourceManager {
~SourceManager();
FileSP GetLastFile() { return GetFile(m_last_support_file_sp); }
+ bool AsLastLine(bool reverse) {
JDevlieghere wrote:
Is this a typo?
```suggestion
bool AtLastLine(bool reverse) {
```
https:
kastiglione wrote:
I have not implemented the mentioned idea of using the top frame that has a
known language. I think that situation would be rare, and makes this more
magic. I think it's better to wait for feedback then to add implement something
that users may not need/want.
https://github
https://github.com/DrSergei updated
https://github.com/llvm/llvm-project/pull/138160
>From 95b85c773ec662ab47420d5c820c84dd18c63d89 Mon Sep 17 00:00:00 2001
From: Druzhkov Sergei
Date: Thu, 1 May 2025 18:46:22 +0300
Subject: [PATCH] [lldb-dap] Add runInTerminal support for Windows
---
.../run
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/136766
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sa
kastiglione wrote:
I've updated the implementation to not resolve to a language specific command
whenever the entered command prefix matches a top level command.
In other words, given a python command `abcdef` and a language specific command
`abc`, then running `abc` will resolve to the python
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/commands/command/language/TestFrameLanguageCommands.py
lldb/t
kazutakahirata wrote:
@real-mikhail @jimingham I've landed 2bff80f25d51e24d3c552e033a2863dd36ef648b
to fix a warning from this PR. Thanks!
https://github.com/llvm/llvm-project/pull/129092
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
JDevlieghere wrote:
> Is it possible to do the launching and attaching in asynchronous mode so that
> the stop events are always emitted?
Yes, that's the alternative I mentioned the PR description:
> An alternative approach could be to stop trying to hide the initial stop
> event, and instea
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/136766
>From 94caf0b58ace58ae5159e3819f776ad6b2988329 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Tue, 22 Apr 2025 13:58:25 -0700
Subject: [PATCH 1/7] [lldb] Expose language plugin commands based based on
langua
Author: Kazu Hirata
Date: 2025-05-01T12:27:08-07:00
New Revision: 2bff80f25d51e24d3c552e033a2863dd36ef648b
URL:
https://github.com/llvm/llvm-project/commit/2bff80f25d51e24d3c552e033a2863dd36ef648b
DIFF:
https://github.com/llvm/llvm-project/commit/2bff80f25d51e24d3c552e033a2863dd36ef648b.diff
L
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/136766
>From 94caf0b58ace58ae5159e3819f776ad6b2988329 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Tue, 22 Apr 2025 13:58:25 -0700
Subject: [PATCH 1/6] [lldb] Expose language plugin commands based based on
langua
@@ -1018,6 +1018,26 @@ CommandInterpreter::VerifyUserMultiwordCmdPath(Args
&path, bool leaf_is_command,
return cur_as_multi;
}
+CommandObjectSP CommandInterpreter::GetFrameLanguageCommand() const {
+ if (auto frame_sp = GetExecutionContext().GetFrameSP()) {
+auto frame
1 - 100 of 159 matches
Mail list logo
