https://github.com/jasonmolenda approved this pull request.
https://github.com/llvm/llvm-project/pull/137543
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
https://github.com/llvm/llvm-project/pull/137542
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
https://github.com/llvm/llvm-project/pull/137541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
https://github.com/llvm/llvm-project/pull/137540
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -322,6 +323,186 @@ enum SteppingGranularity : unsigned {
bool fromJSON(const llvm::json::Value &, SteppingGranularity &,
llvm::json::Path);
+/// Information about a breakpoint created in `setBreakpoints`,
+/// `setFunctionBreakpoints`, `setInstructionBreakpoin
@@ -322,6 +323,186 @@ enum SteppingGranularity : unsigned {
bool fromJSON(const llvm::json::Value &, SteppingGranularity &,
llvm::json::Path);
+/// Information about a breakpoint created in `setBreakpoints`,
+/// `setFunctionBreakpoints`, `setInstructionBreakpoin
@@ -43,6 +43,32 @@ bool fromJSON(const json::Value &Params, Source &S,
json::Path P) {
O.map("sourceReference", S.sourceReference);
}
+static llvm::json::Value ToString(PresentationHint hint) {
ashgti wrote:
toJSON?
Then on line 67 you don't need t
@@ -322,6 +323,186 @@ enum SteppingGranularity : unsigned {
bool fromJSON(const llvm::json::Value &, SteppingGranularity &,
llvm::json::Path);
+/// Information about a breakpoint created in `setBreakpoints`,
+/// `setFunctionBreakpoints`, `setInstructionBreakpoin
JDevlieghere wrote:
Depends on https://github.com/llvm/llvm-project/pull/137542 because
`MachThreadList` relies on `MachThread` to transitively include
`PThreadMutex.h`.
https://github.com/llvm/llvm-project/pull/137543
___
lldb-commits mailing list
l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The debugserver code predates modern C++, but with C++11 and later there's no
need to have something like PThreadMutex. This migrates MachThread away from
PThreadMutex in preparation for removing it
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/137543
The debugserver code predates modern C++, but with C++11 and later there's no
need to have something like PThreadMutex. This migrates MachThread away from
PThreadMutex in preparation for removing it.
>Fro
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The debugserver code predates modern C++, but with C++11 and later there's no
need to have something like PThreadMutex. This migrates MachThreadList away
from that class in preparation for removing
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/137542
The debugserver code predates modern C++, but with C++11 and later there's no
need to have something like PThreadMutex. This migrates MachThreadList away
from that class in preparation for removing PThread
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The debugserver code predates modern C++, but with C++11 and later there's no
need to have something like PThreadMutex. This migrates DNBLog away from that
class in preparation for removing PThreadM
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/137541
The debugserver code predates modern C++, but with C++11 and later there's no
need to have something like PThreadMutex. This migrates DNBLog away from that
class in preparation for removing PThreadMutex.
Author: Jonas Devlieghere
Date: 2025-04-27T11:25:56-07:00
New Revision: daa1e175531495b0ba07179a2c7fc609eb7d371c
URL:
https://github.com/llvm/llvm-project/commit/daa1e175531495b0ba07179a2c7fc609eb7d371c
DIFF:
https://github.com/llvm/llvm-project/commit/daa1e175531495b0ba07179a2c7fc609eb7d371c.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/137485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The debugserver code predates modern C++, but with C++11 and later there's no
need to have something like PThreadMutex. This migrates DNBTimer away from that
class in preparation for removing PThrea
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/137540
The debugserver code predates modern C++, but with C++11 and later there's no
need to have something like PThreadMutex. This migrates DNBTimer away from that
class in preparation for removing PThreadMutex.
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/137485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
Awesome!
https://github.com/llvm/llvm-project/pull/137426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM but please format the table before merging.
https://github.com/llvm/llvm-project/pull/137522
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
@@ -85,10 +85,27 @@ A complete list of currently supported format string
variables is listed below:
+---+-
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/137522
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-04-27T10:21:19-07:00
New Revision: b546baff48767d54da03049d4f30690649a5e599
URL:
https://github.com/llvm/llvm-project/commit/b546baff48767d54da03049d4f30690649a5e599
DIFF:
https://github.com/llvm/llvm-project/commit/b546baff48767d54da03049d4f30690649a5e599.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/137380
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Documents https://github.com/llvm/llvm-project/pull/131836
---
Full diff: https://github.com/llvm/llvm-project/pull/137522.diff
1 Files Affected:
- (modified) lldb/docs/use/formatting.rst (+49-1)
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/137522
>From 2388b0951a3e9b0e2ebd297881f17423c8d68b4e Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sun, 27 Apr 2025 11:23:20 +0100
Subject: [PATCH 1/2] [lldb][docs] Document new frame-format variables
---
lld
@@ -38,7 +42,7 @@ int main() {
#--- commands.input
settings set -f frame-format "custom-frame '${function.basename}'\n"
-break set -l 5 -f main.cpp
+break set -n bar
Michael137 wrote:
Without this for some reason Linux PR CI was failing with:
```
(lldb) sett
https://github.com/Michael137 deleted
https://github.com/llvm/llvm-project/pull/137408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -29,7 +33,7 @@ int main() { return bar(); }
#--- commands.input
settings set -f frame-format "custom-frame '${function.template-arguments}'\n"
-break set -l 4 -f main.cpp
+break set -n func
Michael137 wrote:
Without this for some reason Linux PR CI was fai
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/137408
>From db417e84e944ee80f045414a4ce0f83a3e423e45 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 25 Apr 2025 22:49:36 +0100
Subject: [PATCH 1/2] [lldb][CPlusPLus] Make C++ frame-format work without
debu
Michael137 wrote:
Need to reformat things a bit
https://github.com/llvm/llvm-project/pull/137522
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/137522
Documents https://github.com/llvm/llvm-project/pull/131836
>From 2388b0951a3e9b0e2ebd297881f17423c8d68b4e Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sun, 27 Apr 2025 11:23:20 +0100
Subject: [PATCH] [l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
object indexing causes key error.
Initial commit #290ba2
---
Full diff: https://github.com/llvm/llvm-project/pull/137516.diff
1 Files Affected:
- (modified)
lldb/test/API/tools/lldb-dap/stackTraceDisassem
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/137516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ebuka Ezike
Date: 2025-04-27T15:32:43+01:00
New Revision: ee4b34cf3292382b153ba777fa1092858bea13f5
URL:
https://github.com/llvm/llvm-project/commit/ee4b34cf3292382b153ba777fa1092858bea13f5
DIFF:
https://github.com/llvm/llvm-project/commit/ee4b34cf3292382b153ba777fa1092858bea13f5.diff
L
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/137516
object indexing causes key error.
Initial commit #290ba2
>From f0279f88319ab70d0748d3fcde0cc0d279916e6e Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Sun, 27 Apr 2025 15:03:19 +0100
Subject: [PATCH] [NFC][
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (hapee)
Changes
This PR fixes the issue where the `list` command does not output a prompt when
reaching the end of the file.
Closes #128507.
---
Full diff: https://github.com/llvm/llvm-project/pull/137515.diff
2 Files Affected
https://github.com/hapee created
https://github.com/llvm/llvm-project/pull/137515
This PR fixes the issue where the `list` command does not output a prompt when
reaching the end of the file.
Closes #128507.
>From 2d66140f9d62cb9bae44951df0999b595da05e58 Mon Sep 17 00:00:00 2001
From: hap
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137448
>From dc8388b0027c75dba465c72009ac0c25750ae877 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 26 Apr 2025 10:25:21 +0200
Subject: [PATCH] adding breakpoints protocol types
add all breakpoint requests JSON
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/137512
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137512
>From fd74de70151567d402eb7c0326a6234a21cb2db7 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 27 Apr 2025 13:48:45 +0200
Subject: [PATCH] [lldb] add settings to control how synthetic symbol names are
gene
@@ -639,7 +639,18 @@ void Symbol::SynthesizeNameIfNeeded() const {
// breakpoints on them.
llvm::SmallString<256> name;
llvm::raw_svector_ostream os(name);
-os << GetSyntheticSymbolPrefix() << GetID();
+os << GetSyntheticSymbolPrefix();
+switch (ModuleLi
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137512
>From 10d4c2497a55ccac91c27009ceafc2042476e7ab Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 27 Apr 2025 13:48:45 +0200
Subject: [PATCH] [lldb] add settings to control how synthetic symbol names are
gene
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/137426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen deleted
https://github.com/llvm/llvm-project/pull/137512
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -639,7 +639,18 @@ void Symbol::SynthesizeNameIfNeeded() const {
// breakpoints on them.
llvm::SmallString<256> name;
llvm::raw_svector_ostream os(name);
-os << GetSyntheticSymbolPrefix() << GetID();
+os << GetSyntheticSymbolPrefix();
eron
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ely Ronnen (eronnen)
Changes
Adds a setting that makes lldb generate synthetic symbol names according to the
file address of the function instead of the index, this could make it easier
when debugging crashes and stack traces to understand
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/137512
Adds a setting that makes lldb generate synthetic symbol names according to the
file address of the function instead of the index, this could make it easier
when debugging crashes and stack traces to understand
Author: Ebuka Ezike
Date: 2025-04-27T12:11:14+01:00
New Revision: d1adb0b8cd64607ef64d8bebc3197964a06de73a
URL:
https://github.com/llvm/llvm-project/commit/d1adb0b8cd64607ef64d8bebc3197964a06de73a
DIFF:
https://github.com/llvm/llvm-project/commit/d1adb0b8cd64607ef64d8bebc3197964a06de73a.diff
L
Author: Ebuka Ezike
Date: 2025-04-27T12:13:38+01:00
New Revision: 7670af5a274b801adf83fcc0c7c4011e0be0bc91
URL:
https://github.com/llvm/llvm-project/commit/7670af5a274b801adf83fcc0c7c4011e0be0bc91
DIFF:
https://github.com/llvm/llvm-project/commit/7670af5a274b801adf83fcc0c7c4011e0be0bc91.diff
L
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/137375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/137375
>From a87d7be70ce0d82b159c163b1b319a349cb162ea Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Fri, 25 Apr 2025 18:20:24 +0100
Subject: [PATCH 1/4] [lldb] Add ToJson for OptionValueArch
---
lldb/include/lldb
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/134722
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper approved this pull request.
https://github.com/llvm/llvm-project/pull/137485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper approved this pull request.
https://github.com/llvm/llvm-project/pull/137380
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/137448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/137408
>From db417e84e944ee80f045414a4ce0f83a3e423e45 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 25 Apr 2025 22:49:36 +0100
Subject: [PATCH] [lldb][CPlusPLus] Make C++ frame-format work without
debug-in
Author: Michael Buch
Date: 2025-04-27T11:21:01+01:00
New Revision: d605a0d70e3c2f53209c4320c2b6a9a9d86c8227
URL:
https://github.com/llvm/llvm-project/commit/d605a0d70e3c2f53209c4320c2b6a9a9d86c8227
DIFF:
https://github.com/llvm/llvm-project/commit/d605a0d70e3c2f53209c4320c2b6a9a9d86c8227.diff
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/137448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
eronnen wrote:
CC @ashgti
https://github.com/llvm/llvm-project/pull/137448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-llvm-support
Author: Ely Ronnen (eronnen)
Changes
- Migrate set breakpoint requests to use typed RequestHandler
- `SetBreakpointsRequestHandler`
- `SetDataBreakpointsRequestHandler`
- `SetFunctionBreakpointsRequestHandler`
- `SetInstructionBreakp
https://github.com/eronnen ready_for_review
https://github.com/llvm/llvm-project/pull/137448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
65 matches
Mail list logo