[Lldb-commits] [lldb] [lldb/Format] Make progress count show thousands separators (NFC) (PR #137446)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch changes the progress count formatting show thousands separator making it easier to read big numbers. --- Full diff: https://github.com/llvm/llvm-project/pull/137446.diff 1 Files Affect

[Lldb-commits] [lldb] [lldb/Format] Make progress count show thousands separators (NFC) (PR #137446)

https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/137446 This patch changes the progress count formatting show thousands separator making it easier to read big numbers. >From a293b8b3cd50037998db82b4cd2298489b8b5499 Mon Sep 17 00:00:00 2001 From: Med Ismail Benn

[Lldb-commits] [lldb] [llvm] [lldb-dap] Migrating breakpointLocations request to use typed RequestHandler (PR #137426)

@@ -245,6 +245,23 @@ bool fromJSON(const json::Value &Params, Configuration &C, json::Path P) { parseSourceMap(Params, C.sourceMap, P); } +bool fromJSON(const json::Value &Params, BreakpointLocationsArguments &BLA, + json::Path P) { + json::ObjectMapper

[Lldb-commits] [lldb] [lldb-dap] Support the Module Event (PR #137380)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137380 >From 681beb0f851d20896456b53c51b8ee84382a1254 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 25 Apr 2025 10:40:45 -0700 Subject: [PATCH 1/2] [lldb-dap] Support the Module Event The module eve

[Lldb-commits] [lldb] [llvm] [lldb-dap] Migrating breakpointLocations request to use typed RequestHandler (PR #137426)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/137426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb-dap] Migrating breakpointLocations request to use typed RequestHandler (PR #137426)

https://github.com/JDevlieghere approved this pull request. LGTM but please wait for @ashgti to sign off too. https://github.com/llvm/llvm-project/pull/137426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] 5137587 - [lldb][test] MangledTest: don't use designated initializers

Author: Michael Buch Date: 2025-04-26T01:00:17+01:00 New Revision: 5137587fb1dc878e2dca31c4b929a3ca99f70ace URL: https://github.com/llvm/llvm-project/commit/5137587fb1dc878e2dca31c4b929a3ca99f70ace DIFF: https://github.com/llvm/llvm-project/commit/5137587fb1dc878e2dca31c4b929a3ca99f70ace.diff

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

JDevlieghere wrote: I agree with @medismailben, the line number is super helpful (I copy/paste this into vim all the time) and visually it looks a bit weird without the column even thought it's not useful. https://github.com/llvm/llvm-project/pull/137301 __

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

medismailben wrote: > Not to derail this too much, but I'm also thinking if we should _stop_ > coloring the column number. Happy to open a patch if people think this is a > good idea? I don't have a strong opinion on this but I'm curious on why coloring the column number is bothering you spec

[Lldb-commits] [lldb] a74e4ac - [LLDB][Telemetry] Collect telemetry from client when allowed. (#129728)

Author: Vy Nguyen Date: 2025-04-26T02:19:29+02:00 New Revision: a74e4ac9d52029f9c9fe80654acd9fdd34d2a4cd URL: https://github.com/llvm/llvm-project/commit/a74e4ac9d52029f9c9fe80654acd9fdd34d2a4cd DIFF: https://github.com/llvm/llvm-project/commit/a74e4ac9d52029f9c9fe80654acd9fdd34d2a4cd.diff LOG

[Lldb-commits] [lldb] [llvm] [lldb-dap] Migrating breakpointLocations request to use typed RequestHandler (PR #137426)

https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/137426 >From 1cc60c125a69c4a84c263db6845714f1c320b696 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 26 Apr 2025 01:22:05 +0200 Subject: [PATCH] Migrating breakpointLocations request to use typed RequestHandler

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

adrian-prantl wrote: Not to derail this too much, but I'm also thinking if we should _stop_ coloring the column number. Happy to open a patch if people think this is a good idea? https://github.com/llvm/llvm-project/pull/137301 ___ lldb-commits mailin

[Lldb-commits] [lldb] [lldb][Format] Make function name frame-format variables work without debug-info (PR #137408)

adrian-prantl wrote: That sounds useful! Another way to spell `||` would be `?:` which might be more intuitive to C programmers? https://github.com/llvm/llvm-project/pull/137408 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] [llvm] [lldb-dap] Migrating breakpointLocations request to use typed RequestHandler (PR #137426)

https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/137426 >From 85c1e0de0a5cb8dd09b6f84b2514c7eb06aadac2 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 26 Apr 2025 01:22:05 +0200 Subject: [PATCH] Migrating breakpointLocations request to use typed RequestHandler

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

adrian-prantl wrote: I think this works. https://github.com/llvm/llvm-project/pull/137301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/129728 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/25] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] Make stop-hooks fire when lldb first gains control of a process. (PR #137410)

https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/137410 >From 8a5e25a6e850222fcbb94f685d46895d2666041f Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 25 Apr 2025 15:35:12 -0700 Subject: [PATCH 1/2] Make stop-hooks fire when lldb first gains control of a proc

[Lldb-commits] [lldb] 58aa922 - [lldb-dap] Correcting the types for launch and attach requests. (#137365)

Author: John Harrison Date: 2025-04-25T16:27:49-07:00 New Revision: 58aa92243634221c7cff55ad4bcaf1846b1902c4 URL: https://github.com/llvm/llvm-project/commit/58aa92243634221c7cff55ad4bcaf1846b1902c4 DIFF: https://github.com/llvm/llvm-project/commit/58aa92243634221c7cff55ad4bcaf1846b1902c4.diff

[Lldb-commits] [lldb] Skip tests if socket name is longer than 107 bytes (PR #137405)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/21023 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb-dap] Correcting the types for launch and attach requests. (PR #137365)

https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/137365 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6c78ded - Skip tests if socket name is longer than 107 bytes (#137405)

Author: Emre Kultursay Date: 2025-04-25T16:16:53-07:00 New Revision: 6c78dedc14e7431aa0dd92b9dd8d35bed3e0ed7d URL: https://github.com/llvm/llvm-project/commit/6c78dedc14e7431aa0dd92b9dd8d35bed3e0ed7d DIFF: https://github.com/llvm/llvm-project/commit/6c78dedc14e7431aa0dd92b9dd8d35bed3e0ed7d.diff

[Lldb-commits] [lldb] Skip tests if socket name is longer than 107 bytes (PR #137405)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/137405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not use DomainSocket on Windows (PR #137415)

https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/137415 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not use DomainSocket on Windows (PR #137415)

slydiman wrote: Duplicate of #137414. https://github.com/llvm/llvm-project/pull/137415 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix Windows build (PR #137414)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/137414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 935bc84 - Fix Windows build (#137414)

Author: Emre Kultursay Date: 2025-04-25T16:14:18-07:00 New Revision: 935bc84158e933239047de69b9edc77969b5c70c URL: https://github.com/llvm/llvm-project/commit/935bc84158e933239047de69b9edc77969b5c70c DIFF: https://github.com/llvm/llvm-project/commit/935bc84158e933239047de69b9edc77969b5c70c.diff

[Lldb-commits] [lldb] Fix Windows build (PR #137414)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not use DomainSocket on Windows (PR #137415)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The buildbot lldb-remote-linux-win is broken after #136466. This patch should make it green. --- Full diff: https://github.com/llvm/llvm-project/pull/137415.diff 1 Files Affected: - (modified) lldb/too

[Lldb-commits] [lldb] [lldb] Do not use DomainSocket on Windows (PR #137415)

https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/137415 The buildbot lldb-remote-linux-win is broken after #136466. This patch should make it green. >From 53d84b5113c4d7398694a0e0ff7e07f2cc77451b Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Sat, 26 Apr 202

[Lldb-commits] [lldb] Fix Windows build (PR #137414)

https://github.com/emrekultursay edited https://github.com/llvm/llvm-project/pull/137414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

emrekultursay wrote: Thanks. Are the following patches good enough, or do we prefer a revert? - Test fix: https://github.com/llvm/llvm-project/pull/137405 - Windows fix: https://github.com/llvm/llvm-project/pull/137414 https://github.com/llvm/llvm-project/pull/136466 __

[Lldb-commits] [lldb] Fix Windows build (PR #137414)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Emre Kultursay (emrekultursay) Changes Windows doesn't have domain sockets, so we must properly #ifdef the code that touches DomainSocket. --- Full diff: https://github.com/llvm/llvm-project/pull/137414.diff 1 Files Affected: - (modifie

[Lldb-commits] [lldb] Fix Windows build (PR #137414)

https://github.com/emrekultursay created https://github.com/llvm/llvm-project/pull/137414 Windows doesn't have domain sockets, so we must properly #ifdef the code that touches DomainSocket. >From fb1ced0cd73fbd3844a887d064cf319b27d2a237 Mon Sep 17 00:00:00 2001 From: Emre Kultursay Date: Fri,

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

slydiman wrote: Note DomainSocket is not supported on Windows, so removing the following code broke the Windows build! ``` #if LLDB_ENABLE_POSIX socket = new DomainSocket(sockfd, /*should_close=*/true); #else WithColor::error() << "lldb-platform child: Unix domain sockets are not "

[Lldb-commits] [lldb] Make stop-hooks fire when lldb first gains control of a process. (PR #137410)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/include/lldb/Target/Target.h lldb/source/Comma

[Lldb-commits] [lldb] Make stop-hooks fire when lldb first gains control of a process. (PR #137410)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/commands/target/stop-hooks/on-core-load/TestStopHookOnCoreLoad

[Lldb-commits] [lldb] Make stop-hooks fire when lldb first gains control of a process. (PR #137410)

https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/137410 stop-hooks are supposed to trigger every time the process stops, but as initially implemented they would only fire when control was returned to the user. So for instance when a process was launched the stop

[Lldb-commits] [lldb] Make stop-hooks fire when lldb first gains control of a process. (PR #137410)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes stop-hooks are supposed to trigger every time the process stops, but as initially implemented they would only fire when control was returned to the user. So for instance when a process was launched the stop hook w

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

JDevlieghere wrote: I tried the current state of the patch under Solarized dark and in Terminal.app with the default color scheme: https://github.com/user-attachments/assets/d1e8fe04-002b-4f0c-a0e6-b3ea6facea0d"; /> https://github.com/user-attachments/assets/353d2515-4dba-45a2-ad8c-e76431163d

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

chelcassanova wrote: I agree with Pavel, having the PC highlighted in yellow (or really in a colour that stands out) and having that column centers everything IMO. e.g. I like the cyan, but in the "Pro" scheme since it stands out from everything else. https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb][Format] Make function name frame-format variables work without debug-info (PR #137408)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137408 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][CPlusPlus] Make function name frame-format variables work without debug-info (PR #137408)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137408 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][CPlusPlus] Make C++-specific frame-format variables work without debug-info (PR #137408)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137408 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Skip tests if socket name is longer than 107 bytes (PR #137405)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Skip tests if socket name is longer than 107 bytes (PR #137405)

https://github.com/emrekultursay updated https://github.com/llvm/llvm-project/pull/137405 >From 65de31524033192d1c14af29b70b8f32bac3be55 Mon Sep 17 00:00:00 2001 From: Emre Kultursay Date: Fri, 25 Apr 2025 22:04:28 + Subject: [PATCH 1/2] Skip tests if socket name is longer than 107 bytes T

[Lldb-commits] [lldb] [lldb][CPlusPlus] Make C++ frame-format work without debug-info (PR #137408)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch makes the frame-format variables introduced in https://github.com/llvm/llvm-project/pull/131836 also work when no debug-info is available. Previously, we assumed `sc.function` was available, but

[Lldb-commits] [lldb] Skip tests if socket name is longer than 107 bytes (PR #137405)

@@ -370,6 +374,10 @@ TEST_F(SocketTest, AbstractSocketFromBoundNativeSocket) { true); llvm::sys::path::append(name, "test"); + // Skip the test if the $TMPDIR is too long to hold a domain socket. + if (name.size() > 107u) +return;

[Lldb-commits] [lldb] [lldb][CPlusPlus] Make C++ frame-format work without debug-info (PR #137408)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/137408 This patch makes the frame-format variables introduced in https://github.com/llvm/llvm-project/pull/131836 also work when no debug-info is available. Previously, we assumed `sc.function` was available, but w

[Lldb-commits] [lldb] Skip tests if socket name is longer than 107 bytes (PR #137405)

@@ -349,6 +349,10 @@ TEST_F(SocketTest, DomainSocketFromBoundNativeSocket) { ASSERT_FALSE(EC); llvm::sys::path::append(name, "test"); + // Skip the test if the $TMPDIR is too long to hold a domain socket. + if (name.size() > 107u) +return; JDevlieghe

[Lldb-commits] [lldb] Skip tests if socket name is longer than 107 bytes (PR #137405)

https://github.com/emrekultursay updated https://github.com/llvm/llvm-project/pull/137405 >From 65de31524033192d1c14af29b70b8f32bac3be55 Mon Sep 17 00:00:00 2001 From: Emre Kultursay Date: Fri, 25 Apr 2025 22:04:28 + Subject: [PATCH] Skip tests if socket name is longer than 107 bytes To fi

[Lldb-commits] [lldb] Skip tests if socket name is longer than 107 bytes (PR #137405)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/unittests/Host/SocketTest.cpp `` Vi

[Lldb-commits] [lldb] Skip tests if socket name is longer than 107 bytes (PR #137405)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Emre Kultursay (emrekultursay) Changes To fix the test failures introduced in Commit 488eeb3 --- Full diff: https://github.com/llvm/llvm-project/pull/137405.diff 1 Files Affected: - (modified) lldb/unittests/Host/SocketTest.cpp (+8) `

[Lldb-commits] [lldb] Skip tests if socket name is longer than 107 bytes (PR #137405)

https://github.com/emrekultursay created https://github.com/llvm/llvm-project/pull/137405 To fix the test failures introduced in Commit 488eeb3 >From d7ab4d2f439e63a6145d83f0017f6e56dd2e37f9 Mon Sep 17 00:00:00 2001 From: Emre Kultursay Date: Fri, 25 Apr 2025 22:04:28 + Subject: [PATCH] Sk

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

emrekultursay wrote: We're getting `SetSockAddr` error which can only fail if the path is too long. The path generated by `createUniqueDirectory` is an absolute path to a temporary directory. I guess it can be longer than 107 bytes on the CI machines. All the other DomainSocket related tests s

[Lldb-commits] [lldb] b571aa4 - [lldb][NFC] Add missing newline between function definitions

Author: Michael Buch Date: 2025-04-25T22:52:05+01:00 New Revision: b571aa49b1e07908b22bba3494461799e2f5c493 URL: https://github.com/llvm/llvm-project/commit/b571aa49b1e07908b22bba3494461799e2f5c493 DIFF: https://github.com/llvm/llvm-project/commit/b571aa49b1e07908b22bba3494461799e2f5c493.diff

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

emrekultursay wrote: Thanks folks: 1. Can you please squash-and-merge this PR? (I don't have write permissions) 2. Would you like me to create a cherry-pick into release/20.x branch, or is there a separate process for cherry-picks (e.g., wait some time to validate, submit a cherry-pick request

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

llvmbot wrote: >> 2. Would you like me to create a cherry-pick into release/20.x branch, or is >> there a separate process for cherry-picks (e.g., wait some time to validate, >> submit a cherry-pick request somewhere, etc.)? > >Please file and issue (here's an example: >https://github.com/llv

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

llvmbot wrote: >> 2. Would you like me to create a cherry-pick into release/20.x branch, or is >> there a separate process for cherry-picks (e.g., wait some time to validate, >> submit a cherry-pick request somewhere, etc.)? > >Please file and issue (here's an example: >https://github.com/llv

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

JDevlieghere wrote: > 2. Would you like me to create a cherry-pick into release/20.x branch, or is > there a separate process for cherry-picks (e.g., wait some time to validate, > submit a cherry-pick request somewhere, etc.)? Please file and issue (here's an example: https://github.com/llvm/

[Lldb-commits] [lldb] 488eeb3 - Fix connecting via abstract socket (#136466)

Author: Emre Kultursay Date: 2025-04-25T14:11:19-07:00 New Revision: 488eeb3ae508221f8e476bbc9d2e9f014542862e URL: https://github.com/llvm/llvm-project/commit/488eeb3ae508221f8e476bbc9d2e9f014542862e DIFF: https://github.com/llvm/llvm-project/commit/488eeb3ae508221f8e476bbc9d2e9f014542862e.diff

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

slydiman wrote: https://lab.llvm.org/buildbot/#/builders/141 is also broken. https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix error that lead Windows to think it could reverse execute (PR #137351)

rocallahan wrote: Thanks!!! https://github.com/llvm/llvm-project/pull/137351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #137379)

GeorgeHuyubo wrote: > I've locally applied your change on the top of tree, but I still get: > > ``` > lldb/source/Target/Statistics.cpp:75:39: error: use of undeclared identifier > 'num_symbols_loaded' > module.try_emplace("symbolsLoaded", num_symbols_loaded); >

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

https://github.com/kuilpd edited https://github.com/llvm/llvm-project/pull/137311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Mitigate a build error on Windows. (PR #137388)

https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/137388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a3b6423 - [lldb-dap] Mitigate a build error on Windows. (#137388)

Author: John Harrison Date: 2025-04-25T13:24:13-07:00 New Revision: a3b6423d506f1340782db62d23fb0d1a845a9411 URL: https://github.com/llvm/llvm-project/commit/a3b6423d506f1340782db62d23fb0d1a845a9411 DIFF: https://github.com/llvm/llvm-project/commit/a3b6423d506f1340782db62d23fb0d1a845a9411.diff

[Lldb-commits] [lldb] [lldb-dap] Mitigate a build error on Windows. (PR #137388)

ashgti wrote: It seems to work with MSVC 2022, so I guess its something to do with the way `std::future` is implemented in the 2019 version. https://github.com/llvm/llvm-project/pull/137388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] [lldb-dap] Support the Module Event (PR #137380)

https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/137380 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix broken tests with commanEscapePrefix="" (PR #137384)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix broken tests with commanEscapePrefix="" (PR #137384)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/137384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5c19723 - [lldb-dap] Fix broken tests with commanEscapePrefix="" (#137384)

Author: Ely Ronnen Date: 2025-04-25T13:07:34-07:00 New Revision: 5c197236ed7eea010a4697706e2472145a7c0c61 URL: https://github.com/llvm/llvm-project/commit/5c197236ed7eea010a4697706e2472145a7c0c61 DIFF: https://github.com/llvm/llvm-project/commit/5c197236ed7eea010a4697706e2472145a7c0c61.diff LO

[Lldb-commits] [lldb] [lldb-dap] Mitigate a build error on Windows. (PR #137388)

https://github.com/JDevlieghere approved this pull request. Weird, I wonder what the protected member is that the error is talking about. Anyway, this seems fine. https://github.com/llvm/llvm-project/pull/137388 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #137379)

https://github.com/GeorgeHuyubo closed https://github.com/llvm/llvm-project/pull/137379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #137379)

https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/137379 >From 2c2de66f4ea47716452c2deafbef6e2bfa7113fa Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 22 Apr 2025 19:37:05 -0700 Subject: [PATCH] Add symbol locator time for each module in statistics --- lld

[Lldb-commits] [lldb] [lldb-dap] Mitigate a build error on Windows. (PR #137388)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes When building with MSVC 2019 using `std::future` causes a compile time build error. ``` C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.29.30133\include\future(

[Lldb-commits] [lldb] [lldb-dap] Mitigate a build error on Windows. (PR #137388)

https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/137388 When building with MSVC 2019 using `std::future` causes a compile time build error. ``` C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.29.30133\include\future(196): error C22

[Lldb-commits] [lldb] [lldb-dap] Support the Module Event (PR #137380)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137380 >From 681beb0f851d20896456b53c51b8ee84382a1254 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 25 Apr 2025 10:40:45 -0700 Subject: [PATCH 1/2] [lldb-dap] Support the Module Event The module eve

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/137383 The instructions to build LLDB standalone contain a CMake configure step to build LLVM standalone. This configure step needs to also have the CMake build type in order to work. >From c12f01f83d6849023635

[Lldb-commits] [lldb] [lldb-dap] Fix broken tests with commanEscapePrefix="" (PR #137384)

https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/137384 * Fix broken tests that use commanEscapePrefix="", in my case `TestDAP_stackTraceMissingModule.test_missingModule` >From c496d0ec97db4a1bcb4717afb7427648e0c371ec Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date

[Lldb-commits] [lldb] [lldb-dap] Fix broken tests with commanEscapePrefix="" (PR #137384)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) Changes * Fix broken tests that use commanEscapePrefix="", in my case `TestDAP_stackTraceMissingModule.test_missingModule` --- Full diff: https://github.com/llvm/llvm-project/pull/137384.diff 1 Files Affected: - (m

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From caf6db4c4ef8caea027bb7909a723bf24ff881ad Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH] fallback to assembly when source code is not available fix TestDAP

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

@@ -2202,6 +2202,45 @@ void ValueObject::GetExpressionPath(Stream &s, } } +// Return the alternate value (synthetic if the input object is non-synthetic +// and otherwise) this is permitted by the expression path options. +static ValueObjectSP GetAlternateValue( +ValueOb

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Allow arrays to be dereferenced in C/C++. (PR #135843)

kuilpd wrote: > It's also possible that the implementation of Dereference is just too > persistent. I think it's doing too much. I've created > https://github.com/llvm/llvm-project/pull/137311 which I think is a better > way to approach dereferencing (BTW, I think you'll need to do something

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #134563)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/25713 Here is the relevant piece of th

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

https://github.com/kuilpd edited https://github.com/llvm/llvm-project/pull/137311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

https://github.com/kuilpd commented: So the difference is that if `value->Dereference` fails, the user should try to manually dereference a synthetic value? https://github.com/llvm/llvm-project/pull/137311 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes The instructions to build LLDB standalone contain a CMake configure step to build LLVM standalone. This configure step needs to also have the CMake build type in order to work. --- Full diff: http

[Lldb-commits] [lldb] 77f8335 - Add symbol locator time for each module in statistics (#137379)

Author: GeorgeHuyubo Date: 2025-04-25T11:48:31-07:00 New Revision: 77f8335a07e65f88a2c2925f175f48c458911cee URL: https://github.com/llvm/llvm-project/commit/77f8335a07e65f88a2c2925f175f48c458911cee DIFF: https://github.com/llvm/llvm-project/commit/77f8335a07e65f88a2c2925f175f48c458911cee.diff

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

slydiman wrote: https://lab.llvm.org/buildbot/#/builders/197/builds/4470 is still broken ``` FAILED: tools/lldb/source/Plugins/ExpressionParser/Clang/CMakeFiles/lldbPluginExpressionParserClang.dir/ClangModulesDeclVendor.cpp.obj ccache C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1441~1.34

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #136121)

dyung wrote: > Hmm... perhaps I have misunderstood the LLVM contribution process here. I had > assumed that once all the review feedback had been addressed, some time had > passed to allow reviewers to comment on the modifications resulting from > review feedback, and the "merge" button was av

[Lldb-commits] [lldb] [lldb-dap] Support the Module Event (PR #137380)

https://github.com/da-viper requested changes to this pull request. https://github.com/llvm/llvm-project/pull/137380 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support the Module Event (PR #137380)

@@ -692,7 +692,9 @@ void DAP::SetTarget(const lldb::SBTarget target) { lldb::SBListener listener = this->debugger.GetListener(); listener.StartListeningForEvents( this->target.GetBroadcaster(), -lldb::SBTarget::eBroadcastBitBreakpointChanged); +l

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

https://github.com/dmpots requested changes to this pull request. https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

@@ -374,6 +374,15 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

Michael137 wrote: > https://lab.llvm.org/buildbot/#/builders/197/builds/4470 is still broken > > ``` > > FAILED: > tools/lldb/source/Plugins/ExpressionParser/Clang/CMakeFiles/lldbPluginExpressionParserClang.dir/ClangModulesDeclVendor.cpp.obj > > > ccache > C:\PROGRA~1\MICROS~1\2022\COMMUN~

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

@@ -374,6 +374,15 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #134563)

slydiman wrote: The buildbot [lldb-remote-linux-ubuntu](https://lab.llvm.org/buildbot/#/builders/195/builds/8132) is broken too ``` FAILED: tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Statistics.cpp.o ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GLIBCXX_ASSERTIONS -D

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #137379)

https://github.com/kazutakahirata commented: I've locally applied your change on the top of tree, but I still get: ``` lldb/source/Target/Statistics.cpp:75:39: error: use of undeclared identifier 'num_symbols_loaded' module.try_emplace("symbolsLoaded", num_symbols_loaded);

  1   2   3   >