[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Emre Kultursay (emrekultursay) Changes Commits 82ee31f and 2e89312 added socket sharing, but only for unix domain sockets. That broke Android, which uses unix-abstract sockets. --- Full diff: https://github.com/llvm/llvm-project/pull/13646

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-19 Thread Emre Kultursay via lldb-commits
https://github.com/emrekultursay created https://github.com/llvm/llvm-project/pull/136466 Commits 82ee31f and 2e89312 added socket sharing, but only for unix domain sockets. That broke Android, which uses unix-abstract sockets. >From 950bafe1b6b900384b8d0f925f1cdab19a2c8e3d Mon Sep 17 00:00:00

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-19 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- lldb/include/lldb/Host/linux/AbstractSocket.h lldb

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-19 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/136236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-19 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/136236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ec6828c - [lldb-dap] Remove an incorrect assumption on reverse requests. (#136210)

2025-04-19 Thread via lldb-commits
Author: John Harrison Date: 2025-04-19T13:45:59-07:00 New Revision: ec6828c1ecad7fe2f799f7b5af3361885a5d5bb9 URL: https://github.com/llvm/llvm-project/commit/ec6828c1ecad7fe2f799f7b5af3361885a5d5bb9 DIFF: https://github.com/llvm/llvm-project/commit/ec6828c1ecad7fe2f799f7b5af3361885a5d5bb9.diff

[Lldb-commits] [lldb] [lldb-dap] Remove an incorrect assumption on reverse requests. (PR #136210)

2025-04-19 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/136210 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-19 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/136236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-19 Thread via lldb-commits
@@ -749,10 +749,20 @@ TEST_F(SymtabTest, TestSymtabCreatedOnDemand) { ASSERT_THAT_EXPECTED(ExpectedFile, llvm::Succeeded()); auto module_sp = std::make_shared(ExpectedFile->moduleSpec()); - // The symbol table should not be loaded by default. + // The symbol file should

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-19 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/136236 >From 85cb8cca4fe41cf4080b3dbf7ce4f98c4b15a3c7 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 17 Apr 2025 15:03:00 -0700 Subject: [PATCH 1/5] [lldb] Do not parse symtab during statistics dump Summary: Test

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-19 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/136236 >From 85cb8cca4fe41cf4080b3dbf7ce4f98c4b15a3c7 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 17 Apr 2025 15:03:00 -0700 Subject: [PATCH 1/4] [lldb] Do not parse symtab during statistics dump Summary: Test

[Lldb-commits] [lldb] [lldb] Fix use-color settings not persistent (PR #135626)

2025-04-19 Thread Jonas Devlieghere via lldb-commits
@@ -99,6 +99,12 @@ class IOHandler { // Prompt support isn't mandatory return false; } + + virtual bool SetUseColor(bool use_color) { +// Use color isn't mandatory JDevlieghere wrote: ```suggestion // Color support isn't mandatory. ``` http

[Lldb-commits] [lldb] [lldb] Fix use-color settings not persistent (PR #135626)

2025-04-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/135626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix use-color settings not persistent (PR #135626)

2025-04-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/135626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Remove an incorrect assumption on reverse requests. (PR #136210)

2025-04-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/136210 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Remove an incorrect assumption on reverse requests. (PR #136210)

2025-04-19 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Yeah, according to the [spec](https://microsoft.github.io/debug-adapter-protocol/specification#Base_Protocol_ProtocolMessage) all protocol messages have a sequence number and the sequence number is 1-based: > Sequence number of the message (also known as message ID). The `