[Lldb-commits] [lldb] [LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: Disabling asserts locally solved the problem with LLVM_DUMP_METHOD. This patch works again. I have refactored CPlusPlusLanguage::MethodName and RichManglingContext. I got the lldb-server size 6MB. Please review. Thanks https://github.com/llvm/llvm-project/pull/132274 __

[Lldb-commits] [lldb] [LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/132274 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/132274 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Stop the process for the threads request (PR #134456)

2025-04-04 Thread via lldb-commits
kusmour wrote: Thanks a lot for the comments and draft. I will go a head with the option 3! https://github.com/llvm/llvm-project/pull/134456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [LLDB] Fix tests on Windows (PR #131600)

2025-04-04 Thread Pavel Labath via lldb-commits
@@ -63,7 +63,7 @@ def execute(self, test, litConfig): try: out, err, exitCode = lit.util.executeCommand( cmd, -env=test.config.environment, +env={**os.environ, **test.config.environment}, labat

[Lldb-commits] [lldb] [lldb][debugserver] remove g/G packet handling from debugserver (PR #132127)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/132127 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 554f4d1 - [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (#134097)

2025-04-04 Thread via lldb-commits
Author: Michael Buch Date: 2025-04-03T11:10:16+01:00 New Revision: 554f4d1a5769357ee8438c23f572d595c720ff3c URL: https://github.com/llvm/llvm-project/commit/554f4d1a5769357ee8438c23f572d595c720ff3c DIFF: https://github.com/llvm/llvm-project/commit/554f4d1a5769357ee8438c23f572d595c720ff3c.diff

[Lldb-commits] [lldb] [lldb][AIX] Support for XCOFF Sections (PR #131304)

2025-04-04 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/131304 >From 106e137fea7d4b420ce3d97a8df16c3a91400997 Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Fri, 14 Mar 2025 02:51:21 -0500 Subject: [PATCH 1/3] Support for XCOFF Sections --- .../ObjectFile/

[Lldb-commits] [lldb] [LLDB][NFC] Added the interface DWARFExpression::Delegate to break dependencies and reduce lldb-server size (PR #131645)

2025-04-04 Thread Pavel Labath via lldb-commits
@@ -40,6 +35,31 @@ class DWARFUnit; /// location expression or a location list and interprets it. class DWARFExpression { public: + class Delegate { + public: +Delegate() = default; +virtual ~Delegate() = default; + +virtual uint16_t GetVersion() const = 0; +v

[Lldb-commits] [lldb] [lldb] Make `RegisterContextThreadMemory` thread safe (PR #134469)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/134469 The UpdateRegisterContext method can be called from multiple threads. >From ef59ad0f6522e5ca35cfeed562fc528b4732fb22 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Fri, 4 Apr 2025 18:28:

[Lldb-commits] [lldb] [lldb] Make `RegisterContextThreadMemory` thread safe (PR #134469)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/134469 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6272e1f - [lldb] Make `RegisterContextThreadMemory` thread safe (#134469)

2025-04-04 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-04-04T18:43:31-07:00 New Revision: 6272e1f37e0710b51d38cb98b905a3f2ffea7966 URL: https://github.com/llvm/llvm-project/commit/6272e1f37e0710b51d38cb98b905a3f2ffea7966 DIFF: https://github.com/llvm/llvm-project/commit/6272e1f37e0710b51d38cb98b905a3f2f

[Lldb-commits] [lldb] [lldb] Fix plugin manager test failure on windows (PR #134173)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Peixotto (dmpots) Changes This is an attempt to fix a test failure from #133794 when running on windows builds. I suspect we are running into a case where the [ICF](https://learn.microsoft.com/en-us/cpp/build/reference/opt-optimizati

[Lldb-commits] [lldb] [lldb] Make `RegisterContextThreadMemory` thread safe (PR #134469)

2025-04-04 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/134469 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-04 Thread Yuval Deutscher via lldb-commits
https://github.com/yuvald-sweet-security updated https://github.com/llvm/llvm-project/pull/131609 >From 6f2d070facaced221295a5b0c48ccb3a41a5048d Mon Sep 17 00:00:00 2001 From: Yuval Deutscher Date: Mon, 17 Mar 2025 14:37:26 +0200 Subject: [PATCH 1/2] [lldb] Use correct path for debugserver ---

[Lldb-commits] [lldb] [lldb] Make `RegisterContextThreadMemory` thread safe (PR #134469)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes The UpdateRegisterContext method can be called from multiple threads. --- Full diff: https://github.com/llvm/llvm-project/pull/134469.diff 2 Files Affected: - (modified) lldb/source/Pl

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-04 Thread Pavel Labath via lldb-commits
labath wrote: I think it's a good start (thanks for helping out, David), but I don't get the removal part. What you actually want to test that it *succeeds* in launching the llgs persona, is it not? Wouldn't it be better to *not* remove the lldb-server and check that the "run" command actually

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/134323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

2025-04-04 Thread via lldb-commits
jimingham wrote: Note, the current stop locker is a `pthread_rwlock_t`. These locks according to the docs I could find are recursive for reading, but not recursive for writing. We need them to be recursive for reading because you want to do: locker = process.GetStopLocker() process.GetThread

[Lldb-commits] [lldb] 5271dea - [lldb] Add a {ObjectFile, SymbolFile}::GetObjectName method (#133370)

2025-04-04 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-04T16:33:40-07:00 New Revision: 5271dead61dca30f4a6db0f0df8da00f8987449e URL: https://github.com/llvm/llvm-project/commit/5271dead61dca30f4a6db0f0df8da00f8987449e DIFF: https://github.com/llvm/llvm-project/commit/5271dead61dca30f4a6db0f0df8da00f8987449e.d

[Lldb-commits] [lldb] [lldb] Add a {ObjectFile, SymbolFile}::GetObjectName method (PR #133370)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/133370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,57 @@ +//===-- SBMutexTest.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Mariusz Borsa via lldb-commits
@@ -36,34 +42,61 @@ def setUp(self): self.line_breakpoint = line_number("main.c", "// break line") # Test line numbers: rdar://126237493 -def libsanitizer_tests(self): -target = self.createTestTarget() +# for libsanitizers and remove `skip_line_numb

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/134323 >From 8aa5e0e7f97df7627187bbd8ad4b3df51c798f4f Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Thu, 3 Apr 2025 14:47:53 -0700 Subject: [PATCH 1/5] [LLDB] Update reason for why tests are disabled --- lldb/test/A

[Lldb-commits] [lldb] [lldb-dap] Replace GetBreakpointLabel with kDAPBreakpointLabel constant (NFC) (PR #133746)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Replace GetBreakpointLabel with kDAPBreakpointLabel constant to avoid an unnecessary function call. --- Full diff: https://github.com/llvm/llvm-project/pull/133746.diff 5 Files Affected: - (modif

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-04 Thread Yuval Deutscher via lldb-commits
yuvald-sweet-security wrote: Yea, these tests only test the `lldb` binary, as evident from lit: https://github.com/yuvald-sweet-security/llvm-project/blob/main/lldb/test/API/lit.cfg.py#L247-L248 Do you know if there are any tests that run lldb-server? I couldn't find anything by grepping the r

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/functionalities/asan/TestMemoryHistory.py lldb/test/API/funct

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/132274 >From a4d62ca1dfaca8eb29ce7d2809c28137d22416b9 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Thu, 20 Mar 2025 21:50:51 +0400 Subject: [PATCH 1/2] [LLDB] Refactor Module::LookupInfo constructor and move

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
@@ -36,35 +42,59 @@ def setUp(self): self.line_breakpoint = line_number("main.c", "// break line") # Test line numbers: rdar://126237493 -def libsanitizer_tests(self): -target = self.createTestTarget() - -self.runCmd( -"env Sanitizer

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/134323 >From 8aa5e0e7f97df7627187bbd8ad4b3df51c798f4f Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Thu, 3 Apr 2025 14:47:53 -0700 Subject: [PATCH 1/4] [LLDB] Update reason for why tests are disabled --- lldb/test/A

[Lldb-commits] [lldb] [lldb] Add a {ObjectFile, SymbolFile}::GetObjectName method (PR #133370)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/133370 >From 8af1b715a2d2dd19f8ff374c1fcc4c513a2e6fed Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 4 Apr 2025 13:02:57 -0700 Subject: [PATCH 1/2] [lldb] Add a {ObjectFile,SymbolFile}::GetObjectName

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Alex Langford via lldb-commits
bulbazord wrote: > That said, I don't think this code should be here (and I think Alex would > agree). I do agree with this. > > I was referring more to the other items on the list. I assumed, it seems > > incorrectly, that Alex's patch would fix the dependency in the mangler. It > > seems l

[Lldb-commits] [lldb] [lldb] Add a {ObjectFile, SymbolFile}::GetObjectName method (PR #133370)

2025-04-04 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/133370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Mariusz Borsa via lldb-commits
@@ -15,17 +15,23 @@ class AsanTestCase(TestBase): @expectedFailureNetBSD @skipUnlessAddressSanitizer def test(self): -self.build(make_targets=["asan"]) +self.build(make_targets=["compiler_rt-asan"]) self.asan_tests() -@skipIf(oslist=no

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Mariusz Borsa via lldb-commits
https://github.com/wrotki approved this pull request. LGTM now https://github.com/llvm/llvm-project/pull/134323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: In the PR description you said "I don't think it's reasonable to allow getting threads from a running process." and I agree with that. However, that's not what `lldb-dap` does right now. The request handler calls `SBProcess::GetNumThreads` and `SBProcess::GetThreadAtIndex`

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-04-04 Thread Julius Alexandre via lldb-commits
https://github.com/wizardengineer edited https://github.com/llvm/llvm-project/pull/130516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Mariusz Borsa via lldb-commits
@@ -10,22 +10,28 @@ from lldbsuite.test import lldbutil from lldbsuite.test_event.build_exception import BuildError -class AsanTestCase(TestBase): +class MemoryHistoryTestCase(TestBase): wrotki wrote: 👍 https://github.com/llvm/llvm-project/pull/134323 __

[Lldb-commits] [lldb] [lldb-dap] Stop the process for the threads request (PR #134456)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/134456 None >From 621a5f78b72232e3f76dc2c6162bffc8051045ae Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 4 Apr 2025 15:07:21 -0700 Subject: [PATCH] [lldb-dap] Stop the process for the threads reques

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/134323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/134323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread via lldb-commits
@@ -36,35 +42,59 @@ def setUp(self): self.line_breakpoint = line_number("main.c", "// break line") # Test line numbers: rdar://126237493 -def libsanitizer_tests(self): -target = self.createTestTarget() - -self.runCmd( -"env Sanitizer

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread David Peixotto via lldb-commits
dmpots wrote: > Another way to do this would be to have the list of disabled plugins show in > the result of the `version` command, since that's a commonly provided bit of > info for bug reports. Thanks for the suggestion. Let me work on this and update the PR. https://github.com/llvm/llvm-p

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/134323 >From 8aa5e0e7f97df7627187bbd8ad4b3df51c798f4f Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Thu, 3 Apr 2025 14:47:53 -0700 Subject: [PATCH 1/3] [LLDB] Update reason for why tests are disabled --- lldb/test/A

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
@@ -36,34 +42,61 @@ def setUp(self): self.line_breakpoint = line_number("main.c", "// break line") # Test line numbers: rdar://126237493 -def libsanitizer_tests(self): -target = self.createTestTarget() +# for libsanitizers and remove `skip_line_numb

[Lldb-commits] [lldb] [lldb] s/ValidRange/ValidRanges in UnwindPlan (PR #127661)

2025-04-04 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/127661 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
@@ -15,17 +15,23 @@ class AsanTestCase(TestBase): @expectedFailureNetBSD @skipUnlessAddressSanitizer def test(self): -self.build(make_targets=["asan"]) +self.build(make_targets=["compiler_rt-asan"]) self.asan_tests() -@skipIf(oslist=no

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
@@ -15,17 +15,23 @@ class AsanTestCase(TestBase): @expectedFailureNetBSD @skipUnlessAddressSanitizer def test(self): -self.build(make_targets=["asan"]) +self.build(make_targets=["compiler_rt-asan"]) self.asan_tests() yln wro

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
@@ -36,34 +42,61 @@ def setUp(self): self.line_breakpoint = line_number("main.c", "// break line") # Test line numbers: rdar://126237493 -def libsanitizer_tests(self): -target = self.createTestTarget() +# for libsanitizers and remove `skip_line_numb

[Lldb-commits] [lldb] 5286511 - [lldb][NFC] use platform independent path separator in testSettings.py. (#132392)

2025-04-04 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-03-21T14:02:52Z New Revision: 5286511adc94529c2d0ee9ea37c121ff7eaea223 URL: https://github.com/llvm/llvm-project/commit/5286511adc94529c2d0ee9ea37c121ff7eaea223 DIFF: https://github.com/llvm/llvm-project/commit/5286511adc94529c2d0ee9ea37c121ff7eaea223.diff LOG: [

[Lldb-commits] [lldb] [lldb][NFC] use platform independent path separator in testSettings.py. (PR #132392)

2025-04-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/132392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Expose checking if the symbol file exists/is loaded via SBModule (PR #134163)

2025-04-04 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/134163 The motivation for this patch is that in Statistics.cpp we [check to see if the module symfile is loaded](https://github.com/llvm/llvm-project/blob/990a086d9da0bc2fd53a6a4c95ecbbe23a297a83/lldb/source/Target/St

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP] [ItaniumDemangle] Add infrastructure to track location information of parts of a demangled function name (PR #133249)

2025-04-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/133249 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Enable runInTerminal tests on macOS. (PR #133824)

2025-04-04 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/133824 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8e7d6ba - Revert "[LLDB] Expose checking if the symbol file exists/is loaded via SBModule" (#134341)

2025-04-04 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-04-03T20:45:55-07:00 New Revision: 8e7d6baf0e013408be932758b4a5334c14a34086 URL: https://github.com/llvm/llvm-project/commit/8e7d6baf0e013408be932758b4a5334c14a34086 DIFF: https://github.com/llvm/llvm-project/commit/8e7d6baf0e013408be932758b4a5334c14a34086.diff

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-04-04 Thread Adrian Prantl via lldb-commits
@@ -291,13 +291,11 @@ bool lldb_private::formatters::NSAttributedStringSummaryProvider( "string_ptr", pointer_value, exe_ctx, type)); if (!child_ptr_sp) return false; - DataExtractor data; - Status error; - child_ptr_sp->GetData(data, error); - if (error.Fail()

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-04 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/130169 >From c183231db80d6c97bdd5e9bd0b21d041189146e8 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 18 Mar 2025 14:05:38 -0700 Subject: [PATCH 01/12] [lldb-dap] Adding support for cancelling a request. Adding

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -33,15 +35,12 @@ MakeArgv(const llvm::ArrayRef &strs) { return argv; } -static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj, - llvm::StringRef key, lldb::LaunchFlags mask) { - if (const auto opt_value = GetBoolean(obj,

[Lldb-commits] [lldb] 7af0bfe - [lldb-dap] Ensure logging statements are written as a single chunk. (#131916)

2025-04-04 Thread via lldb-commits
Author: John Harrison Date: 2025-03-19T09:16:53-07:00 New Revision: 7af0bfe62fff676c66a5394995b03030cf5baef4 URL: https://github.com/llvm/llvm-project/commit/7af0bfe62fff676c66a5394995b03030cf5baef4 DIFF: https://github.com/llvm/llvm-project/commit/7af0bfe62fff676c66a5394995b03030cf5baef4.diff

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -9,127 +9,66 @@ #include "DAP.h" #include "EventHelper.h" #include "JSONUtils.h" +#include "Protocol/ProtocolRequests.h" #include "RequestHandler.h" #include "llvm/Support/FileSystem.h" namespace lldb_dap { -// "LaunchRequest": { -// "allOf": [ { "$ref": "#/definiti

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-04 Thread Pavel Labath via lldb-commits
@@ -778,28 +817,121 @@ llvm::Error DAP::Disconnect(bool terminateDebuggee) { return ToError(error); } +bool DAP::IsCancelled(const protocol::Request &req) { + std::lock_guard lock(m_cancelled_requests_mutex); + return m_cancelled_requests.contains(req.seq); +} + +void DAP:

[Lldb-commits] [lldb] d535554 - [lldb] Prefer PointerType::get with LLVMContext over Type (NFC) (#133869)

2025-04-04 Thread via lldb-commits
Author: Mats Jun Larsen Date: 2025-04-01T23:27:29Z New Revision: d53555499f85b7aedb765c66d6f3850c7bc6126d URL: https://github.com/llvm/llvm-project/commit/d53555499f85b7aedb765c66d6f3850c7bc6126d DIFF: https://github.com/llvm/llvm-project/commit/d53555499f85b7aedb765c66d6f3850c7bc6126d.diff LO

[Lldb-commits] [lldb] [lldb][debugserver] Interrupt should reset outstanding SIGSTOP (PR #132128)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes This fixes an uncommon bug with debugserver controlling an inferior process that is hitting an internal breakpoint & continuing when multiple interrupts are sent by SB API to lldb. In the reproducing s

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-04-04 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: There is another Pull Request for the same functionality #108036. The other PR seems to be outdated, though, and this PR seems to be further along (e.g. it also has test cases). CC @jennphilqc @walter-erquinigo @clayborg since you commented on the other PR and might also be

[Lldb-commits] [lldb] [lldb][debugserver] Fix an off-by-one error in watchpoint identification (PR #134314)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/134314 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 12cf6d3 - [lldb] Fix missing semicolon in lldbassert macro

2025-04-04 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-04T13:37:12-07:00 New Revision: 12cf6d3b9e0b4983d609576b15dc37ceb7d1d8d7 URL: https://github.com/llvm/llvm-project/commit/12cf6d3b9e0b4983d609576b15dc37ceb7d1d8d7 DIFF: https://github.com/llvm/llvm-project/commit/12cf6d3b9e0b4983d609576b15dc37ceb7d1d8d7.d

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-04-04 Thread via lldb-commits
@@ -292,6 +292,13 @@ def create_parser(): metavar="platform-working-dir", help="The directory to use on the remote platform.", ) +group.add_argument( +"--platform-available-ports", +dest="lldb_platform_available_ports", +nargs="*"

[Lldb-commits] [lldb] control Darwin parallel image loading with target.parallel-module-load (PR #134437)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thank you! https://github.com/llvm/llvm-project/pull/134437 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] control Darwin parallel image loading with target.parallel-module-load (PR #134437)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/134437 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Added the interface DWARFExpression::Delegate to break dependencies and reduce lldb-server size (PR #131645)

2025-04-04 Thread Pavel Labath via lldb-commits
@@ -696,6 +696,87 @@ llvm::StringRef DWARFUnit::PeekDIEName(dw_offset_t die_offset) { return llvm::StringRef(); } +llvm::Error DWARFUnit::GetDIEBitSizeAndSign(uint64_t die_offset, +uint64_t &bit_size, bool &sign) { + // Retrieve

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-04-04 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,165 @@ +//===-- GoToTargetsRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Add a {ObjectFile, SymbolFile}::GetObjectName method (PR #133370)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/133370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a {ObjectFile, SymbolFile}::GetObjectName method (PR #133370)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/133370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show the path to the .o instead of the containing .a in progress events (PR #133370)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/133370 >From 8af1b715a2d2dd19f8ff374c1fcc4c513a2e6fed Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 4 Apr 2025 13:02:57 -0700 Subject: [PATCH] [lldb] Add a {ObjectFile,SymbolFile}::GetObjectName meth

[Lldb-commits] [lldb] 03604a7 - [lldb] Make lldbassert fire only once per instance (#134343)

2025-04-04 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-04T12:53:10-07:00 New Revision: 03604a784011bec2292f900b118d825f34f8cf89 URL: https://github.com/llvm/llvm-project/commit/03604a784011bec2292f900b118d825f34f8cf89 DIFF: https://github.com/llvm/llvm-project/commit/03604a784011bec2292f900b118d825f34f8cf89.d

[Lldb-commits] [lldb] [lldb] Make lldbassert fire only once per instance (PR #134343)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/134343 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/DWARF] Remove "range lower than function low_pc" check (PR #132395)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The check is not correct for discontinuous functions, as one of the blocks could very well begin before the function entry point. To catch dead-stripped ranges, I check whether the functions is after the first

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes This NFC patch simplifies the main loop in HandleProcessStateChanged event by moving duplicated code into the StopInfo class, also allowing StopInfo subclasses to override behavior. More

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] Fix typos: paramter, parametr, parametere (PR #134092)

2025-04-04 Thread Jay Foad via lldb-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/134092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Enable runInTerminal tests on macOS. (PR #133824)

2025-04-04 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/133824 These tests are currently filtered on macOS if your on an M1 (or newer) device. These tests do work on macOS, for me at least on M1 Max with macOS 15.3.2 and Xcode 16.2. Enabling them again, but if we have CI p

[Lldb-commits] [lldb] [lldb] Fix plugin manager test failure on windows (PR #134173)

2025-04-04 Thread David Peixotto via lldb-commits
dmpots wrote: > LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` > running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 > "test". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/59/builds/15362 > > Here is the relevant

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/134418 >From e240bda8fcea9db4d9c456929ba811feb8d4152b Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Tue, 11 Mar 2025 13:02:14 -0700 Subject: [PATCH 1/4] Add commands to list/enable/disable plugins This commit add

[Lldb-commits] [lldb] Revert "[LLDB] Expose checking if the symbol file exists/is loaded via SBModule" (PR #134341)

2025-04-04 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/134341 Reverts llvm/llvm-project#134163 Reverting while @clayborg and I come up with a better API >From e789e78d20c0dfe70d4e977b259460f1c8008515 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 3 Apr 2025 20:4

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132234)

2025-04-04 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/132234 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-04-04 Thread Mikhail Zakharov via lldb-commits
https://github.com/real-mikhail updated https://github.com/llvm/llvm-project/pull/129092 >From 1d2da22bceb83cbda54567e5f819e5eef4e6 Mon Sep 17 00:00:00 2001 From: Mikhail Zakharov Date: Thu, 27 Feb 2025 18:43:33 +0100 Subject: [PATCH 01/10] [lldb] Do not bump memory modificator ID when "in

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-04 Thread John Harrison via lldb-commits
@@ -778,28 +817,121 @@ llvm::Error DAP::Disconnect(bool terminateDebuggee) { return ToError(error); } +bool DAP::IsCancelled(const protocol::Request &req) { + std::lock_guard lock(m_cancelled_requests_mutex); + return m_cancelled_requests.contains(req.seq); +} + +void DAP:

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread David Peixotto via lldb-commits
@@ -46,12 +49,344 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/134418 >From e240bda8fcea9db4d9c456929ba811feb8d4152b Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Tue, 11 Mar 2025 13:02:14 -0700 Subject: [PATCH 1/3] Add commands to list/enable/disable plugins This commit add

[Lldb-commits] [lldb] [lldb] Make ELF files able to load section headers from memory. (PR #129166)

2025-04-04 Thread Greg Clayton via lldb-commits
@@ -1477,32 +1506,32 @@ size_t ObjectFileELF::GetSectionHeaderInfo(SectionHeaderColl §ion_headers, } if (idx < section_headers.size()) section_headers.resize(idx); + // Sometimes we are able to read the section header memory from an in memory clayborg

[Lldb-commits] [lldb] Reapply LLDB-Telemetry TargetInfo branch (pr/127834) (PR #132043)

2025-04-04 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/132043 >From 9f0a47af2b7fdb90e4fa4cc7f8f97c840af1d2bc Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Mar 2025 10:44:12 -0400 Subject: [PATCH 1/5] Reapply "[LLDB][Telemetry]Define TargetInfo for collecting data

[Lldb-commits] [lldb] [lldb] Change test paths to resolve symlinks (PR #132053)

2025-04-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots created https://github.com/llvm/llvm-project/pull/132053 This commit modifes the `getSourceDir()` and `getBuildDir()` functions to use os.path.realpath to resolve symlinks in the Base test class used for API tests. A few tests were failing when the build and source di

[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-04 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: CI bots showed a fail in lldb-api.tools/lldb-server.TestGdbRemoteRegisterState.py , will debug and update. https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/23305/ https://github.com/llvm/llvm-project/pull/134184 __

[Lldb-commits] [lldb] [lldb/gdb-remote] Do not crash on an invalid server response (PR #131979)

2025-04-04 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/131979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132234)

2025-04-04 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: Will need to revert a dependent commit, this needs to revert as well so it goes cleanly. https://github.com/llvm/llvm-project/pull/132234 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] 52de49e - [lldb][debugserver][MacOSX] Work around sanitizer misaligned address errors when reading exception data (#132193)

2025-04-04 Thread via lldb-commits
Author: Michael Buch Date: 2025-03-21T11:21:29Z New Revision: 52de49e4b9cd69957b7dc50a5fed061ecd0b0d77 URL: https://github.com/llvm/llvm-project/commit/52de49e4b9cd69957b7dc50a5fed061ecd0b0d77 DIFF: https://github.com/llvm/llvm-project/commit/52de49e4b9cd69957b7dc50a5fed061ecd0b0d77.diff LOG:

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Commands/CommandObjectPlugin.cpp lldb/so

[Lldb-commits] [lldb] [lldb] Remove raw access to PluginInstances vector (PR #132884)

2025-04-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/132884 >From 6edc108199044d30eed396145aab463db40d6351 Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Thu, 13 Mar 2025 16:13:45 -0700 Subject: [PATCH 1/2] Remove raw access to PluginInstances vector This commit mod

[Lldb-commits] [lldb] [lldb-dap] Migrating DAP 'initialize' to new typed RequestHandler. (PR #133007)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -229,136 +230,45 @@ static void EventThreadFunction(DAP &dap) { } } -// "InitializeRequest": { -// "allOf": [ { "$ref": "#/definitions/Request" }, { -// "type": "object", -// "description": "Initialize request; value of command field is -// '

[Lldb-commits] [lldb] [LLDB] Fix tests on Windows (PR #131600)

2025-04-04 Thread Aleksandr Korepanov via lldb-commits
@@ -201,8 +201,15 @@ def test_watch_address_with_invalid_watch_size(self): value.GetValueAsUnsigned(), 365, wp_opts, error ) self.assertFalse(watchpoint) -self.expect( -error.GetCString(), -exe=

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/134418 >From e240bda8fcea9db4d9c456929ba811feb8d4152b Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Tue, 11 Mar 2025 13:02:14 -0700 Subject: [PATCH 1/2] Add commands to list/enable/disable plugins This commit add

  1   2   3   >