[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2025-03-08 Thread via lldb-commits
dyung wrote: I've reverted this change as well as two follow-up changes (df79000896101acc9b8d7435e59f767b36c00ac8 and b0baa1d8bd68a2ce2f7c5f2b62333e410e9122a1) since the added test seems to be very flaky. Please address this issue before relanding. https://github.com/llvm/llvm-project/pull/11

[Lldb-commits] [lldb] [lldb-dap] Migrating terminated statistics to the event body. (PR #130454)

2025-03-08 Thread John Harrison via lldb-commits
ashgti wrote: This is split off from #130026 https://github.com/llvm/llvm-project/pull/130454 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrating terminated statistics to the event body. (PR #130454)

2025-03-08 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/130454 Per the DAP spec, the event 'body' field should contain any additional data related to the event. I updated the lldb-dap 'statistics' extension into the terminated event's body like: ``` { "type": "event",

[Lldb-commits] [lldb] [lldb-dap] Migrating terminated statistics to the event body. (PR #130454)

2025-03-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Per the DAP spec, the event 'body' field should contain any additional data related to the event. I updated the lldb-dap 'statistics' extension into the terminated event's body like: ``` { "type": "event",

[Lldb-commits] [lldb] [lldb] Remove an extraneous `printf` statement. (PR #130453)

2025-03-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This was missed in review but is showing up in lldb-dap output. --- Full diff: https://github.com/llvm/llvm-project/pull/130453.diff 1 Files Affected: - (modified) lldb/source/Host/macosx/objcxx/MemoryMonit

[Lldb-commits] [lldb] [lldb] Remove an extraneous `printf` statement. (PR #130453)

2025-03-08 Thread John Harrison via lldb-commits
https://github.com/ashgti ready_for_review https://github.com/llvm/llvm-project/pull/130453 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove an extraneous `printf` statement. (PR #130453)

2025-03-08 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/130453 This was missed in review but is showing up in lldb-dap output. >From 317ab3778f56f7d32c6f3687981b5b87a8392915 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Sat, 8 Mar 2025 18:50:30 -0800 Subject: [PATCH] [

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/130435 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/130435 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1d763f3 - Revert "Modify the localCache API to require an explicit commit on CachedFile… (#115331)"

2025-03-08 Thread Douglas Yung via lldb-commits
Author: Douglas Yung Date: 2025-03-08T23:54:57Z New Revision: 1d763f383380ec629ee6d5053fd41322efcbc6bd URL: https://github.com/llvm/llvm-project/commit/1d763f383380ec629ee6d5053fd41322efcbc6bd DIFF: https://github.com/llvm/llvm-project/commit/1d763f383380ec629ee6d5053fd41322efcbc6bd.diff LOG:

[Lldb-commits] [lldb] [lldb][docs] Added LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS for macOS configuration (PR #130381)

2025-03-08 Thread Julius Alexandre via lldb-commits
https://github.com/wizardengineer edited https://github.com/llvm/llvm-project/pull/130381 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Added LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS for macOS configuration (PR #130381)

2025-03-08 Thread Julius Alexandre via lldb-commits
@@ -340,7 +340,8 @@ On macOS the LLDB test suite requires libc++. Either add code-signed with identity ``lldb_codesign`` (see :ref:`CodeSigning`). * ``LLDB_USE_SYSTEM_DEBUGSERVER:BOOL``: Use the system's debugserver, so lldb is functional without setting up code-signing. -

[Lldb-commits] [lldb] [lldb][docs] Added LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS for macOS configuration (PR #130381)

2025-03-08 Thread Julius Alexandre via lldb-commits
https://github.com/wizardengineer updated https://github.com/llvm/llvm-project/pull/130381 >From 3a8005bcf9780b51e7afbfba17e7bd43e7638cbc Mon Sep 17 00:00:00 2001 From: medievalghoul <61852278+medievalgh...@users.noreply.github.com> Date: Fri, 7 Mar 2025 21:15:46 -0500 Subject: [PATCH 1/2] added

[Lldb-commits] [lldb] [lldb][docs] Added LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS for macOS configuration (PR #130381)

2025-03-08 Thread Julius Alexandre via lldb-commits
@@ -371,6 +372,7 @@ LLVM `_): -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake \ -DLLVM_ENABLE_PROJECTS="clang;lldb" \ -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" \ +

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (Da-Viper) Changes Calling the public API `SBLineEntry::SetColumn()` sets the row instead of the column. This probably should be backported as it has been since version 3.4. --- Full diff: https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-08 Thread via lldb-commits
https://github.com/Da-Viper created https://github.com/llvm/llvm-project/pull/130435 Calling the public API `SBLineEntry::SetColumn()` sets the row instead of the column. This probably should be backported as it has been since version 3.4. >From 02c34e87db59a0b87887aba479afbab70925241b Mon

[Lldb-commits] [lldb] [lldb][docs] Added LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS for macOS configuration (PR #130381)

2025-03-08 Thread Jonas Devlieghere via lldb-commits
@@ -371,6 +372,7 @@ LLVM `_): -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake \ -DLLVM_ENABLE_PROJECTS="clang;lldb" \ -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" \ +

[Lldb-commits] [lldb] a1b14db - [lldb] Remove progress report coalescing (#130329)

2025-03-08 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-03-08T09:10:46-08:00 New Revision: a1b14dbc4740fe49dfb2af44907a195597474556 URL: https://github.com/llvm/llvm-project/commit/a1b14dbc4740fe49dfb2af44907a195597474556 DIFF: https://github.com/llvm/llvm-project/commit/a1b14dbc4740fe49dfb2af44907a195597474556.d

[Lldb-commits] [lldb] [lldb] Remove progress report coalescing (PR #130329)

2025-03-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/130329 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Added LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS for macOS configuration (PR #130381)

2025-03-08 Thread Jonas Devlieghere via lldb-commits
@@ -340,7 +340,8 @@ On macOS the LLDB test suite requires libc++. Either add code-signed with identity ``lldb_codesign`` (see :ref:`CodeSigning`). * ``LLDB_USE_SYSTEM_DEBUGSERVER:BOOL``: Use the system's debugserver, so lldb is functional without setting up code-signing. -

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-08 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/130090 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits