@@ -170,1648 +169,171 @@ std::vector MakeArgv(const
llvm::ArrayRef &strs) {
argv.push_back(s.c_str());
argv.push_back(nullptr);
return argv;
-}
-
-// Send a "exited" event to indicate the process has exited.
-void SendProcessExitedEvent(DAP &dap, lldb::SBProcess &proce
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
a7d578dcce30345e343cba32beb44e573a753cb0...7d2b0bf8a5dee74b0633a8b8699dcfbb99016606
lldb/
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/128268
>From c54157f43966c2d9d62134110026f3fed02de379 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 21 Feb 2025 17:45:17 -0800
Subject: [PATCH 1/6] [lldb-dap] Add 'source' references to stack frames
without s
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/127153
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -453,22 +455,16 @@ ScriptedProcess::GetLoadedDynamicLibrariesInfos() {
if (!dict->HasKey("load_addr"))
return error_with_message("Dictionary is missing key 'load_addr'");
+llvm::StringRef path = "";
medismailben wrote:
If you're using a new `
@@ -0,0 +1,45 @@
+//===-- Request.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -170,1648 +169,171 @@ std::vector MakeArgv(const
llvm::ArrayRef &strs) {
argv.push_back(s.c_str());
argv.push_back(nullptr);
return argv;
-}
-
-// Send a "exited" event to indicate the process has exited.
-void SendProcessExitedEvent(DAP &dap, lldb::SBProcess &proce
https://github.com/ashgti approved this pull request.
LGTM, one question about a potentially duplicated function.
https://github.com/llvm/llvm-project/pull/128262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/128262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
I'm marking this as ready for review. I think the 9 requests that have been
migrated are pretty representative and I intentionally made it so that the old
and new way of register requests keeps working. I was running the tests between
every PR. However, resolving the merge
https://github.com/JDevlieghere ready_for_review
https://github.com/llvm/llvm-project/pull/128262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rchamala updated
https://github.com/llvm/llvm-project/pull/127153
>From a4fdb2d54e76aefb771fe8ad8399494bb5fa8b70 Mon Sep 17 00:00:00 2001
From: rchamala
Date: Thu, 13 Feb 2025 15:00:37 -0800
Subject: [PATCH 1/4] Allow option to ignore module load errors in
ScriptedProcess
-
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/128268
>From c54157f43966c2d9d62134110026f3fed02de379 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 21 Feb 2025 17:45:17 -0800
Subject: [PATCH 1/5] [lldb-dap] Add 'source' references to stack frames
without s
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/128268
>From 2f7885cfac5d5049c317de56109eed3bd2579acc Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 21 Feb 2025 17:45:17 -0800
Subject: [PATCH 1/5] [lldb-dap] Add 'source' references to stack frames
without s
@@ -698,14 +697,22 @@ llvm::json::Value CreateSource(llvm::StringRef
source_path) {
return llvm::json::Value(std::move(source));
}
-static std::optional CreateSource(lldb::SBFrame &frame) {
+static llvm::json::Value CreateSource(lldb::SBFrame &frame,
ashgti
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/128268
>From 2f7885cfac5d5049c317de56109eed3bd2579acc Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 21 Feb 2025 17:45:17 -0800
Subject: [PATCH 1/4] [lldb-dap] Add 'source' references to stack frames
without s
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106907
>From aeb8854bbe7695e576257c8403e04d4b8268b679 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 13:48:41 +0100
Subject: [PATCH 01/10] Add: show return value on step out
---
lldb/tools/lldb-dap
@@ -0,0 +1,45 @@
+//===-- Request.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 998b28f19672ba49925e25f1a78c1252f017c247
481369f8107a43fd101e161c9bd9bb374e38f2af --e
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/128268
>From 2f7885cfac5d5049c317de56109eed3bd2579acc Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 21 Feb 2025 17:45:17 -0800
Subject: [PATCH 1/3] [lldb-dap] Add 'source' references to stack frames
without s
@@ -0,0 +1,92 @@
+//===-- Request.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
ashgti wrote:
Looking into it, I don't think that is supported in git.
https://github.com/llvm/llvm-project/pull/128262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
@@ -799,21 +806,22 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame,
EmplaceSafeString(object, "name", frame_name);
- auto source = CreateSource(frame);
-
- if (source) {
-object.try_emplace("source", *source);
-auto line_entry = frame.GetLineEntry();
-
https://github.com/JDevlieghere commented:
This will need a test.
https://github.com/llvm/llvm-project/pull/128268
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/128268
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -698,14 +697,22 @@ llvm::json::Value CreateSource(llvm::StringRef
source_path) {
return llvm::json::Value(std::move(source));
}
-static std::optional CreateSource(lldb::SBFrame &frame) {
+static llvm::json::Value CreateSource(lldb::SBFrame &frame,
JDevli
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff fb25216209c4d6f686bcb9f7fbc3ac0a8f5a61fa
e2728b6dfba0f9cef3cb9def7d01567dc3e9b6a8 --e
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/128262
>From e6cbcc3ab7a278c3ef01646db22872589486eb91 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 21 Feb 2025 19:20:36 -0600
Subject: [PATCH 1/3] [lldb-dap] Move requests into their own object/file
@@ -0,0 +1,45 @@
+//===-- Request.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/128262
>From e6cbcc3ab7a278c3ef01646db22872589486eb91 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 21 Feb 2025 19:20:36 -0600
Subject: [PATCH 1/2] [lldb-dap] Move requests into their own object/file
@@ -0,0 +1,45 @@
+//===-- Request.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,92 @@
+//===-- Request.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
JDevlieghere wrote:
Is there a way to do that in git? I've found it's been pretty good at figuring
that stuff out so I've never had to do it by hand.
https://github.com/llvm/llvm-project/pull/128262
___
lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/128245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jordan R AW
Date: 2025-02-22T11:13:46-06:00
New Revision: bb6a273d9ab9ee90dbb957e541f4d810fffb22ee
URL:
https://github.com/llvm/llvm-project/commit/bb6a273d9ab9ee90dbb957e541f4d810fffb22ee
DIFF:
https://github.com/llvm/llvm-project/commit/bb6a273d9ab9ee90dbb957e541f4d810fffb22ee.diff
L
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/128215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-02-22T11:11:40-06:00
New Revision: ae28a375d0d700ea73052828f5d7fbbb5f5159b2
URL:
https://github.com/llvm/llvm-project/commit/ae28a375d0d700ea73052828f5d7fbbb5f5159b2
DIFF:
https://github.com/llvm/llvm-project/commit/ae28a375d0d700ea73052828f5d7fbbb5f5159b2.d
DhruvSrivastavaX wrote:
I have builT the lldb-server on AIX and added the changes accordingly, so that
we can restart the review on this.
I will be handling the pending comments on this PR next.
https://github.com/llvm/llvm-project/pull/118160
___
ll
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 1/6] Added base files for NativeProcess for AIX
---
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 1/5] Added base files for NativeProcess for AIX
---
40 matches
Mail list logo
