mstorsjo wrote:
FYI, this had a small impact on deployability on macOS; I used to build LLVM
with 10.9 as a deployment target, but now get these errors:
```
/Users/runner/work/llvm-mingw/llvm-mingw/llvm-project/lldb/include/lldb/Target/StackFrameList.h:161:16:
error: 'shared_mutex' is unavaila
jasonmolenda wrote:
I pushed an update addressing Jonas' suggestions, and also fixing two testsuite
issues I found by testing the patch on an SME and non-SME machine running the
the same OS. I'm still seeing one bonus failure in TestFirmwareCorefiles.py on
the SME system that I need to debug,
https://github.com/wangleiat edited
https://github.com/llvm/llvm-project/pull/118770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/wangleiat closed
https://github.com/llvm/llvm-project/pull/118770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: wanglei
Date: 2024-12-13T10:06:55+08:00
New Revision: 6c4e70fcbbb62f38a5aab085634de5faaa5cf729
URL:
https://github.com/llvm/llvm-project/commit/6c4e70fcbbb62f38a5aab085634de5faaa5cf729
DIFF:
https://github.com/llvm/llvm-project/commit/6c4e70fcbbb62f38a5aab085634de5faaa5cf729.diff
LOG:
https://github.com/pcc closed https://github.com/llvm/llvm-project/pull/119777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/pcc edited https://github.com/llvm/llvm-project/pull/119777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/119757
>From c014afa4c7443c6696398da3d890d98630e14895 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 12 Dec 2024 12:53:13 -0800
Subject: [PATCH] [lldb] Add a progress event for executing an expression
E
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/119757
>From 084b096f2164042fb0a8a85c2614985c589b1788 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 12 Dec 2024 12:53:13 -0800
Subject: [PATCH] [lldb] Add a progress event for executing an expression
E
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/119757
>From 9a4f8c4b3a9953a5f59bd58f538281a0f194473f Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 12 Dec 2024 12:53:13 -0800
Subject: [PATCH] [lldb] Add a progress event for executing an expression
E
@@ -424,6 +425,14 @@ UserExpression::Execute(DiagnosticManager
&diagnostic_manager,
const EvaluateExpressionOptions &options,
lldb::UserExpressionSP &shared_ptr_to_me,
lldb::ExpressionVariableSP &result_va
@@ -424,6 +425,14 @@ UserExpression::Execute(DiagnosticManager
&diagnostic_manager,
const EvaluateExpressionOptions &options,
lldb::UserExpressionSP &shared_ptr_to_me,
lldb::ExpressionVariableSP &result_va
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
c047a5b3f6e2295dd74f1e8f17f1a023150b246c...b41b19c7b9bf5a784914e662b7485ac96c2ccdc4
lldb
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c047a5b3f6e2295dd74f1e8f17f1a023150b246c
b41b19c7b9bf5a784914e662b7485ac96c2ccdc4 --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
The NSError summary provider was fetching and printing the `_code` field as an
unsigned integer, but it's defined to be an NSInteger, which is signed.
---
Full diff: https://github.com/llvm/llvm-project/pull/119764
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/119764
The NSError summary provider was fetching and printing the `_code` field as an
unsigned integer, but it's defined to be an NSInteger, which is signed.
>From b41b19c7b9bf5a784914e662b7485ac96c2ccdc4 Mon Sep 17
@@ -424,6 +425,14 @@ UserExpression::Execute(DiagnosticManager
&diagnostic_manager,
const EvaluateExpressionOptions &options,
lldb::UserExpressionSP &shared_ptr_to_me,
lldb::ExpressionVariableSP &result_va
@@ -424,6 +425,14 @@ UserExpression::Execute(DiagnosticManager
&diagnostic_manager,
const EvaluateExpressionOptions &options,
lldb::UserExpressionSP &shared_ptr_to_me,
lldb::ExpressionVariableSP &result_va
@@ -424,6 +425,14 @@ UserExpression::Execute(DiagnosticManager
&diagnostic_manager,
const EvaluateExpressionOptions &options,
lldb::UserExpressionSP &shared_ptr_to_me,
lldb::ExpressionVariableSP &result_va
@@ -2842,31 +2850,32 @@ rnb_err_t
RNBRemote::SendStopReplyPacketForThread(nub_thread_t tid) {
if (g_num_reg_entries == 0)
InitializeRegisters();
-if (g_reg_entries != NULL) {
- auto interesting_regset = [](int regset) -> bool {
-#if defined(__arm64__) || de
@@ -312,16 +312,21 @@ struct DNBRegisterValue {
uint64_t uint64;
float float32;
double float64;
-int8_t v_sint8[64];
-int16_t v_sint16[32];
-int32_t v_sint32[16];
-int64_t v_sint64[8];
-uint8_t v_uint8[64];
-uint16_t v_uint16[32];
-uint32
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
Expressions can take arbitrary amounts of time to run, so IDEs might want to be
informed about the fact that an expression is currently being executed.
rdar://141253078
---
Full diff: https://github.c
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/119757
Expressions can take arbitrary amounts of time to run, so IDEs might want to be
informed about the fact that an expression is currently being executed.
rdar://141253078
>From 596555941e1596132fcabe84ad80
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/117252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jimingham
Date: 2024-12-12T12:48:41-08:00
New Revision: 186fac33d08b34be494caa58fe63972f69c6d6ab
URL:
https://github.com/llvm/llvm-project/commit/186fac33d08b34be494caa58fe63972f69c6d6ab
DIFF:
https://github.com/llvm/llvm-project/commit/186fac33d08b34be494caa58fe63972f69c6d6ab.diff
LOG
@@ -578,72 +609,53 @@ void StackFrameList::Dump(Stream *s) {
StackFrameSP StackFrameList::GetFrameAtIndex(uint32_t idx) {
StackFrameSP frame_sp;
- std::lock_guard guard(m_mutex);
uint32_t original_idx = idx;
- uint32_t inlined_depth = GetCurrentInlinedDepth();
- if (
@@ -0,0 +1,77 @@
+#include
+#include
+
+// define the SVE/SME/SME2 thread status structures
JDevlieghere wrote:
```suggestion
// Define the SVE/SME/SME2 thread status structures
```
https://github.com/llvm/llvm-project/pull/119171
_
@@ -2567,10 +2568,13 @@ rnb_err_t
RNBRemote::HandlePacket_QSetProcessEvent(const char *p) {
return SendPacket("OK");
}
-void register_value_in_hex_fixed_width(std::ostream &ostrm, nub_process_t pid,
+// if a fail_value is provided, a correct-length reply is always provided,
@@ -2582,27 +2586,31 @@ void register_value_in_hex_fixed_width(std::ostream
&ostrm, nub_process_t pid,
if (reg_value_ptr) {
append_hex_value(ostrm, reg_value_ptr->value.v_uint8, reg->nub_info.size,
false);
-} else {
- // If we fail to
@@ -312,16 +312,21 @@ struct DNBRegisterValue {
uint64_t uint64;
float float32;
double float64;
-int8_t v_sint8[64];
-int16_t v_sint16[32];
-int32_t v_sint32[16];
-int64_t v_sint64[8];
-uint8_t v_uint8[64];
-uint16_t v_uint16[32];
-uint32
https://github.com/JDevlieghere commented:
I did a pass and left some nits but I'm not enough of an expert to review this
in more detail. I like the test coverage and I appreciate @DavidSpickett taking
the time to review this!
https://github.com/llvm/llvm-project/pull/119171
__
@@ -0,0 +1,113 @@
+/// BUILT with
JDevlieghere wrote:
Nit: `s/built/build/`. But also this is covered by the makefile so maybe
something like "Requires -mcpu=apple-m4" would be more to the point.
https://github.com/llvm/llvm-project/pull/119171
__
@@ -100,6 +100,25 @@ bool
ArchitectureAArch64::ReconfigureRegisterInfo(DynamicRegisterInfo ®_info,
if (reg_value != fail_value && reg_value <= 32)
svg_reg_value = reg_value;
}
+ if (!svg_reg_value) {
+const RegisterInfo *darwin_svg_reg_info = reg_info.GetRegis
@@ -0,0 +1,163 @@
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+import lldbsuite.test.lldbutil as lldbutil
+import os
+
+
+class TestSMERegistersDarwin(TestBase):
+NO_DEBUG_INFO_TESTCASE = True
+mydir = TestBase.compute_mydir
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/119171
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
Details:
- This is a subset of PR/98528.( Pavel's suggestion was to split up the patch
to make reviewing easier)
- This contains only the concrete implementation of the framework to be used
but no usages yet.
-
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/119716
Details:
- This is a subset of PR/98528.( Pavel's suggestion was to split up the patch
to make reviewing easier)
- This contains only the concrete implementation of the framework to be used
but no usages yet.
-
DavidSpickett wrote:
I thought they would have switched to a BSD make but perhaps this is left over.
Ok cool then I just need to check a few --version to see what we can look for.
https://github.com/llvm/llvm-project/pull/119573
___
lldb-commits maili
@@ -2299,11 +2301,103 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_va
@@ -8544,7 +8524,8 @@ clang::EnumConstantDecl
*TypeSystemClang::AddEnumerationValueToEnumerationType(
bool is_signed = false;
underlying_type.IsIntegerType(is_signed);
- llvm::APSInt value(enum_value_bit_size, is_signed);
+ // APSInt constructor's sign argument is isUns
@@ -8544,7 +8524,8 @@ clang::EnumConstantDecl
*TypeSystemClang::AddEnumerationValueToEnumerationType(
bool is_signed = false;
underlying_type.IsIntegerType(is_signed);
- llvm::APSInt value(enum_value_bit_size, is_signed);
+ // APSInt constructor's sign argument is isUns
https://github.com/labath approved this pull request.
Thanks for your patience.
https://github.com/llvm/llvm-project/pull/117252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -578,72 +609,53 @@ void StackFrameList::Dump(Stream *s) {
StackFrameSP StackFrameList::GetFrameAtIndex(uint32_t idx) {
StackFrameSP frame_sp;
- std::lock_guard guard(m_mutex);
uint32_t original_idx = idx;
- uint32_t inlined_depth = GetCurrentInlinedDepth();
- if (
@@ -119,6 +120,7 @@ bool StackFrameList::DecrementCurrentInlinedDepth() {
uint32_t current_inlined_depth = GetCurrentInlinedDepth();
if (current_inlined_depth != UINT32_MAX) {
if (current_inlined_depth > 0) {
+std::lock_guard guard(m_inlined_depth_mutex);
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/117252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
I'm going to jump in here, since I think this was my idea. :)
I actually believe that preferring `gmake` *is* the right thing to do because
we are (for whatever reason) looking for *GNU* make, and `gmake` (unlike
`make`, it seems) is very likely to be the a "gnu make" -- if it ex
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/119694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dhruv Srivastava (DhruvSrivastavaX)
Changes
This change is related merging some of the APIs in HostInfoLinux into
HostInfoPosix.
Here is the reference PR comment:
https://github.com/llvm/llvm-project/pull/117906#discussion_r1865427495,
ht
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/119694
This change is related merging some of the APIs in HostInfoLinux into
HostInfoPosix.
Here is the reference PR comment:
https://github.com/llvm/llvm-project/pull/117906#discussion_r1865427495,
https://
DavidSpickett wrote:
I've updated it so that we prefer gmake on the BSDs, but we will use make if we
cannot find gmake. Everywhere else we prefer make instead.
If we can't find a gmake on BSD we will warn but not error.
Which means you can build on a fresh FreeBSD without installing gmake. The
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/119573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/119573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/119573
>From aa3c542bd0f05ea46138b4335cfcbdf7aa19bf16 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 12 Dec 2024 10:42:35 +
Subject: [PATCH] [lldb] Prefer gmake on FreeBSD and NetBSD
System `make`
DavidSpickett wrote:
> So, now the problem is that FreeBSD has both, make and gmake, and when we
> pick up make, the tests fail right? Wouldn't it be sufficient to change the
> order?
It will fix the build on FreeBSD where you have `pkg install gmake`, but on a
system without it, it will find
ilya-biryukov wrote:
Fixed by 7f4312015291a32d811a0f37e24b4d9736c524f7.
https://github.com/llvm/llvm-project/pull/119333
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail commented:
Yes, I believe there was a condition like that in my patch that introduced the
check. And then I simplified it.
So, now the problem is that FreeBSD has both, make and gmake, and when we pick
up make, the tests fail right? Wouldn't it be sufficient t
@@ -2842,31 +2850,32 @@ rnb_err_t
RNBRemote::SendStopReplyPacketForThread(nub_thread_t tid) {
if (g_num_reg_entries == 0)
InitializeRegisters();
-if (g_reg_entries != NULL) {
- auto interesting_regset = [](int regset) -> bool {
-#if defined(__arm64__) || de
@@ -2842,31 +2850,32 @@ rnb_err_t
RNBRemote::SendStopReplyPacketForThread(nub_thread_t tid) {
if (g_num_reg_entries == 0)
InitializeRegisters();
-if (g_reg_entries != NULL) {
- auto interesting_regset = [](int regset) -> bool {
-#if defined(__arm64__) || de
ilya-biryukov wrote:
Ah, it's `DisableFree` again. I'll send a fix.
https://github.com/llvm/llvm-project/pull/119333
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,111 @@
+/// BUILT with
+///xcrun -sdk macosx.internal clang -mcpu=apple-m4 -g sme.c -o sme
+
+#include
+#include
+#include
+
+void write_sve_regs() {
+ asm volatile("ptrue p0.b\n\t");
+ asm volatile("ptrue p1.h\n\t");
+ asm volatile("ptrue p2.s\n\t");
+ asm
Author: David Spickett
Date: 2024-12-12T10:08:53Z
New Revision: 2fae58e9c7becc376454005da69acb3fa993350e
URL:
https://github.com/llvm/llvm-project/commit/2fae58e9c7becc376454005da69acb3fa993350e
DIFF:
https://github.com/llvm/llvm-project/commit/2fae58e9c7becc376454005da69acb3fa993350e.diff
LOG
ilya-biryukov wrote:
@ChuanqiXu9 the added test fails under ASAN that reports memory leaks:
```
$ cmake -G Ninja -DLLVM_USE_SANITIZER=Address -DCMAKE_CXX_COMPILER=clang
-DCMAKE_C_COMPILER=clang ../
$ ninja SerializationTests
$ ./tools/clang/unittests/Serialization/SerializationTests
```
produc
62 matches
Mail list logo
