[Lldb-commits] [lldb] [lldb][Process/Linux] Introduce LoongArch64 hw break/watchpoint support (PR #118043)

2024-12-04 Thread via lldb-commits
wangleiat wrote: > We could move all this back into NativeRegisterContextLinux too but A: let's > take one step at a time and B: it may be that some architecture does not fit > the pattern that AArch64 and LoongArch do. > > So in the interests of you getting this done and us having less churn,

[Lldb-commits] [lldb] [lldb] Add additional assertions to TestVTableValue.test_overwrite_vtable (PR #118719)

2024-12-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes If this test fails, you're likely going to see something like "Assertion Error: A != B" which doesn't really give much explanation for why this failed. Instead of ignoring the error, we should assert that

[Lldb-commits] [lldb] [lldb] Add additional assertions to TestVTableValue.test_overwrite_vtable (PR #118719)

2024-12-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/118719 If this test fails, you're likely going to see something like "Assertion Error: A != B" which doesn't really give much explanation for why this failed. Instead of ignoring the error, we should assert that it

[Lldb-commits] [lldb] [LLDB] Fix error returns in CastToBasicType and CastToEnumType in ValueObject. (PR #117401)

2024-12-04 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl commented: Thanks! https://github.com/llvm/llvm-project/pull/117401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-12-04 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/116392 >From 547549573aba86c9bf9b9c2c189d49a3d8f62413 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 2 Dec 2024 08:36:52 -0800 Subject: [PATCH 1/2] [lldb-dap] Refactoring lldb-dap listening mode to support mul

[Lldb-commits] [lldb] 2e425bf - Reapply "[lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (#117071)"

2024-12-04 Thread Zequan Wu via lldb-commits
Author: Zequan Wu Date: 2024-12-04T13:05:36-08:00 New Revision: 2e425bf629f80c8f8582c266d25a384e7549198d URL: https://github.com/llvm/llvm-project/commit/2e425bf629f80c8f8582c266d25a384e7549198d DIFF: https://github.com/llvm/llvm-project/commit/2e425bf629f80c8f8582c266d25a384e7549198d.diff LOG

[Lldb-commits] [lldb] [lldb-dap] Fix links to LLVM issue tracker and pull requests (PR #118681)

2024-12-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/118681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] When using Socket to listen on `localhost:0` on systems supporting ting ipv4 and ipv6 the second socket to initialize will not update the listening address correctly after

2024-12-04 Thread John Harrison via lldb-commits
ashgti wrote: 118673 Should fix the fature https://github.com/llvm/llvm-project/pull/118565 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix links to LLVM issue tracker and pull requests (PR #118681)

2024-12-04 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/118681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix links to LLVM issue tracker and pull requests (PR #118681)

2024-12-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/118681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9302043 - [lldb-dap] Fix links to LLVM issue tracker and pull requests (#118681)

2024-12-04 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-12-04T11:04:05-08:00 New Revision: 9302043bef24519b95ffce86569ca7c7c97300e9 URL: https://github.com/llvm/llvm-project/commit/9302043bef24519b95ffce86569ca7c7c97300e9 DIFF: https://github.com/llvm/llvm-project/commit/9302043bef24519b95ffce86569ca7c7c97300e9.d

[Lldb-commits] [lldb] [lldb/DWARF] s/DWARFRangeList/llvm::DWARFAddressRangeVector (PR #116620)

2024-12-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Looks ok to me. Thanks! https://github.com/llvm/llvm-project/pull/116620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/117808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix links to LLVM issue tracked and pull requests (PR #118681)

2024-12-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Makes sense to me. https://github.com/llvm/llvm-project/pull/118681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 095c3c9 - [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (#117808)

2024-12-04 Thread via lldb-commits
Author: cmtice Date: 2024-12-04T10:49:12-08:00 New Revision: 095c3c9d6ec349815563d47f951d4590b3d18333 URL: https://github.com/llvm/llvm-project/commit/095c3c9d6ec349815563d47f951d4590b3d18333 DIFF: https://github.com/llvm/llvm-project/commit/095c3c9d6ec349815563d47f951d4590b3d18333.diff LOG: [

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread via lldb-commits
@@ -6754,12 +6754,12 @@ size_t TypeSystemClang::GetIndexOfChildMemberWithName( llvm::StringRef field_name = field->getName(); if (field_name.empty()) { CompilerType field_type = GetType(field->getType()); +std::vector save_indices = c

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/117808 >From b8c64e227b8f9f82b420cc5c2f24fbd3f75f67f5 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Tue, 26 Nov 2024 15:08:32 -0800 Subject: [PATCH 1/9] [lLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWi

[Lldb-commits] [lldb] [lldb-dap] Fix links to LLVM issue tracked and pull requests (PR #118681)

2024-12-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Currently, the link to the issue tracker takes you to the Github source repository, rather than the Github issue tracker. This fixes the link and includes the lldb-dap label in both the issue and PR

[Lldb-commits] [lldb] [lldb-dap] Fix links to LLVM issue tracked and pull requests (PR #118681)

2024-12-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/118681 Currently, the link to the issue tracker takes you to the Github source repository, rather than the Github issue tracker. This fixes the link and includes the lldb-dap label in both the issue and PR URL.

[Lldb-commits] [lldb] [lldb] When using Socket to listen on `localhost:0` on systems supporting ting ipv4 and ipv6 the second socket to initialize will not update the listening address correctly after

2024-12-04 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: It seems this patch break the test `lldb-unit::HostTests/SocketTest/TCPListen0MultiListenerGetListeningConnectionURI` https://lab.llvm.org/buildbot/#/builders/195/builds/1909 https://github.com/llvm/llvm-project/pull/118565 ___ lldb-co

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/117808 >From b8c64e227b8f9f82b420cc5c2f24fbd3f75f67f5 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Tue, 26 Nov 2024 15:08:32 -0800 Subject: [PATCH 1/8] [lLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWi

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

2024-12-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/118547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix the SocketTest failure on unsupported hosts (PR #118673)

2024-12-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes The test `SocketTest::TCPListen0MultiListenerGetListeningConnectionURI` is failing on hosts that do not map `localhost` to both an ipv4 and ipv6 address. For example this build https://lab.llvm.org/buildbot/#

[Lldb-commits] [lldb] ff59538 - [lldb-dap] Support finding the lldb-dap binary (#118547)

2024-12-04 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-12-04T09:43:49-08:00 New Revision: ff5953804ea5b430710b07f1dae395bfcf6d35d0 URL: https://github.com/llvm/llvm-project/commit/ff5953804ea5b430710b07f1dae395bfcf6d35d0 DIFF: https://github.com/llvm/llvm-project/commit/ff5953804ea5b430710b07f1dae395bfcf6d35d0.d

[Lldb-commits] [lldb] [lldb] Fix the SocketTest failure on unsupported hosts (PR #118673)

2024-12-04 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/118673 The test `SocketTest::TCPListen0MultiListenerGetListeningConnectionURI` is failing on hosts that do not map `localhost` to both an ipv4 and ipv6 address. For example this build https://lab.llvm.org/buildbot/#/bu

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -6754,12 +6754,12 @@ size_t TypeSystemClang::GetIndexOfChildMemberWithName( llvm::StringRef field_name = field->getName(); if (field_name.empty()) { CompilerType field_type = GetType(field->getType()); +std::vector save_indices = c

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread via lldb-commits
@@ -0,0 +1,19 @@ +struct A { + struct { +int x = 1; + }; + int y = 2; +} a; + +struct B { + // Anonymous struct inherits another struct. + struct : public A { +int z = 3; + }; + int w = 4; cmtice wrote: No; leftovers from previous testing. Will rem

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/117808 >From b8c64e227b8f9f82b420cc5c2f24fbd3f75f67f5 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Tue, 26 Nov 2024 15:08:32 -0800 Subject: [PATCH 1/7] [lLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWi

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread via lldb-commits
@@ -0,0 +1,19 @@ +struct A { + struct { +int x = 1; + }; + int y = 2; cmtice wrote: No; leftover from other tests. Will remove it. https://github.com/llvm/llvm-project/pull/117808 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/117808 >From b8c64e227b8f9f82b420cc5c2f24fbd3f75f67f5 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Tue, 26 Nov 2024 15:08:32 -0800 Subject: [PATCH 1/6] [lLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWi

[Lldb-commits] [lldb] [lldb] When using Socket to listen on `localhost:0` on systems supporting ting ipv4 and ipv6 the second socket to initialize will not update the listening address correctly after

2024-12-04 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/118565 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d5ba143 - [lldb] Correct an issue when using Socket to listen on `localhost:0` on ipv4 and ipv6. (#118565)

2024-12-04 Thread via lldb-commits
Author: John Harrison Date: 2024-12-04T08:47:18-08:00 New Revision: d5ba143a6d8e8726c900dbfc381dab0e7d8b6a65 URL: https://github.com/llvm/llvm-project/commit/d5ba143a6d8e8726c900dbfc381dab0e7d8b6a65 DIFF: https://github.com/llvm/llvm-project/commit/d5ba143a6d8e8726c900dbfc381dab0e7d8b6a65.diff

[Lldb-commits] [lldb] [lldb] (Prepare to) speed up dwarf indexing (PR #118657)

2024-12-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Makes sense, LGTM. If the amount of work here is so small, and the granularity was too fine for creating separate tasks, I'd argue that it's too fine for progress reporting as well. I think that's what you're saying too. There's proba

[Lldb-commits] [lldb] ba43a10 - [LLDB] Fix error returns in CastToBasicType and CastToEnumType in ValueObject. (#117401)

2024-12-04 Thread via lldb-commits
Author: cmtice Date: 2024-12-04T08:11:10-08:00 New Revision: ba43a102a929eb8aae60580e14f3192a705e1805 URL: https://github.com/llvm/llvm-project/commit/ba43a102a929eb8aae60580e14f3192a705e1805 DIFF: https://github.com/llvm/llvm-project/commit/ba43a102a929eb8aae60580e14f3192a705e1805.diff LOG: [

[Lldb-commits] [lldb] [LLDB] Fix error returns in CastToBasicType and CastToEnumType in ValueObject. (PR #117401)

2024-12-04 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/117401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] (Prepare to) speed up dwarf indexing (PR #118657)

2024-12-04 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/118657 Indexing a single DWARF unit is a fairly small task, which means the overhead of enqueueing a task for each unit is not negligible (mainly because introduces a lot of synchronization points for queue management,

[Lldb-commits] [lldb] [lldb][tests] Fix passing pthread library to a linker for some API tests (PR #118530)

2024-12-04 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev closed https://github.com/llvm/llvm-project/pull/118530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4e80c53 - [lldb][tests] Fix passing pthread library to a linker for some API tests (#118530)

2024-12-04 Thread via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-12-04T16:55:28+01:00 New Revision: 4e80c532c613cc93a43dcf71eaf6a30f96c27b6c URL: https://github.com/llvm/llvm-project/commit/4e80c532c613cc93a43dcf71eaf6a30f96c27b6c DIFF: https://github.com/llvm/llvm-project/commit/4e80c532c613cc93a43dcf71eaf6a30f96c27b6

[Lldb-commits] [lldb] [lldb] (Prepare to) speed up dwarf indexing (PR #118657)

2024-12-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Indexing a single DWARF unit is a fairly small task, which means the overhead of enqueueing a task for each unit is not negligible (mainly because introduces a lot of synchronization points for queue managemen

[Lldb-commits] [lldb] [lldb] (Prepare to) speed up dwarf indexing (PR #118657)

2024-12-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0adab6b1af5b1874099b1e97fdcea2ce5020d79a 6a9384e47441117cff7b2903b4ad8bdfd11f06b4 --e

[Lldb-commits] [lldb] [lldb] (Prepare to) speed up dwarf indexing (PR #118657)

2024-12-04 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/118657 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/DWARF] s/DWARFRangeList/llvm::DWARFAddressRangeVector (PR #116620)

2024-12-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0adab6b1af5b1874099b1e97fdcea2ce5020d79a 5cca8f301abde9333715e97d671afc23d75b9acd --e

[Lldb-commits] [lldb] [lldb/DWARF] s/DWARFRangeList/llvm::DWARFAddressRangeVector (PR #116620)

2024-12-04 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/116620 >From 5cca8f301abde9333715e97d671afc23d75b9acd Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Mon, 18 Nov 2024 14:33:40 +0100 Subject: [PATCH 1/2] [lldb/DWARF] s/DWARFRangeList/llvm::DWARFAddressRangeVector

[Lldb-commits] [lldb] [lldb/DWARF] s/DWARFRangeList/llvm::DWARFAddressRangeVector (PR #116620)

2024-12-04 Thread Pavel Labath via lldb-commits
labath wrote: Rebased on top of other changes. Ping :) https://github.com/llvm/llvm-project/pull/116620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/DWARF] s/DWARFRangeList/llvm::DWARFAddressRangeVector (PR #116620)

2024-12-04 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/116620 >From 5cca8f301abde9333715e97d671afc23d75b9acd Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Mon, 18 Nov 2024 14:33:40 +0100 Subject: [PATCH] [lldb/DWARF] s/DWARFRangeList/llvm::DWARFAddressRangeVector The m

[Lldb-commits] [lldb] [LLDB] Fix error returns in CastToBasicType and CastToEnumType in ValueObject. (PR #117401)

2024-12-04 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/117401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM, happy to postpone clean up this function in a separate PR. Left some comments on the test https://github.com/llvm/llvm-project/pull/117808 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread Michael Buch via lldb-commits
@@ -0,0 +1,19 @@ +struct A { + struct { +int x = 1; + }; + int y = 2; +} a; + +struct B { + // Anonymous struct inherits another struct. + struct : public A { +int z = 3; + }; + int w = 4; Michael137 wrote: Are `w` and `a` necessary for the reprodu

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/117808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread Michael Buch via lldb-commits
@@ -0,0 +1,19 @@ +struct A { + struct { +int x = 1; + }; + int y = 2; Michael137 wrote: Is `y` necessary for the reproducer? https://github.com/llvm/llvm-project/pull/117808 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

2024-12-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/117808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits