[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Much better, thanks. https://github.com/llvm/llvm-project/pull/116456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #116689)

2024-11-18 Thread Pavel Labath via lldb-commits
labath wrote: > Any ideas on why this flag doesn't work on that linux system? My guess would be that's because that buildbot was not configured to build lld, and the test happened to pick up the ambient (old) version on the system. Setting `REQUIRES: lld` on the test should ensure that the tes

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -927,12 +927,87 @@ unsigned char Editline::BufferEndCommand(int ch) { static void PrintCompletion(FILE *output_file, llvm::ArrayRef results, -size_t max_len) { +size_t max_completion_length, size_t max_length) { + constexpr si

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,69 @@ +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test.lldbpexpect import PExpectTest + + +class EditlineCompletionsTest(PExpectTest): +@skipIfAsan +@skipIfEdit

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,69 @@ +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test.lldbpexpect import PExpectTest + + +class EditlineCompletionsTest(PExpectTest): +@skipIfAsan +@skipIfEdit

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/116456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -927,12 +927,87 @@ unsigned char Editline::BufferEndCommand(int ch) { static void PrintCompletion(FILE *output_file, llvm::ArrayRef results, -size_t max_len) { +size_t max_completion_length, size_t max_length) { + constexpr si

[Lldb-commits] [clang] [lldb] [Clang] Improve Sema diagnostic performance for __builtin_counted_by_ref (PR #116719)

2024-11-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Bill Wendling (bwendling) Changes Implement the sema checks with a placeholder. We then check for that placeholder in all of the places we care to emit a diagnostic. Fixes: #115520 --- Patch is 29.47 KiB, truncated to 20.00 KiB below,

[Lldb-commits] [lldb] [lldb] Fix regex support in SBTarget.modules_access (PR #116452)

2024-11-18 Thread Dave Lee via lldb-commits
@@ -79,11 +79,11 @@ STRING_EXTENSION_LEVEL_OUTSIDE(SBTarget, lldb::eDescriptionLevelBrief) module = self.sbtarget.GetModuleAtIndex(idx) if module.uuid == key: return module -elif type(k

[Lldb-commits] [lldb] a7b2e73 - Add support for reading the dynamic symbol table from PT_DYNAMIC (#112596)

2024-11-18 Thread via lldb-commits
Author: Greg Clayton Date: 2024-11-18T10:18:11-08:00 New Revision: a7b2e73bcaa91255a20f1f2e692bec9eb6c17022 URL: https://github.com/llvm/llvm-project/commit/a7b2e73bcaa91255a20f1f2e692bec9eb6c17022 DIFF: https://github.com/llvm/llvm-project/commit/a7b2e73bcaa91255a20f1f2e692bec9eb6c17022.diff

[Lldb-commits] [lldb] [lldb] Fix regex support in SBTarget.modules_access (PR #116452)

2024-11-18 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/116452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang] Improve Sema diagnostic performance for __builtin_counted_by_ref (PR #116719)

2024-11-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Bill Wendling (bwendling) Changes Implement the sema checks with a placeholder. We then check for that placeholder in all of the places we care to emit a diagnostic. Fixes: #115520 --- Patch is 29.47 KiB, truncated to 20.00 KiB below, f

[Lldb-commits] [clang] [lldb] [Clang] Improve Sema diagnostic performance for __builtin_counted_by_ref (PR #116719)

2024-11-18 Thread Bill Wendling via lldb-commits
https://github.com/bwendling created https://github.com/llvm/llvm-project/pull/116719 Implement the sema checks with a placeholder. We then check for that placeholder in all of the places we care to emit a diagnostic. Fixes: #115520 >From 2dcf18163de2ccce959f46bf82df1fa40e3fd1fc Mon Sep 17 0

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread via lldb-commits
jimingham wrote: The change makes this more useful for completion, where you are more getting reminded than reading the whole help. LGTM. https://github.com/llvm/llvm-project/pull/116456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [lldb] 170e1fe - [lldb] Fix regex support in SBTarget.modules_access (#116452)

2024-11-18 Thread via lldb-commits
Author: Dave Lee Date: 2024-11-18T16:15:41-08:00 New Revision: 170e1fe5a5211420923e32995d8bf3da196c2a54 URL: https://github.com/llvm/llvm-project/commit/170e1fe5a5211420923e32995d8bf3da196c2a54 DIFF: https://github.com/llvm/llvm-project/commit/170e1fe5a5211420923e32995d8bf3da196c2a54.diff LOG:

[Lldb-commits] [lldb] [lldb] Fix a positioning bug in diagnostics output (PR #116711)

2024-11-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/116711 The old code did not take the indentation into account. >From cd312045308032582539fe8302c34cab265aaa5a Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 18 Nov 2024 15:22:24 -0800 Subject: [PATCH] [

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #116689)

2024-11-18 Thread Greg Clayton via lldb-commits
clayborg wrote: @labath Your suggestion to use the commands in my test fails on `buildkite/github-pull-requests/linux-linux-x64` with: ``` RUN: at line 6: /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-5wwkv-1/llvm-project/github-pull-requests/build/bin/llvm-mc -triple=x86_64-pc-linux -fil

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #116689)

2024-11-18 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/116689 >From 4dbb6fe631926bdcdcb89d981a457dd7599bffad Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Mon, 18 Nov 2024 12:11:56 -0800 Subject: [PATCH 1/5] Add support for reading the dynamic symbol table from PT_DY

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #116689)

2024-11-18 Thread Greg Clayton via lldb-commits
clayborg wrote: @labath I fixed by removing use of `-z nosectionheader` and then ran llvm-strip as a separate step to ensure the section headers are removed. https://github.com/llvm/llvm-project/pull/116689 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #116689)

2024-11-18 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/116689 >From 4dbb6fe631926bdcdcb89d981a457dd7599bffad Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Mon, 18 Nov 2024 12:11:56 -0800 Subject: [PATCH 1/4] Add support for reading the dynamic symbol table from PT_DY

[Lldb-commits] [lldb] [lldb] Fix a positioning bug in diagnostics output (PR #116711)

2024-11-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes The old code did not take the indentation into account. --- Full diff: https://github.com/llvm/llvm-project/pull/116711.diff 2 Files Affected: - (modified) lldb/source/Utility/DiagnosticsRendering.cp

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-18 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/112811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 94d100f - [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (#112811)

2024-11-18 Thread via lldb-commits
Author: Zequan Wu Date: 2024-11-18T17:45:54-05:00 New Revision: 94d100f2ba81c2bf0ef495f68d66ba8c94c71d2a URL: https://github.com/llvm/llvm-project/commit/94d100f2ba81c2bf0ef495f68d66ba8c94c71d2a DIFF: https://github.com/llvm/llvm-project/commit/94d100f2ba81c2bf0ef495f68d66ba8c94c71d2a.diff LOG

[Lldb-commits] [lldb] Convert ThreadPlanStack's mutex to a shared mutex. (PR #116438)

2024-11-18 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/116438 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b42a816 - Convert ThreadPlanStack's mutex to a shared mutex. (#116438)

2024-11-18 Thread via lldb-commits
Author: jimingham Date: 2024-11-18T13:23:17-08:00 New Revision: b42a81631491571c4b78d095917ebdddee69b04f URL: https://github.com/llvm/llvm-project/commit/b42a81631491571c4b78d095917ebdddee69b04f DIFF: https://github.com/llvm/llvm-project/commit/b42a81631491571c4b78d095917ebdddee69b04f.diff LOG

[Lldb-commits] [lldb] 24feaab - Fix statistics dump to report per-target (#113723)

2024-11-18 Thread via lldb-commits
Author: jeffreytan81 Date: 2024-11-17T20:36:54-08:00 New Revision: 24feaab8380c69d5fa3eb8c21ef2d660913fd4a9 URL: https://github.com/llvm/llvm-project/commit/24feaab8380c69d5fa3eb8c21ef2d660913fd4a9 DIFF: https://github.com/llvm/llvm-project/commit/24feaab8380c69d5fa3eb8c21ef2d660913fd4a9.diff

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -250,6 +251,13 @@ def which(program): return None +def pickrandomport(): +"""Returns a random open port.""" +with socket.socket() as sock: +sock.bind(("", 0)) +return sock.getsockname()[1] labath wrote: Also, due to IPv4 vs IPv

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #116689)

2024-11-18 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. [The Build Fix](https://github.com/llvm/llvm-project/pull/116689/commits/1bcfd2a9a1e7ea4ee984f7198ae4ba4148c4861f), looks good to me. I'm happier with us setting dynsym before the if condition as well. https://github.com/llvm/llvm-project

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #116689)

2024-11-18 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7b525495e8574285c19188be11e7ef8a51382ff3 192cc7ba08aed0d2fe0b306be96dca50f8bd21f1 --e

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #116689)

2024-11-18 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/116689 >From 4dbb6fe631926bdcdcb89d981a457dd7599bffad Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Mon, 18 Nov 2024 12:11:56 -0800 Subject: [PATCH 1/3] Add support for reading the dynamic symbol table from PT_DY

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #116689)

2024-11-18 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/116689 >From 4dbb6fe631926bdcdcb89d981a457dd7599bffad Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Mon, 18 Nov 2024 12:11:56 -0800 Subject: [PATCH 1/2] Add support for reading the dynamic symbol table from PT_DY

[Lldb-commits] [lldb] [lldb] Relax check for breakpoint site in Unwind/windows-unaligned-x86_64.test (PR #115318)

2024-11-18 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail closed https://github.com/llvm/llvm-project/pull/115318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1d0b285 - [lldb] Relax check for breakpoint site in Unwind/windows-unaligned-x86_64.test (#115318)

2024-11-18 Thread via lldb-commits
Author: Stefan Gränitz Date: 2024-11-18T21:14:55+01:00 New Revision: 1d0b2851224b1ef97c49faac2c666535f1997363 URL: https://github.com/llvm/llvm-project/commit/1d0b2851224b1ef97c49faac2c666535f1997363 DIFF: https://github.com/llvm/llvm-project/commit/1d0b2851224b1ef97c49faac2c666535f1997363.diff

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #116689)

2024-11-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Greg Clayton (clayborg) Changes Resubmissions of https://github.com/llvm/llvm-project/pull/112596 with buildbot fixes. Allow LLDB to parse the dynamic symbol table from an ELF file or memory image in an ELF file that has no section header

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #116689)

2024-11-18 Thread Greg Clayton via lldb-commits
https://github.com/clayborg created https://github.com/llvm/llvm-project/pull/116689 Resubmissions of https://github.com/llvm/llvm-project/pull/112596 with buildbot fixes. Allow LLDB to parse the dynamic symbol table from an ELF file or memory image in an ELF file that has no section headers.

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-11-18 Thread Greg Clayton via lldb-commits
clayborg wrote: > I have reverted this change with > [f14e1a8](https://github.com/llvm/llvm-project/commit/f14e1a8597f83fa5bbc78befcb7059144d58ff5c) I found the issue and have a fix. https://github.com/llvm/llvm-project/pull/112596 ___ lldb-commits m

[Lldb-commits] [lldb] [lldb] Fix regex support in SBTarget.modules_access (PR #116452)

2024-11-18 Thread Dave Lee via lldb-commits
@@ -79,11 +79,11 @@ STRING_EXTENSION_LEVEL_OUTSIDE(SBTarget, lldb::eDescriptionLevelBrief) module = self.sbtarget.GetModuleAtIndex(idx) if module.uuid == key: return module -elif type(k

[Lldb-commits] [lldb] [lldb] Fix regex support in SBTarget.modules_access (PR #116452)

2024-11-18 Thread Dave Lee via lldb-commits
@@ -79,11 +79,11 @@ STRING_EXTENSION_LEVEL_OUTSIDE(SBTarget, lldb::eDescriptionLevelBrief) module = self.sbtarget.GetModuleAtIndex(idx) if module.uuid == key: return module -elif type(k

[Lldb-commits] [lldb] f14e1a8 - Revert "Add support for reading the dynamic symbol table from PT_DYNAMIC (#112596)"

2024-11-18 Thread Shubham Sandeep Rastogi via lldb-commits
Author: Shubham Sandeep Rastogi Date: 2024-11-18T11:09:58-08:00 New Revision: f14e1a8597f83fa5bbc78befcb7059144d58ff5c URL: https://github.com/llvm/llvm-project/commit/f14e1a8597f83fa5bbc78befcb7059144d58ff5c DIFF: https://github.com/llvm/llvm-project/commit/f14e1a8597f83fa5bbc78befcb7059144d58

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-11-18 Thread Shubham Sandeep Rastogi via lldb-commits
rastogishubham wrote: I have reverted this change with f14e1a8597f83fa5bbc78befcb7059144d58ff5c https://github.com/llvm/llvm-project/pull/112596 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-11-18 Thread Shubham Sandeep Rastogi via lldb-commits
rastogishubham wrote: It seems like this patch is responsible for breaking greendragon https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/15470/ https://github.com/llvm/llvm-project/pull/112596 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere ready_for_review https://github.com/llvm/llvm-project/pull/116456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/116456 >From 3434c7de701e4851b4eefe25f23e49d415ba4dd3 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 15 Nov 2024 16:06:47 -0800 Subject: [PATCH 1/5] [lldb] Improve editline completion formatting This

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-18 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > Thanks Jason. Looks good. (I think the arm failure is due to it being a > 32-bit machine. Maybe it would be sufficient to use 32-bit values everywhere?) I think the fail on the arm bot was because I have a scripted process plugin and it imports examples/python/templates/s

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/116456 >From 3434c7de701e4851b4eefe25f23e49d415ba4dd3 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 15 Nov 2024 16:06:47 -0800 Subject: [PATCH 1/4] [lldb] Improve editline completion formatting This

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r cdda76a8cfc3b0c5def836f68f6f58efba03e01c...5e0304fa539e7322984cd9962348724f293c1185 lldb/

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This patch improves the formatting of editline completions. The current implementation is naive and doesn't account for the terminal width. Concretely, the old implementation suffered from the follo

[Lldb-commits] [lldb] [lldb] Fix regex support in SBTarget.modules_access (PR #116452)

2024-11-18 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/116452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix regex support in SBTarget.modules_access (PR #116452)

2024-11-18 Thread Alex Langford via lldb-commits
@@ -79,11 +79,11 @@ STRING_EXTENSION_LEVEL_OUTSIDE(SBTarget, lldb::eDescriptionLevelBrief) module = self.sbtarget.GetModuleAtIndex(idx) if module.uuid == key: return module -elif type(k

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/116456 >From 3434c7de701e4851b4eefe25f23e49d415ba4dd3 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 15 Nov 2024 16:06:47 -0800 Subject: [PATCH 1/3] [lldb] Improve editline completion formatting This

[Lldb-commits] [lldb] Convert ThreadPlanStack's mutex to a shared mutex. (PR #116438)

2024-11-18 Thread via lldb-commits
jimingham wrote: The ThreadPlans themselves don't lock access to their state as it stands now. That's not really a problem because ThreadPlans only mutate their state in the course of the ThreadList::ShouldStop process, which happens before the new ThreadPlanStack is accessible to other parts

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-11-18 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/10733 Here is the relevant piece of the build log

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-11-18 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/112596 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/116456 >From 3434c7de701e4851b4eefe25f23e49d415ba4dd3 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 15 Nov 2024 16:06:47 -0800 Subject: [PATCH 1/2] [lldb] Improve editline completion formatting This

[Lldb-commits] [lldb] [lldb][sbapi][NFC] Remove commented out typedef from SBBreakpointName (PR #116434)

2024-11-18 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/116434 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 589ab28 - [lldb][sbapi][NFC] Remove commented out typedef from SBBreakpointName (#116434)

2024-11-18 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2024-11-18T10:08:44-08:00 New Revision: 589ab28d87616006d7f8cf2402379811e2a6183f URL: https://github.com/llvm/llvm-project/commit/589ab28d87616006d7f8cf2402379811e2a6183f DIFF: https://github.com/llvm/llvm-project/commit/589ab28d87616006d7f8cf2402379811e2a6183f.d

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-11-18 Thread Michael Buch via lldb-commits
Michael137 wrote: Revert in https://github.com/llvm/llvm-project/commit/ceeb08b9e0a51a4d2e0804baeb579fe8a6485885 for now to unblock the bot https://github.com/llvm/llvm-project/pull/113787 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] ceeb08b - Revert "[lldb-dap] Support column breakpoints (#113787)"

2024-11-18 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2024-11-18T16:15:06Z New Revision: ceeb08b9e0a51a4d2e0804baeb579fe8a6485885 URL: https://github.com/llvm/llvm-project/commit/ceeb08b9e0a51a4d2e0804baeb579fe8a6485885 DIFF: https://github.com/llvm/llvm-project/commit/ceeb08b9e0a51a4d2e0804baeb579fe8a6485885.diff LOG:

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -250,6 +251,13 @@ def which(program): return None +def pickrandomport(): +"""Returns a random open port.""" +with socket.socket() as sock: +sock.bind(("", 0)) +return sock.getsockname()[1] labath wrote: Indeed. I am not very fo

[Lldb-commits] [lldb] [lldb] rm DWARFDebugRanges (PR #116379)

2024-11-18 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/116379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Relax check for breakpoint site in Unwind/windows-unaligned-x86_64.test (PR #115318)

2024-11-18 Thread Martin Storsjö via lldb-commits
https://github.com/mstorsjo approved this pull request. LGTM, this seems reasonable - I guess the new form should match both `breakpoint 1` and `breakpoint 1.1`. https://github.com/llvm/llvm-project/pull/115318 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] 6e1acdc - [lldb] Fix a warning

2024-11-18 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2024-11-18T07:01:51-08:00 New Revision: 6e1acdcdc1b33c8d3cccf09b8d38279eef2ba69e URL: https://github.com/llvm/llvm-project/commit/6e1acdcdc1b33c8d3cccf09b8d38279eef2ba69e DIFF: https://github.com/llvm/llvm-project/commit/6e1acdcdc1b33c8d3cccf09b8d38279eef2ba69e.diff L

[Lldb-commits] [lldb] e370946 - [lldb] Infer MSInheritanceAttr for CXXRecordDecl with DWARF on Windows (#115177)

2024-11-18 Thread via lldb-commits
Author: Stefan Gränitz Date: 2024-11-18T11:10:10+01:00 New Revision: e370946978c3b50cc2716878122be332df554c6f URL: https://github.com/llvm/llvm-project/commit/e370946978c3b50cc2716878122be332df554c6f DIFF: https://github.com/llvm/llvm-project/commit/e370946978c3b50cc2716878122be332df554c6f.diff

[Lldb-commits] [lldb] [lldb] Relax check for breakpoint site in Unwind/windows-unaligned-x86_64.test (PR #115318)

2024-11-18 Thread Stefan Gränitz via lldb-commits
weliveindetail wrote: @mstorsjo Any thoughts/concerns about this? https://github.com/llvm/llvm-project/pull/115318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Convert ThreadPlanStack's mutex to a shared mutex. (PR #116438)

2024-11-18 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. +1 to what Jonas said :) https://github.com/llvm/llvm-project/pull/116438 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Fix for Process attach (PR #116587)

2024-11-18 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX closed https://github.com/llvm/llvm-project/pull/116587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add timed callbacks to the MainLoop class (PR #112895)

2024-11-18 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/112895 >From bf20e3125480268373a42c678bbf62c8c312227f Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 16 Oct 2024 17:34:53 +0200 Subject: [PATCH] [lldb] Add timed callbacks to the MainLoop class The motivating u

[Lldb-commits] [lldb] [lldb/DWARF] s/DWARFRangeList/llvm::DWARFAddressRangeVector (PR #116620)

2024-11-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The main difference is that the llvm class (just a std::vector in disguise) is not sorted. It turns out this isn't an issue because the callers either: - ignore the range list; - convert it to a different forma

[Lldb-commits] [lldb] [lldb/DWARF] s/DWARFRangeList/llvm::DWARFAddressRangeVector (PR #116620)

2024-11-18 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/116620 The main difference is that the llvm class (just a std::vector in disguise) is not sorted. It turns out this isn't an issue because the callers either: - ignore the range list; - convert it to a different format

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-11-18 Thread Michael Buch via lldb-commits
Michael137 wrote: > LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` > running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 > "test". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/59/builds/8268 > > Here is the relev

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: The string manipulations are fairly crude. I tried to suggest replacements using more advanced features. I'm not sure I got all of the offset calculations right, but I think they demonstrate the general idea, which is: - using existing printf features (e.g.

[Lldb-commits] [lldb] c25c6c3 - [lldb] Unify/improve MainLoop signal handling (#115197)

2024-11-18 Thread via lldb-commits
Author: Pavel Labath Date: 2024-11-18T12:44:06+01:00 New Revision: c25c6c32494c8d1038438b6208d42ba40f25270e URL: https://github.com/llvm/llvm-project/commit/c25c6c32494c8d1038438b6208d42ba40f25270e DIFF: https://github.com/llvm/llvm-project/commit/c25c6c32494c8d1038438b6208d42ba40f25270e.diff

[Lldb-commits] [lldb] [lldb] Unify/improve MainLoop signal handling (PR #115197)

2024-11-18 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/115197 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Unify/improve MainLoop signal handling (PR #115197)

2024-11-18 Thread Michał Górny via lldb-commits
@@ -295,26 +243,17 @@ MainLoopPosix::RegisterSignal(int signo, const Callback &callback, sigaddset(&new_action.sa_mask, signo); sigset_t old_set; - g_signal_flags[signo] = 0; + // Set signal info before installing the signal handler! + g_signal_info[signo].pipe_fd = m_

[Lldb-commits] [lldb] [lldb] Unify/improve MainLoop signal handling (PR #115197)

2024-11-18 Thread Michał Górny via lldb-commits
https://github.com/mgorny approved this pull request. https://github.com/llvm/llvm-project/pull/115197 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Infer MSInheritanceAttr for CXXRecordDecl with DWARF on Windows (PR #115177)

2024-11-18 Thread Stefan Gränitz via lldb-commits
weliveindetail wrote: Yes, the pre-merge test failure wasn't related to my change, but still I prefer landing patches with a green light :) Was out of office last week. Let's give it one last try. https://github.com/llvm/llvm-project/pull/115177 ___

[Lldb-commits] [lldb] [lldb] Add logging for missing `.dwo` files (PR #116436)

2024-11-18 Thread Pavel Labath via lldb-commits
labath wrote: The error logged above the code you're adding is visible through `image dump separate-debug-info` (and it doesn't require logging to be enabled beforehand). Would that be sufficient? https://github.com/llvm/llvm-project/pull/116436 ___

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -1154,34 +1154,38 @@ class DebugAdaptorServer(DebugCommunication): def __init__( self, executable=None, +launch=True, port=None, +unix_socket=None, init_commands=[], log_file=None, env=None, ):

[Lldb-commits] [lldb] 4e7682b - [lldb] rm DWARFDebugRanges (#116379)

2024-11-18 Thread via lldb-commits
Author: Pavel Labath Date: 2024-11-18T10:21:49+01:00 New Revision: 4e7682b1c47d4bd81acb6bcb028b48a4ebff9117 URL: https://github.com/llvm/llvm-project/commit/4e7682b1c47d4bd81acb6bcb028b48a4ebff9117 DIFF: https://github.com/llvm/llvm-project/commit/4e7682b1c47d4bd81acb6bcb028b48a4ebff9117.diff

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -1196,6 +1200,39 @@ def terminate(self): self.process.wait() self.process = None +@classmethod +def launch( +cls, executable: str, /, port=None, unix_socket=None, log_file=None, env=None +) -> subprocess.Popen: +adaptor_e

[Lldb-commits] [lldb] [lldb] Infer MSInheritanceAttr for CXXRecordDecl with DWARF on Windows (PR #115177)

2024-11-18 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail closed https://github.com/llvm/llvm-project/pull/115177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Infer MSInheritanceAttr for CXXRecordDecl with DWARF on Windows (PR #115177)

2024-11-18 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail updated https://github.com/llvm/llvm-project/pull/115177 From 2c8f5571a4fbe87b50d395fe93f7c4657685e683 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?= Date: Fri, 8 Nov 2024 17:16:20 +0100 Subject: [PATCH] [lldb] Infer MSInheritanceAttr for CXXR

[Lldb-commits] [lldb] [lldb] Unify/improve MainLoop signal handling (PR #115197)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -295,26 +243,17 @@ MainLoopPosix::RegisterSignal(int signo, const Callback &callback, sigaddset(&new_action.sa_mask, signo); sigset_t old_set; - g_signal_flags[signo] = 0; + // Set signal info before installing the signal handler! + g_signal_info[signo].pipe_fd = m_

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -927,12 +927,92 @@ unsigned char Editline::BufferEndCommand(int ch) { static void PrintCompletion(FILE *output_file, llvm::ArrayRef results, -size_t max_len) { +size_t max_completion_length, size_t max_lenght) { ---

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -927,12 +927,92 @@ unsigned char Editline::BufferEndCommand(int ch) { static void PrintCompletion(FILE *output_file, llvm::ArrayRef results, -size_t max_len) { +size_t max_completion_length, size_t max_lenght) { + + constexpr

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -927,12 +927,92 @@ unsigned char Editline::BufferEndCommand(int ch) { static void PrintCompletion(FILE *output_file, llvm::ArrayRef results, -size_t max_len) { +size_t max_completion_length, size_t max_lenght) { + + constexpr

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -927,12 +927,92 @@ unsigned char Editline::BufferEndCommand(int ch) { static void PrintCompletion(FILE *output_file, llvm::ArrayRef results, -size_t max_len) { +size_t max_completion_length, size_t max_lenght) { + + constexpr

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -927,12 +927,92 @@ unsigned char Editline::BufferEndCommand(int ch) { static void PrintCompletion(FILE *output_file, llvm::ArrayRef results, -size_t max_len) { +size_t max_completion_length, size_t max_lenght) { + + constexpr

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -927,12 +927,92 @@ unsigned char Editline::BufferEndCommand(int ch) { static void PrintCompletion(FILE *output_file, llvm::ArrayRef results, -size_t max_len) { +size_t max_completion_length, size_t max_lenght) { + + constexpr

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
@@ -927,12 +927,92 @@ unsigned char Editline::BufferEndCommand(int ch) { static void PrintCompletion(FILE *output_file, llvm::ArrayRef results, -size_t max_len) { +size_t max_completion_length, size_t max_lenght) { + + constexpr

[Lldb-commits] [lldb] [lldb] Improve editline completion formatting (PR #116456)

2024-11-18 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/116456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits