https://github.com/jasonmolenda approved this pull request.
It took me a minute to understand how you were handling the locking of the
dependent file list while iterating across it, but now I see it. You grab the
lock at the beginning of the outer loop, then enqueue all of the
not-yet-process
jasonmolenda wrote:
Looks good to me, thanks for addressing this other bottleneck for launch
startup.
https://github.com/llvm/llvm-project/pull/114507
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114507
>From 9a269fa83cea529f704c9eba339eac9987032155 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 31 Oct 2024 21:42:38 -0700
Subject: [PATCH 1/2] [lldb] Create dependent modules in parallel
MIME-Ve
@@ -1608,9 +1612,28 @@ void Target::SetExecutableModule(ModuleSP &executable_sp,
if (image_module_sp) {
added_modules.AppendIfNeeded(image_module_sp, false);
ObjectFile *objfile = image_module_sp->GetObjectFile();
- if (objfile)
+ i
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff d1b311d7d2258531decaea9556d2e96ce2433817
9a269fa83cea529f704c9eba339eac9987032155 --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Create dependent modules in parallel in Target::SetExecutableModule. This
change was inspired by #110646 which takes the same approach when
attaching. Jason suggested we could use the same approach
JDevlieghere wrote:
CC @DmT021
https://github.com/llvm/llvm-project/pull/114507
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/114507
Create dependent modules in parallel in Target::SetExecutableModule. This
change was inspired by #110646 which takes the same approach when attaching.
Jason suggested we could use the same approach when yo
@@ -4428,6 +4428,15 @@ void TargetProperties::SetDisableSTDIO(bool b) {
const uint32_t idx = ePropertyDisableSTDIO;
SetPropertyAtIndex(idx, b);
}
+std::optional
+TargetProperties::GetLaunchWorkingDirectory() const {
walter-erquinigo wrote:
Yeah, that makes
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/114478
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/114303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jeffreytan81 wrote:
Technical these make sense. Please let me know how to revert a PR (or feel free
to revert for me if I do not have permission).
https://github.com/llvm/llvm-project/pull/113596
___
lldb-commits mailing list
lldb-commits@lists.llvm.
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/114478.diff
1 Files Affected:
- (modified) lldb/source/Commands/CommandObjectDWIMPrint.cpp (+1-1)
``diff
diff --git a/lldb/source/Command
walter-erquinigo wrote:
Sorry, I thought it had been 1 week already. I'll be mindful of that next time.
And yeah, it's natural that the conference slowed things down.
https://github.com/llvm/llvm-project/pull/113521
___
lldb-commits mailing list
lldb-
https://github.com/rnk approved this pull request.
https://github.com/llvm/llvm-project/pull/114303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu`
running on `as-builder-9` while building `lldb` at step 16
"test-check-lldb-api".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/195/builds/449
Here is the relevant piece o
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/114478
None
>From 530e9db082ce2a3140045a1696c4e5c2f85a8f36 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Thu, 31 Oct 2024 15:26:21 -0700
Subject: [PATCH] [lldb] Improve command status when dwim-print has no result
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/114478
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/114478
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/114478
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1810,7 +1813,27 @@
SymbolFileNativePDB::ParseVariablesForCompileUnit(CompileUnit &comp_unit,
VariableList &variables) {
PdbSymUid sym_uid(comp_unit.GetID());
lldbassert(sym_uid.kind() == PdbSymUidKind::Compiland);
- re
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-10-31T15:31:51-07:00
New Revision: cf3464bbb796d492bcd4e764ada945304e0c874f
URL:
https://github.com/llvm/llvm-project/commit/cf3464bbb796d492bcd4e764ada945304e0c874f
DIFF:
https://github.com/llvm/llvm-project/commit/cf3464bbb796d492bcd4e764ada945304e0c874f.d
https://github.com/ZequanWu approved this pull request.
Thanks, this makes testing nativepdb/pdb much easier.
https://github.com/llvm/llvm-project/pull/114455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/114303
>From 215c36a380946a0c8cab63605bd0a9da13e642cd Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Tue, 29 Oct 2024 13:19:50 -0700
Subject: [PATCH 1/3] [lldb][NativePDB] Parse global variables.
---
.../NativePDB/S
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/114469
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/114469.diff
1 Files Affected:
- (modified) lldb/test/API/commands/session/save/TestSessionSave.py (+1)
``diff
diff --git a/lldb/test/A
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/114469
None
>From 9a43932849dba04c11cbed2abcac41a3e64b4e06 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Thu, 31 Oct 2024 14:40:59 -0700
Subject: [PATCH] [lldb] Disable automatically opening editor for
TestSes
@@ -1537,6 +1538,154 @@ static void LoadScriptingResourceForModule(const
ModuleSP &module_sp,
feedback_stream.GetData());
}
+static void ForEachFormatterInModule(
+Module &module, SectionType section_type,
+std::functi
https://github.com/omjavaid approved this pull request.
Looks good to me
https://github.com/llvm/llvm-project/pull/114455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> This might not be the right setting to ask this, but is there a plan to use
> one of the PDB parsers over the other? Would it make sense to add this as an
> option to lldb-test and the like instead of continuing to rely on an
> environment variable?
The goal is to have o
@@ -265,6 +265,7 @@ class SymbolFileNativePDB : public SymbolFileCommon {
// UID for anonymous union and anonymous struct as they don't have entities
in
// pdb debug info.
lldb::user_id_t anonymous_id = LLDB_INVALID_UID - 1;
+ std::optional m_cu_count = 0;
-
@@ -1537,6 +1538,154 @@ static void LoadScriptingResourceForModule(const
ModuleSP &module_sp,
feedback_stream.GetData());
}
+static void ForEachFormatterInModule(
JDevlieghere wrote:
Target seems like a weird
https://github.com/bulbazord approved this pull request.
This looks good to me. Probably want somebody more involved in windows to sign
off though.
This might not be the right setting to ask this, but is there a plan to use one
of the PDB parsers over the other? Would it make sense to add this
@@ -1810,7 +1813,27 @@
SymbolFileNativePDB::ParseVariablesForCompileUnit(CompileUnit &comp_unit,
VariableList &variables) {
PdbSymUid sym_uid(comp_unit.GetID());
lldbassert(sym_uid.kind() == PdbSymUidKind::Compiland);
- re
@@ -888,7 +888,8 @@ VariableSP
SymbolFileNativePDB::CreateGlobalVariable(PdbGlobalSymId var_id) {
CompUnitSP comp_unit;
std::optional modi = m_index->GetModuleIndexForVa(addr);
- if (!modi) {
+ // Some globals has modi points to the linker module, ignore them.
+ if (!m
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Lit allows you to set environment variables for all tests in a directory using
a `lit.local.cfg` file. Do this for the PDB and NativePDB tests.
---
Patch is 28.26 KiB, truncated to 20.00 KiB below,
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/114455
Lit allows you to set environment variables for all tests in a directory using
a `lit.local.cfg` file. Do this for the PDB and NativePDB tests.
>From 3788c30d90499dd9c109b258cae38eb2cb1996a3 Mon Sep 17 00:
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114346
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
First off, it is not the case that the "ValueObject Path Expression" operators
- part of what we're starting to call the DIL (Data Inspection Language) - are
supposed to exactly mirror C++ semantics. Since they reflect all the ways that
a synthetic child provider might presen
@@ -1810,7 +1813,27 @@
SymbolFileNativePDB::ParseVariablesForCompileUnit(CompileUnit &comp_unit,
VariableList &variables) {
PdbSymUid sym_uid(comp_unit.GetID());
lldbassert(sym_uid.kind() == PdbSymUidKind::Compiland);
- re
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/114303
>From 215c36a380946a0c8cab63605bd0a9da13e642cd Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Tue, 29 Oct 2024 13:19:50 -0700
Subject: [PATCH 1/2] [lldb][NativePDB] Parse global variables.
---
.../NativePDB/S
Author: Jonas Devlieghere
Date: 2024-10-31T10:39:48-07:00
New Revision: 88591aa0ca7e4d99da353d49f91ea63e43fb55e0
URL:
https://github.com/llvm/llvm-project/commit/88591aa0ca7e4d99da353d49f91ea63e43fb55e0
DIFF:
https://github.com/llvm/llvm-project/commit/88591aa0ca7e4d99da353d49f91ea63e43fb55e0.d
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From c4ee8ba1f6eff974614c9a98e660d22a1691bdb4 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints
This c
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/113007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-10-31T10:27:41-07:00
New Revision: 42fae38e6ad1433ac0ff1a648dfdcd3fdb981093
URL:
https://github.com/llvm/llvm-project/commit/42fae38e6ad1433ac0ff1a648dfdcd3fdb981093
DIFF:
https://github.com/llvm/llvm-project/commit/42fae38e6ad1433ac0ff1a648dfdcd3fdb981093.d
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/114286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Augusto Noronha
Date: 2024-10-31T09:45:58-07:00
New Revision: d6b90282578f607dc18e23197d9494ebbb899437
URL:
https://github.com/llvm/llvm-project/commit/d6b90282578f607dc18e23197d9494ebbb899437
DIFF:
https://github.com/llvm/llvm-project/commit/d6b90282578f607dc18e23197d9494ebbb899437.dif
adrian-prantl wrote:
Unfortunately older videos are regularly being removed. We should probably
remove the links and add https://developer.apple.com/videos/play/wwdc2024/10198
instead.
https://github.com/llvm/llvm-project/pull/114289
___
lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/114122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
Thanks for the analysis. The other bit that lldb looks at (which is what I
added with the patch this change is the result of) is the DW_AT_call_{file,
line} info in the debug_info part of the DWARF for that function. Before we
ignored that information when setting breakpoint
felipepiovezan wrote:
@vogelsgesang since I don't know if our timezones align, I am going to take the
liberty to click the merge button here to see if we can get the bots green
again!
https://github.com/llvm/llvm-project/pull/114122
___
lldb-commits
Author: Adrian Vogelsgesang
Date: 2024-10-31T09:01:46-07:00
New Revision: 2aed0d9cd3fc8f3c600d59b8b10d10a4466e50c6
URL:
https://github.com/llvm/llvm-project/commit/2aed0d9cd3fc8f3c600d59b8b10d10a4466e50c6
DIFF:
https://github.com/llvm/llvm-project/commit/2aed0d9cd3fc8f3c600d59b8b10d10a4466e50c6
Author: Jonas Devlieghere
Date: 2024-10-31T08:46:35-07:00
New Revision: 9ce0a61bdbf13d4d0f2e13e1bb6e7a4bb9d01858
URL:
https://github.com/llvm/llvm-project/commit/9ce0a61bdbf13d4d0f2e13e1bb6e7a4bb9d01858
DIFF:
https://github.com/llvm/llvm-project/commit/9ce0a61bdbf13d4d0f2e13e1bb6e7a4bb9d01858.d
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114346
>From 2d4b486202194166471ccafd97ff63c399b2e822 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 30 Oct 2024 20:34:04 -0700
Subject: [PATCH 1/2] [lldb] Use PY_VERSION_HEX to simplify conditional
https://github.com/felipepiovezan approved this pull request.
Awesome, thank you!
https://github.com/llvm/llvm-project/pull/114122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> Friendly ping, otherwise I'll merge it in a couple of days
[One week](https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted)
is the *minimum time for a ping* (you pinged after six days). It's not the
*maximum time for a review* (there isn't one).
(Practically spea
@@ -642,6 +649,16 @@ bool
lldb_private::python::SWIGBridge::LLDBSwigPythonCallCommandObject(
pfunc(SWIGBridge::ToSWIGWrapper(std::move(debugger)), PythonString(args),
SWIGBridge::ToSWIGWrapper(exe_ctx_ref_sp), cmd_retobj_arg.obj());
+ if (PyErr_Occurred()) {
+p
Michael137 wrote:
Agree with Pavel.
> When libcxx is linked with a program as an archive of static libraries,
functions that aren't used in the program are omitted.
This really isn't the problem. The tests *want* those symbols to not be present
and make sure that we can find those in the `std`
@@ -592,6 +592,8 @@ void
*lldb_private::python::LLDBSWIGPython_CastPyObjectToSBExecutionContext(PyOb
return sb_ptr;
}
+#include "lldb/Interpreter/CommandReturnObject.h"
labath wrote:
Can we put this some place more reasonable (next to the other includes in
labath wrote:
> Agree with Pavel.
I'm not sure you do :P
>
> > When libcxx is linked with a program as an archive of static libraries,
> > functions that aren't used in the program are omitted.
>
> This really isn't the problem. The tests _want_ those symbols to not be
> present and make sur
@@ -365,18 +365,20 @@ void SymbolFileNativePDB::InitializeObject() {
}
uint32_t SymbolFileNativePDB::CalculateNumCompileUnits() {
+ if (m_cu_count)
+return *m_cu_count;
labath wrote:
`CalculateNumCompileUnits` is wrapped by `GetNumCompileUnits`, which ma
@@ -1810,7 +1813,27 @@
SymbolFileNativePDB::ParseVariablesForCompileUnit(CompileUnit &comp_unit,
VariableList &variables) {
PdbSymUid sym_uid(comp_unit.GetID());
lldbassert(sym_uid.kind() == PdbSymUidKind::Compiland);
- re
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/113787
>From af45bc2e24623d7225d24a4680a28630d67d636e Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 26 Oct 2024 14:34:31 +
Subject: [PATCH 1/5] [lldb-dap] Support column breakpoints
This commi
labath wrote:
> I think the code itself seems fine, especially if Pavel's suggestion shows
> that the test works.
I actually did check that `129440743495415807670381713415221633377` is
`0x61616161616161616161616161616161` (and it seems that the dwarf parser is
robust enough to ignore the extr
labath wrote:
Regarding the vector summary example, it looks like that there's still a lot of
room for improvement there. This is what I get before this patch:
```
(lldb) v v vp vr vpr &v &vp &vr &vpr
(std::vector) v = size=2 {
[0] = 0
[1] = 0
}
(std::vector *) vp = 0x7fffd7b0 size=2
labath wrote:
I can believe that this behavior is undesirable. Like I said, I totally
understand *why* you did this. It's the *how* I have a problem with. I don't
believe the we've sufficiently considered the bigger picture. Why does
`AddressOf` handle references transparently and `Dereference
https://github.com/Michael137 approved this pull request.
LGTM thx!
https://github.com/llvm/llvm-project/pull/114122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
I wish python exposed the linux-style macro to construct an arbitrary version
number (`#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + ((c) > 255 ?
255 : (c)))`) as figuring out what version does `0x030d` refer to is not
compl
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/113787
>From af45bc2e24623d7225d24a4680a28630d67d636e Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 26 Oct 2024 14:34:31 +
Subject: [PATCH 1/4] [lldb-dap] Support column breakpoints
This commi
DavidSpickett wrote:
> process launch -w does not carry the working dir to subsequent launches.
> * Please open an issue for that.
Actually this is not a bug. `process launch` and `run` are two separate (at
least from the user perpsective) ways to run a program.
I think if you should just add
DavidSpickett wrote:
I looked into this. Not sure what the stepping logic goes by but I do see there
is no line table entry for the function call we expect to stop at after the
first stop.
I have cut the cpp down to:
```
1 inline void inline_trivial_1 () __attribute__((always_inline));
2
Author: Muhammad Omair Javaid
Date: 2024-10-31T14:37:32+05:00
New Revision: 3bc58fc7f79a9b0cbf931573cb257344bfeaca1e
URL:
https://github.com/llvm/llvm-project/commit/3bc58fc7f79a9b0cbf931573cb257344bfeaca1e
DIFF:
https://github.com/llvm/llvm-project/commit/3bc58fc7f79a9b0cbf931573cb257344bfeaca
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/114346
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett commented:
Pavel's request so he can approve but looks fine to me. The static assert is a
nice addition.
I see the set home change had to be reverted but I assume you're sorting all
that out yourself.
https://github.com/llvm/llvm-project/pull/114346
__
@@ -47,6 +47,10 @@ static llvm::Expected *g_fcxx_modules_workaround
[[maybe_unused]];
// Include python for non windows machines
#include
+
+// Provide a meaningful diagnostic error if someone tries to compile this file
+// with a version of Python we don't support.
+static_
DavidSpickett wrote:
Also please add a release note to the LLDB section in the llvm release notes
doc. These sort of settings people don't know they could use, until they
realise they exist.
https://github.com/llvm/llvm-project/pull/113521
___
lldb-c
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/113521
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4428,6 +4428,15 @@ void TargetProperties::SetDisableSTDIO(bool b) {
const uint32_t idx = ePropertyDisableSTDIO;
SetPropertyAtIndex(idx, b);
}
+std::optional
+TargetProperties::GetLaunchWorkingDirectory() const {
DavidSpickett wrote:
If it's not used wh
@@ -206,3 +207,70 @@ def test_environment_with_special_char(self):
self.assertEqual(value, evil_var)
process.Continue()
self.assertState(process.GetState(), lldb.eStateExited, PROCESS_EXITED)
+
+def test_target_launch_working_dir_prop(self):
+
@@ -206,3 +207,70 @@ def test_environment_with_special_char(self):
self.assertEqual(value, evil_var)
process.Continue()
self.assertState(process.GetState(), lldb.eStateExited, PROCESS_EXITED)
+
+def test_target_launch_working_dir_prop(self):
+
@@ -201,6 +201,10 @@ let Definition = "target" in {
def DebugUtilityExpression: Property<"debug-utility-expression", "Boolean">,
DefaultFalse,
Desc<"Enable debugging of LLDB-internal utility expressions.">;
+ def LaunchWorkingDir: Property<"launch-working-dir", "Stri
https://github.com/DavidSpickett commented:
I think you already did what I asked for in my comment just now, just docs and
comments to update.
https://github.com/llvm/llvm-project/pull/113521
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
@@ -206,3 +207,70 @@ def test_environment_with_special_char(self):
self.assertEqual(value, evil_var)
process.Continue()
self.assertState(process.GetState(), lldb.eStateExited, PROCESS_EXITED)
+
+def test_target_launch_working_dir_prop(self):
+
@@ -201,6 +201,13 @@ class CommandObjectProcessLaunch : public
CommandObjectProcessLaunchOrAttach {
if (target->GetDisableSTDIO())
m_options.launch_info.GetFlags().Set(eLaunchFlagDisableSTDIO);
+if (!m_options.launch_info.GetWorkingDirectory()) {
---
DavidSpickett wrote:
> Internally we use bazel in a way in which
Even if this way of using it (I have no experience with Bazel myself) is
unusual, I think the pitch for the setting is ok anyway.
https://github.com/llvm/llvm-project/pull/113521
___
ll
DavidSpickett wrote:
> That was just a symptom, but what we want is users not having to specify
> process launch -w at all. We want our users to simply do run and that things
> just work.
We have:
* process launch -w does not carry the working dir to subsequent launches.
* Please open an iss
Author: jimingham
Date: 2024-10-31T09:06:42Z
New Revision: a218f0f354e9df2ce689686be503f3d85fea44f9
URL:
https://github.com/llvm/llvm-project/commit/a218f0f354e9df2ce689686be503f3d85fea44f9
DIFF:
https://github.com/llvm/llvm-project/commit/a218f0f354e9df2ce689686be503f3d85fea44f9.diff
LOG: [ll
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/114295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
There was one somewhere in the text, but of course I can't find it so it was
clearly of little use :)
Is now a good time to remind you @JDevlieghere that these two videos are no
longer available on the Apple site. More than a decade old so it's not that
surprising but may
Author: David Spickett
Date: 2024-10-31T09:08:00Z
New Revision: 7557972884106e6bdaf00eabe1a8cafec861a7fe
URL:
https://github.com/llvm/llvm-project/commit/7557972884106e6bdaf00eabe1a8cafec861a7fe
DIFF:
https://github.com/llvm/llvm-project/commit/7557972884106e6bdaf00eabe1a8cafec861a7fe.diff
LOG
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/114295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
93 matches
Mail list logo
