[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-16 Thread Nikita Popov via lldb-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 255a99c - [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (#80309)

2024-10-16 Thread via lldb-commits
Author: Nikita Popov Date: 2024-10-17T08:48:08+02:00 New Revision: 255a99c29f9fa1a89b03a85a3a73d6f44d03c6c1 URL: https://github.com/llvm/llvm-project/commit/255a99c29f9fa1a89b03a85a3a73d6f44d03c6c1 DIFF: https://github.com/llvm/llvm-project/commit/255a99c29f9fa1a89b03a85a3a73d6f44d03c6c1.diff

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112655)

2024-10-16 Thread Kazu Hirata via lldb-commits
@@ -5324,7 +5324,7 @@ std::string ProcessGDBRemote::HarmonizeThreadIdsForProfileData( std::map::iterator iterator = m_thread_id_to_used_usec_map.find(thread_id); if (iterator != m_thread_id_to_used_usec_map.end()) { - prev_used_usec = m_thr

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112655)

2024-10-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/112655 >From 826b8ad10ef9d24e744aa00298ca380bfcd4c79a Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 16 Oct 2024 06:49:47 -0700 Subject: [PATCH 1/2] [lldb] Avoid repeated map lookups (NFC) --- lldb/sour

[Lldb-commits] [lldb] [lldb] Use Locale to convert between std::wstring and std::string (NFC) (PR #112582)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Looks like this is failing in CI. I'll take a look at this tomorrow. In the meantime I'd still like to merge #112446 and #112276. https://github.com/llvm/llvm-project/pull/112582 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [lldb] [lldb] Disable warning about codecvt_utf8 deprecation (NFC) (PR #112446)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/112446 >From 4c53565414c95ddd49050363d3302452cbb99b27 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 15 Oct 2024 15:19:16 -0700 Subject: [PATCH 1/3] [lldb] Disable warning about codecvt_utf8 deprecati

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112655)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
@@ -5324,7 +5324,7 @@ std::string ProcessGDBRemote::HarmonizeThreadIdsForProfileData( std::map::iterator iterator = m_thread_id_to_used_usec_map.find(thread_id); if (iterator != m_thread_id_to_used_usec_map.end()) { - prev_used_usec = m_thr

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112655)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/112655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112655)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/112655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1b4a173fa41e02eddec9f1cf41324aa4ea8a7fa5 eac4e0b05f6c55dc9621edb3c2ba6b07876b3efb --e

[Lldb-commits] [lldb] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Wanyi (kusmour) Changes When FileAction opens file with write access for lldb stdout/stderr redirect, it doesn't clear the file nor append to the end of the file if it already exists. Instead, it writes from cursor index 0. This function

[Lldb-commits] [lldb] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-16 Thread via lldb-commits
https://github.com/kusmour created https://github.com/llvm/llvm-project/pull/112657 When FileAction opens file with write access for lldb stdout/stderr redirect, it doesn't clear the file nor append to the end of the file if it already exists. Instead, it writes from cursor index 0. This func

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112655)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/112655.diff 1 Files Affected: - (modified) lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp (+1-1) ``diff diff --git a/l

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112655)

2024-10-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/112655 None >From 826b8ad10ef9d24e744aa00298ca380bfcd4c79a Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 16 Oct 2024 06:49:47 -0700 Subject: [PATCH] [lldb] Avoid repeated map lookups (NFC) --- lldb/so

[Lldb-commits] [lldb] [lldb] Improve unwinding for discontinuous functions (PR #111409)

2024-10-16 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: (wrote that update too quickly while running out the door -- I can run the lldb-shell tests both with and without your patch, and they pass. I'm not able to repo the failure the CI bots saw.) https://github.com/llvm/llvm-project/pull/111409

[Lldb-commits] [lldb] [lldb] Improve unwinding for discontinuous functions (PR #111409)

2024-10-16 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I was able to build github main on an Intel mac running the current OS, and the shell tests all pass with it. I had the same difficulty trying to repo a failure with this test with Alex's change, I could never get the failure the CI bots were hitting, but I didn't have the

[Lldb-commits] [lldb] 90767bc - [lldb] Remove more mentions of ASLLogCallback (#112639)

2024-10-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-16T17:33:12-07:00 New Revision: 90767bc41bd69fb4b9ac01a8420ef58bbbaeab7c URL: https://github.com/llvm/llvm-project/commit/90767bc41bd69fb4b9ac01a8420ef58bbbaeab7c DIFF: https://github.com/llvm/llvm-project/commit/90767bc41bd69fb4b9ac01a8420ef58bbbaeab7c.d

[Lldb-commits] [lldb] [lldb] Remove more mentions of ASLLogCallback (PR #112639)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/112639 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove more mentions of ASLLogCallback (PR #112639)

2024-10-16 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. https://github.com/llvm/llvm-project/pull/112639 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove more mentions of ASLLogCallback (PR #112639)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/112639.diff 2 Files Affected: - (modified) lldb/tools/debugserver/source/RNBRemote.cpp (+3-13) - (modified) lldb/tools/debugserver/source

[Lldb-commits] [lldb] [lldb] Remove more mentions of ASLLogCallback (PR #112639)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/112639 None >From 44c697b7621b25505bd9097f5820b813868d4f0f Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 16 Oct 2024 17:29:44 -0700 Subject: [PATCH] [lldb] Remove more mentions of ASLLogCallback --

[Lldb-commits] [lldb] c5c11f3 - [lldb-dap] Creating an API for sending dap events from a script in lldb-dap. (#112384)

2024-10-16 Thread via lldb-commits
Author: John Harrison Date: 2024-10-16T17:19:51-07:00 New Revision: c5c11f340436a88cfc2165f2dcd64e4d63285068 URL: https://github.com/llvm/llvm-project/commit/c5c11f340436a88cfc2165f2dcd64e4d63285068 DIFF: https://github.com/llvm/llvm-project/commit/c5c11f340436a88cfc2165f2dcd64e4d63285068.diff

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-16 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/112384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add SBDebugger:: AddNotificationCallback API (PR #111206)

2024-10-16 Thread via lldb-commits
jimingham wrote: That seems a common enough problem that there should be a more straightforward way to do it than having to barge into the middle of target setup... The SBPlatform already has a "module location callback" that you can hook in to find debug modules in a programmatic way. It a

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-16 Thread John Harrison via lldb-commits
@@ -962,6 +962,68 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger debugger, return true; } +// Sends a DAP event with an optional body. +// +// See +// https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent +bool SendEv

[Lldb-commits] [lldb] [lldb] Don't exit the main loop when in runs out of things to listen on (PR #112565)

2024-10-16 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. https://github.com/llvm/llvm-project/pull/112565 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't exit the main loop when in runs out of things to listen on (PR #112565)

2024-10-16 Thread Jacob Lalonde via lldb-commits
@@ -212,15 +209,14 @@ TEST_F(MainLoopTest, PendingCallbackTrigger) { ASSERT_TRUE(callback2_called); } -// Regression test for assertion failure if a lot of callbacks end up -// being queued after loop exits. -TEST_F(MainLoopTest, PendingCallbackAfterLoopExited) { +TEST_F(Mai

[Lldb-commits] [lldb] [lldb] Don't exit the main loop when in runs out of things to listen on (PR #112565)

2024-10-16 Thread Jacob Lalonde via lldb-commits
@@ -365,10 +365,7 @@ Status MainLoopPosix::Run() { Status error; RunImpl impl(*this); - // run until termination or until we run out of things to listen to - // (m_read_fds will always contain m_trigger_pipe fd, so check for > 1) - while (!m_terminate_request && ---

[Lldb-commits] [lldb] [lldb] Use system c++ lib for LLDB STL tests (PR #112598)

2024-10-16 Thread via lldb-commits
https://github.com/zeroomega closed https://github.com/llvm/llvm-project/pull/112598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8f683b5 - [lldb] Use system c++ lib for LLDB STL tests (#112598)

2024-10-16 Thread via lldb-commits
Author: Haowei Date: 2024-10-16T16:34:02-07:00 New Revision: 8f683b552d7a0cf1bdd93f220e2552f9ea0a6b8d URL: https://github.com/llvm/llvm-project/commit/8f683b552d7a0cf1bdd93f220e2552f9ea0a6b8d DIFF: https://github.com/llvm/llvm-project/commit/8f683b552d7a0cf1bdd93f220e2552f9ea0a6b8d.diff LOG: [

[Lldb-commits] [lldb] [lldb] Use system c++ lib for LLDB STL tests (PR #112598)

2024-10-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM thx! https://github.com/llvm/llvm-project/pull/112598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-16 Thread Adrian Vogelsgesang via lldb-commits
@@ -962,6 +962,68 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger debugger, return true; } +// Sends a DAP event with an optional body. +// +// See +// https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent +bool SendEv

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-16 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/112384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread Jacob Lalonde via lldb-commits
@@ -3895,3 +3924,103 @@ std::optional ObjectFileELF::GetDynamicData() { } return std::nullopt; } + + +std::optional +ObjectFileELF::GetDynsymDataFromDynamic(uint32_t &num_symbols) { + // Every ELF file which represents an executable or shared library has + // mandatory .

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread Jacob Lalonde via lldb-commits
@@ -2990,18 +2992,34 @@ void ObjectFileELF::ParseSymtab(Symtab &lldb_symtab) { // section, nomatter if .symtab was already parsed or not. This is because // minidebuginfo normally removes the .symtab symbols which have their // matching .dynsym counterparts. + bool found

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread Jacob Lalonde via lldb-commits
@@ -3895,3 +3924,103 @@ std::optional ObjectFileELF::GetDynamicData() { } return std::nullopt; } + + +std::optional +ObjectFileELF::GetDynsymDataFromDynamic(uint32_t &num_symbols) { + // Every ELF file which represents an executable or shared library has + // mandatory .

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread Jacob Lalonde via lldb-commits
@@ -44,6 +44,8 @@ #include "llvm/Support/MathExtras.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/MipsABIFlags.h" +#include "lldb/Target/Process.h" + Jlalond wrote: Nit: empty line https://github.com/llvm/llvm-project/pull/112596 __

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/112596 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. I left some comments. All code layout options and comment concerns, otherwise LGTM! https://github.com/llvm/llvm-project/pull/112596 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [lldb] [lldb] Use system c++ lib for LLDB STL tests (PR #112598)

2024-10-16 Thread via lldb-commits
zeroomega wrote: The patch passed all presubmit tests. Can I get a approval to land it? https://github.com/llvm/llvm-project/pull/112598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-16 Thread John Harrison via lldb-commits
@@ -962,6 +962,68 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger debugger, return true; } +// Sends a DAP event with an optional body. +// +// See +// https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent +bool SendEv

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-16 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From af2e73635f85bd56b708e1240ad2c6837b7e449f Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH 1/6] [lldb-dap] Creating an API for sending custom dap events fro

[Lldb-commits] [lldb] Add SBDebugger:: AddNotificationCallback API (PR #111206)

2024-10-16 Thread via lldb-commits
cmtice wrote: > I have wanted to be able to hook into target creation to be able to setup > targets when they get created. It would be also nice to get an event when a > process is not longer being debugged due to process exit or detach. Something I have wanted for a long time is a stop hook j

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-16 Thread Jessica Clarke via lldb-commits
https://github.com/jrtc27 closed https://github.com/llvm/llvm-project/pull/112420 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ad5e2bf - [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (#112420)

2024-10-16 Thread via lldb-commits
Author: Brooks Davis Date: 2024-10-16T20:41:38+01:00 New Revision: ad5e2bf6e934abd9fef39d3b88f40d4f3c1a7d60 URL: https://github.com/llvm/llvm-project/commit/ad5e2bf6e934abd9fef39d3b88f40d4f3c1a7d60 DIFF: https://github.com/llvm/llvm-project/commit/ad5e2bf6e934abd9fef39d3b88f40d4f3c1a7d60.diff

[Lldb-commits] [lldb] [lldb] Lookup static const members in FindGlobalVariables (PR #111859)

2024-10-16 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: > I think we may want to implement this in a slightly different matter: find > the unique definition DIE for the given type (we use that concept when > parsing types) and then search for child inside that -- instead of searching > through all (possibly one per CU) definitions of

[Lldb-commits] [lldb] [lldb] Use system c++ lib for LLDB STL tests (PR #112598)

2024-10-16 Thread via lldb-commits
zeroomega wrote: > I believe we need to just remove all the USE_ variables. The PR that broke > your bots was itself motivated by a breakage due to USE_SYSTEM_STDLIB Done. Test run in progress: https://ci.chromium.org/b/8733895290278713505 https://github.com/llvm/llvm-project/pull/112598 _

[Lldb-commits] [lldb] [lldb] Use system c++ lib for LLDB STL tests (PR #112598)

2024-10-16 Thread via lldb-commits
https://github.com/zeroomega updated https://github.com/llvm/llvm-project/pull/112598 >From 2f2ab10e3712992bab7d4b08fad641d73c2800cb Mon Sep 17 00:00:00 2001 From: Haowei Wu Date: Wed, 16 Oct 2024 11:24:34 -0700 Subject: [PATCH] [lldb] Use system c++ lib for LLDB STL tests This change partiall

[Lldb-commits] [lldb] [lldb] Use system c++ lib for LLDB STL tests (PR #112598)

2024-10-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: I believe we need to just remove all the USE_ variables. The PR that broke your bots was itself motivated by a breakage due to USE_SYSTEM_STDLIB https://github.com/llvm/llvm-project/pull/112598 ___ lldb-commits

[Lldb-commits] [lldb] [lldb] Use system c++ lib for LLDB STL tests (PR #112598)

2024-10-16 Thread via lldb-commits
https://github.com/zeroomega updated https://github.com/llvm/llvm-project/pull/112598 >From fe4fe7395d36a89d6df62c8bf6212cff0f665b9f Mon Sep 17 00:00:00 2001 From: Haowei Wu Date: Wed, 16 Oct 2024 11:24:34 -0700 Subject: [PATCH] [lldb] Use system c++ lib for LLDB STL tests This change partiall

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6558e5615ae9e6af6168b0a363808854fd3f 890d2bcf655a2e1e58b025cc0df7b4e42956e4c6 --e

[Lldb-commits] [lldb] [lldb] Use system c++ lib for LLDB STL tests (PR #112598)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Haowei (zeroomega) Changes This change partially reverts #112357 to avoid test failures on machines which do not have gcc installed. Test run: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci.shadow/lldb-linux-x64/b873389735080

[Lldb-commits] [lldb] [lldb] Use system c++ lib for LLDB STL tests (PR #112598)

2024-10-16 Thread via lldb-commits
https://github.com/zeroomega edited https://github.com/llvm/llvm-project/pull/112598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use system c++ lib for stl libs (PR #112598)

2024-10-16 Thread via lldb-commits
https://github.com/zeroomega created https://github.com/llvm/llvm-project/pull/112598 This change partially reverts #112357 to avoid test failures on machines which do not have gcc installed. Test run: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci.shadow/lldb-linux-x64/b87338973

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Greg Clayton (clayborg) Changes Allow LLDB to parse the dynamic symbol table from an ELF file or memory image in an ELF file that has no section headers. This patch uses the ability to parse the PT_DYNAMIC segment and find the DT_SYMTAB, D

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread Greg Clayton via lldb-commits
https://github.com/clayborg created https://github.com/llvm/llvm-project/pull/112596 Allow LLDB to parse the dynamic symbol table from an ELF file or memory image in an ELF file that has no section headers. This patch uses the ability to parse the PT_DYNAMIC segment and find the DT_SYMTAB, DT_

[Lldb-commits] [lldb] [lldb] Use Locale to convert between std::wstring and std::string (NFC) (PR #112582)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/112582 >From de1a1c4cfb5a8c3fc47194275fcc8fc48b7cbbf9 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 16 Oct 2024 10:06:31 -0700 Subject: [PATCH 1/2] [lldb] Use Locale to convert between std::wstring a

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-10-16 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > I adapted the code from here > > https://github.com/llvm/llvm-project/blob/a62768c427ec1f34d7c3823021a6c5a794709103/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py#L516 > > into `lldbgdbproxy.py`: > ``` > +lldb_server_exe = lldbgdbserverutils

[Lldb-commits] [lldb] [lldb] Narrow scope of -Wno-deprecated-declarations (NFC) (PR #112276)

2024-10-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. 🥳 https://github.com/llvm/llvm-project/pull/112276 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use Locale to convert between std::wstring and std::string (NFC) (PR #112582)

2024-10-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 92ad0397f494a9895385057586cc59a908107f81 de1a1c4cfb5a8c3fc47194275fcc8fc48b7cbbf9 --e

[Lldb-commits] [lldb] [lldb] Disable warning about codecvt_utf8 deprecation (NFC) (PR #112446)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > [this](https://godbolt.org/z/4WsnMvz5G) _might_ be a non-deprecated way of > achieving this, though I'm not entirely sure about its portability (windows > is the main question, but I guess we don't use editline there anyway). I > don't think you have to do that, but it is

[Lldb-commits] [lldb] [lldb] Use Locale to convert between std::wstring and std::string (NFC) (PR #112582)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The codecvt header has been deprecated in C++17. Use locale to convert between std::string and std::wstring in Editline. --- Full diff: https://github.com/llvm/llvm-project/pull/112582.diff 2 File

[Lldb-commits] [lldb] [lldb] Use Locale to convert between std::wstring and std::string (NFC) (PR #112582)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/112582 The codecvt header has been deprecated in C++17. Use locale to convert between std::string and std::wstring in Editline. >From de1a1c4cfb5a8c3fc47194275fcc8fc48b7cbbf9 Mon Sep 17 00:00:00 2001 From: Jonas

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/112466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8046f15 - [lldb] Fix offset calculation when printing diagnostics in multiple ranges (#112466)

2024-10-16 Thread via lldb-commits
Author: Adrian Prantl Date: 2024-10-16T09:46:35-07:00 New Revision: 8046f15dfaaa8726b058a3483175890ca95832af URL: https://github.com/llvm/llvm-project/commit/8046f15dfaaa8726b058a3483175890ca95832af DIFF: https://github.com/llvm/llvm-project/commit/8046f15dfaaa8726b058a3483175890ca95832af.diff

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/112466 >From 433765aeb92179d3dcd422949275bf043661682b Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 15 Oct 2024 20:15:12 -0700 Subject: [PATCH] [lldb] Fix offset calculation when printing diagnostics in

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/112451 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 889e6ad - [lldb] Fix a crash when two diagnostics are on the same column or in … (#112451)

2024-10-16 Thread via lldb-commits
Author: Adrian Prantl Date: 2024-10-16T09:45:39-07:00 New Revision: 889e6ad24b6df4f8d5232d4ecbd8eb492717f1b7 URL: https://github.com/llvm/llvm-project/commit/889e6ad24b6df4f8d5232d4ecbd8eb492717f1b7 DIFF: https://github.com/llvm/llvm-project/commit/889e6ad24b6df4f8d5232d4ecbd8eb492717f1b7.diff

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/112466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/112451 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/112466 >From 7c35b47aa81ee0d2151944eff59c159ea3fd4c5c Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 15 Oct 2024 16:20:33 -0700 Subject: [PATCH 1/2] [lldb] Fix a crash when two diagnostics are on the sam

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/112451 >From 7c35b47aa81ee0d2151944eff59c159ea3fd4c5c Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 15 Oct 2024 16:20:33 -0700 Subject: [PATCH] [lldb] Fix a crash when two diagnostics are on the same c

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-16 Thread Adrian Prantl via lldb-commits
@@ -16,12 +16,36 @@ std::string Render(std::vector details) { } // namespace TEST_F(ErrorDisplayTest, RenderStatus) { - DiagnosticDetail::SourceLocation inline_loc; - inline_loc.in_user_input = true; { +DiagnosticDetail::SourceLocation inline_loc; +inline_loc.in_u

[Lldb-commits] [lldb] [lldb] Don't exit the main loop when in runs out of things to listen on (PR #112565)

2024-10-16 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/112565 >From 8a531630f6b233d83f33740ce9dbbd9b3a778641 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 16 Oct 2024 16:54:06 +0200 Subject: [PATCH 1/3] [lldb] Don't exit the main loop when in runs out of things to

[Lldb-commits] [lldb] [lldb][test] Add test for ASTImporter's name conflict resolution (PR #112566)

2024-10-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f113a66c29b17e4937ff5d0ab67dc087fa6ee27e d8369837a10f0e4750dd6c0f6c6b4467931b5012 --e

[Lldb-commits] [lldb] [lldb][test] Add test for ASTImporter's name conflict resolution (PR #112566)

2024-10-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/112566 >From d8369837a10f0e4750dd6c0f6c6b4467931b5012 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 16 Oct 2024 15:48:47 +0100 Subject: [PATCH 1/2] [lldb][test] Add test for ASTImporter's name conflict res

[Lldb-commits] [lldb] [lldb][test] Add test for ASTImporter's name conflict resolution (PR #112566)

2024-10-16 Thread Michael Buch via lldb-commits
Michael137 wrote: Not sure how to best XFAIL this atm (really want to avoid just skipping it). This currently crashes LLDB. Maybe we could make use of the AST dump, or the expression log.. https://github.com/llvm/llvm-project/pull/112566 ___ lldb-com

[Lldb-commits] [lldb] [lldb] Don't exit the main loop when in runs out of things to listen on (PR #112565)

2024-10-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c01ddbe9166614db8121f5ddd5d7291be454c046 8a531630f6b233d83f33740ce9dbbd9b3a778641 --e

[Lldb-commits] [lldb] [lldb][test] Add test for ASTImporter's name conflict resolution (PR #112566)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This is a reduced test case from a crash we've observed in the past. The assertion that this test triggers is: ``` Assertion failed: ((Pos == ImportedDecls.end() || Pos->second == To) && "Try to import an

[Lldb-commits] [lldb] [lldb][test] Add test for ASTImporter's name conflict resolution (PR #112566)

2024-10-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/112566 This is a reduced test case from a crash we've observed in the past. The assertion that this test triggers is: ``` Assertion failed: ((Pos == ImportedDecls.end() || Pos->second == To) && "Try to import an al

[Lldb-commits] [lldb] [lldb] Don't exit the main loop when in runs out of things to listen on (PR #112565)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This behavior made sense in the beginning as the class was completely single threaded, so if the source count ever reached zero, there was no way to add new ones. In https://reviews.llvm.org/D131160, the class

[Lldb-commits] [lldb] [lldb] Don't exit the main loop when in runs out of things to listen on (PR #112565)

2024-10-16 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/112565 This behavior made sense in the beginning as the class was completely single threaded, so if the source count ever reached zero, there was no way to add new ones. In https://reviews.llvm.org/D131160, the class g

[Lldb-commits] [lldb] [lldb][test] Fix tests Test*FromStdModule where called missing at(0) (PR #112485)

2024-10-16 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/112485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (dlav-sc) Changes This patch adds --platform-available-ports option to the dotest.py script to avoid hardcoded gdb ports in lldb testsuite. Currently, this option could be helpful in GdbRemoteTestCases (e.g. TestLldbGdbServer, TestNo

[Lldb-commits] [lldb] [lldb] Disable warning about codecvt_utf8 deprecation (NFC) (PR #112446)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/112446 >From 4c53565414c95ddd49050363d3302452cbb99b27 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 15 Oct 2024 15:19:16 -0700 Subject: [PATCH 1/2] [lldb] Disable warning about codecvt_utf8 deprecati

[Lldb-commits] [lldb] [lldb][test] Skip Test*FromStdModule tests on Linux for now (PR #112530)

2024-10-16 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/112530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 87f1262 - [lldb][test] Skip Test*FromStdModule tests on Linux for now (#112530)

2024-10-16 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-10-16T17:52:16+04:00 New Revision: 87f126243beb69b8b02e5cd4df762bc8a6f1f8cc URL: https://github.com/llvm/llvm-project/commit/87f126243beb69b8b02e5cd4df762bc8a6f1f8cc DIFF: https://github.com/llvm/llvm-project/commit/87f126243beb69b8b02e5cd4df762bc8a6f1f8cc.dif

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-16 Thread Simon Pilgrim via lldb-commits
@@ -28729,7 +28731,7 @@ static SDValue GenerateFixedLengthSVETBL(SDValue Op, SDValue Op1, SDValue Op2, unsigned BitsPerElt = VTOp1.getVectorElementType().getSizeInBits(); unsigned IndexLen = MinSVESize / BitsPerElt; unsigned ElementsPerVectorReg = VTOp1.getVectorNumEleme

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-16 Thread Simon Pilgrim via lldb-commits
https://github.com/RKSimon edited https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-16 Thread Simon Pilgrim via lldb-commits
https://github.com/RKSimon approved this pull request. LGTM with one minor https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-10-16 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > Since this is quite tricky to debug, and has been a known issue for a while > and (i think) only happens when we built libc++ with debug symbols, I'd be > fine with skipping the test on Linux until we figure out what the root cause > is. Agree. Please see #112530. https://g

[Lldb-commits] [lldb] [lldb][test] Skip Test*FromStdModule tests on Linux for now (PR #112530)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This is the alternative to #98701. See for more details: https://reviews.llvm.org/D139361 https://discourse.llvm.org/t/lldb-test-failures-on-linux/80095 --- Full diff: https://github.com/llvm/llvm-project/

[Lldb-commits] [lldb] [lldb][test] Skip Test*FromStdModule tests on Linux for now (PR #112530)

2024-10-16 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/112530 This is the alternative to #98701. See for more details: https://reviews.llvm.org/D139361 https://discourse.llvm.org/t/lldb-test-failures-on-linux/80095 >From 4bf78a4bc9b37322502dfc9810ddae7c231aa7d1 Mon Sep 17

[Lldb-commits] [lldb] [lldb][test] Explicitly add target triple to no_unique_address Shell tests (PR #112523)

2024-10-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/112523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Explicitly add target triple to no_unique_address Shell tests (PR #112523)

2024-10-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/112523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Explicitly add target triple to no_unique_address Shell tests (PR #112523)

2024-10-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/112523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Explicitly add target triple to no_unique_address Shell tests (PR #112523)

2024-10-16 Thread Michael Buch via lldb-commits
Michael137 wrote: > I'll just note that `%clang_host` is not the host compiler (in the way that I > understand the term). It's the clang we've just built, _configured_ to build > for the (current) host. Ooh I see, I didn't realize that. When would we not want to use `clangxx_host` then? I gue

[Lldb-commits] [lldb] [lldb][test] Explicitly add target triple to no_unique_address Shell tests (PR #112523)

2024-10-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/112523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Move no_unique_address tests to DWARF/x86 (PR #112523)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Follow up to https://github.com/llvm/llvm-project/pull/111902. Makes sure all the `no_unique_address` tests are in the same place and we don't rely on the host compiler. Now that we don't compile with the

[Lldb-commits] [lldb] [lldb][test] Move no_unique_address tests to DWARF/x86 (PR #112523)

2024-10-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/112523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >