[Lldb-commits] [lldb] [lldb][NFC] New names for the two RegisterLocation classes (PR #109611)

2024-09-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes lldb has two RegisterLocation classes that do slightly different things. UnwindPlan::Row::RegisterLocation (new: AbstractRegisterLocation) has a description of how to find a register's value or location

[Lldb-commits] [lldb] [lldb][NFC] New names for the two RegisterLocation classes (PR #109611)

2024-09-22 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/109611 lldb has two RegisterLocation classes that do slightly different things. UnwindPlan::Row::RegisterLocation (new: AbstractRegisterLocation) has a description of how to find a register's value or location, n

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-22 Thread Yingwei Zheng via lldb-commits
dtcxzyw wrote: https://github.com/llvm/llvm-project/blob/62f737f7409b5d2b33c746158c62f14e5bb78aed/llvm/lib/Transforms/Utils/SimplifyCFG.cpp#L6516 We should allow truncations here. ``` ; bin/opt -passes='simplifycfg' reduced.ll -S target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:6

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-22 Thread via lldb-commits
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType( m_fallback.GetFullyQualifiedType(context, callback); } +bool DebugNamesDWARFIndex::SameAsEntryATName( +llvm::StringRef query_name, const DebugNames::Entry &entry) const { + auto maybe_dieoffset = en

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-22 Thread via lldb-commits
@@ -402,6 +420,36 @@ bool DebugNamesDWARFIndex::SameParentChain( return true; } +bool DebugNamesDWARFIndex::WithinParentChain( +llvm::ArrayRef query_parent_names, +llvm::ArrayRef parent_chain) const { + if (parent_chain.size() < query_parent_names.size()) +retur

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-22 Thread via lldb-commits
jeffreytan81 wrote: > > > I'm also not sure where's the " NameEntry> mapping > > > table" you mention in the description. Could you point me to it? > > > > > > @labath, that is the first prototype I tried, but benchmark shows it did > > not improve any performance because the time to build th

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

2024-09-22 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109594 >From d8d611a2d6381a9ae47f49c56a43e6e17cd2559e Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Sun, 22 Sep 2024 21:12:17 + Subject: [PATCH] Fix assert frame recognizer for Ubuntu 22.04 On Ubun

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

2024-09-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes On Ubuntu 22.04, the top-most stack frame is the function `__pthread_kill_implementation`. Add it to the list of detected functions. ``` (lldb) bt * thread #1, name = 'a.out', stop reason = signal

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

2024-09-22 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/109594 On Ubuntu 22.04, the top-most stack frame is the function `__pthread_kill_implementation`. Add it to the list of detected functions. ``` (lldb) bt * thread #1, name = 'a.out', stop reason = signal SIGABRT

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-22 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-22 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. looks great! https://github.com/llvm/llvm-project/pull/109485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Rename `enableDisplayExtendedBacktrace` (PR #109521)

2024-09-22 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/109521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 19ecded - [lldb-dap] Rename `enableDisplayExtendedBacktrace` (#109521)

2024-09-22 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-09-22T19:15:16+02:00 New Revision: 19ecdedcd2b7fb44689ce3cd59a6a078539eef3f URL: https://github.com/llvm/llvm-project/commit/19ecdedcd2b7fb44689ce3cd59a6a078539eef3f DIFF: https://github.com/llvm/llvm-project/commit/19ecdedcd2b7fb44689ce3cd59a6a078539eef3f

[Lldb-commits] [lldb] [lldb-dap] Rename `enableDisplayExtendedBacktrace` (PR #109521)

2024-09-22 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/109521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits