llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `publish-sphinx-docs`
running on `as-worker-4` while building `lldb` at step 5
"build-docs-llvm-html-docs-clang-html-docs-clang-tools-html-docs-lld-html-docs-lldb-html-docs-flang-html-docs-openmp-html-docs-polly-html".
Full det
Author: Lang Hames
Date: 2024-08-28T15:49:40+10:00
New Revision: e6cbea11578f197589801297d22b9b3bc4f1bd10
URL:
https://github.com/llvm/llvm-project/commit/e6cbea11578f197589801297d22b9b3bc4f1bd10
DIFF:
https://github.com/llvm/llvm-project/commit/e6cbea11578f197589801297d22b9b3bc4f1bd10.diff
LO
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building
`lldb` at step 5 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/181/builds/4140
Here is the relevant
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`cross-project-tests-sie-ubuntu-dwarf5` running on `doug-worker-1b` while
building `lldb` at step 5 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/163/builds/4286
Here is the re
Author: Lang Hames
Date: 2024-08-28T15:36:57+10:00
New Revision: 3c5ab5a75a9c8fb87dcb13cdf4207aa975fd6972
URL:
https://github.com/llvm/llvm-project/commit/3c5ab5a75a9c8fb87dcb13cdf4207aa975fd6972
DIFF:
https://github.com/llvm/llvm-project/commit/3c5ab5a75a9c8fb87dcb13cdf4207aa975fd6972.diff
LO
https://github.com/lhames closed
https://github.com/llvm/llvm-project/pull/106034
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
Let me know what you think of my idea to always just show the load address of
any SBValue. I think that is the best for LLDB, but I am open to opinions.
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lld
clayborg wrote:
Don't let us hold this patch up if returning the the original patch that fixes
things makes things work if you can't easily get the same functionality from
this version of the patch. Will one part of this patch work with the new stuff
and the other part not? If so, maybe we all
DmT021 wrote:
Nope, `LoadAddressResolver` has its own logic about `eSymbolTypeUndefined` that
doesn't match `FindBestGlobalDataSymbol`. And it breaks
`TestWeakSymbols.TestWeakSymbolsInExpressions.test_weak_symbol_in_expr`.
At this point, I think it would be wiser to return to the original patch
https://github.com/AlexeyMerzlyakov edited
https://github.com/llvm/llvm-project/pull/104547
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
AlexeyMerzlyakov wrote:
@DavidSpickett, thank you for the review and sorry for late reply, I've just
returned from the BT w/o an access to my main PC.
Yes, the way to handle the register sets is pretty similar that ARM64 is using
in dynamic model (if I understand it correctly), so all further
DmT021 wrote:
> We should always prefer symbols from the current module first, probably
> external first, then fall back to internal. If we do a search of all modules,
> we should prefer external symbols first and then internal, but only if they
> are unique.
So it's `current module external,
jurahul wrote:
Yeah. For the unbalanced {{ I actually committed a change to fail in
release builds as well by printing an error message as formatv() output.
The only issue with debug only is that many folks build tablegen in release
mode, so those bad uses may not get flagged. But as long as the
clayborg wrote:
> > What happens if we stop preferring the external symbols over internal ones
> > in IRExecutionUnit::FindInSymbols? What tests break?
>
> It looks like there are no failing tests.
We should always prefer symbols from the current module first, probably
external first, then fa
DmT021 wrote:
> What happens if we stop preferring the external symbols over internal ones in
> IRExecutionUnit::FindInSymbols? What tests break?
It looks like there are no failing tests.
https://github.com/llvm/llvm-project/pull/102835
___
lldb-comm
Author: Adrian Prantl
Date: 2024-08-27T17:25:17-07:00
New Revision: 32abe5d49b758edef0f0c19090361a6fe85c4092
URL:
https://github.com/llvm/llvm-project/commit/32abe5d49b758edef0f0c19090361a6fe85c4092
DIFF:
https://github.com/llvm/llvm-project/commit/32abe5d49b758edef0f0c19090361a6fe85c4092.diff
joker-eph wrote:
Having this enabled guarded by NDEBUG seems like a good option. There is
already some things already like this isn't there? I kind of remember that
using imbalanced `{` / `}` pair of something like that was checked only in
assert builds?
https://github.com/llvm/llvm-project/p
Author: Adrian Prantl
Date: 2024-08-27T17:02:49-07:00
New Revision: 6ae657b08d624f9634fa6ebbf5d6fd7a22dc3b4d
URL:
https://github.com/llvm/llvm-project/commit/6ae657b08d624f9634fa6ebbf5d6fd7a22dc3b4d
DIFF:
https://github.com/llvm/llvm-project/commit/6ae657b08d624f9634fa6ebbf5d6fd7a22dc3b4d.diff
Author: Michael Buch
Date: 2024-08-28T00:40:12+01:00
New Revision: 0b1c8fd162aa1be66332d57d7da68416a9acb5ef
URL:
https://github.com/llvm/llvm-project/commit/0b1c8fd162aa1be66332d57d7da68416a9acb5ef
DIFF:
https://github.com/llvm/llvm-project/commit/0b1c8fd162aa1be66332d57d7da68416a9acb5ef.diff
jurahul wrote:
I did 2 sets of experiments, but data wise I am inconclusive if this causes a
real compile time regression.
1. Build MLIR verbose and capture all mlir-gen command lines to a file:
ninja -C build check-mlir --verbose | tee build_log.txt
grep "NATIVE/bin/mlir-tblgen " build_l
@@ -3367,21 +3340,48 @@ lldb::addr_t Process::FindInMemory(lldb::addr_t low,
lldb::addr_t high,
if (region_size < size)
return LLDB_INVALID_ADDRESS;
+ // See "Boyer-Moore string search algorithm".
std::vector bad_char_heuristic(256, size);
- ProcessMemoryIterator i
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/104193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
LGTM. I will let others chime in.
https://github.com/llvm/llvm-project/pull/104193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-08-27T15:52:04-07:00
New Revision: d22bee143f4a1d867103571e23c992bf97f8e4b3
URL:
https://github.com/llvm/llvm-project/commit/d22bee143f4a1d867103571e23c992bf97f8e4b3
DIFF:
https://github.com/llvm/llvm-project/commit/d22bee143f4a1d867103571e23c992bf97f8e4b3.diff
Author: Adrian Prantl
Date: 2024-08-27T15:43:12-07:00
New Revision: de687eac24a3f4bac8b5ff9975f51ab98775f2d5
URL:
https://github.com/llvm/llvm-project/commit/de687eac24a3f4bac8b5ff9975f51ab98775f2d5
DIFF:
https://github.com/llvm/llvm-project/commit/de687eac24a3f4bac8b5ff9975f51ab98775f2d5.diff
slydiman wrote:
> It also reads the memory in bulk (up to 1MB)
```
// Maximum number of bytes read (and buffered). We need to read at least
// `size` bytes for a successful match.
const size_t max_read_size = std::max(size, 0x1);
```
It seems the minimal chunk is 64KB and the maximal chunk m
Author: Adrian Prantl
Date: 2024-08-27T15:25:32-07:00
New Revision: 47667ee23d148458ab1c6f2c4cdce65ec981d766
URL:
https://github.com/llvm/llvm-project/commit/47667ee23d148458ab1c6f2c4cdce65ec981d766
DIFF:
https://github.com/llvm/llvm-project/commit/47667ee23d148458ab1c6f2c4cdce65ec981d766.diff
Author: Adrian Prantl
Date: 2024-08-27T15:25:32-07:00
New Revision: d48b0f8db8b9414e965a2d7c716e8ac44b2f291e
URL:
https://github.com/llvm/llvm-project/commit/d48b0f8db8b9414e965a2d7c716e8ac44b2f291e
DIFF:
https://github.com/llvm/llvm-project/commit/d48b0f8db8b9414e965a2d7c716e8ac44b2f291e.diff
Author: Adrian Prantl
Date: 2024-08-27T14:52:56-07:00
New Revision: f2f78b284bfb9a118b1cc61202456004922e6ac7
URL:
https://github.com/llvm/llvm-project/commit/f2f78b284bfb9a118b1cc61202456004922e6ac7
DIFF:
https://github.com/llvm/llvm-project/commit/f2f78b284bfb9a118b1cc61202456004922e6ac7.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/105890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-08-27T14:50:46-07:00
New Revision: 328029242136950204ce8bf953eb592bff946d30
URL:
https://github.com/llvm/llvm-project/commit/328029242136950204ce8bf953eb592bff946d30
DIFF:
https://github.com/llvm/llvm-project/commit/328029242136950204ce8bf953eb592bff946d30.diff
Author: Adrian Prantl
Date: 2024-08-27T14:48:16-07:00
New Revision: 67eb72725d1e1c7e214c8f1feded99b152b76470
URL:
https://github.com/llvm/llvm-project/commit/67eb72725d1e1c7e214c8f1feded99b152b76470
DIFF:
https://github.com/llvm/llvm-project/commit/67eb72725d1e1c7e214c8f1feded99b152b76470.diff
Author: Adrian Prantl
Date: 2024-08-27T14:40:29-07:00
New Revision: ff2baf0360372a3762218b6db4beaf7117a4
URL:
https://github.com/llvm/llvm-project/commit/ff2baf0360372a3762218b6db4beaf7117a4
DIFF:
https://github.com/llvm/llvm-project/commit/ff2baf0360372a3762218b6db4beaf7117a4.diff
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
4ea2c73886c407d47215484ab6c983ac6189dd14...b0caffa2d427ea94e90186e32125452ab4e1dd1e
lldb
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4ea2c73886c407d47215484ab6c983ac6189dd14
b0caffa2d427ea94e90186e32125452ab4e1dd1e --e
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/106293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jacob Lalonde
Date: 2024-08-27T14:23:00-07:00
New Revision: b9595324846a96dd3443359a62c70cec5aa352b8
URL:
https://github.com/llvm/llvm-project/commit/b9595324846a96dd3443359a62c70cec5aa352b8
DIFF:
https://github.com/llvm/llvm-project/commit/b9595324846a96dd3443359a62c70cec5aa352b8.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Reverts #105442. Due to `TestSkinnyCoreFailing` and root causing of the
failure will likely take longer than EOD.
---
Patch is 29.32 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/106293
Reverts #105442. Due to `TestSkinnyCoreFailing` and root causing of the failure
will likely take longer than EOD.
>From b0caffa2d427ea94e90186e32125452ab4e1dd1e Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Dat
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/106281
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Vogelsgesang
Date: 2024-08-27T22:59:14+02:00
New Revision: fc517973c299d879f0795d37500a7db1f4d63588
URL:
https://github.com/llvm/llvm-project/commit/fc517973c299d879f0795d37500a7db1f4d63588
DIFF:
https://github.com/llvm/llvm-project/commit/fc517973c299d879f0795d37500a7db1f4d63588
joker-eph wrote:
Possible, let's try it there then
https://github.com/llvm/llvm-project/pull/105745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/106281
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
@adrian-prantl It seems I overlooked this test expectation. This hopefully
fixes the build issue in
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/10463/ .
Unfortunately, i was not able to run this test locally, it is marked as
"unsupported" for some r
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/106281
>From b32e85a07ab0e6dc55d28706d50eb84345575bc6 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Tue, 27 Aug 2024 20:14:36 +
Subject: [PATCH] [lldb] Fix test expectation in `TestFrameRecognizer.p
jurahul wrote:
> > compile-time tests with clang for example
>
> I can check. How do I run them?
I am wondering if running mlir-tblgen is a better benchmark, given that
formatv() is widely used there (as opposed to clang), in case this measurement
has to be done manually.
https://github.com/
vogelsgesang wrote:
fixed in #106281
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Vogelsgesang (vogelsgesang)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/106281.diff
1 Files Affected:
- (modified) lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py
(+1-1)
``diff
diff
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/106281
None
>From 2fdc99f2e42ac7bc12449e420ff653fb963cee24 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Tue, 27 Aug 2024 20:14:36 +
Subject: [PATCH] [lldb] Fix test expectation in `TestFrameRecogn
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/105745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/105745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -67,92 +68,123 @@ formatv_object_base::parseReplacementItem(StringRef Spec) {
StringRef Options;
size_t Index = 0;
RepString = RepString.trim();
- if (RepString.consumeInteger(0, Index)) {
-assert(false && "Invalid replacement sequence index!");
-return Replac
Jlalond wrote:
@medismailben Ack
https://github.com/llvm/llvm-project/pull/105442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jurahul wrote:
> compile-time tests with clang for example
I can check. How do I run them?
https://github.com/llvm/llvm-project/pull/105745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
@@ -67,92 +68,123 @@ formatv_object_base::parseReplacementItem(StringRef Spec) {
StringRef Options;
size_t Index = 0;
RepString = RepString.trim();
- if (RepString.consumeInteger(0, Index)) {
-assert(false && "Invalid replacement sequence index!");
-return Replac
https://github.com/joker-eph commented:
Thanks, I'm wondering about the cost of this: what does it do to some
compile-time tests with clang for example?
https://github.com/llvm/llvm-project/pull/105745
___
lldb-commits mailing list
lldb-commits@lists.
@@ -67,92 +68,123 @@ formatv_object_base::parseReplacementItem(StringRef Spec) {
StringRef Options;
size_t Index = 0;
RepString = RepString.trim();
- if (RepString.consumeInteger(0, Index)) {
-assert(false && "Invalid replacement sequence index!");
-return Replac
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/105745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jurahul wrote:
> CI failed FYI.
Yeah, it looked like an unrelated failure. Windows CI passed.
https://github.com/llvm/llvm-project/pull/105745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
jurahul wrote:
Hi all, this is related to
https://discourse.llvm.org/t/adding-argument-count-validation-for-formatv/80876/1
I still have formatv() and formatvv() functions in the code, but only a handful
instances. So, if this looks ok overall, I will go ahead and rename formatvv()
to formatv
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
@llvm/pr-subscribers-lldb
Author: Rahul Joshi (jurahul)
Changes
- Change formatv() to validate that the number of arguments passed matches
number of
replacement fields in the format string.
- When the format string is a literal, this f
joker-eph wrote:
CI failed FYI.
https://github.com/llvm/llvm-project/pull/105745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/105745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-08-27T12:34:54-07:00
New Revision: b24ffa6002424423ee6bd54347db9b0855efbc2a
URL:
https://github.com/llvm/llvm-project/commit/b24ffa6002424423ee6bd54347db9b0855efbc2a
DIFF:
https://github.com/llvm/llvm-project/commit/b24ffa6002424423ee6bd54347db9b0855efbc2a.diff
medismailben wrote:
It looks like this broke lldb macOS bots:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/10450/
@Jlalond can you take a look ? Thanks.
https://github.com/llvm/llvm-project/pull/105442
___
lldb-commits mailing
Author: Adrian Prantl
Date: 2024-08-27T12:28:25-07:00
New Revision: 5e64520dae5dd980bc6db25414edc3a167d8af8f
URL:
https://github.com/llvm/llvm-project/commit/5e64520dae5dd980bc6db25414edc3a167d8af8f
DIFF:
https://github.com/llvm/llvm-project/commit/5e64520dae5dd980bc6db25414edc3a167d8af8f.diff
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib`
running on `gribozavr4` while building `lldb` at step 5 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/60/builds/6005
Here is the relevant piece of the
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/105990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github:
List[PaperInfo]) -> List[Tuple]:
results.append(gh.for_printing())
continue
elif paper.status != gh.status:
-print(f"We found a CSV row and a Github issue with differen
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/106034
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/negril edited
https://github.com/llvm/llvm-project/pull/105990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github:
List[PaperInfo]) -> List[Tuple]:
results.append(gh.for_printing())
continue
elif paper.status != gh.status:
-print(f"We found a CSV row and a Github issue with differen
Author: Adrian Prantl
Date: 2024-08-27T11:04:54-07:00
New Revision: c349ded7e61f3611ea54fa712e54b16c4c317a6b
URL:
https://github.com/llvm/llvm-project/commit/c349ded7e61f3611ea54fa712e54b16c4c317a6b
DIFF:
https://github.com/llvm/llvm-project/commit/c349ded7e61f3611ea54fa712e54b16c4c317a6b.diff
@@ -305,7 +307,9 @@ def test_frame_recognizer_target_specific(self):
self.expect(
"frame recognizer list",
-substrs=["recognizer.MyFrameRecognizer, module a.out, symbol bar"],
+substrs=[
+"recognizer.MyFrameRecognizer
adrian-prantl wrote:
Looks like this is failing on the Darwin bot:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/10463/
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
Author: Adrian Prantl
Date: 2024-08-27T11:00:08-07:00
New Revision: d1d8edf50449accf7896620afc0249af91354d17
URL:
https://github.com/llvm/llvm-project/commit/d1d8edf50449accf7896620afc0249af91354d17
DIFF:
https://github.com/llvm/llvm-project/commit/d1d8edf50449accf7896620afc0249af91354d17.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/106163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/105890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
This is great. It's something I've wanted since the first day I started working
on LLDB. We've made a lot of progress in this direction so it's great to see
that we've reached a point where we can make this actually happen.
https://g
@@ -37,10 +37,10 @@ class raw_ostream;
using namespace lldb;
using namespace lldb_private;
-Status::Status() : m_string() {}
+Status::Status() {}
-Status::Status(ValueType err, ErrorType type)
-: m_code(err), m_type(type), m_string() {}
+Status::Status(ValueType err, Err
clayborg wrote:
My concerns are addressed, thanks @adrian-prantl
https://github.com/llvm/llvm-project/pull/106163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
I haven't reviewed every single file but the ones I did look at look
straightforward and correct. The changes to `Status` itself I feel positively
about. I agree with the direction that this takes `Status` in.
https://github.com/llvm/llv
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Vogelsgesang
Date: 2024-08-27T19:15:42+02:00
New Revision: dd060bdede8edec18ad5ca122e15cc24a821e3fe
URL:
https://github.com/llvm/llvm-project/commit/dd060bdede8edec18ad5ca122e15cc24a821e3fe
DIFF:
https://github.com/llvm/llvm-project/commit/dd060bdede8edec18ad5ca122e15cc24a821e3fe
adrian-prantl wrote:
Updated all the non-Darwin plugins. I believe to have addressed all outstanding
comments now.
https://github.com/llvm/llvm-project/pull/106163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github:
List[PaperInfo]) -> List[Tuple]:
results.append(gh.for_printing())
continue
elif paper.status != gh.status:
-print(f"We found a CSV row and a Github issue with differen
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/7] [lldb-dap] Add frame recognizers for libc++ `std:
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/106034
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/7] [lldb-dap] Add frame recognizers for libc++ `std:
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/106157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Langford
Date: 2024-08-27T09:59:17-07:00
New Revision: 384d69fcbbd07941e7eb1899435e4d56d0469637
URL:
https://github.com/llvm/llvm-project/commit/384d69fcbbd07941e7eb1899435e4d56d0469637
DIFF:
https://github.com/llvm/llvm-project/commit/384d69fcbbd07941e7eb1899435e4d56d0469637.diff
jimingham wrote:
That should of course be lldb_private::Error -> lldb_private::Status...
Jim
> On Aug 27, 2024, at 9:48 AM, Jim Ingham ***@***.***> wrote:
>
>>
>>
>>
>>> On Aug 27, 2024, at 8:51 AM, Adrian Prantl ***@***.***> wrote:
>>>
>>>
>>> I like this. I have just two remarks:
>>>
jimingham wrote:
> On Aug 27, 2024, at 8:51 AM, Adrian Prantl ***@***.***> wrote:
>
>
> I like this. I have just two remarks:
>
> it might be better to split this into three steps (add new APIs, port to new
> APIs, remove old APIs), as that will make reverts easier/less disruptive (I
> don
@@ -305,7 +307,9 @@ def test_frame_recognizer_target_specific(self):
self.expect(
"frame recognizer list",
-substrs=["recognizer.MyFrameRecognizer, module a.out, symbol bar"],
+substrs=[
+"recognizer.MyFrameRecognizer
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/6] [lldb-dap] Add frame recognizers for libc++ `std:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6e44cb3ccb822085cd2f35c63daa60395dda26f2
37febe79c170b0575051b5fb24a9db3208721b0b --e
@@ -15,7 +15,7 @@ def __init__(self, exe_ctx: lldb.SBExecutionContext, args:
lldb.SBStructuredData
def read_memory_at_address(
self, addr: int, size: int, error: lldb.SBError
) -> lldb.SBData:
-error.SetErrorString("This is an invalid scripted process!"
adrian-prantl wrote:
> I like this. I have just two remarks:
>
> * it might be better to split this into three steps (add new APIs, port to
> new APIs, remove old APIs), as that will make reverts easier/less disruptive
> (I don't know how much we can trust pre-commit CI these days, but I would
adrian-prantl wrote:
> I worry the assert will kill the LLDB library and cause issues. Can we add a
> temporary setting that can override this in case it does cause crashes? I
> really don't want LLDB crashing if we can help it. It will be hard to test
> all of the error code paths that can ha
@@ -56,19 +56,41 @@ class Status {
///
/// \param[in] type
/// The type for \a err.
- explicit Status(ValueType err,
- lldb::ErrorType type = lldb::eErrorTypeGeneric);
+ explicit Status(ValueType err, lldb::ErrorType type =
lldb::eErrorTypeGeneric,
1 - 100 of 129 matches
Mail list logo
