https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/98845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/7] [lldb] progressive progress reporting for darwin
kernel
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
These changes aim to support cross-compilation build on Windows host for Linux
target for API tests execution. They're not final: changes will follow for
refactoring and adjustments to make all tes
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/99266
These changes aim to support cross-compilation build on Windows host for Linux
target for API tests execution. They're not final: changes will follow for
refactoring and adjustments to make all tests pass.
C
dlav-sc wrote:
> Agreed, this fix is correct, thanks for the PR. The register numbering in the
> UnwindPlan can be any eRegisterKind, but it does need to be self consistent,
> and this was not. Do you have permissions to merge this PR? I can do that for
> you if not.
Thanks for the review. I
@@ -633,171 +613,142 @@ StopInfoSP
StopInfoMachException::CreateStopReasonWithMachException(
}
break;
+ // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code]
+ //
+ // Instruction step:
+ // [6, 1, 0]
+ // Intel KDP [6, 3, ??]
+ // armv7 [6, 0x102, ] Sa
@@ -633,171 +613,142 @@ StopInfoSP
StopInfoMachException::CreateStopReasonWithMachException(
}
break;
+ // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code]
+ //
+ // Instruction step:
+ // [6, 1, 0]
+ // Intel KDP [6, 3, ??]
+ // armv7 [6, 0x102, ] Sa
@@ -34,6 +34,8 @@ def check_first_register_readable(test_case):
test_case.expect("register read r0", substrs=["r0 = 0x"])
elif arch in ["powerpc64le"]:
test_case.expect("register read r0", substrs=["r0 = 0x"])
+elif arch in ["rv64gc"]:
d
@@ -2545,6 +2546,11 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec
&file_spec,
ModuleSP module_sp(new Module(file_spec, ArchSpec()));
if (module_sp) {
Status error;
+std::unique_ptr progress_up;
+if (!GetCoreFile())
jasonmolenda wrote
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/98403
>From 4752adac6b8d39512bbfb46726205ceb2301d1c2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 9 Jul 2024 13:30:46 -0700
Subject: [PATCH 1/4] Create CoreDumpOption class, and SB equivalent
---
lldb/incl
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/98845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/98845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2545,6 +2546,11 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec
&file_spec,
ModuleSP module_sp(new Module(file_spec, ArchSpec()));
if (module_sp) {
Status error;
+std::unique_ptr progress_up;
+if (!GetCoreFile())
clayborg wrote:
`
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/6] [lldb] progressive progress reporting for darwin
kernel
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff efde640cdfede834fa79e0eea69f82fb769d6beb
e3c60eea579d3948156ec5d16f0f429700e8112b --e
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/5] [lldb] progressive progress reporting for darwin
kernel
@@ -2545,6 +2546,11 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec
&file_spec,
ModuleSP module_sp(new Module(file_spec, ArchSpec()));
if (module_sp) {
Status error;
+std::unique_ptr progress_up;
+if (!GetCoreFile())
jasonmolenda wrote
@@ -195,20 +196,40 @@ ModuleSP DynamicLoader::LoadBinaryWithUUIDAndAddress(
Target &target = process->GetTarget();
Status error;
+ StreamString prog_str;
+ if (!name.empty()) {
+prog_str << name.str() << " ";
+ }
+ if (uuid.IsValid())
+prog_str << uuid.GetAsStr
@@ -2545,6 +2546,11 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec
&file_spec,
ModuleSP module_sp(new Module(file_spec, ArchSpec()));
if (module_sp) {
Status error;
+std::unique_ptr progress_up;
+if (!GetCoreFile())
clayborg wrote:
M
jasonmolenda wrote:
I don't think this change is correct, or I don't understand what it is trying
to do.
When we're connected to a stub that can allocate memory in the target, none of
this code is executed. So lldb-server/debugserver will not hit this.
We send `qMemoryRegionInfo` packets to
https://github.com/jasonmolenda approved this pull request.
Agreed, this fix is correct, thanks for the PR. The register numbering in the
UnwindPlan can be any eRegisterKind, but it does need to be self consistent,
and this was not. Do you have permissions to merge this PR? I can do that for
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/4] [lldb] progressive progress reporting for darwin
kernel
@@ -191,9 +191,7 @@ class PluginManager {
GetObjectFileCreateMemoryCallbackForPluginName(llvm::StringRef name);
static Status SaveCore(const lldb::ProcessSP &process_sp,
- const FileSpec &outfile,
- lldb::SaveCoreStyle &core_
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/98361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Zequan Wu
Date: 2024-07-16T16:22:31-04:00
New Revision: b7b77b0fe878d5620b042818cf527267521e51f5
URL:
https://github.com/llvm/llvm-project/commit/b7b77b0fe878d5620b042818cf527267521e51f5
DIFF:
https://github.com/llvm/llvm-project/commit/b7b77b0fe878d5620b042818cf527267521e51f5.diff
LOG
ZequanWu wrote:
This buildkite seems got stuck somehow, no logging at all:
https://buildkite.com/llvm-project/github-pull-requests/builds/81790#0190bca9-bde7-4fad-8478-9dffd4f669f7.
Will merge without waiting for it to finish.
https://github.com/llvm/llvm-project/pull/98361
___
https://github.com/clayborg commented:
LGTM
https://github.com/llvm/llvm-project/pull/99043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/99043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -643,9 +644,9 @@ bool
ABISysV_riscv::CreateFunctionEntryUnwindPlan(UnwindPlan &unwind_plan) {
unwind_plan.Clear();
unwind_plan.SetRegisterKind(eRegisterKindDWARF);
clayborg wrote:
Since we specify here that we are using DWARF registers, then the change
@@ -1659,128 +1709,56 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
default_accessibility = eAccessPrivate;
}
- if (attrs.byte_size && *attrs.byte_size == 0 && attrs.name &&
- !decl_die.HasChildren() && cu_language == eLanguageTypeObjC) {
@@ -1595,49 +1627,67 @@ DWARFASTParserClang::GetCPlusPlusQualifiedName(const
DWARFDIE &die) {
if (qualified_name.empty())
qualified_name.append("::");
- qualified_name.append(name);
+ qualified_name.append(unique_typename.GetCString());
qualified_name.append(GetDIE
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/98361
>From 37b6878b9125c314c75053f7d5b0ba520111e9a3 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Tue, 9 Jul 2024 15:28:19 -0700
Subject: [PATCH 1/5] Reapply [lldb][DWARF] Delay struct/class/union definition
DIE se
slydiman wrote:
The best solution is simply to remove all code related to gdb port mapping,
because it does not work at all. Try to run `netstat` and you will be surprised.
1. lldb-server in gdbserver mode completely ignores the port from the url
`tcp://[hostname]:port`. It binds to port 0 and
walter-erquinigo wrote:
@kevinfrei , I'm glad I can be of help to you! Let me know if you want me to
try out your next iteration of this PR on my device.
https://github.com/llvm/llvm-project/pull/98344
___
lldb-commits mailing list
lldb-commits@lists.
kevinfrei wrote:
> @kevinfrei , I'm so sorry to tell you that I have reverted this patch. The
> revert commit is
> [27b2f4f](https://github.com/llvm/llvm-project/commit/27b2f4f861b8aeeabc4eb1a97649062de8fa3992)
> and I left some notes there, which I also copy here:
>
> The patch #98344 causes
slydiman wrote:
> Did you consider making `AllowPort(0)` do nothing?
GetNextAvailablePort() returns 0 in case of the empty map. LaunchGDBServer()
does not update the map with the pid if the port is 0. So 0 is a special value
which means `any`. Adding 0 to a map causes an unexpected behavior.
@@ -34,6 +34,8 @@ def check_first_register_readable(test_case):
test_case.expect("register read r0", substrs=["r0 = 0x"])
elif arch in ["powerpc64le"]:
test_case.expect("register read r0", substrs=["r0 = 0x"])
+elif arch in ["rv64gc"]:
D
@@ -34,6 +34,8 @@ def check_first_register_readable(test_case):
test_case.expect("register read r0", substrs=["r0 = 0x"])
elif arch in ["powerpc64le"]:
test_case.expect("register read r0", substrs=["r0 = 0x"])
+elif arch in ["rv64gc"]:
D
DavidSpickett wrote:
The other ABI plugins use the dwarf indexes and I guess that has to be the case
because the unwind plan's type is dwarf. Adding @jasonmolenda just in case
there's anything more to it.
https://github.com/llvm/llvm-project/pull/99043
_
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/99043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Is this something specific to risc-v or simply uncovered by testing against a
certain risc-v target? Just wondering why we haven't had to do this before now.
https://github.com/llvm/llvm-project/pull/99045
___
lldb-commits mailing
https://github.com/labath commented:
I'm wondering if there's a more fundamental fix to be made here. Like perhaps
treating treating any allocatable SHT_NOBITS section as ZeroFill.
Basically to add `case SHT_NOBITS: if (H.sh_flags & SHF_ALLOC) return
eSectionTypeZeroFill;` to `GetSectionType`
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/98690
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vladislav Dzhidzhoev
Date: 2024-07-16T15:21:06+02:00
New Revision: 139df36d89bd731b5180be3cac2b58d4b2082368
URL:
https://github.com/llvm/llvm-project/commit/139df36d89bd731b5180be3cac2b58d4b2082368
DIFF:
https://github.com/llvm/llvm-project/commit/139df36d89bd731b5180be3cac2b58d4b208236
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/99012
>From 242f78b67d6d6ef125b72c9c797fb2686cce280d Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 10 Jul 2024 15:37:45 +0100
Subject: [PATCH 1/3] [WIP][lldb][test] Add a new __compressed_pair layout to
li
Author: David Spickett
Date: 2024-07-16T13:08:04+01:00
New Revision: d4a89af5a8c52191797bed5ff7ff40a85435d3a0
URL:
https://github.com/llvm/llvm-project/commit/d4a89af5a8c52191797bed5ff7ff40a85435d3a0
DIFF:
https://github.com/llvm/llvm-project/commit/d4a89af5a8c52191797bed5ff7ff40a85435d3a0.diff
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/99012
>From 242f78b67d6d6ef125b72c9c797fb2686cce280d Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 10 Jul 2024 15:37:45 +0100
Subject: [PATCH 1/2] [WIP][lldb][test] Add a new __compressed_pair layout to
li
@@ -1659,128 +1709,56 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
default_accessibility = eAccessPrivate;
}
- if (attrs.byte_size && *attrs.byte_size == 0 && attrs.name &&
- !decl_die.HasChildren() && cu_language == eLanguageTypeObjC) {
@@ -1595,49 +1627,67 @@ DWARFASTParserClang::GetCPlusPlusQualifiedName(const
DWARFDIE &die) {
if (qualified_name.empty())
qualified_name.append("::");
- qualified_name.append(name);
+ qualified_name.append(unique_typename.GetCString());
qualified_name.append(GetDIE
https://github.com/Michael137 approved this pull request.
I like where we ended up with this. LGTM (with two minor nits)
https://github.com/llvm/llvm-project/pull/98361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/98361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@kendalharland Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/96687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kendal Harland
Date: 2024-07-16T12:59:08+02:00
New Revision: 2ea4a03c0f1be6dd11428e4c6eb840b745116ca2
URL:
https://github.com/llvm/llvm-project/commit/2ea4a03c0f1be6dd11428e4c6eb840b745116ca2
DIFF:
https://github.com/llvm/llvm-project/commit/2ea4a03c0f1be6dd11428e4c6eb840b745116ca2.diff
@@ -10,9 +10,10 @@
class TestDAP_stepInTargets(lldbdap_testcase.DAPTestCaseBase):
-@skipIf(
-archs=no_match(["x86_64"])
-) # InstructionControlFlowKind for ARM is not supported yet.
+@skipIf
+# InstructionControlFlowKind for ARM is not supported yet.
@@ -1595,49 +1627,67 @@ DWARFASTParserClang::GetCPlusPlusQualifiedName(const
DWARFDIE &die) {
if (qualified_name.empty())
qualified_name.append("::");
- qualified_name.append(name);
+ qualified_name.append(unique_typename.GetCString());
qualified_name.append(GetDIE
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
Looks good. Third time's the charm.
https://github.com/llvm/llvm-project/pull/98361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
DavidSpickett wrote:
Did you consider making `AllowPort(0)` do nothing?
My guess is that this port dance is complicated enough as it is, and
`AllowPort(0)` doing nothing would be more implicit behaviour we have to pick
apart later.
https://github.com/llvm/llvm-project/pull/98833
_
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/98690
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
27d961dab3caa89a78e68af094ddc8365d97dc91...242f78b67d6d6ef125b72c9c797fb2686cce280d
lldb
@@ -183,31 +183,40 @@ template
class basic_string {
};
};
+#if COMPRESSED_PAIR_REV == 0
std::__lldb::__compressed_pair<__rep, allocator_type> __r_;
+#define __R_ __r_
Michael137 wrote:
Probably more readable if I just replaced all the `__r_.first()
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/99012
This is a follow-up to https://github.com/llvm/llvm-project/pull/98330 for the
upcoming `__compressed_pair` refactor in
https://github.com/llvm/llvm-project/issues/93069
This patch just adds the 2 new copies
Author: David Spickett
Date: 2024-07-16T09:46:40Z
New Revision: 078cb7a4a07582a39ecd2f2fba9e9b1add9ebff3
URL:
https://github.com/llvm/llvm-project/commit/078cb7a4a07582a39ecd2f2fba9e9b1add9ebff3
DIFF:
https://github.com/llvm/llvm-project/commit/078cb7a4a07582a39ecd2f2fba9e9b1add9ebff3.diff
LOG
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/98829
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/90075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ita-sc
Date: 2024-07-16T10:03:42+01:00
New Revision: a1ffabc403d4ce55ab2e665511b0b68a16d4850b
URL:
https://github.com/llvm/llvm-project/commit/a1ffabc403d4ce55ab2e665511b0b68a16d4850b
DIFF:
https://github.com/llvm/llvm-project/commit/a1ffabc403d4ce55ab2e665511b0b68a16d4850b.diff
LOG: [
72 matches
Mail list logo
