[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -791,26 +807,101 @@ void MinidumpFileBuilder::AddLinuxFileStreams( size_t size = memory_buffer->getBufferSize(); if (size == 0) continue; - AddDirectory(stream, size); + error = AddDirectory(stream, size); + if (error.Fail()) +retur

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -791,26 +807,101 @@ void MinidumpFileBuilder::AddLinuxFileStreams( size_t size = memory_buffer->getBufferSize(); if (size == 0) continue; - AddDirectory(stream, size); + error = AddDirectory(stream, size); + if (error.Fail()) +retur

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -20,25 +20,98 @@ #include "lldb/Target/RegisterContext.h" #include "lldb/Target/StopInfo.h" #include "lldb/Target/ThreadList.h" +#include "lldb/Utility/DataBufferHeap.h" #include "lldb/Utility/DataExtractor.h" #include "lldb/Utility/LLDBLog.h" #include "lldb/Utility/Log.h

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -791,26 +807,101 @@ void MinidumpFileBuilder::AddLinuxFileStreams( size_t size = memory_buffer->getBufferSize(); if (size == 0) continue; - AddDirectory(stream, size); + error = AddDirectory(stream, size); + if (error.Fail()) +retur

[Lldb-commits] [lldb] [lldb] Fix the semantics of SupportFile equivalence (PR #95606)

2024-06-17 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > > Thanks for the overwhelming support :-) > > I hate to ruin a party, but I don't think this is a good use of `operator==`, > precisely because it does not define an equivalence relation (it's not > transitive). Might I suggest named function instead? `IsCompatible` ? Th

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/95586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

2024-06-17 Thread via lldb-commits
https://github.com/thetruestblue updated https://github.com/llvm/llvm-project/pull/95586 >From db161e5c87eecbd5607f78e7afd00af183aa415c Mon Sep 17 00:00:00 2001 From: Blue Gaston Date: Fri, 14 Jun 2024 12:53:27 -0400 Subject: [PATCH 1/2] [LLDB] Don't cache module sp when Activate() fails. Curr

[Lldb-commits] [lldb] [lldb] Suppress unsupported language warning for assembly (PR #95871)

2024-06-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/95871 >From 7956f02f180d9e7593e2ddaa2ed376ec926a6825 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 17 Jun 2024 17:41:03 -0700 Subject: [PATCH 1/2] [lldb] Suppress unsupported language warning for ass

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -1425,8 +1425,21 @@ let Command = "statistics dump" in { Desc<"Dump the total possible debug info statistics. " "Force loading all the debug information if not yet loaded, and collect " "statistics with those.">; + def statistics_dump_targets: Option<"targets",

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -29,6 +29,9 @@ struct OptionArgParser { static bool ToBoolean(llvm::StringRef s, bool fail_value, bool *success_ptr); + static bool ToBoolean(llvm::StringRef option_name, llvm::StringRef option_arg, +bool fail_value, Status &error); + --

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -76,13 +77,22 @@ class CommandObjectStatsDump : public CommandObjectParsed { m_all_targets = true; break; case 's': -m_stats_options.summary_only = true; +m_stats_options.SetSummaryOnly(true); break; case 'f': -m_

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -1425,8 +1425,21 @@ let Command = "statistics dump" in { Desc<"Dump the total possible debug info statistics. " "Force loading all the debug information if not yet loaded, and collect " "statistics with those.">; + def statistics_dump_targets: Option<"targets",

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -76,13 +77,22 @@ class CommandObjectStatsDump : public CommandObjectParsed { m_all_targets = true; break; case 's': -m_stats_options.summary_only = true; +m_stats_options.SetSummaryOnly(true); break; case 'f': -m_

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -76,13 +77,22 @@ class CommandObjectStatsDump : public CommandObjectParsed { m_all_targets = true; break; case 's': -m_stats_options.summary_only = true; +m_stats_options.SetSummaryOnly(true); break; case 'f': -m_

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -25,6 +25,15 @@ class LLDB_API SBStatisticsOptions { void SetSummaryOnly(bool b); bool GetSummaryOnly(); + void SetIncludeTargets(bool b); + bool GetIncludeTargets() const; + + void SetIncludeModules(bool b); + bool GetIncludeModules() const; + + void SetIncludeTra

[Lldb-commits] [lldb] [lldb] Suppress unsupported language warning for assembly (PR #95871)

2024-06-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/95871 >From 7956f02f180d9e7593e2ddaa2ed376ec926a6825 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 17 Jun 2024 17:41:03 -0700 Subject: [PATCH] [lldb] Suppress unsupported language warning for assembl

[Lldb-commits] [lldb] [lldb] Suppress unsupported language warning for assembly (PR #95871)

2024-06-17 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > LGTM but all the formatting changes are a bit distracting, would be nice to > be have them in a separate commit. Oh yeah, that wasn't intentional, must be trailing whitespace. Let me fix that. https://github.com/llvm/llvm-project/pull/95871 ___

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { Status error; size_t bytes_written; - bytes_written = header_size; - error = core_file->Write(&header, bytes_written); - if (error.Fail() || bytes_written != header_size) { -if

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { Status error; size_t bytes_written; - bytes_written = header_size; - error = core_file->Write(&header, bytes_written); - if (error.Fail() || bytes_written != header_size) { -if

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -791,26 +805,99 @@ void MinidumpFileBuilder::AddLinuxFileStreams( size_t size = memory_buffer->getBufferSize(); if (size == 0) continue; - AddDirectory(stream, size); + error = AddDirectory(stream, size); + if (error.Fail()) +return

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { Status error; size_t bytes_written; - bytes_written = header_size; - error = core_file->Write(&header, bytes_written); - if (error.Fail() || bytes_written != header_size) { -if

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -480,71 +559,64 @@ class ArchThreadContexts { } }; -// Function returns start and size of the memory region that contains -// memory location pointed to by the current stack pointer. -llvm::Expected> -findStackHelper(const lldb::ProcessSP &process_sp, uint64_t rsp) { - M

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { Status error; size_t bytes_written; - bytes_written = header_size; - error = core_file->Write(&header, bytes_written); - if (error.Fail() || bytes_written != header_size) { -if

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { Status error; size_t bytes_written; - bytes_written = header_size; - error = core_file->Write(&header, bytes_written); - if (error.Fail() || bytes_written != header_size) { -if

[Lldb-commits] [lldb] [lldb] Suppress unsupported language warning for assembly (PR #95871)

2024-06-17 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM but all the formatting changes are a bit distracting, would be nice to be have them in a separate commit. https://github.com/llvm/llvm-project/pull/95871 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [lldb] Suppress unsupported language warning for assembly (PR #95871)

2024-06-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The following warning is technically correct, but pretty much useless, since there aren't any frame variables that we'd expect the debugger to understand. > This version of LLDB has no plugin for th

[Lldb-commits] [lldb] [lldb] Suppress unsupported language warning for assembly (PR #95871)

2024-06-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/95871 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Suppress unsupported language warning for assembly (PR #95871)

2024-06-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/95871 The following warning is technically correct, but pretty much useless, since there aren't any frame variables that we'd expect the debugger to understand. This version of LLDB has no plugin for the langua

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { return error; } -size_t MinidumpFileBuilder::GetDirectoriesNum() const { - return m_directories.size(); +static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) { +

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { Status error; size_t bytes_written; - bytes_written = header_size; - error = core_file->Write(&header, bytes_written); - if (error.Fail() || bytes_written != header_size) { -if

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { Status error; size_t bytes_written; - bytes_written = header_size; - error = core_file->Write(&header, bytes_written); - if (error.Fail() || bytes_written != header_size) { -if

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -791,26 +805,99 @@ void MinidumpFileBuilder::AddLinuxFileStreams( size_t size = memory_buffer->getBufferSize(); if (size == 0) continue; - AddDirectory(stream, size); + error = AddDirectory(stream, size); + if (error.Fail()) +return

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { return error; } -size_t MinidumpFileBuilder::GetDirectoriesNum() const { - return m_directories.size(); +static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) { +

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -480,71 +559,64 @@ class ArchThreadContexts { } }; -// Function returns start and size of the memory region that contains -// memory location pointed to by the current stack pointer. -llvm::Expected> -findStackHelper(const lldb::ProcessSP &process_sp, uint64_t rsp) { - M

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -791,26 +805,99 @@ void MinidumpFileBuilder::AddLinuxFileStreams( size_t size = memory_buffer->getBufferSize(); if (size == 0) continue; - AddDirectory(stream, size); + error = AddDirectory(stream, size); + if (error.Fail()) +return

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { return error; } -size_t MinidumpFileBuilder::GetDirectoriesNum() const { - return m_directories.size(); +static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) { +

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -791,26 +805,99 @@ void MinidumpFileBuilder::AddLinuxFileStreams( size_t size = memory_buffer->getBufferSize(); if (size == 0) continue; - AddDirectory(stream, size); + error = AddDirectory(stream, size); + if (error.Fail()) +return

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Greg Clayton via lldb-commits
@@ -20,25 +20,96 @@ #include "lldb/Target/RegisterContext.h" #include "lldb/Target/StopInfo.h" #include "lldb/Target/ThreadList.h" +#include "lldb/Utility/DataBufferHeap.h" #include "lldb/Utility/DataExtractor.h" #include "lldb/Utility/LLDBLog.h" #include "lldb/Utility/Log.h

[Lldb-commits] [clang] [lldb] [clang][lldb] Don't assert structure layout correctness for layouts provided by LLDB (PR #93809)

2024-06-17 Thread Eli Friedman via lldb-commits
efriedma-quic wrote: That would mean if someone wrote `struct Empty {}; struct Z { Empty a,b,c; }`, we'd lower it to `{ [3 x i8] }` instead of `{%Empty, %Empty, %Empty}`, which is a bit ugly. Other than that, sure, I guess we could do that. https://github.com/llvm/llvm-project/pull/93809

[Lldb-commits] [clang] [lldb] [clang][lldb] Don't assert structure layout correctness for layouts provided by LLDB (PR #93809)

2024-06-17 Thread David Blaikie via lldb-commits
dwblaikie wrote: > Oh, in this particular case, the issue isn't the computed datasize, it's that > FieldDecl::isZeroSize() returns the wrong result. If that's the case, maybe > we can just change FieldDecl::isZeroSize() to say the field is zero size? So > essentially, we pretend all empty fiel

[Lldb-commits] [clang] [lldb] [clang][lldb] Don't assert structure layout correctness for layouts provided by LLDB (PR #93809)

2024-06-17 Thread Eli Friedman via lldb-commits
efriedma-quic wrote: Oh, in this particular case, the issue isn't the computed datasize, it's that FieldDecl::isZeroSize() returns the wrong result. If that's the case, maybe we can just change FieldDecl::isZeroSize() to say the field is zero size? So essentially, we pretend all empty field

[Lldb-commits] [lldb] Convert ValueObject::Dump() to return llvm::Error() (NFCish) (PR #95857)

2024-06-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 6c17f1cabdee3399feceb478921a8369bde18b16...7e3d1420a941431de223098ee153d2d4c63cfbfc lldb/

[Lldb-commits] [lldb] 0041582 - [lldb] Fix Python interpreter workaround (attempt #2)

2024-06-17 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-17T15:15:28-07:00 New Revision: 0041582b6ca137ad04e26985a87a1ae45fb0f0bb URL: https://github.com/llvm/llvm-project/commit/0041582b6ca137ad04e26985a87a1ae45fb0f0bb DIFF: https://github.com/llvm/llvm-project/commit/0041582b6ca137ad04e26985a87a1ae45fb0f0bb.d

[Lldb-commits] [lldb] Convert ValueObject::Dump() to return llvm::Error() (NFCish) (PR #95857)

2024-06-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes This change by itself has no measurable effect on the LLDB testsuite. I'm making it in preparation for threading through more errors in the Swift language plugin. --- Patch is 20.56 KiB, truncated to

[Lldb-commits] [lldb] Convert ValueObject::Dump() to return llvm::Error() (NFCish) (PR #95857)

2024-06-17 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/95857 This change by itself has no measurable effect on the LLDB testsuite. I'm making it in preparation for threading through more errors in the Swift language plugin. >From 7e3d1420a941431de223098ee153d2d4c63

[Lldb-commits] [lldb] 6c17f1c - Fix comments in ValueObjectPrinter.h (NFC)

2024-06-17 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-06-17T15:11:33-07:00 New Revision: 6c17f1cabdee3399feceb478921a8369bde18b16 URL: https://github.com/llvm/llvm-project/commit/6c17f1cabdee3399feceb478921a8369bde18b16 DIFF: https://github.com/llvm/llvm-project/commit/6c17f1cabdee3399feceb478921a8369bde18b16.diff

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Jacob Lalonde via lldb-commits
@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { return error; } -size_t MinidumpFileBuilder::GetDirectoriesNum() const { - return m_directories.size(); +static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) { +

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-06-17 Thread Andy Hippo via lldb-commits
@@ -0,0 +1,165 @@ +(* LLDB Debug Expressions, a subset of C++ *) +(* Insired by https://www.nongnu.org/hcb *) + +expression = assignment_expression ; + +assignment_expression = conditional_expression +logical_or_expression assignment_operator assignment_ex

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-06-17 Thread Andy Hippo via lldb-commits
@@ -0,0 +1,165 @@ +(* LLDB Debug Expressions, a subset of C++ *) +(* Insired by https://www.nongnu.org/hcb *) + +expression = assignment_expression ; + +assignment_expression = conditional_expression +logical_or_expression assignment_operator assignment_ex

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-06-17 Thread Andy Hippo via lldb-commits
@@ -0,0 +1,165 @@ +(* LLDB Debug Expressions, a subset of C++ *) +(* Insired by https://www.nongnu.org/hcb *) + +expression = assignment_expression ; + +assignment_expression = conditional_expression +logical_or_expression assignment_operator assignment_ex

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-06-17 Thread Andy Hippo via lldb-commits
@@ -0,0 +1,165 @@ +(* LLDB Debug Expressions, a subset of C++ *) +(* Insired by https://www.nongnu.org/hcb *) + +expression = assignment_expression ; + +assignment_expression = conditional_expression +logical_or_expression assignment_operator assignment_ex

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add/change options in `statistics dump` to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add/change options in "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 01/15] Add --targets and --modules option to statistics dump --- lldb

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 01/14] Add --targets and --modules option to statistics dump --- lldb

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread Will Hawkins via lldb-commits
@@ -131,11 +131,48 @@ struct ConstStringStats { }; struct StatisticsOptions { - bool summary_only = false; - bool load_all_debug_info = false; - bool include_targets = true; - bool include_modules = true; - bool include_transcript = true; +public: + void SetSummaryOnly(b

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread Will Hawkins via lldb-commits
https://github.com/hawkinsw edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread Will Hawkins via lldb-commits
https://github.com/hawkinsw commented: Thank you for doing this work! I hope that these little bits help! https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread Will Hawkins via lldb-commits
@@ -131,11 +131,48 @@ struct ConstStringStats { }; struct StatisticsOptions { - bool summary_only = false; - bool load_all_debug_info = false; - bool include_targets = true; - bool include_modules = true; - bool include_transcript = true; +public: + void SetSummaryOnly(b

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread Will Hawkins via lldb-commits
@@ -131,11 +131,48 @@ struct ConstStringStats { }; struct StatisticsOptions { - bool summary_only = false; - bool load_all_debug_info = false; - bool include_targets = true; - bool include_modules = true; - bool include_transcript = true; +public: + void SetSummaryOnly(b

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

2024-06-17 Thread Artem Yurchenko via lldb-commits
https://github.com/temyurchenko edited https://github.com/llvm/llvm-project/pull/93913 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

2024-06-17 Thread Artem Yurchenko via lldb-commits
@@ -2380,7 +2380,7 @@ FunctionDecl *Sema::CreateBuiltin(IdentifierInfo *II, QualType Type, } FunctionDecl *New = FunctionDecl::Create(Context, Parent, Loc, Loc, II, Type, - /*TInfo=*/nullptr, SC_Extern, +

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

2024-06-17 Thread Artem Yurchenko via lldb-commits
@@ -2380,7 +2380,7 @@ FunctionDecl *Sema::CreateBuiltin(IdentifierInfo *II, QualType Type, } FunctionDecl *New = FunctionDecl::Create(Context, Parent, Loc, Loc, II, Type, - /*TInfo=*/nullptr, SC_Extern, +

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

2024-06-17 Thread Aaron Ballman via lldb-commits
@@ -2380,7 +2380,7 @@ FunctionDecl *Sema::CreateBuiltin(IdentifierInfo *II, QualType Type, } FunctionDecl *New = FunctionDecl::Create(Context, Parent, Loc, Loc, II, Type, - /*TInfo=*/nullptr, SC_Extern, +

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

2024-06-17 Thread Artem Yurchenko via lldb-commits
https://github.com/temyurchenko updated https://github.com/llvm/llvm-project/pull/93913 >From 410c7ba9fb7667dabdfbc48fdbda427401ca8df0 Mon Sep 17 00:00:00 2001 From: Artem Yurchenko <44875844+temyurche...@users.noreply.github.com> Date: Thu, 30 May 2024 16:18:47 -0400 Subject: [PATCH 1/3] [clang

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

2024-06-17 Thread Artem Yurchenko via lldb-commits
@@ -576,13 +576,19 @@ template static bool isFirstInExternCContext(T *D) { return First->isInExternCContext(); } -static bool isSingleLineLanguageLinkage(const Decl &D) { - if (const auto *SD = dyn_cast(D.getDeclContext())) +static bool isUnbracedLanguageLinkage(const Dec

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

2024-06-17 Thread Artem Yurchenko via lldb-commits
@@ -2380,7 +2380,7 @@ FunctionDecl *Sema::CreateBuiltin(IdentifierInfo *II, QualType Type, } FunctionDecl *New = FunctionDecl::Create(Context, Parent, Loc, Loc, II, Type, - /*TInfo=*/nullptr, SC_Extern, +

[Lldb-commits] [lldb] [WIP][lldb] Use forward decls with redeclared definitions instead of minimal import for records (PR #95100)

2024-06-17 Thread David Blaikie via lldb-commits
dwblaikie wrote: > Good question, I haven't dug into the modules import mechanism yet, but if > this is true, then that could give us an opportunity to introduce a "lazy > method loading" mechanism on the ExternalASTSource that would fit both LLDB > and modules? Will try to confirm this (unles

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

2024-06-17 Thread Aaron Ballman via lldb-commits
@@ -6286,7 +6286,7 @@ static FunctionDecl *rewriteBuiltinFunctionDecl(Sema *Sema, ASTContext &Context, FunctionDecl *OverloadDecl = FunctionDecl::Create( Context, Parent, FDecl->getLocation(), FDecl->getLocation(), FDecl->getIdentifier(), OverloadTy, - /*TIn

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

2024-06-17 Thread Aaron Ballman via lldb-commits
@@ -2380,7 +2380,7 @@ FunctionDecl *Sema::CreateBuiltin(IdentifierInfo *II, QualType Type, } FunctionDecl *New = FunctionDecl::Create(Context, Parent, Loc, Loc, II, Type, - /*TInfo=*/nullptr, SC_Extern, +

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

2024-06-17 Thread Aaron Ballman via lldb-commits
@@ -576,13 +576,19 @@ template static bool isFirstInExternCContext(T *D) { return First->isInExternCContext(); } -static bool isSingleLineLanguageLinkage(const Decl &D) { - if (const auto *SD = dyn_cast(D.getDeclContext())) +static bool isUnbracedLanguageLinkage(const Dec

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

2024-06-17 Thread Greg Clayton via lldb-commits
clayborg wrote: > > But we won't want a CU index back if we have a `DW_IDX_type_unit` that is a > > local type unit. Makes no sense to return a CUOffset from such entries. > > Can you elaborate on that? I believe it doesn't make sense to you, but I just > don't see the logic behind it. In part

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
@@ -133,7 +133,9 @@ struct ConstStringStats { struct StatisticsOptions { bool summary_only = false; bool load_all_debug_info = false; - bool include_transcript = false; + bool include_targets = true; + bool include_modules = true; royitaqi wrote: Right

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

2024-06-17 Thread Pavel Labath via lldb-commits
labath wrote: > But we won't want a CU index back if we have a `DW_IDX_type_unit` that is a > local type unit. Makes no sense to return a CUOffset from such entries. Can you elaborate on that? I believe it doesn't make sense to you, but I just don't see the logic behind it. In particular I don

[Lldb-commits] [lldb] [LLDB] Add an assert to verify sign_bit_pos is within the valid range (NFC) (PR #95678)

2024-06-17 Thread Florian Mayer via lldb-commits
https://github.com/fmayer edited https://github.com/llvm/llvm-project/pull/95678 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add an assert to verify sign_bit_pos is within the valid range (NFC) (PR #95678)

2024-06-17 Thread Florian Mayer via lldb-commits
https://github.com/fmayer edited https://github.com/llvm/llvm-project/pull/95678 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add an assert to verify sign_bit_pos is within the valid range (NFC) (PR #95678)

2024-06-17 Thread Florian Mayer via lldb-commits
@@ -745,26 +745,25 @@ Status Scalar::SetValueFromData(const DataExtractor &data, bool Scalar::SignExtend(uint32_t sign_bit_pos) { const uint32_t max_bit_pos = GetByteSize() * 8; + assert(sign_bit_pos < max_bit_pos); - if (sign_bit_pos < max_bit_pos) { -switch (m_type

[Lldb-commits] [lldb] [LLDB] Remove the redundent increment of 'properties' variable (PR #95675)

2024-06-17 Thread Alex Langford via lldb-commits
https://github.com/bulbazord requested changes to this pull request. I think you can probably just remove the check for `properties` value entirely. This is the first property that may be printed, so it will never be greater than 0. I think this will work: ``` stream.Printf(" ( arch="); ``` Th

[Lldb-commits] [lldb] a1994ae - [lldb] More reliably detect a virtual environment

2024-06-17 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-17T10:20:58-07:00 New Revision: a1994ae6247ddd0374c7eb3a5d421925117833ab URL: https://github.com/llvm/llvm-project/commit/a1994ae6247ddd0374c7eb3a5d421925117833ab DIFF: https://github.com/llvm/llvm-project/commit/a1994ae6247ddd0374c7eb3a5d421925117833ab.d

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

2024-06-17 Thread Greg Clayton via lldb-commits
clayborg wrote: > My previous message reflected my confusion about the usefulness about the > DW_IDX_cu+DW_IDX_tu combo. Let me try to start over. > > The thing I don't like about this patch is the duplication between > `getForeignTUSkeletonCUOffset` (the new function) and `getCUOffset` (the

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-06-17 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,165 @@ +(* LLDB Debug Expressions, a subset of C++ *) +(* Insired by https://www.nongnu.org/hcb *) + +expression = assignment_expression ; adrian-prantl wrote: Nice to actually have the grammar documented! https://github.com/llvm/llvm-project/pull/957

[Lldb-commits] [lldb] [lldb] Fix incorrect logical operator in 'if' condition check (NFC) (PR #94779)

2024-06-17 Thread Adrian Prantl via lldb-commits
@@ -85,7 +85,7 @@ class ScriptedPythonInterface : virtual public ScriptedInterface { bool has_class_name = !class_name.empty(); bool has_interpreter_dict = !(llvm::StringRef(m_interpreter.GetDictionaryName()).empty()); -if (!has_class_name && !has_interpret

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

2024-06-17 Thread via lldb-commits
cmtice wrote: Just a reminder: Once we complete the work of adding type units to the merged debug_names index, foreign type unit entries will need (and have) DW_IDX_compile_unit values, even in the case without .dwp files, and will need to be handled properly. So that should be kept in mind wh

[Lldb-commits] [lldb] Reapply PR/87550 (again) (PR #95571)

2024-06-17 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/95571 >From 018c7a6052add708e0b0d09b911a904b52199da5 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 11 Jun 2024 14:15:43 -0400 Subject: [PATCH 1/3] Reapply "Reapply PR/87550 (#94625)" This reverts commit adcf33f8

[Lldb-commits] [lldb] [lldb] Remove SupportFile::Update and use the original Checksum (PR #95623)

2024-06-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/95623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3380644 - [lldb] Remove SupportFile::Update and use the original Checksum (#95623)

2024-06-17 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-17T09:37:44-07:00 New Revision: 3380644fb070fd6648e873b1e75022bdfc432f1f URL: https://github.com/llvm/llvm-project/commit/3380644fb070fd6648e873b1e75022bdfc432f1f DIFF: https://github.com/llvm/llvm-project/commit/3380644fb070fd6648e873b1e75022bdfc432f1f.d

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add packaging to testing requirements.txt (PR #95806)

2024-06-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: Anyone reading this who has an active PR that this would fix, you'll need to rebase it to include this change. If you're unlikely to effect lldb's tests anyway, I suggest waiting until review is complete before doing the rebase. https://github.com/llvm/llvm-project/pull/95

[Lldb-commits] [lldb] [lldb] Add packaging to testing requirements.txt (PR #95806)

2024-06-17 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thanks! https://github.com/llvm/llvm-project/pull/95806 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Jacob Lalonde via lldb-commits
@@ -858,10 +923,224 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { return error; } -size_t MinidumpFileBuilder::GetDirectoriesNum() const { - return m_directories.size(); +Status MinidumpFileBuilder::AddMemoryList_32( +const Process::CoreFileMemor

[Lldb-commits] [lldb] [lldb] Add packaging to testing requirements.txt (PR #95806)

2024-06-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/95806 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 13c6638 - [lldb] Add packaging to testing requirements.txt (#95806)

2024-06-17 Thread via lldb-commits
Author: David Spickett Date: 2024-06-17T17:14:06+01:00 New Revision: 13c66388db650d7766b5eb63c09ef84bb5c9e9b8 URL: https://github.com/llvm/llvm-project/commit/13c66388db650d7766b5eb63c09ef84bb5c9e9b8 DIFF: https://github.com/llvm/llvm-project/commit/13c66388db650d7766b5eb63c09ef84bb5c9e9b8.diff

[Lldb-commits] [lldb] [lldb] Add packaging to testing requirements.txt (PR #95806)

2024-06-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/95806 >From 5f50abb6d5f36a35b206b673f10a88635ba54a43 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 17 Jun 2024 15:44:16 + Subject: [PATCH] [lldb] Add packaging to testing requirements.txt To fix C

[Lldb-commits] [lldb] [lldb] Add packaging to testing requirements.txt (PR #95806)

2024-06-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: Still waiting for a Linux CI build, but I assume this would fix the problem so I'm going to merge this now. https://github.com/llvm/llvm-project/pull/95806 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

2024-06-17 Thread Jacob Lalonde via lldb-commits
@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { return error; } -size_t MinidumpFileBuilder::GetDirectoriesNum() const { - return m_directories.size(); +static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) { +

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-17 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/95075 >From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 10 Jun 2024 17:04:11 -0700 Subject: [PATCH 01/13] Add --targets and --modules option to statistics dump --- lldb

  1   2   >